From 271001f523ecdacacebae0b8801ee53e59d45b18 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sat, 21 Jan 2023 09:52:58 +0100 Subject: [PATCH] Feature/remove toggle on allocations page (#1620) * Rename allocationCurrent, remove allocationInvestment * Update changelog --- CHANGELOG.md | 4 + .../src/app/portfolio/portfolio.controller.ts | 2 +- .../src/app/portfolio/portfolio.service.ts | 13 +--- .../allocations/allocations-page.component.ts | 74 +++++-------------- .../allocations/allocations-page.html | 48 ------------ .../allocations/allocations-page.module.ts | 2 - .../app/pages/public/public-page.component.ts | 2 +- apps/client/src/locales/messages.de.xlf | 48 ++++-------- apps/client/src/locales/messages.es.xlf | 48 ++++-------- apps/client/src/locales/messages.fr.xlf | 48 ++++-------- apps/client/src/locales/messages.it.xlf | 48 ++++-------- apps/client/src/locales/messages.nl.xlf | 48 ++++-------- apps/client/src/locales/messages.pt.xlf | 48 ++++-------- apps/client/src/locales/messages.xlf | 46 ++++-------- .../portfolio-position.interface.ts | 3 +- .../portfolio-public-details.interface.ts | 2 +- .../holdings-table.component.html | 6 +- .../holdings-table.component.ts | 2 +- 18 files changed, 144 insertions(+), 348 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 11653d69..1fb5bf69 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +### Changed + +- Removed the toggle _Original Shares_ vs. _Current Shares_ on the allocations page + ### Fixed - Fixed the value of the active (emergency fund) filter in percentage on the allocations page diff --git a/apps/api/src/app/portfolio/portfolio.controller.ts b/apps/api/src/app/portfolio/portfolio.controller.ts index 3a1fa989..7879fa4a 100644 --- a/apps/api/src/app/portfolio/portfolio.controller.ts +++ b/apps/api/src/app/portfolio/portfolio.controller.ts @@ -441,7 +441,7 @@ export class PortfolioController { for (const [symbol, portfolioPosition] of Object.entries(holdings)) { portfolioPublicDetails.holdings[symbol] = { - allocationCurrent: portfolioPosition.value / totalValue, + allocationInPercentage: portfolioPosition.value / totalValue, countries: hasDetails ? portfolioPosition.countries : [], currency: hasDetails ? portfolioPosition.currency : undefined, dataSource: portfolioPosition.dataSource, diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts index 5b7a8386..558a988e 100644 --- a/apps/api/src/app/portfolio/portfolio.service.ts +++ b/apps/api/src/app/portfolio/portfolio.service.ts @@ -537,12 +537,9 @@ export class PortfolioService { holdings[item.symbol] = { markets, - allocationCurrent: filteredValueInBaseCurrency.eq(0) + allocationInPercentage: filteredValueInBaseCurrency.eq(0) ? 0 : value.div(filteredValueInBaseCurrency).toNumber(), - allocationInvestment: item.investment - .div(totalInvestmentInBaseCurrency) - .toNumber(), assetClass: symbolProfile.assetClass, assetSubClass: symbolProfile.assetSubClass, countries: symbolProfile.countries, @@ -1260,12 +1257,9 @@ export class PortfolioService { for (const symbol of Object.keys(cashPositions)) { // Calculate allocations for each currency - cashPositions[symbol].allocationCurrent = value.gt(0) + cashPositions[symbol].allocationInPercentage = value.gt(0) ? new Big(cashPositions[symbol].value).div(value).toNumber() : 0; - cashPositions[symbol].allocationInvestment = investment.gt(0) - ? new Big(cashPositions[symbol].investment).div(investment).toNumber() - : 0; } return cashPositions; @@ -1432,8 +1426,7 @@ export class PortfolioService { }): PortfolioPosition { return { currency, - allocationCurrent: 0, - allocationInvestment: 0, + allocationInPercentage: 0, assetClass: AssetClass.CASH, assetSubClass: AssetClass.CASH, countries: [], diff --git a/apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts b/apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts index 6a5a57c8..910629a3 100644 --- a/apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts +++ b/apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts @@ -18,7 +18,7 @@ import { User } from '@ghostfolio/common/interfaces'; import { hasPermission, permissions } from '@ghostfolio/common/permissions'; -import { Market, ToggleOption } from '@ghostfolio/common/types'; +import { Market } from '@ghostfolio/common/types'; import { translate } from '@ghostfolio/ui/i18n'; import { Account, AssetClass, DataSource } from '@prisma/client'; import { DeviceDetectorService } from 'ngx-device-detector'; @@ -53,11 +53,6 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { public markets: { [key in Market]: { name: string; value: number }; }; - public period = 'current'; - public periodOptions: ToggleOption[] = [ - { label: $localize`Initial`, value: 'original' }, - { label: $localize`Current`, value: 'current' } - ]; public placeholder = ''; public portfolioDetails: PortfolioDetails; public positions: { @@ -146,7 +141,7 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { .subscribe((portfolioDetails) => { this.portfolioDetails = portfolioDetails; - this.initializeAnalysisData(this.period); + this.initializeAnalysisData(); this.isLoading = false; @@ -248,7 +243,7 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { }; } - public initializeAnalysisData(aPeriod: string) { + public initializeAnalysisData() { this.initialize(); for (const [id, { current, name, original }] of Object.entries( @@ -257,7 +252,7 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { this.accounts[id] = { id, name, - value: aPeriod === 'original' ? original : current + value: current }; } @@ -266,18 +261,10 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { )) { let value = 0; - if (aPeriod === 'original') { - if (this.hasImpersonationId) { - value = position.allocationInvestment; - } else { - value = position.investment; - } + if (this.hasImpersonationId) { + value = position.allocationInPercentage; } else { - if (this.hasImpersonationId) { - value = position.allocationCurrent; - } else { - value = position.value; - } + value = position.value; } this.positions[symbol] = { @@ -294,14 +281,11 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { if (position.countries.length > 0) { this.markets.developedMarkets.value += - position.markets.developedMarkets * - (aPeriod === 'original' ? position.investment : position.value); + position.markets.developedMarkets * position.value; this.markets.emergingMarkets.value += - position.markets.emergingMarkets * - (aPeriod === 'original' ? position.investment : position.value); + position.markets.emergingMarkets * position.value; this.markets.otherMarkets.value += - position.markets.otherMarkets * - (aPeriod === 'original' ? position.investment : position.value); + position.markets.otherMarkets * position.value; for (const country of position.countries) { const { code, continent, name, weight } = country; @@ -311,11 +295,7 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { } else { this.continents[continent] = { name: continent, - value: - weight * - (aPeriod === 'original' - ? this.portfolioDetails.holdings[symbol].investment - : this.portfolioDetails.holdings[symbol].value) + value: weight * this.portfolioDetails.holdings[symbol].value }; } @@ -324,24 +304,16 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { } else { this.countries[code] = { name, - value: - weight * - (aPeriod === 'original' - ? this.portfolioDetails.holdings[symbol].investment - : this.portfolioDetails.holdings[symbol].value) + value: weight * this.portfolioDetails.holdings[symbol].value }; } } } else { this.continents[UNKNOWN_KEY].value += - aPeriod === 'original' - ? this.portfolioDetails.holdings[symbol].investment - : this.portfolioDetails.holdings[symbol].value; + this.portfolioDetails.holdings[symbol].value; this.countries[UNKNOWN_KEY].value += - aPeriod === 'original' - ? this.portfolioDetails.holdings[symbol].investment - : this.portfolioDetails.holdings[symbol].value; + this.portfolioDetails.holdings[symbol].value; } if (position.sectors.length > 0) { @@ -353,19 +325,13 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { } else { this.sectors[name] = { name, - value: - weight * - (aPeriod === 'original' - ? this.portfolioDetails.holdings[symbol].investment - : this.portfolioDetails.holdings[symbol].value) + value: weight * this.portfolioDetails.holdings[symbol].value }; } } } else { this.sectors[UNKNOWN_KEY].value += - aPeriod === 'original' - ? this.portfolioDetails.holdings[symbol].investment - : this.portfolioDetails.holdings[symbol].value; + this.portfolioDetails.holdings[symbol].value; } } @@ -373,7 +339,7 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { dataSource: position.dataSource, name: position.name, symbol: prettifySymbol(symbol), - value: aPeriod === 'original' ? position.investment : position.value + value: position.value }; } @@ -398,12 +364,6 @@ export class AllocationsPageComponent implements OnDestroy, OnInit { } } - public onChangePeriod(aValue: string) { - this.period = aValue; - - this.initializeAnalysisData(this.period); - } - public onSymbolChartClicked({ dataSource, symbol }: UniqueAsset) { if (dataSource && symbol) { this.router.navigate([], { diff --git a/apps/client/src/app/pages/portfolio/allocations/allocations-page.html b/apps/client/src/app/pages/portfolio/allocations/allocations-page.html index 78d86d18..5ee7deb3 100644 --- a/apps/client/src/app/pages/portfolio/allocations/allocations-page.html +++ b/apps/client/src/app/pages/portfolio/allocations/allocations-page.html @@ -39,12 +39,6 @@ By Account - - - By Holding - - - - - Nach Währung apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 67 + 61 @@ -1702,7 +1702,7 @@ Nach Anlageklasse apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 96 + 84 @@ -1710,7 +1710,7 @@ Nach Position apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 125 + 107 @@ -1718,7 +1718,7 @@ Nach Sektor apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 154 + 130 @@ -1726,7 +1726,7 @@ Nach Kontinent apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 184 + 154 @@ -1734,7 +1734,7 @@ Nach Land apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 213 + 177 @@ -1742,7 +1742,7 @@ Regionen apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 245 + 203 apps/client/src/app/pages/public/public-page.html @@ -2370,7 +2370,7 @@ Entwickelte Länder apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 272 + 224 apps/client/src/app/pages/public/public-page.html @@ -2382,7 +2382,7 @@ Schwellenländer apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 281 + 233 apps/client/src/app/pages/public/public-page.html @@ -2394,7 +2394,7 @@ Andere Länder apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 290 + 242 apps/client/src/app/pages/public/public-page.html @@ -2417,22 +2417,6 @@ 44 - - Initial - Beginn - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 58 - - - - Current - Aktuell - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 59 - - Monthly Monatlich @@ -2454,7 +2438,7 @@ libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 281 + 283 @@ -2462,7 +2446,7 @@ Verzinsung libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 291 + 293 @@ -2470,7 +2454,7 @@ Ersparnisse libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 301 + 303 @@ -2518,7 +2502,7 @@ Filtern nach Konto oder Tag... apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 137 + 132 apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts @@ -2666,7 +2650,7 @@ Gesamtbetrag apps/client/src/app/components/investment-chart/investment-chart.component.ts - 178 + 181 @@ -2682,7 +2666,7 @@ Sparrate apps/client/src/app/components/investment-chart/investment-chart.component.ts - 242 + 245 diff --git a/apps/client/src/locales/messages.es.xlf b/apps/client/src/locales/messages.es.xlf index 453c70bc..b590c22d 100644 --- a/apps/client/src/locales/messages.es.xlf +++ b/apps/client/src/locales/messages.es.xlf @@ -1695,7 +1695,7 @@ Por divisa apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 67 + 61 @@ -1703,7 +1703,7 @@ Por tipo de activo apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 96 + 84 @@ -1711,7 +1711,7 @@ Por participación apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 125 + 107 @@ -1719,7 +1719,7 @@ Por sector apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 154 + 130 @@ -1727,7 +1727,7 @@ Por continente apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 184 + 154 @@ -1735,7 +1735,7 @@ Por país apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 213 + 177 @@ -1743,7 +1743,7 @@ Regiones apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 245 + 203 apps/client/src/app/pages/public/public-page.html @@ -2295,7 +2295,7 @@ Mercados desarrollados apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 272 + 224 apps/client/src/app/pages/public/public-page.html @@ -2343,7 +2343,7 @@ Otros mercados apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 290 + 242 apps/client/src/app/pages/public/public-page.html @@ -2355,7 +2355,7 @@ Mercados emergentes apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 281 + 233 apps/client/src/app/pages/public/public-page.html @@ -2423,15 +2423,7 @@ Ahorros libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 301 - - - - Initial - Inicial - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 58 + 303 @@ -2439,7 +2431,7 @@ Interés libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 291 + 293 @@ -2455,15 +2447,7 @@ libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 281 - - - - Current - Actual - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 59 + 283 @@ -2511,7 +2495,7 @@ Filtrar por cuenta o etiqueta... apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 137 + 132 apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts @@ -2667,7 +2651,7 @@ Importe total apps/client/src/app/components/investment-chart/investment-chart.component.ts - 178 + 181 @@ -2683,7 +2667,7 @@ Tasa de ahorro apps/client/src/app/components/investment-chart/investment-chart.component.ts - 242 + 245 diff --git a/apps/client/src/locales/messages.fr.xlf b/apps/client/src/locales/messages.fr.xlf index 286de306..a3714609 100644 --- a/apps/client/src/locales/messages.fr.xlf +++ b/apps/client/src/locales/messages.fr.xlf @@ -1218,7 +1218,7 @@ Montant Total apps/client/src/app/components/investment-chart/investment-chart.component.ts - 178 + 181 @@ -1226,7 +1226,7 @@ Taux d'Épargne apps/client/src/app/components/investment-chart/investment-chart.component.ts - 242 + 245 @@ -2209,28 +2209,12 @@ 12 - - Initial - Initial - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 58 - - - - Current - Actuel - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 59 - - Filter by account or tag... Filtrer par compte ou étiquette... apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 137 + 132 apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts @@ -2270,7 +2254,7 @@ Par Devise apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 67 + 61 @@ -2278,7 +2262,7 @@ Par Classe d'Actifs apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 96 + 84 @@ -2286,7 +2270,7 @@ Par Position apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 125 + 107 @@ -2294,7 +2278,7 @@ Par Secteur apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 154 + 130 @@ -2302,7 +2286,7 @@ Par Continent apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 184 + 154 @@ -2310,7 +2294,7 @@ Par Pays apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 213 + 177 @@ -2318,7 +2302,7 @@ Régions apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 245 + 203 apps/client/src/app/pages/public/public-page.html @@ -2330,7 +2314,7 @@ Marchés Développés apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 272 + 224 apps/client/src/app/pages/public/public-page.html @@ -2342,7 +2326,7 @@ Marchés Émergents apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 281 + 233 apps/client/src/app/pages/public/public-page.html @@ -2354,7 +2338,7 @@ Autres marchés apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 290 + 242 apps/client/src/app/pages/public/public-page.html @@ -2390,7 +2374,7 @@ libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 281 + 283 @@ -2790,7 +2774,7 @@ Intérêt libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 291 + 293 @@ -2798,7 +2782,7 @@ Épargne libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 301 + 303 diff --git a/apps/client/src/locales/messages.it.xlf b/apps/client/src/locales/messages.it.xlf index 4c5b0f1e..3556e46d 100644 --- a/apps/client/src/locales/messages.it.xlf +++ b/apps/client/src/locales/messages.it.xlf @@ -1695,7 +1695,7 @@ Per valuta apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 67 + 61 @@ -1703,7 +1703,7 @@ Per asset class apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 96 + 84 @@ -1711,7 +1711,7 @@ Per partecipazione apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 125 + 107 @@ -1719,7 +1719,7 @@ Per settore apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 154 + 130 @@ -1727,7 +1727,7 @@ Per continente apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 184 + 154 @@ -1735,7 +1735,7 @@ Per paese apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 213 + 177 @@ -1743,7 +1743,7 @@ Regioni apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 245 + 203 apps/client/src/app/pages/public/public-page.html @@ -2295,7 +2295,7 @@ Mercati sviluppati apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 272 + 224 apps/client/src/app/pages/public/public-page.html @@ -2343,7 +2343,7 @@ Altri mercati apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 290 + 242 apps/client/src/app/pages/public/public-page.html @@ -2355,7 +2355,7 @@ Mercati emergenti apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 281 + 233 apps/client/src/app/pages/public/public-page.html @@ -2423,15 +2423,7 @@ Risparmio libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 301 - - - - Initial - Iniziale - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 58 + 303 @@ -2439,7 +2431,7 @@ Interesse libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 291 + 293 @@ -2455,15 +2447,7 @@ libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 281 - - - - Current - Attuale - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 59 + 283 @@ -2511,7 +2495,7 @@ Filtra per account o tag... apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 137 + 132 apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts @@ -2667,7 +2651,7 @@ Total Amount apps/client/src/app/components/investment-chart/investment-chart.component.ts - 178 + 181 @@ -2683,7 +2667,7 @@ Tasso di risparmio apps/client/src/app/components/investment-chart/investment-chart.component.ts - 242 + 245 diff --git a/apps/client/src/locales/messages.nl.xlf b/apps/client/src/locales/messages.nl.xlf index 24df5019..2b14a8b8 100644 --- a/apps/client/src/locales/messages.nl.xlf +++ b/apps/client/src/locales/messages.nl.xlf @@ -1694,7 +1694,7 @@ Per valuta apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 67 + 61 @@ -1702,7 +1702,7 @@ Per activaklasse apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 96 + 84 @@ -1710,7 +1710,7 @@ Per participatie apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 125 + 107 @@ -1718,7 +1718,7 @@ Per Sector apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 154 + 130 @@ -1726,7 +1726,7 @@ Per continent apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 184 + 154 @@ -1734,7 +1734,7 @@ Per land apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 213 + 177 @@ -1742,7 +1742,7 @@ Regio's apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 245 + 203 apps/client/src/app/pages/public/public-page.html @@ -2294,7 +2294,7 @@ Ontwikkelde markten apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 272 + 224 apps/client/src/app/pages/public/public-page.html @@ -2342,7 +2342,7 @@ Andere markten apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 290 + 242 apps/client/src/app/pages/public/public-page.html @@ -2354,7 +2354,7 @@ Opkomende markten apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 281 + 233 apps/client/src/app/pages/public/public-page.html @@ -2422,15 +2422,7 @@ Besparingen libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 301 - - - - Initial - Aanvankelijk - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 58 + 303 @@ -2438,7 +2430,7 @@ Rente libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 291 + 293 @@ -2454,15 +2446,7 @@ libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 281 - - - - Current - Huidige - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 59 + 283 @@ -2510,7 +2494,7 @@ Filter op account of tag... apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 137 + 132 apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts @@ -2666,7 +2650,7 @@ Totaalbedrag apps/client/src/app/components/investment-chart/investment-chart.component.ts - 178 + 181 @@ -2682,7 +2666,7 @@ Spaarquote apps/client/src/app/components/investment-chart/investment-chart.component.ts - 242 + 245 diff --git a/apps/client/src/locales/messages.pt.xlf b/apps/client/src/locales/messages.pt.xlf index 7ac806d2..aa0037b3 100644 --- a/apps/client/src/locales/messages.pt.xlf +++ b/apps/client/src/locales/messages.pt.xlf @@ -1114,7 +1114,7 @@ libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 281 + 283 @@ -1122,7 +1122,7 @@ Total Amount apps/client/src/app/components/investment-chart/investment-chart.component.ts - 178 + 181 @@ -1130,7 +1130,7 @@ Savings Rate apps/client/src/app/components/investment-chart/investment-chart.component.ts - 242 + 245 @@ -2153,28 +2153,12 @@ 12 - - Initial - Initial - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 58 - - - - Current - Current - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 59 - - Filter by account or tag... Filter by account or tag... apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 137 + 132 apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts @@ -2214,7 +2198,7 @@ By Currency apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 67 + 61 @@ -2222,7 +2206,7 @@ By Asset Class apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 96 + 84 @@ -2230,7 +2214,7 @@ By Holding apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 125 + 107 @@ -2238,7 +2222,7 @@ By Sector apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 154 + 130 @@ -2246,7 +2230,7 @@ By Continent apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 184 + 154 @@ -2254,7 +2238,7 @@ By Country apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 213 + 177 @@ -2262,7 +2246,7 @@ Regions apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 245 + 203 apps/client/src/app/pages/public/public-page.html @@ -2274,7 +2258,7 @@ Developed Markets apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 272 + 224 apps/client/src/app/pages/public/public-page.html @@ -2286,7 +2270,7 @@ Emerging Markets apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 281 + 233 apps/client/src/app/pages/public/public-page.html @@ -2298,7 +2282,7 @@ Other Markets apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 290 + 242 apps/client/src/app/pages/public/public-page.html @@ -2706,7 +2690,7 @@ Interest libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 291 + 293 @@ -2714,7 +2698,7 @@ Savings libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 301 + 303 diff --git a/apps/client/src/locales/messages.xlf b/apps/client/src/locales/messages.xlf index e7c9e1ac..8270e550 100644 --- a/apps/client/src/locales/messages.xlf +++ b/apps/client/src/locales/messages.xlf @@ -1529,49 +1529,49 @@ By Currency apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 67 + 61 By Asset Class apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 96 + 84 By Holding apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 125 + 107 By Sector apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 154 + 130 By Continent apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 184 + 154 By Country apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 213 + 177 Regions apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 245 + 203 apps/client/src/app/pages/public/public-page.html @@ -2062,7 +2062,7 @@ Developed Markets apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 272 + 224 apps/client/src/app/pages/public/public-page.html @@ -2106,7 +2106,7 @@ Other Markets apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 290 + 242 apps/client/src/app/pages/public/public-page.html @@ -2117,7 +2117,7 @@ Emerging Markets apps/client/src/app/pages/portfolio/allocations/allocations-page.html - 281 + 233 apps/client/src/app/pages/public/public-page.html @@ -2178,21 +2178,14 @@ Savings libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 301 - - - - Initial - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 58 + 303 Interest libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 291 + 293 @@ -2207,14 +2200,7 @@ libs/ui/src/lib/fire-calculator/fire-calculator.component.ts - 281 - - - - Current - - apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 59 + 283 @@ -2256,7 +2242,7 @@ Filter by account or tag... apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts - 137 + 132 apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts @@ -2394,7 +2380,7 @@ Total Amount apps/client/src/app/components/investment-chart/investment-chart.component.ts - 178 + 181 @@ -2408,7 +2394,7 @@ Savings Rate apps/client/src/app/components/investment-chart/investment-chart.component.ts - 242 + 245 diff --git a/libs/common/src/lib/interfaces/portfolio-position.interface.ts b/libs/common/src/lib/interfaces/portfolio-position.interface.ts index c0c0dd6f..126ffdab 100644 --- a/libs/common/src/lib/interfaces/portfolio-position.interface.ts +++ b/libs/common/src/lib/interfaces/portfolio-position.interface.ts @@ -5,8 +5,7 @@ import { Country } from './country.interface'; import { Sector } from './sector.interface'; export interface PortfolioPosition { - allocationCurrent: number; - allocationInvestment: number; + allocationInPercentage: number; assetClass?: AssetClass; assetSubClass?: AssetSubClass | 'CASH'; countries: Country[]; diff --git a/libs/common/src/lib/interfaces/portfolio-public-details.interface.ts b/libs/common/src/lib/interfaces/portfolio-public-details.interface.ts index 52dddae3..2ba22a3d 100644 --- a/libs/common/src/lib/interfaces/portfolio-public-details.interface.ts +++ b/libs/common/src/lib/interfaces/portfolio-public-details.interface.ts @@ -6,7 +6,7 @@ export interface PortfolioPublicDetails { holdings: { [symbol: string]: Pick< PortfolioPosition, - | 'allocationCurrent' + | 'allocationInPercentage' | 'countries' | 'currency' | 'dataSource' diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.html b/libs/ui/src/lib/holdings-table/holdings-table.component.html index cc76cd68..b994ba12 100644 --- a/libs/ui/src/lib/holdings-table/holdings-table.component.html +++ b/libs/ui/src/lib/holdings-table/holdings-table.component.html @@ -3,7 +3,7 @@ class="gf-table w-100" mat-table matSort - matSortActive="allocationCurrent" + matSortActive="allocationInPercentage" matSortDirection="desc" [dataSource]="dataSource" > @@ -85,7 +85,7 @@ - + diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts index 6ff3c1c7..a4aee771 100644 --- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts +++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts @@ -58,7 +58,7 @@ export class HoldingsTableComponent implements OnChanges, OnDestroy, OnInit { this.displayedColumns.push('value'); } - this.displayedColumns.push('allocationCurrent'); + this.displayedColumns.push('allocationInPercentage'); this.displayedColumns.push('performance'); this.isLoading = true;