sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Feature/improve allocations by etf holding for impersonation mode (#3534)

Browse Source 
* Improve allocations by ETF holding for impersonation mode

* Update changelog
This commit is contained in:
Thomas Kaul
2024-07-04 20:25:15 +02:00
committed by GitHub
parent 8227a2d91a
commit 1c9805bb96
4 changed files with 38 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
apps/client/src/app/pages/portfolio/allocations/allocations-page.component.ts
View File

@@ -454,30 +454,22 @@ export class AllocationsPageComponent implements OnDestroy, OnInit {
if (position.holdings.length > 0) {
for (const holding of position.holdings) {
const { name, valueInBaseCurrency } = holding;
const { allocationInPercentage, name, valueInBaseCurrency } =
holding;
if (
!this.hasImpersonationId &&
!this.user.settings.isRestrictedView
) {
if (this.topHoldingsMap[name]?.value) {
this.topHoldingsMap[name].value +=
valueInBaseCurrency *
(isNumber(position.valueInBaseCurrency)
? position.valueInBaseCurrency
: position.valueInPercentage);
} else {
this.topHoldingsMap[name] = {
name,
value:
valueInBaseCurrency *
(isNumber(position.valueInBaseCurrency)
? this.portfolioDetails.holdings[symbol]
.valueInBaseCurrency
: this.portfolioDetails.holdings[symbol]
.valueInPercentage)
};
}
if (this.topHoldingsMap[name]?.value) {
this.topHoldingsMap[name].value += isNumber(valueInBaseCurrency)
? valueInBaseCurrency
: allocationInPercentage *
this.portfolioDetails.holdings[symbol].valueInPercentage;
} else {
this.topHoldingsMap[name] = {
name,
value: isNumber(valueInBaseCurrency)
? valueInBaseCurrency
: allocationInPercentage *
this.portfolioDetails.holdings[symbol].valueInPercentage
};
}
}
}
@@ -562,6 +554,14 @@ export class AllocationsPageComponent implements OnDestroy, OnInit {
this.topHoldings = Object.values(this.topHoldingsMap)
.map(({ name, value }) => {
if (this.hasImpersonationId || this.user.settings.isRestrictedView) {
return {
name,
allocationInPercentage: value,
valueInBaseCurrency: null
};
}
return {
name,
allocationInPercentage:
@@ -570,7 +570,7 @@ export class AllocationsPageComponent implements OnDestroy, OnInit {
};
})
.sort((a, b) => {
return b.valueInBaseCurrency - a.valueInBaseCurrency;
return b.allocationInPercentage - a.allocationInPercentage;
});
if (this.topHoldings.length > MAX_TOP_HOLDINGS) {