sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/fix duplicate currency conversion in account calculations (#771)

Browse Source 
* Fix currency conversion (duplicate)

* Update changelog
This commit is contained in:
Thomas Kaul
2022-03-29 17:47:08 +02:00
committed by GitHub
parent 1a8fc5757a
commit 14773bf1aa
3 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
apps/api/src/app/portfolio/portfolio.service-new.ts
View File

@@ -111,21 +111,21 @@ export class PortfolioServiceNew {
}
}
const value = details.accounts[account.id]?.current ?? 0;
const valueInBaseCurrency = details.accounts[account.id]?.current ?? 0;
const result = {
...account,
transactionCount,
value,
valueInBaseCurrency,
balanceInBaseCurrency: this.exchangeRateDataService.toCurrency(
account.balance,
account.currency,
userCurrency
),
valueInBaseCurrency: this.exchangeRateDataService.toCurrency(
value,
account.currency,
userCurrency
value: this.exchangeRateDataService.toCurrency(
valueInBaseCurrency,
userCurrency,
account.currency
)
};

12
apps/api/src/app/portfolio/portfolio.service.ts
View File

@@ -106,21 +106,21 @@ export class PortfolioService {
}
}
const value = details.accounts[account.id]?.current ?? 0;
const valueInBaseCurrency = details.accounts[account.id]?.current ?? 0;
const result = {
...account,
transactionCount,
value,
valueInBaseCurrency,
balanceInBaseCurrency: this.exchangeRateDataService.toCurrency(
account.balance,
account.currency,
userCurrency
),
valueInBaseCurrency: this.exchangeRateDataService.toCurrency(
value,
account.currency,
userCurrency
value: this.exchangeRateDataService.toCurrency(
valueInBaseCurrency,
userCurrency,
account.currency
)
};