sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/improve error handling in benchmark calculation (#1246)

Browse Source 
* Improve error handling

* Update changelog
This commit is contained in:
Thomas Kaul 2022-09-10 18:58:31 +02:00 committed by GitHub
parent 42d32ed652
commit 0fcfa6c1bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Upgraded `yahoo-finance2` from version `2.3.3` to `2.3.6` - Upgraded `yahoo-finance2` from version `2.3.3` to `2.3.6`
### Fixed
- Improved the error handling in the benchmark calculation
## 1.191.0 - 10.09.2022 ## 1.191.0 - 10.09.2022
### Changed ### Changed

6
apps/api/src/app/benchmark/benchmark.service.ts
View File

@ -31,7 +31,11 @@ export class BenchmarkService {
) {} ) {}
public calculateChangeInPercentage(baseValue: number, currentValue: number) { public calculateChangeInPercentage(baseValue: number, currentValue: number) {
return new Big(currentValue).div(baseValue).minus(1).toNumber(); if (baseValue && currentValue) {
return new Big(currentValue).div(baseValue).minus(1).toNumber();
}
return 0;
} }
public async getBenchmarks({ useCache = true } = {}): Promise< public async getBenchmarks({ useCache = true } = {}): Promise<