sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/fix hidden statistics values (#552)

Browse Source 
* Fix hidden values (0)

* Update changelog
This commit is contained in:
Thomas Kaul 2021-12-18 11:13:32 +01:00 committed by GitHub
parent e518bc3779
commit 0806d0dc92
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed the symbol conversion from _Yahoo Finance_ including a hyphen - Fixed the symbol conversion from _Yahoo Finance_ including a hyphen
- Fixed hidden values (`0`) in the statistics section on the about page
### Todo ### Todo

29
apps/client/src/app/pages/about/about-page.html
View File

@ -108,8 +108,11 @@
<mat-card-content> <mat-card-content>
<div class="row"> <div class="row">
<div class="col-xs-12 col-md-4 my-2"> <div class="col-xs-12 col-md-4 my-2">
<h3 class="mb-0" [hidden]="!statistics?.activeUsers1d"> <h3
{{ statistics?.activeUsers1d ?? '-' }} class="mb-0"
[hidden]="statistics?.activeUsers1d === undefined"
>
{{ statistics?.activeUsers1d || '-' }}
</h3> </h3>
<div class="h6 mb-0"> <div class="h6 mb-0">
<span i18n>Active Users</span>&nbsp;<small class="text-muted" <span i18n>Active Users</span>&nbsp;<small class="text-muted"
@ -118,7 +121,10 @@
</div> </div>
</div> </div>
<div class="col-xs-12 col-md-4 my-2"> <div class="col-xs-12 col-md-4 my-2">
<h3 class="mb-0" [hidden]="!statistics?.activeUsers7d"> <h3
class="mb-0"
[hidden]="statistics?.activeUsers7d === undefined"
>
{{ statistics?.activeUsers7d ?? '-' }} {{ statistics?.activeUsers7d ?? '-' }}
</h3> </h3>
<div class="h6 mb-0"> <div class="h6 mb-0">
@ -128,7 +134,10 @@
</div> </div>
</div> </div>
<div class="col-xs-12 col-md-4 my-2"> <div class="col-xs-12 col-md-4 my-2">
<h3 class="mb-0" [hidden]="!statistics?.activeUsers30d"> <h3
class="mb-0"
[hidden]="statistics?.activeUsers30d === undefined"
>
{{ statistics?.activeUsers30d ?? '-' }} {{ statistics?.activeUsers30d ?? '-' }}
</h3> </h3>
<div class="h6 mb-0"> <div class="h6 mb-0">
@ -138,7 +147,7 @@
</div> </div>
</div> </div>
<div class="col-xs-12 col-md-4 my-2"> <div class="col-xs-12 col-md-4 my-2">
<h3 class="mb-0" [hidden]="!statistics?.newUsers30d"> <h3 class="mb-0" [hidden]="statistics?.newUsers30d === undefined">
{{ statistics?.newUsers30d ?? '-' }} {{ statistics?.newUsers30d ?? '-' }}
</h3> </h3>
<div class="h6 mb-0"> <div class="h6 mb-0">
@ -148,13 +157,19 @@
</div> </div>
</div> </div>
<div class="col-xs-12 col-md-4 my-2"> <div class="col-xs-12 col-md-4 my-2">
<h3 class="mb-0" [hidden]="!statistics?.gitHubContributors"> <h3
class="mb-0"
[hidden]="statistics?.gitHubContributors === undefined"
>
{{ statistics?.gitHubContributors ?? '-' }} {{ statistics?.gitHubContributors ?? '-' }}
</h3> </h3>
<div class="h6 mb-0" i18n>Contributors on GitHub</div> <div class="h6 mb-0" i18n>Contributors on GitHub</div>
</div> </div>
<div class="col-xs-12 col-md-4 my-2"> <div class="col-xs-12 col-md-4 my-2">
<h3 class="mb-0" [hidden]="!statistics?.gitHubStargazers"> <h3
class="mb-0"
[hidden]="statistics?.gitHubStargazers === undefined"
>
{{ statistics?.gitHubStargazers ?? '-' }} {{ statistics?.gitHubStargazers ?? '-' }}
</h3> </h3>
<div class="h6 mb-0" i18n>Stars on GitHub</div> <div class="h6 mb-0" i18n>Stars on GitHub</div>