SubMiner/backlog/tasks/task-148 - Fix-Windows-plugin-env-binary-override-resolution.md

id, title, status, assignee, created_date, updated_date, labels, dependencies, priority, ordinal

id	title	status	assignee	created_date	updated_date	labels	dependencies	priority	ordinal
TASK-148	Fix Windows plugin env binary override resolution	Done	codex	2026-03-09 00:00	2026-03-18 05:28	windows plugin regression		medium	48500

Description

Fix the mpv plugin's Windows binary override lookup so SUBMINER_BINARY_PATH still resolves when SUBMINER_APPIMAGE_PATH is unset. The current Lua resolver builds an array with a leading nil, which causes ipairs iteration to stop before the later Windows override candidate.

Acceptance Criteria

• #1 scripts/test-plugin-binary-windows.lua passes the env override regression that expects .exe suffix resolution from SUBMINER_BINARY_PATH.
• #2 Existing plugin start/binary test gate stays green after the fix.

Final Summary

Updated plugin/subminer/binary.lua so env override lookup checks SUBMINER_APPIMAGE_PATH and SUBMINER_BINARY_PATH sequentially instead of via a Lua array literal that truncates at the first nil. This restores Windows .exe suffix resolution for SUBMINER_BINARY_PATH when the AppImage env var is unset.

Verification:

• lua scripts/test-plugin-binary-windows.lua
• bun run test:plugin:src