sudacode
e8f10fe8a9
- Split win32/darwin branches in handleOverlayWindowBlurred so darwin visible blur returns early without calling onWindowsVisibleOverlayBlur - Add regression test asserting Windows callback stays inactive on macOS visible overlay blur - Close TASK-347
3.2 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, modified_files, priority
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | modified_files | priority | |||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-347 | Address PR 57 CodeRabbit review round after stats session fix | Done |
|
2026-05-12 07:02 | 2026-05-12 09:48 |
|
|
|
high |
Description
Assess and address the 2026-05-12 CodeRabbit review on PR #57 plus the current red GitHub Actions check. Latest comments cover stats session detail token aggregation, Linux fullscreen overlay refresh scheduling, Hyprland title-event polling, malformed Hyprland monitor JSON handling, and JLPT-lock test coverage for name matches.
Acceptance Criteria
- #1 Still-valid latest CodeRabbit findings on PR #57 are fixed or documented as skipped with rationale.
- #2 CI failure context is inspected and any repo-relevant failing tests or formatting issues are fixed.
- #3 Regression coverage is added for behavior changes where practical before production edits.
- #4 Relevant local verification passes.
Implementation Plan
- Inspect failing GitHub Actions log and current code around each latest CodeRabbit finding.
- Add or update focused regression tests first for behavior changes: stats token aggregation, fullscreen refresh exit cancellation, Hyprland monitor parse failure, and title-only event filtering.
- Apply minimal production fixes for still-valid findings, plus the subtitle-render duplicate test coverage item.
- Run targeted tests first, then format/typecheck and broader relevant gates; update the task with results.
Address latest CodeRabbit callback-scope finding: add regression coverage that macOS visible-overlay blur does not invoke onWindowsVisibleOverlayBlur, then split win32/darwin blur handling in src/core/services/overlay-window-input.ts.
Implementation Notes
2026-05-12 09:47: Assessed latest PR #57 CodeRabbit comments via gh. Prior review findings in comments are marked addressed by CodeRabbit; latest still-actionable item was macOS visible-overlay blur invoking the Windows-only blur callback in overlay-window-input.ts.
Added regression coverage showing macOS visible-overlay blur leaves onWindowsVisibleOverlayBlur inactive; test failed before production change and passed after splitting win32/darwin handling.
Verification: bun test src/core/services/overlay-window.test.ts; bun run typecheck; git diff --check. PR checks: build-test-audit pass, GitGuardian pass, CodeRabbit pass/skipped, Claude skipped.
Final Summary
Addressed the latest CodeRabbit callback-scope review on PR #57. Windows visible-overlay blur still invokes onWindowsVisibleOverlayBlur and returns without restacking; macOS visible-overlay blur now returns without restacking and without invoking the Windows-only callback. Added focused regression coverage and verified targeted tests, typecheck, diff whitespace, and current PR checks.