Files
SubMiner/backlog/tasks/task-343 - Fix-macOS-character-dictionary-selector-session-shortcut.md
T
sudacode 47499eccff fix: map openCharacterDictionary session action to --open-character-dict
- Add missing Lua CLI dispatch entry for openCharacterDictionary
- Add regression test for Alt+Meta+A binding and CLI flag forwarding
2026-05-11 01:07:11 -07:00

1.7 KiB

id, title, status, assignee, created_date, updated_date, labels, dependencies, modified_files, priority, ordinal
id title status assignee created_date updated_date labels dependencies modified_files priority ordinal
TASK-343 Fix macOS character dictionary selector session shortcut Done
2026-05-11 08:05 2026-05-11 08:06
bug
macos
character-dictionary
plugin
plugin/subminer/session_bindings.lua
scripts/test-plugin-session-bindings.lua
medium 181500

Description

Opening the character dictionary AniList selector from mpv/session shortcuts should work on macOS. Current generated session bindings include the openCharacterDictionary session action, but the Lua plugin CLI dispatch table does not map that action to the app flag, so the shortcut cannot reach the runtime selector.

Acceptance Criteria

  • #1 The openCharacterDictionary session action invokes the app with --open-character-dictionary from the mpv plugin.
  • #2 Regression coverage proves the Lua session-binding CLI map forwards openCharacterDictionary correctly.
  • #3 Existing session-binding regression coverage still passes.

Implementation Notes

TDD red: lua scripts/test-plugin-session-bindings.lua failed because openCharacterDictionary did not emit --open-character-dictionary. Green after adding the missing Lua CLI mapping.

Final Summary

Fixed the mpv plugin session action mapping so the character dictionary selector shortcut dispatches --open-character-dictionary to the app. Added Lua regression coverage for the macOS-style Alt+Meta+A binding and verified adjacent TypeScript session binding tests.