mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-06-13 15:13:32 -07:00
b1bdeabca8
* fix(jellyfin): show overlay, inject plugin, and fix stats title on playb - Show visible overlay automatically during Jellyfin playback so subtitleStyle applies - Inject bundled mpv plugin on auto-launch so keybindings work without overlay focus - Group Jellyfin playback stats under item metadata (jellyfin://host/item/id) instead of stream URLs so episodes merge with matching local titles - Mark ffsubsync unavailable in subsync modal for remote media paths - Drain queued second-instance commands even when onReady throws * fix(overlay): stabilize macOS focus handoff and sidebar Yomitan pause - Keep overlay visible during macOS foreground probe after overlay blur - Hold sidebar hover-pause while a Yomitan lookup popup remains open * fix(jellyfin): fix discovery loop, device identity, tray state, and Disc - Derive device identity from OS hostname; remove legacy configurable client/device fields - Prevent discovery playback from reloading active item, misreporting pause state, and duplicate overlay restores - Restart stale tray discovery sessions without re-login when server drops SubMiner cast target - Sync tray discovery checkbox state on Linux after CLI/startup/remote-session changes - Stop Discord presence falling back to stream URLs; prime title before tokenized stream loads - Fix picker library discovery when log level is above info - Fix config.example.jsonc trailing commas and array formatting * docs(release): trim and consolidate prerelease notes for 0.15.0 - Remove breaking changes section and several redundant bullet points - Consolidate per-platform updater notes into a single entry - Normalize em-dash separators to hyphens in section headers * fix(config): remove trailing commas from config.example.jsonc - Strip trailing commas throughout both config.example.jsonc copies - Reformat inline arrays to multi-line for JSON strictness - Update Jellyfin subtitle preload and playback launch tests and impl * fix(tokenizer): preserve known-word highlight when POS filters suppress - Known-word cache matches now set isKnown=true even for tokens excluded by POS filters - POS exclusion gate suppresses N+1, frequency, and JLPT only; known status is computed before the gate - Jellyfin subtitle preload continues after cleanup failures instead of aborting - Update config docs and option description to document the known-word bypass behavior * fix(jellyfin): send explicit hide/show overlay instead of toggle - Track overlay visibility in plugin state; y-t uses explicit hide/show commands when state is known - Prevent paused Jellyfin playback from resuming on overlay hide - Fix subtitle cache cleanup to only remove dirs after successful cleanup * fix(jellyfin): fix remote progress sync, seek reporting, and startup sto - arm active playback before loadfile with loadedMediaPath: null to suppress premature stop events - force immediate progress report on seek-like position jumps at the mpv time-pos level - send positionTicks and failed=false in reportStopped payload - remove EventName from HTTP timeline payloads (websocket-only field) - add startup grace window to drop stop events before media finishes loading * fix(jellyfin): fix overlay toggle sync, redirect reload, and AppImage bi - Sync visible-overlay state back to plugin via script messages to avoid toggle/hide drift - Collapse duplicate toggle events within 250ms to prevent hide-then-show on single keypress - Preserve manual hide across Jellyfin path-changing redirects even when media-title drops - Rearm managed subtitle defaults on path-changing redirects - Route toggleVisibleOverlay session binding through plugin toggle instead of app-side IPC - Show Linux/Hyprland overlay passively (showInactive) to avoid stealing mpv keyboard focus - Fix AppImage binary resolution to prefer $APPIMAGE env over mounted inner binary - Add stats window layer management so delete/update dialogs appear above stats window - Fix Jellyfin remote progress sync during Linux websocket reconnect windows * Fix CodeRabbit review feedback * fix(jellyfin): subtitle timing, resume progress, and overlay sync - Add per-stream subtitle delay persistence and auto timeline-offset correction - Strip server-selected subtitle stream from mpv load URL; suppress plugin subtitle rearm and auto-start during app-managed preload - Fix resume position lost when mpv resets on stop; use last known position for final progress/stopped reports - Keep Play vs Resume distinct to avoid early seek race on normal play - Fix discovery resume when remote play sends StartPositionTicks=0 despite saved progress - Deduplicate show/hide overlay commands using recorded visibility state - Rewrite docs-site Jellyfin page around cast-to-device UX * test: update lifecycle cleanup assertion * fix: clear aborted playback state, fix overlay passthrough, and guard du - Reset app_managed_playback_pending on lifecycle cleanup to prevent state leak into next item - Record visible overlay action only after command succeeds, not before - Non-native passive overlay now always click-through on re-show (fix isNonNativePassiveOverlay ordering) - Defer activeParsedSubtitleMediaPath assignment until after prefetch completes - Move autoplay gate release into the hide branch of toggleVisibleOverlay - Clear active Jellyfin playback when stopping media that never loaded - Reset managed subtitle delay and delay key when no external tracks are available - Await async removeDir in subtitle cache cleanup - Guard duplicate delete clicks in MediaDetailView and SessionsTab with refs - Escape key in DeleteConfirmDialog now calls stopPropagation and stopImmediatePropagation
232 lines
7.7 KiB
TypeScript
232 lines
7.7 KiB
TypeScript
import assert from 'node:assert/strict';
|
|
import test from 'node:test';
|
|
|
|
import {
|
|
createManagedLocalSubtitleSelectionRuntime,
|
|
resolveManagedLocalSubtitleSelection,
|
|
} from './local-subtitle-selection';
|
|
|
|
const mixedLanguageTrackList = [
|
|
{ type: 'sub', id: 1, lang: 'pt', title: '[Infinite]', external: false, selected: true },
|
|
{ type: 'sub', id: 2, lang: 'pt', title: '[Moshi Moshi]', external: false },
|
|
{ type: 'sub', id: 3, lang: 'en', title: '(Vivid)', external: false },
|
|
{ type: 'sub', id: 9, lang: 'en', title: 'English(US)', external: false },
|
|
{ type: 'sub', id: 11, lang: 'en', title: 'en.srt', external: true },
|
|
{ type: 'sub', id: 12, lang: 'ja', title: 'ja.srt', external: true },
|
|
];
|
|
|
|
const unlabeledExternalSidecarTrackList = [
|
|
{ type: 'sub', id: 1, lang: 'eng', title: 'English ASS', external: false, selected: true },
|
|
{ type: 'sub', id: 2, title: 'srt', external: true },
|
|
];
|
|
|
|
test('resolveManagedLocalSubtitleSelection prefers default Japanese primary and English secondary tracks', () => {
|
|
const result = resolveManagedLocalSubtitleSelection({
|
|
trackList: mixedLanguageTrackList,
|
|
primaryLanguages: [],
|
|
secondaryLanguages: [],
|
|
});
|
|
|
|
assert.equal(result.primaryTrackId, 12);
|
|
assert.equal(result.secondaryTrackId, 11);
|
|
});
|
|
|
|
test('resolveManagedLocalSubtitleSelection respects configured language overrides', () => {
|
|
const result = resolveManagedLocalSubtitleSelection({
|
|
trackList: mixedLanguageTrackList,
|
|
primaryLanguages: ['pt'],
|
|
secondaryLanguages: ['ja'],
|
|
});
|
|
|
|
assert.equal(result.primaryTrackId, 1);
|
|
assert.equal(result.secondaryTrackId, 12);
|
|
});
|
|
|
|
test('resolveManagedLocalSubtitleSelection promotes a single unlabeled external sidecar to primary', () => {
|
|
const result = resolveManagedLocalSubtitleSelection({
|
|
trackList: unlabeledExternalSidecarTrackList,
|
|
primaryLanguages: [],
|
|
secondaryLanguages: [],
|
|
});
|
|
|
|
assert.equal(result.primaryTrackId, 2);
|
|
assert.equal(result.secondaryTrackId, 1);
|
|
});
|
|
|
|
test('resolveManagedLocalSubtitleSelection does not guess between multiple unlabeled external sidecars', () => {
|
|
const result = resolveManagedLocalSubtitleSelection({
|
|
trackList: [
|
|
...unlabeledExternalSidecarTrackList,
|
|
{ type: 'sub', id: 3, title: 'subrip', external: true },
|
|
],
|
|
primaryLanguages: [],
|
|
secondaryLanguages: [],
|
|
});
|
|
|
|
assert.equal(result.primaryTrackId, null);
|
|
assert.equal(result.secondaryTrackId, 1);
|
|
});
|
|
|
|
test('managed local subtitle selection runtime applies preferred tracks once for a local media path', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const scheduled: Array<() => void> = [];
|
|
|
|
const runtime = createManagedLocalSubtitleSelectionRuntime({
|
|
getCurrentMediaPath: () => '/videos/example.mkv',
|
|
getMpvClient: () =>
|
|
({
|
|
connected: true,
|
|
requestProperty: async (name: string) => {
|
|
if (name === 'track-list') {
|
|
return mixedLanguageTrackList;
|
|
}
|
|
throw new Error(`Unexpected property: ${name}`);
|
|
},
|
|
}) as never,
|
|
getPrimarySubtitleLanguages: () => [],
|
|
getSecondarySubtitleLanguages: () => [],
|
|
sendMpvCommand: (command) => {
|
|
commands.push(command);
|
|
},
|
|
schedule: (callback) => {
|
|
scheduled.push(callback);
|
|
return 1 as never;
|
|
},
|
|
clearScheduled: () => {},
|
|
});
|
|
|
|
runtime.handleMediaPathChange('/videos/example.mkv');
|
|
scheduled.shift()?.();
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
runtime.handleSubtitleTrackListChange(mixedLanguageTrackList);
|
|
|
|
assert.deepEqual(commands, [
|
|
['set_property', 'sid', 12],
|
|
['set_property', 'secondary-sid', 11],
|
|
]);
|
|
});
|
|
|
|
test('managed local subtitle selection runtime promotes a single unlabeled external sidecar over embedded english', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const scheduled: Array<() => void> = [];
|
|
|
|
const runtime = createManagedLocalSubtitleSelectionRuntime({
|
|
getCurrentMediaPath: () => '/videos/example.mkv',
|
|
getMpvClient: () =>
|
|
({
|
|
connected: true,
|
|
requestProperty: async (name: string) => {
|
|
if (name === 'track-list') {
|
|
return unlabeledExternalSidecarTrackList;
|
|
}
|
|
throw new Error(`Unexpected property: ${name}`);
|
|
},
|
|
}) as never,
|
|
getPrimarySubtitleLanguages: () => [],
|
|
getSecondarySubtitleLanguages: () => [],
|
|
sendMpvCommand: (command) => {
|
|
commands.push(command);
|
|
},
|
|
schedule: (callback) => {
|
|
scheduled.push(callback);
|
|
return 1 as never;
|
|
},
|
|
clearScheduled: () => {},
|
|
});
|
|
|
|
runtime.handleMediaPathChange('/videos/example.mkv');
|
|
scheduled.shift()?.();
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
runtime.handleSubtitleTrackListChange(unlabeledExternalSidecarTrackList);
|
|
|
|
assert.deepEqual(commands, [
|
|
['set_property', 'sid', 2],
|
|
['set_property', 'secondary-sid', 1],
|
|
]);
|
|
});
|
|
|
|
test('managed local subtitle selection keeps waiting for primary after early secondary-only track list', () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const runtime = createManagedLocalSubtitleSelectionRuntime({
|
|
getCurrentMediaPath: () => '/videos/example.mkv',
|
|
getMpvClient: () => null,
|
|
getPrimarySubtitleLanguages: () => [],
|
|
getSecondarySubtitleLanguages: () => [],
|
|
sendMpvCommand: (command) => {
|
|
commands.push(command);
|
|
},
|
|
schedule: () => 1 as never,
|
|
clearScheduled: () => {},
|
|
});
|
|
|
|
runtime.handleMediaPathChange('/videos/example.mkv');
|
|
runtime.handleSubtitleTrackListChange([
|
|
{ type: 'sub', id: 1, lang: 'eng', title: 'ASS', external: false },
|
|
{ type: 'sub', id: 2, lang: 'en', title: 'en.srt', external: true },
|
|
]);
|
|
runtime.handleSubtitleTrackListChange([
|
|
{ type: 'sub', id: 1, lang: 'eng', title: 'ASS', external: false },
|
|
{ type: 'sub', id: 2, lang: 'en', title: 'en.srt', external: true },
|
|
{ type: 'sub', id: 3, lang: 'ja', title: 'ja.srt', external: true },
|
|
]);
|
|
|
|
assert.deepEqual(commands, [
|
|
['set_property', 'secondary-sid', 2],
|
|
['set_property', 'sid', 3],
|
|
]);
|
|
});
|
|
|
|
test('managed local subtitle selection keeps pending refresh after early primary-only track list', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const scheduled = new Map<number, () => void>();
|
|
let nextTimerId = 1;
|
|
|
|
const runtime = createManagedLocalSubtitleSelectionRuntime({
|
|
getCurrentMediaPath: () => '/videos/example.mkv',
|
|
getMpvClient: () =>
|
|
({
|
|
connected: true,
|
|
requestProperty: async (name: string) => {
|
|
if (name === 'track-list') {
|
|
return [
|
|
{ type: 'sub', id: 3, lang: 'ja', title: 'ja.srt', external: true },
|
|
{ type: 'sub', id: 4, lang: 'en', title: 'en.srt', external: true },
|
|
];
|
|
}
|
|
throw new Error(`Unexpected property: ${name}`);
|
|
},
|
|
}) as never,
|
|
getPrimarySubtitleLanguages: () => [],
|
|
getSecondarySubtitleLanguages: () => [],
|
|
sendMpvCommand: (command) => {
|
|
commands.push(command);
|
|
},
|
|
schedule: (callback) => {
|
|
const timerId = nextTimerId++;
|
|
scheduled.set(timerId, callback);
|
|
return timerId as never;
|
|
},
|
|
clearScheduled: (timer) => {
|
|
scheduled.delete(timer as never);
|
|
},
|
|
});
|
|
|
|
runtime.handleMediaPathChange('/videos/example.mkv');
|
|
runtime.handleSubtitleTrackListChange([
|
|
{ type: 'sub', id: 3, lang: 'ja', title: 'ja.srt', external: true },
|
|
]);
|
|
|
|
assert.deepEqual(commands, [['set_property', 'sid', 3]]);
|
|
assert.equal(scheduled.size, 1);
|
|
|
|
const refresh = [...scheduled.values()][0];
|
|
assert.ok(refresh);
|
|
refresh();
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
|
|
assert.deepEqual(commands, [
|
|
['set_property', 'sid', 3],
|
|
['set_property', 'secondary-sid', 4],
|
|
]);
|
|
});
|