mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-07-28 04:49:49 -07:00
430373f010
* feat(tokenizer): use Yomitan word classes for subtitle POS filtering - Carry matched headword wordClasses from termsFind into YomitanScanToken - Map recognized Yomitan wordClasses to SubMiner coarse POS before annotation - MeCab enrichment now fills only missing POS fields, preserving existing coarse pos1 - Exclude standalone grammar particles, して helper fragments, and single-kana surfaces from annotations - Respect source-text punctuation gaps when counting N+1 sentence words - Preserve known-word highlight on excluded kanji-containing tokens - Add backlog tasks 304 (N+1 boundary bug) and 305 (wordClasses POS, done) * fix(tokenizer): preserve annotation and enrichment behavior * fix: restore jlpt subtitle underlines * fix: exclude kana-only n+1 targets * fix: refresh overlay on Hyprland fullscreen * fix: address fullscreen and n-plus-one review notes * fix: address CodeRabbit review comments * fix: accept modified digits for multi-line sentence mining * Cancel pending Linux MPV fullscreen overlay refresh bursts - return a cancel handle from the Linux refresh burst scheduler - clear pending refresh bursts when overlays hide or windows close - tighten the burst test polling to wait for the async refresh * fix: suppress N+1 for kana-only candidates and fix minSentenceWords coun - Treat kana-only tokens with surrounding subtitle punctuation (…, ―, etc.) as kana-only so they are not promoted to N+1 targets - Exclude unknown tokens filtered from N+1 targeting from the minSentenceWords count so filtered kana-only unknowns cannot satisfy sentence length threshold - Add regression tests for kana-only candidate suppression and filtered-unknown padding cases * Suppress subtitle annotations for grammar fragments - Hide annotation metadata for auxiliary inflection and ja-nai endings - Preserve lexical `くれる` forms and add regression coverage * Fix kana-only N+1 tokenizer regression test - Use a pure-kana fixture for the subtitle token N+1 case - Update task notes for the latest CodeRabbit follow-up * Fix managed playback exit and tokenizer grammar splits - Ignore background stats daemons during regular app startup - Split standalone grammar endings before applying annotations - Clear helper-span annotations for auxiliary-only tokens * fix: refresh current subtitle after known-word mining * fix: suppress sigh interjection annotations * fix: preserve jlpt underline color after lookup * Replace grammar-ending permutations with shared matcher; preserve word a - Extract `grammar-ending.ts` with `isStandaloneGrammarEndingText` / `isSubtitleGrammarEndingText` pattern matchers - Replace `STANDALONE_GRAMMAR_ENDINGS` set in parser-selection-stage with shared matcher - Replace generated phrase sets in subtitle-annotation-filter with shared matcher - Remove stale duplicate subtitle-exclusion constants and helpers from annotation-stage - Manual clipboard card updates now write only to the sentence audio field, leaving word/expression audio untouched * fix: CI changelog, annotation options threading, and Jellyfin quit - Add `type: fixed` / `area:` frontmatter to `changes/319` to pass `changelog:lint` - Thread `TokenizerAnnotationOptions` through `stripSubtitleAnnotationMetadata` so `sourceText` is honored - Include `jellyfinPlay` in `shouldQuitOnDisconnectWhenOverlayRuntimeInitialized` predicate - Make mouse test `elementFromPoint` stubs coordinate-sensitive - Make Lua test `.tmp` mkdir portable on Windows * Preserve overlay across macOS flaps and mpv playlist changes - keep visible overlays alive during transient macOS tracker loss - reuse the running mpv overlay path on playlist navigation - update regression coverage and changelog fragments * fix: restore stats daemon deferral * fix: keep subtitle prefetch alive after cache hits * Fix JLPT underline color drift and AniList skipped-threshold sync - Replace JLPT `text-decoration` underlines with `border-bottom` so Chromium selection/hover cannot repaint them to another annotation's color - Lock JLPT underline color for combined annotation selectors (known, n+1, frequency) and character hover/selection states - Trigger AniList post-watch check on every mpv time-position update to catch skipped completion thresholds - Fall back to filename-parser season/episode when guessit omits them * fix: address coderabbit feedback * fix: sync AniList after seeked completion * fix: preserve ordinal frequency annotations * fix: preserve known highlighting for filtered tokens * fix: address PR #57 CodeRabbit feedback - Acquire AniList post-watch in-flight lock before async gating to prevent duplicate writes - Isolate manual watched mark result from AniList post-watch callback failures - Report known-word cache clears as mutations during immediate append when state existed - Add regression tests for each fix * fix: stop AniList setup reopening on Linux when keyring token exists - Gate setup success on token persistence: `saveToken` now returns `boolean`; on failure, keeps the setup window open instead of reporting success - Config reload passes `allowSetupPrompt: false` so playback reloads don't re-open the setup window - Add regression test for persistence-failure path * fix: suppress known highlights for subtitle particles * fix: retry transient AniList safeStorage failures * fix: hide overlay focus ring * fix: align Hyprland fullscreen overlays * fix: restore subtitle playback keybindings * fix: align Hyprland overlay windows to mpv and stop pinning them - Force-apply exact Hyprland move/resize/setprop dispatches when bounds are provided - Stop pinning overlay windows; toggle pin off when Hyprland reports pinned=true - Compensate stats overlay outer placement for Electron/Wayland content insets - Make stats overlay window and page opaque so mpv cannot show through transparent insets - Constrain stats app to h-screen with internal scroll so content covers mpv from y=0 - Lock overlay/stats window titles against page-title-updated events - Add regression coverage for placement dispatches, inset compensation, and CSS overlay mode * fix: retain frequency rank for honorific prefix-noun tokens - Add `shouldAllowHonorificPrefixNounFrequency` to exempt お/ご/御 + noun merged tokens from frequency exclusion - Add regression test for `ご機嫌` asserting rank 5484 is preserved after MeCab enrichment and annotation - Close TASK-341 * fix: map openCharacterDictionary session action to --open-character-dict - Add missing Lua CLI dispatch entry for openCharacterDictionary - Add regression test for Alt+Meta+A binding and CLI flag forwarding * fix: keep macOS overlay interactive while mpv remains active - Overlay no longer hides or becomes click-through during tracker refreshes when mpv is the focused window - Preserve already-visible overlay when tracker is temporarily not ready but mpv target signal is active - Add regression tests for active-mpv tracker refresh and transient tracker-not-ready paths * fix: address coderabbit subtitle follow-ups * fix: resolve media detail from sessions when lifetime summary is absent - Change `getMediaDetail` JOIN to LEFT JOIN on `imm_lifetime_media` and fall back to aggregated session metrics when no lifetime row exists - Add filter `AND (lm.video_id IS NOT NULL OR s.session_id IS NOT NULL)` to keep results valid - Add regression test covering the session-visible / media-detail-missing mismatch * fix: address PR-57 CodeRabbit findings and CI failures - use filtered word counts in media detail session token aggregation - cancel fullscreen refresh burst on exit via updateLinuxMpvFullscreenOverlayRefreshBurst - guard Hyprland JSON.parse in try/catch; exclude windowtitle from geometry events - narrow focus suppression from :focus to :focus-visible - apply JLPT lock selectors to word-name-match tokens (N1–N5) * fix: macOS overlay z-order and Yomitan compound token known highlighting - Release always-on-top when tracked mpv loses foreground on macOS - Skip visible overlay blur restacking on macOS to avoid covering unrelated windows - Prefer Yomitan internal parse tokens over fragmented scanner output for known-word decisions - Add regression tests for both behaviors * fix: macOS visible-overlay blur no longer invokes Windows-only blur call - Split win32/darwin branches in handleOverlayWindowBlurred so darwin visible blur returns early without calling onWindowsVisibleOverlayBlur - Add regression test asserting Windows callback stays inactive on macOS visible overlay blur - Close TASK-347
189 lines
6.4 KiB
TypeScript
189 lines
6.4 KiB
TypeScript
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import {
|
|
buildAnilistSetupFallbackHtml,
|
|
buildAnilistManualTokenEntryHtml,
|
|
buildAnilistSetupUrl,
|
|
consumeAnilistSetupCallbackUrl,
|
|
extractAnilistAccessTokenFromUrl,
|
|
findAnilistSetupDeepLinkArgvUrl,
|
|
} from './anilist-setup';
|
|
|
|
test('buildAnilistSetupUrl includes required query params', () => {
|
|
const url = buildAnilistSetupUrl({
|
|
authorizeUrl: 'https://anilist.co/api/v2/oauth/authorize',
|
|
clientId: '36084',
|
|
responseType: 'token',
|
|
redirectUri: 'https://anilist.subminer.moe/',
|
|
});
|
|
assert.match(url, /client_id=36084/);
|
|
assert.match(url, /response_type=token/);
|
|
assert.match(url, /redirect_uri=https%3A%2F%2Fanilist\.subminer\.moe%2F/);
|
|
});
|
|
|
|
test('buildAnilistSetupUrl omits redirect_uri when unset', () => {
|
|
const url = buildAnilistSetupUrl({
|
|
authorizeUrl: 'https://anilist.co/api/v2/oauth/authorize',
|
|
clientId: '36084',
|
|
responseType: 'token',
|
|
});
|
|
assert.match(url, /client_id=36084/);
|
|
assert.match(url, /response_type=token/);
|
|
assert.equal(url.includes('redirect_uri='), false);
|
|
});
|
|
|
|
test('buildAnilistSetupFallbackHtml escapes reason content', () => {
|
|
const html = buildAnilistSetupFallbackHtml({
|
|
reason: '<script>alert(1)</script>',
|
|
authorizeUrl: 'https://anilist.example/auth',
|
|
developerSettingsUrl: 'https://anilist.example/dev',
|
|
});
|
|
assert.equal(html.includes('<script>alert(1)</script>'), false);
|
|
assert.match(html, /<script>alert\(1\)<\/script>/);
|
|
});
|
|
|
|
test('buildAnilistManualTokenEntryHtml includes access-token submit route only', () => {
|
|
const html = buildAnilistManualTokenEntryHtml({
|
|
authorizeUrl: 'https://anilist.example/auth',
|
|
developerSettingsUrl: 'https://anilist.example/dev',
|
|
});
|
|
assert.match(html, /subminer:\/\/anilist-setup\?access_token=/);
|
|
assert.equal(html.includes('callback_url='), false);
|
|
assert.equal(html.includes('subminer://anilist-setup?code='), false);
|
|
});
|
|
|
|
test('extractAnilistAccessTokenFromUrl returns access token from hash fragment', () => {
|
|
const token = extractAnilistAccessTokenFromUrl(
|
|
'https://anilist.subminer.moe/#access_token=token-from-hash&token_type=Bearer',
|
|
);
|
|
assert.equal(token, 'token-from-hash');
|
|
});
|
|
|
|
test('extractAnilistAccessTokenFromUrl returns access token from query', () => {
|
|
const token = extractAnilistAccessTokenFromUrl(
|
|
'https://anilist.subminer.moe/?access_token=token-from-query&token_type=Bearer',
|
|
);
|
|
assert.equal(token, 'token-from-query');
|
|
});
|
|
|
|
test('findAnilistSetupDeepLinkArgvUrl finds subminer deep link from argv', () => {
|
|
const rawUrl = findAnilistSetupDeepLinkArgvUrl([
|
|
'/Applications/SubMiner.app/Contents/MacOS/SubMiner',
|
|
'--start',
|
|
'subminer://anilist-setup?access_token=argv-token',
|
|
]);
|
|
assert.equal(rawUrl, 'subminer://anilist-setup?access_token=argv-token');
|
|
});
|
|
|
|
test('findAnilistSetupDeepLinkArgvUrl returns null when missing', () => {
|
|
const rawUrl = findAnilistSetupDeepLinkArgvUrl([
|
|
'/Applications/SubMiner.app/Contents/MacOS/SubMiner',
|
|
'--start',
|
|
]);
|
|
assert.equal(rawUrl, null);
|
|
});
|
|
|
|
test('consumeAnilistSetupCallbackUrl persists token and closes window for callback URL', () => {
|
|
const originalDateNow = Date.now;
|
|
const events: string[] = [];
|
|
try {
|
|
Date.now = () => 120_000;
|
|
const handled = consumeAnilistSetupCallbackUrl({
|
|
rawUrl: 'https://anilist.subminer.moe/#access_token=saved-token',
|
|
saveToken: (value: string) => {
|
|
events.push(`save:${value}`);
|
|
return true;
|
|
},
|
|
setCachedToken: (value: string) => events.push(`cache:${value}`),
|
|
setResolvedState: (timestampMs: number) =>
|
|
events.push(`state:${timestampMs > 0 ? 'ok' : 'bad'}`),
|
|
setSetupPageOpened: (opened: boolean) => events.push(`opened:${opened}`),
|
|
onSuccess: () => events.push('success'),
|
|
closeWindow: () => events.push('close'),
|
|
});
|
|
|
|
assert.equal(handled, true);
|
|
assert.deepEqual(events, [
|
|
'save:saved-token',
|
|
'cache:saved-token',
|
|
'state:ok',
|
|
'opened:false',
|
|
'success',
|
|
'close',
|
|
]);
|
|
} finally {
|
|
Date.now = originalDateNow;
|
|
}
|
|
});
|
|
|
|
test('consumeAnilistSetupCallbackUrl persists token for subminer deep link URL', () => {
|
|
const originalDateNow = Date.now;
|
|
const events: string[] = [];
|
|
try {
|
|
Date.now = () => 120_000;
|
|
const handled = consumeAnilistSetupCallbackUrl({
|
|
rawUrl: 'subminer://anilist-setup?access_token=saved-token',
|
|
saveToken: (value: string) => {
|
|
events.push(`save:${value}`);
|
|
return true;
|
|
},
|
|
setCachedToken: (value: string) => events.push(`cache:${value}`),
|
|
setResolvedState: (timestampMs: number) =>
|
|
events.push(`state:${timestampMs > 0 ? 'ok' : 'bad'}`),
|
|
setSetupPageOpened: (opened: boolean) => events.push(`opened:${opened}`),
|
|
onSuccess: () => events.push('success'),
|
|
closeWindow: () => events.push('close'),
|
|
});
|
|
|
|
assert.equal(handled, true);
|
|
assert.deepEqual(events, [
|
|
'save:saved-token',
|
|
'cache:saved-token',
|
|
'state:ok',
|
|
'opened:false',
|
|
'success',
|
|
'close',
|
|
]);
|
|
} finally {
|
|
Date.now = originalDateNow;
|
|
}
|
|
});
|
|
|
|
test('consumeAnilistSetupCallbackUrl keeps setup open when token persistence fails', () => {
|
|
const events: string[] = [];
|
|
const handled = consumeAnilistSetupCallbackUrl({
|
|
rawUrl: 'subminer://anilist-setup?access_token=saved-token',
|
|
saveToken: (value: string) => {
|
|
events.push(`save:${value}`);
|
|
return false;
|
|
},
|
|
setCachedToken: () => events.push('cache'),
|
|
setResolvedState: () => events.push('state'),
|
|
setSetupPageOpened: (opened: boolean) => events.push(`opened:${opened}`),
|
|
onSuccess: () => events.push('success'),
|
|
closeWindow: () => events.push('close'),
|
|
});
|
|
|
|
assert.equal(handled, true);
|
|
assert.deepEqual(events, ['save:saved-token', 'opened:true']);
|
|
});
|
|
|
|
test('consumeAnilistSetupCallbackUrl ignores non-callback URLs', () => {
|
|
const events: string[] = [];
|
|
const handled = consumeAnilistSetupCallbackUrl({
|
|
rawUrl: 'https://anilist.co/settings/developer',
|
|
saveToken: () => {
|
|
events.push('save');
|
|
return true;
|
|
},
|
|
setCachedToken: () => events.push('cache'),
|
|
setResolvedState: () => events.push('state'),
|
|
setSetupPageOpened: () => events.push('opened'),
|
|
onSuccess: () => events.push('success'),
|
|
closeWindow: () => events.push('close'),
|
|
});
|
|
|
|
assert.equal(handled, false);
|
|
assert.deepEqual(events, []);
|
|
});
|