SubMiner/backlog/tasks/task-1.3 - Phase-3-Consolidate-related-service-modules.md

id, title, status, assignee, created_date, updated_date, labels, dependencies, references, parent_task_id, ordinal

id	title	status	assignee	created_date	updated_date	labels	dependencies	references	parent_task_id	ordinal
TASK-1.3	Phase 3: Consolidate related service modules	Done	codex	2026-02-10 18:46	2026-02-11 03:35		TASK-1.2	plan.md src/core/services/overlay-visibility-service.ts src/core/services/overlay-manager-service.ts src/core/services/overlay-shortcut-service.ts src/core/services/numeric-shortcut-session-service.ts src/core/services/app-ready-runtime-service.ts	TASK-1	5000

Description

Merge split modules for overlay visibility, broadcast, shortcuts, numeric shortcuts, and startup orchestration into cohesive service files.

Acceptance Criteria

• #1 Overlay visibility/runtime split is consolidated into a single service module.
• #2 Overlay broadcast functions are merged with overlay manager responsibilities.
• #3 Shortcut and numeric shortcut runtime/lifecycle splits are consolidated as described in plan.md.
• #4 Startup bootstrap and app-ready runtime orchestration is consolidated into one startup module.
• #5 pnpm run build && pnpm run test:core passes after Phase 3 completion.

Implementation Plan

1. Merge overlay-visibility-runtime-service.ts exports into overlay-visibility-service.ts and update imports/exports.
2. Merge overlay broadcast responsibilities from overlay-broadcast-runtime-service.ts into overlay-manager-service.ts while preserving current APIs used by main.ts.
3. Consolidate shortcut modules by absorbing lifecycle utilities into overlay-shortcut-service.ts and fallback-runner logic into overlay-shortcut-runtime-service.ts (or successor handler module), then remove obsolete files.
4. Merge numeric shortcut runtime/session split into a single numeric-shortcut-service.ts and update call sites/tests.
5. Merge startup bootstrap + app-ready orchestration into a single startup module, update imports, remove obsolete files, and run pnpm run build && pnpm run test:core.

Implementation Notes

Merged overlay visibility runtime API into overlay-visibility-service.ts and removed overlay-visibility-runtime-service.ts.

Merged overlay broadcast behavior into overlay-manager-service.ts (including manager-level broadcasting) and removed overlay-broadcast-runtime-service.ts + test, with equivalent coverage moved into overlay-manager-service.test.ts.

Consolidated shortcut modules into overlay-shortcut-service.ts (lifecycle) and new overlay-shortcut-handler.ts (runtime handlers + local fallback), removing overlay-shortcut-lifecycle-service.ts, overlay-shortcut-runtime-service.ts, and overlay-shortcut-fallback-runner.ts.

Merged numeric shortcut runtime/session split into numeric-shortcut-service.ts; removed numeric-shortcut-runtime-service.ts and merged runtime test coverage into session tests.

Merged startup bootstrap + app-ready orchestration into startup-service.ts; removed startup-bootstrap-runtime-service.ts and app-ready-runtime-service.ts with tests updated to new module path.

Verification: pnpm run build && pnpm run test:core passes after consolidation.