2.2 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | priority | ordinal | ||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-67 | Make wrapper stop auto-sending --start by default | Done | 2026-02-18 09:47 | 2026-02-19 23:18 |
|
high | 68000 |
Description
Update the subminer wrapper flow so it no longer appends --start automatically when launching the app, requiring explicit start semantics and allowing background AppImage workflow to be primary.
Acceptance Criteria
- #1 Wrapper launch path does not append --start unless explicitly requested
- #2 Existing explicit startup commands still work and are documented
- #3 Tests updated for new wrapper behavior
Implementation Notes
Launcher wrapper no longer auto-starts overlay from mpv plugin auto_start setting; only explicit --start/--start-overlay trigger wrapper-managed startup.
Simplified plugin runtime config parsing in launcher to consume socket_path only for wrapper behavior.
Updated docs examples and descriptions to make explicit startup flow clear (subminer --start video.mkv), and rebuilt bundled subminer script.
Validated with bun run build && make build-launcher && bun run test:fast.
Follow-up: updated mpv plugin command builder (plugin/subminer.lua) to stop forcing --start for toggle/show/hide actions; only explicit start action now sends start context. This avoids second-instance command failures when app is already running in background mode.
Final Summary
Updated the subminer wrapper to stop implicitly issuing app --start based on plugin auto-start settings, so background AppImage usage is the default and overlay startup happens only on explicit wrapper flags (--start/--start-overlay) or manual plugin commands. Also updated launcher docs/examples to reflect explicit startup semantics and regenerated the bundled subminer script.
Definition of Done
- #1 Validated with launcher-related tests or command simulation