mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-05-29 12:55:16 -07:00
5feed360ca
* fix: harden preload argv parsing for popup windows * fix: align youtube playback with shared overlay startup * fix: unwrap mpv youtube streams for anki media mining * docs: update docs for youtube subtitle and mining flow * refactor: unify cli and runtime wiring for startup and youtube flow * feat: update subtitle sidebar overlay behavior * chore: add shared log-file source for diagnostics * fix(ci): add changelog fragment for immersion changes * fix: address CodeRabbit review feedback * fix: persist canonical title from youtube metadata * style: format stats library tab * fix: address latest review feedback * style: format stats library files * test: stub launcher youtube deps in CI * test: isolate launcher youtube flow deps * test: stub launcher youtube deps in failing case * test: force x11 backend in launcher ci harness * test: address latest review feedback * fix(launcher): preserve user YouTube ytdl raw options * docs(backlog): update task tracking notes * fix(immersion): special-case youtube media paths in runtime and tracking * feat(stats): improve YouTube media metadata and picker key handling * fix(ci): format stats media library hook * fix: address latest CodeRabbit review items * docs: update youtube release notes and docs * feat: auto-load youtube subtitles before manual picker * fix: restore app-owned youtube subtitle flow * docs: update youtube playback docs and config copy * refactor: remove legacy youtube launcher mode plumbing * fix: refine youtube subtitle startup binding * docs: clarify youtube subtitle startup behavior * fix: address PR #31 latest review follow-ups * fix: address PR #31 follow-up review comments * test: harden youtube picker test harness * udpate backlog * fix: add timeout to youtube metadata probe * docs: refresh youtube and stats docs * update backlog * update backlog * chore: release v0.9.0
446 lines
13 KiB
TypeScript
446 lines
13 KiB
TypeScript
import assert from 'node:assert/strict';
|
|
import test from 'node:test';
|
|
import { initializeOverlayAnkiIntegration, initializeOverlayRuntime } from './overlay-runtime-init';
|
|
|
|
test('initializeOverlayRuntime skips Anki integration when ankiConnect.enabled is false', () => {
|
|
let createdIntegrations = 0;
|
|
let startedIntegrations = 0;
|
|
let setIntegrationCalls = 0;
|
|
|
|
initializeOverlayRuntime({
|
|
backendOverride: null,
|
|
createMainWindow: () => {},
|
|
registerGlobalShortcuts: () => {},
|
|
updateVisibleOverlayBounds: () => {},
|
|
isVisibleOverlayVisible: () => false,
|
|
updateVisibleOverlayVisibility: () => {},
|
|
getOverlayWindows: () => [],
|
|
syncOverlayShortcuts: () => {},
|
|
setWindowTracker: () => {},
|
|
getMpvSocketPath: () => '/tmp/mpv.sock',
|
|
createWindowTracker: () => null,
|
|
getResolvedConfig: () => ({
|
|
ankiConnect: { enabled: false } as never,
|
|
}),
|
|
getSubtitleTimingTracker: () => ({}),
|
|
getMpvClient: () => ({
|
|
send: () => {},
|
|
}),
|
|
getRuntimeOptionsManager: () => ({
|
|
getEffectiveAnkiConnectConfig: (config) => config as never,
|
|
}),
|
|
createAnkiIntegration: () => {
|
|
createdIntegrations += 1;
|
|
return {
|
|
start: () => {
|
|
startedIntegrations += 1;
|
|
},
|
|
};
|
|
},
|
|
setAnkiIntegration: () => {
|
|
setIntegrationCalls += 1;
|
|
},
|
|
showDesktopNotification: () => {},
|
|
createFieldGroupingCallback: () => async () => ({
|
|
keepNoteId: 1,
|
|
deleteNoteId: 2,
|
|
deleteDuplicate: false,
|
|
cancelled: false,
|
|
}),
|
|
getKnownWordCacheStatePath: () => '/tmp/known-words-cache.json',
|
|
});
|
|
|
|
assert.equal(createdIntegrations, 0);
|
|
assert.equal(startedIntegrations, 0);
|
|
assert.equal(setIntegrationCalls, 0);
|
|
});
|
|
|
|
test('initializeOverlayRuntime starts Anki integration when ankiConnect.enabled is true', () => {
|
|
let createdIntegrations = 0;
|
|
let startedIntegrations = 0;
|
|
let setIntegrationCalls = 0;
|
|
|
|
initializeOverlayRuntime({
|
|
backendOverride: null,
|
|
createMainWindow: () => {},
|
|
registerGlobalShortcuts: () => {},
|
|
updateVisibleOverlayBounds: () => {},
|
|
isVisibleOverlayVisible: () => false,
|
|
updateVisibleOverlayVisibility: () => {},
|
|
getOverlayWindows: () => [],
|
|
syncOverlayShortcuts: () => {},
|
|
setWindowTracker: () => {},
|
|
getMpvSocketPath: () => '/tmp/mpv.sock',
|
|
createWindowTracker: () => null,
|
|
getResolvedConfig: () => ({
|
|
ankiConnect: { enabled: true } as never,
|
|
}),
|
|
getSubtitleTimingTracker: () => ({}),
|
|
getMpvClient: () => ({
|
|
send: () => {},
|
|
}),
|
|
getRuntimeOptionsManager: () => ({
|
|
getEffectiveAnkiConnectConfig: (config) => config as never,
|
|
}),
|
|
createAnkiIntegration: (args) => {
|
|
createdIntegrations += 1;
|
|
assert.equal(args.config.enabled, true);
|
|
return {
|
|
start: () => {
|
|
startedIntegrations += 1;
|
|
},
|
|
};
|
|
},
|
|
setAnkiIntegration: () => {
|
|
setIntegrationCalls += 1;
|
|
},
|
|
showDesktopNotification: () => {},
|
|
createFieldGroupingCallback: () => async () => ({
|
|
keepNoteId: 3,
|
|
deleteNoteId: 4,
|
|
deleteDuplicate: false,
|
|
cancelled: false,
|
|
}),
|
|
getKnownWordCacheStatePath: () => '/tmp/known-words-cache.json',
|
|
});
|
|
|
|
assert.equal(createdIntegrations, 1);
|
|
assert.equal(startedIntegrations, 1);
|
|
assert.equal(setIntegrationCalls, 1);
|
|
});
|
|
|
|
test('initializeOverlayAnkiIntegration can initialize Anki transport after overlay runtime already exists', () => {
|
|
let createdIntegrations = 0;
|
|
let startedIntegrations = 0;
|
|
let setIntegrationCalls = 0;
|
|
|
|
initializeOverlayAnkiIntegration({
|
|
getResolvedConfig: () => ({
|
|
ankiConnect: { enabled: true } as never,
|
|
}),
|
|
getSubtitleTimingTracker: () => ({}),
|
|
getMpvClient: () => ({
|
|
send: () => {},
|
|
}),
|
|
getRuntimeOptionsManager: () => ({
|
|
getEffectiveAnkiConnectConfig: (config) => config as never,
|
|
}),
|
|
createAnkiIntegration: (args) => {
|
|
createdIntegrations += 1;
|
|
assert.equal(args.config.enabled, true);
|
|
return {
|
|
start: () => {
|
|
startedIntegrations += 1;
|
|
},
|
|
};
|
|
},
|
|
setAnkiIntegration: () => {
|
|
setIntegrationCalls += 1;
|
|
},
|
|
showDesktopNotification: () => {},
|
|
createFieldGroupingCallback: () => async () => ({
|
|
keepNoteId: 11,
|
|
deleteNoteId: 12,
|
|
deleteDuplicate: false,
|
|
cancelled: false,
|
|
}),
|
|
getKnownWordCacheStatePath: () => '/tmp/known-words-cache.json',
|
|
});
|
|
|
|
assert.equal(createdIntegrations, 1);
|
|
assert.equal(startedIntegrations, 1);
|
|
assert.equal(setIntegrationCalls, 1);
|
|
});
|
|
|
|
test('initializeOverlayAnkiIntegration returns false when integration already exists', () => {
|
|
let createdIntegrations = 0;
|
|
let startedIntegrations = 0;
|
|
let setIntegrationCalls = 0;
|
|
|
|
const result = initializeOverlayAnkiIntegration({
|
|
getResolvedConfig: () => ({
|
|
ankiConnect: { enabled: true } as never,
|
|
}),
|
|
getSubtitleTimingTracker: () => ({}),
|
|
getMpvClient: () => ({
|
|
send: () => {},
|
|
}),
|
|
getRuntimeOptionsManager: () => ({
|
|
getEffectiveAnkiConnectConfig: (config) => config as never,
|
|
}),
|
|
getAnkiIntegration: () => ({}),
|
|
createAnkiIntegration: () => {
|
|
createdIntegrations += 1;
|
|
return {
|
|
start: () => {
|
|
startedIntegrations += 1;
|
|
},
|
|
};
|
|
},
|
|
setAnkiIntegration: () => {
|
|
setIntegrationCalls += 1;
|
|
},
|
|
showDesktopNotification: () => {},
|
|
createFieldGroupingCallback: () => async () => ({
|
|
keepNoteId: 11,
|
|
deleteNoteId: 12,
|
|
deleteDuplicate: false,
|
|
cancelled: false,
|
|
}),
|
|
getKnownWordCacheStatePath: () => '/tmp/known-words-cache.json',
|
|
});
|
|
|
|
assert.equal(result, false);
|
|
assert.equal(createdIntegrations, 0);
|
|
assert.equal(startedIntegrations, 0);
|
|
assert.equal(setIntegrationCalls, 0);
|
|
});
|
|
|
|
test('initializeOverlayAnkiIntegration returns false when ankiConnect is disabled', () => {
|
|
let createdIntegrations = 0;
|
|
let startedIntegrations = 0;
|
|
let setIntegrationCalls = 0;
|
|
|
|
const result = initializeOverlayAnkiIntegration({
|
|
getResolvedConfig: () => ({
|
|
ankiConnect: { enabled: false } as never,
|
|
}),
|
|
getSubtitleTimingTracker: () => ({}),
|
|
getMpvClient: () => ({
|
|
send: () => {},
|
|
}),
|
|
getRuntimeOptionsManager: () => ({
|
|
getEffectiveAnkiConnectConfig: (config) => config as never,
|
|
}),
|
|
createAnkiIntegration: () => {
|
|
createdIntegrations += 1;
|
|
return {
|
|
start: () => {
|
|
startedIntegrations += 1;
|
|
},
|
|
};
|
|
},
|
|
setAnkiIntegration: () => {
|
|
setIntegrationCalls += 1;
|
|
},
|
|
showDesktopNotification: () => {},
|
|
createFieldGroupingCallback: () => async () => ({
|
|
keepNoteId: 11,
|
|
deleteNoteId: 12,
|
|
deleteDuplicate: false,
|
|
cancelled: false,
|
|
}),
|
|
getKnownWordCacheStatePath: () => '/tmp/known-words-cache.json',
|
|
});
|
|
|
|
assert.equal(result, false);
|
|
assert.equal(createdIntegrations, 0);
|
|
assert.equal(startedIntegrations, 0);
|
|
assert.equal(setIntegrationCalls, 0);
|
|
});
|
|
|
|
test('initializeOverlayRuntime can skip starting Anki integration transport', () => {
|
|
let createdIntegrations = 0;
|
|
let startedIntegrations = 0;
|
|
let setIntegrationCalls = 0;
|
|
|
|
initializeOverlayRuntime({
|
|
backendOverride: null,
|
|
createMainWindow: () => {},
|
|
registerGlobalShortcuts: () => {},
|
|
updateVisibleOverlayBounds: () => {},
|
|
isVisibleOverlayVisible: () => false,
|
|
updateVisibleOverlayVisibility: () => {},
|
|
getOverlayWindows: () => [],
|
|
syncOverlayShortcuts: () => {},
|
|
setWindowTracker: () => {},
|
|
getMpvSocketPath: () => '/tmp/mpv.sock',
|
|
createWindowTracker: () => null,
|
|
getResolvedConfig: () => ({
|
|
ankiConnect: { enabled: true } as never,
|
|
}),
|
|
getSubtitleTimingTracker: () => ({}),
|
|
getMpvClient: () => ({
|
|
send: () => {},
|
|
}),
|
|
getRuntimeOptionsManager: () => ({
|
|
getEffectiveAnkiConnectConfig: (config) => config as never,
|
|
}),
|
|
createAnkiIntegration: () => {
|
|
createdIntegrations += 1;
|
|
return {
|
|
start: () => {
|
|
startedIntegrations += 1;
|
|
},
|
|
};
|
|
},
|
|
setAnkiIntegration: () => {
|
|
setIntegrationCalls += 1;
|
|
},
|
|
showDesktopNotification: () => {},
|
|
createFieldGroupingCallback: () => async () => ({
|
|
keepNoteId: 7,
|
|
deleteNoteId: 8,
|
|
deleteDuplicate: false,
|
|
cancelled: false,
|
|
}),
|
|
getKnownWordCacheStatePath: () => '/tmp/known-words-cache.json',
|
|
shouldStartAnkiIntegration: () => false,
|
|
});
|
|
|
|
assert.equal(createdIntegrations, 1);
|
|
assert.equal(startedIntegrations, 0);
|
|
assert.equal(setIntegrationCalls, 1);
|
|
});
|
|
|
|
test('initializeOverlayRuntime merges shared ai config with Anki overrides', () => {
|
|
initializeOverlayRuntime({
|
|
backendOverride: null,
|
|
createMainWindow: () => {},
|
|
registerGlobalShortcuts: () => {},
|
|
updateVisibleOverlayBounds: () => {},
|
|
isVisibleOverlayVisible: () => false,
|
|
updateVisibleOverlayVisibility: () => {},
|
|
getOverlayWindows: () => [],
|
|
syncOverlayShortcuts: () => {},
|
|
setWindowTracker: () => {},
|
|
getMpvSocketPath: () => '/tmp/mpv.sock',
|
|
createWindowTracker: () => null,
|
|
getResolvedConfig: () => ({
|
|
ankiConnect: {
|
|
enabled: true,
|
|
ai: {
|
|
enabled: true,
|
|
model: 'openrouter/anki-model',
|
|
systemPrompt: 'Translate mined sentence text.',
|
|
},
|
|
} as never,
|
|
ai: {
|
|
enabled: true,
|
|
apiKey: 'shared-key',
|
|
baseUrl: 'https://openrouter.ai/api',
|
|
model: 'openrouter/shared-model',
|
|
systemPrompt: 'Legacy shared prompt.',
|
|
requestTimeoutMs: 15000,
|
|
},
|
|
}),
|
|
getSubtitleTimingTracker: () => ({}),
|
|
getMpvClient: () => ({
|
|
send: () => {},
|
|
}),
|
|
getRuntimeOptionsManager: () => ({
|
|
getEffectiveAnkiConnectConfig: (config) => config as never,
|
|
}),
|
|
createAnkiIntegration: (args) => {
|
|
assert.equal(args.aiConfig.apiKey, 'shared-key');
|
|
assert.equal(args.aiConfig.baseUrl, 'https://openrouter.ai/api');
|
|
assert.equal(args.aiConfig.model, 'openrouter/anki-model');
|
|
assert.equal(args.aiConfig.systemPrompt, 'Translate mined sentence text.');
|
|
return {
|
|
start: () => {},
|
|
};
|
|
},
|
|
setAnkiIntegration: () => {},
|
|
showDesktopNotification: () => {},
|
|
createFieldGroupingCallback: () => async () => ({
|
|
keepNoteId: 5,
|
|
deleteNoteId: 6,
|
|
deleteDuplicate: false,
|
|
cancelled: false,
|
|
}),
|
|
getKnownWordCacheStatePath: () => '/tmp/known-words-cache.json',
|
|
});
|
|
});
|
|
|
|
test('initializeOverlayRuntime re-syncs overlay shortcuts when tracker focus changes', () => {
|
|
let syncCalls = 0;
|
|
const tracker = {
|
|
onGeometryChange: null as ((...args: unknown[]) => void) | null,
|
|
onWindowFound: null as ((...args: unknown[]) => void) | null,
|
|
onWindowLost: null as (() => void) | null,
|
|
onWindowFocusChange: null as ((focused: boolean) => void) | null,
|
|
start: () => {},
|
|
};
|
|
|
|
initializeOverlayRuntime({
|
|
backendOverride: null,
|
|
createMainWindow: () => {},
|
|
registerGlobalShortcuts: () => {},
|
|
updateVisibleOverlayBounds: () => {},
|
|
isVisibleOverlayVisible: () => false,
|
|
updateVisibleOverlayVisibility: () => {},
|
|
getOverlayWindows: () => [],
|
|
syncOverlayShortcuts: () => {
|
|
syncCalls += 1;
|
|
},
|
|
setWindowTracker: () => {},
|
|
getMpvSocketPath: () => '/tmp/mpv.sock',
|
|
createWindowTracker: () => tracker as never,
|
|
getResolvedConfig: () => ({
|
|
ankiConnect: { enabled: false } as never,
|
|
}),
|
|
getSubtitleTimingTracker: () => null,
|
|
getMpvClient: () => null,
|
|
getRuntimeOptionsManager: () => null,
|
|
setAnkiIntegration: () => {},
|
|
showDesktopNotification: () => {},
|
|
createFieldGroupingCallback: () => async () => ({
|
|
keepNoteId: 1,
|
|
deleteNoteId: 2,
|
|
deleteDuplicate: false,
|
|
cancelled: false,
|
|
}),
|
|
getKnownWordCacheStatePath: () => '/tmp/known-words-cache.json',
|
|
});
|
|
|
|
assert.equal(typeof tracker.onWindowFocusChange, 'function');
|
|
tracker.onWindowFocusChange?.(true);
|
|
assert.equal(syncCalls, 1);
|
|
});
|
|
|
|
test('initializeOverlayRuntime refreshes visible overlay when tracker focus changes while overlay is shown', () => {
|
|
let visibilityRefreshCalls = 0;
|
|
const tracker = {
|
|
onGeometryChange: null as ((...args: unknown[]) => void) | null,
|
|
onWindowFound: null as ((...args: unknown[]) => void) | null,
|
|
onWindowLost: null as (() => void) | null,
|
|
onWindowFocusChange: null as ((focused: boolean) => void) | null,
|
|
start: () => {},
|
|
};
|
|
|
|
initializeOverlayRuntime({
|
|
backendOverride: null,
|
|
createMainWindow: () => {},
|
|
registerGlobalShortcuts: () => {},
|
|
updateVisibleOverlayBounds: () => {},
|
|
isVisibleOverlayVisible: () => true,
|
|
updateVisibleOverlayVisibility: () => {
|
|
visibilityRefreshCalls += 1;
|
|
},
|
|
getOverlayWindows: () => [],
|
|
syncOverlayShortcuts: () => {},
|
|
setWindowTracker: () => {},
|
|
getMpvSocketPath: () => '/tmp/mpv.sock',
|
|
createWindowTracker: () => tracker as never,
|
|
getResolvedConfig: () => ({
|
|
ankiConnect: { enabled: false } as never,
|
|
}),
|
|
getSubtitleTimingTracker: () => null,
|
|
getMpvClient: () => null,
|
|
getRuntimeOptionsManager: () => null,
|
|
setAnkiIntegration: () => {},
|
|
showDesktopNotification: () => {},
|
|
createFieldGroupingCallback: () => async () => ({
|
|
keepNoteId: 1,
|
|
deleteNoteId: 2,
|
|
deleteDuplicate: false,
|
|
cancelled: false,
|
|
}),
|
|
getKnownWordCacheStatePath: () => '/tmp/known-words-cache.json',
|
|
});
|
|
|
|
tracker.onWindowFocusChange?.(true);
|
|
|
|
assert.equal(visibilityRefreshCalls, 2);
|
|
});
|