mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-02-27 18:22:41 -08:00
1.5 KiB
1.5 KiB
id, title, status, assignee, created_date, labels, milestone, dependencies, references, priority
| id | title | status | assignee | created_date | labels | milestone | dependencies | references | priority | ||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-10 | Consolidate service naming conventions and barrel exports | To Do | 2026-02-11 08:21 |
|
Codebase Clarity & Composability |
|
low |
Description
The service layer has inconsistent naming:
- Some functions end in
Service:handleCliCommandService,loadSubtitlePositionService - Some end in
RuntimeService:replayCurrentSubtitleRuntimeService,sendMpvCommandRuntimeService - Some are plain:
shortcutMatchesInputForLocalFallback - Factory functions mix
create*DepsRuntimeServicewithcreate*Service
The barrel export (src/core/services/index.ts) re-exports 79 symbols from 28 files through a single surface, which obscures dependency boundaries. Consumers import everything from ./core/services and can't tell which service file they actually depend on.
Establish consistent naming:
- Exported service functions:
verbNounService(e.g.,handleCliCommand) - Deps factory functions:
create*Deps - Consider whether the barrel re-export is still the right pattern vs direct imports from individual files.
Acceptance Criteria
- #1 All service functions follow a consistent naming convention
- #2 Decision documented on barrel export vs direct imports
- #3 No functional changes