mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-08-05 07:21:34 -07:00
b1bdeabca8
* fix(jellyfin): show overlay, inject plugin, and fix stats title on playb - Show visible overlay automatically during Jellyfin playback so subtitleStyle applies - Inject bundled mpv plugin on auto-launch so keybindings work without overlay focus - Group Jellyfin playback stats under item metadata (jellyfin://host/item/id) instead of stream URLs so episodes merge with matching local titles - Mark ffsubsync unavailable in subsync modal for remote media paths - Drain queued second-instance commands even when onReady throws * fix(overlay): stabilize macOS focus handoff and sidebar Yomitan pause - Keep overlay visible during macOS foreground probe after overlay blur - Hold sidebar hover-pause while a Yomitan lookup popup remains open * fix(jellyfin): fix discovery loop, device identity, tray state, and Disc - Derive device identity from OS hostname; remove legacy configurable client/device fields - Prevent discovery playback from reloading active item, misreporting pause state, and duplicate overlay restores - Restart stale tray discovery sessions without re-login when server drops SubMiner cast target - Sync tray discovery checkbox state on Linux after CLI/startup/remote-session changes - Stop Discord presence falling back to stream URLs; prime title before tokenized stream loads - Fix picker library discovery when log level is above info - Fix config.example.jsonc trailing commas and array formatting * docs(release): trim and consolidate prerelease notes for 0.15.0 - Remove breaking changes section and several redundant bullet points - Consolidate per-platform updater notes into a single entry - Normalize em-dash separators to hyphens in section headers * fix(config): remove trailing commas from config.example.jsonc - Strip trailing commas throughout both config.example.jsonc copies - Reformat inline arrays to multi-line for JSON strictness - Update Jellyfin subtitle preload and playback launch tests and impl * fix(tokenizer): preserve known-word highlight when POS filters suppress - Known-word cache matches now set isKnown=true even for tokens excluded by POS filters - POS exclusion gate suppresses N+1, frequency, and JLPT only; known status is computed before the gate - Jellyfin subtitle preload continues after cleanup failures instead of aborting - Update config docs and option description to document the known-word bypass behavior * fix(jellyfin): send explicit hide/show overlay instead of toggle - Track overlay visibility in plugin state; y-t uses explicit hide/show commands when state is known - Prevent paused Jellyfin playback from resuming on overlay hide - Fix subtitle cache cleanup to only remove dirs after successful cleanup * fix(jellyfin): fix remote progress sync, seek reporting, and startup sto - arm active playback before loadfile with loadedMediaPath: null to suppress premature stop events - force immediate progress report on seek-like position jumps at the mpv time-pos level - send positionTicks and failed=false in reportStopped payload - remove EventName from HTTP timeline payloads (websocket-only field) - add startup grace window to drop stop events before media finishes loading * fix(jellyfin): fix overlay toggle sync, redirect reload, and AppImage bi - Sync visible-overlay state back to plugin via script messages to avoid toggle/hide drift - Collapse duplicate toggle events within 250ms to prevent hide-then-show on single keypress - Preserve manual hide across Jellyfin path-changing redirects even when media-title drops - Rearm managed subtitle defaults on path-changing redirects - Route toggleVisibleOverlay session binding through plugin toggle instead of app-side IPC - Show Linux/Hyprland overlay passively (showInactive) to avoid stealing mpv keyboard focus - Fix AppImage binary resolution to prefer $APPIMAGE env over mounted inner binary - Add stats window layer management so delete/update dialogs appear above stats window - Fix Jellyfin remote progress sync during Linux websocket reconnect windows * Fix CodeRabbit review feedback * fix(jellyfin): subtitle timing, resume progress, and overlay sync - Add per-stream subtitle delay persistence and auto timeline-offset correction - Strip server-selected subtitle stream from mpv load URL; suppress plugin subtitle rearm and auto-start during app-managed preload - Fix resume position lost when mpv resets on stop; use last known position for final progress/stopped reports - Keep Play vs Resume distinct to avoid early seek race on normal play - Fix discovery resume when remote play sends StartPositionTicks=0 despite saved progress - Deduplicate show/hide overlay commands using recorded visibility state - Rewrite docs-site Jellyfin page around cast-to-device UX * test: update lifecycle cleanup assertion * fix: clear aborted playback state, fix overlay passthrough, and guard du - Reset app_managed_playback_pending on lifecycle cleanup to prevent state leak into next item - Record visible overlay action only after command succeeds, not before - Non-native passive overlay now always click-through on re-show (fix isNonNativePassiveOverlay ordering) - Defer activeParsedSubtitleMediaPath assignment until after prefetch completes - Move autoplay gate release into the hide branch of toggleVisibleOverlay - Clear active Jellyfin playback when stopping media that never loaded - Reset managed subtitle delay and delay key when no external tracks are available - Await async removeDir in subtitle cache cleanup - Guard duplicate delete clicks in MediaDetailView and SessionsTab with refs - Escape key in DeleteConfirmDialog now calls stopPropagation and stopImmediatePropagation
369 lines
10 KiB
TypeScript
369 lines
10 KiB
TypeScript
import assert from 'node:assert/strict';
|
|
import test from 'node:test';
|
|
import {
|
|
clearJellyfinAuthSessionAndRefreshTray,
|
|
isJellyfinConfiguredForTray,
|
|
toggleJellyfinDiscoveryFromTray,
|
|
} from './jellyfin-tray-discovery';
|
|
|
|
test('detects Jellyfin tray configuration when Jellyfin has a server URL', () => {
|
|
assert.equal(
|
|
isJellyfinConfiguredForTray({
|
|
getResolvedJellyfinConfig: () => ({
|
|
enabled: true,
|
|
serverUrl: 'http://server:8096',
|
|
accessToken: 'token',
|
|
userId: 'user',
|
|
}),
|
|
}),
|
|
true,
|
|
);
|
|
|
|
assert.equal(
|
|
isJellyfinConfiguredForTray({
|
|
getResolvedJellyfinConfig: () => ({
|
|
enabled: true,
|
|
serverUrl: 'http://server:8096',
|
|
}),
|
|
}),
|
|
true,
|
|
);
|
|
|
|
assert.equal(
|
|
isJellyfinConfiguredForTray({
|
|
getResolvedJellyfinConfig: () => ({
|
|
enabled: false,
|
|
serverUrl: 'http://server:8096',
|
|
accessToken: 'token',
|
|
userId: 'user',
|
|
}),
|
|
}),
|
|
false,
|
|
);
|
|
|
|
assert.equal(
|
|
isJellyfinConfiguredForTray({
|
|
getResolvedJellyfinConfig: () => ({
|
|
enabled: true,
|
|
serverUrl: '',
|
|
accessToken: 'token',
|
|
userId: 'user',
|
|
}),
|
|
}),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test('clears stored auth, stops active discovery, and refreshes tray', () => {
|
|
const calls: string[] = [];
|
|
|
|
clearJellyfinAuthSessionAndRefreshTray({
|
|
clearStoredSession: () => calls.push('clear'),
|
|
getRemoteSession: () => ({ advertiseNow: async () => true }),
|
|
stopRemoteSession: () => calls.push('stop'),
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message) => calls.push(`error:${message}`),
|
|
},
|
|
});
|
|
|
|
assert.deepEqual(calls, ['clear', 'stop', 'refresh']);
|
|
});
|
|
|
|
test('clear auth still refreshes tray when clear or stop throws', () => {
|
|
const calls: string[] = [];
|
|
|
|
clearJellyfinAuthSessionAndRefreshTray({
|
|
clearStoredSession: () => {
|
|
throw new Error('clear failed');
|
|
},
|
|
getRemoteSession: () => ({ advertiseNow: async () => true }),
|
|
stopRemoteSession: () => {
|
|
throw new Error('stop failed');
|
|
},
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message) => calls.push(`error:${message}`),
|
|
},
|
|
});
|
|
|
|
assert.deepEqual(calls, [
|
|
'error:Failed to clear Jellyfin auth session.',
|
|
'error:Failed to stop Jellyfin discovery while clearing auth session.',
|
|
'refresh',
|
|
]);
|
|
});
|
|
|
|
test('starts explicit discovery and advertises cast target from tray', async () => {
|
|
const calls: string[] = [];
|
|
let session: { advertiseNow: () => Promise<boolean> } | null = null;
|
|
|
|
await toggleJellyfinDiscoveryFromTray({
|
|
getRemoteSession: () => session,
|
|
stopRemoteSession: () => calls.push('stop'),
|
|
startRemoteSession: async (options) => {
|
|
assert.deepEqual(options, { explicit: true });
|
|
calls.push('start');
|
|
session = {
|
|
advertiseNow: async () => {
|
|
calls.push('advertise');
|
|
return true;
|
|
},
|
|
};
|
|
},
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message) => calls.push(`error:${message}`),
|
|
},
|
|
showMpvOsd: (message) => calls.push(`osd:${message}`),
|
|
});
|
|
|
|
assert.deepEqual(calls, [
|
|
'start',
|
|
'advertise',
|
|
'info:Jellyfin discovery started; cast target is visible in server sessions.',
|
|
'osd:Jellyfin discovery started',
|
|
'refresh',
|
|
]);
|
|
});
|
|
|
|
test('starts explicit discovery and reports pending visibility from tray', async () => {
|
|
const calls: string[] = [];
|
|
let session: { advertiseNow: () => Promise<boolean> } | null = null;
|
|
|
|
await toggleJellyfinDiscoveryFromTray({
|
|
getRemoteSession: () => session,
|
|
stopRemoteSession: () => calls.push('stop'),
|
|
startRemoteSession: async (options) => {
|
|
assert.deepEqual(options, { explicit: true });
|
|
calls.push('start');
|
|
session = {
|
|
advertiseNow: async () => {
|
|
calls.push('advertise');
|
|
return false;
|
|
},
|
|
};
|
|
},
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message) => calls.push(`error:${message}`),
|
|
},
|
|
showMpvOsd: (message) => calls.push(`osd:${message}`),
|
|
});
|
|
|
|
assert.deepEqual(calls, [
|
|
'start',
|
|
'advertise',
|
|
'warn:Jellyfin discovery started, but cast target is not visible yet.',
|
|
'osd:Jellyfin discovery started; waiting for visibility',
|
|
'refresh',
|
|
]);
|
|
});
|
|
|
|
test('stops active discovery from tray', async () => {
|
|
const calls: string[] = [];
|
|
|
|
await toggleJellyfinDiscoveryFromTray({
|
|
getRemoteSession: () => ({ advertiseNow: async () => true }),
|
|
stopRemoteSession: () => calls.push('stop'),
|
|
startRemoteSession: async () => {
|
|
calls.push('start');
|
|
},
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message) => calls.push(`error:${message}`),
|
|
},
|
|
showMpvOsd: (message) => calls.push(`osd:${message}`),
|
|
});
|
|
|
|
assert.deepEqual(calls, [
|
|
'stop',
|
|
'info:Jellyfin discovery stopped.',
|
|
'osd:Jellyfin discovery stopped',
|
|
'refresh',
|
|
]);
|
|
});
|
|
|
|
test('uses checked tray state to start discovery instead of blind toggling', async () => {
|
|
const calls: string[] = [];
|
|
let session: { advertiseNow: () => Promise<boolean> } | null = null;
|
|
|
|
await toggleJellyfinDiscoveryFromTray(
|
|
{
|
|
getRemoteSession: () => session,
|
|
stopRemoteSession: () => calls.push('stop'),
|
|
startRemoteSession: async (options) => {
|
|
assert.deepEqual(options, { explicit: true });
|
|
calls.push('start');
|
|
session = {
|
|
advertiseNow: async () => {
|
|
calls.push('advertise');
|
|
return true;
|
|
},
|
|
};
|
|
},
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message) => calls.push(`error:${message}`),
|
|
},
|
|
showMpvOsd: (message) => calls.push(`osd:${message}`),
|
|
},
|
|
{ desiredActive: true },
|
|
);
|
|
|
|
assert.deepEqual(calls, [
|
|
'start',
|
|
'advertise',
|
|
'info:Jellyfin discovery started; cast target is visible in server sessions.',
|
|
'osd:Jellyfin discovery started',
|
|
'refresh',
|
|
]);
|
|
});
|
|
|
|
test('uses unchecked tray state to stop discovery without visibility probing', async () => {
|
|
const calls: string[] = [];
|
|
|
|
await toggleJellyfinDiscoveryFromTray(
|
|
{
|
|
getRemoteSession: () => ({
|
|
advertiseNow: async () => {
|
|
calls.push('advertise');
|
|
return true;
|
|
},
|
|
}),
|
|
stopRemoteSession: () => calls.push('stop'),
|
|
startRemoteSession: async () => {
|
|
calls.push('start');
|
|
},
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message) => calls.push(`error:${message}`),
|
|
},
|
|
showMpvOsd: (message) => calls.push(`osd:${message}`),
|
|
},
|
|
{ desiredActive: false },
|
|
);
|
|
|
|
assert.deepEqual(calls, [
|
|
'stop',
|
|
'info:Jellyfin discovery stopped.',
|
|
'osd:Jellyfin discovery stopped',
|
|
'refresh',
|
|
]);
|
|
});
|
|
|
|
test('restarts active discovery when current session is not visible', async () => {
|
|
const calls: string[] = [];
|
|
let session: { advertiseNow: () => Promise<boolean> } | null = {
|
|
advertiseNow: async () => {
|
|
calls.push('advertise-stale');
|
|
return false;
|
|
},
|
|
};
|
|
|
|
await toggleJellyfinDiscoveryFromTray({
|
|
getRemoteSession: () => session,
|
|
stopRemoteSession: () => {
|
|
calls.push('stop');
|
|
session = null;
|
|
},
|
|
startRemoteSession: async (options) => {
|
|
assert.deepEqual(options, { explicit: true });
|
|
calls.push('start');
|
|
session = {
|
|
advertiseNow: async () => {
|
|
calls.push('advertise-fresh');
|
|
return true;
|
|
},
|
|
};
|
|
},
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message) => calls.push(`error:${message}`),
|
|
},
|
|
showMpvOsd: (message) => calls.push(`osd:${message}`),
|
|
});
|
|
|
|
assert.deepEqual(calls, [
|
|
'advertise-stale',
|
|
'warn:Jellyfin discovery was active but not visible; restarting.',
|
|
'stop',
|
|
'start',
|
|
'advertise-fresh',
|
|
'info:Jellyfin discovery started; cast target is visible in server sessions.',
|
|
'osd:Jellyfin discovery started',
|
|
'refresh',
|
|
]);
|
|
});
|
|
|
|
test('warns and refreshes tray when explicit discovery cannot create a session', async () => {
|
|
const calls: string[] = [];
|
|
|
|
await toggleJellyfinDiscoveryFromTray({
|
|
getRemoteSession: () => null,
|
|
stopRemoteSession: () => calls.push('stop'),
|
|
startRemoteSession: async () => {
|
|
calls.push('start');
|
|
},
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message) => calls.push(`error:${message}`),
|
|
},
|
|
showMpvOsd: (message) => calls.push(`osd:${message}`),
|
|
});
|
|
|
|
assert.deepEqual(calls, [
|
|
'start',
|
|
'warn:Jellyfin discovery could not start. Configure Jellyfin first.',
|
|
'osd:Jellyfin discovery unavailable',
|
|
'refresh',
|
|
]);
|
|
});
|
|
|
|
test('reports discovery toggle failures and still refreshes tray', async () => {
|
|
const calls: string[] = [];
|
|
const error = new Error('boom');
|
|
|
|
await toggleJellyfinDiscoveryFromTray({
|
|
getRemoteSession: () => null,
|
|
stopRemoteSession: () => calls.push('stop'),
|
|
startRemoteSession: async () => {
|
|
throw error;
|
|
},
|
|
refreshTrayMenu: () => calls.push('refresh'),
|
|
logger: {
|
|
info: (message) => calls.push(`info:${message}`),
|
|
warn: (message) => calls.push(`warn:${message}`),
|
|
error: (message, actualError) => {
|
|
calls.push(`error:${message}`);
|
|
assert.equal(actualError, error);
|
|
},
|
|
},
|
|
showMpvOsd: (message) => calls.push(`osd:${message}`),
|
|
});
|
|
|
|
assert.deepEqual(calls, [
|
|
'error:Failed to toggle Jellyfin discovery.',
|
|
'osd:Jellyfin discovery failed',
|
|
'refresh',
|
|
]);
|
|
});
|