SubMiner/backlog/completed/task-229 - Address-PR-31-final-CodeRabbit-picker-test-follow-up.md at 983f3b38eebf2b72e2814feac3d31408f867e9e0 - SubMiner

mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-04-01 06:12:07 -07:00

Files

chore: archive completed backlog tasks and update ordinals

- Move ~35 completed tasks from backlog/tasks/ to backlog/completed/
- Add ordinal fields to remaining in-progress task files
- Mark task-255 (playlist browser modal) as Done with final notes

2026-03-31 12:38:27 -07:00

2.0 KiB

Raw Blame History

id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority, ordinal

title

status

assignee

created_date

updated_date

labels

dependencies

references

priority

ordinal

TASK-229

Address PR #31 final CodeRabbit picker test follow-up

Done

codex

2026-03-24 04:27

2026-03-24 06:41

pr-review

coderabbit

PR #31 feat: add app-owned YouTube subtitle flow with absPlayer-style parsing

CodeRabbit comment on src/renderer/modals/youtube-track-picker.test.ts global restoration / harness duplication

medium

145500

Description

Fix the remaining CodeRabbit comment on the YouTube picker test file by restoring absent globals correctly and reducing repeated test harness setup so global stubbing is consistent and isolated.

Acceptance Criteria

#1 Picker tests restore window, document, and CustomEvent without leaving undefined-valued globals behind.
#2 Repeated picker test setup is consolidated enough to remove the current review complaint.
#3 Relevant picker tests pass and PR thread is updated.

Implementation Plan

Add a failing regression around global restoration semantics in the YouTube picker test harness.
Extract shared DOM/environment helpers and restore logic using delete when globals were originally absent.
Re-run focused tests and typecheck, then commit/push and reply on the PR thread.

Implementation Notes

Latest CodeRabbit comment targets youtube-track-picker.test.ts harness cleanup and correct restoration of global properties.

Final Summary

Addressed the last PR #31 CodeRabbit comment by refactoring the YouTube picker test harness to use shared DOM/env helpers, restoring absent globals via delete semantics, adding a regression for cleanup behavior, and pushing commit 039e2f56 with focused picker tests plus typecheck passing.

2.0 KiB Raw Blame History