mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-30 06:12:06 -07:00
1.5 KiB
1.5 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | priority | ordinal | |||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-243 | Assess and address PR #36 latest CodeRabbit review round | Done | 2026-03-29 07:39 | 2026-03-29 07:41 |
|
|
high | 3600 |
Description
Inspect the latest CodeRabbit review round on PR #36, verify each actionable comment against the current branch, implement the confirmed fixes, and verify the touched paths.
Acceptance Criteria
- #1 Confirmed review comments are implemented or explicitly deferred with rationale.
- #2 Touched paths are verified with the smallest sufficient test/build lane.
- #3 Current PR feedback is reduced to resolved or intentionally deferred suggestions.
Final Summary
Addressed the confirmed latest CodeRabbit review items on PR #36. scripts/run-coverage-lane.ts now uses the Bun-style import.meta.main entrypoint check with a local ts-ignore to preserve the repo's CommonJS typecheck settings. src/core/services/immersion-tracker/maintenance.ts no longer shadows the imported nowMs helper in retention functions. src/main.ts now centralizes the startup-mode predicates behind a shared helper and releases resolvedSource.cleanup on the cached-subtitle fast path so materialized sources do not leak.