mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-02 06:22:42 -08:00
1.4 KiB
1.4 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | priority | ordinal |
|---|---|---|---|---|---|---|---|---|---|
| TASK-79 | Jimaku modal: auto-close after successful subtitle load | Done | 2026-03-01 13:52 | 2026-03-01 14:06 | medium | 10000 |
Description
Fix Jimaku modal UX so selecting a subtitle file closes the modal automatically once subtitle download+load succeeds.
Current behavior:
- Subtitle file downloads and loads into mpv.
- Jimaku modal remains open until manual close.
Expected behavior:
- On successful
jimakuDownloadFileresult, close modal immediately. - Keep error behavior unchanged (stay open + show error).
Acceptance Criteria
- #1 Successful subtitle file selection/download in Jimaku closes modal automatically.
- #2 Existing error path keeps modal open and shows error.
- #3 Regression test covers success auto-close behavior.
Final Summary
Fixed renderer Jimaku success flow to close modal immediately after successful jimakuDownloadFile result. Added regression test (src/renderer/modals/jimaku.test.ts) that reproduces keyboard file-selection success path and asserts modal close state + notifyOverlayModalClosed('jimaku') emission. Kept failure path unchanged.
Also wired new test into test:core:src and test:core:dist package scripts.