SubMiner/backlog/tasks/task-325 - Keep-JLPT-underline-color-fixed-with-combined-lookup-annotations.md at 8342fa0c0e66b12f1695763a23f0cdf10dd55c9e - SubMiner

sudacode/SubMiner

Fork 0

mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-05-04 00:41:33 -07:00

Files

T

sudacode b245ca642d

Fix JLPT underline color drift and AniList skipped-threshold sync

- Replace JLPT `text-decoration` underlines with `border-bottom` so Chromium selection/hover cannot repaint them to another annotation's color
- Lock JLPT underline color for combined annotation selectors (known, n+1, frequency) and character hover/selection states
- Trigger AniList post-watch check on every mpv time-position update to catch skipped completion thresholds
- Fall back to filename-parser season/episode when guessit omits them

2026-05-04 00:06:27 -07:00

2.8 KiB

Raw Blame History

id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority

title

status

assignee

created_date

updated_date

labels

dependencies

references

priority

TASK-325

Keep JLPT underline color fixed with combined lookup annotations

Done

@Codex

2026-05-04 00:25

2026-05-04 00:28

overlay

jlpt

renderer

TASK-318

TASK-308

medium

Description

Yomitan lookup on a subtitle token that has a JLPT level plus another annotation such as frequency or known-word highlighting can make the JLPT underline take the other annotation color. The underline must always remain the token's JLPT level color; other annotation classes may still control text color.

Acceptance Criteria

#1 A JLPT token combined with frequency styling keeps its underline set to the configured JLPT level color during lookup/selection styling.
#2 A JLPT token combined with known-word styling keeps its underline set to the configured JLPT level color during lookup/selection styling.
#3 Regression coverage exercises combined JLPT plus non-JLPT annotation selectors, including character span selection/hover styling used by lookup.

Implementation Plan

Add focused renderer CSS regression coverage for combined word-jlpt-n* plus known/frequency classes, including .c::selection/.c:hover lookup paths.
Run bun test src/renderer/subtitle-render.test.ts and confirm the new assertion fails on the current CSS.
Update src/renderer/style.css so JLPT decoration color is locked on the token and child character spans without changing text color priority for known/frequency/name/N+1 annotations.
Re-run the focused renderer test, then run typecheck/changelog checks as scope requires.

Implementation Notes

Added red/green renderer CSS regression for combined JLPT plus known/N+1/frequency annotation classes and character hover lookup paths. Current CSS failed before the lock selectors were added; focused test passes after the CSS change.

Final Summary

Fixed JLPT underline color drift for tokens that also carry known-word, N+1, or frequency annotation classes. The renderer CSS now explicitly locks the underline decoration color for combined JLPT annotation selectors, hover, character hover, and selection states while preserving the existing text color priority for other annotations.

Added renderer regression coverage for combined JLPT plus non-JLPT annotation selectors and lookup character hover paths. Added a user-visible changelog fragment.

Checks: bun test src/renderer/subtitle-render.test.ts; bun run changelog:lint; bun run typecheck; bun run format:check:src.

2.8 KiB Raw Blame History