mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-06 19:57:26 -08:00
2.4 KiB
2.4 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | priority | ordinal |
|---|---|---|---|---|---|---|---|---|---|
| TASK-77 | Subtitle hover: auto-pause playback with config toggle | Done | 2026-02-28 22:43 | 2026-03-04 12:07 | medium | 8000 |
Description
Add a user-facing subtitle config option to pause mpv playback when the cursor hovers subtitle text and resume playback when the cursor leaves.
Scope:
- New config key:
subtitleStyle.autoPauseVideoOnHover. - Default should be enabled.
- Hover pause/resume must not unpause if playback was already paused before hover.
- Docs/examples/tests updated.
Acceptance Criteria
- #1
subtitleStyle.autoPauseVideoOnHoverexists and defaults totrue. - #2 Overlay pauses playback on subtitle hover and resumes on leave only when hover-triggered pause occurred.
- #3 Main/renderer IPC exposes pause-state query for safe hover behavior.
- #4 Config docs/examples and user docs/readme mention the new behavior and toggle.
- #5 Regression tests cover config parsing/validation and hover behavior edge cases.
Final Summary
Implemented subtitleStyle.autoPauseVideoOnHover with default true, wired through config defaults/resolution/types, renderer state/style, and mouse hover handlers. Added playback pause-state IPC (getPlaybackPaused) to avoid false resume when media was already paused. Added renderer hover behavior tests (including race/cancel case) and config/resolve tests. Updated config examples and docs (README, usage, shortcuts, mining workflow, configuration) to document default hover pause/resume behavior and disable path.
Follow-up adjustments (2026-03-04):
- Hover pause now resumes immediately when leaving subtitle text (no Yomitan-popup hover retention).
- Added
subtitleStyle.autoPauseVideoOnYomitanPopup(defaultfalse) to optionally keep playback paused while Yomitan popup is open, with auto-resume on close only when SubMiner initiated the popup pause. - Yomitan popup control keybinds added while popup is open:
J/Kscroll,Mmine,Paudio play,[previous audio variant,]next audio variant (within selected source). - Extension copy drift detection widened so popup runtime changes are reliably re-copied on launch (
popup.js,popup-main.js,display.js,display-audio.js).