SubMiner/backlog/tasks/task-107 - Fix-post-rebase-overlay-toggle-regression.md

id, title, status, assignee, created_date, updated_date, labels, dependencies, priority, ordinal

id	title	status	assignee	created_date	updated_date	labels	dependencies	priority	ordinal
TASK-107	Fix post-rebase overlay toggle regression	Done	codex	2026-02-21 23:34	2026-02-22 07:49	bug overlay regression		high	98000

Description

After recent rebase, toggling visible or invisible overlay opens a transparent non-interactable window. Symptoms:

• invisible subtitle mode no longer renders/works,
• visible subtitles do not show,
• overlay keybinds do not work on the created window.

Need root-cause fix so both overlay modes render and interactive/keybind behavior returns to pre-rebase behavior.

Action Steps

1. Reproduce regression in source tests around overlay toggle/window behavior.
2. Add failing regression test for transparent/non-interactable overlay window path.
3. Identify rebase-introduced break in overlay creation/runtime toggle wiring.
4. Implement minimal fix for renderer loading + window interaction state.
5. Verify with focused tests and smoke checks.

Acceptance Criteria

• #1 Toggling visible overlay shows subtitle content again.
• #2 Toggling invisible overlay restores interactive subtitle behavior.
• #3 Overlay keybinds work after overlay toggle in both modes.
• #4 Added regression coverage for broken toggle path.

Implementation Notes

• Root-cause candidate fixed: renderer layer detection could trust preload process.argv over per-window query params, which can drift under shared renderer process and force wrong layer behavior.
• Changed src/renderer/utils/platform.ts to prioritize window.location.search (?layer=visible|invisible) and only fallback to preload layer when query is missing/invalid.
• Added regression test in src/renderer/error-recovery.test.ts asserting query-layer precedence.
• Added explicit webPreferences.sandbox = false in src/core/services/overlay-window.ts to keep preload Node-style API availability stable on newer Electron defaults.
• Added regression test src/core/services/overlay-window-config.test.ts to guard sandbox setting.
• Validation: bun test src/core/services/overlay-window-config.test.ts src/renderer/error-recovery.test.ts; bun run build.

Definition of Done

• #1 Focused overlay/runtime tests pass.
• #2 No new type/build regressions introduced by fix.
• #3 Task notes include root cause and validation commands.