mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-07-07 13:08:54 -07:00
b1bdeabca8
* fix(jellyfin): show overlay, inject plugin, and fix stats title on playb - Show visible overlay automatically during Jellyfin playback so subtitleStyle applies - Inject bundled mpv plugin on auto-launch so keybindings work without overlay focus - Group Jellyfin playback stats under item metadata (jellyfin://host/item/id) instead of stream URLs so episodes merge with matching local titles - Mark ffsubsync unavailable in subsync modal for remote media paths - Drain queued second-instance commands even when onReady throws * fix(overlay): stabilize macOS focus handoff and sidebar Yomitan pause - Keep overlay visible during macOS foreground probe after overlay blur - Hold sidebar hover-pause while a Yomitan lookup popup remains open * fix(jellyfin): fix discovery loop, device identity, tray state, and Disc - Derive device identity from OS hostname; remove legacy configurable client/device fields - Prevent discovery playback from reloading active item, misreporting pause state, and duplicate overlay restores - Restart stale tray discovery sessions without re-login when server drops SubMiner cast target - Sync tray discovery checkbox state on Linux after CLI/startup/remote-session changes - Stop Discord presence falling back to stream URLs; prime title before tokenized stream loads - Fix picker library discovery when log level is above info - Fix config.example.jsonc trailing commas and array formatting * docs(release): trim and consolidate prerelease notes for 0.15.0 - Remove breaking changes section and several redundant bullet points - Consolidate per-platform updater notes into a single entry - Normalize em-dash separators to hyphens in section headers * fix(config): remove trailing commas from config.example.jsonc - Strip trailing commas throughout both config.example.jsonc copies - Reformat inline arrays to multi-line for JSON strictness - Update Jellyfin subtitle preload and playback launch tests and impl * fix(tokenizer): preserve known-word highlight when POS filters suppress - Known-word cache matches now set isKnown=true even for tokens excluded by POS filters - POS exclusion gate suppresses N+1, frequency, and JLPT only; known status is computed before the gate - Jellyfin subtitle preload continues after cleanup failures instead of aborting - Update config docs and option description to document the known-word bypass behavior * fix(jellyfin): send explicit hide/show overlay instead of toggle - Track overlay visibility in plugin state; y-t uses explicit hide/show commands when state is known - Prevent paused Jellyfin playback from resuming on overlay hide - Fix subtitle cache cleanup to only remove dirs after successful cleanup * fix(jellyfin): fix remote progress sync, seek reporting, and startup sto - arm active playback before loadfile with loadedMediaPath: null to suppress premature stop events - force immediate progress report on seek-like position jumps at the mpv time-pos level - send positionTicks and failed=false in reportStopped payload - remove EventName from HTTP timeline payloads (websocket-only field) - add startup grace window to drop stop events before media finishes loading * fix(jellyfin): fix overlay toggle sync, redirect reload, and AppImage bi - Sync visible-overlay state back to plugin via script messages to avoid toggle/hide drift - Collapse duplicate toggle events within 250ms to prevent hide-then-show on single keypress - Preserve manual hide across Jellyfin path-changing redirects even when media-title drops - Rearm managed subtitle defaults on path-changing redirects - Route toggleVisibleOverlay session binding through plugin toggle instead of app-side IPC - Show Linux/Hyprland overlay passively (showInactive) to avoid stealing mpv keyboard focus - Fix AppImage binary resolution to prefer $APPIMAGE env over mounted inner binary - Add stats window layer management so delete/update dialogs appear above stats window - Fix Jellyfin remote progress sync during Linux websocket reconnect windows * Fix CodeRabbit review feedback * fix(jellyfin): subtitle timing, resume progress, and overlay sync - Add per-stream subtitle delay persistence and auto timeline-offset correction - Strip server-selected subtitle stream from mpv load URL; suppress plugin subtitle rearm and auto-start during app-managed preload - Fix resume position lost when mpv resets on stop; use last known position for final progress/stopped reports - Keep Play vs Resume distinct to avoid early seek race on normal play - Fix discovery resume when remote play sends StartPositionTicks=0 despite saved progress - Deduplicate show/hide overlay commands using recorded visibility state - Rewrite docs-site Jellyfin page around cast-to-device UX * test: update lifecycle cleanup assertion * fix: clear aborted playback state, fix overlay passthrough, and guard du - Reset app_managed_playback_pending on lifecycle cleanup to prevent state leak into next item - Record visible overlay action only after command succeeds, not before - Non-native passive overlay now always click-through on re-show (fix isNonNativePassiveOverlay ordering) - Defer activeParsedSubtitleMediaPath assignment until after prefetch completes - Move autoplay gate release into the hide branch of toggleVisibleOverlay - Clear active Jellyfin playback when stopping media that never loaded - Reset managed subtitle delay and delay key when no external tracks are available - Await async removeDir in subtitle cache cleanup - Guard duplicate delete clicks in MediaDetailView and SessionsTab with refs - Escape key in DeleteConfirmDialog now calls stopPropagation and stopImmediatePropagation
745 lines
24 KiB
TypeScript
745 lines
24 KiB
TypeScript
import assert from 'node:assert/strict';
|
|
import test from 'node:test';
|
|
import { createPlayJellyfinItemInMpvHandler } from './jellyfin-playback-launch';
|
|
|
|
const baseSession = {
|
|
serverUrl: 'http://localhost:8096',
|
|
accessToken: 'token',
|
|
userId: 'uid',
|
|
username: 'alice',
|
|
};
|
|
|
|
const baseClientInfo = {
|
|
clientName: 'SubMiner',
|
|
clientVersion: '1.0.0',
|
|
deviceId: 'did',
|
|
};
|
|
|
|
test('playback handler throws when mpv is not connected', async () => {
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => false,
|
|
getMpvClient: () => null,
|
|
resolvePlaybackPlan: async () => {
|
|
throw new Error('unreachable');
|
|
},
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: () => {},
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: () => {},
|
|
showMpvOsd: () => {},
|
|
});
|
|
|
|
await assert.rejects(
|
|
() =>
|
|
handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-1',
|
|
}),
|
|
/MPV not connected and auto-launch failed/,
|
|
);
|
|
});
|
|
|
|
test('playback handler drives mpv commands and playback state', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const scheduled: Array<{ delay: number; callback: () => void }> = [];
|
|
const calls: string[] = [];
|
|
const activeStates: Array<Record<string, unknown>> = [];
|
|
const reportPayloads: Array<Record<string, unknown>> = [];
|
|
const statsMetadata: Array<Record<string, unknown>> = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8',
|
|
mode: 'direct',
|
|
title: 'Episode 1',
|
|
itemTitle: 'Episode 1',
|
|
seriesTitle: 'Show Title',
|
|
seasonNumber: 1,
|
|
episodeNumber: 1,
|
|
startTimeTicks: 12_000_000,
|
|
audioStreamIndex: 1,
|
|
subtitleStreamIndex: 2,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => calls.push('defaults'),
|
|
showVisibleOverlay: () => calls.push('visible-overlay'),
|
|
sendMpvCommand: (command) => commands.push(command),
|
|
armQuitOnDisconnect: () => calls.push('arm'),
|
|
schedule: (callback, delayMs) => {
|
|
scheduled.push({ delay: delayMs, callback });
|
|
},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {
|
|
calls.push('preload');
|
|
},
|
|
setActivePlayback: (state) => activeStates.push(state as Record<string, unknown>),
|
|
setLastProgressAtMs: (value) => calls.push(`progress:${value}`),
|
|
reportPlaying: (payload) => reportPayloads.push(payload as Record<string, unknown>),
|
|
showMpvOsd: (text) => calls.push(`osd:${text}`),
|
|
recordJellyfinPlaybackMetadata: (metadata) => {
|
|
statsMetadata.push(metadata as Record<string, unknown>);
|
|
},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-1',
|
|
});
|
|
|
|
assert.deepEqual(commands.slice(0, 8), [
|
|
['set_property', 'sub-auto', 'no'],
|
|
['set_property', 'sid', 'no'],
|
|
['set_property', 'secondary-sid', 'no'],
|
|
['set_property', 'sub-visibility', 'no'],
|
|
['set_property', 'secondary-sub-visibility', 'no'],
|
|
['script-message', 'subminer-managed-subtitles-loading'],
|
|
[
|
|
'loadfile',
|
|
'https://stream.example/video.m3u8',
|
|
'replace',
|
|
-1,
|
|
'sid=no,secondary-sid=no,sub-auto=no,sub-visibility=no,secondary-sub-visibility=no,start=1.2',
|
|
],
|
|
['set_property', 'force-media-title', 'Episode 1'],
|
|
]);
|
|
assert.equal(scheduled.length, 0);
|
|
assert.equal(
|
|
commands.filter((command) => command[0] === 'set_property' && command[1] === 'sid').length,
|
|
1,
|
|
);
|
|
|
|
assert.ok(calls.includes('defaults'));
|
|
assert.ok(
|
|
calls.indexOf('preload') < calls.indexOf('visible-overlay'),
|
|
'visible overlay should be shown after Jellyfin subtitles are selected',
|
|
);
|
|
assert.ok(calls.includes('visible-overlay'));
|
|
assert.ok(calls.includes('arm'));
|
|
assert.ok(calls.includes('preload'));
|
|
assert.ok(calls.includes('progress:0'));
|
|
assert.ok(calls.includes('osd:Jellyfin direct: Episode 1'));
|
|
|
|
assert.equal(activeStates.length, 1);
|
|
assert.equal(activeStates[0]?.playMethod, 'DirectPlay');
|
|
assert.equal(activeStates[0]?.lastKnownPositionSeconds, 1.2);
|
|
assert.equal(reportPayloads.length, 1);
|
|
assert.equal(reportPayloads[0]?.eventName, 'start');
|
|
assert.equal(reportPayloads[0]?.positionTicks, 12_000_000);
|
|
assert.equal(reportPayloads[0]?.isPaused, false);
|
|
assert.deepEqual(statsMetadata, [
|
|
{
|
|
mediaPath: 'https://stream.example/video.m3u8',
|
|
displayTitle: 'Episode 1',
|
|
itemTitle: 'Episode 1',
|
|
seriesTitle: 'Show Title',
|
|
seasonNumber: 1,
|
|
episodeNumber: 1,
|
|
itemId: 'item-1',
|
|
},
|
|
]);
|
|
});
|
|
|
|
test('playback handler waits for Jellyfin subtitle preload before showing visible overlay', async () => {
|
|
const calls: string[] = [];
|
|
let resolvePreload!: () => void;
|
|
const preloadComplete = new Promise<void>((resolve) => {
|
|
resolvePreload = resolve;
|
|
});
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8',
|
|
mode: 'direct',
|
|
title: 'Episode 1',
|
|
itemTitle: 'Episode 1',
|
|
seriesTitle: 'Show Title',
|
|
seasonNumber: 1,
|
|
episodeNumber: 1,
|
|
startTimeTicks: 0,
|
|
audioStreamIndex: 1,
|
|
subtitleStreamIndex: 2,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => calls.push('visible-overlay'),
|
|
sendMpvCommand: () => {},
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: async () => {
|
|
calls.push('preload-start');
|
|
await preloadComplete;
|
|
calls.push('preload-done');
|
|
},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: () => {},
|
|
showMpvOsd: () => {},
|
|
});
|
|
|
|
const playback = handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-1',
|
|
});
|
|
for (let i = 0; i < 5 && calls.length === 0; i += 1) {
|
|
await Promise.resolve();
|
|
}
|
|
|
|
assert.equal(calls.length, 1);
|
|
assert.equal(calls[0], 'preload-start');
|
|
resolvePreload();
|
|
await playback;
|
|
|
|
assert.deepEqual(calls, ['preload-start', 'preload-done', 'visible-overlay']);
|
|
});
|
|
|
|
test('playback handler strips Jellyfin subtitle stream from mpv load URL', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const reports: Array<Record<string, unknown>> = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://jellyfin.local/Videos/ep-1/stream?static=true&api_key=secret-token&MediaSourceId=ms-1&AudioStreamIndex=3&SubtitleStreamIndex=4',
|
|
mode: 'direct',
|
|
title: 'Episode 1',
|
|
itemTitle: 'Episode 1',
|
|
seriesTitle: null,
|
|
seasonNumber: null,
|
|
episodeNumber: null,
|
|
startTimeTicks: 0,
|
|
audioStreamIndex: 3,
|
|
subtitleStreamIndex: 4,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => commands.push(command),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: (payload) => reports.push(payload),
|
|
showMpvOsd: () => {},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'ep-1',
|
|
});
|
|
|
|
const loadCommand = commands.find((command) => command[0] === 'loadfile');
|
|
assert.ok(loadCommand);
|
|
const url = new URL(String(loadCommand[1]));
|
|
assert.equal(url.searchParams.get('AudioStreamIndex'), '3');
|
|
assert.equal(url.searchParams.has('SubtitleStreamIndex'), false);
|
|
assert.equal(reports[0]?.subtitleStreamIndex, 4);
|
|
});
|
|
|
|
test('playback handler starts remote Play from beginning when requested despite saved plan progress', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const reportPayloads: Array<Record<string, unknown>> = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8?api_key=token&StartTimeTicks=35000000',
|
|
mode: 'transcode',
|
|
title: 'Episode 2',
|
|
itemTitle: 'Episode 2',
|
|
seriesTitle: null,
|
|
seasonNumber: null,
|
|
episodeNumber: null,
|
|
startTimeTicks: 35_000_000,
|
|
audioStreamIndex: null,
|
|
subtitleStreamIndex: null,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => commands.push(command),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: (payload) => reportPayloads.push(payload as Record<string, unknown>),
|
|
showMpvOsd: () => {},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-2',
|
|
startTimeTicksOverride: 0,
|
|
fallbackToPlanStartTimeOnZeroOverride: false,
|
|
});
|
|
|
|
const loadCommand = commands.find((command) => command[0] === 'loadfile');
|
|
assert.ok(loadCommand);
|
|
const loadedUrl = String(loadCommand[1] ?? '');
|
|
const parsed = new URL(loadedUrl);
|
|
assert.equal(parsed.searchParams.get('StartTimeTicks'), null);
|
|
assert.equal(
|
|
commands.some((command) => command[0] === 'seek'),
|
|
false,
|
|
);
|
|
assert.equal(reportPayloads[0]?.positionTicks, 0);
|
|
});
|
|
|
|
test('playback handler disables mpv subtitle selection before Jellyfin media loads', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8',
|
|
mode: 'direct',
|
|
title: 'Episode 1',
|
|
itemTitle: 'Episode 1',
|
|
seriesTitle: null,
|
|
seasonNumber: null,
|
|
episodeNumber: null,
|
|
startTimeTicks: 0,
|
|
audioStreamIndex: null,
|
|
subtitleStreamIndex: null,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => commands.push(command),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: () => {},
|
|
showMpvOsd: () => {},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-1',
|
|
});
|
|
|
|
const loadIndex = commands.findIndex((command) => command[0] === 'loadfile');
|
|
assert.ok(loadIndex > 0);
|
|
assert.ok(
|
|
commands.findIndex(
|
|
(command, index) =>
|
|
index < loadIndex &&
|
|
command[0] === 'script-message' &&
|
|
command[1] === 'subminer-managed-subtitles-loading',
|
|
) >= 0,
|
|
);
|
|
assert.ok(
|
|
commands.findIndex(
|
|
(command, index) =>
|
|
index < loadIndex &&
|
|
command[0] === 'set_property' &&
|
|
command[1] === 'sid' &&
|
|
command[2] === 'no',
|
|
) >= 0,
|
|
);
|
|
assert.ok(
|
|
commands.findIndex(
|
|
(command, index) =>
|
|
index < loadIndex &&
|
|
command[0] === 'set_property' &&
|
|
command[1] === 'secondary-sid' &&
|
|
command[2] === 'no',
|
|
) >= 0,
|
|
);
|
|
assert.ok(
|
|
commands.findIndex(
|
|
(command, index) =>
|
|
index < loadIndex &&
|
|
command[0] === 'set_property' &&
|
|
command[1] === 'sub-visibility' &&
|
|
command[2] === 'no',
|
|
) >= 0,
|
|
);
|
|
assert.ok(
|
|
commands.findIndex(
|
|
(command, index) =>
|
|
index < loadIndex &&
|
|
command[0] === 'set_property' &&
|
|
command[1] === 'secondary-sub-visibility' &&
|
|
command[2] === 'no',
|
|
) >= 0,
|
|
);
|
|
assert.equal(
|
|
commands[loadIndex]?.[4],
|
|
'sid=no,secondary-sid=no,sub-auto=no,sub-visibility=no,secondary-sub-visibility=no',
|
|
);
|
|
});
|
|
|
|
test('playback handler publishes Jellyfin title before loading tokenized stream url', async () => {
|
|
const timeline: string[] = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://jellyfin.local/Videos/ep-1/stream?static=true&api_key=secret-token&MediaSourceId=ms-1',
|
|
mode: 'direct',
|
|
title: 'Galaxy Quest S02E07 A New Hope',
|
|
itemTitle: 'A New Hope',
|
|
seriesTitle: 'Galaxy Quest',
|
|
seasonNumber: 2,
|
|
episodeNumber: 7,
|
|
startTimeTicks: 0,
|
|
audioStreamIndex: null,
|
|
subtitleStreamIndex: null,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => timeline.push(`cmd:${command[0]}:${String(command[1] ?? '')}`),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: () => {},
|
|
showMpvOsd: () => {},
|
|
updateCurrentMediaTitle: (title) => {
|
|
timeline.push(`title:${title}`);
|
|
},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'ep-1',
|
|
});
|
|
|
|
const titleIndex = timeline.indexOf('title:Galaxy Quest S02E07 A New Hope');
|
|
const loadIndex = timeline.findIndex((entry) => entry.startsWith('cmd:loadfile:'));
|
|
assert.ok(titleIndex >= 0);
|
|
assert.ok(loadIndex >= 0);
|
|
assert.ok(titleIndex < loadIndex);
|
|
assert.equal(timeline[titleIndex]?.includes('api_key'), false);
|
|
});
|
|
|
|
test('playback handler arms unloaded active playback before loading mpv media', async () => {
|
|
const timeline: string[] = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8',
|
|
mode: 'direct',
|
|
title: 'Episode 1',
|
|
itemTitle: 'Episode 1',
|
|
seriesTitle: null,
|
|
seasonNumber: null,
|
|
episodeNumber: null,
|
|
startTimeTicks: 0,
|
|
audioStreamIndex: null,
|
|
subtitleStreamIndex: null,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => timeline.push(`cmd:${command[0]}`),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: (state) => timeline.push(`active:${String(state.loadedMediaPath)}`),
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: () => {},
|
|
showMpvOsd: () => {},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-1',
|
|
});
|
|
|
|
assert.ok(timeline.indexOf('active:null') >= 0);
|
|
assert.ok(timeline.indexOf('active:null') < timeline.indexOf('cmd:loadfile'));
|
|
});
|
|
|
|
test('playback handler applies start override to stream url for remote resume', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8?api_key=token',
|
|
mode: 'transcode',
|
|
title: 'Episode 2',
|
|
itemTitle: 'Episode 2',
|
|
seriesTitle: null,
|
|
seasonNumber: null,
|
|
episodeNumber: null,
|
|
startTimeTicks: 0,
|
|
audioStreamIndex: null,
|
|
subtitleStreamIndex: null,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => commands.push(command),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: () => {},
|
|
showMpvOsd: () => {},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-2',
|
|
startTimeTicksOverride: 55_000_000,
|
|
});
|
|
|
|
const loadCommand = commands.find((command) => command[0] === 'loadfile');
|
|
assert.ok(loadCommand);
|
|
const loadedUrl = String(loadCommand[1] ?? '');
|
|
const parsed = new URL(loadedUrl);
|
|
assert.equal(parsed.searchParams.get('StartTimeTicks'), '55000000');
|
|
assert.equal(
|
|
commands.some((command) => command[0] === 'seek'),
|
|
false,
|
|
);
|
|
});
|
|
|
|
test('playback handler keeps Jellyfin resume ticks when remote start override is zero', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const reportPayloads: Array<Record<string, unknown>> = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8?api_key=token&StartTimeTicks=35000000',
|
|
mode: 'transcode',
|
|
title: 'Episode 2',
|
|
itemTitle: 'Episode 2',
|
|
seriesTitle: null,
|
|
seasonNumber: null,
|
|
episodeNumber: null,
|
|
startTimeTicks: 35_000_000,
|
|
audioStreamIndex: null,
|
|
subtitleStreamIndex: null,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => commands.push(command),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: (payload) => reportPayloads.push(payload as Record<string, unknown>),
|
|
showMpvOsd: () => {},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-2',
|
|
startTimeTicksOverride: 0,
|
|
fallbackToPlanStartTimeOnZeroOverride: true,
|
|
});
|
|
|
|
const loadCommand = commands.find((command) => command[0] === 'loadfile');
|
|
assert.ok(loadCommand);
|
|
const loadedUrl = String(loadCommand[1] ?? '');
|
|
const parsed = new URL(loadedUrl);
|
|
assert.equal(parsed.searchParams.get('StartTimeTicks'), '35000000');
|
|
assert.equal(
|
|
commands.some((command) => command[0] === 'seek'),
|
|
false,
|
|
);
|
|
assert.equal(reportPayloads[0]?.positionTicks, 35_000_000);
|
|
});
|
|
|
|
test('playback handler does not let stats metadata failures block playback startup', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8',
|
|
mode: 'direct',
|
|
title: 'Episode 3',
|
|
itemTitle: 'Episode 3',
|
|
seriesTitle: null,
|
|
seasonNumber: null,
|
|
episodeNumber: null,
|
|
startTimeTicks: 0,
|
|
audioStreamIndex: null,
|
|
subtitleStreamIndex: null,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => commands.push(command),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: () => {},
|
|
showMpvOsd: () => {},
|
|
recordJellyfinPlaybackMetadata: () => {
|
|
throw new Error('stats db unavailable');
|
|
},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-3',
|
|
});
|
|
|
|
assert.deepEqual(
|
|
commands.find((command) => command[0] === 'loadfile'),
|
|
[
|
|
'loadfile',
|
|
'https://stream.example/video.m3u8',
|
|
'replace',
|
|
-1,
|
|
'sid=no,secondary-sid=no,sub-auto=no,sub-visibility=no,secondary-sub-visibility=no',
|
|
],
|
|
);
|
|
});
|
|
|
|
test('playback handler does not let media title failures block playback startup', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8',
|
|
mode: 'direct',
|
|
title: 'Episode 4',
|
|
itemTitle: 'Episode 4',
|
|
seriesTitle: null,
|
|
seasonNumber: null,
|
|
episodeNumber: null,
|
|
startTimeTicks: 0,
|
|
audioStreamIndex: null,
|
|
subtitleStreamIndex: null,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => commands.push(command),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: () => {},
|
|
showMpvOsd: () => {},
|
|
updateCurrentMediaTitle: () => {
|
|
throw new Error('title state unavailable');
|
|
},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-4',
|
|
});
|
|
|
|
assert.deepEqual(
|
|
commands.find((command) => command[0] === 'loadfile'),
|
|
[
|
|
'loadfile',
|
|
'https://stream.example/video.m3u8',
|
|
'replace',
|
|
-1,
|
|
'sid=no,secondary-sid=no,sub-auto=no,sub-visibility=no,secondary-sub-visibility=no',
|
|
],
|
|
);
|
|
});
|
|
|
|
test('playback handler handles rejected best-effort hook promises', async () => {
|
|
const commands: Array<Array<string | number>> = [];
|
|
const handler = createPlayJellyfinItemInMpvHandler({
|
|
ensureMpvConnectedForPlayback: async () => true,
|
|
getMpvClient: () => ({ connected: true, send: () => {} }),
|
|
resolvePlaybackPlan: async () => ({
|
|
url: 'https://stream.example/video.m3u8',
|
|
mode: 'direct',
|
|
title: 'Episode 5',
|
|
itemTitle: 'Episode 5',
|
|
seriesTitle: null,
|
|
seasonNumber: null,
|
|
episodeNumber: null,
|
|
startTimeTicks: 0,
|
|
audioStreamIndex: null,
|
|
subtitleStreamIndex: null,
|
|
}),
|
|
applyJellyfinMpvDefaults: () => {},
|
|
showVisibleOverlay: () => {},
|
|
sendMpvCommand: (command) => commands.push(command),
|
|
armQuitOnDisconnect: () => {},
|
|
schedule: () => {},
|
|
convertTicksToSeconds: (ticks) => ticks / 10_000_000,
|
|
preloadExternalSubtitles: () => {},
|
|
setActivePlayback: () => {},
|
|
setLastProgressAtMs: () => {},
|
|
reportPlaying: () => {},
|
|
showMpvOsd: () => {},
|
|
updateCurrentMediaTitle: async () => {
|
|
throw new Error('title async unavailable');
|
|
},
|
|
recordJellyfinPlaybackMetadata: async () => {
|
|
throw new Error('stats async unavailable');
|
|
},
|
|
});
|
|
|
|
await handler({
|
|
session: baseSession,
|
|
clientInfo: baseClientInfo,
|
|
jellyfinConfig: {},
|
|
itemId: 'item-5',
|
|
});
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
|
|
assert.deepEqual(
|
|
commands.find((command) => command[0] === 'loadfile'),
|
|
[
|
|
'loadfile',
|
|
'https://stream.example/video.m3u8',
|
|
'replace',
|
|
-1,
|
|
'sid=no,secondary-sid=no,sub-auto=no,sub-visibility=no,secondary-sub-visibility=no',
|
|
],
|
|
);
|
|
});
|