SubMiner/backlog/tasks/task-224 - Auto-load-default-YouTube-subtitles-at-playback-start-and-make-picker-manual-only.md at 5feed360caa29aed4e61cefc78f206d52774ff55 - SubMiner

mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-03-24 00:11:27 -07:00

Files

sudacode 5feed360ca feat: add app-owned YouTube subtitle flow with absPlayer-style parsing (#31 )

* fix: harden preload argv parsing for popup windows

* fix: align youtube playback with shared overlay startup

* fix: unwrap mpv youtube streams for anki media mining

* docs: update docs for youtube subtitle and mining flow

* refactor: unify cli and runtime wiring for startup and youtube flow

* feat: update subtitle sidebar overlay behavior

* chore: add shared log-file source for diagnostics

* fix(ci): add changelog fragment for immersion changes

* fix: address CodeRabbit review feedback

* fix: persist canonical title from youtube metadata

* style: format stats library tab

* fix: address latest review feedback

* style: format stats library files

* test: stub launcher youtube deps in CI

* test: isolate launcher youtube flow deps

* test: stub launcher youtube deps in failing case

* test: force x11 backend in launcher ci harness

* test: address latest review feedback

* fix(launcher): preserve user YouTube ytdl raw options

* docs(backlog): update task tracking notes

* fix(immersion): special-case youtube media paths in runtime and tracking

* feat(stats): improve YouTube media metadata and picker key handling

* fix(ci): format stats media library hook

* fix: address latest CodeRabbit review items

* docs: update youtube release notes and docs

* feat: auto-load youtube subtitles before manual picker

* fix: restore app-owned youtube subtitle flow

* docs: update youtube playback docs and config copy

* refactor: remove legacy youtube launcher mode plumbing

* fix: refine youtube subtitle startup binding

* docs: clarify youtube subtitle startup behavior

* fix: address PR #31 latest review follow-ups

* fix: address PR #31 follow-up review comments

* test: harden youtube picker test harness

* udpate backlog

* fix: add timeout to youtube metadata probe

* docs: refresh youtube and stats docs

* update backlog

* update backlog

* chore: release v0.9.0

2026-03-24 00:01:24 -07:00

3.7 KiB

Raw Blame History

id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority, ordinal

title

status

assignee

created_date

updated_date

labels

dependencies

references

priority

ordinal

TASK-224

Auto-load default YouTube subtitles at playback start and make picker manual-only

Done

Codex

2026-03-23 18:51

2026-03-24 06:41

youtube

mpv

overlay

keybindings

/Users/sudacode/projects/japanese/SubMiner/src/main/runtime/youtube-flow.ts

/Users/sudacode/projects/japanese/SubMiner/src/renderer/modals/youtube-track-picker.ts

/Users/sudacode/projects/japanese/SubMiner/src/config/definitions/shared.ts

high

150500

Description

Replace the mandatory YouTube subtitle picker startup flow with automatic default-track loading. On YouTube playback start, attempt to load the default primary subtitle and best-effort secondary subtitle without prompting. Gate playback only on primary subtitle load/tokenization readiness. If primary subtitle probing/download/loading fails, resume playback and report the failure through the configured notification/output path. Keep the YouTube subtitle picker as a regular overlay modal opened by a new default keybinding during active YouTube playback.

Acceptance Criteria

#1 Opening a YouTube URL auto-selects and attempts to load the default primary subtitle without opening the picker modal.
#2 Opening a YouTube URL also attempts to load the default secondary subtitle when available, but playback never waits on secondary success.
#3 Playback remains gated only until the primary subtitle is loaded and tokenization is ready; primary failure resumes playback immediately.
#4 Primary auto-load failures report through the existing configured notification/output path and keep playback running.
#5 The YouTube subtitle picker can be opened manually during active YouTube playback via a new default keybinding.
#6 Regression tests cover startup auto-load success, primary failure fallback, and the manual picker keybinding flow.

Implementation Plan

Add failing tests for YouTube startup auto-load success, primary failure fallback, and manual picker keybinding flow.
Refactor the YouTube runtime to auto-select default tracks on startup, gate playback only on primary subtitle/tokenization readiness, and route failures through the configured notification/output path.
Add a new default keybinding and command path to open the YouTube picker manually during active YouTube playback.
Run targeted tests, then SubMiner verification lanes for launcher/runtime changes; update docs/changelog if required by the final behavior change.

Implementation Notes

Verification blocker outside this change: bun run test:fast still fails at scripts/update-aur-package.test.ts on macOS because scripts/update-aur-package.sh uses mapfile, which is unavailable in the system Bash 3.x environment used here.

Final Summary

Reworked app-owned YouTube playback to auto-load the default primary subtitle plus a best-effort secondary subtitle at startup instead of forcing the picker modal first. Playback now waits only on primary subtitle load/tokenization readiness, routes startup primary-failure messaging through the configured notification output path, and keeps the YouTube subtitle picker available on demand via a new default Ctrl+Shift+J keybinding during active YouTube playback. Updated the runtime/IPC/config plumbing, user-facing help/docs, and added regression coverage for startup auto-load, primary-failure fallback, and manual picker invocation.

3.7 KiB Raw Blame History