SubMiner/backlog/tasks/task-218 - Delete-zero-session-media-from-stats-library-and-trends.md at 5feed360caa29aed4e61cefc78f206d52774ff55 - SubMiner

mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-03-24 00:11:27 -07:00

Files

sudacode 5feed360ca feat: add app-owned YouTube subtitle flow with absPlayer-style parsing (#31 )

* fix: harden preload argv parsing for popup windows

* fix: align youtube playback with shared overlay startup

* fix: unwrap mpv youtube streams for anki media mining

* docs: update docs for youtube subtitle and mining flow

* refactor: unify cli and runtime wiring for startup and youtube flow

* feat: update subtitle sidebar overlay behavior

* chore: add shared log-file source for diagnostics

* fix(ci): add changelog fragment for immersion changes

* fix: address CodeRabbit review feedback

* fix: persist canonical title from youtube metadata

* style: format stats library tab

* fix: address latest review feedback

* style: format stats library files

* test: stub launcher youtube deps in CI

* test: isolate launcher youtube flow deps

* test: stub launcher youtube deps in failing case

* test: force x11 backend in launcher ci harness

* test: address latest review feedback

* fix(launcher): preserve user YouTube ytdl raw options

* docs(backlog): update task tracking notes

* fix(immersion): special-case youtube media paths in runtime and tracking

* feat(stats): improve YouTube media metadata and picker key handling

* fix(ci): format stats media library hook

* fix: address latest CodeRabbit review items

* docs: update youtube release notes and docs

* feat: auto-load youtube subtitles before manual picker

* fix: restore app-owned youtube subtitle flow

* docs: update youtube playback docs and config copy

* refactor: remove legacy youtube launcher mode plumbing

* fix: refine youtube subtitle startup binding

* docs: clarify youtube subtitle startup behavior

* fix: address PR #31 latest review follow-ups

* fix: address PR #31 follow-up review comments

* test: harden youtube picker test harness

* udpate backlog

* fix: add timeout to youtube metadata probe

* docs: refresh youtube and stats docs

* update backlog

* update backlog

* chore: release v0.9.0

2026-03-24 00:01:24 -07:00

3.8 KiB

Raw Blame History

id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority, ordinal

title

status

assignee

created_date

updated_date

labels

dependencies

references

priority

ordinal

TASK-218

Delete zero-session media from stats library and trends

Done

codex

2026-03-22 16:20

2026-03-24 06:41

stats

immersion-tracker

/Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/query.ts

/Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/lifetime.ts

/Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/maintenance.ts

/Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/__tests__/query.test.ts

medium

153500

Description

Deleting the last retained session for a video still left stale lifetime media rows and trend rollups behind, so the stats dashboard could continue showing ghost entries in Library and Trends after all sessions were gone.

Acceptance Criteria

#1 Deleting the final session for a video removes that media from Library queries and detail reads
#2 Deleting the final session for a video removes stale daily/monthly trend rollups for that media
#3 Regression coverage proves zero-session media disappears from affected stats surfaces after deletion

Implementation Plan

Add a failing regression around deleting the only retained session for a video while preexisting lifetime and rollup rows exist.
Patch the deletion path to rebuild lifetime and rollup state from retained sessions inside the same transaction.
Run focused immersion-tracker tests plus the repo-native verifier core lane and record results.

Implementation Notes

Added a query regression that seeds a finished session plus stale lifetime media/anime rows and daily/monthly rollups, deletes that only session, and asserts Library, Anime detail, and Trends all drop the media immediately.

Refactored lifetime rebuild logic so it can run inside an existing delete transaction, then reused that helper from deleteSession, deleteSessions, and deleteVideo.

Added a rollup rebuild helper that clears existing daily/monthly rollups and reconstructs them from retained telemetry inside the current transaction so deleted sessions cannot leave ghost trend points behind.

Verification passed:

bun test src/core/services/immersion-tracker/__tests__/query.test.ts
bun test src/core/services/immersion-tracker-service.test.ts
bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker/lifetime.ts src/core/services/immersion-tracker/maintenance.ts src/core/services/immersion-tracker/__tests__/query.test.ts
bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker/lifetime.ts src/core/services/immersion-tracker/maintenance.ts src/core/services/immersion-tracker/__tests__/query.test.ts

Verifier artifact dir: .tmp/skill-verification/subminer-verify-20260322-210718-n6sGL8

Final Summary

Delete paths now rebuild lifetime summaries and trend rollups after removing sessions, so when the last session for a video disappears the stats database also drops that media from Library, related detail reads, and chart data. Added a regression proving a video with only stale lifetime/rollup rows vanishes after its final session is deleted, and verified the change with focused immersion-tracker tests plus the SubMiner core verification lane.

3.8 KiB Raw Blame History