sudacode
5feed360ca
* fix: harden preload argv parsing for popup windows * fix: align youtube playback with shared overlay startup * fix: unwrap mpv youtube streams for anki media mining * docs: update docs for youtube subtitle and mining flow * refactor: unify cli and runtime wiring for startup and youtube flow * feat: update subtitle sidebar overlay behavior * chore: add shared log-file source for diagnostics * fix(ci): add changelog fragment for immersion changes * fix: address CodeRabbit review feedback * fix: persist canonical title from youtube metadata * style: format stats library tab * fix: address latest review feedback * style: format stats library files * test: stub launcher youtube deps in CI * test: isolate launcher youtube flow deps * test: stub launcher youtube deps in failing case * test: force x11 backend in launcher ci harness * test: address latest review feedback * fix(launcher): preserve user YouTube ytdl raw options * docs(backlog): update task tracking notes * fix(immersion): special-case youtube media paths in runtime and tracking * feat(stats): improve YouTube media metadata and picker key handling * fix(ci): format stats media library hook * fix: address latest CodeRabbit review items * docs: update youtube release notes and docs * feat: auto-load youtube subtitles before manual picker * fix: restore app-owned youtube subtitle flow * docs: update youtube playback docs and config copy * refactor: remove legacy youtube launcher mode plumbing * fix: refine youtube subtitle startup binding * docs: clarify youtube subtitle startup behavior * fix: address PR #31 latest review follow-ups * fix: address PR #31 follow-up review comments * test: harden youtube picker test harness * udpate backlog * fix: add timeout to youtube metadata probe * docs: refresh youtube and stats docs * update backlog * update backlog * chore: release v0.9.0
3.9 KiB
id, title, status, assignee, created_date, updated_date, labels, milestone, dependencies, references, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | milestone | dependencies | references | priority | ordinal | ||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-191 | Assess PR #19 CodeRabbit review follow-ups | Done |
|
2026-03-17 23:15 | 2026-03-23 03:22 |
|
m-1 |
|
medium | 139500 |
Description
Validate the open CodeRabbit review comments on PR #19 against the current branch, implement only the confirmed fixes, and record which bot suggestions are stale or technically incomplete.
Acceptance Criteria
- #1 Each open CodeRabbit PR #19 comment is validated against the current branch behavior
- #2 Confirmed issues are fixed with regression coverage where it fits
- #3 Non-actionable or partially-wrong bot guidance is documented explicitly
Implementation Plan
- Inspect the open CodeRabbit review threads on PR #19 and restate each finding in codebase terms.
- Add failing regression tests for any verified bugs before changing production code.
- Patch the smallest safe service-layer behavior, rerun focused verification, and record which suggestions were accepted versus rejected.
Implementation Notes
Validated the two open CodeRabbit inline findings on PR #19 against the current branch. Both reported real bugs in ImmersionTrackerService, but the first suggestion's exact remediation was incomplete for this codebase.
reassignAnimeAnilist did overwrite imm_anime.description with NULL when callers omitted description. Fixed with a presence-aware SQL update that preserves the existing description when the field is omitted while still allowing explicit description: null to clear the stored value. Rejected the bot's COALESCE(?, description) prompt because that would silently remove the explicit-clear behavior the API already supports.
ensureCoverArt could return true after a fetcher reported success even when no cover-art row/blob was stored, because undefined !== null evaluated truthy through optional chaining. Fixed by loading the row into a local variable and requiring a non-null blob.
Added regression coverage in src/core/services/immersion-tracker-service.test.ts for omitted-description preservation, explicit-null clearing, and the no-row ensureCoverArt false-positive case.
Verification passed:
bun test src/core/services/immersion-tracker-service.test.tsbash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh src/core/services/immersion-tracker-service.ts src/core/services/immersion-tracker-service.test.tsbash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/core/services/immersion-tracker-service.ts src/core/services/immersion-tracker-service.test.ts
Verifier artifact directory: .tmp/skill-verification/subminer-verify-20260317-231743-wHFNnN
Final Summary
Assessed the open PR #19 CodeRabbit comments and fixed the two confirmed service-layer regressions. reassignAnimeAnilist now preserves an existing anime description when callers omit the description field but still clears it on explicit null, and ensureCoverArt no longer reports success when no cover-art row/blob exists after a fetch attempt.
Both comments were actionable, but one bot-proposed fix was not correct as written for this branch: replacing the description update with COALESCE(?, description) would have broken intentional description clearing. Added regression tests for the accepted behaviors and verified the change with the full touched service test file plus the SubMiner core verification lane.