3.2 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | priority | |||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-112 | Address Claude review items on PR 15 | Done |
|
2026-03-08 00:11 | 2026-03-08 00:12 |
|
|
medium |
Description
Review Claude's PR feedback on PR #15, implement only the technically valid fixes on the current branch, and document which comments are non-actionable or already acceptable.
Acceptance Criteria
- #1 Validated Claude's concrete PR review items against current branch state and repo conventions
- #2 Implemented the accepted fixes with regression coverage or verification where applicable
- #3 Documented which review items are non-blocking or intentionally left unchanged
Implementation Plan
- Validate each Claude review item against current branch files and repo workflow.
- Patch release quality-gate to match CI ordering and add explicit typecheck.
- Remove duplicate .gitmodules stanza and normalize the TASK-101 reference path through Backlog MCP.
- Run relevant verification for workflow/config metadata changes and record which review items remain non-actionable.
Implementation Notes
User asked to address Claude PR comments on PR #15 and assess whether any action items remain. Treat review suggestions skeptically; only fix validated defects.
Validated Claude's five review items. Fixed release workflow ordering/typecheck, removed the duplicate .gitmodules entry, and normalized TASK-101 references to repo-relative paths via Backlog MCP.
Left the vendor/subminer-yomitan branch-pin suggestion unchanged. The committed submodule SHA already controls reproducibility; adding a branch would only affect update ergonomics and was not required to address a concrete defect.
Final Summary
Validated Claude's PR #15 review summary against the current branch and applied the actionable fixes. In .github/workflows/release.yml, the release quality-gate job now restores the dependency cache before installation, no longer installs twice, and runs bun run typecheck before the fast test suite to match CI expectations. In .gitmodules, removed the duplicate vendor/yomitan-jlpt-vocab stanza with the conflicting duplicate path. Through Backlog MCP, updated TASK-101 references from an absolute local path to repo-relative paths so the task metadata is portable across contributors.
Verification: git diff --check, git config -f .gitmodules --get-regexp '^submodule\..*\.path$', bun run typecheck, and bun run test:fast all passed. bun run format:check still fails on many pre-existing unrelated files already present on the branch, including multiple backlog task files and existing source/docs files; this review patch did not attempt a repo-wide formatting sweep.