SubMiner/backlog/tasks/task-1.2 - Phase-2-Merge-DI-adapter-runtime-services-into-target-services.md

id, title, status, assignee, created_date, updated_date, labels, dependencies, references, parent_task_id, ordinal

id	title	status	assignee	created_date	updated_date	labels	dependencies	references	parent_task_id	ordinal
TASK-1.2	Phase 2: Merge DI adapter runtime services into target services	Done	codex	2026-02-10 18:46	2026-02-18 04:11		TASK-1.1	plan.md src/core/services/cli-command-service.ts src/core/services/ipc-service.ts src/core/services/tokenizer-service.ts src/core/services/app-lifecycle-deps-runtime-service.ts	TASK-1	10000

Description

Absorb dependency adapter runtime services into core service modules and remove adapter files/tests while preserving runtime behavior.

Acceptance Criteria

• #1 CLI, IPC, tokenizer, and app lifecycle adapter logic is merged into their target service modules.
• #2 Adapter service and adapter test files listed in Phase 2 are removed.
• #3 Callers pass dependency shapes expected by updated services without redundant mapping layers.
• #4 pnpm run build && pnpm run test:core passes after Phase 2 completion.

Implementation Plan

1. Audit cli-command-deps-runtime-service.ts, ipc-deps-runtime-service.ts, tokenizer-deps-runtime-service.ts, and app-lifecycle-deps-runtime-service.ts usage sites in main.ts and corresponding services.
2. For each adapter, move null-guarding and shape-normalization logic into its target service (cli-command-service.ts, ipc-service.ts, tokenizer-service.ts, app-lifecycle-service.ts) and simplify caller dependency objects.
3. Remove adapter service files/tests and update src/core/services/index.ts exports/import sites.
4. Run pnpm run build && pnpm run test:core and fix any typing/regression issues from the interface consolidation.
5. Update task notes with dependency-shape decisions to preserve handoff clarity.

Implementation Notes

Merged adapter-constructor logic into target services: createCliCommandDepsRuntimeService moved into cli-command-service.ts, createIpcDepsRuntimeService moved into ipc-service.ts, createTokenizerDepsRuntimeService moved into tokenizer-service.ts, and createAppLifecycleDepsRuntimeService moved into app-lifecycle-service.ts.

Deleted adapter service files and tests for cli-command deps, ipc deps, tokenizer deps, and app lifecycle deps.

Updated src/core/services/index.ts exports and package.json test:core entries to remove deleted adapter test modules.

Verification: pnpm run build && pnpm run test:core passes after consolidation.