mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-05-13 20:12:54 -07:00
430373f010
* feat(tokenizer): use Yomitan word classes for subtitle POS filtering - Carry matched headword wordClasses from termsFind into YomitanScanToken - Map recognized Yomitan wordClasses to SubMiner coarse POS before annotation - MeCab enrichment now fills only missing POS fields, preserving existing coarse pos1 - Exclude standalone grammar particles, して helper fragments, and single-kana surfaces from annotations - Respect source-text punctuation gaps when counting N+1 sentence words - Preserve known-word highlight on excluded kanji-containing tokens - Add backlog tasks 304 (N+1 boundary bug) and 305 (wordClasses POS, done) * fix(tokenizer): preserve annotation and enrichment behavior * fix: restore jlpt subtitle underlines * fix: exclude kana-only n+1 targets * fix: refresh overlay on Hyprland fullscreen * fix: address fullscreen and n-plus-one review notes * fix: address CodeRabbit review comments * fix: accept modified digits for multi-line sentence mining * Cancel pending Linux MPV fullscreen overlay refresh bursts - return a cancel handle from the Linux refresh burst scheduler - clear pending refresh bursts when overlays hide or windows close - tighten the burst test polling to wait for the async refresh * fix: suppress N+1 for kana-only candidates and fix minSentenceWords coun - Treat kana-only tokens with surrounding subtitle punctuation (…, ―, etc.) as kana-only so they are not promoted to N+1 targets - Exclude unknown tokens filtered from N+1 targeting from the minSentenceWords count so filtered kana-only unknowns cannot satisfy sentence length threshold - Add regression tests for kana-only candidate suppression and filtered-unknown padding cases * Suppress subtitle annotations for grammar fragments - Hide annotation metadata for auxiliary inflection and ja-nai endings - Preserve lexical `くれる` forms and add regression coverage * Fix kana-only N+1 tokenizer regression test - Use a pure-kana fixture for the subtitle token N+1 case - Update task notes for the latest CodeRabbit follow-up * Fix managed playback exit and tokenizer grammar splits - Ignore background stats daemons during regular app startup - Split standalone grammar endings before applying annotations - Clear helper-span annotations for auxiliary-only tokens * fix: refresh current subtitle after known-word mining * fix: suppress sigh interjection annotations * fix: preserve jlpt underline color after lookup * Replace grammar-ending permutations with shared matcher; preserve word a - Extract `grammar-ending.ts` with `isStandaloneGrammarEndingText` / `isSubtitleGrammarEndingText` pattern matchers - Replace `STANDALONE_GRAMMAR_ENDINGS` set in parser-selection-stage with shared matcher - Replace generated phrase sets in subtitle-annotation-filter with shared matcher - Remove stale duplicate subtitle-exclusion constants and helpers from annotation-stage - Manual clipboard card updates now write only to the sentence audio field, leaving word/expression audio untouched * fix: CI changelog, annotation options threading, and Jellyfin quit - Add `type: fixed` / `area:` frontmatter to `changes/319` to pass `changelog:lint` - Thread `TokenizerAnnotationOptions` through `stripSubtitleAnnotationMetadata` so `sourceText` is honored - Include `jellyfinPlay` in `shouldQuitOnDisconnectWhenOverlayRuntimeInitialized` predicate - Make mouse test `elementFromPoint` stubs coordinate-sensitive - Make Lua test `.tmp` mkdir portable on Windows * Preserve overlay across macOS flaps and mpv playlist changes - keep visible overlays alive during transient macOS tracker loss - reuse the running mpv overlay path on playlist navigation - update regression coverage and changelog fragments * fix: restore stats daemon deferral * fix: keep subtitle prefetch alive after cache hits * Fix JLPT underline color drift and AniList skipped-threshold sync - Replace JLPT `text-decoration` underlines with `border-bottom` so Chromium selection/hover cannot repaint them to another annotation's color - Lock JLPT underline color for combined annotation selectors (known, n+1, frequency) and character hover/selection states - Trigger AniList post-watch check on every mpv time-position update to catch skipped completion thresholds - Fall back to filename-parser season/episode when guessit omits them * fix: address coderabbit feedback * fix: sync AniList after seeked completion * fix: preserve ordinal frequency annotations * fix: preserve known highlighting for filtered tokens * fix: address PR #57 CodeRabbit feedback - Acquire AniList post-watch in-flight lock before async gating to prevent duplicate writes - Isolate manual watched mark result from AniList post-watch callback failures - Report known-word cache clears as mutations during immediate append when state existed - Add regression tests for each fix * fix: stop AniList setup reopening on Linux when keyring token exists - Gate setup success on token persistence: `saveToken` now returns `boolean`; on failure, keeps the setup window open instead of reporting success - Config reload passes `allowSetupPrompt: false` so playback reloads don't re-open the setup window - Add regression test for persistence-failure path * fix: suppress known highlights for subtitle particles * fix: retry transient AniList safeStorage failures * fix: hide overlay focus ring * fix: align Hyprland fullscreen overlays * fix: restore subtitle playback keybindings * fix: align Hyprland overlay windows to mpv and stop pinning them - Force-apply exact Hyprland move/resize/setprop dispatches when bounds are provided - Stop pinning overlay windows; toggle pin off when Hyprland reports pinned=true - Compensate stats overlay outer placement for Electron/Wayland content insets - Make stats overlay window and page opaque so mpv cannot show through transparent insets - Constrain stats app to h-screen with internal scroll so content covers mpv from y=0 - Lock overlay/stats window titles against page-title-updated events - Add regression coverage for placement dispatches, inset compensation, and CSS overlay mode * fix: retain frequency rank for honorific prefix-noun tokens - Add `shouldAllowHonorificPrefixNounFrequency` to exempt お/ご/御 + noun merged tokens from frequency exclusion - Add regression test for `ご機嫌` asserting rank 5484 is preserved after MeCab enrichment and annotation - Close TASK-341 * fix: map openCharacterDictionary session action to --open-character-dict - Add missing Lua CLI dispatch entry for openCharacterDictionary - Add regression test for Alt+Meta+A binding and CLI flag forwarding * fix: keep macOS overlay interactive while mpv remains active - Overlay no longer hides or becomes click-through during tracker refreshes when mpv is the focused window - Preserve already-visible overlay when tracker is temporarily not ready but mpv target signal is active - Add regression tests for active-mpv tracker refresh and transient tracker-not-ready paths * fix: address coderabbit subtitle follow-ups * fix: resolve media detail from sessions when lifetime summary is absent - Change `getMediaDetail` JOIN to LEFT JOIN on `imm_lifetime_media` and fall back to aggregated session metrics when no lifetime row exists - Add filter `AND (lm.video_id IS NOT NULL OR s.session_id IS NOT NULL)` to keep results valid - Add regression test covering the session-visible / media-detail-missing mismatch * fix: address PR-57 CodeRabbit findings and CI failures - use filtered word counts in media detail session token aggregation - cancel fullscreen refresh burst on exit via updateLinuxMpvFullscreenOverlayRefreshBurst - guard Hyprland JSON.parse in try/catch; exclude windowtitle from geometry events - narrow focus suppression from :focus to :focus-visible - apply JLPT lock selectors to word-name-match tokens (N1–N5) * fix: macOS overlay z-order and Yomitan compound token known highlighting - Release always-on-top when tracked mpv loses foreground on macOS - Skip visible overlay blur restacking on macOS to avoid covering unrelated windows - Prefer Yomitan internal parse tokens over fragmented scanner output for known-word decisions - Add regression tests for both behaviors * fix: macOS visible-overlay blur no longer invokes Windows-only blur call - Split win32/darwin branches in handleOverlayWindowBlurred so darwin visible blur returns early without calling onWindowsVisibleOverlayBlur - Add regression test asserting Windows callback stays inactive on macOS visible overlay blur - Close TASK-347
284 lines
10 KiB
TypeScript
284 lines
10 KiB
TypeScript
import assert from 'node:assert/strict';
|
|
import test from 'node:test';
|
|
import {
|
|
createHandleMpvMediaPathChangeHandler,
|
|
createHandleMpvMediaTitleChangeHandler,
|
|
createHandleMpvPauseChangeHandler,
|
|
createHandleMpvSecondarySubtitleChangeHandler,
|
|
createHandleMpvSecondarySubtitleVisibilityHandler,
|
|
createHandleMpvSubtitleAssChangeHandler,
|
|
createHandleMpvSubtitleChangeHandler,
|
|
createHandleMpvSubtitleMetricsChangeHandler,
|
|
createHandleMpvTimePosChangeHandler,
|
|
} from './mpv-main-event-actions';
|
|
|
|
test('subtitle change handler updates state, broadcasts, and forwards', () => {
|
|
const calls: string[] = [];
|
|
const handler = createHandleMpvSubtitleChangeHandler({
|
|
setCurrentSubText: (text) => calls.push(`set:${text}`),
|
|
getImmediateSubtitlePayload: () => null,
|
|
broadcastSubtitle: (payload) => calls.push(`broadcast:${payload.text}`),
|
|
onSubtitleChange: (text) => calls.push(`process:${text}`),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
});
|
|
|
|
handler({ text: 'line' });
|
|
assert.deepEqual(calls, ['set:line', 'broadcast:line', 'process:line', 'presence']);
|
|
});
|
|
|
|
test('subtitle change handler broadcasts cached annotated payload immediately when available', () => {
|
|
const payloads: Array<{ text: string; tokens: unknown[] | null }> = [];
|
|
const calls: string[] = [];
|
|
const handler = createHandleMpvSubtitleChangeHandler({
|
|
setCurrentSubText: (text) => calls.push(`set:${text}`),
|
|
getImmediateSubtitlePayload: (text) => {
|
|
calls.push(`lookup:${text}`);
|
|
return { text, tokens: [] };
|
|
},
|
|
broadcastSubtitle: (payload) => {
|
|
payloads.push(payload);
|
|
calls.push(`broadcast:${payload.tokens === null ? 'plain' : 'annotated'}`);
|
|
},
|
|
onSubtitleChange: (text) => calls.push(`process:${text}`),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
});
|
|
|
|
handler({ text: 'line' });
|
|
|
|
assert.deepEqual(payloads, [{ text: 'line', tokens: [] }]);
|
|
assert.deepEqual(calls, [
|
|
'set:line',
|
|
'lookup:line',
|
|
'process:line',
|
|
'broadcast:annotated',
|
|
'presence',
|
|
]);
|
|
});
|
|
|
|
test('subtitle change handler emits cached annotation after forwarding the subtitle change', () => {
|
|
const calls: string[] = [];
|
|
const handler = createHandleMpvSubtitleChangeHandler({
|
|
setCurrentSubText: (text) => calls.push(`set:${text}`),
|
|
getImmediateSubtitlePayload: (text) => {
|
|
calls.push(`lookup:${text}`);
|
|
return { text, tokens: [] };
|
|
},
|
|
emitImmediateSubtitle: (payload) => {
|
|
calls.push(`emit:${payload.tokens === null ? 'plain' : 'annotated'}`);
|
|
},
|
|
broadcastSubtitle: (payload) => {
|
|
calls.push(`broadcast:${payload.tokens === null ? 'plain' : 'annotated'}`);
|
|
},
|
|
onSubtitleChange: (text) => calls.push(`process:${text}`),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
});
|
|
|
|
handler({ text: 'line' });
|
|
|
|
assert.deepEqual(calls, [
|
|
'set:line',
|
|
'lookup:line',
|
|
'process:line',
|
|
'emit:annotated',
|
|
'presence',
|
|
]);
|
|
});
|
|
|
|
test('subtitle ass change handler updates state and broadcasts', () => {
|
|
const calls: string[] = [];
|
|
const handler = createHandleMpvSubtitleAssChangeHandler({
|
|
setCurrentSubAssText: (text) => calls.push(`set:${text}`),
|
|
broadcastSubtitleAss: (text) => calls.push(`broadcast:${text}`),
|
|
});
|
|
|
|
handler({ text: '{\\an8}line' });
|
|
assert.deepEqual(calls, ['set:{\\an8}line', 'broadcast:{\\an8}line']);
|
|
});
|
|
|
|
test('secondary subtitle change handler broadcasts text', () => {
|
|
const seen: string[] = [];
|
|
const handler = createHandleMpvSecondarySubtitleChangeHandler({
|
|
broadcastSecondarySubtitle: (text) => seen.push(text),
|
|
});
|
|
|
|
handler({ text: 'secondary' });
|
|
assert.deepEqual(seen, ['secondary']);
|
|
});
|
|
|
|
test('media path change handler reports stop for empty path and probes media key', () => {
|
|
const calls: string[] = [];
|
|
const handler = createHandleMpvMediaPathChangeHandler({
|
|
updateCurrentMediaPath: (path) => calls.push(`path:${path}`),
|
|
reportJellyfinRemoteStopped: () => calls.push('stopped'),
|
|
restoreMpvSubVisibility: () => calls.push('restore-mpv-sub'),
|
|
resetSubtitleSidebarEmbeddedLayout: () => calls.push('reset-sidebar-layout'),
|
|
getCurrentAnilistMediaKey: () => 'show:1',
|
|
resetAnilistMediaTracking: (mediaKey) => calls.push(`reset:${String(mediaKey)}`),
|
|
maybeProbeAnilistDuration: (mediaKey) => calls.push(`probe:${mediaKey}`),
|
|
ensureAnilistMediaGuess: (mediaKey) => calls.push(`guess:${mediaKey}`),
|
|
syncImmersionMediaState: () => calls.push('sync'),
|
|
flushPlaybackPositionOnMediaPathClear: () => calls.push('flush-playback'),
|
|
scheduleCharacterDictionarySync: () => calls.push('dict-sync'),
|
|
signalAutoplayReadyIfWarm: (path) => calls.push(`autoplay:${path}`),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
});
|
|
|
|
handler({ path: '' });
|
|
assert.deepEqual(calls, [
|
|
'flush-playback',
|
|
'path:',
|
|
'reset-sidebar-layout',
|
|
'stopped',
|
|
'restore-mpv-sub',
|
|
'reset:show:1',
|
|
'probe:show:1',
|
|
'guess:show:1',
|
|
'sync',
|
|
'presence',
|
|
]);
|
|
});
|
|
|
|
test('media path change handler signals autoplay-ready fast path for warm non-empty media', () => {
|
|
const calls: string[] = [];
|
|
const handler = createHandleMpvMediaPathChangeHandler({
|
|
updateCurrentMediaPath: (path) => calls.push(`path:${path}`),
|
|
reportJellyfinRemoteStopped: () => calls.push('stopped'),
|
|
restoreMpvSubVisibility: () => calls.push('restore-mpv-sub'),
|
|
resetSubtitleSidebarEmbeddedLayout: () => calls.push('reset-sidebar-layout'),
|
|
getCurrentAnilistMediaKey: () => null,
|
|
resetAnilistMediaTracking: (mediaKey) => calls.push(`reset:${String(mediaKey)}`),
|
|
maybeProbeAnilistDuration: (mediaKey) => calls.push(`probe:${mediaKey}`),
|
|
ensureAnilistMediaGuess: (mediaKey) => calls.push(`guess:${mediaKey}`),
|
|
syncImmersionMediaState: () => calls.push('sync'),
|
|
flushPlaybackPositionOnMediaPathClear: () => calls.push('flush-playback'),
|
|
scheduleCharacterDictionarySync: () => calls.push('dict-sync'),
|
|
signalAutoplayReadyIfWarm: (path) => calls.push(`autoplay:${path}`),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
});
|
|
|
|
handler({ path: '/tmp/video.mkv' });
|
|
|
|
assert.deepEqual(calls, [
|
|
'path:/tmp/video.mkv',
|
|
'reset-sidebar-layout',
|
|
'reset:null',
|
|
'sync',
|
|
'dict-sync',
|
|
'autoplay:/tmp/video.mkv',
|
|
'presence',
|
|
]);
|
|
});
|
|
|
|
test('media title change handler clears guess state without re-scheduling character dictionary sync', () => {
|
|
const calls: string[] = [];
|
|
const deps: Parameters<typeof createHandleMpvMediaTitleChangeHandler>[0] & {
|
|
scheduleCharacterDictionarySync: () => void;
|
|
} = {
|
|
updateCurrentMediaTitle: (title) => calls.push(`title:${title}`),
|
|
resetAnilistMediaGuessState: () => calls.push('reset-guess'),
|
|
notifyImmersionTitleUpdate: (title) => calls.push(`notify:${title}`),
|
|
syncImmersionMediaState: () => calls.push('sync'),
|
|
scheduleCharacterDictionarySync: () => calls.push('dict-sync'),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
};
|
|
const handler = createHandleMpvMediaTitleChangeHandler(deps);
|
|
|
|
handler({ title: 'Episode 1' });
|
|
assert.deepEqual(calls, [
|
|
'title:Episode 1',
|
|
'reset-guess',
|
|
'notify:Episode 1',
|
|
'sync',
|
|
'presence',
|
|
]);
|
|
});
|
|
|
|
test('time-pos and pause handlers report progress with correct urgency', () => {
|
|
const calls: string[] = [];
|
|
const timeHandler = createHandleMpvTimePosChangeHandler({
|
|
recordPlaybackPosition: (time) => calls.push(`time:${time}`),
|
|
reportJellyfinRemoteProgress: (force) => calls.push(`progress:${force ? 'force' : 'normal'}`),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
maybeRunAnilistPostWatchUpdate: async () => {
|
|
calls.push('post-watch');
|
|
},
|
|
logError: () => calls.push('post-watch-error'),
|
|
});
|
|
const pauseHandler = createHandleMpvPauseChangeHandler({
|
|
recordPauseState: (paused) => calls.push(`pause:${paused ? 'yes' : 'no'}`),
|
|
reportJellyfinRemoteProgress: (force) => calls.push(`progress:${force ? 'force' : 'normal'}`),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
});
|
|
|
|
timeHandler({ time: 12.5 });
|
|
pauseHandler({ paused: true });
|
|
assert.deepEqual(calls, [
|
|
'time:12.5',
|
|
'progress:normal',
|
|
'presence',
|
|
'post-watch',
|
|
'pause:yes',
|
|
'progress:force',
|
|
'presence',
|
|
]);
|
|
});
|
|
|
|
test('time-pos handler logs post-watch update rejection without blocking later handlers', async () => {
|
|
const calls: string[] = [];
|
|
const timeHandler = createHandleMpvTimePosChangeHandler({
|
|
recordPlaybackPosition: (time) => calls.push(`time:${time}`),
|
|
reportJellyfinRemoteProgress: (force) => calls.push(`progress:${force ? 'force' : 'normal'}`),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
maybeRunAnilistPostWatchUpdate: async () => {
|
|
calls.push('post-watch');
|
|
throw new Error('boom');
|
|
},
|
|
logError: (message, error) => calls.push(`error:${message}:${(error as Error).message}`),
|
|
});
|
|
const pauseHandler = createHandleMpvPauseChangeHandler({
|
|
recordPauseState: (paused) => calls.push(`pause:${paused ? 'yes' : 'no'}`),
|
|
reportJellyfinRemoteProgress: (force) => calls.push(`progress:${force ? 'force' : 'normal'}`),
|
|
refreshDiscordPresence: () => calls.push('presence'),
|
|
});
|
|
|
|
timeHandler({ time: 12.5 });
|
|
pauseHandler({ paused: true });
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
|
|
assert.deepEqual(calls, [
|
|
'time:12.5',
|
|
'progress:normal',
|
|
'presence',
|
|
'post-watch',
|
|
'pause:yes',
|
|
'progress:force',
|
|
'presence',
|
|
'error:AniList post-watch update failed unexpectedly:boom',
|
|
]);
|
|
});
|
|
|
|
test('subtitle metrics change handler forwards patch payload', () => {
|
|
let received: Record<string, unknown> | null = null;
|
|
const handler = createHandleMpvSubtitleMetricsChangeHandler({
|
|
updateSubtitleRenderMetrics: (patch) => {
|
|
received = patch;
|
|
},
|
|
});
|
|
|
|
const patch = { fontSize: 48 };
|
|
handler({ patch });
|
|
assert.deepEqual(received, patch);
|
|
});
|
|
|
|
test('secondary subtitle visibility handler stores visibility flag', () => {
|
|
const seen: boolean[] = [];
|
|
const handler = createHandleMpvSecondarySubtitleVisibilityHandler({
|
|
setPreviousSecondarySubVisibility: (visible) => seen.push(visible),
|
|
});
|
|
|
|
handler({ visible: true });
|
|
handler({ visible: false });
|
|
assert.deepEqual(seen, [true, false]);
|
|
});
|