sudacode/SubMiner

Fork 0

mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-08-04 19:21:33 -07:00

Files

T

History

sudacode 2003efa235

fix(subtitles): release prefetch pause across all priming paths

The repeated-subtitle pause leak was only fixed for ordinary subtitle
changes. Startup autoplay priming and visible-overlay priming pause the same
way and also ignored whether any tokenization was scheduled, so a cache miss
on text the controller already holds (mining a card while the line is on
screen) left prefetching idle for the rest of the cue.

Pause and release are now one operation via pausePrefetchUntilEmit, and both
controller entry points report whether an emit is expected. A repeat arriving
while a run is already in flight keeps the pause, since that run still emits.

Also invalidate the character dictionary lookups centrally from the sync
completion handler instead of at three manager call sites. Ordinary selection
sync never invalidated them, so a stale non-null name candidate list could
skip a newly added name for up to five seconds; a missing list falls back to
the exhaustive scan, but a stale one does not. Ordering matters: the
invalidation runs before the subtitle refreshes so they re-tokenize against
the new dictionary content.

Docs: subtitle-overlay-priming no longer claims every subtitle change calls
onSeek().

2026-08-04 01:56:44 -07:00

2026-03-15-renderer-performance-design.md

Replace subtitle delay actions with native mpv keybindings (#120 )

2026-06-12 00:03:06 -07:00

domains.md

refactor: split anki-connect and stats-server resolvers into modules (#169 )

2026-07-17 23:05:59 -07:00

layering.md

docs: audit and refresh user-facing and internal docs

2026-05-23 21:21:16 -07:00

README.md

refactor(main): eliminate local pass-through wrappers in main.ts (#168 )

2026-07-15 03:22:03 -07:00

stats-trends-data-flow.md

refactor(stats): drop dead IPC handlers, unify stats types over HTTP (#164 )

2026-07-13 12:09:56 -07:00

subtitle-overlay-priming.md

fix(subtitles): release prefetch pause across all priming paths

2026-08-04 01:56:44 -07:00

README.md

Architecture Map

Status: active Last verified: 2026-05-23 Owner: Kyle Yasuda Read when: runtime ownership, composition boundaries, or layering questions

SubMiner runs as three cooperating runtimes:

Electron desktop app in src/
Launcher CLI in launcher/
mpv Lua plugin in plugin/subminer/

The desktop app keeps src/main.ts as composition root and pushes behavior into small runtime/domain modules.

Current Shape

src/main/ owns composition, runtime setup, IPC wiring, and app lifecycle adapters.
src/main/boot/ owns boot-phase assembly seams so src/main.ts can stay focused on lifecycle coordination and startup-path selection.
src/core/services/ owns focused runtime services plus pure or side-effect-bounded logic.
src/renderer/ owns overlay rendering and input behavior.
src/config/ owns config definitions, defaults, loading, and resolution.
src/types/ owns shared cross-runtime contracts via domain entrypoints; src/types.ts stays a compatibility barrel.
src/main/runtime/composers/ owns larger domain compositions.
src/main.ts call sites invoke configured runtime handlers and runtime-object methods directly; do not add local pass-through wrappers around them.

Architecture Intent

Small units, explicit boundaries
Composition over monoliths
Pure helpers where possible
Stable user behavior while internals evolve

README.md

Architecture Map

Read Next

Current Shape

Architecture Intent