mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-07-07 13:08:54 -07:00
b1bdeabca8
* fix(jellyfin): show overlay, inject plugin, and fix stats title on playb - Show visible overlay automatically during Jellyfin playback so subtitleStyle applies - Inject bundled mpv plugin on auto-launch so keybindings work without overlay focus - Group Jellyfin playback stats under item metadata (jellyfin://host/item/id) instead of stream URLs so episodes merge with matching local titles - Mark ffsubsync unavailable in subsync modal for remote media paths - Drain queued second-instance commands even when onReady throws * fix(overlay): stabilize macOS focus handoff and sidebar Yomitan pause - Keep overlay visible during macOS foreground probe after overlay blur - Hold sidebar hover-pause while a Yomitan lookup popup remains open * fix(jellyfin): fix discovery loop, device identity, tray state, and Disc - Derive device identity from OS hostname; remove legacy configurable client/device fields - Prevent discovery playback from reloading active item, misreporting pause state, and duplicate overlay restores - Restart stale tray discovery sessions without re-login when server drops SubMiner cast target - Sync tray discovery checkbox state on Linux after CLI/startup/remote-session changes - Stop Discord presence falling back to stream URLs; prime title before tokenized stream loads - Fix picker library discovery when log level is above info - Fix config.example.jsonc trailing commas and array formatting * docs(release): trim and consolidate prerelease notes for 0.15.0 - Remove breaking changes section and several redundant bullet points - Consolidate per-platform updater notes into a single entry - Normalize em-dash separators to hyphens in section headers * fix(config): remove trailing commas from config.example.jsonc - Strip trailing commas throughout both config.example.jsonc copies - Reformat inline arrays to multi-line for JSON strictness - Update Jellyfin subtitle preload and playback launch tests and impl * fix(tokenizer): preserve known-word highlight when POS filters suppress - Known-word cache matches now set isKnown=true even for tokens excluded by POS filters - POS exclusion gate suppresses N+1, frequency, and JLPT only; known status is computed before the gate - Jellyfin subtitle preload continues after cleanup failures instead of aborting - Update config docs and option description to document the known-word bypass behavior * fix(jellyfin): send explicit hide/show overlay instead of toggle - Track overlay visibility in plugin state; y-t uses explicit hide/show commands when state is known - Prevent paused Jellyfin playback from resuming on overlay hide - Fix subtitle cache cleanup to only remove dirs after successful cleanup * fix(jellyfin): fix remote progress sync, seek reporting, and startup sto - arm active playback before loadfile with loadedMediaPath: null to suppress premature stop events - force immediate progress report on seek-like position jumps at the mpv time-pos level - send positionTicks and failed=false in reportStopped payload - remove EventName from HTTP timeline payloads (websocket-only field) - add startup grace window to drop stop events before media finishes loading * fix(jellyfin): fix overlay toggle sync, redirect reload, and AppImage bi - Sync visible-overlay state back to plugin via script messages to avoid toggle/hide drift - Collapse duplicate toggle events within 250ms to prevent hide-then-show on single keypress - Preserve manual hide across Jellyfin path-changing redirects even when media-title drops - Rearm managed subtitle defaults on path-changing redirects - Route toggleVisibleOverlay session binding through plugin toggle instead of app-side IPC - Show Linux/Hyprland overlay passively (showInactive) to avoid stealing mpv keyboard focus - Fix AppImage binary resolution to prefer $APPIMAGE env over mounted inner binary - Add stats window layer management so delete/update dialogs appear above stats window - Fix Jellyfin remote progress sync during Linux websocket reconnect windows * Fix CodeRabbit review feedback * fix(jellyfin): subtitle timing, resume progress, and overlay sync - Add per-stream subtitle delay persistence and auto timeline-offset correction - Strip server-selected subtitle stream from mpv load URL; suppress plugin subtitle rearm and auto-start during app-managed preload - Fix resume position lost when mpv resets on stop; use last known position for final progress/stopped reports - Keep Play vs Resume distinct to avoid early seek race on normal play - Fix discovery resume when remote play sends StartPositionTicks=0 despite saved progress - Deduplicate show/hide overlay commands using recorded visibility state - Rewrite docs-site Jellyfin page around cast-to-device UX * test: update lifecycle cleanup assertion * fix: clear aborted playback state, fix overlay passthrough, and guard du - Reset app_managed_playback_pending on lifecycle cleanup to prevent state leak into next item - Record visible overlay action only after command succeeds, not before - Non-native passive overlay now always click-through on re-show (fix isNonNativePassiveOverlay ordering) - Defer activeParsedSubtitleMediaPath assignment until after prefetch completes - Move autoplay gate release into the hide branch of toggleVisibleOverlay - Clear active Jellyfin playback when stopping media that never loaded - Reset managed subtitle delay and delay key when no external tracks are available - Await async removeDir in subtitle cache cleanup - Guard duplicate delete clicks in MediaDetailView and SessionsTab with refs - Escape key in DeleteConfirmDialog now calls stopPropagation and stopImmediatePropagation
230 lines
6.7 KiB
TypeScript
230 lines
6.7 KiB
TypeScript
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
import { createDestroyTrayHandler, createEnsureTrayHandler } from './tray-lifecycle';
|
|
|
|
test('ensure tray updates menu when tray already exists', () => {
|
|
const calls: string[] = [];
|
|
const tray = {
|
|
setContextMenu: () => calls.push('set-menu'),
|
|
setToolTip: () => calls.push('set-tooltip'),
|
|
on: () => calls.push('bind-click'),
|
|
destroy: () => calls.push('destroy'),
|
|
};
|
|
|
|
const ensureTray = createEnsureTrayHandler({
|
|
getTray: () => tray,
|
|
setTray: () => calls.push('set-tray'),
|
|
buildTrayMenu: () => ({}),
|
|
resolveTrayIconPath: () => null,
|
|
createImageFromPath: () =>
|
|
({
|
|
isEmpty: () => false,
|
|
resize: () => {
|
|
throw new Error('should not resize');
|
|
},
|
|
setTemplateImage: () => {},
|
|
}) as never,
|
|
createEmptyImage: () =>
|
|
({
|
|
isEmpty: () => true,
|
|
resize: () => {
|
|
throw new Error('should not resize');
|
|
},
|
|
setTemplateImage: () => {},
|
|
}) as never,
|
|
createTray: () => tray as never,
|
|
trayTooltip: 'SubMiner',
|
|
platform: 'darwin',
|
|
logWarn: () => calls.push('warn'),
|
|
ensureOverlayVisibleFromTrayClick: () => calls.push('show-overlay'),
|
|
});
|
|
|
|
ensureTray();
|
|
assert.deepEqual(calls, ['set-menu']);
|
|
});
|
|
|
|
test('ensure tray refreshes existing tray menu on linux with setContextMenu', () => {
|
|
const calls: string[] = [];
|
|
let trayRef: unknown = {
|
|
setContextMenu: () => calls.push('old-set-menu'),
|
|
setToolTip: () => calls.push('old-set-tooltip'),
|
|
on: () => calls.push('old-bind-click'),
|
|
destroy: () => calls.push('old-destroy'),
|
|
};
|
|
|
|
const ensureTray = createEnsureTrayHandler({
|
|
getTray: () => trayRef as never,
|
|
setTray: (tray) => {
|
|
trayRef = tray;
|
|
calls.push(tray ? 'set-new-tray' : 'clear-tray');
|
|
},
|
|
buildTrayMenu: () => ({ id: 'menu' }),
|
|
resolveTrayIconPath: () => '/tmp/icon.png',
|
|
createImageFromPath: () =>
|
|
({
|
|
isEmpty: () => false,
|
|
resize: (options: { width: number; height: number }) => {
|
|
calls.push(`resize:${options.width}x${options.height}`);
|
|
return {
|
|
isEmpty: () => false,
|
|
resize: () => {
|
|
throw new Error('unexpected');
|
|
},
|
|
setTemplateImage: () => {},
|
|
};
|
|
},
|
|
setTemplateImage: () => {},
|
|
}) as never,
|
|
createEmptyImage: () =>
|
|
({
|
|
isEmpty: () => true,
|
|
resize: () => {
|
|
throw new Error('unexpected');
|
|
},
|
|
setTemplateImage: () => {},
|
|
}) as never,
|
|
createTray: () =>
|
|
({
|
|
setContextMenu: () => calls.push('new-set-menu'),
|
|
setToolTip: () => calls.push('new-set-tooltip'),
|
|
on: () => calls.push('new-bind-click'),
|
|
destroy: () => calls.push('new-destroy'),
|
|
}) as never,
|
|
trayTooltip: 'SubMiner',
|
|
platform: 'linux',
|
|
logWarn: () => calls.push('warn'),
|
|
ensureOverlayVisibleFromTrayClick: () => calls.push('show-overlay'),
|
|
});
|
|
|
|
ensureTray();
|
|
assert.deepEqual(calls, ['old-set-menu']);
|
|
});
|
|
|
|
test('ensure tray creates new tray and binds click handler', () => {
|
|
const calls: string[] = [];
|
|
let trayRef: unknown = null;
|
|
|
|
const ensureTray = createEnsureTrayHandler({
|
|
getTray: () => null,
|
|
setTray: (tray) => {
|
|
trayRef = tray;
|
|
calls.push('set-tray');
|
|
},
|
|
buildTrayMenu: () => ({ id: 'menu' }),
|
|
resolveTrayIconPath: () => '/tmp/icon.png',
|
|
createImageFromPath: () =>
|
|
({
|
|
isEmpty: () => false,
|
|
resize: (options: {
|
|
width: number;
|
|
height: number;
|
|
quality?: 'best' | 'better' | 'good';
|
|
}) => {
|
|
calls.push(`resize:${options.width}x${options.height}`);
|
|
return {
|
|
isEmpty: () => false,
|
|
resize: () => {
|
|
throw new Error('unexpected');
|
|
},
|
|
setTemplateImage: () => calls.push('template'),
|
|
};
|
|
},
|
|
setTemplateImage: () => calls.push('template'),
|
|
}) as never,
|
|
createEmptyImage: () =>
|
|
({
|
|
isEmpty: () => true,
|
|
resize: () => {
|
|
throw new Error('unexpected');
|
|
},
|
|
setTemplateImage: () => {},
|
|
}) as never,
|
|
createTray: () =>
|
|
({
|
|
setContextMenu: () => calls.push('set-menu'),
|
|
setToolTip: () => calls.push('set-tooltip'),
|
|
on: (_event: 'click', _handler: () => void) => {
|
|
calls.push('bind-click');
|
|
},
|
|
destroy: () => calls.push('destroy'),
|
|
}) as never,
|
|
trayTooltip: 'SubMiner',
|
|
platform: 'darwin',
|
|
logWarn: () => calls.push('warn'),
|
|
ensureOverlayVisibleFromTrayClick: () => calls.push('show-overlay'),
|
|
});
|
|
|
|
ensureTray();
|
|
assert.ok(trayRef);
|
|
assert.ok(calls.includes('set-tray'));
|
|
assert.ok(calls.includes('set-menu'));
|
|
assert.ok(calls.includes('bind-click'));
|
|
});
|
|
|
|
test('ensure tray logs Linux tray registration failures without crashing startup', () => {
|
|
const calls: string[] = [];
|
|
let trayRef: unknown = null;
|
|
|
|
const ensureTray = createEnsureTrayHandler({
|
|
getTray: () => null,
|
|
setTray: (tray) => {
|
|
trayRef = tray;
|
|
calls.push('set-tray');
|
|
},
|
|
buildTrayMenu: () => ({ id: 'menu' }),
|
|
resolveTrayIconPath: () => '/tmp/icon.png',
|
|
createImageFromPath: () =>
|
|
({
|
|
isEmpty: () => false,
|
|
resize: () => ({
|
|
isEmpty: () => false,
|
|
resize: () => {
|
|
throw new Error('unexpected');
|
|
},
|
|
setTemplateImage: () => {},
|
|
}),
|
|
setTemplateImage: () => {},
|
|
}) as never,
|
|
createEmptyImage: () =>
|
|
({
|
|
isEmpty: () => true,
|
|
resize: () => {
|
|
throw new Error('unexpected');
|
|
},
|
|
setTemplateImage: () => {},
|
|
}) as never,
|
|
createTray: () => {
|
|
throw new Error('StatusNotifier watcher unavailable');
|
|
},
|
|
trayTooltip: 'SubMiner',
|
|
platform: 'linux',
|
|
logWarn: (message) => calls.push(`warn:${message}`),
|
|
ensureOverlayVisibleFromTrayClick: () => calls.push('show-overlay'),
|
|
});
|
|
|
|
ensureTray();
|
|
|
|
assert.equal(trayRef, null);
|
|
assert.deepEqual(calls, [
|
|
'warn:Unable to create Linux tray icon. Ensure your desktop has a StatusNotifier/AppIndicator tray host. StatusNotifier watcher unavailable',
|
|
]);
|
|
});
|
|
|
|
test('destroy tray handler destroys active tray and clears ref', () => {
|
|
const calls: string[] = [];
|
|
let tray: { destroy: () => void } | null = {
|
|
destroy: () => calls.push('destroy'),
|
|
};
|
|
const destroyTray = createDestroyTrayHandler({
|
|
getTray: () => tray as never,
|
|
setTray: (next) => {
|
|
tray = next as never;
|
|
calls.push('set-null');
|
|
},
|
|
});
|
|
|
|
destroyTray();
|
|
assert.deepEqual(calls, ['destroy', 'set-null']);
|
|
assert.equal(tray, null);
|
|
});
|