mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-30 06:12:06 -07:00
1.4 KiB
1.4 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | priority | ordinal | |||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-244 | Assess and address PR #36 latest CodeRabbit review round 2 | Done | 2026-03-29 08:09 | 2026-03-29 08:10 |
|
|
high | 3610 |
Description
Inspect the newest CodeRabbit review round on PR #36, verify the actionable comment against the current branch, implement the confirmed fix, and verify the touched path.
Acceptance Criteria
- #1 The actionable review comment is implemented or explicitly deferred with rationale.
- #2 Touched path is verified with the smallest sufficient test lane.
- #3 Current PR feedback is reduced to resolved or intentionally deferred suggestions.
Final Summary
Addressed the actionable latest CodeRabbit comment on PR #36. src/core/services/immersion-tracker/maintenance.ts now skips retention deletions when a window is disabled with Infinity, so toDbMs(...) is only called for finite retention values. Added a regression test in maintenance.test.ts that verifies disabled retention windows preserve session events, telemetry, and sessions while returning zero deletions.