4.3 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | |||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-111 | Fix subtitle-cycle OSD labels for J keybindings | Done |
|
2026-03-07 23:45 | 2026-03-08 00:06 |
|
Description
When cycling subtitle tracks with the default J/Shift+J keybindings, the mpv OSD currently shows raw template text like ${sid} instead of a resolved subtitle label. Update the keybinding OSD behavior so users see the active subtitle selection clearly when cycling tracks, and ensure placeholder-based OSD messages sent through the mpv client API render correctly.
Acceptance Criteria
- #1 Pressing the primary subtitle cycle keybinding shows a resolved subtitle label on the OSD instead of a raw
${sid}placeholder. - #2 Pressing the secondary subtitle cycle keybinding shows a resolved subtitle label on the OSD instead of a raw
${secondary-sid}placeholder. - #3 Proxy OSD messages that rely on mpv property expansion render resolved values when sent through the mpv client API.
- #4 Regression tests cover the subtitle-cycle OSD behavior and the placeholder-expansion OSD path.
Implementation Plan
- Add focused failing tests for subtitle-cycle OSD labels and mpv placeholder-expansion behavior.
- Update the IPC mpv command handler to resolve primary and secondary subtitle track labels from mpv
track-listdata after cycling subtitle tracks. - Update the mpv OSD runtime path so placeholder-based
show-textmessages sent through the client API opt into property expansion. - Run focused tests, then the relevant core test lane, and record results in the task notes.
Implementation Notes
Initial triage: ipc-command.ts emits raw ${sid}/${secondary-sid} placeholder strings, and showMpvOsdRuntime sends show-text via mpv client API without enabling property expansion.
User approved implementation plan on 2026-03-07.
Implementation: proxy mpv command OSD now supports an async resolver so subtitle track cycling can show human-readable labels instead of raw ${sid} placeholders.
Implementation: showMpvOsdRuntime now prefixes placeholder-based messages with mpv client-api expand-properties, which fixes raw ${...} OSD output for subtitle delay/position messages.
Testing: bun test src/core/services/ipc-command.test.ts src/core/services/mpv-control.test.ts src/main/runtime/mpv-proxy-osd.test.ts src/main/runtime/ipc-mpv-command-main-deps.test.ts src/main/runtime/ipc-bridge-actions.test.ts src/main/runtime/ipc-bridge-actions-main-deps.test.ts src/main/runtime/composers/ipc-runtime-composer.test.ts passed.
Testing: bun x tsc --noEmit passed.
Testing: bun run test:core:src passed (423 pass, 6 skip, 0 fail).
Docs: no update required because no checked-in docs or help text describe the J/Shift+J OSD output behavior.
Final Summary
Fixed subtitle-cycle OSD handling for the default J/Shift+J keybindings. The IPC mpv command path now supports resolving proxy OSD text asynchronously, and the main-runtime resolver reads mpv track-list state so primary and secondary subtitle cycling show human-readable track labels instead of raw ${sid} / ${secondary-sid} placeholders.
Also fixed the lower-level mpv OSD transport so placeholder-based show-text messages sent through the client API opt into expand-properties. That preserves existing template-based OSD messages like subtitle delay and subtitle position without leaking the raw ${...} syntax.
Added regression coverage for the async proxy OSD path, the placeholder-expansion showMpvOsdRuntime path, and the runtime subtitle-track label resolver. Verification run: bun x tsc --noEmit; focused mpv/IPC tests; and the maintained bun run test:core:src lane (423 pass, 6 skip, 0 fail).