sudacode
09b11b689f
- Guard `getSourceState()` with `SUBMINER_YOMITAN_ALLOW_MISSING_GIT=1` escape hatch for environments without a git submodule - Fix README requirements table column alignment and remove stray horizontal rule - Update task-268 with follow-up CodeRabbit round notes and final summary
2.5 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | priority | |||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-268 | Address CodeRabbit review action items for PR #38 | Done | 2026-04-01 05:35 | 2026-04-01 06:07 |
|
|
medium |
Description
Review unresolved CodeRabbit feedback on PR #38 and implement the actionable fixes without regressing duplicate grouping or popup behavior.
Acceptance Criteria
- #1 All unresolved actionable CodeRabbit review comments on PR #38 are triaged and either fixed in code or explicitly identified as non-actionable or ambiguous.
- #2 Code changes preserve duplicate grouping and popup flow behavior covered by existing or added regression tests.
- #3 Relevant local verification for the affected areas passes.
Implementation Notes
2026-04-01: Reopened for follow-up CodeRabbit round after commit 233bde58. Remaining actionable items: guard maxMatches <= 0 in duplicate exact-match helper and strengthen the duplicate tracking test fixture to prove deduplication as well as sorting.
2026-04-01: Follow-up round addressed locally. Added guard for maxMatches <= 0 in duplicate exact-match scanning and strengthened the pre-add duplicate tracking test fixture to prove deduplication as well as sorting.
Final Summary
Addressed all unresolved actionable CodeRabbit comments on PR #38. Fixed duplicate tracking so empty duplicate lists are not persisted after sentence-card creation, sanitized Yomitan add-note noteId values to accept only positive integers, preserved paused playback for configured subtitle-seek keybindings when pause state is unknown, and short-circuited duplicate exact-match scanning for single-result lookups. Added regression tests for each case and verified with bun test on the affected suites plus bun run typecheck, bun run test:fast, bun run test:env, bun run build, and bun run test:smoke:dist.
Follow-up CodeRabbit round addressed locally: findExactDuplicateNoteIds() now returns early when maxMatches <= 0, and the sentence-card duplicate tracking regression test now uses a repeated duplicate ID to assert deduplication plus sorting. Re-verified with targeted duplicate/card tests, bun run typecheck, and bun run test:fast.