mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-08-18 00:21:41 -07:00
Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
8ebf6a45fe
|
||
|
|
fc7fde30d5
|
||
|
|
f335b26fe3
|
||
|
|
00b1b79bf4 | ||
|
|
e11a5fea0d
|
||
|
|
f73fe179d0
|
||
|
|
2938e7a32a | ||
|
|
82f6b4705a | ||
|
|
a02c33dac4 |
@@ -0,0 +1,5 @@
|
|||||||
|
type: internal
|
||||||
|
area: docs
|
||||||
|
|
||||||
|
- Excluded the `/main/` and `/v/<version>/` docs trees from search indexing with a self-referential canonical, `noindex,follow`, and a matching `X-Robots-Tag` header, so crawlers spend their budget on the current docs instead of ~30 archived copies of every page.
|
||||||
|
- Restored `<lastmod>` dates in the docs sitemap, which were silently dropped because production builds render from an untracked release snapshot.
|
||||||
@@ -0,0 +1,5 @@
|
|||||||
|
type: fixed
|
||||||
|
area: overlay
|
||||||
|
|
||||||
|
- Dedicated overlay modals are prewarmed on macOS and Windows so shortcuts open them promptly on the first press. Windows now refreshes the hidden modal renderer between sessions to keep later modals interactive. On macOS, reused modals and the in-app stats window also open above fullscreen mpv on its current Space instead of appearing on another desktop or forcing a Space change.
|
||||||
|
- Updated subtitle ASS observation to mpv's current `sub-text/ass` property, removing its deprecation warning.
|
||||||
@@ -0,0 +1,4 @@
|
|||||||
|
type: fixed
|
||||||
|
area: overlay
|
||||||
|
|
||||||
|
- Fixed the overlay getting stuck on "Overlay loading" forever when startup stalls: mpv IPC connection attempts now time out and retry, switching sockets aborts obsolete attempts, and the plugin replaces its spinner with an actionable error if overlay content is still not ready after 30 seconds.
|
||||||
@@ -0,0 +1,4 @@
|
|||||||
|
type: fixed
|
||||||
|
area: overlay
|
||||||
|
|
||||||
|
- Secondary subtitles now parse the selected ASS/SRT/VTT source with the primary subtitle deduplication pipeline, preventing layered animation text from appearing several times in the overlay, mined cards, and statistics. Live mpv text remains the fallback for unreadable tracks.
|
||||||
@@ -0,0 +1,4 @@
|
|||||||
|
type: fixed
|
||||||
|
area: overlay
|
||||||
|
|
||||||
|
- Fixed system-wide mouse lag on Windows while SubMiner is running: the overlay no longer installs Electron's global mouse hook for click-through forwarding, and the mpv window tracker no longer blocks the app on repeated PowerShell command-line lookups.
|
||||||
@@ -1,3 +1,4 @@
|
|||||||
|
import { spawnSync } from 'node:child_process';
|
||||||
import { existsSync, readFileSync, statSync } from 'node:fs';
|
import { existsSync, readFileSync, statSync } from 'node:fs';
|
||||||
import { extname, join, posix, resolve, sep } from 'node:path';
|
import { extname, join, posix, resolve, sep } from 'node:path';
|
||||||
import type { DefaultTheme, HeadConfig, TransformContext, UserConfig } from 'vitepress';
|
import type { DefaultTheme, HeadConfig, TransformContext, UserConfig } from 'vitepress';
|
||||||
@@ -26,6 +27,9 @@ function optionalEnv(value: string | undefined): string | undefined {
|
|||||||
const base = normalizeBase(optionalEnv(process.env.SUBMINER_DOCS_BASE) ?? '/');
|
const base = normalizeBase(optionalEnv(process.env.SUBMINER_DOCS_BASE) ?? '/');
|
||||||
const outDir = optionalEnv(process.env.SUBMINER_DOCS_OUT_DIR);
|
const outDir = optionalEnv(process.env.SUBMINER_DOCS_OUT_DIR);
|
||||||
const docsSourceDir = optionalEnv(process.env.SUBMINER_DOCS_SOURCE_DIR) ?? process.cwd();
|
const docsSourceDir = optionalEnv(process.env.SUBMINER_DOCS_SOURCE_DIR) ?? process.cwd();
|
||||||
|
// The tracked `docs-site/` checkout, which stays a git working tree even when
|
||||||
|
// `docsSourceDir` points at an untracked release snapshot. Used for git lookups only.
|
||||||
|
const repoDocsDir = optionalEnv(process.env.SUBMINER_DOCS_REPO_DIR) ?? process.cwd();
|
||||||
const channel = normalizeChannel(optionalEnv(process.env.SUBMINER_DOCS_CHANNEL));
|
const channel = normalizeChannel(optionalEnv(process.env.SUBMINER_DOCS_CHANNEL));
|
||||||
const docsVersion = optionalEnv(process.env.SUBMINER_DOCS_VERSION);
|
const docsVersion = optionalEnv(process.env.SUBMINER_DOCS_VERSION);
|
||||||
const latestStable = optionalEnv(process.env.SUBMINER_DOCS_LATEST_STABLE) ?? 'v0.18.0';
|
const latestStable = optionalEnv(process.env.SUBMINER_DOCS_LATEST_STABLE) ?? 'v0.18.0';
|
||||||
@@ -82,15 +86,18 @@ function pageToRoute(page: string): string | null {
|
|||||||
return route ? `/${route}` : '/';
|
return route ? `/${route}` : '/';
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Only the root channel is indexable. `main` and every /v/<version>/ archive are
|
||||||
|
// near-verbatim copies of it, so they own their URL via a self-referential canonical
|
||||||
|
// and are excluded from the index instead of being consolidated onto root. Uniform
|
||||||
|
// self-canonical plus noindex avoids mixing noindex with a cross-page canonical,
|
||||||
|
// which Google treats as a conflicting signal.
|
||||||
|
const isIndexableChannel = channel === 'stable-root';
|
||||||
|
|
||||||
function pageToCanonicalHref(page: string): string | null {
|
function pageToCanonicalHref(page: string): string | null {
|
||||||
const route = pageToRoute(page);
|
const route = pageToRoute(page);
|
||||||
if (!route) return null;
|
if (!route) return null;
|
||||||
|
|
||||||
if (channel === 'main') {
|
if (!isIndexableChannel) {
|
||||||
return `${DOCS_HOSTNAME}${canonicalRouteWithBase(route)}`;
|
|
||||||
}
|
|
||||||
|
|
||||||
if (channel === 'stable-archive' && docsVersion !== latestStable) {
|
|
||||||
return `${DOCS_HOSTNAME}${canonicalRouteWithBase(route)}`;
|
return `${DOCS_HOSTNAME}${canonicalRouteWithBase(route)}`;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -106,7 +113,9 @@ function transformPageHead({ page }: TransformContext): HeadConfig[] {
|
|||||||
const href = pageToCanonicalHref(page);
|
const href = pageToCanonicalHref(page);
|
||||||
const head: HeadConfig[] = href ? [['link', { rel: 'canonical', href }]] : [];
|
const head: HeadConfig[] = href ? [['link', { rel: 'canonical', href }]] : [];
|
||||||
|
|
||||||
if (channel === 'main') {
|
// Crawlable so links still pass through, but out of the index: ~30 archived copies
|
||||||
|
// of every page otherwise soak up the crawl budget the current docs need.
|
||||||
|
if (!isIndexableChannel) {
|
||||||
head.push(['meta', { name: 'robots', content: 'noindex,follow' }]);
|
head.push(['meta', { name: 'robots', content: 'noindex,follow' }]);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -287,6 +296,39 @@ const versionItems = [
|
|||||||
})),
|
})),
|
||||||
];
|
];
|
||||||
|
|
||||||
|
function sitemapUrlToPage(url: string): string {
|
||||||
|
const route = url.replace(/\.html$/, '').replace(/^\/+|\/+$/g, '');
|
||||||
|
return route ? `${route}.md` : 'index.md';
|
||||||
|
}
|
||||||
|
|
||||||
|
// VitePress derives <lastmod> by running `git log` inside its source dir. Production
|
||||||
|
// builds point that at an untracked snapshot of the release tag, so the lookup comes
|
||||||
|
// back empty and the sitemap ships with no dates at all. Resolve it from the tracked
|
||||||
|
// checkout at the ref being built instead.
|
||||||
|
function lastModifiedFor(url: string): string | undefined {
|
||||||
|
const ref = docsVersion && docsVersion !== 'main' ? docsVersion : 'HEAD';
|
||||||
|
const result = spawnSync('git', ['log', '-1', '--format=%cI', ref, '--', sitemapUrlToPage(url)], {
|
||||||
|
cwd: repoDocsDir,
|
||||||
|
encoding: 'utf8',
|
||||||
|
});
|
||||||
|
|
||||||
|
return (result.status === 0 && result.stdout.trim()) || undefined;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Only the root channel publishes a sitemap. Archived and `main` builds would emit
|
||||||
|
// their own copies listing the same canonical URLs, which just advertises the
|
||||||
|
// duplicate trees we are trying to keep out of the index.
|
||||||
|
const sitemap: UserConfig['sitemap'] = isIndexableChannel
|
||||||
|
? {
|
||||||
|
hostname: DOCS_HOSTNAME,
|
||||||
|
transformItems(items) {
|
||||||
|
return items
|
||||||
|
.filter((item) => item.url !== 'README' && item.url !== `${DOCS_HOSTNAME}/README`)
|
||||||
|
.map((item) => ({ ...item, lastmod: item.lastmod ?? lastModifiedFor(item.url) }));
|
||||||
|
},
|
||||||
|
}
|
||||||
|
: undefined;
|
||||||
|
|
||||||
const nav: DefaultTheme.NavItem[] = [
|
const nav: DefaultTheme.NavItem[] = [
|
||||||
{ text: 'Home', link: '/' },
|
{ text: 'Home', link: '/' },
|
||||||
{ text: 'Get Started', link: '/installation' },
|
{ text: 'Get Started', link: '/installation' },
|
||||||
@@ -419,14 +461,7 @@ const config: UserConfig = {
|
|||||||
appearance: 'dark',
|
appearance: 'dark',
|
||||||
cleanUrls: true,
|
cleanUrls: true,
|
||||||
metaChunk: true,
|
metaChunk: true,
|
||||||
sitemap: {
|
sitemap,
|
||||||
hostname: DOCS_HOSTNAME,
|
|
||||||
transformItems(items) {
|
|
||||||
return items.filter(
|
|
||||||
(item) => item.url !== 'README' && item.url !== `${DOCS_HOSTNAME}/README`,
|
|
||||||
);
|
|
||||||
},
|
|
||||||
},
|
|
||||||
transformHead: transformPageHead,
|
transformHead: transformPageHead,
|
||||||
lastUpdated: true,
|
lastUpdated: true,
|
||||||
srcExclude: ['subagents/**', 'README.md'],
|
srcExclude: ['subagents/**', 'README.md'],
|
||||||
|
|||||||
+3
-1
@@ -38,8 +38,10 @@ bun run docs:dev
|
|||||||
The public docs root is stable-only:
|
The public docs root is stable-only:
|
||||||
|
|
||||||
- `/` serves the latest stable release docs.
|
- `/` serves the latest stable release docs.
|
||||||
- `/main/` serves development docs from `main` and is marked `noindex,follow`.
|
- `/main/` serves development docs from `main`.
|
||||||
- `/v/<version>/` serves stable release archives.
|
- `/v/<version>/` serves stable release archives.
|
||||||
- Prerelease tags do not update the docs site.
|
- Prerelease tags do not update the docs site.
|
||||||
|
|
||||||
|
Only `/` is indexable. `/main/` and every `/v/<version>/` page carries a self-referential canonical plus `noindex,follow`, and the generated `_headers` file repeats that as an `X-Robots-Tag`. They stay crawlable so their links still resolve, but ~30 archived copies of every page would otherwise consume the crawl budget the current docs need. Only the root build emits `sitemap.xml`, and its `<lastmod>` dates come from `git log` against the tracked checkout at the released tag, because the build renders from an untracked snapshot that VitePress cannot date itself.
|
||||||
|
|
||||||
Keep Cloudflare Git auto-deploy disabled. The production deploy is `.github/workflows/docs-pages.yml`, which uploads `.tmp/docs-versioned-site` with `--branch main` so tag-triggered runs update Production instead of creating preview deployments.
|
Keep Cloudflare Git auto-deploy disabled. The production deploy is `.github/workflows/docs-pages.yml`, which uploads `.tmp/docs-versioned-site` with `--branch main` so tag-triggered runs update Production instead of creating preview deployments.
|
||||||
|
|||||||
+39
-11
@@ -56,34 +56,43 @@ test('main docs canonical uses /main/ and emits noindex', async () => {
|
|||||||
{ rel: 'canonical', href: 'https://docs.subminer.moe/main/' },
|
{ rel: 'canonical', href: 'https://docs.subminer.moe/main/' },
|
||||||
]);
|
]);
|
||||||
expect(head).toContainEqual(['meta', { name: 'robots', content: 'noindex,follow' }]);
|
expect(head).toContainEqual(['meta', { name: 'robots', content: 'noindex,follow' }]);
|
||||||
|
expect(mainDocsConfig.sitemap).toBeUndefined();
|
||||||
|
|
||||||
process.env.SUBMINER_DOCS_CHANNEL = previousChannel;
|
process.env.SUBMINER_DOCS_CHANNEL = previousChannel;
|
||||||
process.env.SUBMINER_DOCS_BASE = previousBase;
|
process.env.SUBMINER_DOCS_BASE = previousBase;
|
||||||
});
|
});
|
||||||
|
|
||||||
test('latest stable archive canonical points to root equivalent', async () => {
|
test.each([
|
||||||
|
['latest stable', 'v0.14.0', '/v/0.14.0/', 'https://docs.subminer.moe/v/0.14.0/usage'],
|
||||||
|
['superseded', 'v0.12.0', '/v/0.12.0/', 'https://docs.subminer.moe/v/0.12.0/usage'],
|
||||||
|
])(
|
||||||
|
'%s archive keeps a self-referential canonical and stays out of the index',
|
||||||
|
async (_label, version, base, expectedCanonical) => {
|
||||||
const previousChannel = process.env.SUBMINER_DOCS_CHANNEL;
|
const previousChannel = process.env.SUBMINER_DOCS_CHANNEL;
|
||||||
const previousBase = process.env.SUBMINER_DOCS_BASE;
|
const previousBase = process.env.SUBMINER_DOCS_BASE;
|
||||||
const previousVersion = process.env.SUBMINER_DOCS_VERSION;
|
const previousVersion = process.env.SUBMINER_DOCS_VERSION;
|
||||||
const previousLatest = process.env.SUBMINER_DOCS_LATEST_STABLE;
|
const previousLatest = process.env.SUBMINER_DOCS_LATEST_STABLE;
|
||||||
process.env.SUBMINER_DOCS_CHANNEL = 'stable-archive';
|
process.env.SUBMINER_DOCS_CHANNEL = 'stable-archive';
|
||||||
process.env.SUBMINER_DOCS_BASE = '/v/0.14.0/';
|
process.env.SUBMINER_DOCS_BASE = base;
|
||||||
process.env.SUBMINER_DOCS_VERSION = 'v0.14.0';
|
process.env.SUBMINER_DOCS_VERSION = version;
|
||||||
process.env.SUBMINER_DOCS_LATEST_STABLE = 'v0.14.0';
|
process.env.SUBMINER_DOCS_LATEST_STABLE = 'v0.14.0';
|
||||||
const { default: latestArchiveConfig } = await import('./.vitepress/config?latest-archive');
|
try {
|
||||||
|
const { default: archiveConfig } = await import(`./.vitepress/config?archive-${version}`);
|
||||||
|
|
||||||
const head = await latestArchiveConfig.transformHead?.(makeTransformContext('usage.md'));
|
const head = await archiveConfig.transformHead?.(makeTransformContext('usage.md'));
|
||||||
|
|
||||||
expect(head).toContainEqual([
|
|
||||||
'link',
|
|
||||||
{ rel: 'canonical', href: 'https://docs.subminer.moe/usage' },
|
|
||||||
]);
|
|
||||||
|
|
||||||
|
expect(head).toContainEqual(['link', { rel: 'canonical', href: expectedCanonical }]);
|
||||||
|
expect(head).toContainEqual(['meta', { name: 'robots', content: 'noindex,follow' }]);
|
||||||
|
// A sitemap here would advertise the archive tree we just excluded.
|
||||||
|
expect(archiveConfig.sitemap).toBeUndefined();
|
||||||
|
} finally {
|
||||||
process.env.SUBMINER_DOCS_CHANNEL = previousChannel;
|
process.env.SUBMINER_DOCS_CHANNEL = previousChannel;
|
||||||
process.env.SUBMINER_DOCS_BASE = previousBase;
|
process.env.SUBMINER_DOCS_BASE = previousBase;
|
||||||
process.env.SUBMINER_DOCS_VERSION = previousVersion;
|
process.env.SUBMINER_DOCS_VERSION = previousVersion;
|
||||||
process.env.SUBMINER_DOCS_LATEST_STABLE = previousLatest;
|
process.env.SUBMINER_DOCS_LATEST_STABLE = previousLatest;
|
||||||
});
|
}
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
test('stable archive theme links stay on the selected version', async () => {
|
test('stable archive theme links stay on the selected version', async () => {
|
||||||
const previousCwd = process.cwd();
|
const previousCwd = process.cwd();
|
||||||
@@ -433,3 +442,22 @@ test('docs sitemap excludes duplicate README page from indexable URLs', async ()
|
|||||||
|
|
||||||
expect(transformedItems?.map((item) => item.url)).toEqual(['', 'usage']);
|
expect(transformedItems?.map((item) => item.url)).toEqual(['', 'usage']);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('docs sitemap dates every URL from the tracked checkout', async () => {
|
||||||
|
const previousRepoDir = process.env.SUBMINER_DOCS_REPO_DIR;
|
||||||
|
// Production builds render from an untracked snapshot, so the date has to come from
|
||||||
|
// the real checkout rather than VitePress's own srcDir git lookup.
|
||||||
|
process.env.SUBMINER_DOCS_REPO_DIR = docsSiteDir;
|
||||||
|
try {
|
||||||
|
const { default: sitemapConfig } = await import('./.vitepress/config?sitemap-lastmod');
|
||||||
|
|
||||||
|
const items = await sitemapConfig.sitemap?.transformItems?.([{ url: '' }, { url: 'usage' }]);
|
||||||
|
|
||||||
|
expect(items).toHaveLength(2);
|
||||||
|
for (const item of items ?? []) {
|
||||||
|
expect(item.lastmod).toMatch(/^\d{4}-\d{2}-\d{2}T/);
|
||||||
|
}
|
||||||
|
} finally {
|
||||||
|
process.env.SUBMINER_DOCS_REPO_DIR = previousRepoDir;
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|||||||
@@ -3,7 +3,7 @@
|
|||||||
# Subtitle Overlay Priming
|
# Subtitle Overlay Priming
|
||||||
|
|
||||||
Status: active
|
Status: active
|
||||||
Last verified: 2026-08-04
|
Last verified: 2026-08-17
|
||||||
Owner: Kyle Yasuda
|
Owner: Kyle Yasuda
|
||||||
Read when: debugging subtitle state or blank Linux/X11 overlay windows when the visible overlay is shown or recreated
|
Read when: debugging subtitle state or blank Linux/X11 overlay windows when the visible overlay is shown or recreated
|
||||||
|
|
||||||
@@ -77,6 +77,25 @@ coming and prefetching would otherwise idle for the rest of the cue.
|
|||||||
- The current cue upgrades in place when its tokens and annotations are ready. This can reflow text
|
- The current cue upgrades in place when its tokens and annotations are ready. This can reflow text
|
||||||
or character images, but cue visibility does not wait for that work.
|
or character images, but cue visibility does not wait for that work.
|
||||||
|
|
||||||
|
## Secondary Subtitle Flow
|
||||||
|
|
||||||
|
- `secondary-sub-text` remains the immediate fallback, so unreadable and remote subtitle sources
|
||||||
|
still appear without waiting for file resolution.
|
||||||
|
- `secondary-subtitle-track.ts` resolves `secondary-sid` against mpv's track list. External tracks
|
||||||
|
are read directly; supported embedded text tracks are extracted through the same ffmpeg-backed
|
||||||
|
source resolver used by primary subtitle prefetching.
|
||||||
|
- The selected source is parsed with `parseSubtitleCues()`, including metadata-aware ASS duplicate
|
||||||
|
and animation collapse. Playback `time-pos` selects the active parsed cue after applying
|
||||||
|
`secondary-sub-delay`.
|
||||||
|
- The resolved text is stored in `mpvClient.currentSecondarySubText` before it is broadcast. The
|
||||||
|
overlay, mining, timing tracker, and immersion statistics therefore consume the same secondary
|
||||||
|
text when a readable source is available.
|
||||||
|
- Media and `secondary-sid` changes clear the previous parsed state before refreshing the source;
|
||||||
|
track-list changes refresh without discarding an unchanged source. Observed
|
||||||
|
`secondary-sub-delay` changes retime the active parsed cue without rereading the file. If loading,
|
||||||
|
extraction, or parsing fails, the controller returns to live mpv text and the renderer's
|
||||||
|
conservative short stack heuristic remains the final display fallback.
|
||||||
|
|
||||||
## Emitted State
|
## Emitted State
|
||||||
|
|
||||||
- `emitSubtitle(payload)` maps to `emitSubtitlePayload(payload)`. Overlay windows and annotation
|
- `emitSubtitle(payload)` maps to `emitSubtitlePayload(payload)`. Overlay windows and annotation
|
||||||
@@ -84,8 +103,8 @@ coming and prefetching would otherwise idle for the rest of the cue.
|
|||||||
- The basic subtitle websocket receives the immediate plain cue only. Because its serialized
|
- The basic subtitle websocket receives the immediate plain cue only. Because its serialized
|
||||||
payload discards annotations, the later upgrade would be an identical duplicate and is skipped
|
payload discards annotations, the later upgrade would be an identical duplicate and is skipped
|
||||||
when text and cue timing match.
|
when text and cue timing match.
|
||||||
- Secondary priming reads mpv `secondary-sub-text`, stores it in
|
- Secondary priming reads mpv `secondary-sub-text` and routes it through the secondary track
|
||||||
`mpvClient.currentSecondarySubText`, and broadcasts `secondary-subtitle:set` to overlay windows.
|
controller. A parsed active cue replaces the live text when the selected source is readable.
|
||||||
- If secondary `requestProperty` fails, the primary flow stays complete and only a debug line is
|
- If secondary `requestProperty` fails, the primary flow stays complete and only a debug line is
|
||||||
written.
|
written.
|
||||||
|
|
||||||
@@ -129,7 +148,11 @@ coming and prefetching would otherwise idle for the rest of the cue.
|
|||||||
path, empty or stale bounding shapes produced invisible or clipped subtitles even though the
|
path, empty or stale bounding shapes produced invisible or clipped subtitles even though the
|
||||||
overlay window remained mapped above mpv.
|
overlay window remained mapped above mpv.
|
||||||
- Pointer pass-through should continue to use `setIgnoreMouseEvents(true, { forward: true })` and
|
- Pointer pass-through should continue to use `setIgnoreMouseEvents(true, { forward: true })` and
|
||||||
the Linux cursor-poll fallback, not bounding-shape clipping.
|
the Linux cursor-poll fallback, not bounding-shape clipping. Note that on Windows click-through
|
||||||
|
must go through `applyOverlayClickThrough()` (`src/core/services/overlay-click-through.ts`),
|
||||||
|
which omits `forward: true` there: Electron implements forwarding with a global low-level mouse
|
||||||
|
hook that lags mouse input system-wide whenever the main thread stalls; the Windows cursor poll
|
||||||
|
handles overlay wake-up instead.
|
||||||
- Visible-overlay show/reset marks Linux pointer passthrough state dirty even when the logical
|
- Visible-overlay show/reset marks Linux pointer passthrough state dirty even when the logical
|
||||||
interaction state is already inactive. The next cursor-poll tick must still reapply
|
interaction state is already inactive. The next cursor-poll tick must still reapply
|
||||||
`setIgnoreMouseEvents(true, { forward: true })`; otherwise a newly shown Electron overlay can keep
|
`setIgnoreMouseEvents(true, { forward: true })`; otherwise a newly shown Electron overlay can keep
|
||||||
|
|||||||
+1
-1
@@ -2,7 +2,7 @@
|
|||||||
"name": "subminer",
|
"name": "subminer",
|
||||||
"productName": "SubMiner",
|
"productName": "SubMiner",
|
||||||
"desktopName": "SubMiner.desktop",
|
"desktopName": "SubMiner.desktop",
|
||||||
"version": "0.19.3",
|
"version": "0.19.4-beta.1",
|
||||||
"description": "All-in-one sentence mining overlay with AnkiConnect and dictionary integration",
|
"description": "All-in-one sentence mining overlay with AnkiConnect and dictionary integration",
|
||||||
"packageManager": "bun@1.3.5",
|
"packageManager": "bun@1.3.5",
|
||||||
"main": "dist/main-entry.js",
|
"main": "dist/main-entry.js",
|
||||||
|
|||||||
@@ -106,9 +106,12 @@ function M.create(ctx)
|
|||||||
|
|
||||||
local function get_subtitle_ass_property()
|
local function get_subtitle_ass_property()
|
||||||
local ass_text = mp.get_property("sub-text/ass")
|
local ass_text = mp.get_property("sub-text/ass")
|
||||||
|
if ass_text ~= nil then
|
||||||
if type(ass_text) == "string" and ass_text ~= "" then
|
if type(ass_text) == "string" and ass_text ~= "" then
|
||||||
return ass_text
|
return ass_text
|
||||||
end
|
end
|
||||||
|
return nil
|
||||||
|
end
|
||||||
ass_text = mp.get_property("sub-text-ass")
|
ass_text = mp.get_property("sub-text-ass")
|
||||||
if type(ass_text) == "string" and ass_text ~= "" then
|
if type(ass_text) == "string" and ass_text ~= "" then
|
||||||
return ass_text
|
return ass_text
|
||||||
|
|||||||
@@ -7,6 +7,8 @@ local OVERLAY_RESTART_PING_MAX_ATTEMPTS = 20
|
|||||||
local OVERLAY_LOADING_OSD_PREFIX = "Overlay loading "
|
local OVERLAY_LOADING_OSD_PREFIX = "Overlay loading "
|
||||||
local OVERLAY_LOADING_OSD_FRAMES = { "|", "/", "-", "\\" }
|
local OVERLAY_LOADING_OSD_FRAMES = { "|", "/", "-", "\\" }
|
||||||
local OVERLAY_LOADING_OSD_REFRESH_SECONDS = 0.18
|
local OVERLAY_LOADING_OSD_REFRESH_SECONDS = 0.18
|
||||||
|
local OVERLAY_LOADING_OSD_DEADLINE_SECONDS = 30
|
||||||
|
local OVERLAY_LOADING_OSD_TIMEOUT_MESSAGE = "Overlay did not become ready; check SubMiner logs"
|
||||||
local AUTO_PLAY_READY_LOADING_OSD = "Loading subtitle tokenization..."
|
local AUTO_PLAY_READY_LOADING_OSD = "Loading subtitle tokenization..."
|
||||||
local AUTO_PLAY_READY_READY_OSD = "Subtitle tokenization ready"
|
local AUTO_PLAY_READY_READY_OSD = "Subtitle tokenization ready"
|
||||||
local DEFAULT_AUTO_PLAY_READY_TIMEOUT_SECONDS = 30
|
local DEFAULT_AUTO_PLAY_READY_TIMEOUT_SECONDS = 30
|
||||||
@@ -265,10 +267,19 @@ function M.create(ctx)
|
|||||||
state.overlay_loading_osd_timer = nil
|
state.overlay_loading_osd_timer = nil
|
||||||
end
|
end
|
||||||
|
|
||||||
|
local function clear_overlay_loading_osd_deadline()
|
||||||
|
local timeout = state.overlay_loading_osd_deadline
|
||||||
|
if timeout and timeout.kill then
|
||||||
|
timeout:kill()
|
||||||
|
end
|
||||||
|
state.overlay_loading_osd_deadline = nil
|
||||||
|
end
|
||||||
|
|
||||||
local function stop_overlay_loading_osd()
|
local function stop_overlay_loading_osd()
|
||||||
state.overlay_loading_osd_active = false
|
state.overlay_loading_osd_active = false
|
||||||
state.overlay_loading_osd_frame = 1
|
state.overlay_loading_osd_frame = 1
|
||||||
clear_overlay_loading_osd_timer()
|
clear_overlay_loading_osd_timer()
|
||||||
|
clear_overlay_loading_osd_deadline()
|
||||||
end
|
end
|
||||||
|
|
||||||
local function start_overlay_loading_osd()
|
local function start_overlay_loading_osd()
|
||||||
@@ -291,6 +302,21 @@ function M.create(ctx)
|
|||||||
end
|
end
|
||||||
end)
|
end)
|
||||||
end
|
end
|
||||||
|
if type(mp.add_timeout) == "function" then
|
||||||
|
state.overlay_loading_osd_deadline = mp.add_timeout(OVERLAY_LOADING_OSD_DEADLINE_SECONDS, function()
|
||||||
|
if not state.overlay_loading_osd_active then
|
||||||
|
return
|
||||||
|
end
|
||||||
|
state.overlay_loading_osd_deadline = nil
|
||||||
|
stop_overlay_loading_osd()
|
||||||
|
subminer_log(
|
||||||
|
"warn",
|
||||||
|
"process",
|
||||||
|
"Overlay loading deadline expired before the app reported content ready"
|
||||||
|
)
|
||||||
|
show_osd(OVERLAY_LOADING_OSD_TIMEOUT_MESSAGE, { force = true })
|
||||||
|
end)
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
local function disarm_auto_play_ready_gate(options)
|
local function disarm_auto_play_ready_gate(options)
|
||||||
|
|||||||
@@ -232,7 +232,7 @@ function M.create(ctx)
|
|||||||
elseif action_id == "triggerFieldGrouping" then
|
elseif action_id == "triggerFieldGrouping" then
|
||||||
return { "--trigger-field-grouping" }
|
return { "--trigger-field-grouping" }
|
||||||
elseif action_id == "triggerSubsync" then
|
elseif action_id == "triggerSubsync" then
|
||||||
return { "--trigger-subsync" }
|
return { "--session-action", '{"actionId":"triggerSubsync"}' }
|
||||||
elseif action_id == "mineSentence" then
|
elseif action_id == "mineSentence" then
|
||||||
return { "--mine-sentence" }
|
return { "--mine-sentence" }
|
||||||
elseif action_id == "mineSentenceMultiple" then
|
elseif action_id == "mineSentenceMultiple" then
|
||||||
@@ -251,7 +251,7 @@ function M.create(ctx)
|
|||||||
elseif action_id == "markWatched" then
|
elseif action_id == "markWatched" then
|
||||||
return { "--mark-watched" }
|
return { "--mark-watched" }
|
||||||
elseif action_id == "openRuntimeOptions" then
|
elseif action_id == "openRuntimeOptions" then
|
||||||
return { "--open-runtime-options" }
|
return { "--session-action", '{"actionId":"openRuntimeOptions"}' }
|
||||||
elseif action_id == "openJimaku" then
|
elseif action_id == "openJimaku" then
|
||||||
return { "--open-jimaku" }
|
return { "--open-jimaku" }
|
||||||
elseif action_id == "openTsukihime" or action_id == "openAnimetosho" then
|
elseif action_id == "openTsukihime" or action_id == "openAnimetosho" then
|
||||||
@@ -259,7 +259,7 @@ function M.create(ctx)
|
|||||||
elseif action_id == "openYoutubePicker" then
|
elseif action_id == "openYoutubePicker" then
|
||||||
return { "--open-youtube-picker" }
|
return { "--open-youtube-picker" }
|
||||||
elseif action_id == "openSessionHelp" then
|
elseif action_id == "openSessionHelp" then
|
||||||
return { "--open-session-help" }
|
return { "--session-action", '{"actionId":"openSessionHelp"}' }
|
||||||
elseif action_id == "openCharacterDictionaryManager" then
|
elseif action_id == "openCharacterDictionaryManager" then
|
||||||
return { "--session-action", '{"actionId":"openCharacterDictionaryManager"}' }
|
return { "--session-action", '{"actionId":"openCharacterDictionaryManager"}' }
|
||||||
elseif action_id == "openControllerSelect" then
|
elseif action_id == "openControllerSelect" then
|
||||||
|
|||||||
@@ -26,6 +26,7 @@ function M.new()
|
|||||||
auto_play_ready_initial_pause_ownership_consumed = false,
|
auto_play_ready_initial_pause_ownership_consumed = false,
|
||||||
overlay_loading_osd_active = false,
|
overlay_loading_osd_active = false,
|
||||||
overlay_loading_osd_timer = nil,
|
overlay_loading_osd_timer = nil,
|
||||||
|
overlay_loading_osd_deadline = nil,
|
||||||
overlay_loading_osd_frame = 1,
|
overlay_loading_osd_frame = 1,
|
||||||
pending_visible_overlay_hide_timer = nil,
|
pending_visible_overlay_hide_timer = nil,
|
||||||
pending_visible_overlay_hide_generation = 0,
|
pending_visible_overlay_hide_generation = 0,
|
||||||
|
|||||||
+13
-1
@@ -4,6 +4,7 @@ function M.create(ctx)
|
|||||||
local mp = ctx.mp
|
local mp = ctx.mp
|
||||||
local input = ctx.input
|
local input = ctx.input
|
||||||
local process = ctx.process
|
local process = ctx.process
|
||||||
|
local state = ctx.state
|
||||||
local subminer_log = ctx.log.subminer_log
|
local subminer_log = ctx.log.subminer_log
|
||||||
local show_osd = ctx.log.show_osd
|
local show_osd = ctx.log.show_osd
|
||||||
|
|
||||||
@@ -93,7 +94,18 @@ function M.create(ctx)
|
|||||||
if not ensure_binary_for_menu() then
|
if not ensure_binary_for_menu() then
|
||||||
return
|
return
|
||||||
end
|
end
|
||||||
process.run_control_command_async("open-session-help")
|
process.run_binary_command_async({
|
||||||
|
state.binary_path,
|
||||||
|
"--session-action",
|
||||||
|
'{"actionId":"openSessionHelp"}',
|
||||||
|
}, function(ok, result, error)
|
||||||
|
if ok then
|
||||||
|
return
|
||||||
|
end
|
||||||
|
local reason = error or (result and result.stderr) or "unknown error"
|
||||||
|
subminer_log("warn", "session-bindings", "Session action failed: " .. tostring(reason))
|
||||||
|
show_osd("Session action failed")
|
||||||
|
end)
|
||||||
end)
|
end)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
+38
-66
@@ -1,80 +1,52 @@
|
|||||||
> This is a prerelease build for testing. Stable changelog and docs-site updates remain pending until the final stable release.
|
> This is a prerelease build for testing. Stable changelog and docs-site updates remain pending until the final stable release.
|
||||||
|
|
||||||
<!-- prerelease-base-version: 0.19.0 -->
|
<!-- prerelease-base-version: 0.19.4 -->
|
||||||
|
|
||||||
## Highlights
|
## Highlights
|
||||||
### Added
|
### Added
|
||||||
|
- **Library Merge and Move**
|
||||||
- **Sync Stats & History**
|
- Duplicate library cards for the same show can now be combined: select cards in the library grid, choose "Merge Selected," and pick which entry to keep. Sessions, mined cards, and watch time move over, and future episodes stay matched to the merged card.
|
||||||
- New **Sync Stats & History** window (tray menu) and `subminer sync <host>` command keep mining stats and watch history in sync between machines over SSH, with saved devices, per-host sync direction, and live stage-by-stage progress.
|
- Episodes can be reassigned to a different library entry with a "→" button on the episode row, fixing cases where a file lands under the wrong title. Manual assignments survive later filename parsing, Jellyfin refreshes, and season repair.
|
||||||
- Merges are safe to repeat: data combines without duplicates, and hosts with auto-sync enabled sync automatically in the background on a schedule, reporting results as overlay notifications.
|
- Exact AniList matches with compatible seasons now merge automatically, while fuzzy matches show up as a dismissible "Possible duplicate" prompt instead of merging without confirmation.
|
||||||
- Manual snapshot tools (create, merge, reveal, delete) and connection testing cover one-off transfers; Windows machines running the built-in OpenSSH Server work as sync remotes too, with no setup needed beyond SSH access. Power users can script transfers directly with `--push`/`--pull`, `--check`, `--snapshot`/`--merge`, and `--json` flags.
|
|
||||||
|
|
||||||
- **TsukiHime Subtitle Downloads**
|
|
||||||
- Download Japanese and secondary-language subtitles for the current video directly from TsukiHime, mirroring the existing Jimaku flow.
|
|
||||||
- Press `Ctrl+Shift+T` to search by tabs for the primary and secondary languages; the matching release is found automatically from the video filename and loads straight into mpv, no API key required.
|
|
||||||
|
|
||||||
- **Post-Playback History Menu**
|
|
||||||
- After a watch-history episode ends or mpv closes, the fzf/rofi launcher returns to that series with options to play the previous or next episode, rewatch, pick another episode, or quit SubMiner.
|
|
||||||
- Previous/Next continue across season directories, so you can binge a show without manually browsing folders.
|
|
||||||
- The menu shown right after picking a series from `subminer -H` now offers the previous episode too, matching the post-playback menu.
|
|
||||||
|
|
||||||
- **Known-Word Highlighting by Anki Maturity**
|
|
||||||
- Subtitle highlights for known words can now be colored by Anki card maturity (new, learning, young, mature), similar to asbplayer. Enable it with `ankiConnect.knownWords.maturityEnabled`, or toggle it live during a session.
|
|
||||||
- The mature-interval threshold and the four tier colors are configurable, and the in-session help legend shows the active tier colors while maturity highlighting is on.
|
|
||||||
- Tiers follow Anki's own card state: a lapsed card correctly shows as learning rather than young, and a note is treated as mature if any of its cards are mature. Stats and other known-word tools stay accurate with this new data.
|
|
||||||
|
|
||||||
- **Stats Library Entry Deletion**
|
|
||||||
- Added a "Delete Entry" action in the stats Library detail view that removes an entire title in one step: every episode, session, subtitle line, rollup, cover, and vocabulary count derived from it. Previously a mistaken entry had to be cleared episode by episode and still lingered in the Library.
|
|
||||||
- Delete progress (session, session group, episode, or full entry) now shows app-wide as a progress bar plus a status toast, staying visible across tabs and windows instead of disappearing when you switch away.
|
|
||||||
- Deletes are dramatically faster on large libraries, and opening the Vocabulary tab no longer stalls; the first launch after upgrading migrates the stats database in place to support this.
|
|
||||||
|
|
||||||
### Changed
|
|
||||||
|
|
||||||
- **Clipboard-Video Shortcut**
|
|
||||||
- The "append clipboard video to queue" shortcut is now configurable via `shortcuts.appendClipboardVideoToQueue` instead of being fixed.
|
|
||||||
|
|
||||||
### Fixed
|
### Fixed
|
||||||
|
- **Anki Audio Generation on Network Drives**
|
||||||
|
- Fixed sentence-audio generation timing out on slow network-mounted video files with many subtitle and font-attachment streams.
|
||||||
|
- Extraction now uses bounded probing and a two-minute budget, and failures show a clear error instead of a cryptic one.
|
||||||
|
- **Duplicate Subtitle Line Stats**
|
||||||
|
- Fixed karaoke openings and animated signs (which record one subtitle event per animation frame) inflating word and kanji counts and skewing "Top Repeated Words." Ordinary repeated dialogue and rewatches are unaffected.
|
||||||
|
- Already-inflated stats can be cleaned up with the new "Duplicates" button in the Vocabulary tab, or `subminer stats cleanup --duplicate-lines` (supports `--dry-run` and `--lookback-days`). Only the affected subtitle lines and vocabulary counts are touched; watch time and lines-seen totals are untouched.
|
||||||
|
- **Overlay Modals on macOS and Windows**
|
||||||
|
- Fixed overlay modals and the stats window opening on the wrong macOS Space, or forcing a Space switch, when mpv is fullscreen. They now open above fullscreen mpv on its current Space.
|
||||||
|
- Modals are now prewarmed on macOS and Windows so shortcuts open them promptly, and Windows keeps the hidden modal responsive between sessions.
|
||||||
|
- **Wayland File Drag-and-Drop**
|
||||||
|
- Fixed dragging subtitle and video files from file managers like Thunar onto the overlay on native Wayland; dropped files are now resolved and sent to mpv.
|
||||||
|
- **Windows Mouse Lag**
|
||||||
|
- Fixed system-wide mouse lag while SubMiner is running on Windows, caused by a global mouse hook and blocking window lookups during click-through tracking.
|
||||||
|
- **Mining Clip Accuracy**
|
||||||
|
- Fixed mined audio and animated image clips sometimes capturing the wrong subtitle line when audio extraction was slow. The clip range is now locked in at the moment of lookup, so audio and image clips always match.
|
||||||
|
- **Linux Notifications**
|
||||||
|
- Character dictionary progress notifications on Linux now update in place instead of flickering off and back on with every status change.
|
||||||
|
- **Stats Delete Performance**
|
||||||
|
- Fixed stats deletes freezing the dashboard; deletes now reliably run off the main thread, with automatic retry if the delete worker crashes.
|
||||||
|
- Deletes, library merges/moves, and AniList reassignments are now much faster because totals are updated incrementally instead of rebuilt from scratch, and no longer erase lifetime totals older than the recent session history.
|
||||||
|
- Session deletes on large libraries dropped from minutes to milliseconds.
|
||||||
|
|
||||||
- **Word Highlighting Accuracy**
|
### Docs
|
||||||
- Fixed several incorrect word highlighting and annotation cases: inconsistent part-of-speech exclusions on merged quote-particle tokens, missing annotations for rare kanji, katakana punctuation wrongly treated as non-kana noise, and certain kanji vocabulary skipped for next-level ("N+1") highlighting.
|
- **Feature Demos Page**
|
||||||
|
- Hidden the unfinished feature demos page from the documentation sidebar; it's still reachable by direct URL.
|
||||||
- **AniList Season Resolution**
|
|
||||||
- Season 2 and later episodes now resolve to the correct AniList entry by walking sequel relations instead of guessing from the title, so watch progress, the character dictionary, and cover art for later seasons no longer silently fall back to season 1.
|
|
||||||
- Manual AniList overrides now stay in effect for every episode in the same season (by folder and detected season), and setting an override now fixes both the character dictionary and AniList watch progress together instead of needing separate corrections.
|
|
||||||
|
|
||||||
- **Startup Playback Pausing Too Early**
|
|
||||||
- Fixed playback resuming before subtitle processing finished warming up, which could briefly show untranslated subtitles right after opening a video.
|
|
||||||
- Most noticeable when resuming mid-episode or when a subtitle cue starts within the first couple of seconds.
|
|
||||||
|
|
||||||
- **Linux AppImage Crash Notification on Quit**
|
|
||||||
- Fixed a spurious "Service Crash" desktop notification appearing after closing a video when running the Linux AppImage.
|
|
||||||
- If needed, the mount-keepalive behavior behind this fix can be disabled with `SUBMINER_NO_APPIMAGE_MOUNT_KEEPALIVE=1`.
|
|
||||||
|
|
||||||
- **AnkiConnect Proxy Port Conflict**
|
|
||||||
- Fixed video playback failing to start when another process already held the configured AnkiConnect proxy port; SubMiner now shows a notification explaining how to resolve the conflict instead of crashing.
|
|
||||||
|
|
||||||
- **Stats & Settings Reliability**
|
|
||||||
- Fixed session stats reporting zero known words after the known-word cache gained maturity tiers.
|
|
||||||
- Hardened the stats server against malformed requests, stalled AniList lookups, media mismatches during word mining, and missing Yomitan connections.
|
|
||||||
- AnkiConnect settings validation now preserves valid custom configurations while safely falling back on invalid values instead of failing.
|
|
||||||
|
|
||||||
- **Stats Library Cover After Relink**
|
|
||||||
- Relinking a title to a different AniList entry now updates its cover art in the stats Library grid, not just the detail view, so unrelated titles no longer end up sharing the wrong cover.
|
|
||||||
|
|
||||||
- **Rofi Menu Prompt Spacing**
|
|
||||||
- Rofi menu prompts now keep a space between the prompt label and the input field instead of crowding the search placeholder text.
|
|
||||||
|
|
||||||
## What's Changed
|
## What's Changed
|
||||||
|
|
||||||
- feat(shortcuts): make clipboard-video-append shortcut configurable by @ksyasuda in #158
|
- feat(stats): add library entry merge and episode move by @ksyasuda in #190
|
||||||
- refactor(tokenizer): extract subtitle annotation filter into rule table by @ksyasuda in #162
|
- fix(stats): stop counting duplicate typeset subtitle lines by @ksyasuda in #191
|
||||||
- refactor(tsukihime): swap Animetosho backend for TsukiHime API by @ksyasuda in #165
|
- fix(media): tolerate slow MKV audio extraction by @ksyasuda in #195
|
||||||
- refactor: split anki-connect and stats-server resolvers into modules by @ksyasuda in #169
|
- fix(stats): subtract lifetime totals incrementally on delete by @ksyasuda in #196
|
||||||
- feat(launcher): add post-playback history menu with previous episode by @ksyasuda in #170
|
- fix(anki): snapshot mining media clip timing by @ksyasuda in #197
|
||||||
- Anki maturity-based known-word highlighting by @ksyasuda in #172
|
- fix(notifications): replace Linux progress updates in place by @ksyasuda in #198
|
||||||
- fix(anilist): resolve later seasons via sequel relations, not title guessing by @ksyasuda in #173
|
- fix(overlay): support native Wayland file drag-and-drop by @ksyasuda in #199
|
||||||
- feat(stats): add library entry deletion and app-wide delete progress by @ksyasuda in #174
|
- fix(overlay): keep macOS modal windows on fullscreen Spaces by @ksyasuda in #200
|
||||||
|
- fix(overlay): prevent Windows mouse lag during click-through tracking by @ksyasuda in #201
|
||||||
|
|
||||||
## Installation
|
## Installation
|
||||||
|
|
||||||
|
|||||||
@@ -35,6 +35,17 @@ const archiveCacheRoot = join(repoRoot, '.tmp/docs-versioned-archive-cache');
|
|||||||
const maxCloudflareFiles = 20_000;
|
const maxCloudflareFiles = 20_000;
|
||||||
const maxCloudflareFileBytes = 25 * 1024 * 1024;
|
const maxCloudflareFileBytes = 25 * 1024 * 1024;
|
||||||
|
|
||||||
|
// Cloudflare Pages header rules for the whole deployment. Mirrors the `noindex,follow`
|
||||||
|
// meta tag the non-root channels emit, so the duplicate trees stay out of the index
|
||||||
|
// even for responses a crawler takes without parsing the HTML.
|
||||||
|
const deployHeaders = `# Generated by scripts/build-versioned-docs.ts. Do not edit by hand.
|
||||||
|
/main/*
|
||||||
|
X-Robots-Tag: noindex, follow
|
||||||
|
|
||||||
|
/v/*
|
||||||
|
X-Robots-Tag: noindex, follow
|
||||||
|
`;
|
||||||
|
|
||||||
function run(
|
function run(
|
||||||
command: string,
|
command: string,
|
||||||
args: string[],
|
args: string[],
|
||||||
@@ -173,6 +184,7 @@ function buildDocs(options: {
|
|||||||
SUBMINER_DOCS_BASE: options.base,
|
SUBMINER_DOCS_BASE: options.base,
|
||||||
SUBMINER_DOCS_OUT_DIR: options.outDir,
|
SUBMINER_DOCS_OUT_DIR: options.outDir,
|
||||||
SUBMINER_DOCS_SOURCE_DIR: options.snapshotDocsSite,
|
SUBMINER_DOCS_SOURCE_DIR: options.snapshotDocsSite,
|
||||||
|
SUBMINER_DOCS_REPO_DIR: currentDocsSite,
|
||||||
SUBMINER_DOCS_CHANNEL: options.channel,
|
SUBMINER_DOCS_CHANNEL: options.channel,
|
||||||
SUBMINER_DOCS_VERSION: options.version ?? '',
|
SUBMINER_DOCS_VERSION: options.version ?? '',
|
||||||
SUBMINER_DOCS_LATEST_STABLE: options.latestStable,
|
SUBMINER_DOCS_LATEST_STABLE: options.latestStable,
|
||||||
@@ -378,6 +390,7 @@ function main() {
|
|||||||
});
|
});
|
||||||
|
|
||||||
writeFileSync(join(aggregateOutDir, 'versions.json'), `${JSON.stringify(manifest, null, 2)}\n`);
|
writeFileSync(join(aggregateOutDir, 'versions.json'), `${JSON.stringify(manifest, null, 2)}\n`);
|
||||||
|
writeFileSync(join(aggregateOutDir, '_headers'), deployHeaders);
|
||||||
assertCloudflarePagesLimits(aggregateOutDir);
|
assertCloudflarePagesLimits(aggregateOutDir);
|
||||||
const prunedArchives = pruneArchiveCacheGenerations({
|
const prunedArchives = pruneArchiveCacheGenerations({
|
||||||
cacheRoot: archiveCacheRoot,
|
cacheRoot: archiveCacheRoot,
|
||||||
|
|||||||
@@ -130,7 +130,9 @@ local function run_plugin_scenario(config)
|
|||||||
|
|
||||||
function mp.add_timeout(seconds, callback)
|
function mp.add_timeout(seconds, callback)
|
||||||
recorded.timeouts[#recorded.timeouts + 1] = seconds
|
recorded.timeouts[#recorded.timeouts + 1] = seconds
|
||||||
|
local delay = tonumber(seconds) or 0
|
||||||
local timeout = {
|
local timeout = {
|
||||||
|
seconds = delay,
|
||||||
killed = false,
|
killed = false,
|
||||||
callback = callback,
|
callback = callback,
|
||||||
}
|
}
|
||||||
@@ -138,7 +140,6 @@ local function run_plugin_scenario(config)
|
|||||||
self.killed = true
|
self.killed = true
|
||||||
end
|
end
|
||||||
|
|
||||||
local delay = tonumber(seconds) or 0
|
|
||||||
if callback and delay < 5 and not config.defer_timeouts then
|
if callback and delay < 5 and not config.defer_timeouts then
|
||||||
callback()
|
callback()
|
||||||
end
|
end
|
||||||
@@ -514,6 +515,15 @@ local function has_timeout(timeouts, target)
|
|||||||
return false
|
return false
|
||||||
end
|
end
|
||||||
|
|
||||||
|
local function find_timeout_handle(recorded, target)
|
||||||
|
for _, timeout in ipairs(recorded.timeout_handles) do
|
||||||
|
if math.abs(timeout.seconds - target) < 0.0001 then
|
||||||
|
return timeout
|
||||||
|
end
|
||||||
|
end
|
||||||
|
return nil
|
||||||
|
end
|
||||||
|
|
||||||
local function env_has(call, target)
|
local function env_has(call, target)
|
||||||
local env = (call and call.env) or {}
|
local env = (call and call.env) or {}
|
||||||
for _, value in ipairs(env) do
|
for _, value in ipairs(env) do
|
||||||
@@ -1636,6 +1646,8 @@ do
|
|||||||
#recorded.periodic_timers == 1,
|
#recorded.periodic_timers == 1,
|
||||||
"auto-start visible overlay should refresh the early overlay loading OSD"
|
"auto-start visible overlay should refresh the early overlay loading OSD"
|
||||||
)
|
)
|
||||||
|
local overlay_loading_deadline = find_timeout_handle(recorded, 30)
|
||||||
|
assert_true(overlay_loading_deadline ~= nil, "overlay loading OSD should have a bounded deadline")
|
||||||
local overlay_loading_timer = recorded.periodic_timers[1]
|
local overlay_loading_timer = recorded.periodic_timers[1]
|
||||||
recorded.periodic_timers[1].callback()
|
recorded.periodic_timers[1].callback()
|
||||||
assert_true(
|
assert_true(
|
||||||
@@ -1670,6 +1682,46 @@ do
|
|||||||
recorded.periodic_timers[1].killed == true,
|
recorded.periodic_timers[1].killed == true,
|
||||||
"overlay loading ready should stop the early overlay loading OSD refresher"
|
"overlay loading ready should stop the early overlay loading OSD refresher"
|
||||||
)
|
)
|
||||||
|
assert_true(
|
||||||
|
overlay_loading_deadline.killed == true,
|
||||||
|
"overlay loading ready should cancel the bounded loading deadline"
|
||||||
|
)
|
||||||
|
end
|
||||||
|
|
||||||
|
do
|
||||||
|
local recorded, err = run_plugin_scenario({
|
||||||
|
defer_timeouts = true,
|
||||||
|
process_list = "",
|
||||||
|
option_overrides = {
|
||||||
|
binary_path = binary_path,
|
||||||
|
auto_start = "yes",
|
||||||
|
auto_start_visible_overlay = "yes",
|
||||||
|
osd_messages = false,
|
||||||
|
socket_path = "/tmp/subminer-socket",
|
||||||
|
},
|
||||||
|
input_ipc_server = "/tmp/subminer-socket",
|
||||||
|
media_title = "Random Movie",
|
||||||
|
files = {
|
||||||
|
[binary_path] = true,
|
||||||
|
},
|
||||||
|
})
|
||||||
|
assert_true(recorded ~= nil, "plugin failed to load for overlay loading deadline scenario: " .. tostring(err))
|
||||||
|
fire_event(recorded, "start-file")
|
||||||
|
local overlay_loading_deadline = find_timeout_handle(recorded, 30)
|
||||||
|
assert_true(overlay_loading_deadline ~= nil, "overlay loading deadline should be scheduled")
|
||||||
|
overlay_loading_deadline.callback()
|
||||||
|
assert_true(
|
||||||
|
recorded.periodic_timers[1].killed == true,
|
||||||
|
"overlay loading deadline should stop the loading spinner"
|
||||||
|
)
|
||||||
|
assert_true(
|
||||||
|
has_osd_message(recorded.osd, "SubMiner: Overlay did not become ready; check SubMiner logs"),
|
||||||
|
"overlay loading deadline should replace the spinner with actionable feedback"
|
||||||
|
)
|
||||||
|
assert_true(
|
||||||
|
has_log_containing(recorded.logs, "Overlay loading deadline expired"),
|
||||||
|
"overlay loading deadline should leave a diagnostic log entry"
|
||||||
|
)
|
||||||
end
|
end
|
||||||
|
|
||||||
do
|
do
|
||||||
|
|||||||
@@ -34,6 +34,7 @@ import {
|
|||||||
parseSubsyncManualRunRequest,
|
parseSubsyncManualRunRequest,
|
||||||
parseYoutubePickerResolveRequest,
|
parseYoutubePickerResolveRequest,
|
||||||
} from '../../shared/ipc/validators';
|
} from '../../shared/ipc/validators';
|
||||||
|
import { applyOverlayClickThrough } from './overlay-click-through';
|
||||||
|
|
||||||
const { ipcMain } = electron;
|
const { ipcMain } = electron;
|
||||||
|
|
||||||
@@ -442,8 +443,14 @@ export function registerIpcHandlers(deps: IpcServiceDeps, ipc: IpcMainRegistrar
|
|||||||
const senderWindow =
|
const senderWindow =
|
||||||
electron.BrowserWindow?.fromWebContents((event as IpcMainEvent).sender) ?? null;
|
electron.BrowserWindow?.fromWebContents((event as IpcMainEvent).sender) ?? null;
|
||||||
if (senderWindow && !senderWindow.isDestroyed()) {
|
if (senderWindow && !senderWindow.isDestroyed()) {
|
||||||
|
// Route forwarding requests through the platform-aware helper so Windows never
|
||||||
|
// installs Electron's global mouse hook (see overlay-click-through.ts).
|
||||||
|
if (ignore && parsedOptions?.forward) {
|
||||||
|
applyOverlayClickThrough(senderWindow);
|
||||||
|
} else {
|
||||||
senderWindow.setIgnoreMouseEvents(ignore, parsedOptions);
|
senderWindow.setIgnoreMouseEvents(ignore, parsedOptions);
|
||||||
}
|
}
|
||||||
|
}
|
||||||
deps.onOverlayMouseInteractionChanged?.(!ignore, senderWindow);
|
deps.onOverlayMouseInteractionChanged?.(!ignore, senderWindow);
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -125,9 +125,40 @@ test('mineSentenceCard creates sentence card from mpv subtitle state', async ()
|
|||||||
]);
|
]);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('mineSentenceCard refreshes secondary subtitle text before creating card', async () => {
|
test('mineSentenceCard uses normalized secondary subtitle state instead of raw mpv text', async () => {
|
||||||
|
const created: Array<{ sentence: string; secondarySub?: string }> = [];
|
||||||
|
let requestedRawSecondaryText = false;
|
||||||
|
|
||||||
|
await mineSentenceCard({
|
||||||
|
ankiIntegration: {
|
||||||
|
updateLastAddedFromClipboard: async () => {},
|
||||||
|
triggerFieldGroupingForLastAddedCard: async () => {},
|
||||||
|
markLastCardAsAudioCard: async () => {},
|
||||||
|
createSentenceCard: async (sentence, _startTime, _endTime, secondarySub) => {
|
||||||
|
created.push({ sentence, secondarySub });
|
||||||
|
return true;
|
||||||
|
},
|
||||||
|
},
|
||||||
|
mpvClient: {
|
||||||
|
connected: true,
|
||||||
|
currentSubText: '日本語字幕',
|
||||||
|
currentSubStart: 10,
|
||||||
|
currentSubEnd: 12,
|
||||||
|
currentSecondarySubText: 'Your\nmosaic',
|
||||||
|
requestProperty: async () => {
|
||||||
|
requestedRawSecondaryText = true;
|
||||||
|
return 'Your\nYour\nYour\nYour\nmosaic';
|
||||||
|
},
|
||||||
|
},
|
||||||
|
showMpvOsd: () => {},
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(requestedRawSecondaryText, false);
|
||||||
|
assert.deepEqual(created, [{ sentence: '日本語字幕', secondarySub: 'Your\nmosaic' }]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('mineSentenceCard omits normalized secondary text that matches the primary subtitle', async () => {
|
||||||
const created: Array<{ sentence: string; secondarySub?: string }> = [];
|
const created: Array<{ sentence: string; secondarySub?: string }> = [];
|
||||||
const requestedProperties: string[] = [];
|
|
||||||
|
|
||||||
await mineSentenceCard({
|
await mineSentenceCard({
|
||||||
ankiIntegration: {
|
ankiIntegration: {
|
||||||
@@ -145,43 +176,6 @@ test('mineSentenceCard refreshes secondary subtitle text before creating card',
|
|||||||
currentSubStart: 10,
|
currentSubStart: 10,
|
||||||
currentSubEnd: 12,
|
currentSubEnd: 12,
|
||||||
currentSecondarySubText: '日本語字幕',
|
currentSecondarySubText: '日本語字幕',
|
||||||
requestProperty: async (name: string) => {
|
|
||||||
requestedProperties.push(name);
|
|
||||||
return name === 'secondary-sub-text' ? 'English subtitle' : null;
|
|
||||||
},
|
|
||||||
},
|
|
||||||
showMpvOsd: () => {},
|
|
||||||
});
|
|
||||||
|
|
||||||
assert.deepEqual(requestedProperties, ['secondary-sub-text']);
|
|
||||||
assert.deepEqual(created, [{ sentence: '日本語字幕', secondarySub: 'English subtitle' }]);
|
|
||||||
});
|
|
||||||
|
|
||||||
test('mineSentenceCard does not fall back to stale cached secondary subtitle after successful refresh', async () => {
|
|
||||||
const created: Array<{ sentence: string; secondarySub?: string }> = [];
|
|
||||||
|
|
||||||
await mineSentenceCard({
|
|
||||||
ankiIntegration: {
|
|
||||||
updateLastAddedFromClipboard: async () => {},
|
|
||||||
triggerFieldGroupingForLastAddedCard: async () => {},
|
|
||||||
markLastCardAsAudioCard: async () => {},
|
|
||||||
createSentenceCard: async (sentence, _startTime, _endTime, secondarySub) => {
|
|
||||||
created.push({ sentence, secondarySub });
|
|
||||||
return true;
|
|
||||||
},
|
|
||||||
},
|
|
||||||
mpvClient: {
|
|
||||||
connected: true,
|
|
||||||
currentSubText: '日本語字幕',
|
|
||||||
currentSubStart: 10,
|
|
||||||
currentSubEnd: 12,
|
|
||||||
currentSecondarySubText: 'stale cached subtitle',
|
|
||||||
requestProperty: async (name: string) => {
|
|
||||||
if (name === 'secondary-sub-text') {
|
|
||||||
return '';
|
|
||||||
}
|
|
||||||
return null;
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
showMpvOsd: () => {},
|
showMpvOsd: () => {},
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -129,19 +129,8 @@ function normalizeSecondarySubText(text: unknown, primaryText: string): string |
|
|||||||
return trimmed;
|
return trimmed;
|
||||||
}
|
}
|
||||||
|
|
||||||
async function getCurrentSecondarySubTextForSentenceCard(
|
function getCurrentSecondarySubTextForSentenceCard(mpvClient: MpvClientLike): string | undefined {
|
||||||
mpvClient: MpvClientLike,
|
return normalizeSecondarySubText(mpvClient.currentSecondarySubText, mpvClient.currentSubText);
|
||||||
): Promise<string | undefined> {
|
|
||||||
const primaryText = mpvClient.currentSubText;
|
|
||||||
if (mpvClient.requestProperty) {
|
|
||||||
try {
|
|
||||||
const latestSecondaryText = await mpvClient.requestProperty('secondary-sub-text');
|
|
||||||
return normalizeSecondarySubText(latestSecondaryText, primaryText);
|
|
||||||
} catch {
|
|
||||||
// Fall back to the cached secondary subtitle below.
|
|
||||||
}
|
|
||||||
}
|
|
||||||
return normalizeSecondarySubText(mpvClient.currentSecondarySubText, primaryText);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
export async function updateLastCardFromClipboard(deps: {
|
export async function updateLastCardFromClipboard(deps: {
|
||||||
@@ -190,7 +179,7 @@ export async function mineSentenceCard(deps: {
|
|||||||
return false;
|
return false;
|
||||||
}
|
}
|
||||||
|
|
||||||
const secondarySubText = await getCurrentSecondarySubTextForSentenceCard(mpvClient);
|
const secondarySubText = getCurrentSecondarySubTextForSentenceCard(mpvClient);
|
||||||
return await anki.createSentenceCard(
|
return await anki.createSentenceCard(
|
||||||
mpvClient.currentSubText,
|
mpvClient.currentSubText,
|
||||||
mpvClient.currentSubStart,
|
mpvClient.currentSubStart,
|
||||||
|
|||||||
@@ -53,7 +53,7 @@ const MPV_SUBTITLE_PROPERTY_OBSERVATIONS: string[] = [
|
|||||||
'sub-scale-by-window',
|
'sub-scale-by-window',
|
||||||
'osd-height',
|
'osd-height',
|
||||||
'osd-dimensions',
|
'osd-dimensions',
|
||||||
'sub-text-ass',
|
'sub-text/ass',
|
||||||
'sub-border-size',
|
'sub-border-size',
|
||||||
'sub-shadow-offset',
|
'sub-shadow-offset',
|
||||||
'sub-ass-override',
|
'sub-ass-override',
|
||||||
@@ -65,6 +65,8 @@ const MPV_SUBTITLE_PROPERTY_OBSERVATIONS: string[] = [
|
|||||||
'secondary-sub-visibility',
|
'secondary-sub-visibility',
|
||||||
'sub-visibility',
|
'sub-visibility',
|
||||||
'sid',
|
'sid',
|
||||||
|
'secondary-sid',
|
||||||
|
'secondary-sub-delay',
|
||||||
'track-list',
|
'track-list',
|
||||||
];
|
];
|
||||||
|
|
||||||
@@ -74,7 +76,7 @@ const MPV_INITIAL_PROPERTY_REQUESTS: Array<MpvProtocolCommand> = [
|
|||||||
request_id: MPV_REQUEST_ID_SUBTEXT,
|
request_id: MPV_REQUEST_ID_SUBTEXT,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
command: ['get_property', 'sub-text-ass'],
|
command: ['get_property', 'sub-text/ass'],
|
||||||
request_id: MPV_REQUEST_ID_SUBTEXT_ASS,
|
request_id: MPV_REQUEST_ID_SUBTEXT_ASS,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
|
|||||||
@@ -63,6 +63,8 @@ function createDeps(overrides: Partial<MpvProtocolHandleMessageDeps> = {}): {
|
|||||||
emitSubtitleTiming: (payload) => state.events.push(payload),
|
emitSubtitleTiming: (payload) => state.events.push(payload),
|
||||||
emitSecondarySubtitleChange: (payload) => state.events.push(payload),
|
emitSecondarySubtitleChange: (payload) => state.events.push(payload),
|
||||||
emitSubtitleTrackChange: (payload) => state.events.push(payload),
|
emitSubtitleTrackChange: (payload) => state.events.push(payload),
|
||||||
|
emitSecondarySubtitleTrackChange: (payload) => state.events.push(payload),
|
||||||
|
emitSecondarySubtitleDelayChange: (payload) => state.events.push(payload),
|
||||||
emitSubtitleTrackListChange: (payload) => state.events.push(payload),
|
emitSubtitleTrackListChange: (payload) => state.events.push(payload),
|
||||||
getCurrentSubText: () => state.subText,
|
getCurrentSubText: () => state.subText,
|
||||||
setCurrentSubText: (text) => {
|
setCurrentSubText: (text) => {
|
||||||
@@ -129,6 +131,28 @@ test('dispatchMpvProtocolMessage emits subtitle text on property change', async
|
|||||||
assert.deepEqual(state.events, [{ text: '字幕', isOverlayVisible: false }]);
|
assert.deepEqual(state.events, [{ text: '字幕', isOverlayVisible: false }]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('dispatchMpvProtocolMessage emits ASS subtitle text from the current mpv property', async () => {
|
||||||
|
const { deps, state } = createDeps();
|
||||||
|
|
||||||
|
await dispatchMpvProtocolMessage(
|
||||||
|
{ event: 'property-change', name: 'sub-text/ass', data: '{\\b1}字幕' },
|
||||||
|
deps,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert.deepEqual(state.events, [{ text: '{\\b1}字幕' }]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('dispatchMpvProtocolMessage emits ASS subtitle text from the legacy mpv property', async () => {
|
||||||
|
const { deps, state } = createDeps();
|
||||||
|
|
||||||
|
await dispatchMpvProtocolMessage(
|
||||||
|
{ event: 'property-change', name: 'sub-text-ass', data: '{\\b1}字幕' },
|
||||||
|
deps,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert.deepEqual(state.events, [{ text: '{\\b1}字幕' }]);
|
||||||
|
});
|
||||||
|
|
||||||
test('dispatchMpvProtocolMessage emits subtitle track changes', async () => {
|
test('dispatchMpvProtocolMessage emits subtitle track changes', async () => {
|
||||||
const { deps, state } = createDeps({
|
const { deps, state } = createDeps({
|
||||||
emitSubtitleTrackChange: (payload) => state.events.push(payload),
|
emitSubtitleTrackChange: (payload) => state.events.push(payload),
|
||||||
@@ -136,12 +160,42 @@ test('dispatchMpvProtocolMessage emits subtitle track changes', async () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
await dispatchMpvProtocolMessage({ event: 'property-change', name: 'sid', data: '3' }, deps);
|
await dispatchMpvProtocolMessage({ event: 'property-change', name: 'sid', data: '3' }, deps);
|
||||||
|
await dispatchMpvProtocolMessage(
|
||||||
|
{ event: 'property-change', name: 'secondary-sid', data: '4' },
|
||||||
|
deps,
|
||||||
|
);
|
||||||
|
await dispatchMpvProtocolMessage(
|
||||||
|
{ event: 'property-change', name: 'secondary-sub-delay', data: '0.5' },
|
||||||
|
deps,
|
||||||
|
);
|
||||||
await dispatchMpvProtocolMessage(
|
await dispatchMpvProtocolMessage(
|
||||||
{ event: 'property-change', name: 'track-list', data: [{ type: 'sub', id: 3 }] },
|
{ event: 'property-change', name: 'track-list', data: [{ type: 'sub', id: 3 }] },
|
||||||
deps,
|
deps,
|
||||||
);
|
);
|
||||||
|
|
||||||
assert.deepEqual(state.events, [{ sid: 3 }, { trackList: [{ type: 'sub', id: 3 }] }]);
|
assert.deepEqual(state.events, [
|
||||||
|
{ sid: 3 },
|
||||||
|
{ sid: 4 },
|
||||||
|
{ delay: 0.5 },
|
||||||
|
{ trackList: [{ type: 'sub', id: 3 }] },
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('dispatchMpvProtocolMessage rejects decimal subtitle track IDs', async () => {
|
||||||
|
const { deps, state } = createDeps();
|
||||||
|
|
||||||
|
await dispatchMpvProtocolMessage({ event: 'property-change', name: 'sid', data: '4.5' }, deps);
|
||||||
|
await dispatchMpvProtocolMessage(
|
||||||
|
{ event: 'property-change', name: 'secondary-sid', data: '4.5' },
|
||||||
|
deps,
|
||||||
|
);
|
||||||
|
await dispatchMpvProtocolMessage({ event: 'property-change', name: 'sid', data: 4.5 }, deps);
|
||||||
|
await dispatchMpvProtocolMessage(
|
||||||
|
{ event: 'property-change', name: 'secondary-sid', data: 4.5 },
|
||||||
|
deps,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert.deepEqual(state.events, [{ sid: null }, { sid: null }, { sid: null }, { sid: null }]);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('dispatchMpvProtocolMessage enforces sub-visibility hidden when overlay suppression is enabled', async () => {
|
test('dispatchMpvProtocolMessage enforces sub-visibility hidden when overlay suppression is enabled', async () => {
|
||||||
|
|||||||
@@ -54,6 +54,8 @@ export interface MpvProtocolHandleMessageDeps {
|
|||||||
emitSubtitleTiming: (payload: { text: string; start: number; end: number }) => void;
|
emitSubtitleTiming: (payload: { text: string; start: number; end: number }) => void;
|
||||||
emitSecondarySubtitleChange: (payload: { text: string }) => void;
|
emitSecondarySubtitleChange: (payload: { text: string }) => void;
|
||||||
emitSubtitleTrackChange: (payload: { sid: number | null }) => void;
|
emitSubtitleTrackChange: (payload: { sid: number | null }) => void;
|
||||||
|
emitSecondarySubtitleTrackChange: (payload: { sid: number | null }) => void;
|
||||||
|
emitSecondarySubtitleDelayChange: (payload: { delay: number }) => void;
|
||||||
emitSubtitleTrackListChange: (payload: { trackList: unknown[] | null }) => void;
|
emitSubtitleTrackListChange: (payload: { trackList: unknown[] | null }) => void;
|
||||||
getCurrentSubText: () => string;
|
getCurrentSubText: () => string;
|
||||||
setCurrentSubText: (text: string) => void;
|
setCurrentSubText: (text: string) => void;
|
||||||
@@ -248,7 +250,7 @@ export async function dispatchMpvProtocolMessage(
|
|||||||
isOverlayVisible: overlayVisible,
|
isOverlayVisible: overlayVisible,
|
||||||
});
|
});
|
||||||
deps.setCurrentSubText(nextSubText);
|
deps.setCurrentSubText(nextSubText);
|
||||||
} else if (msg.name === 'sub-text-ass') {
|
} else if (msg.name === 'sub-text/ass' || msg.name === 'sub-text-ass') {
|
||||||
deps.emitSubtitleAssChange({ text: (msg.data as string) || '' });
|
deps.emitSubtitleAssChange({ text: (msg.data as string) || '' });
|
||||||
} else if (msg.name === 'sub-start') {
|
} else if (msg.name === 'sub-start') {
|
||||||
deps.setCurrentSubStart((msg.data as number) || 0);
|
deps.setCurrentSubStart((msg.data as number) || 0);
|
||||||
@@ -281,7 +283,25 @@ export async function dispatchMpvProtocolMessage(
|
|||||||
: typeof msg.data === 'string'
|
: typeof msg.data === 'string'
|
||||||
? Number(msg.data)
|
? Number(msg.data)
|
||||||
: null;
|
: null;
|
||||||
deps.emitSubtitleTrackChange({ sid: sid !== null && Number.isFinite(sid) ? sid : null });
|
deps.emitSubtitleTrackChange({ sid: sid !== null && Number.isInteger(sid) ? sid : null });
|
||||||
|
} else if (msg.name === 'secondary-sid') {
|
||||||
|
const sid =
|
||||||
|
typeof msg.data === 'number'
|
||||||
|
? msg.data
|
||||||
|
: typeof msg.data === 'string'
|
||||||
|
? Number(msg.data)
|
||||||
|
: null;
|
||||||
|
deps.emitSecondarySubtitleTrackChange({
|
||||||
|
sid: sid !== null && Number.isInteger(sid) ? sid : null,
|
||||||
|
});
|
||||||
|
} else if (msg.name === 'secondary-sub-delay') {
|
||||||
|
const delay =
|
||||||
|
typeof msg.data === 'number'
|
||||||
|
? msg.data
|
||||||
|
: typeof msg.data === 'string'
|
||||||
|
? Number(msg.data)
|
||||||
|
: 0;
|
||||||
|
deps.emitSecondarySubtitleDelayChange({ delay: Number.isFinite(delay) ? delay : 0 });
|
||||||
} else if (msg.name === 'track-list') {
|
} else if (msg.name === 'track-list') {
|
||||||
deps.emitSubtitleTrackListChange({
|
deps.emitSubtitleTrackListChange({
|
||||||
trackList: Array.isArray(msg.data) ? (msg.data as unknown[]) : null,
|
trackList: Array.isArray(msg.data) ? (msg.data as unknown[]) : null,
|
||||||
|
|||||||
@@ -38,7 +38,15 @@ class ManualCloseSocket extends FakeSocket {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const wait = () => new Promise((resolve) => setTimeout(resolve, 0));
|
class HangingSocket extends FakeSocket {
|
||||||
|
override connect(path: string): void {
|
||||||
|
this.connectedPaths.push(path);
|
||||||
|
// Never emits 'connect', 'error', or 'close' on its own: models a named
|
||||||
|
// pipe dial that stalls indefinitely.
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
const wait = (ms = 0) => new Promise((resolve) => setTimeout(resolve, ms));
|
||||||
|
|
||||||
test('getMpvReconnectDelay follows existing reconnect ramp', () => {
|
test('getMpvReconnectDelay follows existing reconnect ramp', () => {
|
||||||
assert.equal(getMpvReconnectDelay(0, true), 1000);
|
assert.equal(getMpvReconnectDelay(0, true), 1000);
|
||||||
@@ -232,6 +240,75 @@ test('MpvSocketTransport.shutdown clears socket and lifecycle flags', async () =
|
|||||||
assert.deepEqual(events, []);
|
assert.deepEqual(events, []);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('MpvSocketTransport aborts a hung connect after the timeout and allows a fresh dial', async () => {
|
||||||
|
const events: string[] = [];
|
||||||
|
const errors: Error[] = [];
|
||||||
|
const sockets: HangingSocket[] = [];
|
||||||
|
const transport = new MpvSocketTransport({
|
||||||
|
socketPath: '/tmp/mpv.sock',
|
||||||
|
connectTimeoutMs: 5,
|
||||||
|
onConnect: () => {
|
||||||
|
events.push('connect');
|
||||||
|
},
|
||||||
|
onData: () => {},
|
||||||
|
onError: (error) => {
|
||||||
|
events.push('error');
|
||||||
|
errors.push(error);
|
||||||
|
},
|
||||||
|
onClose: () => {
|
||||||
|
events.push('close');
|
||||||
|
},
|
||||||
|
socketFactory: () => {
|
||||||
|
const socket = new HangingSocket();
|
||||||
|
sockets.push(socket);
|
||||||
|
return socket as unknown as net.Socket;
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
transport.connect();
|
||||||
|
assert.equal(transport.isConnecting, true);
|
||||||
|
|
||||||
|
await wait(20);
|
||||||
|
|
||||||
|
assert.deepEqual(events, ['error', 'close']);
|
||||||
|
assert.match(errors[0]!.message, /connect timed out/);
|
||||||
|
assert.equal(sockets[0]!.destroyed, true);
|
||||||
|
assert.equal(transport.isConnecting, false);
|
||||||
|
assert.equal(transport.isConnected, false);
|
||||||
|
|
||||||
|
transport.connect();
|
||||||
|
assert.equal(transport.isConnecting, true);
|
||||||
|
assert.equal(sockets.length, 2);
|
||||||
|
assert.equal(sockets[1]!.connectedPaths.at(0), '/tmp/mpv.sock');
|
||||||
|
|
||||||
|
transport.shutdown();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('MpvSocketTransport does not fire the connect timeout after a successful connect', async () => {
|
||||||
|
const events: string[] = [];
|
||||||
|
const transport = new MpvSocketTransport({
|
||||||
|
socketPath: '/tmp/mpv.sock',
|
||||||
|
connectTimeoutMs: 5,
|
||||||
|
onConnect: () => {
|
||||||
|
events.push('connect');
|
||||||
|
},
|
||||||
|
onData: () => {},
|
||||||
|
onError: () => {
|
||||||
|
events.push('error');
|
||||||
|
},
|
||||||
|
onClose: () => {
|
||||||
|
events.push('close');
|
||||||
|
},
|
||||||
|
socketFactory: () => new FakeSocket() as unknown as net.Socket,
|
||||||
|
});
|
||||||
|
|
||||||
|
transport.connect();
|
||||||
|
await wait(20);
|
||||||
|
|
||||||
|
assert.deepEqual(events, ['connect']);
|
||||||
|
assert.equal(transport.isConnected, true);
|
||||||
|
});
|
||||||
|
|
||||||
test('MpvSocketTransport ignores stale socket events after shutdown and reconnect', async () => {
|
test('MpvSocketTransport ignores stale socket events after shutdown and reconnect', async () => {
|
||||||
const events: string[] = [];
|
const events: string[] = [];
|
||||||
const sockets: ManualCloseSocket[] = [];
|
const sockets: ManualCloseSocket[] = [];
|
||||||
|
|||||||
@@ -62,6 +62,8 @@ interface MpvSocketTransportEvents {
|
|||||||
onClose: () => void;
|
onClose: () => void;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export const MPV_CONNECT_TIMEOUT_MS = 5000;
|
||||||
|
|
||||||
export interface MpvSocketTransportOptions {
|
export interface MpvSocketTransportOptions {
|
||||||
socketPath: string;
|
socketPath: string;
|
||||||
onConnect: () => void;
|
onConnect: () => void;
|
||||||
@@ -69,13 +71,16 @@ export interface MpvSocketTransportOptions {
|
|||||||
onError: (error: Error) => void;
|
onError: (error: Error) => void;
|
||||||
onClose: () => void;
|
onClose: () => void;
|
||||||
socketFactory?: () => net.Socket;
|
socketFactory?: () => net.Socket;
|
||||||
|
connectTimeoutMs?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
export class MpvSocketTransport {
|
export class MpvSocketTransport {
|
||||||
private socketPath: string;
|
private socketPath: string;
|
||||||
private readonly callbacks: MpvSocketTransportEvents;
|
private readonly callbacks: MpvSocketTransportEvents;
|
||||||
private readonly socketFactory: () => net.Socket;
|
private readonly socketFactory: () => net.Socket;
|
||||||
|
private readonly connectTimeoutMs: number;
|
||||||
private socketRef: net.Socket | null = null;
|
private socketRef: net.Socket | null = null;
|
||||||
|
private connectTimer: ReturnType<typeof setTimeout> | null = null;
|
||||||
public socket: net.Socket | null = null;
|
public socket: net.Socket | null = null;
|
||||||
public connected = false;
|
public connected = false;
|
||||||
public connecting = false;
|
public connecting = false;
|
||||||
@@ -83,6 +88,7 @@ export class MpvSocketTransport {
|
|||||||
constructor(options: MpvSocketTransportOptions) {
|
constructor(options: MpvSocketTransportOptions) {
|
||||||
this.socketPath = options.socketPath;
|
this.socketPath = options.socketPath;
|
||||||
this.socketFactory = options.socketFactory ?? (() => new net.Socket());
|
this.socketFactory = options.socketFactory ?? (() => new net.Socket());
|
||||||
|
this.connectTimeoutMs = options.connectTimeoutMs ?? MPV_CONNECT_TIMEOUT_MS;
|
||||||
this.callbacks = {
|
this.callbacks = {
|
||||||
onConnect: options.onConnect,
|
onConnect: options.onConnect,
|
||||||
onData: options.onData,
|
onData: options.onData,
|
||||||
@@ -91,6 +97,31 @@ export class MpvSocketTransport {
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
private clearConnectTimeout(): void {
|
||||||
|
if (this.connectTimer) {
|
||||||
|
clearTimeout(this.connectTimer);
|
||||||
|
this.connectTimer = null;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A named-pipe/socket dial that neither connects nor errors would otherwise
|
||||||
|
// latch `connecting` forever and silently block every future connect().
|
||||||
|
private armConnectTimeout(socket: net.Socket): void {
|
||||||
|
this.clearConnectTimeout();
|
||||||
|
this.connectTimer = setTimeout(() => {
|
||||||
|
this.connectTimer = null;
|
||||||
|
if (this.socketRef !== socket || this.connected) return;
|
||||||
|
this.connecting = false;
|
||||||
|
this.callbacks.onError(
|
||||||
|
new Error(`MPV IPC connect timed out after ${this.connectTimeoutMs}ms: ${this.socketPath}`),
|
||||||
|
);
|
||||||
|
// Destroying the socket emits 'close', which drives the normal
|
||||||
|
// disconnect path (including reconnect scheduling) upstream.
|
||||||
|
socket.destroy();
|
||||||
|
}, this.connectTimeoutMs);
|
||||||
|
this.connectTimer.unref?.();
|
||||||
|
}
|
||||||
|
|
||||||
setSocketPath(socketPath: string): void {
|
setSocketPath(socketPath: string): void {
|
||||||
this.socketPath = socketPath;
|
this.socketPath = socketPath;
|
||||||
}
|
}
|
||||||
@@ -111,6 +142,7 @@ export class MpvSocketTransport {
|
|||||||
|
|
||||||
socket.on('connect', () => {
|
socket.on('connect', () => {
|
||||||
if (this.socketRef !== socket) return;
|
if (this.socketRef !== socket) return;
|
||||||
|
this.clearConnectTimeout();
|
||||||
this.connected = true;
|
this.connected = true;
|
||||||
this.connecting = false;
|
this.connecting = false;
|
||||||
this.callbacks.onConnect();
|
this.callbacks.onConnect();
|
||||||
@@ -123,6 +155,7 @@ export class MpvSocketTransport {
|
|||||||
|
|
||||||
socket.on('error', (error: Error) => {
|
socket.on('error', (error: Error) => {
|
||||||
if (this.socketRef !== socket) return;
|
if (this.socketRef !== socket) return;
|
||||||
|
this.clearConnectTimeout();
|
||||||
this.connected = false;
|
this.connected = false;
|
||||||
this.connecting = false;
|
this.connecting = false;
|
||||||
this.callbacks.onError(error);
|
this.callbacks.onError(error);
|
||||||
@@ -130,12 +163,14 @@ export class MpvSocketTransport {
|
|||||||
|
|
||||||
socket.on('close', () => {
|
socket.on('close', () => {
|
||||||
if (this.socketRef !== socket) return;
|
if (this.socketRef !== socket) return;
|
||||||
|
this.clearConnectTimeout();
|
||||||
this.connected = false;
|
this.connected = false;
|
||||||
this.connecting = false;
|
this.connecting = false;
|
||||||
this.callbacks.onClose();
|
this.callbacks.onClose();
|
||||||
});
|
});
|
||||||
|
|
||||||
socket.connect(this.socketPath);
|
socket.connect(this.socketPath);
|
||||||
|
this.armConnectTimeout(socket);
|
||||||
}
|
}
|
||||||
|
|
||||||
send(payload: MpvSocketMessagePayload): boolean {
|
send(payload: MpvSocketMessagePayload): boolean {
|
||||||
@@ -149,6 +184,7 @@ export class MpvSocketTransport {
|
|||||||
}
|
}
|
||||||
|
|
||||||
shutdown(): void {
|
shutdown(): void {
|
||||||
|
this.clearConnectTimeout();
|
||||||
const socket = this.socketRef;
|
const socket = this.socketRef;
|
||||||
this.socketRef = null;
|
this.socketRef = null;
|
||||||
this.socket = null;
|
this.socket = null;
|
||||||
|
|||||||
@@ -1,5 +1,6 @@
|
|||||||
import test from 'node:test';
|
import test from 'node:test';
|
||||||
import assert from 'node:assert/strict';
|
import assert from 'node:assert/strict';
|
||||||
|
import { EventEmitter } from 'node:events';
|
||||||
import {
|
import {
|
||||||
MpvIpcClient,
|
MpvIpcClient,
|
||||||
MpvIpcClientDeps,
|
MpvIpcClientDeps,
|
||||||
@@ -23,6 +24,18 @@ function makeDeps(overrides: Partial<MpvIpcClientProtocolDeps> = {}): MpvIpcClie
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const wait = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
|
||||||
|
|
||||||
|
async function waitFor(predicate: () => boolean, timeoutMs = 2000): Promise<void> {
|
||||||
|
const deadline = Date.now() + timeoutMs;
|
||||||
|
while (!predicate()) {
|
||||||
|
if (Date.now() >= deadline) {
|
||||||
|
throw new Error('Timed out waiting for MPV retry connection');
|
||||||
|
}
|
||||||
|
await wait(10);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
function captureWarnLogs(run: () => void): string[] {
|
function captureWarnLogs(run: () => void): string[] {
|
||||||
const originalWarn = console.warn;
|
const originalWarn = console.warn;
|
||||||
const originalLogLevel = process.env.SUBMINER_LOG_LEVEL;
|
const originalLogLevel = process.env.SUBMINER_LOG_LEVEL;
|
||||||
@@ -505,6 +518,17 @@ test('MpvIpcClient reconnect replays property subscriptions and initial state re
|
|||||||
(command as { command: unknown[] }).command[1] === 1 &&
|
(command as { command: unknown[] }).command[1] === 1 &&
|
||||||
(command as { command: unknown[] }).command[2] === 'sub-text',
|
(command as { command: unknown[] }).command[2] === 'sub-text',
|
||||||
);
|
);
|
||||||
|
const hasAssSubtitleSubscription = commands.some(
|
||||||
|
(command) =>
|
||||||
|
Array.isArray((command as { command: unknown[] }).command) &&
|
||||||
|
(command as { command: unknown[] }).command[0] === 'observe_property' &&
|
||||||
|
(command as { command: unknown[] }).command[2] === 'sub-text/ass',
|
||||||
|
);
|
||||||
|
const hasDeprecatedAssSubtitleProperty = commands.some(
|
||||||
|
(command) =>
|
||||||
|
Array.isArray((command as { command: unknown[] }).command) &&
|
||||||
|
(command as { command: unknown[] }).command.includes('sub-text-ass'),
|
||||||
|
);
|
||||||
const hasPathRequest = commands.some(
|
const hasPathRequest = commands.some(
|
||||||
(command) =>
|
(command) =>
|
||||||
Array.isArray((command as { command: unknown[] }).command) &&
|
Array.isArray((command as { command: unknown[] }).command) &&
|
||||||
@@ -514,6 +538,8 @@ test('MpvIpcClient reconnect replays property subscriptions and initial state re
|
|||||||
|
|
||||||
assert.equal(hasSecondaryVisibilityReset, true);
|
assert.equal(hasSecondaryVisibilityReset, true);
|
||||||
assert.equal(hasTrackSubscription, true);
|
assert.equal(hasTrackSubscription, true);
|
||||||
|
assert.equal(hasAssSubtitleSubscription, true);
|
||||||
|
assert.equal(hasDeprecatedAssSubtitleProperty, false);
|
||||||
assert.equal(hasPathRequest, true);
|
assert.equal(hasPathRequest, true);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -743,3 +769,117 @@ test('MpvIpcClient playNextSubtitle still auto-pauses at end while already playi
|
|||||||
assert.equal((client as any).pendingPauseAtSubEnd, true);
|
assert.equal((client as any).pendingPauseAtSubEnd, true);
|
||||||
assert.deepEqual(commands, [{ command: ['sub-seek', 1] }]);
|
assert.deepEqual(commands, [{ command: ['sub-seek', 1] }]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
class HangingTestSocket extends EventEmitter {
|
||||||
|
public connectedPaths: string[] = [];
|
||||||
|
public destroyed = false;
|
||||||
|
|
||||||
|
connect(path: string): void {
|
||||||
|
this.connectedPaths.push(path);
|
||||||
|
// Never resolves: models a stalled named-pipe dial.
|
||||||
|
}
|
||||||
|
|
||||||
|
write(): boolean {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
destroy(): void {
|
||||||
|
this.destroyed = true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
class RetryTestSocket extends EventEmitter {
|
||||||
|
public connectedPaths: string[] = [];
|
||||||
|
public destroyed = false;
|
||||||
|
|
||||||
|
constructor(private readonly shouldConnect: boolean) {
|
||||||
|
super();
|
||||||
|
}
|
||||||
|
|
||||||
|
connect(path: string): void {
|
||||||
|
this.connectedPaths.push(path);
|
||||||
|
if (this.shouldConnect) {
|
||||||
|
setTimeout(() => this.emit('connect'), 0);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
write(): boolean {
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
destroy(): void {
|
||||||
|
if (this.destroyed) return;
|
||||||
|
this.destroyed = true;
|
||||||
|
this.emit('close');
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
test('MpvIpcClient automatically retries the same socket path after a connect timeout', async () => {
|
||||||
|
const sockets: RetryTestSocket[] = [];
|
||||||
|
let reconnectTimer: ReturnType<typeof setTimeout> | null = null;
|
||||||
|
const originalLogLevel = process.env.SUBMINER_LOG_LEVEL;
|
||||||
|
const client = new MpvIpcClient(
|
||||||
|
'/tmp/mpv.sock',
|
||||||
|
makeDeps({
|
||||||
|
connectTimeoutMs: 5,
|
||||||
|
getReconnectTimer: () => reconnectTimer,
|
||||||
|
setReconnectTimer: (timer) => {
|
||||||
|
reconnectTimer = timer;
|
||||||
|
},
|
||||||
|
socketFactory: () => {
|
||||||
|
const socket = new RetryTestSocket(sockets.length > 0);
|
||||||
|
sockets.push(socket);
|
||||||
|
return socket as unknown as import('node:net').Socket;
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
|
||||||
|
process.env.SUBMINER_LOG_LEVEL = 'error';
|
||||||
|
try {
|
||||||
|
client.connect();
|
||||||
|
await waitFor(() => client.connected);
|
||||||
|
|
||||||
|
assert.equal(sockets.length, 2);
|
||||||
|
assert.equal(sockets[0]!.destroyed, true);
|
||||||
|
assert.equal(sockets[0]!.connectedPaths.at(0), '/tmp/mpv.sock');
|
||||||
|
assert.equal(sockets[1]!.connectedPaths.at(0), '/tmp/mpv.sock');
|
||||||
|
assert.equal(client.connected, true);
|
||||||
|
} finally {
|
||||||
|
if (originalLogLevel === undefined) {
|
||||||
|
delete process.env.SUBMINER_LOG_LEVEL;
|
||||||
|
} else {
|
||||||
|
process.env.SUBMINER_LOG_LEVEL = originalLogLevel;
|
||||||
|
}
|
||||||
|
if (reconnectTimer) clearTimeout(reconnectTimer);
|
||||||
|
(client as any).transport.shutdown();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test('MpvIpcClient.setSocketPath aborts an in-flight connect so the next dial targets the new path', () => {
|
||||||
|
const sockets: HangingTestSocket[] = [];
|
||||||
|
const client = new MpvIpcClient(
|
||||||
|
'/tmp/mpv-old.sock',
|
||||||
|
makeDeps({
|
||||||
|
socketFactory: () => {
|
||||||
|
const socket = new HangingTestSocket();
|
||||||
|
sockets.push(socket);
|
||||||
|
return socket as unknown as import('node:net').Socket;
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
|
||||||
|
client.connect();
|
||||||
|
assert.equal(sockets.length, 1);
|
||||||
|
assert.equal(sockets[0]!.connectedPaths.at(0), '/tmp/mpv-old.sock');
|
||||||
|
assert.equal((client as any).connecting, true);
|
||||||
|
|
||||||
|
client.setSocketPath('/tmp/mpv-new.sock');
|
||||||
|
assert.equal((client as any).connecting, false);
|
||||||
|
assert.equal(sockets[0]!.destroyed, true);
|
||||||
|
|
||||||
|
client.connect();
|
||||||
|
assert.equal(sockets.length, 2);
|
||||||
|
assert.equal(sockets[1]!.connectedPaths.at(0), '/tmp/mpv-new.sock');
|
||||||
|
|
||||||
|
(client as any).transport.shutdown();
|
||||||
|
});
|
||||||
|
|||||||
@@ -9,7 +9,11 @@ import {
|
|||||||
splitMpvMessagesFromBuffer,
|
splitMpvMessagesFromBuffer,
|
||||||
} from './mpv-protocol';
|
} from './mpv-protocol';
|
||||||
import { requestMpvInitialState, subscribeToMpvProperties } from './mpv-properties';
|
import { requestMpvInitialState, subscribeToMpvProperties } from './mpv-properties';
|
||||||
import { scheduleMpvReconnect, MpvSocketTransport } from './mpv-transport';
|
import {
|
||||||
|
scheduleMpvReconnect,
|
||||||
|
MpvSocketTransport,
|
||||||
|
MpvSocketTransportOptions,
|
||||||
|
} from './mpv-transport';
|
||||||
import { createLogger } from '../../logger';
|
import { createLogger } from '../../logger';
|
||||||
|
|
||||||
const logger = createLogger('main:mpv');
|
const logger = createLogger('main:mpv');
|
||||||
@@ -110,6 +114,8 @@ export interface MpvIpcClientProtocolDeps {
|
|||||||
shouldAutoLoadSecondarySubTrack?: (path: string) => boolean;
|
shouldAutoLoadSecondarySubTrack?: (path: string) => boolean;
|
||||||
shouldQuitOnMpvShutdown?: () => boolean;
|
shouldQuitOnMpvShutdown?: () => boolean;
|
||||||
requestAppQuit?: () => void;
|
requestAppQuit?: () => void;
|
||||||
|
socketFactory?: MpvSocketTransportOptions['socketFactory'];
|
||||||
|
connectTimeoutMs?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
export interface MpvIpcClientDeps extends MpvIpcClientProtocolDeps {}
|
export interface MpvIpcClientDeps extends MpvIpcClientProtocolDeps {}
|
||||||
@@ -125,6 +131,8 @@ export interface MpvIpcClientEventMap {
|
|||||||
'fullscreen-change': { fullscreen: boolean };
|
'fullscreen-change': { fullscreen: boolean };
|
||||||
'secondary-subtitle-change': { text: string };
|
'secondary-subtitle-change': { text: string };
|
||||||
'subtitle-track-change': { sid: number | null };
|
'subtitle-track-change': { sid: number | null };
|
||||||
|
'secondary-subtitle-track-change': { sid: number | null };
|
||||||
|
'secondary-subtitle-delay-change': { delay: number };
|
||||||
'subtitle-track-list-change': { trackList: unknown[] | null };
|
'subtitle-track-list-change': { trackList: unknown[] | null };
|
||||||
'media-path-change': { path: string };
|
'media-path-change': { path: string };
|
||||||
'media-title-change': { title: string | null };
|
'media-title-change': { title: string | null };
|
||||||
@@ -188,6 +196,8 @@ export class MpvIpcClient implements MpvClient {
|
|||||||
|
|
||||||
this.transport = new MpvSocketTransport({
|
this.transport = new MpvSocketTransport({
|
||||||
socketPath,
|
socketPath,
|
||||||
|
socketFactory: deps.socketFactory,
|
||||||
|
connectTimeoutMs: deps.connectTimeoutMs,
|
||||||
onConnect: () => {
|
onConnect: () => {
|
||||||
this.connected = true;
|
this.connected = true;
|
||||||
this.connecting = false;
|
this.connecting = false;
|
||||||
@@ -289,6 +299,14 @@ export class MpvIpcClient implements MpvClient {
|
|||||||
previousSocketPath: this.socketPath,
|
previousSocketPath: this.socketPath,
|
||||||
socketPath,
|
socketPath,
|
||||||
});
|
});
|
||||||
|
if (this.connecting && !this.connected) {
|
||||||
|
// Abort the in-flight dial to the old path; otherwise the connecting
|
||||||
|
// latch turns every later connect() into a no-op while we hang on a
|
||||||
|
// stale socket.
|
||||||
|
logger.debug('Aborting in-flight MPV IPC connect for socket path change.');
|
||||||
|
this.transport.shutdown();
|
||||||
|
this.connecting = false;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
this.socketPath = socketPath;
|
this.socketPath = socketPath;
|
||||||
this.transport.setSocketPath(socketPath);
|
this.transport.setSocketPath(socketPath);
|
||||||
@@ -422,6 +440,12 @@ export class MpvIpcClient implements MpvClient {
|
|||||||
emitSubtitleTrackChange: (payload) => {
|
emitSubtitleTrackChange: (payload) => {
|
||||||
this.emit('subtitle-track-change', payload);
|
this.emit('subtitle-track-change', payload);
|
||||||
},
|
},
|
||||||
|
emitSecondarySubtitleTrackChange: (payload) => {
|
||||||
|
this.emit('secondary-subtitle-track-change', payload);
|
||||||
|
},
|
||||||
|
emitSecondarySubtitleDelayChange: (payload) => {
|
||||||
|
this.emit('secondary-subtitle-delay-change', payload);
|
||||||
|
},
|
||||||
emitSubtitleTrackListChange: (payload) => {
|
emitSubtitleTrackListChange: (payload) => {
|
||||||
this.emit('subtitle-track-list-change', payload);
|
this.emit('subtitle-track-list-change', payload);
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -0,0 +1,21 @@
|
|||||||
|
import assert from 'node:assert/strict';
|
||||||
|
import test from 'node:test';
|
||||||
|
|
||||||
|
import { applyOverlayClickThrough } from './overlay-click-through';
|
||||||
|
|
||||||
|
test('applyOverlayClickThrough requests forwarding only off Windows', () => {
|
||||||
|
const calls: Array<{ ignore: boolean; forward: boolean }> = [];
|
||||||
|
const window = {
|
||||||
|
setIgnoreMouseEvents: (ignore: boolean, options?: { forward?: boolean }) => {
|
||||||
|
calls.push({ ignore, forward: options?.forward === true });
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
applyOverlayClickThrough(window, true);
|
||||||
|
applyOverlayClickThrough(window, false);
|
||||||
|
|
||||||
|
assert.deepEqual(calls, [
|
||||||
|
{ ignore: true, forward: false },
|
||||||
|
{ ignore: true, forward: true },
|
||||||
|
]);
|
||||||
|
});
|
||||||
@@ -0,0 +1,27 @@
|
|||||||
|
type ClickThroughWindow = {
|
||||||
|
setIgnoreMouseEvents: (ignore: boolean, options?: { forward?: boolean }) => void;
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Puts an overlay window into click-through mode. Forwarded mouse-move ({ forward: true }) is
|
||||||
|
* what lets renderer hover tracking wake a click-through overlay, but on Windows Electron
|
||||||
|
* implements it with a global WH_MOUSE_LL hook whose callback runs on the main-process message
|
||||||
|
* loop, so any main-thread stall delays mouse input system-wide (electron/electron#10183).
|
||||||
|
* Windows instead wakes the overlay via the main-process cursor poll
|
||||||
|
* (tickWindowsOverlayPointerInteraction), so no forwarding is requested there. macOS still
|
||||||
|
* needs forwarding for renderer hover tracking; Linux ignores the flag entirely
|
||||||
|
* (electron/electron#16777).
|
||||||
|
*
|
||||||
|
* Pass isWindowsPlatform when the caller already carries a platform flag (tests simulate
|
||||||
|
* platforms through it); otherwise the real process.platform decides.
|
||||||
|
*/
|
||||||
|
export function applyOverlayClickThrough(
|
||||||
|
window: ClickThroughWindow,
|
||||||
|
isWindowsPlatform?: boolean,
|
||||||
|
): void {
|
||||||
|
if (isWindowsPlatform ?? process.platform === 'win32') {
|
||||||
|
window.setIgnoreMouseEvents(true);
|
||||||
|
} else {
|
||||||
|
window.setIgnoreMouseEvents(true, { forward: true });
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -848,7 +848,7 @@ test('Windows visible overlay stays click-through and binds to mpv while tracked
|
|||||||
} as never);
|
} as never);
|
||||||
|
|
||||||
assert.ok(calls.includes('opacity:0'));
|
assert.ok(calls.includes('opacity:0'));
|
||||||
assert.ok(calls.includes('mouse-ignore:true:forward'));
|
assert.ok(calls.includes('mouse-ignore:true:plain'));
|
||||||
assert.ok(calls.includes('show-inactive'));
|
assert.ok(calls.includes('show-inactive'));
|
||||||
assert.ok(calls.includes('sync-windows-z-order'));
|
assert.ok(calls.includes('sync-windows-z-order'));
|
||||||
assert.ok(!calls.includes('move-top'));
|
assert.ok(!calls.includes('move-top'));
|
||||||
@@ -1060,7 +1060,7 @@ test('tracked Windows overlay refresh rebinds while already visible', () => {
|
|||||||
isWindowsPlatform: true,
|
isWindowsPlatform: true,
|
||||||
} as never);
|
} as never);
|
||||||
|
|
||||||
assert.ok(calls.includes('mouse-ignore:true:forward'));
|
assert.ok(calls.includes('mouse-ignore:true:plain'));
|
||||||
assert.ok(calls.includes('sync-windows-z-order'));
|
assert.ok(calls.includes('sync-windows-z-order'));
|
||||||
assert.ok(!calls.includes('move-top'));
|
assert.ok(!calls.includes('move-top'));
|
||||||
assert.ok(!calls.includes('show'));
|
assert.ok(!calls.includes('show'));
|
||||||
@@ -1134,7 +1134,7 @@ test('forced passthrough still reapplies while visible on Windows', () => {
|
|||||||
forceMousePassthrough: true,
|
forceMousePassthrough: true,
|
||||||
} as never);
|
} as never);
|
||||||
|
|
||||||
assert.ok(calls.includes('mouse-ignore:true:forward'));
|
assert.ok(calls.includes('mouse-ignore:true:plain'));
|
||||||
assert.ok(!calls.includes('always-on-top:false'));
|
assert.ok(!calls.includes('always-on-top:false'));
|
||||||
assert.ok(!calls.includes('move-top'));
|
assert.ok(!calls.includes('move-top'));
|
||||||
assert.ok(calls.includes('sync-windows-z-order'));
|
assert.ok(calls.includes('sync-windows-z-order'));
|
||||||
@@ -1339,7 +1339,7 @@ test('tracked Windows overlay rebinds without hiding when tracker focus changes'
|
|||||||
|
|
||||||
assert.ok(!calls.includes('always-on-top:false'));
|
assert.ok(!calls.includes('always-on-top:false'));
|
||||||
assert.ok(!calls.includes('move-top'));
|
assert.ok(!calls.includes('move-top'));
|
||||||
assert.ok(calls.includes('mouse-ignore:true:forward'));
|
assert.ok(calls.includes('mouse-ignore:true:plain'));
|
||||||
assert.ok(calls.includes('sync-windows-z-order'));
|
assert.ok(calls.includes('sync-windows-z-order'));
|
||||||
assert.ok(!calls.includes('ensure-level'));
|
assert.ok(!calls.includes('ensure-level'));
|
||||||
assert.ok(!calls.includes('enforce-order'));
|
assert.ok(!calls.includes('enforce-order'));
|
||||||
@@ -1489,7 +1489,7 @@ test('tracked Windows overlay reshows click-through even if focus state is stale
|
|||||||
isWindowsPlatform: true,
|
isWindowsPlatform: true,
|
||||||
} as never);
|
} as never);
|
||||||
|
|
||||||
assert.ok(calls.includes('mouse-ignore:true:forward'));
|
assert.ok(calls.includes('mouse-ignore:true:plain'));
|
||||||
assert.ok(calls.includes('show-inactive'));
|
assert.ok(calls.includes('show-inactive'));
|
||||||
assert.ok(!calls.includes('show'));
|
assert.ok(!calls.includes('show'));
|
||||||
});
|
});
|
||||||
@@ -1532,7 +1532,7 @@ test('tracked Windows overlay binds above mpv even when tracker focus lags', ()
|
|||||||
|
|
||||||
assert.ok(!calls.includes('always-on-top:false'));
|
assert.ok(!calls.includes('always-on-top:false'));
|
||||||
assert.ok(!calls.includes('move-top'));
|
assert.ok(!calls.includes('move-top'));
|
||||||
assert.ok(calls.includes('mouse-ignore:true:forward'));
|
assert.ok(calls.includes('mouse-ignore:true:plain'));
|
||||||
assert.ok(calls.includes('sync-windows-z-order'));
|
assert.ok(calls.includes('sync-windows-z-order'));
|
||||||
assert.ok(!calls.includes('ensure-level'));
|
assert.ok(!calls.includes('ensure-level'));
|
||||||
});
|
});
|
||||||
@@ -2193,7 +2193,7 @@ test('Windows preserves visible overlay and rebinds to mpv while tracker transie
|
|||||||
assert.ok(!calls.includes('show'));
|
assert.ok(!calls.includes('show'));
|
||||||
assert.ok(!calls.includes('always-on-top:false'));
|
assert.ok(!calls.includes('always-on-top:false'));
|
||||||
assert.ok(!calls.includes('move-top'));
|
assert.ok(!calls.includes('move-top'));
|
||||||
assert.ok(calls.includes('mouse-ignore:true:forward'));
|
assert.ok(calls.includes('mouse-ignore:true:plain'));
|
||||||
assert.ok(calls.includes('sync-windows-z-order'));
|
assert.ok(calls.includes('sync-windows-z-order'));
|
||||||
assert.ok(!calls.includes('ensure-level'));
|
assert.ok(!calls.includes('ensure-level'));
|
||||||
assert.ok(calls.includes('sync-shortcuts'));
|
assert.ok(calls.includes('sync-shortcuts'));
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
import type { BrowserWindow } from 'electron';
|
import type { BrowserWindow } from 'electron';
|
||||||
import { BaseWindowTracker } from '../../window-trackers';
|
import { BaseWindowTracker } from '../../window-trackers';
|
||||||
import { WindowGeometry } from '../../types';
|
import { WindowGeometry } from '../../types';
|
||||||
|
import { applyOverlayClickThrough } from './overlay-click-through';
|
||||||
import { OVERLAY_WINDOW_CONTENT_READY_FLAG } from './overlay-window-flags';
|
import { OVERLAY_WINDOW_CONTENT_READY_FLAG } from './overlay-window-flags';
|
||||||
|
|
||||||
const WINDOWS_OVERLAY_REVEAL_DELAY_MS = 48;
|
const WINDOWS_OVERLAY_REVEAL_DELAY_MS = 48;
|
||||||
@@ -117,7 +118,7 @@ export function updateVisibleOverlayVisibility(args: {
|
|||||||
clearPendingWindowsOverlayReveal(mainWindow);
|
clearPendingWindowsOverlayReveal(mainWindow);
|
||||||
setOverlayWindowOpacity(mainWindow, 0);
|
setOverlayWindowOpacity(mainWindow, 0);
|
||||||
}
|
}
|
||||||
mainWindow.setIgnoreMouseEvents(true, { forward: true });
|
applyOverlayClickThrough(mainWindow, args.isWindowsPlatform);
|
||||||
releaseOverlayWindowLevel(mainWindow);
|
releaseOverlayWindowLevel(mainWindow);
|
||||||
mainWindow.hide();
|
mainWindow.hide();
|
||||||
args.syncOverlayShortcuts();
|
args.syncOverlayShortcuts();
|
||||||
@@ -215,7 +216,7 @@ export function updateVisibleOverlayVisibility(args: {
|
|||||||
shouldPreserveWindowsOverlayDuringFocusHandoff ||
|
shouldPreserveWindowsOverlayDuringFocusHandoff ||
|
||||||
(hasWindowsForegroundProcessSignal && windowsForegroundProcessName === 'mpv');
|
(hasWindowsForegroundProcessSignal && windowsForegroundProcessName === 'mpv');
|
||||||
if (shouldIgnoreMouseEvents) {
|
if (shouldIgnoreMouseEvents) {
|
||||||
mainWindow.setIgnoreMouseEvents(true, { forward: true });
|
applyOverlayClickThrough(mainWindow, args.isWindowsPlatform);
|
||||||
} else {
|
} else {
|
||||||
mainWindow.setIgnoreMouseEvents(false);
|
mainWindow.setIgnoreMouseEvents(false);
|
||||||
}
|
}
|
||||||
@@ -263,7 +264,7 @@ export function updateVisibleOverlayVisibility(args: {
|
|||||||
if (hasNonNativeInputRegion) {
|
if (hasNonNativeInputRegion) {
|
||||||
mainWindow.setIgnoreMouseEvents(false);
|
mainWindow.setIgnoreMouseEvents(false);
|
||||||
} else {
|
} else {
|
||||||
mainWindow.setIgnoreMouseEvents(true, { forward: true });
|
applyOverlayClickThrough(mainWindow, args.isWindowsPlatform);
|
||||||
}
|
}
|
||||||
if (args.isWindowsPlatform) {
|
if (args.isWindowsPlatform) {
|
||||||
scheduleWindowsOverlayReveal(
|
scheduleWindowsOverlayReveal(
|
||||||
@@ -424,7 +425,7 @@ export function updateVisibleOverlayVisibility(args: {
|
|||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
args.setTrackerNotReadyWarningShown(false);
|
args.setTrackerNotReadyWarningShown(false);
|
||||||
mainWindow.setIgnoreMouseEvents(true, { forward: true });
|
applyOverlayClickThrough(mainWindow, args.isWindowsPlatform);
|
||||||
releaseOverlayWindowLevel(mainWindow);
|
releaseOverlayWindowLevel(mainWindow);
|
||||||
mainWindow.hide();
|
mainWindow.hide();
|
||||||
args.syncOverlayShortcuts();
|
args.syncOverlayShortcuts();
|
||||||
|
|||||||
@@ -15,6 +15,32 @@ test('overlay window config explicitly disables renderer sandbox for preload com
|
|||||||
assert.equal(options.webPreferences?.backgroundThrottling, false);
|
assert.equal(options.webPreferences?.backgroundThrottling, false);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('macOS modal overlay uses a fullscreen auxiliary panel without changing the passive overlay', () => {
|
||||||
|
const visibleOptions = buildOverlayWindowOptions('visible', {
|
||||||
|
isDev: false,
|
||||||
|
platform: 'darwin',
|
||||||
|
yomitanSession: null,
|
||||||
|
});
|
||||||
|
const modalOptions = buildOverlayWindowOptions('modal', {
|
||||||
|
isDev: false,
|
||||||
|
platform: 'darwin',
|
||||||
|
yomitanSession: null,
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(visibleOptions.type, undefined);
|
||||||
|
assert.equal(modalOptions.type, 'panel');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('non-macOS modal overlay remains a regular window', () => {
|
||||||
|
const options = buildOverlayWindowOptions('modal', {
|
||||||
|
isDev: false,
|
||||||
|
platform: 'linux',
|
||||||
|
yomitanSession: null,
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(options.type, undefined);
|
||||||
|
});
|
||||||
|
|
||||||
test('Linux visible overlay window allows compositor resize for mpv-sized placement', () => {
|
test('Linux visible overlay window allows compositor resize for mpv-sized placement', () => {
|
||||||
const originalPlatformDescriptor = Object.getOwnPropertyDescriptor(process, 'platform');
|
const originalPlatformDescriptor = Object.getOwnPropertyDescriptor(process, 'platform');
|
||||||
|
|
||||||
|
|||||||
@@ -1 +1,2 @@
|
|||||||
export const OVERLAY_WINDOW_CONTENT_READY_FLAG = '__subminerOverlayContentReady';
|
export const OVERLAY_WINDOW_CONTENT_READY_FLAG = '__subminerOverlayContentReady';
|
||||||
|
export const OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG = '__subminerOverlayDocumentLoaded';
|
||||||
|
|||||||
@@ -12,15 +12,17 @@ export function buildOverlayWindowOptions(
|
|||||||
options: {
|
options: {
|
||||||
isDev: boolean;
|
isDev: boolean;
|
||||||
linuxX11FullscreenOverlay?: boolean;
|
linuxX11FullscreenOverlay?: boolean;
|
||||||
|
platform?: NodeJS.Platform;
|
||||||
yomitanSession?: Session | null;
|
yomitanSession?: Session | null;
|
||||||
},
|
},
|
||||||
): BrowserWindowConstructorOptions {
|
): BrowserWindowConstructorOptions {
|
||||||
const showNativeDebugFrame = process.platform === 'win32' && options.isDev;
|
const platform = options.platform ?? process.platform;
|
||||||
const isLinuxVisibleOverlay = process.platform === 'linux' && kind === 'visible';
|
const showNativeDebugFrame = platform === 'win32' && options.isDev;
|
||||||
|
const isLinuxVisibleOverlay = platform === 'linux' && kind === 'visible';
|
||||||
const isLinuxFullscreenOverlay =
|
const isLinuxFullscreenOverlay =
|
||||||
isLinuxVisibleOverlay && options.linuxX11FullscreenOverlay === true;
|
isLinuxVisibleOverlay && options.linuxX11FullscreenOverlay === true;
|
||||||
const shouldStartAlwaysOnTop =
|
const shouldStartAlwaysOnTop =
|
||||||
!(process.platform === 'win32' && kind === 'visible') &&
|
!(platform === 'win32' && kind === 'visible') &&
|
||||||
(!isLinuxVisibleOverlay || isLinuxFullscreenOverlay);
|
(!isLinuxVisibleOverlay || isLinuxFullscreenOverlay);
|
||||||
const shouldAllowCompositorResize = isLinuxVisibleOverlay && !isLinuxFullscreenOverlay;
|
const shouldAllowCompositorResize = isLinuxVisibleOverlay && !isLinuxFullscreenOverlay;
|
||||||
|
|
||||||
@@ -41,7 +43,10 @@ export function buildOverlayWindowOptions(
|
|||||||
hasShadow: false,
|
hasShadow: false,
|
||||||
focusable: !isLinuxFullscreenOverlay,
|
focusable: !isLinuxFullscreenOverlay,
|
||||||
acceptFirstMouse: true,
|
acceptFirstMouse: true,
|
||||||
...(process.platform === 'win32' ? { thickFrame: showNativeDebugFrame } : {}),
|
// A macOS panel is a fullscreen auxiliary window, so modal surfaces stay on the
|
||||||
|
// active mpv Space instead of opening on SubMiner's last regular desktop.
|
||||||
|
...(platform === 'darwin' && kind === 'modal' ? { type: 'panel' as const } : {}),
|
||||||
|
...(platform === 'win32' ? { thickFrame: showNativeDebugFrame } : {}),
|
||||||
webPreferences: {
|
webPreferences: {
|
||||||
preload: path.join(__dirname, '..', '..', 'preload.js'),
|
preload: path.join(__dirname, '..', '..', 'preload.js'),
|
||||||
contextIsolation: true,
|
contextIsolation: true,
|
||||||
|
|||||||
@@ -16,7 +16,10 @@ import {
|
|||||||
} from './hyprland-window-placement';
|
} from './hyprland-window-placement';
|
||||||
import { buildOverlayWindowOptions, OVERLAY_WINDOW_TITLES } from './overlay-window-options';
|
import { buildOverlayWindowOptions, OVERLAY_WINDOW_TITLES } from './overlay-window-options';
|
||||||
import { normalizeOverlayWindowBoundsForPlatform } from './overlay-window-bounds';
|
import { normalizeOverlayWindowBoundsForPlatform } from './overlay-window-bounds';
|
||||||
import { OVERLAY_WINDOW_CONTENT_READY_FLAG } from './overlay-window-flags';
|
import {
|
||||||
|
OVERLAY_WINDOW_CONTENT_READY_FLAG,
|
||||||
|
OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG,
|
||||||
|
} from './overlay-window-flags';
|
||||||
export { OVERLAY_WINDOW_CONTENT_READY_FLAG } from './overlay-window-flags';
|
export { OVERLAY_WINDOW_CONTENT_READY_FLAG } from './overlay-window-flags';
|
||||||
|
|
||||||
const logger = createLogger('main:overlay-window');
|
const logger = createLogger('main:overlay-window');
|
||||||
@@ -133,6 +136,9 @@ export function createOverlayWindow(
|
|||||||
(window as BrowserWindow & { [OVERLAY_WINDOW_CONTENT_READY_FLAG]?: boolean })[
|
(window as BrowserWindow & { [OVERLAY_WINDOW_CONTENT_READY_FLAG]?: boolean })[
|
||||||
OVERLAY_WINDOW_CONTENT_READY_FLAG
|
OVERLAY_WINDOW_CONTENT_READY_FLAG
|
||||||
] = false;
|
] = false;
|
||||||
|
(window as BrowserWindow & { [OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG]?: boolean })[
|
||||||
|
OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG
|
||||||
|
] = false;
|
||||||
|
|
||||||
if (!(process.platform === 'win32' && kind === 'visible')) {
|
if (!(process.platform === 'win32' && kind === 'visible')) {
|
||||||
options.ensureOverlayWindowLevel(window);
|
options.ensureOverlayWindowLevel(window);
|
||||||
@@ -144,11 +150,20 @@ export function createOverlayWindow(
|
|||||||
});
|
});
|
||||||
|
|
||||||
window.webContents.on('did-finish-load', () => {
|
window.webContents.on('did-finish-load', () => {
|
||||||
|
(window as BrowserWindow & { [OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG]?: boolean })[
|
||||||
|
OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG
|
||||||
|
] = true;
|
||||||
window.setTitle(OVERLAY_WINDOW_TITLES[kind]);
|
window.setTitle(OVERLAY_WINDOW_TITLES[kind]);
|
||||||
options.onRuntimeOptionsChanged();
|
options.onRuntimeOptionsChanged();
|
||||||
options.onWindowDidFinishLoad?.();
|
options.onWindowDidFinishLoad?.();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
window.webContents.on('did-start-loading', () => {
|
||||||
|
(window as BrowserWindow & { [OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG]?: boolean })[
|
||||||
|
OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG
|
||||||
|
] = false;
|
||||||
|
});
|
||||||
|
|
||||||
window.webContents.on('page-title-updated', (event) => {
|
window.webContents.on('page-title-updated', (event) => {
|
||||||
event.preventDefault();
|
event.preventDefault();
|
||||||
window.setTitle(OVERLAY_WINDOW_TITLES[kind]);
|
window.setTitle(OVERLAY_WINDOW_TITLES[kind]);
|
||||||
|
|||||||
@@ -57,7 +57,9 @@ export function shouldHideStatsWindowForInput(input: Electron.Input, toggleKey:
|
|||||||
export function buildStatsWindowOptions(options: {
|
export function buildStatsWindowOptions(options: {
|
||||||
preloadPath: string;
|
preloadPath: string;
|
||||||
bounds?: WindowGeometry | null;
|
bounds?: WindowGeometry | null;
|
||||||
|
platform?: NodeJS.Platform;
|
||||||
}): BrowserWindowConstructorOptions {
|
}): BrowserWindowConstructorOptions {
|
||||||
|
const platform = options.platform ?? process.platform;
|
||||||
return {
|
return {
|
||||||
title: STATS_WINDOW_TITLE,
|
title: STATS_WINDOW_TITLE,
|
||||||
x: options.bounds?.x,
|
x: options.bounds?.x,
|
||||||
@@ -73,6 +75,9 @@ export function buildStatsWindowOptions(options: {
|
|||||||
focusable: true,
|
focusable: true,
|
||||||
acceptFirstMouse: true,
|
acceptFirstMouse: true,
|
||||||
fullscreenable: false,
|
fullscreenable: false,
|
||||||
|
// Panels join fullscreen Spaces on macOS without moving the user back to the
|
||||||
|
// desktop where SubMiner last owned a regular application window.
|
||||||
|
...(platform === 'darwin' ? { type: 'panel' as const } : {}),
|
||||||
backgroundColor: '#24273a',
|
backgroundColor: '#24273a',
|
||||||
show: false,
|
show: false,
|
||||||
webPreferences: {
|
webPreferences: {
|
||||||
@@ -84,6 +89,12 @@ export function buildStatsWindowOptions(options: {
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export function shouldPresentStatsWindowAfterLoad(
|
||||||
|
platform: NodeJS.Platform = process.platform,
|
||||||
|
): boolean {
|
||||||
|
return platform === 'darwin';
|
||||||
|
}
|
||||||
|
|
||||||
export function resolveStatsWindowOuterBoundsForContent(
|
export function resolveStatsWindowOuterBoundsForContent(
|
||||||
window: StatsWindowBoundsController,
|
window: StatsWindowBoundsController,
|
||||||
target: WindowGeometry,
|
target: WindowGeometry,
|
||||||
|
|||||||
@@ -12,6 +12,7 @@ import {
|
|||||||
scheduleStatsWindowPostShowReconciles,
|
scheduleStatsWindowPostShowReconciles,
|
||||||
showStatsNativeConfirmDialog,
|
showStatsNativeConfirmDialog,
|
||||||
shouldHideStatsWindowForInput,
|
shouldHideStatsWindowForInput,
|
||||||
|
shouldPresentStatsWindowAfterLoad,
|
||||||
} from './stats-window-runtime';
|
} from './stats-window-runtime';
|
||||||
|
|
||||||
test('buildStatsWindowOptions uses tracked overlay bounds and preload-friendly web preferences', () => {
|
test('buildStatsWindowOptions uses tracked overlay bounds and preload-friendly web preferences', () => {
|
||||||
@@ -40,6 +41,30 @@ test('buildStatsWindowOptions uses tracked overlay bounds and preload-friendly w
|
|||||||
assert.equal(options.webPreferences?.sandbox, true);
|
assert.equal(options.webPreferences?.sandbox, true);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('buildStatsWindowOptions uses a fullscreen auxiliary panel on macOS', () => {
|
||||||
|
const options = buildStatsWindowOptions({
|
||||||
|
preloadPath: '/tmp/preload-stats.js',
|
||||||
|
platform: 'darwin',
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(options.type, 'panel');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('buildStatsWindowOptions remains a regular window off macOS', () => {
|
||||||
|
const options = buildStatsWindowOptions({
|
||||||
|
preloadPath: '/tmp/preload-stats.js',
|
||||||
|
platform: 'linux',
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(options.type, undefined);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('stats panels present after document load on macOS', () => {
|
||||||
|
assert.equal(shouldPresentStatsWindowAfterLoad('darwin'), true);
|
||||||
|
assert.equal(shouldPresentStatsWindowAfterLoad('linux'), false);
|
||||||
|
assert.equal(shouldPresentStatsWindowAfterLoad('win32'), false);
|
||||||
|
});
|
||||||
|
|
||||||
test('shouldHideStatsWindowForInput matches Escape and configured bare toggle key', () => {
|
test('shouldHideStatsWindowForInput matches Escape and configured bare toggle key', () => {
|
||||||
assert.equal(
|
assert.equal(
|
||||||
shouldHideStatsWindowForInput(
|
shouldHideStatsWindowForInput(
|
||||||
|
|||||||
@@ -13,6 +13,7 @@ import {
|
|||||||
scheduleStatsWindowPostShowReconciles,
|
scheduleStatsWindowPostShowReconciles,
|
||||||
showStatsNativeConfirmDialog,
|
showStatsNativeConfirmDialog,
|
||||||
shouldHideStatsWindowForInput,
|
shouldHideStatsWindowForInput,
|
||||||
|
shouldPresentStatsWindowAfterLoad,
|
||||||
STATS_WINDOW_TITLE,
|
STATS_WINDOW_TITLE,
|
||||||
} from './stats-window-runtime.js';
|
} from './stats-window-runtime.js';
|
||||||
import { ensureHyprlandWindowFloatingByTitle } from './hyprland-window-placement.js';
|
import { ensureHyprlandWindowFloatingByTitle } from './hyprland-window-placement.js';
|
||||||
@@ -209,10 +210,15 @@ export function toggleStatsOverlay(options: StatsWindowOptions): void {
|
|||||||
options.onVisibilityChanged?.(false);
|
options.onVisibilityChanged?.(false);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
statsWindow.once('ready-to-show', () => {
|
const showInitialStatsWindow = () => {
|
||||||
if (!statsWindow) return;
|
if (!statsWindow) return;
|
||||||
showStatsWindow(statsWindow, options);
|
showStatsWindow(statsWindow, options);
|
||||||
});
|
};
|
||||||
|
if (shouldPresentStatsWindowAfterLoad()) {
|
||||||
|
statsWindow.webContents.once('did-finish-load', showInitialStatsWindow);
|
||||||
|
} else {
|
||||||
|
statsWindow.once('ready-to-show', showInitialStatsWindow);
|
||||||
|
}
|
||||||
|
|
||||||
statsWindow.on('blur', () => {
|
statsWindow.on('blur', () => {
|
||||||
if (!statsWindow || statsWindow.isDestroyed() || !statsWindow.isVisible()) {
|
if (!statsWindow || statsWindow.isDestroyed() || !statsWindow.isVisible()) {
|
||||||
|
|||||||
@@ -15,7 +15,7 @@
|
|||||||
* layer that keeps the two views consistent by construction.
|
* layer that keeps the two views consistent by construction.
|
||||||
* 2. Otherwise (embedded track nobody parsed, a source whose timings mpv has shifted)
|
* 2. Otherwise (embedded track nobody parsed, a source whose timings mpv has shifted)
|
||||||
* fall back to timing alone. No authoring metadata is available live -- mpv delivers
|
* fall back to timing alone. No authoring metadata is available live -- mpv delivers
|
||||||
* `sub-text-ass` after `sub-start`/`sub-end`, so any ASS text read here belongs to the
|
* `sub-text/ass` after `sub-start`/`sub-end`, so any ASS text read here belongs to the
|
||||||
* previous event -- which puts this layer in the same position as the SRT path in
|
* previous event -- which puts this layer in the same position as the SRT path in
|
||||||
* `subtitle-cue-dedup`, and it uses that path's deliberately strict bounds.
|
* `subtitle-cue-dedup`, and it uses that path's deliberately strict bounds.
|
||||||
*/
|
*/
|
||||||
|
|||||||
@@ -24,10 +24,17 @@ import {
|
|||||||
shouldForwardStartupArgvViaAppControl,
|
shouldForwardStartupArgvViaAppControl,
|
||||||
applyBackgroundBootstrapCommandLineSwitches,
|
applyBackgroundBootstrapCommandLineSwitches,
|
||||||
applyEarlyLinuxCommandLineSwitches,
|
applyEarlyLinuxCommandLineSwitches,
|
||||||
|
resolveAppControlHandoffTimeoutMs,
|
||||||
resolveLinuxPasswordStoreValue,
|
resolveLinuxPasswordStoreValue,
|
||||||
spawnDetachedApp,
|
spawnDetachedApp,
|
||||||
} from './main-entry-runtime';
|
} from './main-entry-runtime';
|
||||||
|
|
||||||
|
test('app-control handoffs allow for macOS application activation latency', () => {
|
||||||
|
assert.equal(resolveAppControlHandoffTimeoutMs('darwin'), 3000);
|
||||||
|
assert.equal(resolveAppControlHandoffTimeoutMs('linux'), 500);
|
||||||
|
assert.equal(resolveAppControlHandoffTimeoutMs('win32'), 500);
|
||||||
|
});
|
||||||
|
|
||||||
test('detached app launch policy stays in the startup runtime utilities', () => {
|
test('detached app launch policy stays in the startup runtime utilities', () => {
|
||||||
const entrySource = fs.readFileSync(path.join(process.cwd(), 'src/main-entry.ts'), 'utf8');
|
const entrySource = fs.readFileSync(path.join(process.cwd(), 'src/main-entry.ts'), 'utf8');
|
||||||
const runtimeSource = fs.readFileSync(
|
const runtimeSource = fs.readFileSync(
|
||||||
|
|||||||
@@ -14,6 +14,8 @@ const TRANSPORTED_APP_ARGC_ENV = 'SUBMINER_APP_ARGC';
|
|||||||
const TRANSPORTED_APP_ARG_PREFIX = 'SUBMINER_APP_ARG_';
|
const TRANSPORTED_APP_ARG_PREFIX = 'SUBMINER_APP_ARG_';
|
||||||
const MAX_TRANSPORTED_APP_ARGS = 256;
|
const MAX_TRANSPORTED_APP_ARGS = 256;
|
||||||
const APP_NAME = 'SubMiner';
|
const APP_NAME = 'SubMiner';
|
||||||
|
const DEFAULT_APP_CONTROL_HANDOFF_TIMEOUT_MS = 500;
|
||||||
|
const MACOS_APP_CONTROL_HANDOFF_TIMEOUT_MS = 3000;
|
||||||
const MPV_LONG_OPTIONS_WITH_SEPARATE_VALUES = new Set([
|
const MPV_LONG_OPTIONS_WITH_SEPARATE_VALUES = new Set([
|
||||||
'--alang',
|
'--alang',
|
||||||
'--audio-file',
|
'--audio-file',
|
||||||
@@ -186,6 +188,14 @@ export function shouldForwardStartupArgvViaAppControl(
|
|||||||
return hasExplicitCommand(args);
|
return hasExplicitCommand(args);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export function resolveAppControlHandoffTimeoutMs(
|
||||||
|
platform: NodeJS.Platform = process.platform,
|
||||||
|
): number {
|
||||||
|
return platform === 'darwin'
|
||||||
|
? MACOS_APP_CONTROL_HANDOFF_TIMEOUT_MS
|
||||||
|
: DEFAULT_APP_CONTROL_HANDOFF_TIMEOUT_MS;
|
||||||
|
}
|
||||||
|
|
||||||
function readTransportedStartupArgs(env: NodeJS.ProcessEnv): string[] | null {
|
function readTransportedStartupArgs(env: NodeJS.ProcessEnv): string[] | null {
|
||||||
const rawCount = env[TRANSPORTED_APP_ARGC_ENV];
|
const rawCount = env[TRANSPORTED_APP_ARGC_ENV];
|
||||||
if (rawCount === undefined) {
|
if (rawCount === undefined) {
|
||||||
|
|||||||
+2
-1
@@ -9,6 +9,7 @@ import {
|
|||||||
normalizeLaunchMpvTargets,
|
normalizeLaunchMpvTargets,
|
||||||
normalizeStartupArgv,
|
normalizeStartupArgv,
|
||||||
applyEarlyLinuxCommandLineSwitches,
|
applyEarlyLinuxCommandLineSwitches,
|
||||||
|
resolveAppControlHandoffTimeoutMs,
|
||||||
sanitizeStartupEnv,
|
sanitizeStartupEnv,
|
||||||
sanitizeBackgroundEnv,
|
sanitizeBackgroundEnv,
|
||||||
sanitizeHelpEnv,
|
sanitizeHelpEnv,
|
||||||
@@ -214,7 +215,7 @@ async function forwardStartupArgvViaAppControlIfAvailable(): Promise<boolean> {
|
|||||||
|
|
||||||
const result = await sendAppControlCommand(process.argv, {
|
const result = await sendAppControlCommand(process.argv, {
|
||||||
configDir: userDataPath,
|
configDir: userDataPath,
|
||||||
timeoutMs: 500,
|
timeoutMs: resolveAppControlHandoffTimeoutMs(),
|
||||||
});
|
});
|
||||||
if (result.ok) {
|
if (result.ok) {
|
||||||
app.exit(0);
|
app.exit(0);
|
||||||
|
|||||||
+40
-2
@@ -331,6 +331,7 @@ import {
|
|||||||
acquireYoutubeSubtitleTrack,
|
acquireYoutubeSubtitleTrack,
|
||||||
acquireYoutubeSubtitleTracks,
|
acquireYoutubeSubtitleTracks,
|
||||||
} from './core/services/youtube/generate';
|
} from './core/services/youtube/generate';
|
||||||
|
import { applyOverlayClickThrough } from './core/services/overlay-click-through';
|
||||||
import { createYoutubeMediaCacheService } from './core/services/youtube/media-cache';
|
import { createYoutubeMediaCacheService } from './core/services/youtube/media-cache';
|
||||||
import { resolveYoutubePlaybackUrl } from './core/services/youtube/playback-resolve';
|
import { resolveYoutubePlaybackUrl } from './core/services/youtube/playback-resolve';
|
||||||
import { probeYoutubeTracks } from './core/services/youtube/track-probe';
|
import { probeYoutubeTracks } from './core/services/youtube/track-probe';
|
||||||
@@ -526,6 +527,7 @@ import {
|
|||||||
createRefreshSubtitlePrefetchFromActiveTrackHandler,
|
createRefreshSubtitlePrefetchFromActiveTrackHandler,
|
||||||
createResolveActiveSubtitleSidebarSourceHandler,
|
createResolveActiveSubtitleSidebarSourceHandler,
|
||||||
} from './main/runtime/subtitle-prefetch-runtime';
|
} from './main/runtime/subtitle-prefetch-runtime';
|
||||||
|
import { createSecondarySubtitleTrackController } from './main/runtime/secondary-subtitle-track';
|
||||||
import {
|
import {
|
||||||
createCreateAnilistSetupWindowHandler,
|
createCreateAnilistSetupWindowHandler,
|
||||||
createCreateConfigSettingsWindowHandler,
|
createCreateConfigSettingsWindowHandler,
|
||||||
@@ -1942,7 +1944,7 @@ const autoplaySubtitlePrimingRuntime = createAutoplaySubtitlePrimingRuntime({
|
|||||||
getLastObservedTimePos: () => lastObservedTimePos,
|
getLastObservedTimePos: () => lastObservedTimePos,
|
||||||
getVisibleOverlayVisible: () => overlayManager.getVisibleOverlayVisible(),
|
getVisibleOverlayVisible: () => overlayManager.getVisibleOverlayVisible(),
|
||||||
emitSecondarySubtitle: (text) => {
|
emitSecondarySubtitle: (text) => {
|
||||||
overlayManager.broadcastToOverlayWindows('secondary-subtitle:set', text);
|
secondarySubtitleTrackController.handleLiveText(text);
|
||||||
},
|
},
|
||||||
initSubtitlePrefetch: (sourcePath, currentTimePos, sourceKey) =>
|
initSubtitlePrefetch: (sourcePath, currentTimePos, sourceKey) =>
|
||||||
subtitlePrefetchInitController.initSubtitlePrefetch(sourcePath, currentTimePos, sourceKey),
|
subtitlePrefetchInitController.initSubtitlePrefetch(sourcePath, currentTimePos, sourceKey),
|
||||||
@@ -2000,6 +2002,24 @@ const resolveActiveSubtitleSidebarSourceHandler = createResolveActiveSubtitleSid
|
|||||||
logDebug: (message) => logger.debug(message),
|
logDebug: (message) => logger.debug(message),
|
||||||
});
|
});
|
||||||
|
|
||||||
|
const secondarySubtitleTrackController = createSecondarySubtitleTrackController({
|
||||||
|
getMpvClient: () => appState.mpvClient,
|
||||||
|
getCurrentTimePos: () => appState.mpvClient?.currentTimePos ?? lastObservedTimePos,
|
||||||
|
resolveSubtitleSource: (input) => resolveActiveSubtitleSidebarSourceHandler(input),
|
||||||
|
loadSubtitleSourceText,
|
||||||
|
parseSubtitleCues: (content, filename) => parseSubtitleCues(content, filename),
|
||||||
|
setCurrentSecondaryText: (text) => {
|
||||||
|
if (appState.mpvClient) {
|
||||||
|
appState.mpvClient.currentSecondarySubText = text;
|
||||||
|
}
|
||||||
|
},
|
||||||
|
broadcastSecondaryText: (text) => {
|
||||||
|
overlayManager.broadcastToOverlayWindows('secondary-subtitle:set', text);
|
||||||
|
},
|
||||||
|
logDebug: (message) => logger.debug(message),
|
||||||
|
logWarn: (message, error) => logger.warn(message, error),
|
||||||
|
});
|
||||||
|
|
||||||
const refreshSubtitlePrefetchFromActiveTrackHandler =
|
const refreshSubtitlePrefetchFromActiveTrackHandler =
|
||||||
createRefreshSubtitlePrefetchFromActiveTrackHandler({
|
createRefreshSubtitlePrefetchFromActiveTrackHandler({
|
||||||
getMpvClient: () => appState.mpvClient,
|
getMpvClient: () => appState.mpvClient,
|
||||||
@@ -4382,6 +4402,7 @@ const {
|
|||||||
onMpvConnected: () => {
|
onMpvConnected: () => {
|
||||||
maybeStartOverlayLoadingOsd();
|
maybeStartOverlayLoadingOsd();
|
||||||
flushQueuedMpvOsdNotifications();
|
flushQueuedMpvOsdNotifications();
|
||||||
|
secondarySubtitleTrackController.scheduleRefresh(0);
|
||||||
if (appState.sessionBindingsInitialized) {
|
if (appState.sessionBindingsInitialized) {
|
||||||
sendMpvCommandRuntime(appState.mpvClient, [
|
sendMpvCommandRuntime(appState.mpvClient, [
|
||||||
'script-message',
|
'script-message',
|
||||||
@@ -4400,6 +4421,9 @@ const {
|
|||||||
broadcastToOverlayWindows: (channel, payload) => {
|
broadcastToOverlayWindows: (channel, payload) => {
|
||||||
overlayManager.broadcastToOverlayWindows(channel, payload);
|
overlayManager.broadcastToOverlayWindows(channel, payload);
|
||||||
},
|
},
|
||||||
|
onSecondarySubtitleChange: (text) => {
|
||||||
|
secondarySubtitleTrackController.handleLiveText(text);
|
||||||
|
},
|
||||||
getImmediateSubtitlePayload: (text) => subtitleProcessingController.consumeCachedSubtitle(text),
|
getImmediateSubtitlePayload: (text) => subtitleProcessingController.consumeCachedSubtitle(text),
|
||||||
emitImmediateSubtitle: (payload) => {
|
emitImmediateSubtitle: (payload) => {
|
||||||
emitSubtitlePayload(payload);
|
emitSubtitlePayload(payload);
|
||||||
@@ -4433,6 +4457,7 @@ const {
|
|||||||
appState.activeParsedSubtitleMediaPath,
|
appState.activeParsedSubtitleMediaPath,
|
||||||
);
|
);
|
||||||
if ((normalizedPath || null) !== previousPath) {
|
if ((normalizedPath || null) !== previousPath) {
|
||||||
|
secondarySubtitleTrackController.reset();
|
||||||
const resetSubtitlePayload = { text: '', tokens: null };
|
const resetSubtitlePayload = { text: '', tokens: null };
|
||||||
const frequencyDictionary = configService.getConfig().subtitleStyle.frequencyDictionary;
|
const frequencyDictionary = configService.getConfig().subtitleStyle.frequencyDictionary;
|
||||||
const frequencyOptions = {
|
const frequencyOptions = {
|
||||||
@@ -4467,6 +4492,7 @@ const {
|
|||||||
void youtubeMediaCachePlaybackRuntime.handleMediaPathChange(path);
|
void youtubeMediaCachePlaybackRuntime.handleMediaPathChange(path);
|
||||||
if (path) {
|
if (path) {
|
||||||
ensureImmersionTrackerStarted();
|
ensureImmersionTrackerStarted();
|
||||||
|
secondarySubtitleTrackController.scheduleRefresh();
|
||||||
void subtitlePrefetchRuntime.refreshSubtitlePrefetchFromActiveTrack();
|
void subtitlePrefetchRuntime.refreshSubtitlePrefetchFromActiveTrack();
|
||||||
// Retry after a short delay because MPV can populate track-list after path.
|
// Retry after a short delay because MPV can populate track-list after path.
|
||||||
subtitlePrefetchRuntime.scheduleSubtitlePrefetchRefresh(500);
|
subtitlePrefetchRuntime.scheduleSubtitlePrefetchRefresh(500);
|
||||||
@@ -4521,6 +4547,7 @@ const {
|
|||||||
subtitlePrefetchService.onSeek(time);
|
subtitlePrefetchService.onSeek(time);
|
||||||
}
|
}
|
||||||
lastObservedTimePos = time;
|
lastObservedTimePos = time;
|
||||||
|
secondarySubtitleTrackController.handleTimePos(time);
|
||||||
},
|
},
|
||||||
onFullscreenChange: (fullscreen) => {
|
onFullscreenChange: (fullscreen) => {
|
||||||
cancelLinuxMpvFullscreenOverlayRefreshBurst = updateLinuxMpvFullscreenOverlayRefreshBurst(
|
cancelLinuxMpvFullscreenOverlayRefreshBurst = updateLinuxMpvFullscreenOverlayRefreshBurst(
|
||||||
@@ -4548,6 +4575,13 @@ const {
|
|||||||
autoplaySubtitlePrimingRuntime.scheduleSubtitlePrefetchRefresh();
|
autoplaySubtitlePrimingRuntime.scheduleSubtitlePrefetchRefresh();
|
||||||
youtubePrimarySubtitleNotificationRuntime.handleSubtitleTrackChange(sid);
|
youtubePrimarySubtitleNotificationRuntime.handleSubtitleTrackChange(sid);
|
||||||
},
|
},
|
||||||
|
onSecondarySubtitleTrackChange: () => {
|
||||||
|
secondarySubtitleTrackController.handleTrackChange();
|
||||||
|
secondarySubtitleTrackController.scheduleRefresh(0);
|
||||||
|
},
|
||||||
|
onSecondarySubtitleDelayChange: (delay) => {
|
||||||
|
secondarySubtitleTrackController.handleDelayChange(delay);
|
||||||
|
},
|
||||||
onSubtitleTrackListChange: (trackList) => {
|
onSubtitleTrackListChange: (trackList) => {
|
||||||
const diagnostics = buildSubtitleTrackDiagnostics(
|
const diagnostics = buildSubtitleTrackDiagnostics(
|
||||||
lastObservedPrimarySubtitleTrackId,
|
lastObservedPrimarySubtitleTrackId,
|
||||||
@@ -4561,6 +4595,7 @@ const {
|
|||||||
logger.info('[mpv-subtitles] subtitle track list updated', diagnostics);
|
logger.info('[mpv-subtitles] subtitle track list updated', diagnostics);
|
||||||
}
|
}
|
||||||
managedLocalSubtitleSelectionRuntime.handleSubtitleTrackListChange(trackList);
|
managedLocalSubtitleSelectionRuntime.handleSubtitleTrackListChange(trackList);
|
||||||
|
secondarySubtitleTrackController.scheduleRefresh(0);
|
||||||
autoplaySubtitlePrimingRuntime.scheduleSubtitlePrefetchRefresh();
|
autoplaySubtitlePrimingRuntime.scheduleSubtitlePrefetchRefresh();
|
||||||
youtubePrimarySubtitleNotificationRuntime.handleSubtitleTrackListChange(trackList);
|
youtubePrimarySubtitleNotificationRuntime.handleSubtitleTrackListChange(trackList);
|
||||||
},
|
},
|
||||||
@@ -5009,6 +5044,9 @@ function syncLinuxVisibleOverlayMpvFullscreenMode(fullscreen: boolean): void {
|
|||||||
|
|
||||||
function initializeOverlayRuntime(): void {
|
function initializeOverlayRuntime(): void {
|
||||||
initializeOverlayRuntimeHandler();
|
initializeOverlayRuntimeHandler();
|
||||||
|
if (!(appState.initialArgs && isHeadlessInitialCommand(appState.initialArgs))) {
|
||||||
|
overlayModalRuntime.primeModalWindow();
|
||||||
|
}
|
||||||
appState.ankiIntegration?.setRecordCardsMinedCallback(recordTrackedCardsMined);
|
appState.ankiIntegration?.setRecordCardsMinedCallback(recordTrackedCardsMined);
|
||||||
appState.ankiIntegration?.setKnownWordCacheUpdatedCallback(
|
appState.ankiIntegration?.setKnownWordCacheUpdatedCallback(
|
||||||
refreshCurrentSubtitleAfterKnownWordUpdate,
|
refreshCurrentSubtitleAfterKnownWordUpdate,
|
||||||
@@ -5466,7 +5504,7 @@ const { registerIpcRuntimeHandlers } = composeIpcRuntimeHandlers({
|
|||||||
senderWindow === modalWindow &&
|
senderWindow === modalWindow &&
|
||||||
!senderWindow.isDestroyed()
|
!senderWindow.isDestroyed()
|
||||||
) {
|
) {
|
||||||
senderWindow.setIgnoreMouseEvents(true, { forward: true });
|
applyOverlayClickThrough(senderWindow);
|
||||||
senderWindow.hide();
|
senderWindow.hide();
|
||||||
}
|
}
|
||||||
handleOverlayModalClosedHandler(modal);
|
handleOverlayModalClosedHandler(modal);
|
||||||
|
|||||||
@@ -16,6 +16,7 @@ type MockWindow = {
|
|||||||
loading: boolean;
|
loading: boolean;
|
||||||
url: string;
|
url: string;
|
||||||
contentReady: boolean;
|
contentReady: boolean;
|
||||||
|
documentLoaded: boolean;
|
||||||
loadCallbacks: Array<() => void>;
|
loadCallbacks: Array<() => void>;
|
||||||
readyToShowCallbacks: Array<() => void>;
|
readyToShowCallbacks: Array<() => void>;
|
||||||
};
|
};
|
||||||
@@ -31,6 +32,7 @@ function createMockWindow(): MockWindow & {
|
|||||||
getShowCount: () => number;
|
getShowCount: () => number;
|
||||||
getHideCount: () => number;
|
getHideCount: () => number;
|
||||||
show: () => void;
|
show: () => void;
|
||||||
|
showInactive: () => void;
|
||||||
hide: () => void;
|
hide: () => void;
|
||||||
destroy: () => void;
|
destroy: () => void;
|
||||||
focus: () => void;
|
focus: () => void;
|
||||||
@@ -61,6 +63,7 @@ function createMockWindow(): MockWindow & {
|
|||||||
loading: false,
|
loading: false,
|
||||||
url: 'file:///overlay/index.html?layer=modal',
|
url: 'file:///overlay/index.html?layer=modal',
|
||||||
contentReady: true,
|
contentReady: true,
|
||||||
|
documentLoaded: true,
|
||||||
loadCallbacks: [],
|
loadCallbacks: [],
|
||||||
readyToShowCallbacks: [],
|
readyToShowCallbacks: [],
|
||||||
};
|
};
|
||||||
@@ -84,6 +87,10 @@ function createMockWindow(): MockWindow & {
|
|||||||
state.visible = true;
|
state.visible = true;
|
||||||
state.showCount += 1;
|
state.showCount += 1;
|
||||||
},
|
},
|
||||||
|
showInactive: () => {
|
||||||
|
state.visible = true;
|
||||||
|
state.showCount += 1;
|
||||||
|
},
|
||||||
hide: () => {
|
hide: () => {
|
||||||
state.visible = false;
|
state.visible = false;
|
||||||
state.hideCount += 1;
|
state.hideCount += 1;
|
||||||
@@ -96,6 +103,10 @@ function createMockWindow(): MockWindow & {
|
|||||||
state.focused = true;
|
state.focused = true;
|
||||||
},
|
},
|
||||||
emitDidFinishLoad: () => {
|
emitDidFinishLoad: () => {
|
||||||
|
state.documentLoaded = true;
|
||||||
|
(
|
||||||
|
window as typeof window & { __subminerOverlayDocumentLoaded?: boolean }
|
||||||
|
).__subminerOverlayDocumentLoaded = true;
|
||||||
const callbacks = state.loadCallbacks.splice(0);
|
const callbacks = state.loadCallbacks.splice(0);
|
||||||
for (const callback of callbacks) {
|
for (const callback of callbacks) {
|
||||||
callback();
|
callback();
|
||||||
@@ -197,9 +208,22 @@ function createMockWindow(): MockWindow & {
|
|||||||
},
|
},
|
||||||
});
|
});
|
||||||
|
|
||||||
|
Object.defineProperty(window, 'documentLoaded', {
|
||||||
|
get: () => state.documentLoaded,
|
||||||
|
set: (value: boolean) => {
|
||||||
|
state.documentLoaded = value;
|
||||||
|
(
|
||||||
|
window as typeof window & { __subminerOverlayDocumentLoaded?: boolean }
|
||||||
|
).__subminerOverlayDocumentLoaded = value;
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
(
|
(
|
||||||
window as typeof window & { __subminerOverlayContentReady?: boolean }
|
window as typeof window & { __subminerOverlayContentReady?: boolean }
|
||||||
).__subminerOverlayContentReady = state.contentReady;
|
).__subminerOverlayContentReady = state.contentReady;
|
||||||
|
(
|
||||||
|
window as typeof window & { __subminerOverlayDocumentLoaded?: boolean }
|
||||||
|
).__subminerOverlayDocumentLoaded = state.documentLoaded;
|
||||||
|
|
||||||
return window;
|
return window;
|
||||||
}
|
}
|
||||||
@@ -259,6 +283,73 @@ test('sendToActiveOverlayWindow creates modal window lazily when absent', () =>
|
|||||||
assert.deepEqual(window.sent, [['jimaku:open']]);
|
assert.deepEqual(window.sent, [['jimaku:open']]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
for (const platform of ['darwin', 'win32'] as const) {
|
||||||
|
test(`primeModalWindow creates and warms a hidden modal on ${platform}`, () => {
|
||||||
|
const modalWindow = createMockWindow();
|
||||||
|
modalWindow.loading = true;
|
||||||
|
modalWindow.url = '';
|
||||||
|
modalWindow.contentReady = false;
|
||||||
|
modalWindow.documentLoaded = false;
|
||||||
|
let currentModal: ReturnType<typeof createMockWindow> | null = null;
|
||||||
|
let createCalls = 0;
|
||||||
|
const runtime = createOverlayModalRuntimeService(
|
||||||
|
{
|
||||||
|
getMainWindow: () => null,
|
||||||
|
getModalWindow: () => currentModal as never,
|
||||||
|
createModalWindow: () => {
|
||||||
|
createCalls += 1;
|
||||||
|
currentModal = modalWindow;
|
||||||
|
return modalWindow as never;
|
||||||
|
},
|
||||||
|
getModalGeometry: () => ({ x: 1, y: 2, width: 300, height: 200 }),
|
||||||
|
setModalWindowBounds: () => {},
|
||||||
|
},
|
||||||
|
{ platform },
|
||||||
|
);
|
||||||
|
|
||||||
|
assert.equal(runtime.primeModalWindow(), true);
|
||||||
|
assert.equal(createCalls, 1);
|
||||||
|
assert.equal(modalWindow.isVisible(), false);
|
||||||
|
|
||||||
|
modalWindow.loading = false;
|
||||||
|
modalWindow.url = 'file:///overlay/index.html?layer=modal';
|
||||||
|
modalWindow.emitDidFinishLoad();
|
||||||
|
modalWindow.emitReadyToShow();
|
||||||
|
modalWindow.contentReady = true;
|
||||||
|
|
||||||
|
assert.equal(
|
||||||
|
runtime.sendToActiveOverlayWindow('session-help:open', undefined, {
|
||||||
|
restoreOnModalClose: 'session-help',
|
||||||
|
preferModalWindow: true,
|
||||||
|
}),
|
||||||
|
true,
|
||||||
|
);
|
||||||
|
assert.equal(createCalls, 1);
|
||||||
|
assert.equal(modalWindow.isVisible(), true);
|
||||||
|
assert.deepEqual(modalWindow.sent, [['session-help:open']]);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
test('primeModalWindow leaves Linux modal creation lazy', () => {
|
||||||
|
let createCalls = 0;
|
||||||
|
const runtime = createOverlayModalRuntimeService(
|
||||||
|
{
|
||||||
|
getMainWindow: () => null,
|
||||||
|
getModalWindow: () => null,
|
||||||
|
createModalWindow: () => {
|
||||||
|
createCalls += 1;
|
||||||
|
return createMockWindow() as never;
|
||||||
|
},
|
||||||
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
|
setModalWindowBounds: () => {},
|
||||||
|
},
|
||||||
|
{ platform: 'linux' },
|
||||||
|
);
|
||||||
|
|
||||||
|
assert.equal(runtime.primeModalWindow(), false);
|
||||||
|
assert.equal(createCalls, 0);
|
||||||
|
});
|
||||||
|
|
||||||
test('sendToActiveOverlayWindow does not retain restore state when modal creation fails', () => {
|
test('sendToActiveOverlayWindow does not retain restore state when modal creation fails', () => {
|
||||||
const runtime = createOverlayModalRuntimeService({
|
const runtime = createOverlayModalRuntimeService({
|
||||||
getMainWindow: () => null,
|
getMainWindow: () => null,
|
||||||
@@ -301,7 +392,7 @@ test('sendToActiveOverlayWindow waits for blank modal URL before sending open co
|
|||||||
window.loading = false;
|
window.loading = false;
|
||||||
window.url = 'file:///overlay/index.html?layer=modal';
|
window.url = 'file:///overlay/index.html?layer=modal';
|
||||||
window.emitDidFinishLoad();
|
window.emitDidFinishLoad();
|
||||||
assert.deepEqual(window.sent, []);
|
assert.deepEqual(window.sent, [['runtime-options:open']]);
|
||||||
|
|
||||||
window.contentReady = true;
|
window.contentReady = true;
|
||||||
window.emitReadyToShow();
|
window.emitReadyToShow();
|
||||||
@@ -311,15 +402,18 @@ test('sendToActiveOverlayWindow waits for blank modal URL before sending open co
|
|||||||
assert.equal(window.getShowCount(), 1);
|
assert.equal(window.getShowCount(), 1);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('handleOverlayModalClosed hides modal window only after all pending modals close', () => {
|
test('handleOverlayModalClosed keeps the modal window warm after all pending modals close', () => {
|
||||||
const window = createMockWindow();
|
const window = createMockWindow();
|
||||||
const runtime = createOverlayModalRuntimeService({
|
const runtime = createOverlayModalRuntimeService(
|
||||||
|
{
|
||||||
getMainWindow: () => null,
|
getMainWindow: () => null,
|
||||||
getModalWindow: () => window as never,
|
getModalWindow: () => window as never,
|
||||||
createModalWindow: () => window as never,
|
createModalWindow: () => window as never,
|
||||||
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
setModalWindowBounds: () => {},
|
setModalWindowBounds: () => {},
|
||||||
});
|
},
|
||||||
|
{ platform: 'darwin' },
|
||||||
|
);
|
||||||
|
|
||||||
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
||||||
restoreOnModalClose: 'runtime-options',
|
restoreOnModalClose: 'runtime-options',
|
||||||
@@ -342,7 +436,9 @@ test('handleOverlayModalClosed hides modal window only after all pending modals
|
|||||||
assert.equal(window.isDestroyed(), false);
|
assert.equal(window.isDestroyed(), false);
|
||||||
|
|
||||||
runtime.handleOverlayModalClosed('subsync');
|
runtime.handleOverlayModalClosed('subsync');
|
||||||
assert.equal(window.isDestroyed(), true);
|
assert.equal(window.isDestroyed(), false);
|
||||||
|
assert.equal(window.isVisible(), false);
|
||||||
|
assert.equal(window.ignoreMouseEvents, true);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('sendToActiveOverlayWindow prefers visible main overlay window for modal open', () => {
|
test('sendToActiveOverlayWindow prefers visible main overlay window for modal open', () => {
|
||||||
@@ -464,6 +560,46 @@ test('modal window path restores visible main overlay before modal input deactiv
|
|||||||
assert.deepEqual(events, ['state:true:visible:true', 'state:false:visible:true']);
|
assert.deepEqual(events, ['state:true:visible:true', 'state:false:visible:true']);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('macOS maps a new modal panel before focusing SubMiner and hiding the subtitle overlay', () => {
|
||||||
|
const mainWindow = createMockWindow();
|
||||||
|
mainWindow.visible = true;
|
||||||
|
const modalWindow = createMockWindow();
|
||||||
|
const events: string[] = [];
|
||||||
|
const showInactive = modalWindow.showInactive;
|
||||||
|
modalWindow.showInactive = () => {
|
||||||
|
events.push('show-inactive');
|
||||||
|
showInactive();
|
||||||
|
};
|
||||||
|
const hideMainWindow = mainWindow.hide;
|
||||||
|
mainWindow.hide = () => {
|
||||||
|
events.push('hide-main');
|
||||||
|
hideMainWindow();
|
||||||
|
};
|
||||||
|
const runtime = createOverlayModalRuntimeService(
|
||||||
|
{
|
||||||
|
getMainWindow: () => mainWindow as never,
|
||||||
|
getModalWindow: () => modalWindow as never,
|
||||||
|
createModalWindow: () => modalWindow as never,
|
||||||
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
|
setModalWindowBounds: () => {},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
platform: 'darwin',
|
||||||
|
focusApplication: () => events.push('focus-application'),
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
||||||
|
restoreOnModalClose: 'runtime-options',
|
||||||
|
preferModalWindow: true,
|
||||||
|
});
|
||||||
|
runtime.notifyOverlayModalOpened('runtime-options');
|
||||||
|
|
||||||
|
assert.deepEqual(events, ['show-inactive', 'focus-application', 'hide-main']);
|
||||||
|
assert.equal(modalWindow.isVisible(), true);
|
||||||
|
assert.equal(mainWindow.isVisible(), false);
|
||||||
|
});
|
||||||
|
|
||||||
test('modal window path runs final close handoff before modal input deactivates', () => {
|
test('modal window path runs final close handoff before modal input deactivates', () => {
|
||||||
const mainWindow = createMockWindow();
|
const mainWindow = createMockWindow();
|
||||||
mainWindow.visible = true;
|
mainWindow.visible = true;
|
||||||
@@ -650,15 +786,18 @@ test('handleOverlayModalClosed is a no-op when no modal window can be targeted',
|
|||||||
assert.deepEqual(state, []);
|
assert.deepEqual(state, []);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('handleOverlayModalClosed destroys modal window for single kiku modal', () => {
|
test('handleOverlayModalClosed hides and retains modal window for single kiku modal', () => {
|
||||||
const window = createMockWindow();
|
const window = createMockWindow();
|
||||||
const runtime = createOverlayModalRuntimeService({
|
const runtime = createOverlayModalRuntimeService(
|
||||||
|
{
|
||||||
getMainWindow: () => null,
|
getMainWindow: () => null,
|
||||||
getModalWindow: () => window as never,
|
getModalWindow: () => window as never,
|
||||||
createModalWindow: () => window as never,
|
createModalWindow: () => window as never,
|
||||||
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
setModalWindowBounds: () => {},
|
setModalWindowBounds: () => {},
|
||||||
});
|
},
|
||||||
|
{ platform: 'darwin' },
|
||||||
|
);
|
||||||
|
|
||||||
runtime.sendToActiveOverlayWindow(
|
runtime.sendToActiveOverlayWindow(
|
||||||
'kiku:field-grouping-open',
|
'kiku:field-grouping-open',
|
||||||
@@ -669,7 +808,9 @@ test('handleOverlayModalClosed destroys modal window for single kiku modal', ()
|
|||||||
);
|
);
|
||||||
runtime.handleOverlayModalClosed('kiku');
|
runtime.handleOverlayModalClosed('kiku');
|
||||||
|
|
||||||
assert.equal(window.isDestroyed(), true);
|
assert.equal(window.isDestroyed(), false);
|
||||||
|
assert.equal(window.isVisible(), false);
|
||||||
|
assert.equal(window.ignoreMouseEvents, true);
|
||||||
assert.equal(runtime.getRestoreVisibleOverlayOnModalClose().size, 0);
|
assert.equal(runtime.getRestoreVisibleOverlayOnModalClose().size, 0);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -719,8 +860,10 @@ test('modal fallback reveal skips showing window when content is not ready', asy
|
|||||||
assert.equal(window.ignoreMouseEvents, false);
|
assert.equal(window.ignoreMouseEvents, false);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('sendToActiveOverlayWindow waits for modal ready-to-show before delivering open event', () => {
|
test('sendToActiveOverlayWindow delivers on first modal load without waiting for ready-to-show', () => {
|
||||||
const window = createMockWindow();
|
const window = createMockWindow();
|
||||||
|
window.loading = true;
|
||||||
|
window.url = '';
|
||||||
window.contentReady = false;
|
window.contentReady = false;
|
||||||
const runtime = createOverlayModalRuntimeService({
|
const runtime = createOverlayModalRuntimeService({
|
||||||
getMainWindow: () => null,
|
getMainWindow: () => null,
|
||||||
@@ -738,16 +881,100 @@ test('sendToActiveOverlayWindow waits for modal ready-to-show before delivering
|
|||||||
|
|
||||||
assert.equal(sent, true);
|
assert.equal(sent, true);
|
||||||
assert.deepEqual(window.sent, []);
|
assert.deepEqual(window.sent, []);
|
||||||
|
window.loading = false;
|
||||||
|
window.url = 'file:///overlay/index.html?layer=modal';
|
||||||
window.emitDidFinishLoad();
|
window.emitDidFinishLoad();
|
||||||
assert.deepEqual(window.sent, []);
|
assert.deepEqual(window.sent, [['runtime-options:open']]);
|
||||||
|
|
||||||
window.contentReady = true;
|
window.contentReady = true;
|
||||||
window.emitReadyToShow();
|
window.emitReadyToShow();
|
||||||
assert.deepEqual(window.sent, [['runtime-options:open']]);
|
assert.deepEqual(window.sent, [['runtime-options:open']]);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('sendToActiveOverlayWindow delivers when the modal loaded before listeners were registered', () => {
|
||||||
|
const window = createMockWindow();
|
||||||
|
window.contentReady = false;
|
||||||
|
const runtime = createOverlayModalRuntimeService({
|
||||||
|
getMainWindow: () => null,
|
||||||
|
getModalWindow: () => window as never,
|
||||||
|
createModalWindow: () => {
|
||||||
|
throw new Error('modal window should not be created when already present');
|
||||||
|
},
|
||||||
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
|
setModalWindowBounds: () => {},
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(
|
||||||
|
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
||||||
|
restoreOnModalClose: 'runtime-options',
|
||||||
|
}),
|
||||||
|
true,
|
||||||
|
);
|
||||||
|
assert.deepEqual(window.sent, [['runtime-options:open']]);
|
||||||
|
|
||||||
|
window.contentReady = true;
|
||||||
|
window.emitReadyToShow();
|
||||||
|
assert.deepEqual(window.sent, [['runtime-options:open']]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('sendToActiveOverlayWindow does not infer document readiness from a pending file URL', () => {
|
||||||
|
const window = createMockWindow();
|
||||||
|
window.contentReady = false;
|
||||||
|
window.documentLoaded = false;
|
||||||
|
window.loading = false;
|
||||||
|
const runtime = createOverlayModalRuntimeService({
|
||||||
|
getMainWindow: () => null,
|
||||||
|
getModalWindow: () => window as never,
|
||||||
|
createModalWindow: () => {
|
||||||
|
throw new Error('modal window should not be created when already present');
|
||||||
|
},
|
||||||
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
|
setModalWindowBounds: () => {},
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(
|
||||||
|
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
||||||
|
restoreOnModalClose: 'runtime-options',
|
||||||
|
}),
|
||||||
|
true,
|
||||||
|
);
|
||||||
|
assert.deepEqual(window.sent, []);
|
||||||
|
|
||||||
|
window.emitDidFinishLoad();
|
||||||
|
assert.deepEqual(window.sent, [['runtime-options:open']]);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('sendToActiveOverlayWindow rejects stale content readiness during document reload', () => {
|
||||||
|
const window = createMockWindow();
|
||||||
|
window.contentReady = true;
|
||||||
|
window.documentLoaded = false;
|
||||||
|
window.loading = false;
|
||||||
|
const runtime = createOverlayModalRuntimeService({
|
||||||
|
getMainWindow: () => null,
|
||||||
|
getModalWindow: () => window as never,
|
||||||
|
createModalWindow: () => {
|
||||||
|
throw new Error('modal window should not be created when already present');
|
||||||
|
},
|
||||||
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
|
setModalWindowBounds: () => {},
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(
|
||||||
|
runtime.sendToActiveOverlayWindow('session-help:open', undefined, {
|
||||||
|
restoreOnModalClose: 'session-help',
|
||||||
|
}),
|
||||||
|
true,
|
||||||
|
);
|
||||||
|
assert.deepEqual(window.sent, []);
|
||||||
|
|
||||||
|
window.emitDidFinishLoad();
|
||||||
|
assert.deepEqual(window.sent, [['session-help:open']]);
|
||||||
|
});
|
||||||
|
|
||||||
test('sendToActiveOverlayWindow flushes every queued load and ready listener before sending', () => {
|
test('sendToActiveOverlayWindow flushes every queued load and ready listener before sending', () => {
|
||||||
const window = createMockWindow();
|
const window = createMockWindow();
|
||||||
|
window.loading = true;
|
||||||
|
window.url = '';
|
||||||
window.contentReady = false;
|
window.contentReady = false;
|
||||||
const runtime = createOverlayModalRuntimeService({
|
const runtime = createOverlayModalRuntimeService({
|
||||||
getMainWindow: () => null,
|
getMainWindow: () => null,
|
||||||
@@ -773,29 +1000,73 @@ test('sendToActiveOverlayWindow flushes every queued load and ready listener bef
|
|||||||
);
|
);
|
||||||
assert.deepEqual(window.sent, []);
|
assert.deepEqual(window.sent, []);
|
||||||
|
|
||||||
|
window.loading = false;
|
||||||
|
window.url = 'file:///overlay/index.html?layer=modal';
|
||||||
window.emitDidFinishLoad();
|
window.emitDidFinishLoad();
|
||||||
assert.deepEqual(window.sent, []);
|
assert.deepEqual(window.sent, [['runtime-options:open'], ['session-help:open']]);
|
||||||
|
|
||||||
window.contentReady = true;
|
window.contentReady = true;
|
||||||
window.emitReadyToShow();
|
window.emitReadyToShow();
|
||||||
assert.deepEqual(window.sent, [['runtime-options:open'], ['session-help:open']]);
|
assert.deepEqual(window.sent, [['runtime-options:open'], ['session-help:open']]);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('modal reopen creates a fresh window after close destroys the previous one', () => {
|
test('modal reopen reuses the warm window and shows it immediately on macOS', () => {
|
||||||
const firstWindow = createMockWindow();
|
const modalWindow = createMockWindow();
|
||||||
const secondWindow = createMockWindow();
|
let createCalls = 0;
|
||||||
let currentModal: ReturnType<typeof createMockWindow> | null = firstWindow;
|
|
||||||
|
|
||||||
const runtime = createOverlayModalRuntimeService({
|
const runtime = createOverlayModalRuntimeService(
|
||||||
|
{
|
||||||
getMainWindow: () => null,
|
getMainWindow: () => null,
|
||||||
getModalWindow: () => currentModal as never,
|
getModalWindow: () => modalWindow as never,
|
||||||
createModalWindow: () => {
|
createModalWindow: () => {
|
||||||
currentModal = secondWindow;
|
createCalls += 1;
|
||||||
return secondWindow as never;
|
return modalWindow as never;
|
||||||
},
|
},
|
||||||
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
setModalWindowBounds: () => {},
|
setModalWindowBounds: () => {},
|
||||||
|
},
|
||||||
|
{ platform: 'darwin' },
|
||||||
|
);
|
||||||
|
|
||||||
|
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
||||||
|
restoreOnModalClose: 'runtime-options',
|
||||||
});
|
});
|
||||||
|
runtime.notifyOverlayModalOpened('runtime-options');
|
||||||
|
runtime.handleOverlayModalClosed('runtime-options');
|
||||||
|
|
||||||
|
assert.equal(modalWindow.isDestroyed(), false);
|
||||||
|
assert.equal(modalWindow.isVisible(), false);
|
||||||
|
|
||||||
|
const sent = runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
||||||
|
restoreOnModalClose: 'runtime-options',
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(sent, true);
|
||||||
|
assert.equal(createCalls, 0);
|
||||||
|
assert.equal(modalWindow.isVisible(), true);
|
||||||
|
assert.equal(modalWindow.getShowCount(), 2);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('modal reopen on Windows uses a fresh prewarmed interactive window', () => {
|
||||||
|
const firstWindow = createMockWindow();
|
||||||
|
const replacementWindow = createMockWindow();
|
||||||
|
let currentModal = firstWindow;
|
||||||
|
let createCalls = 0;
|
||||||
|
|
||||||
|
const runtime = createOverlayModalRuntimeService(
|
||||||
|
{
|
||||||
|
getMainWindow: () => null,
|
||||||
|
getModalWindow: () => currentModal as never,
|
||||||
|
createModalWindow: () => {
|
||||||
|
createCalls += 1;
|
||||||
|
currentModal = replacementWindow;
|
||||||
|
return replacementWindow as never;
|
||||||
|
},
|
||||||
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
|
setModalWindowBounds: () => {},
|
||||||
|
},
|
||||||
|
{ platform: 'win32' },
|
||||||
|
);
|
||||||
|
|
||||||
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
||||||
restoreOnModalClose: 'runtime-options',
|
restoreOnModalClose: 'runtime-options',
|
||||||
@@ -804,30 +1075,30 @@ test('modal reopen creates a fresh window after close destroys the previous one'
|
|||||||
runtime.handleOverlayModalClosed('runtime-options');
|
runtime.handleOverlayModalClosed('runtime-options');
|
||||||
|
|
||||||
assert.equal(firstWindow.isDestroyed(), true);
|
assert.equal(firstWindow.isDestroyed(), true);
|
||||||
|
assert.equal(currentModal, replacementWindow);
|
||||||
|
assert.equal(replacementWindow.isVisible(), false);
|
||||||
|
assert.equal(createCalls, 1);
|
||||||
|
|
||||||
const sent = runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
const sent = runtime.sendToActiveOverlayWindow('session-help:open', undefined, {
|
||||||
restoreOnModalClose: 'runtime-options',
|
restoreOnModalClose: 'session-help',
|
||||||
});
|
});
|
||||||
|
|
||||||
assert.equal(sent, true);
|
assert.equal(sent, true);
|
||||||
assert.equal(currentModal, secondWindow);
|
assert.equal(createCalls, 1);
|
||||||
assert.equal(secondWindow.getShowCount(), 0);
|
assert.equal(replacementWindow.isVisible(), true);
|
||||||
|
assert.equal(replacementWindow.ignoreMouseEvents, false);
|
||||||
|
assert.deepEqual(replacementWindow.sent, [['session-help:open']]);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('modal reopen after close-destroy notifies state change on fresh window lifecycle', () => {
|
test('modal reopen on the warm window notifies state change for each lifecycle', () => {
|
||||||
const firstWindow = createMockWindow();
|
const modalWindow = createMockWindow();
|
||||||
const secondWindow = createMockWindow();
|
|
||||||
let currentModal: ReturnType<typeof createMockWindow> | null = firstWindow;
|
|
||||||
const state: boolean[] = [];
|
const state: boolean[] = [];
|
||||||
|
|
||||||
const runtime = createOverlayModalRuntimeService(
|
const runtime = createOverlayModalRuntimeService(
|
||||||
{
|
{
|
||||||
getMainWindow: () => null,
|
getMainWindow: () => null,
|
||||||
getModalWindow: () => currentModal as never,
|
getModalWindow: () => modalWindow as never,
|
||||||
createModalWindow: () => {
|
createModalWindow: () => modalWindow as never,
|
||||||
currentModal = secondWindow;
|
|
||||||
return secondWindow as never;
|
|
||||||
},
|
|
||||||
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
getModalGeometry: () => ({ x: 0, y: 0, width: 400, height: 300 }),
|
||||||
setModalWindowBounds: () => {},
|
setModalWindowBounds: () => {},
|
||||||
},
|
},
|
||||||
@@ -835,6 +1106,7 @@ test('modal reopen after close-destroy notifies state change on fresh window lif
|
|||||||
onModalStateChange: (active: boolean): void => {
|
onModalStateChange: (active: boolean): void => {
|
||||||
state.push(active);
|
state.push(active);
|
||||||
},
|
},
|
||||||
|
platform: 'darwin',
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
|
|
||||||
@@ -845,7 +1117,7 @@ test('modal reopen after close-destroy notifies state change on fresh window lif
|
|||||||
runtime.handleOverlayModalClosed('runtime-options');
|
runtime.handleOverlayModalClosed('runtime-options');
|
||||||
|
|
||||||
assert.deepEqual(state, [true, false]);
|
assert.deepEqual(state, [true, false]);
|
||||||
assert.equal(firstWindow.isDestroyed(), true);
|
assert.equal(modalWindow.isDestroyed(), false);
|
||||||
|
|
||||||
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
runtime.sendToActiveOverlayWindow('runtime-options:open', undefined, {
|
||||||
restoreOnModalClose: 'runtime-options',
|
restoreOnModalClose: 'runtime-options',
|
||||||
@@ -853,7 +1125,7 @@ test('modal reopen after close-destroy notifies state change on fresh window lif
|
|||||||
runtime.notifyOverlayModalOpened('runtime-options');
|
runtime.notifyOverlayModalOpened('runtime-options');
|
||||||
|
|
||||||
assert.deepEqual(state, [true, false, true]);
|
assert.deepEqual(state, [true, false, true]);
|
||||||
assert.equal(currentModal, secondWindow);
|
assert.equal(modalWindow.isVisible(), true);
|
||||||
});
|
});
|
||||||
|
|
||||||
test('visible stale modal window is made interactive again before reopening', () => {
|
test('visible stale modal window is made interactive again before reopening', () => {
|
||||||
|
|||||||
+100
-18
@@ -2,7 +2,11 @@ import type { BrowserWindow } from 'electron';
|
|||||||
import type { OverlayHostedModal } from '../shared/ipc/contracts';
|
import type { OverlayHostedModal } from '../shared/ipc/contracts';
|
||||||
import type { WindowGeometry } from '../types';
|
import type { WindowGeometry } from '../types';
|
||||||
import type { HyprlandPlacementStatus } from '../core/services/hyprland-window-placement';
|
import type { HyprlandPlacementStatus } from '../core/services/hyprland-window-placement';
|
||||||
import { OVERLAY_WINDOW_CONTENT_READY_FLAG } from '../core/services/overlay-window-flags';
|
import { applyOverlayClickThrough } from '../core/services/overlay-click-through';
|
||||||
|
import {
|
||||||
|
OVERLAY_WINDOW_CONTENT_READY_FLAG,
|
||||||
|
OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG,
|
||||||
|
} from '../core/services/overlay-window-flags';
|
||||||
|
|
||||||
const MODAL_REVEAL_FALLBACK_DELAY_MS = 250;
|
const MODAL_REVEAL_FALLBACK_DELAY_MS = 250;
|
||||||
// The dedicated modal window maps asynchronously on Wayland; a single reconcile can fire
|
// The dedicated modal window maps asynchronously on Wayland; a single reconcile can fire
|
||||||
@@ -39,6 +43,7 @@ export interface OverlayWindowResolver {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export interface OverlayModalRuntime {
|
export interface OverlayModalRuntime {
|
||||||
|
primeModalWindow: () => boolean;
|
||||||
sendToActiveOverlayWindow: (
|
sendToActiveOverlayWindow: (
|
||||||
channel: string,
|
channel: string,
|
||||||
payload?: unknown,
|
payload?: unknown,
|
||||||
@@ -59,6 +64,8 @@ export interface OverlayModalRuntime {
|
|||||||
type RevealFallbackHandle = NonNullable<Parameters<typeof globalThis.clearTimeout>[0]>;
|
type RevealFallbackHandle = NonNullable<Parameters<typeof globalThis.clearTimeout>[0]>;
|
||||||
|
|
||||||
export interface OverlayModalRuntimeOptions {
|
export interface OverlayModalRuntimeOptions {
|
||||||
|
platform?: NodeJS.Platform;
|
||||||
|
focusApplication?: () => void;
|
||||||
onModalStateChange?: (isActive: boolean) => void;
|
onModalStateChange?: (isActive: boolean) => void;
|
||||||
onFinalModalClosed?: () => void;
|
onFinalModalClosed?: () => void;
|
||||||
scheduleRevealFallback?: (callback: () => void, delayMs: number) => RevealFallbackHandle;
|
scheduleRevealFallback?: (callback: () => void, delayMs: number) => RevealFallbackHandle;
|
||||||
@@ -79,6 +86,11 @@ export function createOverlayModalRuntimeService(
|
|||||||
let pendingModalWindowReveal: BrowserWindow | null = null;
|
let pendingModalWindowReveal: BrowserWindow | null = null;
|
||||||
let pendingModalWindowRevealTimeout: RevealFallbackHandle | null = null;
|
let pendingModalWindowRevealTimeout: RevealFallbackHandle | null = null;
|
||||||
const modalWindowBoundsReconcileGenerations = new WeakMap<BrowserWindow, number>();
|
const modalWindowBoundsReconcileGenerations = new WeakMap<BrowserWindow, number>();
|
||||||
|
const modalWindowPrimeListenersRegistered = new WeakSet<BrowserWindow>();
|
||||||
|
const platform = options.platform ?? process.platform;
|
||||||
|
const shouldPrimeModalWindow = platform === 'darwin' || platform === 'win32';
|
||||||
|
const reuseModalWindowAfterClose = platform === 'darwin';
|
||||||
|
const focusApplication = options.focusApplication ?? requestOverlayApplicationFocus;
|
||||||
const scheduleRevealFallback = (callback: () => void, delayMs: number): RevealFallbackHandle =>
|
const scheduleRevealFallback = (callback: () => void, delayMs: number): RevealFallbackHandle =>
|
||||||
(options.scheduleRevealFallback ?? globalThis.setTimeout)(callback, delayMs);
|
(options.scheduleRevealFallback ?? globalThis.setTimeout)(callback, delayMs);
|
||||||
const clearRevealFallback = (timeout: RevealFallbackHandle): void =>
|
const clearRevealFallback = (timeout: RevealFallbackHandle): void =>
|
||||||
@@ -134,7 +146,11 @@ export function createOverlayModalRuntimeService(
|
|||||||
}
|
}
|
||||||
const overlayWindow = window as BrowserWindow & {
|
const overlayWindow = window as BrowserWindow & {
|
||||||
[OVERLAY_WINDOW_CONTENT_READY_FLAG]?: boolean;
|
[OVERLAY_WINDOW_CONTENT_READY_FLAG]?: boolean;
|
||||||
|
[OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG]?: boolean;
|
||||||
};
|
};
|
||||||
|
if (overlayWindow[OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG] === false) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
if (
|
if (
|
||||||
typeof overlayWindow[OVERLAY_WINDOW_CONTENT_READY_FLAG] === 'boolean' &&
|
typeof overlayWindow[OVERLAY_WINDOW_CONTENT_READY_FLAG] === 'boolean' &&
|
||||||
overlayWindow[OVERLAY_WINDOW_CONTENT_READY_FLAG] !== true
|
overlayWindow[OVERLAY_WINDOW_CONTENT_READY_FLAG] !== true
|
||||||
@@ -145,6 +161,50 @@ export function createOverlayModalRuntimeService(
|
|||||||
return currentURL !== '' && currentURL !== 'about:blank';
|
return currentURL !== '' && currentURL !== 'about:blank';
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const isWindowLoadedForIpc = (window: BrowserWindow): boolean => {
|
||||||
|
if (window.isDestroyed() || window.webContents.isLoading()) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
const overlayWindow = window as BrowserWindow & {
|
||||||
|
[OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG]?: boolean;
|
||||||
|
};
|
||||||
|
if (overlayWindow[OVERLAY_WINDOW_DOCUMENT_LOADED_FLAG] !== true) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
const currentURL = window.webContents.getURL();
|
||||||
|
return currentURL !== '' && currentURL !== 'about:blank';
|
||||||
|
};
|
||||||
|
|
||||||
|
const markModalWindowPrimed = (window: BrowserWindow): void => {
|
||||||
|
if (deps.getModalWindow() !== window || !isWindowLoadedForIpc(window)) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
modalWindowPrimedForImmediateShow = true;
|
||||||
|
};
|
||||||
|
|
||||||
|
const primeModalWindow = (): boolean => {
|
||||||
|
if (!shouldPrimeModalWindow) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
const modalWindow = resolveModalWindow();
|
||||||
|
if (!modalWindow) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
deps.setModalWindowBounds(deps.getModalGeometry());
|
||||||
|
if (isWindowReadyForIpc(modalWindow)) {
|
||||||
|
modalWindowPrimedForImmediateShow = true;
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!modalWindowPrimeListenersRegistered.has(modalWindow)) {
|
||||||
|
modalWindowPrimeListenersRegistered.add(modalWindow);
|
||||||
|
modalWindow.webContents.once('did-finish-load', () => markModalWindowPrimed(modalWindow));
|
||||||
|
modalWindow.once('ready-to-show', () => markModalWindowPrimed(modalWindow));
|
||||||
|
}
|
||||||
|
return true;
|
||||||
|
};
|
||||||
|
|
||||||
const elevateModalWindow = (window: BrowserWindow): void => {
|
const elevateModalWindow = (window: BrowserWindow): void => {
|
||||||
if (window.isDestroyed()) return;
|
if (window.isDestroyed()) return;
|
||||||
window.setAlwaysOnTop(true, 'screen-saver', 3);
|
window.setAlwaysOnTop(true, 'screen-saver', 3);
|
||||||
@@ -205,16 +265,19 @@ export function createOverlayModalRuntimeService(
|
|||||||
}
|
}
|
||||||
|
|
||||||
let delivered = false;
|
let delivered = false;
|
||||||
const deliverWhenReady = (): void => {
|
const deliver = (isReady: () => boolean): void => {
|
||||||
if (delivered || window.isDestroyed() || !isWindowReadyForIpc(window)) {
|
if (delivered || window.isDestroyed() || !isReady()) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
delivered = true;
|
delivered = true;
|
||||||
sendNow(window);
|
sendNow(window);
|
||||||
};
|
};
|
||||||
|
|
||||||
window.webContents.once('did-finish-load', deliverWhenReady);
|
// A hidden macOS panel may not emit ready-to-show until it is presented. The
|
||||||
window.once('ready-to-show', deliverWhenReady);
|
// renderer can safely receive IPC as soon as its document has finished loading.
|
||||||
|
window.webContents.once('did-finish-load', () => deliver(() => isWindowLoadedForIpc(window)));
|
||||||
|
window.once('ready-to-show', () => deliver(() => isWindowReadyForIpc(window)));
|
||||||
|
deliver(() => isWindowLoadedForIpc(window));
|
||||||
};
|
};
|
||||||
|
|
||||||
const showModalWindow = (
|
const showModalWindow = (
|
||||||
@@ -224,13 +287,20 @@ export function createOverlayModalRuntimeService(
|
|||||||
} = { passThroughMouseEvents: false },
|
} = { passThroughMouseEvents: false },
|
||||||
): void => {
|
): void => {
|
||||||
setWindowFocusable(window);
|
setWindowFocusable(window);
|
||||||
requestOverlayApplicationFocus();
|
const wasVisible = window.isVisible();
|
||||||
if (!window.isVisible()) {
|
if (!wasVisible && platform === 'darwin') {
|
||||||
|
// Mapping the panel first keeps it attached to mpv's active fullscreen Space.
|
||||||
|
window.showInactive();
|
||||||
|
focusApplication();
|
||||||
|
} else {
|
||||||
|
focusApplication();
|
||||||
|
}
|
||||||
|
if (!wasVisible && platform !== 'darwin') {
|
||||||
window.show();
|
window.show();
|
||||||
}
|
}
|
||||||
elevateModalWindow(window);
|
elevateModalWindow(window);
|
||||||
if (options.passThroughMouseEvents) {
|
if (options.passThroughMouseEvents) {
|
||||||
window.setIgnoreMouseEvents(true, { forward: true });
|
applyOverlayClickThrough(window, platform === 'win32');
|
||||||
} else {
|
} else {
|
||||||
window.setIgnoreMouseEvents(false);
|
window.setIgnoreMouseEvents(false);
|
||||||
}
|
}
|
||||||
@@ -245,11 +315,11 @@ export function createOverlayModalRuntimeService(
|
|||||||
|
|
||||||
const ensureModalWindowInteractive = (window: BrowserWindow): void => {
|
const ensureModalWindowInteractive = (window: BrowserWindow): void => {
|
||||||
setWindowFocusable(window);
|
setWindowFocusable(window);
|
||||||
requestOverlayApplicationFocus();
|
|
||||||
window.setIgnoreMouseEvents(false);
|
window.setIgnoreMouseEvents(false);
|
||||||
elevateModalWindow(window);
|
elevateModalWindow(window);
|
||||||
|
|
||||||
if (window.isVisible()) {
|
if (window.isVisible()) {
|
||||||
|
focusApplication();
|
||||||
window.focus();
|
window.focus();
|
||||||
window.webContents.focus();
|
window.webContents.focus();
|
||||||
const reconcileGeneration = nextModalWindowBoundsReconcileGeneration(window);
|
const reconcileGeneration = nextModalWindowBoundsReconcileGeneration(window);
|
||||||
@@ -291,7 +361,7 @@ export function createOverlayModalRuntimeService(
|
|||||||
mainWindowMousePassthroughForcedByModal = false;
|
mainWindowMousePassthroughForcedByModal = false;
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
mainWindow.setIgnoreMouseEvents(true, { forward: true });
|
applyOverlayClickThrough(mainWindow, platform === 'win32');
|
||||||
mainWindowMousePassthroughForcedByModal = true;
|
mainWindowMousePassthroughForcedByModal = true;
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
@@ -447,9 +517,21 @@ export function createOverlayModalRuntimeService(
|
|||||||
if (restoreVisibleOverlayOnModalClose.size === 0) {
|
if (restoreVisibleOverlayOnModalClose.size === 0) {
|
||||||
clearPendingModalWindowReveal();
|
clearPendingModalWindowReveal();
|
||||||
if (modalWindow && !modalWindow.isDestroyed()) {
|
if (modalWindow && !modalWindow.isDestroyed()) {
|
||||||
|
if (reuseModalWindowAfterClose) {
|
||||||
|
applyOverlayClickThrough(modalWindow, false);
|
||||||
|
modalWindow.hide();
|
||||||
|
markModalWindowPrimed(modalWindow);
|
||||||
|
} else {
|
||||||
modalWindow.destroy();
|
modalWindow.destroy();
|
||||||
}
|
|
||||||
modalWindowPrimedForImmediateShow = false;
|
modalWindowPrimedForImmediateShow = false;
|
||||||
|
// Reusing a transparent click-through BrowserWindow can leave later modal sessions
|
||||||
|
// non-interactive on Windows. Recycle the renderer after every close, then warm its
|
||||||
|
// replacement so the next shortcut still opens promptly.
|
||||||
|
if (platform === 'win32') {
|
||||||
|
primeModalWindow();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
mainWindowMousePassthroughForcedByModal = false;
|
mainWindowMousePassthroughForcedByModal = false;
|
||||||
setMainWindowVisibilityForModal(false);
|
setMainWindowVisibilityForModal(false);
|
||||||
try {
|
try {
|
||||||
@@ -478,17 +560,16 @@ export function createOverlayModalRuntimeService(
|
|||||||
}
|
}
|
||||||
|
|
||||||
const modalWindow = deps.getModalWindow();
|
const modalWindow = deps.getModalWindow();
|
||||||
|
if (targetWindow.isVisible()) {
|
||||||
|
ensureModalWindowInteractive(targetWindow);
|
||||||
|
} else {
|
||||||
|
showModalWindow(targetWindow);
|
||||||
|
}
|
||||||
|
|
||||||
if (modalWindow && !modalWindow.isDestroyed() && targetWindow === modalWindow) {
|
if (modalWindow && !modalWindow.isDestroyed() && targetWindow === modalWindow) {
|
||||||
setMainWindowMousePassthroughForModal(true);
|
setMainWindowMousePassthroughForModal(true);
|
||||||
setMainWindowVisibilityForModal(true);
|
setMainWindowVisibilityForModal(true);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (targetWindow.isVisible()) {
|
|
||||||
ensureModalWindowInteractive(targetWindow);
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
|
|
||||||
showModalWindow(targetWindow);
|
|
||||||
};
|
};
|
||||||
|
|
||||||
const waitForModalOpen = async (modal: OverlayHostedModal, timeoutMs: number): Promise<boolean> =>
|
const waitForModalOpen = async (modal: OverlayHostedModal, timeoutMs: number): Promise<boolean> =>
|
||||||
@@ -515,6 +596,7 @@ export function createOverlayModalRuntimeService(
|
|||||||
});
|
});
|
||||||
|
|
||||||
return {
|
return {
|
||||||
|
primeModalWindow,
|
||||||
sendToActiveOverlayWindow,
|
sendToActiveOverlayWindow,
|
||||||
openRuntimeOptionsPalette,
|
openRuntimeOptionsPalette,
|
||||||
openJimaku,
|
openJimaku,
|
||||||
|
|||||||
@@ -191,6 +191,8 @@ test('mpv event bindings register all expected events', () => {
|
|||||||
onSubtitleAssChange: () => {},
|
onSubtitleAssChange: () => {},
|
||||||
onSecondarySubtitleChange: () => {},
|
onSecondarySubtitleChange: () => {},
|
||||||
onSubtitleTrackChange: () => {},
|
onSubtitleTrackChange: () => {},
|
||||||
|
onSecondarySubtitleTrackChange: () => {},
|
||||||
|
onSecondarySubtitleDelayChange: () => {},
|
||||||
onSubtitleTrackListChange: () => {},
|
onSubtitleTrackListChange: () => {},
|
||||||
onSubtitleTiming: () => {},
|
onSubtitleTiming: () => {},
|
||||||
onMediaPathChange: () => {},
|
onMediaPathChange: () => {},
|
||||||
@@ -215,6 +217,8 @@ test('mpv event bindings register all expected events', () => {
|
|||||||
'subtitle-ass-change',
|
'subtitle-ass-change',
|
||||||
'secondary-subtitle-change',
|
'secondary-subtitle-change',
|
||||||
'subtitle-track-change',
|
'subtitle-track-change',
|
||||||
|
'secondary-subtitle-track-change',
|
||||||
|
'secondary-subtitle-delay-change',
|
||||||
'subtitle-track-list-change',
|
'subtitle-track-list-change',
|
||||||
'subtitle-timing',
|
'subtitle-timing',
|
||||||
'media-path-change',
|
'media-path-change',
|
||||||
|
|||||||
@@ -4,6 +4,8 @@ type MpvBindingEventName =
|
|||||||
| 'subtitle-ass-change'
|
| 'subtitle-ass-change'
|
||||||
| 'secondary-subtitle-change'
|
| 'secondary-subtitle-change'
|
||||||
| 'subtitle-track-change'
|
| 'subtitle-track-change'
|
||||||
|
| 'secondary-subtitle-track-change'
|
||||||
|
| 'secondary-subtitle-delay-change'
|
||||||
| 'subtitle-track-list-change'
|
| 'subtitle-track-list-change'
|
||||||
| 'subtitle-timing'
|
| 'subtitle-timing'
|
||||||
| 'media-path-change'
|
| 'media-path-change'
|
||||||
@@ -90,6 +92,8 @@ export function createBindMpvClientEventHandlers(deps: {
|
|||||||
onSubtitleAssChange: (payload: { text: string }) => void;
|
onSubtitleAssChange: (payload: { text: string }) => void;
|
||||||
onSecondarySubtitleChange: (payload: { text: string }) => void;
|
onSecondarySubtitleChange: (payload: { text: string }) => void;
|
||||||
onSubtitleTrackChange: (payload: { sid: number | null }) => void;
|
onSubtitleTrackChange: (payload: { sid: number | null }) => void;
|
||||||
|
onSecondarySubtitleTrackChange: (payload: { sid: number | null }) => void;
|
||||||
|
onSecondarySubtitleDelayChange: (payload: { delay: number }) => void;
|
||||||
onSubtitleTrackListChange: (payload: { trackList: unknown[] | null }) => void;
|
onSubtitleTrackListChange: (payload: { trackList: unknown[] | null }) => void;
|
||||||
onSubtitleTiming: (payload: { text: string; start: number; end: number }) => void;
|
onSubtitleTiming: (payload: { text: string; start: number; end: number }) => void;
|
||||||
onMediaPathChange: (payload: { path: string | null }) => void;
|
onMediaPathChange: (payload: { path: string | null }) => void;
|
||||||
@@ -107,6 +111,8 @@ export function createBindMpvClientEventHandlers(deps: {
|
|||||||
mpvClient.on('subtitle-ass-change', deps.onSubtitleAssChange);
|
mpvClient.on('subtitle-ass-change', deps.onSubtitleAssChange);
|
||||||
mpvClient.on('secondary-subtitle-change', deps.onSecondarySubtitleChange);
|
mpvClient.on('secondary-subtitle-change', deps.onSecondarySubtitleChange);
|
||||||
mpvClient.on('subtitle-track-change', deps.onSubtitleTrackChange);
|
mpvClient.on('subtitle-track-change', deps.onSubtitleTrackChange);
|
||||||
|
mpvClient.on('secondary-subtitle-track-change', deps.onSecondarySubtitleTrackChange);
|
||||||
|
mpvClient.on('secondary-subtitle-delay-change', deps.onSecondarySubtitleDelayChange);
|
||||||
mpvClient.on('subtitle-track-list-change', deps.onSubtitleTrackListChange);
|
mpvClient.on('subtitle-track-list-change', deps.onSubtitleTrackListChange);
|
||||||
mpvClient.on('subtitle-timing', deps.onSubtitleTiming);
|
mpvClient.on('subtitle-timing', deps.onSubtitleTiming);
|
||||||
mpvClient.on('media-path-change', deps.onMediaPathChange);
|
mpvClient.on('media-path-change', deps.onMediaPathChange);
|
||||||
|
|||||||
@@ -37,6 +37,9 @@ test('main mpv event binder wires callbacks through to runtime deps', () => {
|
|||||||
broadcastSubtitleAss: (text) => calls.push(`broadcast-ass:${text}`),
|
broadcastSubtitleAss: (text) => calls.push(`broadcast-ass:${text}`),
|
||||||
broadcastSecondarySubtitle: (text) => calls.push(`broadcast-secondary:${text}`),
|
broadcastSecondarySubtitle: (text) => calls.push(`broadcast-secondary:${text}`),
|
||||||
onSubtitleTrackChange: () => calls.push('subtitle-track-change'),
|
onSubtitleTrackChange: () => calls.push('subtitle-track-change'),
|
||||||
|
onSecondarySubtitleTrackChange: () => calls.push('secondary-subtitle-track-change'),
|
||||||
|
onSecondarySubtitleDelayChange: (delay) =>
|
||||||
|
calls.push(`secondary-subtitle-delay-change:${delay}`),
|
||||||
onSubtitleTrackListChange: () => calls.push('subtitle-track-list-change'),
|
onSubtitleTrackListChange: () => calls.push('subtitle-track-list-change'),
|
||||||
|
|
||||||
updateCurrentMediaPath: (path) => calls.push(`media-path:${path}`),
|
updateCurrentMediaPath: (path) => calls.push(`media-path:${path}`),
|
||||||
@@ -73,6 +76,8 @@ test('main mpv event binder wires callbacks through to runtime deps', () => {
|
|||||||
handlers.get('connection-change')?.({ connected: true });
|
handlers.get('connection-change')?.({ connected: true });
|
||||||
handlers.get('subtitle-change')?.({ text: 'line' });
|
handlers.get('subtitle-change')?.({ text: 'line' });
|
||||||
handlers.get('subtitle-track-change')?.({ sid: 3 });
|
handlers.get('subtitle-track-change')?.({ sid: 3 });
|
||||||
|
handlers.get('secondary-subtitle-track-change')?.({ sid: 4 });
|
||||||
|
handlers.get('secondary-subtitle-delay-change')?.({ delay: 0.5 });
|
||||||
handlers.get('subtitle-track-list-change')?.({ trackList: [] });
|
handlers.get('subtitle-track-list-change')?.({ trackList: [] });
|
||||||
handlers.get('media-path-change')?.({ path: '/tmp/video.mkv' });
|
handlers.get('media-path-change')?.({ path: '/tmp/video.mkv' });
|
||||||
handlers.get('media-path-change')?.({ path: '' });
|
handlers.get('media-path-change')?.({ path: '' });
|
||||||
@@ -86,6 +91,8 @@ test('main mpv event binder wires callbacks through to runtime deps', () => {
|
|||||||
assert.equal(calls.includes('broadcast-sub:line'), true);
|
assert.equal(calls.includes('broadcast-sub:line'), true);
|
||||||
assert.ok(calls.includes('subtitle-change:line'));
|
assert.ok(calls.includes('subtitle-change:line'));
|
||||||
assert.ok(calls.includes('subtitle-track-change'));
|
assert.ok(calls.includes('subtitle-track-change'));
|
||||||
|
assert.ok(calls.includes('secondary-subtitle-track-change'));
|
||||||
|
assert.ok(calls.includes('secondary-subtitle-delay-change:0.5'));
|
||||||
assert.ok(calls.includes('subtitle-track-list-change'));
|
assert.ok(calls.includes('subtitle-track-list-change'));
|
||||||
assert.ok(calls.includes('media-title:Episode 1'));
|
assert.ok(calls.includes('media-title:Episode 1'));
|
||||||
assert.ok(calls.includes('media-path:/tmp/video.mkv'));
|
assert.ok(calls.includes('media-path:/tmp/video.mkv'));
|
||||||
|
|||||||
@@ -54,6 +54,8 @@ export function createBindMpvMainEventHandlersHandler(deps: {
|
|||||||
broadcastSubtitleAss: (text: string) => void;
|
broadcastSubtitleAss: (text: string) => void;
|
||||||
broadcastSecondarySubtitle: (text: string) => void;
|
broadcastSecondarySubtitle: (text: string) => void;
|
||||||
onSubtitleTrackChange?: (sid: number | null) => void;
|
onSubtitleTrackChange?: (sid: number | null) => void;
|
||||||
|
onSecondarySubtitleTrackChange?: (sid: number | null) => void;
|
||||||
|
onSecondarySubtitleDelayChange?: (delay: number) => void;
|
||||||
onSubtitleTrackListChange?: (trackList: unknown[] | null) => void;
|
onSubtitleTrackListChange?: (trackList: unknown[] | null) => void;
|
||||||
|
|
||||||
updateCurrentMediaPath: (path: string) => void;
|
updateCurrentMediaPath: (path: string) => void;
|
||||||
@@ -189,6 +191,8 @@ export function createBindMpvMainEventHandlersHandler(deps: {
|
|||||||
onSubtitleAssChange: handleMpvSubtitleAssChange,
|
onSubtitleAssChange: handleMpvSubtitleAssChange,
|
||||||
onSecondarySubtitleChange: handleMpvSecondarySubtitleChange,
|
onSecondarySubtitleChange: handleMpvSecondarySubtitleChange,
|
||||||
onSubtitleTrackChange: ({ sid }) => deps.onSubtitleTrackChange?.(sid),
|
onSubtitleTrackChange: ({ sid }) => deps.onSubtitleTrackChange?.(sid),
|
||||||
|
onSecondarySubtitleTrackChange: ({ sid }) => deps.onSecondarySubtitleTrackChange?.(sid),
|
||||||
|
onSecondarySubtitleDelayChange: ({ delay }) => deps.onSecondarySubtitleDelayChange?.(delay),
|
||||||
onSubtitleTrackListChange: ({ trackList }) => deps.onSubtitleTrackListChange?.(trackList),
|
onSubtitleTrackListChange: ({ trackList }) => deps.onSubtitleTrackListChange?.(trackList),
|
||||||
onSubtitleTiming: handleMpvSubtitleTiming,
|
onSubtitleTiming: handleMpvSubtitleTiming,
|
||||||
onMediaPathChange: handleMpvMediaPathChange,
|
onMediaPathChange: handleMpvMediaPathChange,
|
||||||
|
|||||||
@@ -47,6 +47,9 @@ test('mpv main event main deps map app state updates and delegate callbacks', as
|
|||||||
logSubtitleTimingError: (message) => calls.push(`subtitle-error:${message}`),
|
logSubtitleTimingError: (message) => calls.push(`subtitle-error:${message}`),
|
||||||
broadcastToOverlayWindows: (channel, payload) =>
|
broadcastToOverlayWindows: (channel, payload) =>
|
||||||
calls.push(`broadcast:${channel}:${String(payload)}`),
|
calls.push(`broadcast:${channel}:${String(payload)}`),
|
||||||
|
onSecondarySubtitleChange: (text) => calls.push(`secondary:${text}`),
|
||||||
|
onSecondarySubtitleTrackChange: (sid) => calls.push(`secondary-track:${String(sid)}`),
|
||||||
|
onSecondarySubtitleDelayChange: (delay) => calls.push(`secondary-delay:${delay}`),
|
||||||
onSubtitleChange: (text) => calls.push(`subtitle-change:${text}`),
|
onSubtitleChange: (text) => calls.push(`subtitle-change:${text}`),
|
||||||
ensureImmersionTrackerInitialized: () => calls.push('ensure-immersion'),
|
ensureImmersionTrackerInitialized: () => calls.push('ensure-immersion'),
|
||||||
updateCurrentMediaPath: (path) => calls.push(`path:${path}`),
|
updateCurrentMediaPath: (path) => calls.push(`path:${path}`),
|
||||||
@@ -86,6 +89,8 @@ test('mpv main event main deps map app state updates and delegate callbacks', as
|
|||||||
deps.setCurrentSubAssText('ass');
|
deps.setCurrentSubAssText('ass');
|
||||||
deps.broadcastSubtitleAss('ass');
|
deps.broadcastSubtitleAss('ass');
|
||||||
deps.broadcastSecondarySubtitle('sec');
|
deps.broadcastSecondarySubtitle('sec');
|
||||||
|
deps.onSecondarySubtitleTrackChange?.(4);
|
||||||
|
deps.onSecondarySubtitleDelayChange?.(0.5);
|
||||||
deps.updateCurrentMediaPath('/tmp/video');
|
deps.updateCurrentMediaPath('/tmp/video');
|
||||||
deps.restoreMpvSubVisibility();
|
deps.restoreMpvSubVisibility();
|
||||||
deps.resetSubtitleSidebarEmbeddedLayout();
|
deps.resetSubtitleSidebarEmbeddedLayout();
|
||||||
@@ -116,6 +121,10 @@ test('mpv main event main deps map app state updates and delegate callbacks', as
|
|||||||
assert.ok(calls.includes('sync-overlay-mpv-sub'));
|
assert.ok(calls.includes('sync-overlay-mpv-sub'));
|
||||||
assert.ok(calls.includes('anilist-post-watch'));
|
assert.ok(calls.includes('anilist-post-watch'));
|
||||||
assert.ok(calls.includes('timing:y:secondary'));
|
assert.ok(calls.includes('timing:y:secondary'));
|
||||||
|
assert.ok(calls.includes('secondary:sec'));
|
||||||
|
assert.ok(calls.includes('secondary-track:4'));
|
||||||
|
assert.ok(calls.includes('secondary-delay:0.5'));
|
||||||
|
assert.ok(!calls.includes('broadcast:secondary-subtitle:set:sec'));
|
||||||
assert.ok(calls.includes('ensure-immersion'));
|
assert.ok(calls.includes('ensure-immersion'));
|
||||||
assert.ok(calls.includes('sync-immersion'));
|
assert.ok(calls.includes('sync-immersion'));
|
||||||
assert.ok(calls.includes('autoplay:/tmp/video'));
|
assert.ok(calls.includes('autoplay:/tmp/video'));
|
||||||
|
|||||||
@@ -53,11 +53,14 @@ export function createBuildBindMpvMainEventHandlersMainDepsHandler(deps: {
|
|||||||
recordAnilistMediaDuration?: (durationSec: number) => void;
|
recordAnilistMediaDuration?: (durationSec: number) => void;
|
||||||
logSubtitleTimingError: (message: string, error: unknown) => void;
|
logSubtitleTimingError: (message: string, error: unknown) => void;
|
||||||
broadcastToOverlayWindows: (channel: string, payload: unknown) => void;
|
broadcastToOverlayWindows: (channel: string, payload: unknown) => void;
|
||||||
|
onSecondarySubtitleChange?: (text: string) => void;
|
||||||
getImmediateSubtitlePayload?: (text: string) => SubtitleData | null;
|
getImmediateSubtitlePayload?: (text: string) => SubtitleData | null;
|
||||||
emitImmediateSubtitle?: (payload: SubtitleData) => void;
|
emitImmediateSubtitle?: (payload: SubtitleData) => void;
|
||||||
onSubtitleChange: (text: string) => void;
|
onSubtitleChange: (text: string) => void;
|
||||||
logSubtitleProcessingDebug?: (message: string) => void;
|
logSubtitleProcessingDebug?: (message: string) => void;
|
||||||
onSubtitleTrackChange?: (sid: number | null) => void;
|
onSubtitleTrackChange?: (sid: number | null) => void;
|
||||||
|
onSecondarySubtitleTrackChange?: (sid: number | null) => void;
|
||||||
|
onSecondarySubtitleDelayChange?: (delay: number) => void;
|
||||||
onSubtitleTrackListChange?: (trackList: unknown[] | null) => void;
|
onSubtitleTrackListChange?: (trackList: unknown[] | null) => void;
|
||||||
updateCurrentMediaPath: (path: string) => void;
|
updateCurrentMediaPath: (path: string) => void;
|
||||||
restoreMpvSubVisibility: () => void;
|
restoreMpvSubVisibility: () => void;
|
||||||
@@ -173,6 +176,12 @@ export function createBuildBindMpvMainEventHandlersMainDepsHandler(deps: {
|
|||||||
immersionLineDedupGate.reset();
|
immersionLineDedupGate.reset();
|
||||||
deps.onSubtitleTrackChange?.(sid);
|
deps.onSubtitleTrackChange?.(sid);
|
||||||
},
|
},
|
||||||
|
onSecondarySubtitleTrackChange: deps.onSecondarySubtitleTrackChange
|
||||||
|
? (sid: number | null) => deps.onSecondarySubtitleTrackChange!(sid)
|
||||||
|
: undefined,
|
||||||
|
onSecondarySubtitleDelayChange: deps.onSecondarySubtitleDelayChange
|
||||||
|
? (delay: number) => deps.onSecondarySubtitleDelayChange!(delay)
|
||||||
|
: undefined,
|
||||||
onSubtitleTrackListChange: deps.onSubtitleTrackListChange
|
onSubtitleTrackListChange: deps.onSubtitleTrackListChange
|
||||||
? (trackList: unknown[] | null) => deps.onSubtitleTrackListChange!(trackList)
|
? (trackList: unknown[] | null) => deps.onSubtitleTrackListChange!(trackList)
|
||||||
: undefined,
|
: undefined,
|
||||||
@@ -182,8 +191,13 @@ export function createBuildBindMpvMainEventHandlersMainDepsHandler(deps: {
|
|||||||
},
|
},
|
||||||
broadcastSubtitleAss: (text: string) =>
|
broadcastSubtitleAss: (text: string) =>
|
||||||
deps.broadcastToOverlayWindows('subtitle-ass:set', text),
|
deps.broadcastToOverlayWindows('subtitle-ass:set', text),
|
||||||
broadcastSecondarySubtitle: (text: string) =>
|
broadcastSecondarySubtitle: (text: string) => {
|
||||||
deps.broadcastToOverlayWindows('secondary-subtitle:set', text),
|
if (deps.onSecondarySubtitleChange) {
|
||||||
|
deps.onSecondarySubtitleChange(text);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
deps.broadcastToOverlayWindows('secondary-subtitle:set', text);
|
||||||
|
},
|
||||||
updateCurrentMediaPath: (path: string) => {
|
updateCurrentMediaPath: (path: string) => {
|
||||||
immersionLineDedupGate.reset();
|
immersionLineDedupGate.reset();
|
||||||
deps.updateCurrentMediaPath(path);
|
deps.updateCurrentMediaPath(path);
|
||||||
|
|||||||
@@ -0,0 +1,250 @@
|
|||||||
|
import assert from 'node:assert/strict';
|
||||||
|
import test from 'node:test';
|
||||||
|
import { parseSubtitleCues } from '../../core/services/subtitle-cue-parser';
|
||||||
|
import {
|
||||||
|
createSecondarySubtitleTrackController,
|
||||||
|
findActiveSubtitleText,
|
||||||
|
} from './secondary-subtitle-track';
|
||||||
|
|
||||||
|
test('findActiveSubtitleText combines unique simultaneous parsed cues', () => {
|
||||||
|
assert.equal(
|
||||||
|
findActiveSubtitleText(
|
||||||
|
[
|
||||||
|
{ startTime: 1, endTime: 3, text: 'Your' },
|
||||||
|
{ startTime: 1, endTime: 3, text: 'Your' },
|
||||||
|
{ startTime: 1, endTime: 3, text: 'mosaic' },
|
||||||
|
],
|
||||||
|
2,
|
||||||
|
),
|
||||||
|
'Your\nmosaic',
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('secondary track controller parses the selected ASS file before publishing', async () => {
|
||||||
|
const broadcasts: string[] = [];
|
||||||
|
let currentText = '';
|
||||||
|
const resolverInputs: Array<{ allowSelectedFallback?: boolean }> = [];
|
||||||
|
const ass = `[Events]
|
||||||
|
Format: Layer, Start, End, Style, Name, MarginL, MarginR, MarginV, Effect, Text
|
||||||
|
Dialogue: 0,0:00:01.00,0:00:03.00,Sign,,0,0,0,,Your
|
||||||
|
Dialogue: 1,0:00:01.00,0:00:03.00,Sign,,0,0,0,,Your
|
||||||
|
Dialogue: 2,0:00:01.00,0:00:03.00,Sign,,0,0,0,,Your
|
||||||
|
Dialogue: 3,0:00:01.00,0:00:03.00,Sign,,0,0,0,,Your
|
||||||
|
Dialogue: 4,0:00:01.00,0:00:03.00,Sign,,0,0,0,,mosaic`;
|
||||||
|
const controller = createSecondarySubtitleTrackController({
|
||||||
|
getMpvClient: () => ({
|
||||||
|
connected: true,
|
||||||
|
requestProperty: async (name) => {
|
||||||
|
if (name === 'secondary-sid') return 2;
|
||||||
|
if (name === 'track-list') return [{ type: 'sub', id: 2 }];
|
||||||
|
if (name === 'path') return '/media/video.mkv';
|
||||||
|
if (name === 'secondary-sub-delay') return 0;
|
||||||
|
return null;
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
getCurrentTimePos: () => 2,
|
||||||
|
resolveSubtitleSource: async (input) => {
|
||||||
|
resolverInputs.push(input);
|
||||||
|
return { path: '/subs/english.ass', sourceKey: '/subs/english.ass' };
|
||||||
|
},
|
||||||
|
loadSubtitleSourceText: async () => ass,
|
||||||
|
parseSubtitleCues,
|
||||||
|
setCurrentSecondaryText: (text) => {
|
||||||
|
currentText = text;
|
||||||
|
},
|
||||||
|
broadcastSecondaryText: (text) => broadcasts.push(text),
|
||||||
|
});
|
||||||
|
|
||||||
|
await controller.refresh();
|
||||||
|
controller.handleLiveText('Your\nYour\nYour\nYour\nmosaic');
|
||||||
|
|
||||||
|
assert.equal(resolverInputs[0]?.allowSelectedFallback, false);
|
||||||
|
assert.equal(currentText, 'Your\nmosaic');
|
||||||
|
assert.deepEqual(broadcasts, ['Your\nmosaic']);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('secondary track controller follows parsed cue timing and subtitle delay', async () => {
|
||||||
|
const broadcasts: string[] = [];
|
||||||
|
let time = 2.25;
|
||||||
|
const controller = createSecondarySubtitleTrackController({
|
||||||
|
getMpvClient: () => ({
|
||||||
|
connected: true,
|
||||||
|
requestProperty: async (name) => {
|
||||||
|
if (name === 'secondary-sid') return 2;
|
||||||
|
if (name === 'track-list') return [{ type: 'sub', id: 2 }];
|
||||||
|
if (name === 'path') return '/media/video.mkv';
|
||||||
|
if (name === 'secondary-sub-delay') return 0.5;
|
||||||
|
return null;
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
getCurrentTimePos: () => time,
|
||||||
|
resolveSubtitleSource: async () => ({ path: '/subs/english.srt', sourceKey: 'english' }),
|
||||||
|
loadSubtitleSourceText: async () => '',
|
||||||
|
parseSubtitleCues: () => [
|
||||||
|
{ startTime: 1, endTime: 2, text: 'first' },
|
||||||
|
{ startTime: 2, endTime: 3, text: 'second' },
|
||||||
|
],
|
||||||
|
setCurrentSecondaryText: () => {},
|
||||||
|
broadcastSecondaryText: (text) => broadcasts.push(text),
|
||||||
|
});
|
||||||
|
|
||||||
|
await controller.refresh();
|
||||||
|
controller.handleDelayChange(0);
|
||||||
|
time = 3.25;
|
||||||
|
controller.handleTimePos(time);
|
||||||
|
|
||||||
|
assert.deepEqual(broadcasts, ['first', 'second', '']);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('secondary track controller clears old parsed text immediately on a track change', async () => {
|
||||||
|
const broadcasts: string[] = [];
|
||||||
|
let currentText = '';
|
||||||
|
const controller = createSecondarySubtitleTrackController({
|
||||||
|
getMpvClient: () => ({
|
||||||
|
connected: true,
|
||||||
|
requestProperty: async (name) => {
|
||||||
|
if (name === 'secondary-sid') return 2;
|
||||||
|
if (name === 'track-list') return [{ type: 'sub', id: 2, external: true }];
|
||||||
|
if (name === 'path') return '/media/video.mkv';
|
||||||
|
if (name === 'secondary-sub-delay') return 0;
|
||||||
|
return null;
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
getCurrentTimePos: () => 2,
|
||||||
|
resolveSubtitleSource: async () => ({ path: '/subs/old.ass', sourceKey: 'old' }),
|
||||||
|
loadSubtitleSourceText: async () => '',
|
||||||
|
parseSubtitleCues: () => [{ startTime: 1, endTime: 3, text: 'old parsed text' }],
|
||||||
|
setCurrentSecondaryText: (text) => {
|
||||||
|
currentText = text;
|
||||||
|
},
|
||||||
|
broadcastSecondaryText: (text) => broadcasts.push(text),
|
||||||
|
});
|
||||||
|
|
||||||
|
await controller.refresh();
|
||||||
|
controller.handleTrackChange();
|
||||||
|
controller.handleLiveText('new live text');
|
||||||
|
|
||||||
|
assert.equal(currentText, 'new live text');
|
||||||
|
assert.deepEqual(broadcasts, ['old parsed text', '', 'new live text']);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('secondary track controller falls back to live mpv text without a readable source', async () => {
|
||||||
|
const broadcasts: string[] = [];
|
||||||
|
let currentText = '';
|
||||||
|
const controller = createSecondarySubtitleTrackController({
|
||||||
|
getMpvClient: () => ({
|
||||||
|
connected: true,
|
||||||
|
requestProperty: async (name) => {
|
||||||
|
if (name === 'secondary-sid') return 'no';
|
||||||
|
if (name === 'path') return '/media/video.mkv';
|
||||||
|
return null;
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
getCurrentTimePos: () => 2,
|
||||||
|
resolveSubtitleSource: async () => null,
|
||||||
|
loadSubtitleSourceText: async () => '',
|
||||||
|
parseSubtitleCues: () => [],
|
||||||
|
setCurrentSecondaryText: (text) => {
|
||||||
|
currentText = text;
|
||||||
|
},
|
||||||
|
broadcastSecondaryText: (text) => broadcasts.push(text),
|
||||||
|
});
|
||||||
|
|
||||||
|
controller.handleLiveText('live fallback');
|
||||||
|
await controller.refresh();
|
||||||
|
|
||||||
|
assert.equal(currentText, 'live fallback');
|
||||||
|
assert.deepEqual(broadcasts, ['live fallback']);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('secondary track controller reuses parsed cues for an unchanged embedded track', async () => {
|
||||||
|
let resolveCalls = 0;
|
||||||
|
let parseCalls = 0;
|
||||||
|
const controller = createSecondarySubtitleTrackController({
|
||||||
|
getMpvClient: () => ({
|
||||||
|
connected: true,
|
||||||
|
requestProperty: async (name) => {
|
||||||
|
if (name === 'secondary-sid') return 2;
|
||||||
|
if (name === 'track-list') {
|
||||||
|
return [{ type: 'sub', id: 2, external: false, 'ff-index': 3 }];
|
||||||
|
}
|
||||||
|
if (name === 'path') return '/media/video.mkv';
|
||||||
|
if (name === 'secondary-sub-delay') return 0;
|
||||||
|
return null;
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
getCurrentTimePos: () => 2,
|
||||||
|
resolveSubtitleSource: async () => {
|
||||||
|
resolveCalls += 1;
|
||||||
|
return { path: `/tmp/extracted-${resolveCalls}.ass`, sourceKey: 'embedded-track-2' };
|
||||||
|
},
|
||||||
|
loadSubtitleSourceText: async () => '',
|
||||||
|
parseSubtitleCues: () => {
|
||||||
|
parseCalls += 1;
|
||||||
|
return [{ startTime: 1, endTime: 3, text: 'parsed' }];
|
||||||
|
},
|
||||||
|
setCurrentSecondaryText: () => {},
|
||||||
|
broadcastSecondaryText: () => {},
|
||||||
|
});
|
||||||
|
|
||||||
|
await controller.refresh();
|
||||||
|
await controller.refresh();
|
||||||
|
|
||||||
|
assert.equal(resolveCalls, 1);
|
||||||
|
assert.equal(parseCalls, 1);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('secondary track controller ignores and cleans up a refresh invalidated by reset', async () => {
|
||||||
|
const broadcasts: string[] = [];
|
||||||
|
let notifyResolveStarted: (() => void) | undefined;
|
||||||
|
let releaseResolve: (() => void) | undefined;
|
||||||
|
let cleanupCalls = 0;
|
||||||
|
let parseCalls = 0;
|
||||||
|
const resolveStarted = new Promise<void>((resolve) => {
|
||||||
|
notifyResolveStarted = resolve;
|
||||||
|
});
|
||||||
|
const resolveGate = new Promise<void>((resolve) => {
|
||||||
|
releaseResolve = resolve;
|
||||||
|
});
|
||||||
|
const controller = createSecondarySubtitleTrackController({
|
||||||
|
getMpvClient: () => ({
|
||||||
|
connected: true,
|
||||||
|
requestProperty: async (name) => {
|
||||||
|
if (name === 'secondary-sid') return 2;
|
||||||
|
if (name === 'track-list') return [{ type: 'sub', id: 2, external: true }];
|
||||||
|
if (name === 'path') return '/media/video.mkv';
|
||||||
|
if (name === 'secondary-sub-delay') return 0;
|
||||||
|
return null;
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
getCurrentTimePos: () => 2,
|
||||||
|
resolveSubtitleSource: async () => {
|
||||||
|
notifyResolveStarted?.();
|
||||||
|
await resolveGate;
|
||||||
|
return {
|
||||||
|
path: '/subs/secondary.ass',
|
||||||
|
sourceKey: 'secondary',
|
||||||
|
cleanup: async () => {
|
||||||
|
cleanupCalls += 1;
|
||||||
|
},
|
||||||
|
};
|
||||||
|
},
|
||||||
|
loadSubtitleSourceText: async () => '',
|
||||||
|
parseSubtitleCues: () => {
|
||||||
|
parseCalls += 1;
|
||||||
|
return [{ startTime: 1, endTime: 3, text: 'stale' }];
|
||||||
|
},
|
||||||
|
setCurrentSecondaryText: () => {},
|
||||||
|
broadcastSecondaryText: (text) => broadcasts.push(text),
|
||||||
|
});
|
||||||
|
|
||||||
|
const refresh = controller.refresh();
|
||||||
|
await resolveStarted;
|
||||||
|
controller.reset();
|
||||||
|
releaseResolve?.();
|
||||||
|
await refresh;
|
||||||
|
|
||||||
|
assert.deepEqual(broadcasts, ['']);
|
||||||
|
assert.equal(parseCalls, 0);
|
||||||
|
assert.equal(cleanupCalls, 1);
|
||||||
|
});
|
||||||
@@ -0,0 +1,233 @@
|
|||||||
|
import type { SubtitleCue } from '../../types/subtitle';
|
||||||
|
|
||||||
|
type SecondarySubtitleMpvClient = {
|
||||||
|
connected?: boolean;
|
||||||
|
requestProperty: (name: string) => Promise<unknown>;
|
||||||
|
};
|
||||||
|
|
||||||
|
type ResolvedSubtitleSource = {
|
||||||
|
path: string;
|
||||||
|
sourceKey: string;
|
||||||
|
cleanup?: () => Promise<void>;
|
||||||
|
};
|
||||||
|
|
||||||
|
type SecondarySubtitleSourceInput = {
|
||||||
|
currentExternalFilenameRaw: unknown;
|
||||||
|
currentTrackRaw: unknown;
|
||||||
|
trackListRaw: unknown;
|
||||||
|
sidRaw: unknown;
|
||||||
|
videoPath: string;
|
||||||
|
allowSelectedFallback?: boolean;
|
||||||
|
};
|
||||||
|
|
||||||
|
const DEFAULT_REFRESH_DELAY_MS = 500;
|
||||||
|
|
||||||
|
function finiteNumber(value: unknown, fallback = 0): number {
|
||||||
|
const number = typeof value === 'number' ? value : Number(value);
|
||||||
|
return Number.isFinite(number) ? number : fallback;
|
||||||
|
}
|
||||||
|
|
||||||
|
function trackId(value: unknown): number | null {
|
||||||
|
if (typeof value !== 'number' && typeof value !== 'string') return null;
|
||||||
|
const number = typeof value === 'number' ? value : Number(value.trim());
|
||||||
|
return Number.isInteger(number) ? number : null;
|
||||||
|
}
|
||||||
|
|
||||||
|
function buildSelectedTrackIdentity(
|
||||||
|
trackListRaw: unknown,
|
||||||
|
sidRaw: unknown,
|
||||||
|
videoPath: string,
|
||||||
|
): string | null {
|
||||||
|
if (!Array.isArray(trackListRaw)) return null;
|
||||||
|
const sid = trackId(sidRaw);
|
||||||
|
if (sid === null) return null;
|
||||||
|
|
||||||
|
const selectedTrack = trackListRaw.find((entry: unknown) => {
|
||||||
|
if (!entry || typeof entry !== 'object') return false;
|
||||||
|
const track = entry as Record<string, unknown>;
|
||||||
|
return track.type === 'sub' && trackId(track.id) === sid;
|
||||||
|
}) as Record<string, unknown> | undefined;
|
||||||
|
if (!selectedTrack) return null;
|
||||||
|
|
||||||
|
return JSON.stringify([
|
||||||
|
videoPath,
|
||||||
|
sid,
|
||||||
|
selectedTrack.external === true,
|
||||||
|
selectedTrack['external-filename'] ?? null,
|
||||||
|
trackId(selectedTrack['ff-index']),
|
||||||
|
]);
|
||||||
|
}
|
||||||
|
|
||||||
|
export function findActiveSubtitleText(cues: readonly SubtitleCue[], timeSeconds: number): string {
|
||||||
|
if (!Number.isFinite(timeSeconds)) return '';
|
||||||
|
|
||||||
|
const seen = new Set<string>();
|
||||||
|
const activeText: string[] = [];
|
||||||
|
for (const cue of cues) {
|
||||||
|
if (cue.startTime > timeSeconds || cue.endTime <= timeSeconds) continue;
|
||||||
|
const text = cue.text.trim();
|
||||||
|
if (!text || seen.has(text)) continue;
|
||||||
|
seen.add(text);
|
||||||
|
activeText.push(text);
|
||||||
|
}
|
||||||
|
return activeText.join('\n');
|
||||||
|
}
|
||||||
|
|
||||||
|
export function createSecondarySubtitleTrackController(deps: {
|
||||||
|
getMpvClient: () => SecondarySubtitleMpvClient | null;
|
||||||
|
getCurrentTimePos: () => number;
|
||||||
|
resolveSubtitleSource: (
|
||||||
|
input: SecondarySubtitleSourceInput,
|
||||||
|
) => Promise<ResolvedSubtitleSource | null>;
|
||||||
|
loadSubtitleSourceText: (source: string) => Promise<string>;
|
||||||
|
parseSubtitleCues: (content: string, filename: string) => SubtitleCue[];
|
||||||
|
setCurrentSecondaryText: (text: string) => void;
|
||||||
|
broadcastSecondaryText: (text: string) => void;
|
||||||
|
logDebug?: (message: string) => void;
|
||||||
|
logWarn?: (message: string, error: unknown) => void;
|
||||||
|
}) {
|
||||||
|
let parsedCues: SubtitleCue[] | null = null;
|
||||||
|
let parsedSourceKey: string | null = null;
|
||||||
|
let parsedTrackIdentity: string | null = null;
|
||||||
|
let secondaryDelaySeconds = 0;
|
||||||
|
let lastLiveText = '';
|
||||||
|
let lastBroadcastText: string | null = null;
|
||||||
|
let refreshGeneration = 0;
|
||||||
|
let refreshTimer: ReturnType<typeof setTimeout> | null = null;
|
||||||
|
|
||||||
|
const publish = (text: string): void => {
|
||||||
|
deps.setCurrentSecondaryText(text);
|
||||||
|
if (text === lastBroadcastText) return;
|
||||||
|
lastBroadcastText = text;
|
||||||
|
deps.broadcastSecondaryText(text);
|
||||||
|
};
|
||||||
|
|
||||||
|
const resolveAtTime = (timeSeconds: number): string => {
|
||||||
|
if (!parsedCues) return lastLiveText;
|
||||||
|
return findActiveSubtitleText(parsedCues, timeSeconds - secondaryDelaySeconds);
|
||||||
|
};
|
||||||
|
|
||||||
|
const useLiveFallback = (): void => {
|
||||||
|
parsedCues = null;
|
||||||
|
parsedSourceKey = null;
|
||||||
|
parsedTrackIdentity = null;
|
||||||
|
publish(lastLiveText);
|
||||||
|
};
|
||||||
|
|
||||||
|
const refresh = async (): Promise<void> => {
|
||||||
|
const generation = ++refreshGeneration;
|
||||||
|
const client = deps.getMpvClient();
|
||||||
|
if (!client?.connected) {
|
||||||
|
useLiveFallback();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
let resolvedSource: ResolvedSubtitleSource | null = null;
|
||||||
|
try {
|
||||||
|
const [secondarySid, trackList, videoPathRaw, secondaryDelayRaw] = await Promise.all([
|
||||||
|
client.requestProperty('secondary-sid').catch(() => null),
|
||||||
|
client.requestProperty('track-list').catch(() => null),
|
||||||
|
client.requestProperty('path').catch(() => null),
|
||||||
|
client.requestProperty('secondary-sub-delay').catch(() => 0),
|
||||||
|
]);
|
||||||
|
if (generation !== refreshGeneration) return;
|
||||||
|
|
||||||
|
const videoPath = typeof videoPathRaw === 'string' ? videoPathRaw.trim() : '';
|
||||||
|
if (!videoPath || secondarySid === null || secondarySid === 'no') {
|
||||||
|
useLiveFallback();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
secondaryDelaySeconds = finiteNumber(secondaryDelayRaw);
|
||||||
|
const selectedTrackIdentity = buildSelectedTrackIdentity(trackList, secondarySid, videoPath);
|
||||||
|
if (selectedTrackIdentity && selectedTrackIdentity === parsedTrackIdentity && parsedCues) {
|
||||||
|
publish(resolveAtTime(deps.getCurrentTimePos()));
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
resolvedSource = await deps.resolveSubtitleSource({
|
||||||
|
currentExternalFilenameRaw: null,
|
||||||
|
currentTrackRaw: null,
|
||||||
|
trackListRaw: trackList,
|
||||||
|
sidRaw: secondarySid,
|
||||||
|
videoPath,
|
||||||
|
allowSelectedFallback: false,
|
||||||
|
});
|
||||||
|
if (generation !== refreshGeneration) return;
|
||||||
|
if (!resolvedSource) {
|
||||||
|
deps.logDebug?.('[secondary-subtitle-track] selected source is not readable');
|
||||||
|
useLiveFallback();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (resolvedSource.sourceKey === parsedSourceKey && parsedCues) {
|
||||||
|
parsedTrackIdentity = selectedTrackIdentity;
|
||||||
|
publish(resolveAtTime(deps.getCurrentTimePos()));
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const content = await deps.loadSubtitleSourceText(resolvedSource.path);
|
||||||
|
const cues = deps.parseSubtitleCues(content, resolvedSource.path);
|
||||||
|
if (generation !== refreshGeneration) return;
|
||||||
|
if (cues.length === 0) {
|
||||||
|
deps.logDebug?.('[secondary-subtitle-track] selected source contained no parsed cues');
|
||||||
|
useLiveFallback();
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
parsedCues = cues;
|
||||||
|
parsedSourceKey = resolvedSource.sourceKey;
|
||||||
|
parsedTrackIdentity = selectedTrackIdentity;
|
||||||
|
publish(resolveAtTime(deps.getCurrentTimePos()));
|
||||||
|
} catch (error) {
|
||||||
|
if (generation !== refreshGeneration) return;
|
||||||
|
deps.logWarn?.('[secondary-subtitle-track] failed to parse selected source', error);
|
||||||
|
useLiveFallback();
|
||||||
|
} finally {
|
||||||
|
await resolvedSource?.cleanup?.().catch(() => undefined);
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
const scheduleRefresh = (delayMs = DEFAULT_REFRESH_DELAY_MS): void => {
|
||||||
|
if (refreshTimer) clearTimeout(refreshTimer);
|
||||||
|
refreshTimer = setTimeout(() => {
|
||||||
|
refreshTimer = null;
|
||||||
|
void refresh();
|
||||||
|
}, delayMs);
|
||||||
|
};
|
||||||
|
|
||||||
|
const clearSelectedTrack = (): void => {
|
||||||
|
refreshGeneration += 1;
|
||||||
|
if (refreshTimer) clearTimeout(refreshTimer);
|
||||||
|
refreshTimer = null;
|
||||||
|
parsedCues = null;
|
||||||
|
parsedSourceKey = null;
|
||||||
|
parsedTrackIdentity = null;
|
||||||
|
secondaryDelaySeconds = 0;
|
||||||
|
lastLiveText = '';
|
||||||
|
publish('');
|
||||||
|
};
|
||||||
|
|
||||||
|
return {
|
||||||
|
refresh,
|
||||||
|
scheduleRefresh,
|
||||||
|
handleLiveText(text: string): void {
|
||||||
|
lastLiveText = text;
|
||||||
|
publish(resolveAtTime(deps.getCurrentTimePos()));
|
||||||
|
},
|
||||||
|
handleTimePos(timeSeconds: number): void {
|
||||||
|
if (!parsedCues) return;
|
||||||
|
publish(resolveAtTime(timeSeconds));
|
||||||
|
},
|
||||||
|
handleTrackChange(): void {
|
||||||
|
clearSelectedTrack();
|
||||||
|
},
|
||||||
|
handleDelayChange(delaySeconds: number): void {
|
||||||
|
secondaryDelaySeconds = finiteNumber(delaySeconds);
|
||||||
|
if (parsedCues) {
|
||||||
|
publish(resolveAtTime(deps.getCurrentTimePos()));
|
||||||
|
}
|
||||||
|
},
|
||||||
|
reset: clearSelectedTrack,
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -1,3 +1,5 @@
|
|||||||
|
import { applyOverlayClickThrough } from '../../core/services/overlay-click-through';
|
||||||
|
|
||||||
type StatsOverlayVisibilityWindow = {
|
type StatsOverlayVisibilityWindow = {
|
||||||
isDestroyed: () => boolean;
|
isDestroyed: () => boolean;
|
||||||
isVisible: () => boolean;
|
isVisible: () => boolean;
|
||||||
@@ -8,7 +10,7 @@ function makeOverlayMousePassive(window: StatsOverlayVisibilityWindow | null): v
|
|||||||
if (!window || window.isDestroyed() || !window.isVisible()) {
|
if (!window || window.isDestroyed() || !window.isVisible()) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
window.setIgnoreMouseEvents(true, { forward: true });
|
applyOverlayClickThrough(window);
|
||||||
}
|
}
|
||||||
|
|
||||||
export function createStatsOverlayVisibilityChangeHandler(deps: {
|
export function createStatsOverlayVisibilityChangeHandler(deps: {
|
||||||
|
|||||||
@@ -248,3 +248,31 @@ test('subtitle source resolver logs debug when no active subtitle track is selec
|
|||||||
assert.equal(debugs.length, 1);
|
assert.equal(debugs.length, 1);
|
||||||
assert.match(debugs[0]!, /\[subtitle-prefetch\].*no active subtitle track/);
|
assert.match(debugs[0]!, /\[subtitle-prefetch\].*no active subtitle track/);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('subtitle source resolver does not fall back to the primary selected track for secondary', async () => {
|
||||||
|
const resolveSource = createResolveActiveSubtitleSidebarSourceHandler({
|
||||||
|
getFfmpegPath: () => 'ffmpeg',
|
||||||
|
extractInternalSubtitleTrack: async () => {
|
||||||
|
throw new Error('should not extract the primary track');
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
const resolved = await resolveSource({
|
||||||
|
currentExternalFilenameRaw: null,
|
||||||
|
currentTrackRaw: null,
|
||||||
|
trackListRaw: [
|
||||||
|
{
|
||||||
|
type: 'sub',
|
||||||
|
id: 1,
|
||||||
|
selected: true,
|
||||||
|
external: true,
|
||||||
|
'external-filename': '/subs/primary.ass',
|
||||||
|
},
|
||||||
|
],
|
||||||
|
sidRaw: null,
|
||||||
|
videoPath: '/media/video.mkv',
|
||||||
|
allowSelectedFallback: false,
|
||||||
|
});
|
||||||
|
|
||||||
|
assert.equal(resolved, null);
|
||||||
|
});
|
||||||
|
|||||||
@@ -41,6 +41,7 @@ function getActiveSubtitleTrack(
|
|||||||
currentTrackRaw: unknown,
|
currentTrackRaw: unknown,
|
||||||
trackListRaw: unknown,
|
trackListRaw: unknown,
|
||||||
sidRaw: unknown,
|
sidRaw: unknown,
|
||||||
|
allowSelectedFallback: boolean,
|
||||||
): MpvSubtitleTrackLike | null {
|
): MpvSubtitleTrackLike | null {
|
||||||
if (currentTrackRaw && typeof currentTrackRaw === 'object') {
|
if (currentTrackRaw && typeof currentTrackRaw === 'object') {
|
||||||
const track = currentTrackRaw as MpvSubtitleTrackLike;
|
const track = currentTrackRaw as MpvSubtitleTrackLike;
|
||||||
@@ -68,6 +69,10 @@ function getActiveSubtitleTrack(
|
|||||||
return bySid;
|
return bySid;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (!allowSelectedFallback) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
return (
|
return (
|
||||||
(trackListRaw.find((entry: unknown) => {
|
(trackListRaw.find((entry: unknown) => {
|
||||||
if (!entry || typeof entry !== 'object') {
|
if (!entry || typeof entry !== 'object') {
|
||||||
@@ -94,6 +99,7 @@ export function createResolveActiveSubtitleSidebarSourceHandler(deps: {
|
|||||||
trackListRaw: unknown;
|
trackListRaw: unknown;
|
||||||
sidRaw: unknown;
|
sidRaw: unknown;
|
||||||
videoPath: string;
|
videoPath: string;
|
||||||
|
allowSelectedFallback?: boolean;
|
||||||
}): Promise<ActiveSubtitleSidebarSource | null> => {
|
}): Promise<ActiveSubtitleSidebarSource | null> => {
|
||||||
const currentExternalFilename =
|
const currentExternalFilename =
|
||||||
typeof input.currentExternalFilenameRaw === 'string'
|
typeof input.currentExternalFilenameRaw === 'string'
|
||||||
@@ -103,7 +109,12 @@ export function createResolveActiveSubtitleSidebarSourceHandler(deps: {
|
|||||||
return { path: currentExternalFilename, sourceKey: currentExternalFilename };
|
return { path: currentExternalFilename, sourceKey: currentExternalFilename };
|
||||||
}
|
}
|
||||||
|
|
||||||
const track = getActiveSubtitleTrack(input.currentTrackRaw, input.trackListRaw, input.sidRaw);
|
const track = getActiveSubtitleTrack(
|
||||||
|
input.currentTrackRaw,
|
||||||
|
input.trackListRaw,
|
||||||
|
input.sidRaw,
|
||||||
|
input.allowSelectedFallback !== false,
|
||||||
|
);
|
||||||
if (!track) {
|
if (!track) {
|
||||||
deps.logDebug?.('[subtitle-prefetch] no active subtitle track selected yet');
|
deps.logDebug?.('[subtitle-prefetch] no active subtitle track selected yet');
|
||||||
return null;
|
return null;
|
||||||
|
|||||||
@@ -31,6 +31,20 @@ function makeSpawn(): { spawn: SyncLauncherSpawn; children: FakeChild[]; command
|
|||||||
return { spawn, children, commands };
|
return { spawn, children, commands };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async function waitForResult<T>(promise: Promise<T>, timeoutMs = 3000): Promise<T> {
|
||||||
|
let timeout: ReturnType<typeof setTimeout> | null = null;
|
||||||
|
try {
|
||||||
|
return await Promise.race([
|
||||||
|
promise,
|
||||||
|
new Promise<never>((_, reject) => {
|
||||||
|
timeout = setTimeout(() => reject(new Error('Timed out waiting for result.')), timeoutMs);
|
||||||
|
}),
|
||||||
|
]);
|
||||||
|
} finally {
|
||||||
|
if (timeout !== null) clearTimeout(timeout);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
test('runSyncLauncher parses NDJSON events across chunk boundaries', async () => {
|
test('runSyncLauncher parses NDJSON events across chunk boundaries', async () => {
|
||||||
const { spawn, children, commands } = makeSpawn();
|
const { spawn, children, commands } = makeSpawn();
|
||||||
const events: SyncProgressEvent[] = [];
|
const events: SyncProgressEvent[] = [];
|
||||||
@@ -96,7 +110,9 @@ test('runSyncLauncher settles after exit when close never arrives', async () =>
|
|||||||
// so `close` never fires.
|
// so `close` never fires.
|
||||||
child.emit('exit', 1, null);
|
child.emit('exit', 1, null);
|
||||||
|
|
||||||
const result = await handle.done;
|
// Keep the isolated Bun test process alive while the production drain timer
|
||||||
|
// remains unref'ed, and fail instead of hanging if the result never settles.
|
||||||
|
const result = await waitForResult(handle.done);
|
||||||
assert.equal(result.ok, false);
|
assert.equal(result.ok, false);
|
||||||
assert.match(result.error ?? '', /remote refused/);
|
assert.match(result.error ?? '', /remote refused/);
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -66,7 +66,7 @@ export function runSyncLauncher(options: {
|
|||||||
spawn?: SyncLauncherSpawn;
|
spawn?: SyncLauncherSpawn;
|
||||||
timeoutMs?: number;
|
timeoutMs?: number;
|
||||||
}): SyncLauncherRunHandle {
|
}): SyncLauncherRunHandle {
|
||||||
const spawn =
|
const spawn: SyncLauncherSpawn =
|
||||||
options.spawn ??
|
options.spawn ??
|
||||||
((command, args) => {
|
((command, args) => {
|
||||||
// The child must boot as a full Electron app (its entry handles
|
// The child must boot as a full Electron app (its entry handles
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
import { type BrowserWindow, screen } from 'electron';
|
import { type BrowserWindow, screen } from 'electron';
|
||||||
import { execFile } from 'node:child_process';
|
import { execFile } from 'node:child_process';
|
||||||
import { startOverlayWindowTracker as startOverlayWindowTrackerCore } from '../../core/services';
|
import { startOverlayWindowTracker as startOverlayWindowTrackerCore } from '../../core/services';
|
||||||
|
import { applyOverlayClickThrough } from '../../core/services/overlay-click-through';
|
||||||
import { isHeadlessInitialCommand, type CliArgs } from '../../cli/args';
|
import { isHeadlessInitialCommand, type CliArgs } from '../../cli/args';
|
||||||
import type { OverlayContentMeasurement, WindowGeometry } from '../../types';
|
import type { OverlayContentMeasurement, WindowGeometry } from '../../types';
|
||||||
import { createWindowTracker as createWindowTrackerCore } from '../../window-trackers';
|
import { createWindowTracker as createWindowTrackerCore } from '../../window-trackers';
|
||||||
@@ -603,7 +604,7 @@ export function createVisibleOverlayInteractionRuntime(deps: VisibleOverlayInter
|
|||||||
if (active) {
|
if (active) {
|
||||||
mainWindow.setIgnoreMouseEvents(false);
|
mainWindow.setIgnoreMouseEvents(false);
|
||||||
} else {
|
} else {
|
||||||
mainWindow.setIgnoreMouseEvents(true, { forward: true });
|
applyOverlayClickThrough(mainWindow);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -1434,6 +1434,18 @@ test('prepareSecondarySubtitleLines collapses karaoke syllable spam into one ded
|
|||||||
assert.deepEqual(prepareSecondarySubtitleLines(karaoke), ['ya This no ma ups']);
|
assert.deepEqual(prepareSecondarySubtitleLines(karaoke), ['ya This no ma ups']);
|
||||||
});
|
});
|
||||||
|
|
||||||
|
test('prepareSecondarySubtitleLines preserves repeated short dialogue without layer metadata', () => {
|
||||||
|
const dialogue = ['Wait', 'Wait', 'Wait'];
|
||||||
|
|
||||||
|
assert.deepEqual(prepareSecondarySubtitleLines(dialogue.join('\\N')), dialogue);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('prepareSecondarySubtitleLines preserves short simultaneous dialogue without repeats', () => {
|
||||||
|
const dialogue = ['Wait', 'Go!', 'No!', 'Run!'];
|
||||||
|
|
||||||
|
assert.deepEqual(prepareSecondarySubtitleLines(dialogue.join('\\N')), dialogue);
|
||||||
|
});
|
||||||
|
|
||||||
test('prepareSecondarySubtitleLines keeps normal dialogue lines intact', () => {
|
test('prepareSecondarySubtitleLines keeps normal dialogue lines intact', () => {
|
||||||
const dialogue = ' I never expected this. \\N\\N But here we are. ';
|
const dialogue = ' I never expected this. \\N\\N But here we are. ';
|
||||||
|
|
||||||
|
|||||||
+102
-30
@@ -1,4 +1,4 @@
|
|||||||
import { execFileSync } from 'node:child_process';
|
import { execFile } from 'node:child_process';
|
||||||
import koffi from 'koffi';
|
import koffi from 'koffi';
|
||||||
import { matchesMpvSocketPathInCommandLine } from './mpv-socket-match';
|
import { matchesMpvSocketPathInCommandLine } from './mpv-socket-match';
|
||||||
|
|
||||||
@@ -173,16 +173,52 @@ function getProcessNameByPid(pid: number): string | null {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
const processCommandLineCache = new Map<number, string>();
|
// Short-lived cache so the 250ms poll doesn't re-query every top-level window's process
|
||||||
|
// on each pass. The TTL bounds staleness from PID reuse.
|
||||||
|
const PROCESS_NAME_CACHE_TTL_MS = 5_000;
|
||||||
|
const PROCESS_NAME_CACHE_PRUNE_THRESHOLD = 512;
|
||||||
|
const processNameCache = new Map<number, { name: string | null; expiresAtMs: number }>();
|
||||||
|
|
||||||
function getProcessCommandLineByPid(pid: number): string | null {
|
function getCachedProcessNameByPid(pid: number): string | null {
|
||||||
if (processCommandLineCache.has(pid)) {
|
const nowMs = Date.now();
|
||||||
return processCommandLineCache.get(pid) ?? null;
|
const cached = processNameCache.get(pid);
|
||||||
|
if (cached && cached.expiresAtMs > nowMs) {
|
||||||
|
return cached.name;
|
||||||
|
}
|
||||||
|
const name = getProcessNameByPid(pid);
|
||||||
|
processNameCache.set(pid, { name, expiresAtMs: nowMs + PROCESS_NAME_CACHE_TTL_MS });
|
||||||
|
return name;
|
||||||
}
|
}
|
||||||
|
|
||||||
let commandLine: string | null = null;
|
function pruneExpiredProcessNames(nowMs: number): void {
|
||||||
try {
|
if (processNameCache.size <= PROCESS_NAME_CACHE_PRUNE_THRESHOLD) return;
|
||||||
const output = execFileSync(
|
for (const [pid, entry] of processNameCache) {
|
||||||
|
if (entry.expiresAtMs <= nowMs) {
|
||||||
|
processNameCache.delete(pid);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
type ProcessCommandLineCacheEntry =
|
||||||
|
| { state: 'resolved'; commandLine: string; expiresAtMs: number; refreshInFlight: boolean }
|
||||||
|
| { state: 'pending' }
|
||||||
|
| { state: 'failed'; retryAtMs: number; backoffMs: number };
|
||||||
|
|
||||||
|
const COMMAND_LINE_RETRY_INITIAL_BACKOFF_MS = 2_000;
|
||||||
|
const COMMAND_LINE_RETRY_MAX_BACKOFF_MS = 30_000;
|
||||||
|
// A process command line never changes, so a resolved entry only has to expire to survive
|
||||||
|
// Windows PID reuse (a dead mpv's PID handed to a new instance, whose stale socket path would
|
||||||
|
// otherwise match the wrong window forever). Longer than the process-name TTL because each
|
||||||
|
// refresh costs a PowerShell spawn, and the cached value keeps being served while the refresh
|
||||||
|
// runs, so expiry never interrupts window matching.
|
||||||
|
const COMMAND_LINE_CACHE_TTL_MS = 60_000;
|
||||||
|
const processCommandLineCache = new Map<number, ProcessCommandLineCacheEntry>();
|
||||||
|
|
||||||
|
function queryProcessCommandLine(
|
||||||
|
pid: number,
|
||||||
|
onResult: (commandLine: string | null) => void,
|
||||||
|
): void {
|
||||||
|
execFile(
|
||||||
'powershell.exe',
|
'powershell.exe',
|
||||||
[
|
[
|
||||||
'-NoProfile',
|
'-NoProfile',
|
||||||
@@ -195,21 +231,67 @@ function getProcessCommandLineByPid(pid: number): string | null {
|
|||||||
{
|
{
|
||||||
encoding: 'utf8',
|
encoding: 'utf8',
|
||||||
windowsHide: true,
|
windowsHide: true,
|
||||||
stdio: ['ignore', 'pipe', 'ignore'],
|
|
||||||
timeout: 1500,
|
timeout: 1500,
|
||||||
},
|
},
|
||||||
).trim();
|
(error, stdout) => {
|
||||||
commandLine = output.length > 0 ? output : null;
|
const output = error ? '' : stdout.trim();
|
||||||
} catch {
|
onResult(output.length > 0 ? output : null);
|
||||||
commandLine = null;
|
},
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
if (commandLine !== null) {
|
// Resolves a process command line via a background PowerShell lookup. Returns null until the
|
||||||
processCommandLineCache.set(pid, commandLine);
|
// first lookup completes; the caller's next poll picks up the cached result. Failures are
|
||||||
} else {
|
// negative-cached with exponential backoff: the synchronous version of this lookup could
|
||||||
processCommandLineCache.delete(pid);
|
// block the main thread for its full 1.5s timeout on every 250ms poll, which (combined with
|
||||||
|
// the forward:true mouse hook) stalled mouse input system-wide.
|
||||||
|
function getProcessCommandLineByPid(pid: number): string | null {
|
||||||
|
const entry = processCommandLineCache.get(pid);
|
||||||
|
const nowMs = Date.now();
|
||||||
|
|
||||||
|
if (entry?.state === 'resolved') {
|
||||||
|
if (nowMs >= entry.expiresAtMs && !entry.refreshInFlight) {
|
||||||
|
entry.refreshInFlight = true;
|
||||||
|
queryProcessCommandLine(pid, (commandLine) => {
|
||||||
|
processCommandLineCache.set(pid, {
|
||||||
|
state: 'resolved',
|
||||||
|
// A failed refresh is usually a transient query error rather than a dead process
|
||||||
|
// (a gone process owns no window, so it is never looked up again). Keep the last
|
||||||
|
// known command line and re-check after the next TTL.
|
||||||
|
commandLine: commandLine ?? entry.commandLine,
|
||||||
|
expiresAtMs: Date.now() + COMMAND_LINE_CACHE_TTL_MS,
|
||||||
|
refreshInFlight: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
}
|
}
|
||||||
return commandLine;
|
return entry.commandLine;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (entry?.state === 'pending') return null;
|
||||||
|
if (entry?.state === 'failed' && nowMs < entry.retryAtMs) return null;
|
||||||
|
|
||||||
|
const nextBackoffMs =
|
||||||
|
entry?.state === 'failed'
|
||||||
|
? Math.min(entry.backoffMs * 2, COMMAND_LINE_RETRY_MAX_BACKOFF_MS)
|
||||||
|
: COMMAND_LINE_RETRY_INITIAL_BACKOFF_MS;
|
||||||
|
processCommandLineCache.set(pid, { state: 'pending' });
|
||||||
|
queryProcessCommandLine(pid, (commandLine) => {
|
||||||
|
if (commandLine !== null) {
|
||||||
|
processCommandLineCache.set(pid, {
|
||||||
|
state: 'resolved',
|
||||||
|
commandLine,
|
||||||
|
expiresAtMs: Date.now() + COMMAND_LINE_CACHE_TTL_MS,
|
||||||
|
refreshInFlight: false,
|
||||||
|
});
|
||||||
|
} else {
|
||||||
|
processCommandLineCache.set(pid, {
|
||||||
|
state: 'failed',
|
||||||
|
retryAtMs: Date.now() + nextBackoffMs,
|
||||||
|
backoffMs: nextBackoffMs,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
});
|
||||||
|
return null;
|
||||||
}
|
}
|
||||||
|
|
||||||
export function findMpvWindows(targetSocketPath?: string | null): MpvPollResult {
|
export function findMpvWindows(targetSocketPath?: string | null): MpvPollResult {
|
||||||
@@ -217,8 +299,7 @@ export function findMpvWindows(targetSocketPath?: string | null): MpvPollResult
|
|||||||
const matches: MpvWindowMatch[] = [];
|
const matches: MpvWindowMatch[] = [];
|
||||||
let hasMinimized = false;
|
let hasMinimized = false;
|
||||||
let hasFocused = false;
|
let hasFocused = false;
|
||||||
const processNameCache = new Map<number, string | null>();
|
pruneExpiredProcessNames(Date.now());
|
||||||
const processCommandLineLookupCache = new Map<number, string | null>();
|
|
||||||
|
|
||||||
const cb = koffi.register((hwnd: number, _lParam: number) => {
|
const cb = koffi.register((hwnd: number, _lParam: number) => {
|
||||||
if (!IsWindowVisible(hwnd)) return true;
|
if (!IsWindowVisible(hwnd)) return true;
|
||||||
@@ -228,21 +309,12 @@ export function findMpvWindows(targetSocketPath?: string | null): MpvPollResult
|
|||||||
const pidValue = pid[0]!;
|
const pidValue = pid[0]!;
|
||||||
if (pidValue === 0) return true;
|
if (pidValue === 0) return true;
|
||||||
|
|
||||||
let processName = processNameCache.get(pidValue);
|
const processName = getCachedProcessNameByPid(pidValue);
|
||||||
if (processName === undefined) {
|
|
||||||
processName = getProcessNameByPid(pidValue);
|
|
||||||
processNameCache.set(pidValue, processName);
|
|
||||||
}
|
|
||||||
|
|
||||||
if (!processName || processName.toLowerCase() !== 'mpv') return true;
|
if (!processName || processName.toLowerCase() !== 'mpv') return true;
|
||||||
|
|
||||||
let commandLine: string | null = null;
|
let commandLine: string | null = null;
|
||||||
if (targetSocketPath) {
|
if (targetSocketPath) {
|
||||||
commandLine = processCommandLineLookupCache.get(pidValue) ?? null;
|
|
||||||
if (!processCommandLineLookupCache.has(pidValue)) {
|
|
||||||
commandLine = getProcessCommandLineByPid(pidValue);
|
commandLine = getProcessCommandLineByPid(pidValue);
|
||||||
processCommandLineLookupCache.set(pidValue, commandLine);
|
|
||||||
}
|
|
||||||
if (!commandLine || !matchesMpvSocketPathInCommandLine(commandLine, targetSocketPath)) {
|
if (!commandLine || !matchesMpvSocketPathInCommandLine(commandLine, targetSocketPath)) {
|
||||||
return true;
|
return true;
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user