sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-02-27 18:22:41 -08:00
Code Issues Packages Projects Releases Wiki Activity

Address Claude review feedback

Browse Source
This commit is contained in:
Kyle Yasuda
2026-02-15 23:36:06 -08:00
parent 8e9d392b21
commit f21fc95d17
7 changed files with 224 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/renderer/subtitle-render.ts
View File

@@ -83,8 +83,9 @@ function getFrequencyDictionaryClass(
}
if (settings.mode === "banded") {
const normalizedBand = Math.ceil((rank / topX) * 5);
const band = Math.min(5, Math.max(1, normalizedBand));
const bandCount = settings.bandedColors.length;
const normalizedBand = Math.ceil((rank / topX) * bandCount);
const band = Math.min(bandCount, Math.max(1, normalizedBand));
return `word-frequency-band-${band}`;
}
@@ -183,12 +184,14 @@ export function computeWordClass(
classes.push(`word-jlpt-${token.jlptLevel.toLowerCase()}`);
}
const frequencyClass = getFrequencyDictionaryClass(
token,
resolvedFrequencySettings,
);
if (frequencyClass) {
classes.push(frequencyClass);
if (!token.isKnown && !token.isNPlusOneTarget) {
const frequencyClass = getFrequencyDictionaryClass(
token,
resolvedFrequencySettings,
);
if (frequencyClass) {
classes.push(frequencyClass);
}
}
return classes.join(" ");