Address Claude review feedback

src/renderer/subtitle-render.test.ts

@@ -53,6 +53,54 @@ test("computeWordClass preserves known and n+1 classes while adding JLPT classes
   );
 });
 
+test("computeWordClass does not add frequency class to known or N+1 terms", () => {
+  const known = createToken({
+    isKnown: true,
+    frequencyRank: 10,
+    surface: "既知",
+  });
+  const nPlusOne = createToken({
+    isNPlusOneTarget: true,
+    frequencyRank: 10,
+    surface: "目標",
+  });
+  const frequency = createToken({
+    frequencyRank: 10,
+    surface: "頻度",
+  });
+
+  assert.equal(
+    computeWordClass(known, {
+      enabled: true,
+      topX: 100,
+      mode: "single",
+      singleColor: "#000000",
+      bandedColors: ["#000000", "#000000", "#000000", "#000000", "#000000"] as const,
+    }),
+    "word word-known",
+  );
+  assert.equal(
+    computeWordClass(nPlusOne, {
+      enabled: true,
+      topX: 100,
+      mode: "single",
+      singleColor: "#000000",
+      bandedColors: ["#000000", "#000000", "#000000", "#000000", "#000000"] as const,
+    }),
+    "word word-n-plus-one",
+  );
+  assert.equal(
+    computeWordClass(frequency, {
+      enabled: true,
+      topX: 100,
+      mode: "single",
+      singleColor: "#000000",
+      bandedColors: ["#000000", "#000000", "#000000", "#000000", "#000000"] as const,
+    }),
+    "word word-frequency-single",
+  );
+});
+
 test("computeWordClass adds frequency class for single mode when rank is within topX", () => {
   const token = createToken({
     surface: "猫",
@@ -114,6 +162,23 @@ test("computeWordClass adds frequency class for banded mode", () => {
   assert.equal(actual, "word word-frequency-band-2");
 });
 
+test("computeWordClass uses configured band count for banded mode", () => {
+  const token = createToken({
+    surface: "犬",
+    frequencyRank: 2,
+  });
+
+  const actual = computeWordClass(token, {
+    enabled: true,
+    topX: 4,
+    mode: "banded",
+    singleColor: "#000000",
+    bandedColors: ["#111111", "#222222", "#333333"] as any,
+  } as any);
+
+  assert.equal(actual, "word word-frequency-band-1");
+});
+
 test("computeWordClass skips frequency class when rank is out of topX", () => {
   const token = createToken({
     surface: "犬",

src/renderer/subtitle-render.ts

@@ -83,8 +83,9 @@ function getFrequencyDictionaryClass(
   }
 
   if (settings.mode === "banded") {
-    const normalizedBand = Math.ceil((rank / topX) * 5);
-    const band = Math.min(5, Math.max(1, normalizedBand));
+    const bandCount = settings.bandedColors.length;
+    const normalizedBand = Math.ceil((rank / topX) * bandCount);
+    const band = Math.min(bandCount, Math.max(1, normalizedBand));
     return `word-frequency-band-${band}`;
   }
 
@@ -183,12 +184,14 @@ export function computeWordClass(
     classes.push(`word-jlpt-${token.jlptLevel.toLowerCase()}`);
   }
 
-  const frequencyClass = getFrequencyDictionaryClass(
-    token,
-    resolvedFrequencySettings,
-  );
-  if (frequencyClass) {
-    classes.push(frequencyClass);
+  if (!token.isKnown && !token.isNPlusOneTarget) {
+    const frequencyClass = getFrequencyDictionaryClass(
+      token,
+      resolvedFrequencySettings,
+    );
+    if (frequencyClass) {
+      classes.push(frequencyClass);
+    }
   }
 
   return classes.join(" ");