fix(jellyfin): fix discovery loop, device identity, tray state, and Disc

- Derive device identity from OS hostname; remove legacy configurable client/device fields
- Prevent discovery playback from reloading active item, misreporting pause state, and duplicate overlay restores
- Restart stale tray discovery sessions without re-login when server drops SubMiner cast target
- Sync tray discovery checkbox state on Linux after CLI/startup/remote-session changes
- Stop Discord presence falling back to stream URLs; prime title before tokenized stream loads
- Fix picker library discovery when log level is above info
- Fix config.example.jsonc trailing commas and array formatting

src/main/runtime/jellyfin-remote-session-lifecycle.test.ts

@@ -13,10 +13,6 @@ function createConfig(overrides?: Partial<Record<string, unknown>>) {
     serverUrl: 'http://localhost',
     accessToken: 'token',
     userId: 'user-id',
-    deviceId: '',
-    clientName: '',
-    clientVersion: '',
-    remoteControlDeviceName: '',
     autoAnnounce: false,
     ...(overrides || {}),
   } as never;
@@ -39,6 +35,12 @@ test('start handler no-ops when jellyfin integration is disabled', async () => {
     defaultDeviceId: 'default-device',
     defaultClientName: 'SubMiner',
     defaultClientVersion: '1.0',
+    getClientInfo: () => ({
+      deviceId: 'workstation',
+      clientName: 'SubMiner',
+      clientVersion: '1.0',
+    }),
+    getHostName: () => 'workstation',
     handlePlay: async () => {},
     handlePlaystate: async () => {},
     handleGeneralCommand: async () => {},
@@ -67,6 +69,12 @@ test('start handler no-ops when remote control is disabled', async () => {
     defaultDeviceId: 'default-device',
     defaultClientName: 'SubMiner',
     defaultClientVersion: '1.0',
+    getClientInfo: () => ({
+      deviceId: 'workstation',
+      clientName: 'SubMiner',
+      clientVersion: '1.0',
+    }),
+    getHostName: () => 'workstation',
     handlePlay: async () => {},
     handlePlaystate: async () => {},
     handleGeneralCommand: async () => {},
@@ -95,6 +103,12 @@ test('start handler respects auto-connect unless explicit start is requested', a
     defaultDeviceId: 'default-device',
     defaultClientName: 'SubMiner',
     defaultClientVersion: '1.0',
+    getClientInfo: () => ({
+      deviceId: 'workstation',
+      clientName: 'SubMiner',
+      clientVersion: '1.0',
+    }),
+    getHostName: () => 'workstation',
     handlePlay: async () => {},
     handlePlaystate: async () => {},
     handleGeneralCommand: async () => {},
@@ -117,6 +131,7 @@ test('start handler creates, starts, and stores session', async () => {
   } | null = null;
   let started = false;
   const infos: string[] = [];
+  let stateChanges = 0;
   const startRemote = createStartJellyfinRemoteSessionHandler({
     getJellyfinConfig: () => createConfig({ clientName: 'Desk' }),
     getCurrentSession: () => null,
@@ -124,7 +139,7 @@ test('start handler creates, starts, and stores session', async () => {
       storedSession = session as never;
     },
     createRemoteSessionService: (options) => {
-      assert.equal(options.deviceName, 'Desk');
+      assert.equal(options.deviceName, 'workstation');
       return {
         start: () => {
           started = true;
@@ -136,18 +151,119 @@ test('start handler creates, starts, and stores session', async () => {
     defaultDeviceId: 'default-device',
     defaultClientName: 'SubMiner',
     defaultClientVersion: '1.0',
+    getClientInfo: () => ({
+      deviceId: 'workstation',
+      clientName: 'SubMiner',
+      clientVersion: '1.0',
+    }),
+    getHostName: () => 'workstation',
     handlePlay: async () => {},
     handlePlaystate: async () => {},
     handleGeneralCommand: async () => {},
     logInfo: (message) => infos.push(message),
     logWarn: () => {},
+    onSessionStateChanged: () => {
+      stateChanges += 1;
+    },
   });
 
   await startRemote();
 
   assert.equal(started, true);
   assert.ok(storedSession);
-  assert.ok(infos.some((line) => line.includes('Jellyfin remote session enabled (Desk).')));
+  assert.equal(stateChanges, 1);
+  assert.ok(infos.some((line) => line.includes('Jellyfin remote session enabled (workstation).')));
+});
+
+test('start handler uses hostname-derived client info and visible device name', async () => {
+  let createdOptions: {
+    deviceId: string;
+    clientName: string;
+    clientVersion: string;
+    deviceName: string;
+  } | null = null;
+  const startRemote = createStartJellyfinRemoteSessionHandler({
+    getJellyfinConfig: () =>
+      createConfig({
+        clientName: 'SubMiner',
+      }),
+    getClientInfo: () => ({
+      deviceId: 'kyle-pc',
+      clientName: 'SubMiner',
+      clientVersion: '0.1.0',
+    }),
+    getHostName: () => 'kyle-pc',
+    getCurrentSession: () => null,
+    setCurrentSession: () => {},
+    createRemoteSessionService: (options) => {
+      createdOptions = {
+        deviceId: options.deviceId,
+        clientName: options.clientName,
+        clientVersion: options.clientVersion,
+        deviceName: options.deviceName,
+      };
+      return {
+        start: () => {},
+        stop: () => {},
+        advertiseNow: async () => true,
+      };
+    },
+    defaultDeviceId: 'subminer',
+    defaultClientName: 'SubMiner',
+    defaultClientVersion: '0.1.0',
+    handlePlay: async () => {},
+    handlePlaystate: async () => {},
+    handleGeneralCommand: async () => {},
+    logInfo: () => {},
+    logWarn: () => {},
+  });
+
+  await startRemote({ explicit: true });
+
+  assert.deepEqual(createdOptions, {
+    deviceId: 'kyle-pc',
+    clientName: 'SubMiner',
+    clientVersion: '0.1.0',
+    deviceName: 'kyle-pc',
+  });
+});
+
+test('start handler ignores configured visible device name', async () => {
+  let createdDeviceName = '';
+  const startRemote = createStartJellyfinRemoteSessionHandler({
+    getJellyfinConfig: () =>
+      createConfig({
+        remoteControlDeviceName: 'SubMiner Cachy sudacode',
+      }),
+    getClientInfo: () => ({
+      deviceId: 'cachy',
+      clientName: 'SubMiner',
+      clientVersion: '0.1.0',
+    }),
+    getHostName: () => 'cachy',
+    getCurrentSession: () => null,
+    setCurrentSession: () => {},
+    createRemoteSessionService: (options) => {
+      createdDeviceName = options.deviceName;
+      return {
+        start: () => {},
+        stop: () => {},
+        advertiseNow: async () => true,
+      };
+    },
+    defaultDeviceId: 'subminer',
+    defaultClientName: 'SubMiner',
+    defaultClientVersion: '0.1.0',
+    handlePlay: async () => {},
+    handlePlaystate: async () => {},
+    handleGeneralCommand: async () => {},
+    logInfo: () => {},
+    logWarn: () => {},
+  });
+
+  await startRemote({ explicit: true });
+
+  assert.equal(createdDeviceName, 'cachy');
 });
 
 test('start handler stops previous session before replacing', async () => {
@@ -175,6 +291,12 @@ test('start handler stops previous session before replacing', async () => {
     defaultDeviceId: 'default-device',
     defaultClientName: 'SubMiner',
     defaultClientVersion: '1.0',
+    getClientInfo: () => ({
+      deviceId: 'workstation',
+      clientName: 'SubMiner',
+      clientVersion: '1.0',
+    }),
+    getHostName: () => 'workstation',
     handlePlay: async () => {},
     handlePlaystate: async () => {},
     handleGeneralCommand: async () => {},
@@ -189,6 +311,7 @@ test('start handler stops previous session before replacing', async () => {
 test('stop handler stops active session and clears playback', () => {
   let stopCalls = 0;
   let clearCalls = 0;
+  let stateChanges = 0;
   let currentSession: { stop: () => void } | null = {
     stop: () => {
       stopCalls += 1;
@@ -203,10 +326,14 @@ test('stop handler stops active session and clears playback', () => {
     clearActivePlayback: () => {
       clearCalls += 1;
     },
+    onSessionStateChanged: () => {
+      stateChanges += 1;
+    },
   });
 
   stopRemote();
   assert.equal(stopCalls, 1);
   assert.equal(clearCalls, 1);
   assert.equal(currentSession, null);
+  assert.equal(stateChanges, 1);
 });