diff --git a/.agents/skills/subminer-change-verification/SKILL.md b/.agents/skills/subminer-change-verification/SKILL.md index 3a78d552..63771261 100644 --- a/.agents/skills/subminer-change-verification/SKILL.md +++ b/.agents/skills/subminer-change-verification/SKILL.md @@ -18,5 +18,5 @@ When this shim is invoked: 1. Read the canonical plugin-owned skill. 2. Follow the plugin-owned skill as the source of truth. -3. Use the wrapper scripts in this shim directory only for compatibility with existing commands, docs, and backlog history. +3. Use the wrapper scripts in this shim directory only for compatibility with existing commands and docs. 4. Do not duplicate workflow changes here; update the plugin-owned skill and scripts instead. diff --git a/AGENTS.md b/AGENTS.md index 8f7fa589..0a5fbdfd 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -64,32 +64,3 @@ Start here, then leave this file. - CI red: `gh run list/view`, rerun, fix, repeat until green - TypeScript: keep files small; follow existing patterns - Swift: use workspace helper/daemon; validate `swift build` + tests - - - - - -## BACKLOG WORKFLOW INSTRUCTIONS - -This project uses Backlog.md MCP for all task and project management activities. - -**CRITICAL GUIDANCE** - -- If your client supports MCP resources, read `backlog://workflow/overview` to understand when and how to use Backlog for this project. -- If your client only supports tools or the above request fails, call `backlog.get_workflow_overview()` tool to load the tool-oriented overview (it lists the matching guide tools). - -- **First time working here?** Read the overview resource IMMEDIATELY to learn the workflow -- **Already familiar?** You should have the overview cached ("## Backlog.md Overview (MCP)") -- **When to read it**: BEFORE creating tasks, or when you're unsure whether to track work - -These guides cover: -- Decision framework for when to create tasks -- Search-first workflow to avoid duplicates -- Links to detailed guides for task creation, execution, and finalization -- MCP tools reference - -You MUST read the overview resource to understand the complete workflow. The information is NOT summarized here. - - - - diff --git a/Backlog.md b/Backlog.md deleted file mode 100644 index 9beed539..00000000 --- a/Backlog.md +++ /dev/null @@ -1,266 +0,0 @@ -# Backlog - -Purpose: lightweight repo-local task board. Seeded with current testing / coverage work. - -Status keys: - -- `todo`: not started -- `doing`: in progress -- `blocked`: waiting -- `done`: shipped - -Priority keys: - -- `P0`: urgent / release-risk -- `P1`: high value -- `P2`: useful cleanup -- `P3`: nice-to-have - -## Active - -| ID | Pri | Status | Area | Title | -| ------ | --- | ------ | -------------- | --------------------------------------------------- | -| SM-013 | P1 | done | review-followup | Address PR #36 CodeRabbit action items | - -## Ready - -| ID | Pri | Status | Area | Title | -| ------ | --- | ------ | ----------------- | ---------------------------------------------------------------- | -| SM-001 | P1 | todo | launcher | Add tests for CLI parser and args normalizer | -| SM-002 | P1 | todo | immersion-tracker | Backfill tests for uncovered query exports | -| SM-003 | P1 | todo | anki | Add focused field-grouping service + merge edge-case tests | -| SM-004 | P2 | todo | tests | Extract shared test utils for deps factories and polling helpers | -| SM-005 | P2 | todo | tests | Strengthen weak assertions in app-ready and IPC tests | -| SM-006 | P2 | todo | tests | Break up monolithic youtube-flow and subtitle-sidebar tests | -| SM-007 | P2 | todo | anilist | Add tests for AniList rate limiter | -| SM-008 | P3 | todo | subtitles | Add core subtitle-position persistence/path tests | -| SM-009 | P3 | todo | tokenizer | Add tests for JLPT token filter | -| SM-010 | P1 | todo | immersion-tracker | Refactor storage + immersion-tracker service into focused modules | -| SM-011 | P1 | done | tests | Add coverage reporting for maintained test lanes | -| SM-012 | P2 | done | config/runtime | Replace JSON serialize-clone helpers with structured cloning | - -## Icebox - -None. - -## Ticket Details - -### SM-001 - -Title: Add tests for CLI parser and args normalizer -Priority: P1 -Status: done -Scope: - -- `launcher/config/cli-parser-builder.ts` -- `launcher/config/args-normalizer.ts` - Acceptance: -- root options parsing covered -- subcommand routing covered -- invalid action / invalid log level / invalid backend cases covered -- target classification covered: file, directory, URL, invalid - -### SM-002 - -Title: Backfill tests for uncovered query exports -Priority: P1 -Status: todo -Scope: - -- `src/core/services/immersion-tracker/query-*.ts` - Targets: -- headword helpers -- anime/media detail helpers not covered by existing wrapper tests -- lexical detail / appearance helpers -- maintenance helpers beyond `deleteSession` and `upsertCoverArt` - Acceptance: -- every exported query helper either directly tested or explicitly justified as covered elsewhere -- at least one focused regression per complex SQL branch / aggregation branch - -### SM-003 - -Title: Add focused field-grouping service + merge edge-case tests -Priority: P1 -Status: todo -Scope: - -- `src/anki-integration/field-grouping.ts` -- `src/anki-integration/field-grouping-merge.ts` - Acceptance: -- auto/manual/disabled flow branches covered -- duplicate-card preview failure path covered -- merge edge cases covered: empty fields, generated media fallback, strict grouped spans, audio synchronization - -### SM-004 - -Title: Extract shared test utils for deps factories and polling helpers -Priority: P2 -Status: todo -Scope: - -- common `makeDeps` / `createDeps` helpers -- common `waitForCondition` - Acceptance: -- shared helper module added -- at least 3 duplicated polling helpers removed -- at least 5 duplicated deps factories consolidated or clearly prepared for follow-up migration - -### SM-005 - -Title: Strengthen weak assertions in app-ready and IPC tests -Priority: P2 -Status: todo -Scope: - -- `src/core/services/app-ready.test.ts` -- `src/core/services/ipc.test.ts` - Acceptance: -- replace broad `assert.ok(...)` presence checks with exact value / order assertions where expected value known -- handler registration tests assert channel-specific behavior, not only existence - -### SM-006 - -Title: Break up monolithic youtube-flow and subtitle-sidebar tests -Priority: P2 -Status: todo -Scope: - -- `src/main/runtime/youtube-flow.test.ts` -- `src/renderer/modals/subtitle-sidebar.test.ts` - Acceptance: -- reduce single-test breadth -- split largest tests into focused cases by behavior -- keep semantics unchanged - -### SM-007 - -Title: Add tests for AniList rate limiter -Priority: P2 -Status: todo -Scope: - -- `src/core/services/anilist/rate-limiter.ts` - Acceptance: -- capacity-window wait behavior covered -- `x-ratelimit-remaining` + reset handling covered -- `retry-after` handling covered - -### SM-008 - -Title: Add core subtitle-position persistence/path tests -Priority: P3 -Status: todo -Scope: - -- `src/core/services/subtitle-position.ts` - Acceptance: -- save/load persistence covered -- fallback behavior covered -- path normalization behavior covered for URL vs local target - -### SM-009 - -Title: Add tests for JLPT token filter -Priority: P3 -Status: todo -Scope: - -- `src/core/services/jlpt-token-filter.ts` - Acceptance: -- excluded term membership covered -- ignored POS1 membership covered -- exported list / entry consistency covered - -### SM-010 - -Title: Refactor storage + immersion-tracker service into focused layers without API changes -Priority: P1 -Status: todo -Scope: - -- `src/core/database/storage/storage.ts` -- `src/core/database/storage/schema.ts` -- `src/core/database/storage/cover-blob.ts` -- `src/core/database/storage/records.ts` -- `src/core/database/storage/write-path.ts` -- `src/core/services/immersion-tracker/youtube.ts` -- `src/core/services/immersion-tracker/youtube-manager.ts` -- `src/core/services/immersion-tracker/write-queue.ts` -- `src/core/services/immersion-tracker/immersion-tracker-service.ts` - -Acceptance: - -- behavior and public API remain unchanged for all callers -- `storage.ts` responsibilities split into DDL/migrations, cover blob helpers, record CRUD, and write-path execution -- `immersion-tracker-service.ts` reduces to session state, media change orchestration, query proxies, and lifecycle -- YouTube code split into pure utilities, a stateful manager (`YouTubeManager`), and a dedicated write queue (`WriteQueue`) -- removed `storage.ts` is replaced with focused modules and updated imports -- no API or migration regressions; existing tests for trackers/storage coverage remain green or receive focused updates - -### SM-011 - -Title: Add coverage reporting for maintained test lanes -Priority: P1 -Status: done -Scope: - -- `package.json` -- CI workflow files under `.github/` -- `docs/workflow/verification.md` - Acceptance: -- at least one maintained test lane emits machine-readable coverage output -- CI surfaces coverage as an artifact, summary, or check output -- local contributor path for coverage is documented -- chosen coverage path works with Bun/TypeScript lanes already maintained by the repo -Implementation note: -- Added `bun run test:coverage:src` for the maintained source lane via a sharded coverage runner, with merged LCOV output at `coverage/test-src/lcov.info` and CI/release artifact upload as `coverage-test-src`. - -### SM-012 - -Title: Replace JSON serialize-clone helpers with structured cloning -Priority: P2 -Status: todo -Scope: - -- `src/runtime-options.ts` -- `src/config/definitions.ts` -- `src/config/service.ts` -- `src/main/controller-config-update.ts` - Acceptance: -- runtime/config clone helpers stop using `JSON.parse(JSON.stringify(...))` -- replacement preserves current behavior for plain config/runtime objects -- focused tests cover clone/merge behavior that could regress during the swap -- no new clone helper is introduced in these paths without a documented reason - -Done: - -- replaced JSON serialize-clone call sites in runtime/config/controller update paths with `structuredClone` -- updated focused tests and fixtures to cover detached clone behavior and guard against regressions - -### SM-013 - -Title: Address PR #36 CodeRabbit action items -Priority: P1 -Status: done -Scope: - -- `plugins/subminer-workflow/skills/subminer-change-verification/scripts/verify_subminer_change.sh` -- `scripts/subminer-change-verification.test.ts` -- `src/core/services/immersion-tracker/query-sessions.ts` -- `src/core/services/immersion-tracker/query-trends.ts` -- `src/core/services/immersion-tracker/maintenance.ts` -- `src/main/boot/services.ts` -- `src/main/character-dictionary-runtime/zip.test.ts` -Acceptance: -- fix valid open CodeRabbit findings on PR #36 -- add focused regression coverage for behavior changes where practical -- verify touched tests plus typecheck stay green - -Done: - -- hardened `--artifact-dir` validation in the verification script -- fixed trend aggregation rounding and monthly ratio bucketing -- preserved unwatched anime episodes in episode queries -- restored seconds-based aggregate timestamps in shared maintenance -- fixed the startup refactor compile break by making the predicates local at the call site -- verified with `bun test src/core/services/immersion-tracker/__tests__/query.test.ts src/core/services/immersion-tracker/__tests__/query-split-modules.test.ts` and `bun run typecheck` diff --git a/backlog/archive/tasks/task-175 - Address-latest-PR-19-review-comments.md b/backlog/archive/tasks/task-175 - Address-latest-PR-19-review-comments.md deleted file mode 100644 index 4570af35..00000000 --- a/backlog/archive/tasks/task-175 - Address-latest-PR-19-review-comments.md +++ /dev/null @@ -1,33 +0,0 @@ ---- -id: TASK-175 -title: Address latest PR 19 review comments -status: In Progress -assignee: [] -created_date: '2026-03-15 10:25' -labels: - - pr-review - - stats-dashboard -dependencies: [] -references: - - src/core/services/ipc.ts - - src/core/services/stats-server.ts - - src/core/services/immersion-tracker/__tests__/query.test.ts - - src/core/services/stats-window-runtime.ts - - src/core/services/stats-window.test.ts - - src/shared/ipc/contracts.ts - - src/main.ts -priority: medium ---- - -## Description - - -Validate the latest automated review comments on PR #19 against the current branch, implement the technically valid fixes, and document any items intentionally left unchanged. - - -## Acceptance Criteria - -- [ ] #1 Validated the latest PR #19 review comments against current branch behavior and existing architecture -- [ ] #2 Implemented the accepted fixes with regression coverage where it fits -- [ ] #3 Documented which latest review items were intentionally not changed because they were already addressed or not technically warranted - diff --git a/backlog/archive/tasks/task-279 - Prepare-v0.11.2-release-notes-and-verify-release-gate.md b/backlog/archive/tasks/task-279 - Prepare-v0.11.2-release-notes-and-verify-release-gate.md deleted file mode 100644 index 5de26a5a..00000000 --- a/backlog/archive/tasks/task-279 - Prepare-v0.11.2-release-notes-and-verify-release-gate.md +++ /dev/null @@ -1,23 +0,0 @@ ---- -id: TASK-279 -title: Prepare v0.11.2 release notes and verify release gate -status: In Progress -assignee: [] -created_date: '2026-04-04 07:38' -labels: [] -dependencies: [] -priority: high ---- - -## Description - - -Generate release metadata for the pending changelog fragments, review the resulting changelog/release notes output, and run the documented local release gate so the repo is ready for a v0.11.2 cut if checks pass. - - -## Acceptance Criteria - -- [ ] #1 CHANGELOG.md and release/release-notes.md are generated for v0.11.2 using the pending changes fragments. -- [ ] #2 The documented local release gate for release prep is run and the pass/fail state is recorded with any blockers. -- [ ] #3 Any release-prep file updates needed for the generated notes are left in the worktree for review without tagging or pushing. - diff --git a/backlog/archive/tasks/task-87.7 - Developer-workflow-hygiene-make-docs-watch-reproducible-and-remove-stale-small-surface-drift.md b/backlog/archive/tasks/task-87.7 - Developer-workflow-hygiene-make-docs-watch-reproducible-and-remove-stale-small-surface-drift.md deleted file mode 100644 index 34b58493..00000000 --- a/backlog/archive/tasks/task-87.7 - Developer-workflow-hygiene-make-docs-watch-reproducible-and-remove-stale-small-surface-drift.md +++ /dev/null @@ -1,51 +0,0 @@ ---- -id: TASK-87.7 -title: >- - Developer workflow hygiene: make docs watch reproducible and remove stale - small-surface drift -status: To Do -assignee: [] -created_date: '2026-03-06 03:20' -updated_date: '2026-03-06 03:21' -labels: - - tooling - - tech-debt -milestone: m-0 -dependencies: [] -references: - - package.json - - bun.lock - - src/anki-integration/field-grouping-workflow.ts -documentation: - - docs/reports/2026-02-22-task-100-dead-code-report.md -parent_task_id: TASK-87 -priority: low ---- - -## Description - - - -The review found a few low-risk but recurring hygiene issues: docs:watch depends on bunx concurrently even though concurrently is not declared in package metadata, and small stale API surface remains after recent refactors, such as unused parameters in field-grouping workflow code. This task should make the developer workflow reproducible and clean up low-risk stale symbols that do not warrant a dedicated architecture task. - - - -## Acceptance Criteria - - - -- [ ] #1 The docs:watch workflow runs through declared project tooling or is rewritten to avoid undeclared dependencies. -- [ ] #2 Small stale symbols or parameters identified during the review outside the main composition-root cleanup are removed without behavior changes. -- [ ] #3 Any contributor-facing command changes are reflected in repository documentation. -- [ ] #4 The cleanup remains scoped to low-risk workflow and hygiene fixes rather than expanding into large architectural refactors. - - -## Implementation Plan - - - -1. Fix the docs:watch workflow so it relies on declared project tooling or an equivalent checked-in command path. -2. Clean up low-risk stale symbols surfaced by the review outside the main.ts architecture task, such as unused parameters left behind by refactors. -3. Keep the task scoped: avoid pulling in main composition-root cleanup or larger Anki/runtime refactors. -4. Verify the affected developer commands still work and document any usage changes. - diff --git a/backlog/completed/task-100 - Add-configurable-texthooker-startup-launch.md b/backlog/completed/task-100 - Add-configurable-texthooker-startup-launch.md deleted file mode 100644 index b2b8e293..00000000 --- a/backlog/completed/task-100 - Add-configurable-texthooker-startup-launch.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -id: TASK-100 -title: Add configurable texthooker startup launch -status: Done -assignee: [] -created_date: '2026-03-06 23:30' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -priority: medium -ordinal: 11010 ---- - -## Description - - -Add a config option under `texthooker` to launch the built-in texthooker server automatically when SubMiner starts. - -Scope: - -- Add `texthooker.launchAtStartup`. -- Default to `true`. -- Start the existing texthooker server during normal app startup when enabled. -- Keep `texthooker.openBrowser` as separate behavior. -- Add regression coverage and update generated config docs/example. - - -## Acceptance Criteria - -- [x] #1 Default config enables automatic texthooker startup. -- [x] #2 Config parser accepts valid boolean values and warns on invalid values. -- [x] #3 App-ready startup launches texthooker when enabled. -- [x] #4 Generated config template/example documents the new option. - - -## Final Summary - - -Added `texthooker.launchAtStartup` with a default of `true`, wired it through config defaults/validation/template generation, and started the existing texthooker server during app-ready startup without coupling it to browser auto-open behavior. - -Also added regression coverage for config parsing/template output and app-ready dependency wiring, then regenerated the checked-in config example artifacts. - diff --git a/backlog/completed/task-101 - Index-AniList-character-alternative-names-in-the-character-dictionary.md b/backlog/completed/task-101 - Index-AniList-character-alternative-names-in-the-character-dictionary.md deleted file mode 100644 index 0e462ac2..00000000 --- a/backlog/completed/task-101 - Index-AniList-character-alternative-names-in-the-character-dictionary.md +++ /dev/null @@ -1,40 +0,0 @@ ---- -id: TASK-101 -title: Index AniList character alternative names in the character dictionary -status: Done -assignee: [] -created_date: '2026-03-07 00:00' -updated_date: '2026-03-16 05:13' -labels: - - dictionary - - anilist -dependencies: [] -references: - - src/main/character-dictionary-runtime.ts - - src/main/character-dictionary-runtime.test.ts -priority: high -ordinal: 71500 ---- - -## Description - - -Index AniList character alternative names in generated character dictionaries so aliases like Shadow resolve during subtitle lookup instead of falling through to unrelated generic dictionary entries. - - -## Acceptance Criteria - -- [x] #1 Character fetch reads AniList alternative character names needed for lookup coverage -- [x] #2 Generated term banks include alias-derived terms for subtitle lookups like シャドウ -- [x] #3 Regression coverage proves alternative-name indexing works end to end - - -## Final Summary - - -Character dictionary generation now requests AniList `name.alternative`, indexes those aliases as term candidates, and expands mixed aliases like `Minoru Kagenou (影野ミノル)` into usable outer/inner variants. Also extended kana alias synthesis so the AniList alias `Shadow` emits `シャドウ`, which matches the subtitle token the user hit in The Eminence in Shadow. - -Bumped the character-dictionary snapshot format to invalidate stale cached snapshots, and updated merged-dictionary rebuilds to refresh invalid snapshots before composing the ZIP so old cache files do not hard-fail the merge path. - -Verified with `bun test src/main/character-dictionary-runtime.test.ts` and `bun run tsc --noEmit`. - diff --git a/backlog/completed/task-102 - Quiet-default-AppImage-startup-and-implicit-background-launch.md b/backlog/completed/task-102 - Quiet-default-AppImage-startup-and-implicit-background-launch.md deleted file mode 100644 index ee451c75..00000000 --- a/backlog/completed/task-102 - Quiet-default-AppImage-startup-and-implicit-background-launch.md +++ /dev/null @@ -1,65 +0,0 @@ ---- -id: TASK-102 -title: Quiet default AppImage startup and implicit background launch -status: Done -assignee: - - codex -created_date: '2026-03-06 21:20' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/main-entry-runtime.ts - - /home/sudacode/projects/japanese/SubMiner/src/core/services/cli-command.ts - - /home/sudacode/projects/japanese/SubMiner/src/main.ts -priority: medium -ordinal: 77500 ---- - -## Description - - -Make the packaged Linux no-arg launch path behave like a quiet background start instead of surfacing startup-only noise. - -Scope: - -- Treat default background entry launches as implicit `--start --background`. -- Keep the `--password-store` diagnostic out of normal startup output. -- Suppress known startup-only `node:sqlite` and `lsfg-vk` warnings for the entry/background launch path. -- Avoid noisy protocol-registration warnings during normal startup when registration is unsupported. - - -## Acceptance Criteria - -- [x] #1 Initial background launch reaches the start path without logging `No running instance. Use --start to launch the app.` -- [x] #2 Default startup no longer emits the `Applied --password-store gnome-libsecret` line at normal log levels. -- [x] #3 Entry/background launch sanitization suppresses the observed `ExperimentalWarning: SQLite...` and `lsfg-vk ... unsupported configuration version` startup noise. -- [x] #4 Regression coverage documents the new startup behavior. - - -## Implementation Notes - - -Normalized no-arg/password-store-only entry launches to append implicit `--start --background`, and upgraded `--background`-only entry launches to include `--start`. - -Applied shared entry env sanitization before loading the main process so default startup strips the `lsfg-vk` Vulkan layer and sets `NODE_NO_WARNINGS=1`; background children keep the same sanitized env. - -Downgraded startup-only protocol-registration failure logging to debug, and routed the Linux password-store diagnostic through the scoped debug logger instead of raw console output. - -Verification: - -- `bun test src/main-entry-runtime.test.ts src/main/runtime/anilist-setup-protocol.test.ts src/main/runtime/anilist-setup-protocol-main-deps.test.ts` -- `bun run test:fast` - -Note: the final `node --experimental-sqlite --test dist/main/runtime/registry.test.js` step in `bun run test:fast` still prints Node's own experimental SQLite warning because that test command explicitly enables the feature flag outside the app entrypoint. - - -## Final Summary - - -Default packaged startup is now quiet and behaves like an implicit `--start --background` launch. - -- No-arg AppImage entry launches now append `--start --background`, and `--background`-only launches append the missing `--start`. -- Entry/background startup sanitization now suppresses the observed `lsfg-vk` and `node:sqlite` warnings on the app launch path. -- Linux password-store and unsupported protocol-registration diagnostics now stay at debug level instead of normal startup output. - diff --git a/backlog/completed/task-103 - Add-dedicated-annotation-websocket-for-texthooker.md b/backlog/completed/task-103 - Add-dedicated-annotation-websocket-for-texthooker.md deleted file mode 100644 index 7ad492d2..00000000 --- a/backlog/completed/task-103 - Add-dedicated-annotation-websocket-for-texthooker.md +++ /dev/null @@ -1,38 +0,0 @@ ---- -id: TASK-103 -title: Add dedicated annotation websocket for texthooker -status: Done -assignee: - - codex -created_date: '2026-03-07 02:20' -updated_date: '2026-03-16 05:13' -labels: - - texthooker - - websocket - - subtitle -dependencies: [] -priority: medium -ordinal: 73500 ---- - -## Description - - -Add a separate annotated subtitle websocket for bundled texthooker so token/JLPT/frequency markup is available on a stable dedicated port even when the regular websocket is in `auto` mode and skipped because `mpv_websocket` is installed. - - -## Acceptance Criteria - -- [x] #1 Regular `websocket.enabled: "auto"` behavior remains unchanged and still skips the regular websocket when `mpv_websocket` is installed. -- [x] #2 A separate `annotationWebsocket` config controls an independent annotated websocket with default port `6678`. -- [x] #3 Bundled texthooker is pointed at the annotation websocket when it is enabled. -- [x] #4 Focused regression tests cover config parsing, startup wiring, and texthooker bootstrap injection. - - -## Final Summary - - -Added `annotationWebsocket.enabled`/`annotationWebsocket.port` with defaults of `true`/`6678`, started that websocket independently from the regular auto-managed websocket, and injected the bundled texthooker websocket URL so it connects to the annotation feed by default. - -Also added focused regression coverage and regenerated the checked-in config examples. - diff --git a/backlog/completed/task-104 - Mirror-overlay-annotation-hover-behavior-in-vendored-texthooker.md b/backlog/completed/task-104 - Mirror-overlay-annotation-hover-behavior-in-vendored-texthooker.md deleted file mode 100644 index 83f81d35..00000000 --- a/backlog/completed/task-104 - Mirror-overlay-annotation-hover-behavior-in-vendored-texthooker.md +++ /dev/null @@ -1,45 +0,0 @@ ---- -id: TASK-104 -title: Mirror overlay annotation hover behavior in vendored texthooker -status: Done -assignee: - - codex -created_date: '2026-03-06 21:45' -updated_date: '2026-03-16 05:13' -labels: - - texthooker - - subtitle - - websocket -dependencies: - - TASK-103 -references: - - /home/sudacode/projects/japanese/SubMiner/src/core/services/subtitle-ws.ts - - >- - /home/sudacode/projects/japanese/SubMiner/vendor/texthooker-ui/src/components/App.svelte - - >- - /home/sudacode/projects/japanese/SubMiner/vendor/texthooker-ui/src/line-markup.ts - - /home/sudacode/projects/japanese/SubMiner/vendor/texthooker-ui/src/app.css -priority: medium -ordinal: 76500 ---- - -## Description - - -Bring bundled texthooker annotation rendering closer to the visible overlay. Keep the lightweight texthooker UX, but preserve token metadata for hover, match overlay color-precedence rules across known/N+1/name/frequency/JLPT, expose name-match highlighting as a toggle, and emit a structured annotation payload on the dedicated websocket so non-SubMiner clients can treat it as an API. - - -## Acceptance Criteria - -- [x] #1 Annotation websocket payload includes both rendered `sentence` HTML and structured token metadata for generic clients. -- [x] #2 Vendored texthooker preserves annotation metadata attrs needed for hover labels and uses overlay-matching color precedence rules. -- [x] #3 Vendored texthooker supports character-name highlighting with a user-facing toggle and standalone-web note. -- [x] #4 Hovering annotated texthooker tokens reveals JLPT/frequency metadata without adding the full overlay popup workflow. -- [x] #5 Focused serializer, texthooker markup, socket parsing, CSS, and build verification pass. - - -## Final Summary - - -Extended the dedicated annotation websocket payload to ship `version`, plain `text`, rendered `sentence`, and structured `tokens` metadata while keeping backward-compatible `sentence` consumers working. Updated the vendored texthooker to preserve hover metadata attrs, follow overlay color precedence for known/N+1/name/frequency/JLPT annotations, add a character-name highlight toggle plus standalone-web dictionary note, and render lightweight hover labels for frequency/JLPT metadata. Added focused regression coverage and rebuilt both the vendored texthooker bundle and SubMiner. - diff --git a/backlog/completed/task-105 - Stop-local-docs-artifact-writes-after-docs-repo-split.md b/backlog/completed/task-105 - Stop-local-docs-artifact-writes-after-docs-repo-split.md deleted file mode 100644 index ae7aaddc..00000000 --- a/backlog/completed/task-105 - Stop-local-docs-artifact-writes-after-docs-repo-split.md +++ /dev/null @@ -1,40 +0,0 @@ ---- -id: TASK-105 -title: Stop local docs artifact writes after docs repo split -status: Done -assignee: [] -created_date: '2026-03-07 00:00' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -priority: medium -ordinal: 12010 ---- - -## Description - - -Now that user-facing docs live in `../subminer-docs`, first-party scripts in this repo should not keep writing generated artifacts into the local `docs/` tree. - -Scope: - -- Audit first-party scripts/automation for writes to `docs/`. -- Keep repo-local outputs only where they are still intentionally owned by this repo. -- Repoint generated docs artifacts to `../subminer-docs` when that is the maintained source of truth. -- Add regression coverage for the config-example generation path contract. - - -## Acceptance Criteria - -- [x] #1 The config-example generator no longer writes to `docs/public/config.example.jsonc` inside this repo. -- [x] #2 When `../subminer-docs` exists, the generator updates `../subminer-docs/public/config.example.jsonc`. -- [x] #3 Automated coverage guards the output-path contract so local docs writes do not regress. - - -## Final Summary - - -Removed the first-party local `docs/public` config-example write path from `src/generate-config-example.ts` and replaced it with sibling-docs-repo detection that targets `../subminer-docs/public/config.example.jsonc` only when that repo exists. - -Added a project-local regression suite for output-path resolution and artifact writing, wired that suite into the maintained config test lane, and removed the stale generated `docs/public/config.example.jsonc` artifact from the working tree. - diff --git a/backlog/completed/task-106 - Add-first-run-setup-gate-and-auto-install-flow.md b/backlog/completed/task-106 - Add-first-run-setup-gate-and-auto-install-flow.md deleted file mode 100644 index 714dd3ee..00000000 --- a/backlog/completed/task-106 - Add-first-run-setup-gate-and-auto-install-flow.md +++ /dev/null @@ -1,71 +0,0 @@ ---- -id: TASK-106 -title: Add first-run setup gate and auto-install flow -status: Done -assignee: - - codex -created_date: '2026-03-07 06:10' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/main.ts - - /home/sudacode/projects/japanese/SubMiner/src/shared/setup-state.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/first-run-setup-service.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/first-run-setup-window.ts - - >- - /home/sudacode/projects/japanese/SubMiner/launcher/commands/playback-command.ts -priority: high -ordinal: 13010 ---- - -## Description - - -Replace the current manual install flow with a first-run setup gate: - -- bootstrap the default config dir/config file automatically -- detect legacy installs and mark them complete when config + Yomitan dictionaries are already present -- open a compact Catppuccin Macchiato setup popup for incomplete installs -- optionally install the mpv plugin into the default mpv location -- block launcher playback until setup completes, then resume the original playback flow - - -## Acceptance Criteria - -- [x] #1 First app launch seeds the default config dir/config file without manual copy steps. -- [x] #2 Existing installs with config plus at least one Yomitan dictionary are auto-detected as already complete. -- [x] #3 Incomplete installs get a first-run setup popup with mpv plugin install, Yomitan settings, refresh, skip, and finish actions. -- [x] #4 Launcher playback waits for setup completion and does not start mpv while setup is incomplete. -- [x] #5 Plugin assets are packaged into the Electron bundle and regression tests cover the new flow. - - -## Implementation Notes - - -Added shared setup-state/config/mpv path helpers so Electron and launcher read the same onboarding state file. - -Introduced a first-run setup service plus compact BrowserWindow popup using Catppuccin Macchiato styling. The popup supports optional mpv plugin install, opening Yomitan settings, status refresh, skip-plugin, and gated finish once at least one Yomitan dictionary is installed. - -Electron startup now bootstraps a default config file, auto-detects legacy-complete installs, adds `--setup` CLI support, exposes a tray `Complete Setup` action while incomplete, and avoids reopening setup once completion is recorded. - -Launcher playback now checks the shared setup-state file before starting mpv. If setup is incomplete, it launches the app with `--background --setup`, waits for completion, and only then proceeds. - -Verification: - -- `bun run typecheck` -- `bun run test:fast` - - -## Final Summary - - -SubMiner now supports a download-and-launch install flow. - -- First launch auto-creates config and opens setup only when needed. -- Existing users with working installs are silently migrated to completed setup. -- The setup popup handles optional mpv plugin install and Yomitan dictionary readiness. -- Launcher playback is gated on setup completion and resumes automatically afterward. - diff --git a/backlog/completed/task-107 - Fix-Yomitan-scan-token-fallback-fragmentation.md b/backlog/completed/task-107 - Fix-Yomitan-scan-token-fallback-fragmentation.md deleted file mode 100644 index 749b3b07..00000000 --- a/backlog/completed/task-107 - Fix-Yomitan-scan-token-fallback-fragmentation.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -id: TASK-107 -title: 'Fix Yomitan scan-token fallback fragmentation on exact-source misses' -status: Done -assignee: [] -created_date: '2026-03-07 01:10' -updated_date: '2026-03-07 01:12' -labels: [] -dependencies: [] -priority: high -ordinal: 9007 ---- - -## Description - - - -Left-to-right Yomitan scanning can emit bogus fallback tokens when `termsFind` returns entries but none of their headwords carries an exact primary source for the consumed substring. Repro: `だが それでも届かぬ高みがあった` currently yields trailing fragments like `があ` / `た`, which blocks the real `あった` token from receiving frequency highlighting. - - - -## Acceptance Criteria - - - -- [x] #1 Scanner skips `termsFind` fallback entries that are not backed by an exact primary source for the consumed substring. -- [x] #2 Repro line no longer yields bogus trailing fragments such as `があ`. -- [x] #3 Regression coverage added for the scan-token path. - - - -## Final Summary - - - -Removed the scan-token helper fallback that previously emitted a token from the first returned headword even when Yomitan did not report an exact primary source for the consumed substring. Added a focused regression test covering `だが それでも届かぬ高みがあった`, ensuring bogus `があ` fragmentation is skipped so the later `あった` exact match can still be tokenized and highlighted. - -Verification: - -- `bun test src/core/services/tokenizer/yomitan-parser-runtime.test.ts src/core/services/tokenizer.test.ts --timeout 20000` - - diff --git a/backlog/completed/task-108 - Exclude-single-kana-tokens-from-frequency-highlighting.md b/backlog/completed/task-108 - Exclude-single-kana-tokens-from-frequency-highlighting.md deleted file mode 100644 index 07065824..00000000 --- a/backlog/completed/task-108 - Exclude-single-kana-tokens-from-frequency-highlighting.md +++ /dev/null @@ -1,43 +0,0 @@ ---- -id: TASK-108 -title: 'Exclude single kana tokens from frequency highlighting' -status: Done -assignee: [] -created_date: '2026-03-07 01:18' -updated_date: '2026-03-07 01:22' -labels: [] -dependencies: [] -priority: medium -ordinal: 9008 ---- - -## Description - - - -Suppress frequency highlighting for single-character hiragana or katakana tokens. Scope is frequency-only: known/N+1/JLPT behavior stays unchanged. - - - -## Acceptance Criteria - - - -- [x] #1 Single-character hiragana tokens do not retain `frequencyRank`. -- [x] #2 Single-character katakana tokens do not retain `frequencyRank`. -- [x] #3 Regression coverage exists at annotation-stage and tokenizer levels. - - - -## Final Summary - - - -Added a frequency-only suppression rule for single-character kana tokens based on token `surface`, so bogus merged fragments like `た` and standalone one-character kana no longer keep `frequencyRank`. Regression coverage now exists both in the annotation stage and in the tokenizer path, while multi-character tokens and N+1/JLPT behavior remain unchanged. - -Verification: - -- `bun test src/core/services/tokenizer/annotation-stage.test.ts --timeout 20000` -- `bun test src/core/services/tokenizer.test.ts --timeout 20000` - - diff --git a/backlog/completed/task-110 - Replace-vendored-Yomitan-with-submodule-built-Chrome-artifact-workflow.md b/backlog/completed/task-110 - Replace-vendored-Yomitan-with-submodule-built-Chrome-artifact-workflow.md deleted file mode 100644 index 5e742ae1..00000000 --- a/backlog/completed/task-110 - Replace-vendored-Yomitan-with-submodule-built-Chrome-artifact-workflow.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-110 -title: Replace vendored Yomitan with submodule-built Chrome artifact workflow -status: Done -assignee: [] -created_date: '2026-03-07 11:05' -updated_date: '2026-03-16 05:13' -labels: - - yomitan - - build - - release -dependencies: [] -priority: high -ordinal: 10010 ---- - -## Description - - -Replace the checked-in `vendor/yomitan` release tree with a `subminer-yomitan` git submodule. Build Yomitan from source, extract the Chromium zip artifact into a stable local build directory, and make SubMiner dev/runtime/tests/release packaging load that extracted extension instead of the source tree or vendored files. - - -## Acceptance Criteria - -- [x] #1 Repo tracks Yomitan as a git submodule instead of committed extension files under `vendor/yomitan`. -- [x] #2 SubMiner has a reproducible build/extract step that produces a local Chromium extension directory from `subminer-yomitan`. -- [x] #3 Dev/runtime/tests resolve the extracted build output as the default Yomitan extension path. -- [x] #4 Release packaging includes the extracted Chromium extension files instead of the old vendored tree. -- [x] #5 Docs and verification commands reflect the new workflow. - - -## Final Summary - - -Replaced the checked-in `vendor/yomitan` extension tree with a `vendor/subminer-yomitan` git submodule and added a reproducible `bun run build:yomitan` workflow that builds `yomitan-chrome.zip`, extracts it into `build/yomitan`, and reuses a source-state stamp to skip redundant rebuilds. Runtime path resolution, helper CLIs, Yomitan integration tests, packaging, CI cache keys, and README source-build notes now all target that generated artifact instead of the old vendored files. - -Verification: - -- `bun run build:yomitan` -- `bun test src/core/services/yomitan-extension-paths.test.ts src/core/services/yomitan-structured-content-generator.test.ts src/yomitan-translator-sort.test.ts` -- `bun run typecheck` -- `bun run build` -- `bun run test:core:src` - diff --git a/backlog/completed/task-111 - Fix-subtitle-cycle-OSD-labels-for-J-keybindings.md b/backlog/completed/task-111 - Fix-subtitle-cycle-OSD-labels-for-J-keybindings.md deleted file mode 100644 index 080d5796..00000000 --- a/backlog/completed/task-111 - Fix-subtitle-cycle-OSD-labels-for-J-keybindings.md +++ /dev/null @@ -1,72 +0,0 @@ ---- -id: TASK-111 -title: Fix subtitle-cycle OSD labels for J keybindings -status: Done -assignee: - - Codex -created_date: '2026-03-07 23:45' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/ipc-command.ts - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/mpv.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/ipc-command.test.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/mpv-control.test.ts -ordinal: 72500 ---- - -## Description - - -When cycling subtitle tracks with the default J/Shift+J keybindings, the mpv OSD currently shows raw template text like `${sid}` instead of a resolved subtitle label. Update the keybinding OSD behavior so users see the active subtitle selection clearly when cycling tracks, and ensure placeholder-based OSD messages sent through the mpv client API render correctly. - - -## Acceptance Criteria - -- [x] #1 Pressing the primary subtitle cycle keybinding shows a resolved subtitle label on the OSD instead of a raw `${sid}` placeholder. -- [x] #2 Pressing the secondary subtitle cycle keybinding shows a resolved subtitle label on the OSD instead of a raw `${secondary-sid}` placeholder. -- [x] #3 Proxy OSD messages that rely on mpv property expansion render resolved values when sent through the mpv client API. -- [x] #4 Regression tests cover the subtitle-cycle OSD behavior and the placeholder-expansion OSD path. - - -## Implementation Plan - - -1. Add focused failing tests for subtitle-cycle OSD labels and mpv placeholder-expansion behavior. -2. Update the IPC mpv command handler to resolve primary and secondary subtitle track labels from mpv `track-list` data after cycling subtitle tracks. -3. Update the mpv OSD runtime path so placeholder-based `show-text` messages sent through the client API opt into property expansion. -4. Run focused tests, then the relevant core test lane, and record results in the task notes. - - -## Implementation Notes - - -Initial triage: `ipc-command.ts` emits raw `${sid}`/`${secondary-sid}` placeholder strings, and `showMpvOsdRuntime` sends `show-text` via mpv client API without enabling property expansion. - -User approved implementation plan on 2026-03-07. - -Implementation: proxy mpv command OSD now supports an async resolver so subtitle track cycling can show human-readable labels instead of raw `${sid}` placeholders. - -Implementation: `showMpvOsdRuntime` now prefixes placeholder-based messages with mpv client-api `expand-properties`, which fixes raw `${...}` OSD output for subtitle delay/position messages. - -Testing: `bun test src/core/services/ipc-command.test.ts src/core/services/mpv-control.test.ts src/main/runtime/mpv-proxy-osd.test.ts src/main/runtime/ipc-mpv-command-main-deps.test.ts src/main/runtime/ipc-bridge-actions.test.ts src/main/runtime/ipc-bridge-actions-main-deps.test.ts src/main/runtime/composers/ipc-runtime-composer.test.ts` passed. - -Testing: `bun x tsc --noEmit` passed. - -Testing: `bun run test:core:src` passed (423 pass, 6 skip, 0 fail). - -Docs: no update required because no checked-in docs or help text describe the J/Shift+J OSD output behavior. - - -## Final Summary - - -Fixed subtitle-cycle OSD handling for the default J/Shift+J keybindings. The IPC mpv command path now supports resolving proxy OSD text asynchronously, and the main-runtime resolver reads mpv `track-list` state so primary and secondary subtitle cycling show human-readable track labels instead of raw `${sid}` / `${secondary-sid}` placeholders. - -Also fixed the lower-level mpv OSD transport so placeholder-based `show-text` messages sent through the client API opt into `expand-properties`. That preserves existing template-based OSD messages like subtitle delay and subtitle position without leaking the raw `${...}` syntax. - -Added regression coverage for the async proxy OSD path, the placeholder-expansion `showMpvOsdRuntime` path, and the runtime subtitle-track label resolver. Verification run: `bun x tsc --noEmit`; focused mpv/IPC tests; and the maintained `bun run test:core:src` lane (423 pass, 6 skip, 0 fail). - diff --git a/backlog/completed/task-112 - Address-Claude-review-items-on-PR-15.md b/backlog/completed/task-112 - Address-Claude-review-items-on-PR-15.md deleted file mode 100644 index fafa8119..00000000 --- a/backlog/completed/task-112 - Address-Claude-review-items-on-PR-15.md +++ /dev/null @@ -1,62 +0,0 @@ ---- -id: TASK-112 -title: Address Claude review items on PR 15 -status: Done -assignee: - - codex -created_date: '2026-03-08 00:11' -updated_date: '2026-03-16 05:13' -labels: - - pr-review - - ci -dependencies: [] -references: - - .github/workflows/release.yml - - .github/workflows/ci.yml - - .gitmodules - - >- - backlog/tasks/task-101 - - Index-AniList-character-alternative-names-in-the-character-dictionary.md -priority: medium -ordinal: 70500 ---- - -## Description - - -Review Claude's PR feedback on PR #15, implement only the technically valid fixes on the current branch, and document which comments are non-actionable or already acceptable. - - -## Acceptance Criteria - -- [x] #1 Validated Claude's concrete PR review items against current branch state and repo conventions -- [x] #2 Implemented the accepted fixes with regression coverage or verification where applicable -- [x] #3 Documented which review items are non-blocking or intentionally left unchanged - - -## Implementation Plan - - -1. Validate each Claude review item against current branch files and repo workflow. -2. Patch release quality-gate to match CI ordering and add explicit typecheck. -3. Remove duplicate .gitmodules stanza and normalize the TASK-101 reference path through Backlog MCP. -4. Run relevant verification for workflow/config metadata changes and record which review items remain non-actionable. - - -## Implementation Notes - - -User asked to address Claude PR comments on PR #15 and assess whether any action items remain. Treat review suggestions skeptically; only fix validated defects. - -Validated Claude's five review items. Fixed release workflow ordering/typecheck, removed the duplicate .gitmodules entry, and normalized TASK-101 references to repo-relative paths via Backlog MCP. - -Left the vendor/subminer-yomitan branch-pin suggestion unchanged. The committed submodule SHA already controls reproducibility; adding a branch would only affect update ergonomics and was not required to address a concrete defect. - - -## Final Summary - - -Validated Claude's PR #15 review summary against the current branch and applied the actionable fixes. In `.github/workflows/release.yml`, the release `quality-gate` job now restores the dependency cache before installation, no longer installs twice, and runs `bun run typecheck` before the fast test suite to match CI expectations. In `.gitmodules`, removed the duplicate `vendor/yomitan-jlpt-vocab` stanza with the conflicting duplicate path. Through Backlog MCP, updated `TASK-101` references from an absolute local path to repo-relative paths so the task metadata is portable across contributors. - -Verification: `git diff --check`, `git config -f .gitmodules --get-regexp '^submodule\..*\.path$'`, `bun run typecheck`, and `bun run test:fast` all passed. `bun run format:check` still fails on many pre-existing unrelated files already present on the branch, including multiple backlog task files and existing source/docs files; this review patch did not attempt a repo-wide formatting sweep. - diff --git a/backlog/completed/task-113 - Scope-make-pretty-to-maintained-source-files.md b/backlog/completed/task-113 - Scope-make-pretty-to-maintained-source-files.md deleted file mode 100644 index af0de74d..00000000 --- a/backlog/completed/task-113 - Scope-make-pretty-to-maintained-source-files.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-113 -title: Scope make pretty to maintained source files -status: Done -assignee: - - codex -created_date: '2026-03-08 00:20' -updated_date: '2026-03-16 05:13' -labels: - - tooling - - formatting -dependencies: [] -references: - - Makefile - - package.json -priority: medium -ordinal: 69500 ---- - -## Description - - -Change the `make pretty` workflow so it formats only the maintained source/config files we intentionally keep under Prettier, instead of sweeping backlog/docs/generated content across the whole repository. - - -## Acceptance Criteria - -- [x] #1 `make pretty` formats only the approved maintained source/config paths -- [x] #2 The allowlist is reusable for check/write flows instead of duplicating path logic -- [x] #3 Verification shows the scoped formatting command targets the intended files without touching backlog or vendored content - - -## Implementation Plan - - -1. Inspect current Prettier config/ignore behavior and keep the broad repo-wide format command unchanged. -2. Add a reusable scoped Prettier script that targets maintained source/config paths only. -3. Update `make pretty` to call the scoped script. -4. Verify the scoped command resolves only intended files and does not traverse backlog or vendor paths. - - -## Implementation Notes - - -User approved the allowlist approach: keep repo-wide `format` intact, make `make pretty` use a maintained-path formatter scope. - -Added `scripts/prettier-scope.sh` as the single allowlist for scoped Prettier paths and wired `format:src` / `format:check:src` to it. - -Updated `make pretty` to call `bun run format:src`. Verified with `make -n pretty` and shell tracing that the helper only targets the maintained allowlist and does not traverse `backlog/` or `vendor/`. - -Excluded `Makefile` and `.prettierignore` from the allowlist after verification showed Prettier cannot infer parsers for them. - - -## Final Summary - - -Scoped the repo's day-to-day formatting entrypoint without changing the existing broad repo-wide Prettier scripts. Added `scripts/prettier-scope.sh` as the shared allowlist for maintained source/config paths (`.github`, `build`, `launcher`, `scripts`, `src`, plus selected root JSON config files), added `format:src` and `format:check:src` in `package.json`, and updated `make pretty` to run the scoped formatter. - -Verification: `make -n pretty` now resolves to `bun run format:src`. `bash -n scripts/prettier-scope.sh` passed, and shell-traced `bash -x scripts/prettier-scope.sh --check` confirmed the exact allowlist passed to Prettier. `bun run format:check:src` fails only because existing files inside the allowed source scope are not currently formatted; it no longer touches `backlog/` or `vendor/`. - diff --git a/backlog/completed/task-114 - Fix-failing-CI-checks-on-PR-15.md b/backlog/completed/task-114 - Fix-failing-CI-checks-on-PR-15.md deleted file mode 100644 index 7b17a4de..00000000 --- a/backlog/completed/task-114 - Fix-failing-CI-checks-on-PR-15.md +++ /dev/null @@ -1,63 +0,0 @@ ---- -id: TASK-114 -title: Fix failing CI checks on PR 15 -status: Done -assignee: - - codex -created_date: '2026-03-08 00:34' -updated_date: '2026-03-16 05:13' -labels: - - ci - - test -dependencies: [] -references: - - src/renderer/subtitle-render.test.ts - - src/renderer/style.css - - .github/workflows/ci.yml -priority: high -ordinal: 68500 ---- - -## Description - - -Investigate the failing GitHub Actions CI run for PR #15 on branch `yomitan-fork`, fix the underlying test or code regression, and verify the affected local test/CI lane passes. - - -## Acceptance Criteria - -- [x] #1 Identified the concrete failing CI job and captured the relevant failure context -- [x] #2 Implemented the minimal code or test change needed to resolve the CI failure -- [x] #3 Verified the affected local test target and the broader fast CI test lane pass - - -## Implementation Plan - - -1. Inspect the failing GitHub Actions run and confirm the exact failing test/assertion. -2. Reproduce the failing renderer stylesheet test locally and compare the assertion against current CSS. -3. Apply the minimal test or stylesheet fix needed to restore the intended hover/selection behavior. -4. Re-run the targeted renderer test, then re-run `bun run test` to verify the fast CI lane is green. - - -## Implementation Notes - - -GitHub Actions run 22810400921 failed in job build-test-audit, step `Test suite (source)`, with a single failing test: `JLPT CSS rules use underline-only styling in renderer stylesheet` in src/renderer/subtitle-render.test.ts. - -Reproduced the failing test locally with `bun test src/renderer/subtitle-render.test.ts`. The failure was a brittle stylesheet assertion, not a renderer behavior regression. - -Updated the renderer stylesheet test helper to split selectors safely across `:is(...)` commas and normalize multiline selector whitespace, then switched the failing hover/JLPT assertions to inspect extracted rule blocks instead of matching the entire CSS file text. - -Verification passed with `bun test src/renderer/subtitle-render.test.ts` and `bun run test`. - - -## Final Summary - - -Investigated GitHub Actions CI run `22810400921` for PR #15 and confirmed the only failing job was `build-test-audit`, step `Test suite (source)`, with a single failure in `src/renderer/subtitle-render.test.ts` (`JLPT CSS rules use underline-only styling in renderer stylesheet`). - -The renderer CSS itself was still correct; the regression was in the test helper. `extractClassBlock` was splitting selector lists on every comma, which breaks selectors containing `:is(...)`, and the affected assertions fell back to brittle whole-file regex matching against a multiline selector. Fixed the test by teaching the helper to split selectors only at top-level commas, normalizing selector whitespace around multiline `:not(...)` / `:is(...)` clauses, and asserting on extracted rule blocks for the plain-word hover and JLPT-only hover/selection rules. - -Verification: `bun test src/renderer/subtitle-render.test.ts` passed, and `bun run test` passed end to end (the same fast lane that failed in CI). - diff --git a/backlog/completed/task-115 - Refresh-subminer-docs-contributor-docs-for-current-repo-workflow.md b/backlog/completed/task-115 - Refresh-subminer-docs-contributor-docs-for-current-repo-workflow.md deleted file mode 100644 index 91be5301..00000000 --- a/backlog/completed/task-115 - Refresh-subminer-docs-contributor-docs-for-current-repo-workflow.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-115 -title: Refresh subminer-docs contributor docs for current repo workflow -status: Done -assignee: - - codex -created_date: '2026-03-08 00:40' -updated_date: '2026-03-16 05:13' -labels: - - docs -dependencies: [] -references: - - ../subminer-docs/development.md - - ../subminer-docs/README.md - - Makefile - - package.json -priority: medium -ordinal: 67500 ---- - -## Description - - -Update the sibling `subminer-docs` repo so contributor/development docs match the current SubMiner repo workflow after the docs split and recent tooling changes, including removing stale in-repo docs build steps and documenting the scoped formatting command. - - -## Acceptance Criteria - -- [x] #1 Contributor docs in `subminer-docs` no longer reference stale in-repo docs build commands for the app repo -- [x] #2 Contributor docs mention the current scoped formatting workflow (`make pretty` / `format:src`) where relevant -- [x] #3 Removed stale or no-longer-needed instructions that no longer match the current repo layout - - -## Implementation Plan - - -1. Inspect `subminer-docs` for contributor/development instructions that drifted after the docs repo split and recent tooling changes. -2. Update contributor docs to remove stale app-repo docs commands and document the current scoped formatting workflow. -3. Verify the modified docs page and build the docs site from the sibling docs repo when local dependencies are available. - - -## Implementation Notes - - -Detected concrete doc drift in `subminer-docs/development.md`: stale in-repo docs build commands and no mention of the scoped `make pretty` formatter. - -Updated `../subminer-docs/development.md` to remove stale app-repo docs build steps from the local gate, document `make pretty` / `format:check:src`, and point docs-site work to the sibling docs repo explicitly. - -Installed docs repo dependencies locally with `bun install` and verified the docs site with `bun run docs:build` in `../subminer-docs`. - -Did not change `../subminer-docs/README.md`; it was already accurate for the docs repo itself. - - -## Final Summary - - -Refreshed the contributor/development docs in the sibling `subminer-docs` repo to match the current SubMiner workflow. In `development.md`, removed the stale app-repo `bun run docs:build` step from the local CI-equivalent gate, added an explicit note to run docs builds from `../subminer-docs` when docs change, documented the scoped formatting workflow (`make pretty` and `bun run format:check:src`), and replaced the old in-repo `make docs*` instructions with the correct sibling-repo `bun run docs:*` commands. Also updated the Makefile reference to include `make pretty` and removed the obsolete `make docs-dev` entry. - -Verification: installed docs repo dependencies with `bun install` in `../subminer-docs` and ran `bun run docs:build` successfully. Left `README.md` unchanged because it was already accurate for the standalone docs repo. - diff --git a/backlog/completed/task-116 - Audit-branch-commits-for-remaining-subminer-docs-updates.md b/backlog/completed/task-116 - Audit-branch-commits-for-remaining-subminer-docs-updates.md deleted file mode 100644 index 71abc2d9..00000000 --- a/backlog/completed/task-116 - Audit-branch-commits-for-remaining-subminer-docs-updates.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -id: TASK-116 -title: Audit branch commits for remaining subminer-docs updates -status: Done -assignee: - - codex -created_date: '2026-03-08 00:46' -updated_date: '2026-03-16 05:13' -labels: - - docs -dependencies: [] -references: - - ../subminer-docs/installation.md - - ../subminer-docs/troubleshooting.md - - src/core/services/yomitan-extension-paths.ts - - scripts/build-yomitan.mjs -priority: medium -ordinal: 66500 ---- - -## Description - - -Review recent `yomitan-fork` commits against the sibling `subminer-docs` repo, identify any concrete documentation drift that remains after the earlier contributor-doc updates, and patch the docs for behavior/tooling changes that are now outdated or misleading. - - -## Acceptance Criteria - -- [x] #1 Reviewed recent branch commits for user-facing or contributor-facing changes that may require docs updates -- [x] #2 Updated `subminer-docs` pages where branch changes introduced concrete doc drift -- [x] #3 Verified the docs site still builds after the updates - - -## Implementation Plan - - -1. Review branch commit themes against `subminer-docs` and identify only concrete drift introduced by recent workflow/runtime changes. -2. Patch docs for the Yomitan submodule build workflow, updated source-build prerequisites, and current runtime Yomitan search paths/manual fallback path. -3. Rebuild the docs site to verify the updated pages render cleanly. - - -## Implementation Notes - - -Concrete remaining drift after commit audit: installation/development docs still understate the Node/npm + submodule requirements for the Yomitan build flow, and troubleshooting still points at obsolete `vendor/yomitan` / `extensions/yomitan` paths. - -Audited branch commits against subminer-docs coverage. Existing docs already cover first-run setup, texthooker startup/annotated websocket config, AniList merged character dictionaries, configurable collapsible sections, and subtitle name highlighting. Patched remaining drift around source-build prerequisites and Yomitan build/install paths in installation.md, development.md, and troubleshooting.md. Verified with `bun run docs:build` in ../subminer-docs. - - -## Final Summary - - -Audited branch commits for missing documentation updates in ../subminer-docs. Updated installation, development, and troubleshooting docs to match the current Yomitan submodule build flow, source-build prerequisites, and runtime extension search/manual fallback paths. Confirmed other recent branch features were already documented and rebuilt the docs site successfully. - diff --git a/backlog/completed/task-117 - Prepare-initial-Windows-release-docs-and-version-bump.md b/backlog/completed/task-117 - Prepare-initial-Windows-release-docs-and-version-bump.md deleted file mode 100644 index de9ac385..00000000 --- a/backlog/completed/task-117 - Prepare-initial-Windows-release-docs-and-version-bump.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-117 -title: Prepare initial Windows release docs and version bump -status: Done -assignee: - - codex -created_date: '2026-03-08 15:17' -updated_date: '2026-03-16 05:13' -labels: - - release - - docs - - windows -dependencies: [] -references: - - package.json - - README.md - - ../subminer-docs/installation.md - - ../subminer-docs/usage.md - - ../subminer-docs/changelog.md -priority: medium -ordinal: 53500 ---- - -## Description - - -Prepare the initial packaged Windows release by bumping the app version and refreshing the release-facing README/backlog/docs surfaces so install and direct-command guidance no longer reads Linux-only. - - -## Acceptance Criteria - -- [x] #1 App version is bumped for the Windows release cut -- [x] #2 README and sibling docs describe Windows packaged installation alongside Linux/macOS guidance -- [x] #3 Backlog records the release-doc/version update with the modified references - - -## Implementation Plan - - -1. Bump the package version for the release cut. -2. Update the root README install/start guidance to mention Windows packaged builds. -3. Patch the sibling docs repo installation, usage, and changelog pages for the Windows release. -4. Record the work in Backlog and run targeted verification on the touched surfaces. - - -## Implementation Notes - - -The public README still advertised Linux/macOS only, while the sibling docs had Windows-specific runtime notes but no actual Windows install section and several direct-command examples still assumed `SubMiner.AppImage`. - -Bumped `package.json` to `0.5.0`, expanded the README platform/install copy to include Windows, added a Windows install section to `../subminer-docs/installation.md`, clarified in `../subminer-docs/usage.md` that direct packaged-app examples use `SubMiner.exe` on Windows, and added a `v0.5.0` changelog entry covering the initial Windows release plus the latest overlay behavior polish. - - -## Final Summary - - -Prepared the initial Windows release documentation pass and version bump. `package.json` now reports `0.5.0`. The root `README.md` now advertises Linux, macOS, and Windows support, includes Windows packaged-install guidance, and clarifies first-launch behavior across platforms. In the sibling docs repo, `installation.md` now includes a dedicated Windows install section, `usage.md` explains that direct packaged-app examples use `SubMiner.exe` on Windows, and `changelog.md` now includes the `v0.5.0` release notes for the initial Windows build and recent overlay behavior changes. - -Verification: targeted `bun run tsc --noEmit -p tsconfig.typecheck.json` in the app repo and `bun run docs:build` in `../subminer-docs`. - diff --git a/backlog/completed/task-117 - Replace-YouTube-subtitle-generation-with-pure-TypeScript-pipeline-and-shared-AI-config.md b/backlog/completed/task-117 - Replace-YouTube-subtitle-generation-with-pure-TypeScript-pipeline-and-shared-AI-config.md deleted file mode 100644 index 0eda38e8..00000000 --- a/backlog/completed/task-117 - Replace-YouTube-subtitle-generation-with-pure-TypeScript-pipeline-and-shared-AI-config.md +++ /dev/null @@ -1,75 +0,0 @@ ---- -id: TASK-117 -title: >- - Replace YouTube subtitle generation with pure TypeScript pipeline and shared - AI config -status: Done -assignee: - - codex -created_date: '2026-03-08 03:16' -updated_date: '2026-03-08 03:35' -labels: [] -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube.ts - - /Users/sudacode/projects/japanese/SubMiner/src/anki-integration/ai.ts - - /Users/sudacode/projects/japanese/SubMiner/src/types.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/config/definitions/defaults-integrations.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/config/resolve/subtitle-domains.ts - - /Users/sudacode/projects/japanese/SubMiner/config.example.jsonc ---- - -## Description - - - -Replace the launcher YouTube subtitle generation flow with a pure TypeScript pipeline that prefers real downloadable YouTube subtitles, never uses YouTube auto-generated subtitles, locally generates missing tracks with whisper.cpp, and can optionally fix generated subtitles via a shared OpenAI-compatible AI provider config. This feature also introduces a breaking config cleanup: move provider settings to a new top-level ai section and reduce ankiConnect.ai to a boolean feature toggle. - - - -## Acceptance Criteria - - - -- [x] #1 Launcher YouTube subtitle generation prefers downloadable manual YouTube subtitles, never uses YouTube auto-generated subtitles, and locally generates only missing tracks with whisper.cpp. -- [x] #2 Generated whisper subtitle tracks can optionally be post-processed with an OpenAI-compatible AI provider using shared top-level ai config, with validation and fallback to raw whisper output on failure. -- [x] #3 Configuration is updated so top-level ai is canonical shared provider config, ankiConnect.ai is boolean-only, and youtubeSubgen includes whisperVadModel, whisperThreads, and fixWithAi. -- [x] #4 Launcher CLI/config parsing, config example, and docs reflect the new breaking config shape with no migration layer. -- [x] #5 Automated tests cover the new YouTube generation behavior, AI-fix fallback/validation behavior, shared AI config usage, and breaking config validation. - - -## Implementation Plan - - - -1. Introduce canonical top-level ai config plus youtubeSubgen runtime knobs (whisperVadModel, whisperThreads, fixWithAi) and convert ankiConnect.ai to a boolean-only toggle across types, defaults, validation, option registries, launcher config parsing, and config example/docs. -2. Extract shared OpenAI-compatible AI client helpers from the current Anki translation code, including base URL normalization, API key / apiKeyCommand resolution, timeout handling, and response text extraction. -3. Update Anki translation flow and hot-reload/runtime plumbing to consume global ai config while treating ankiConnect.ai as a feature gate only. -4. Replace launcher/youtube.ts with a modular launcher/youtube pipeline that fetches only manual YouTube subtitles, generates missing tracks locally with ffmpeg + whisper.cpp + optional VAD/thread controls, and preserves preprocess/automatic playback behavior. -5. Add optional AI subtitle-fix processing for whisper-generated tracks using the shared ai client, with strict SRT batching/validation and fallback to raw whisper output on provider or format failure. -6. Expand automated coverage for config validation, shared AI usage, launcher config parsing, and YouTube subtitle generation behavior including removal of yt-dlp auto-subs and AI-fix fallback rules. - - -## Implementation Notes - - - -Implemented pure TypeScript launcher/youtube pipeline modules for manual subtitle fetch, audio extraction, whisper runs, SRT utilities, and optional AI subtitle fixing. Removed yt-dlp auto-subtitle usage from the generation path. - -Added shared top-level ai config plus shared AI client helpers; converted ankiConnect.ai to a boolean feature gate and updated Anki runtime wiring to consume global ai config. - -Updated launcher config parsing, config template sections, and config.example.jsonc for the breaking config shape including youtubeSubgen.whisperVadModel, youtubeSubgen.whisperThreads, and youtubeSubgen.fixWithAi. - -Verification: bun run test:config:src passed; targeted AI/Anki/runtime tests passed; bun run typecheck passed. bun run test:launcher:unit:src reported one unrelated existing failure in launcher/aniskip-metadata.test.ts (resolveAniSkipMetadataForFile resolves MAL id and intro payload). - - - -## Final Summary - - - -Replaced the launcher YouTube subtitle flow with a modular TypeScript pipeline that prefers manual YouTube subtitles, transcribes only missing tracks with whisper.cpp, and can optionally post-fix whisper output through a shared OpenAI-compatible AI client with strict SRT validation/fallback. Introduced canonical top-level ai config, reduced ankiConnect.ai to a boolean feature gate, updated launcher/config parsing and checked-in config artifacts, and added coverage for YouTube orchestration, whisper args, SRT validation, AI fix behavior, and breaking config validation. - - diff --git a/backlog/completed/task-117.1 - Harden-AI-subtitle-fix-against-non-SRT-model-responses.md b/backlog/completed/task-117.1 - Harden-AI-subtitle-fix-against-non-SRT-model-responses.md deleted file mode 100644 index 38437f32..00000000 --- a/backlog/completed/task-117.1 - Harden-AI-subtitle-fix-against-non-SRT-model-responses.md +++ /dev/null @@ -1,57 +0,0 @@ ---- -id: TASK-117.1 -title: Harden AI subtitle fix against non-SRT model responses -status: Done -assignee: - - '@codex' -created_date: '2026-03-08 08:22' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube/subtitle-fix-ai.ts - - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube/srt.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube/subtitle-fix-ai.test.ts -parent_task_id: TASK-117 -ordinal: 59500 ---- - -## Description - - -Prevent optional YouTube AI subtitle post-processing from bailing out whenever the model returns usable cue text in a non-SRT wrapper or text-only format. The launcher should recover safe cases, preserve original timing, and fall back cleanly when the response cannot be mapped back to the source cues. - - -## Acceptance Criteria - -- [x] #1 AI subtitle fixing accepts safe AI responses that omit SRT framing but still provide one corrected text payload per original cue while preserving original cue timing. -- [x] #2 AI subtitle fixing still rejects responses that cannot be mapped back to the original cue batch without guessing and falls back to the raw subtitle file with a warning. -- [x] #3 Automated tests cover wrapped-SRT and text-only AI responses plus an unrecoverable invalid response case. - - -## Implementation Plan - - -1. Add failing tests in launcher/youtube/subtitle-fix-ai.test.ts for three cases: wrapped valid SRT, text-only one-block-per-cue output, and unrecoverable invalid output. -2. Extend launcher/youtube/subtitle-fix-ai.ts with a small response-normalization path that first strips markdown/code-fence wrappers, then accepts deterministic text-only cue batches only when they map 1:1 to the original cues without changing timestamps. -3. Keep existing safety rules: preserve cue count and timing, log a warning, and fall back to the raw subtitle file when normalization cannot recover a trustworthy batch. -4. Run focused launcher unit tests for subtitle-fix-ai and SRT parsing; expand only if the change affects adjacent behavior. - - -## Implementation Notes - - -Implemented deterministic AI subtitle-response recovery for fenced SRT, embedded SRT payloads, and text-only 1:1 cue batches while preserving original timing and existing fallback behavior. - -Verification: bun test launcher/youtube/_.test.ts passed; bun run typecheck passed; repo-wide format check still reports unrelated pre-existing warnings in launcher/youtube/orchestrator.ts and scripts/build-changelog_. - - -## Final Summary - - -Hardened the launcher AI subtitle-fix path so it can recover deterministic non-SRT model responses instead of immediately falling back. Added `parseAiSubtitleFixResponse` in `launcher/youtube/subtitle-fix-ai.ts` to normalize markdown-fenced or embedded SRT payloads first, then accept text-only responses only when they map 1:1 onto the original cue batch and preserve source timings. Added regression coverage in `launcher/youtube/subtitle-fix-ai.test.ts` for fenced SRT, text-only cue batches, and unrecoverable invalid output, plus a changelog fragment in `changes/task-117.1.md`. - -Verification: `bun test launcher/youtube/*.test.ts`, `bun run typecheck`, `bunx prettier --check launcher/youtube/subtitle-fix-ai.ts launcher/youtube/subtitle-fix-ai.test.ts`, and `bun run changelog:lint` passed. Repo-wide `bun run format:check:src` still reports unrelated pre-existing warnings in `launcher/youtube/orchestrator.ts` and `scripts/build-changelog*`. - diff --git a/backlog/completed/task-118 - Add-Windows-release-build-and-SignPath-signing.md b/backlog/completed/task-118 - Add-Windows-release-build-and-SignPath-signing.md deleted file mode 100644 index b89961bc..00000000 --- a/backlog/completed/task-118 - Add-Windows-release-build-and-SignPath-signing.md +++ /dev/null @@ -1,65 +0,0 @@ ---- -id: TASK-118 -title: Add Windows release build and SignPath signing -status: Done -assignee: - - codex -created_date: '2026-03-08 15:17' -updated_date: '2026-03-16 05:13' -labels: - - release - - windows - - signing -dependencies: [] -references: - - .github/workflows/release.yml - - build/installer.nsh - - build/signpath-windows-artifact-config.xml - - package.json -priority: high -ordinal: 54500 ---- - -## Description - - -Extend the tag-driven release workflow so Windows artifacts are built on GitHub-hosted runners and submitted to SignPath for free open-source Authenticode signing, while preserving the existing macOS notarization path. - - -## Acceptance Criteria - -- [x] #1 Release workflow builds Windows installer and ZIP artifacts on `windows-latest` -- [x] #2 Workflow submits unsigned Windows artifacts to SignPath and uploads the signed outputs for release publication -- [x] #3 Repository includes a checked-in SignPath artifact-configuration source of truth for the Windows release files - - -## Implementation Plan - - -1. Inspect the existing release workflow and current Windows packaging configuration. -2. Add a Windows release job that builds unsigned artifacts, uploads them as a workflow artifact, and submits them to SignPath. -3. Update the release aggregation job to publish signed Windows assets and mention Windows install steps in the generated release notes. -4. Check in the Windows SignPath artifact configuration XML used to define what gets signed. - - -## Implementation Notes - - -The repository already had Windows packaging configuration (`build:win`, NSIS include script, Windows helper asset packaging), but the release workflow still built Linux and macOS only. - -Added a `build-windows` job to `.github/workflows/release.yml` that runs on `windows-latest`, validates required SignPath secrets, builds unsigned Windows artifacts, uploads them with `actions/upload-artifact@v4`, and then calls the official `signpath/github-action-submit-signing-request@v2` action to retrieve signed outputs. - -Checked in `build/signpath-windows-artifact-config.xml` as the source-of-truth artifact configuration for SignPath. It signs the top-level NSIS installer EXE and deep-signs `.exe` and `.dll` files inside the portable ZIP artifact. - -Updated the release aggregation job to download the signed Windows artifacts and added a Windows install section to the generated GitHub release body. - - -## Final Summary - - -Windows release publishing is now wired into the tag-driven workflow. `.github/workflows/release.yml` builds Windows artifacts on `windows-latest`, submits them to SignPath using the official GitHub action, and publishes the signed `.exe` and `.zip` outputs alongside the Linux and macOS artifacts. The workflow now requests the additional `actions: read` permission required by the SignPath GitHub integration, and the generated release notes now include Windows installation steps. - -The checked-in `build/signpath-windows-artifact-config.xml` file defines the SignPath artifact structure expected by the workflow artifact ZIP: sign the top-level `SubMiner-*.exe` installer and deep-sign `.exe` and `.dll` files inside `SubMiner-*.zip`. - -Verification: workflow/static changes were checked with `git diff --check` on the touched files. Actual signing requires configured SignPath secrets and a matching artifact configuration in your SignPath project. - diff --git a/backlog/completed/task-118 - Fix-GitHub-release-workflow-publish-step-failure.md b/backlog/completed/task-118 - Fix-GitHub-release-workflow-publish-step-failure.md deleted file mode 100644 index ae4e1e76..00000000 --- a/backlog/completed/task-118 - Fix-GitHub-release-workflow-publish-step-failure.md +++ /dev/null @@ -1,73 +0,0 @@ ---- -id: TASK-118 -title: Fix GitHub release workflow publish step failure -status: Done -assignee: - - Codex -created_date: '2026-03-08 03:34' -updated_date: '2026-03-08 03:38' -labels: - - ci - - release - - github-actions -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/.github/workflows/release.yml - - 'https://github.com/ksyasuda/SubMiner/actions/runs/22812335927' ---- - -## Description - - - -The GitHub Actions Release workflow fails during the Publish Release step for tag releases because the gh CLI invocation passes invalid arguments when creating or editing the GitHub release. Restore successful release publication for tagged builds without changing unrelated release packaging behavior. - - - -## Acceptance Criteria - - - -- [x] #1 Tagged Release workflow completes the Publish Release step without gh CLI argument errors. -- [x] #2 Release workflow still creates or updates the GitHub release as a non-prerelease for normal version tags. -- [x] #3 A regression check covers the publish command shape or workflow behavior that caused this failure. -- [x] #4 Any release workflow behavior change is documented in repository docs or workflow comments if needed. - - -## Implementation Plan - - - -1. Add a targeted regression test for .github/workflows/release.yml that fails if the publish step passes an argument to the gh --prerelease boolean flag or otherwise omits explicit non-prerelease behavior. -2. Run the targeted test to confirm the current workflow fails for the expected reason. -3. Patch the Publish Release step in .github/workflows/release.yml to remove the invalid gh CLI usage while preserving non-prerelease release creation/update behavior. -4. Re-run the targeted regression test and any relevant lightweight verification, then record results in task notes. - - -## Implementation Notes - - - -Identified root cause from GitHub Actions run 22812335927: Publish Release failed with `accepts 1 arg(s), received 2` because the workflow passed a value to gh's boolean prerelease flag. - -Added a workflow comment clarifying that omitting the prerelease flag keeps normal releases as non-prerelease releases. - -Added src/release-workflow.test.ts and wired it into `bun run test:fast` so CI catches the invalid workflow shape before the next tag. - -Verification: `bun test src/release-workflow.test.ts`, `bun run typecheck`, and `bun run test:fast` all passed locally. - -Code-review pass found no issues; remaining caveat is that prerelease tag semantics are still not modeled for tags like `v1.0.0-beta.1`, which is outside this fix scope. - - - -## Final Summary - - - -Fixed the GitHub Actions release publish step so tagged releases no longer fail on invalid gh CLI usage. The workflow now omits the prerelease flag when creating or editing normal releases, which preserves existing non-prerelease behavior and avoids the `accepts 1 arg(s), received 2` failure seen in run 22812335927. - -Added a small regression test that reads `.github/workflows/release.yml` and asserts the publish step does not set the prerelease flag, then included that test in `bun run test:fast` so the main verification lane catches this class of workflow regression before the next release. - -Validation run locally: `bun test src/release-workflow.test.ts`, `bun run typecheck`, and `bun run test:fast`. Residual risk: prerelease-tag semantics remain unchanged for tags such as `v1.0.0-beta.1`; this fix is intentionally scoped to restoring normal tagged release publication. - - diff --git a/backlog/completed/task-120 - Replace-node-sqlite-with-libsql-and-remove-Yomitan-Node-wrapper.md b/backlog/completed/task-120 - Replace-node-sqlite-with-libsql-and-remove-Yomitan-Node-wrapper.md deleted file mode 100644 index c073c8dd..00000000 --- a/backlog/completed/task-120 - Replace-node-sqlite-with-libsql-and-remove-Yomitan-Node-wrapper.md +++ /dev/null @@ -1,36 +0,0 @@ ---- -id: TASK-120 -title: 'Replace node:sqlite with libsql and remove Yomitan Node wrapper' -status: Done -assignee: [] -created_date: '2026-03-08 04:14' -updated_date: '2026-03-16 05:13' -labels: - - runtime - - bun - - sqlite - - tech-debt -dependencies: [] -priority: medium -ordinal: 65500 ---- - -## Description - - -Remove the remaining root Node requirement caused by immersion tracking SQLite usage and the old Yomitan build wrapper by migrating the local SQLite layer off node:sqlite, running the SQLite-backed verification lanes under Bun, and switching the vendored Yomitan build flow to Bun-native scripts. - - -## Acceptance Criteria - -- [x] #1 Immersion tracker runtime no longer imports or requires node:sqlite -- [x] #2 SQLite-backed immersion tracker tests run under Bun without Node --experimental-sqlite -- [x] #3 Root build/test scripts no longer require the Yomitan Node wrapper or Node-based SQLite verification lanes -- [x] #4 README requirements/testing docs reflect the Bun-native workflow - - -## Final Summary - - -Replaced the immersion tracker SQLite dependency with a local libsql-backed wrapper, updated Bun/runtime compatibility tests to avoid process.exitCode side effects, switched Yomitan builds to run directly inside the vendored Bun-native project, deleted scripts/build-yomitan.mjs, and verified typecheck plus Bun build/test lanes (`build:yomitan`, `test:immersion:sqlite`, `test:runtime:compat`, `test:fast`). - diff --git a/backlog/completed/task-121 - Fix-YouTube-manual-subtitle-selection-regression-when-downloadable-tracks-exist.md b/backlog/completed/task-121 - Fix-YouTube-manual-subtitle-selection-regression-when-downloadable-tracks-exist.md deleted file mode 100644 index 9d62d64b..00000000 --- a/backlog/completed/task-121 - Fix-YouTube-manual-subtitle-selection-regression-when-downloadable-tracks-exist.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-121 -title: >- - Fix YouTube manual subtitle selection regression when downloadable tracks - exist -status: Done -assignee: - - '@codex' -created_date: '2026-03-08 05:37' -updated_date: '2026-03-16 05:13' -labels: - - bug - - youtube - - subtitles -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube/manual-subs.ts - - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube/orchestrator.ts - - 'https://www.youtube.com/watch?v=MXzQRLmN9hE' -priority: high -ordinal: 64500 ---- - -## Description - - -Ensure launcher YouTube subtitle generation reuses downloadable manual subtitle tracks when the video already has requested languages available, instead of falling back to whisper generation. Reproduce against videos like MXzQRLmN9hE that expose manual en/ja subtitles via yt-dlp. - - -## Acceptance Criteria - -- [x] #1 When requested primary/secondary manual YouTube subtitle tracks exist, planning selects them and schedules no whisper generation for those tracks. -- [x] #2 Filename normalization handles manual subtitle outputs produced by yt-dlp for language-tagged downloads. -- [x] #3 Automated tests cover the reproduced manual en/ja selection case. - - -## Implementation Notes - - -Reproduced against https://www.youtube.com/watch?v=MXzQRLmN9hE with yt-dlp --list-subs: manual zh/en/ja/ko subtitle tracks are available from YouTube. - -Adjusted launcher YouTube orchestration so detected manual subtitle tracks suppress whisper generation but are no longer materialized as external subtitle files. SubMiner now relies on the native YouTube/mpv subtitle tracks for those languages. - -Added orchestration tests covering the manual-track reuse plan and ran a direct runtime probe against MXzQRLmN9hE. Probe result: primary/secondary native tracks detected, no external subtitle aliases emitted, output directory remained empty. - -Verification: bun test launcher/youtube/orchestrator.test.ts launcher/config-domain-parsers.test.ts launcher/mpv.test.ts passed; bun run typecheck passed. - - -## Final Summary - - -Fixed the YouTube subtitle regression where videos with real downloadable subtitle tracks still ended up with duplicate external subtitle files. Manual subtitle availability now suppresses whisper generation and external subtitle publication, so videos like MXzQRLmN9hE use the native YouTube/mpv subtitle tracks directly. Launcher preprocess logging was also updated to report native subtitle availability instead of misleading missing statuses. - diff --git a/backlog/completed/task-122 - Harden-changelog-workflow-and-CI-enforcement.md b/backlog/completed/task-122 - Harden-changelog-workflow-and-CI-enforcement.md deleted file mode 100644 index ff54c8a2..00000000 --- a/backlog/completed/task-122 - Harden-changelog-workflow-and-CI-enforcement.md +++ /dev/null @@ -1,72 +0,0 @@ ---- -id: TASK-122 -title: Harden changelog workflow and CI enforcement -status: Done -assignee: - - Codex -created_date: '2026-03-08 06:13' -updated_date: '2026-03-16 05:13' -labels: - - release - - changelog - - ci -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/scripts/build-changelog.ts - - /Users/sudacode/projects/japanese/SubMiner/scripts/build-changelog.test.ts - - /Users/sudacode/projects/japanese/SubMiner/.github/workflows/ci.yml - - /Users/sudacode/projects/japanese/SubMiner/.github/workflows/release.yml - - /Users/sudacode/projects/japanese/SubMiner/docs/RELEASING.md - - /Users/sudacode/projects/japanese/SubMiner/changes/README.md -priority: medium -ordinal: 63500 ---- - -## Description - - -Improve the release changelog workflow so changelog fragments are reliable, release output is more readable, and pull requests get early feedback when changelog metadata is missing or malformed. - - -## Acceptance Criteria - -- [x] #1 `scripts/build-changelog.ts` ignores non-fragment files in `changes/` and validates fragment structure before generating changelog output. -- [x] #2 Generated `CHANGELOG.md` and `release/release-notes.md` group public changes into readable sections instead of a flat bullet list. -- [x] #3 CI enforces changelog validation on pull requests and provides an explicit opt-out path for changes that should not produce release notes. -- [x] #4 Contributor docs explain the fragment format and the PR/release workflow for changelog generation. -- [x] #5 Automated tests cover fragment parsing/building behavior and workflow enforcement expectations. - - -## Implementation Plan - - -1. Add failing tests for changelog fragment discovery, structured fragment parsing/rendering, release-note output, and CI workflow expectations. -2. Update scripts/build-changelog.ts to ignore non-fragment files, parse fragment metadata, group generated output by change type, add lint/PR-check commands, and simplify output paths to repo-local artifacts. -3. Update CI and PR workflow files to run changelog validation on pull requests with an explicit skip path, and keep release workflow using committed changelog output. -4. Refresh changes/README.md, docs/RELEASING.md, and any PR template text so contributors know how to write fragments and when opt-out is allowed. -5. Run targeted tests and changelog commands, then record results and finalize the task. - - -## Implementation Notes - - -Implemented structured changelog fragments with required `type` and `area` metadata; `changes/README.md` is now ignored by the generator and verified by regression tests. - -Added `changelog:lint` and `changelog:pr-check`, plus PR CI enforcement with `skip-changelog` opt-out. PR check now reads git name-status output so deleted fragment files do not satisfy the requirement. - -Changed generated changelog/release notes output to grouped sections (`Added`, `Changed`, `Fixed`, etc.) and simplified release notes to highlights + install/assets pointers. - -Kept changelog output repo-local. This aligns with existing repo direction where docs updates happen in the sibling docs repo explicitly rather than implicit local writes from app-repo generators. - -Verification: `bun test scripts/build-changelog.test.ts src/ci-workflow.test.ts src/release-workflow.test.ts` passed; `bun run typecheck` passed; `bun run changelog:lint` passed. `bun run test:fast` still fails in unrelated existing `src/core/services/subsync.test.ts` cases (`runSubsyncManual keeps internal alass source file alive until sync finishes`, `runSubsyncManual resolves string sid values from mpv stream properties`). - - -## Final Summary - - -Hardened the changelog workflow end-to-end. `scripts/build-changelog.ts` now ignores helper files like `changes/README.md`, requires structured fragment metadata (`type` + `area`), groups generated release sections by change type, and emits shorter release notes focused on highlights plus install/assets pointers. Added explicit `changelog:lint` and `changelog:pr-check` commands, with PR validation based on git name-status so deleted fragment files do not satisfy the fragment requirement. - -Updated contributor-facing workflow docs in `changes/README.md`, `docs/RELEASING.md`, and a new PR template so authors know to add a fragment or apply the `skip-changelog` label. CI now runs fragment linting on every run and enforces fragment presence on pull requests. Added regression coverage in `scripts/build-changelog.test.ts` and a new `src/ci-workflow.test.ts` to lock the workflow contract. - -Verification completed: `bun test scripts/build-changelog.test.ts src/ci-workflow.test.ts src/release-workflow.test.ts`, `bun run typecheck`, and `bun run changelog:lint` all passed. A broader `bun run test:fast` run still fails in unrelated existing `src/core/services/subsync.test.ts` cases outside the changelog/workflow scope. - diff --git a/backlog/completed/task-123 - Add-progress-logging-for-YouTube-subtitle-generation-phases.md b/backlog/completed/task-123 - Add-progress-logging-for-YouTube-subtitle-generation-phases.md deleted file mode 100644 index 450a594a..00000000 --- a/backlog/completed/task-123 - Add-progress-logging-for-YouTube-subtitle-generation-phases.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-123 -title: Add progress logging for YouTube subtitle generation phases -status: Done -assignee: - - '@codex' -created_date: '2026-03-08 07:07' -updated_date: '2026-03-16 05:13' -labels: - - ux - - logging - - youtube - - subtitles -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube/orchestrator.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube/audio-extraction.ts - - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube/whisper.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/youtube/subtitle-fix-ai.ts -priority: medium -ordinal: 62500 ---- - -## Description - - -Improve launcher YouTube subtitle generation observability so users can tell that work is happening and roughly how long each phase is taking. Cover manual subtitle probe, audio extraction, ffmpeg prep, whisper generation, and optional AI subtitle fix phases without flooding normal logs. - - -## Acceptance Criteria - -- [x] #1 Users see clear info-level phase logs for YouTube subtitle generation work including subtitle probe, fallback audio extraction, whisper, and optional AI fix phases. -- [x] #2 Long-running phases surface elapsed-time progress or explicit start/finish timing so it is obvious the process is still active. -- [x] #3 Automated tests cover the new logging/progress helper behavior where practical. - - -## Implementation Notes - - -Implemented a shared timed YouTube phase logger in launcher/youtube/progress.ts with info-level start/finish messages and warn-level failure messages that include elapsed time. - -Wired phase logging into YouTube metadata probe, manual subtitle probe, fallback audio extraction, ffmpeg whisper prep, whisper primary/secondary generation, and optional AI subtitle fix phases. - -Verification: bun test launcher/youtube/progress.test.ts launcher/youtube/orchestrator.test.ts passed; bun run typecheck passed. - - -## Final Summary - - -Added clear phase-level observability for YouTube subtitle generation without noisy tool output. Users now see start/finish logs with elapsed time for subtitle probe, fallback audio extraction, ffmpeg prep, whisper generation, and optional AI subtitle-fix phases, making it obvious when generation is active and roughly how long each step took. - diff --git a/backlog/completed/task-124 - Remove-YouTube-subtitle-generation-modes-and-make-YouTube-playback-always-generate-load-subtitles.md b/backlog/completed/task-124 - Remove-YouTube-subtitle-generation-modes-and-make-YouTube-playback-always-generate-load-subtitles.md deleted file mode 100644 index 72f4e874..00000000 --- a/backlog/completed/task-124 - Remove-YouTube-subtitle-generation-modes-and-make-YouTube-playback-always-generate-load-subtitles.md +++ /dev/null @@ -1,77 +0,0 @@ ---- -id: TASK-124 -title: >- - Remove YouTube subtitle generation modes and make YouTube playback always - generate/load subtitles -status: Done -assignee: - - codex -created_date: '2026-03-08 07:18' -updated_date: '2026-03-16 05:13' -labels: - - launcher - - youtube - - subtitles -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/commands/playback-command.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/config/args-normalizer.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/config/youtube-subgen-config.ts - - /Users/sudacode/projects/japanese/SubMiner/launcher/types.ts - - /Users/sudacode/projects/japanese/SubMiner/config.example.jsonc - - >- - /Users/sudacode/projects/japanese/SubMiner/src/config/definitions/options-integrations.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/config/resolve/subtitle-domains.ts -priority: high -ordinal: 61500 ---- - -## Description - - -Simplify launcher YouTube playback by removing the configurable subtitle generation mode. For YouTube targets, the launcher should treat subtitle generation/loading as the canonical behavior instead of supporting off/preprocess/automatic branches. This change should remove the unreliable automatic/background path and the mode concept from config/CLI/env/docs, while preserving the core YouTube subtitle generation pipeline and mpv loading flow. - - -## Acceptance Criteria - -- [x] #1 Launcher playback no longer supports or branches on a YouTube subtitle generation mode; YouTube URLs follow a single generation-and-load flow. -- [x] #2 Configuration, CLI parsing, and environment handling no longer expose a YouTube subtitle generation mode option, and stale automatic/preprocess/off values are not part of the supported interface. -- [x] #3 Tests cover the new single-flow behavior and the removal of mode parsing/branching. -- [x] #4 User-facing config/docs/examples are updated to reflect the removed mode concept. - - -## Implementation Plan - - -1. Remove the YouTube subtitle generation mode concept from launcher/shared types, config parsing, CLI options, and environment normalization so no supported interface accepts automatic/preprocess/off. -2. Update playback orchestration so YouTube targets always run subtitle generation/loading before mpv startup and delete the background automatic path. -3. Adjust mpv YouTube URL argument construction to no longer branch on mode while preserving subtitle/audio language behavior and preloaded subtitle file injection. -4. Add/modify tests first to cover removed mode parsing and the single YouTube preload flow, then update config/docs/examples to match the simplified interface. -5. Run focused launcher/config tests plus typecheck, then summarize any remaining gaps. - - -## Implementation Notes - - -Removed launcher/shared youtubeSubgen.mode handling and collapsed YouTube playback onto a single preload-before-mpv subtitle generation flow. - -Added launcher integration coverage proving YouTube subtitle generation runs before mpv startup and that the removed --mode flag now errors. - -Verification: bun test launcher/config-domain-parsers.test.ts launcher/parse-args.test.ts launcher/mpv.test.ts launcher/main.test.ts src/config/config.test.ts; bun run test:config:src; bun run typecheck. - -Broader repo checks still show pre-existing issues outside this change: bun run test:launcher:unit:src fails in launcher/aniskip-metadata.test.ts (MAL id assertion), and format scope check reports unrelated existing files launcher/youtube/orchestrator.ts, scripts/build-changelog.test.ts, scripts/build-changelog.ts. - - -## Final Summary - - -Removed the launcher YouTube subtitle generation mode surface so YouTube playback now always runs the subtitle generation pipeline before starting mpv. The launcher no longer accepts youtubeSubgen.mode from shared config, CLI, or env normalization, and the old automatic/background loading path has been deleted from playback. - -Updated mpv YouTube startup options to keep manual subtitle discovery enabled without requesting auto subtitles, and refreshed user-facing config/docs to describe a single YouTube subtitle generation flow. Added regression coverage for mode removal, config/template cleanup, and launcher ordering so YouTube subtitle work is confirmed to happen before mpv launch. - -Verification: bun test launcher/config-domain-parsers.test.ts launcher/parse-args.test.ts launcher/mpv.test.ts launcher/main.test.ts src/config/config.test.ts; bun run test:config:src; bun run typecheck. Broader unrelated repo issues remain in launcher/aniskip-metadata.test.ts and existing formatting drift in launcher/youtube/orchestrator.ts plus scripts/build-changelog files. - diff --git a/backlog/completed/task-126 - Improve-secondary-subtitle-readability-with-hover-only-background-and-stronger-text-separation.md b/backlog/completed/task-126 - Improve-secondary-subtitle-readability-with-hover-only-background-and-stronger-text-separation.md deleted file mode 100644 index ef0554ec..00000000 --- a/backlog/completed/task-126 - Improve-secondary-subtitle-readability-with-hover-only-background-and-stronger-text-separation.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-126 -title: >- - Improve secondary subtitle readability with hover-only background and stronger - text separation -status: Done -assignee: [] -created_date: '2026-03-08 07:35' -updated_date: '2026-03-16 05:13' -labels: - - overlay - - subtitles - - ui -dependencies: [] -priority: medium -ordinal: 60500 ---- - -## Description - - -Adjust overlay secondary subtitle styling so translation text stays readable on bright video backgrounds. Keep the dark background hidden by default in hover mode and show it only while hovered. Increase secondary subtitle weight to 600 and strengthen edge separation without changing primary subtitle styling. - - -## Acceptance Criteria - -- [x] #1 Secondary subtitles render with stronger edge separation than today. -- [x] #2 Secondary subtitle font weight defaults to 600. -- [x] #3 When secondary subtitle mode is hover, the secondary background appears only while hovered. -- [x] #4 Primary subtitle styling behavior remains unchanged. -- [x] #5 Renderer tests cover the new secondary hover background behavior and default secondary style values. - - -## Implementation Notes - - -Adjusted secondary subtitle defaults to use stronger shadowing, 600 font weight, and a translucent dark background. Routed secondary background/backdrop styling through CSS custom properties so hover mode can keep the background hidden until the secondary subtitle is actually hovered. Added renderer and config tests covering default values and hover-only background behavior. - - -## Final Summary - - -Improved secondary subtitle readability by strengthening default text separation, increasing the default secondary weight to 600, and making the configured dark background appear only while hovered in secondary hover mode. Added config and renderer coverage for the new defaults and hover-aware style routing. - diff --git a/backlog/completed/task-127 - Skip-AniSkip-lookup-for-YouTube-and-URL-playback-targets.md b/backlog/completed/task-127 - Skip-AniSkip-lookup-for-YouTube-and-URL-playback-targets.md deleted file mode 100644 index 98b4e867..00000000 --- a/backlog/completed/task-127 - Skip-AniSkip-lookup-for-YouTube-and-URL-playback-targets.md +++ /dev/null @@ -1,84 +0,0 @@ ---- -id: TASK-127 -title: Skip AniSkip lookup for YouTube and URL playback targets -status: Done -assignee: - - '@codex' -created_date: '2026-03-08 08:24' -updated_date: '2026-03-16 05:13' -labels: - - bug - - launcher - - youtube -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/launcher/mpv.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/commands/playback-command.ts - - /Users/sudacode/projects/japanese/SubMiner/launcher/mpv.test.ts -ordinal: 56500 ---- - -## Description - - -Prevent launcher playback from attempting AniSkip metadata resolution when the user is playing a YouTube target or any URL target. AniSkip only works for local anime files, so URL-driven playback and YouTube subtitle-generation flows should bypass it entirely. - - -## Acceptance Criteria - -- [x] #1 Launcher playback skips AniSkip metadata resolution for explicit URL targets, including YouTube URLs. -- [x] #2 YouTube subtitle-generation playback does not invoke AniSkip lookup before mpv launch. -- [x] #3 Automated launcher tests cover the URL/YouTube skip behavior. - - -## Implementation Plan - - -1. Add a launcher mpv unit test that intercepts AniSkip resolution and proves URL/YouTube playback does not call it before spawning mpv. -2. Run the focused launcher mpv test to confirm the new case fails or exposes the current gap. -3. Patch launcher playback/AniSkip gating so URL and YouTube subtitle-generation paths always bypass AniSkip lookup. -4. Re-run focused launcher tests and record the verification results in task notes. - -5. Add a Lua plugin regression test covering overlay-start on URL playback so AniSkip never runs after auto-start. - -6. Patch plugin/subminer/aniskip.lua to short-circuit all AniSkip lookup triggers for remote URL media paths. - -7. Re-run plugin regression plus touched launcher checks and update the task summary with the plugin-side fix. - - -## Implementation Notes - - -Added explicit AniSkip gating in launcher/mpv.ts via shouldResolveAniSkipMetadata(target, targetKind, preloadedSubtitles). - -URL targets now always bypass AniSkip. File targets with preloaded subtitles also bypass AniSkip, covering YouTube subtitle-preload playback. - -Added launcher/mpv.test.ts coverage for local-file vs URL vs preloaded-subtitle AniSkip gating. - -Verification: bun test launcher/mpv.test.ts passed. - -Verification: bun run typecheck passed. - -Verification: bunx prettier --check launcher/mpv.ts launcher/mpv.test.ts passed. - -Verification: bun run changelog:lint passed. - -Verification: bun run test:launcher:unit:src remains blocked by unrelated existing failure in launcher/aniskip-metadata.test.ts (`resolveAniSkipMetadataForFile resolves MAL id and intro payload`: expected malId 1234, got null). - -Added plugin regression in scripts/test-plugin-start-gate.lua for URL playback with auto-start/overlay-start; it now asserts no MAL or AniSkip curl requests occur. - -Patched plugin/subminer/aniskip.lua to short-circuit AniSkip lookup for remote media paths (`scheme://...`), which covers YouTube URL playback inside the mpv plugin lifecycle. - -Verification: lua scripts/test-plugin-start-gate.lua passed. - -Verification: bun run test:plugin:src passed. - -Verification: bun test launcher/mpv.test.ts passed after plugin-side fix. - - -## Final Summary - - -Fixed AniSkip suppression end-to-end for URL playback. The launcher now skips AniSkip before mpv launch, and the mpv plugin now also refuses AniSkip lookups for remote URL media during file-loaded, overlay-start, or later refresh triggers. Added regression coverage in both launcher/mpv.test.ts and scripts/test-plugin-start-gate.lua, plus a changelog fragment. Wider `bun run test:launcher:unit:src` is still blocked by the unrelated existing launcher/aniskip-metadata.test.ts MAL-id failure. - diff --git a/backlog/completed/task-128 - Prevent-AI-subtitle-fix-from-translating-primary-YouTube-subtitles-into-the-wrong-language.md b/backlog/completed/task-128 - Prevent-AI-subtitle-fix-from-translating-primary-YouTube-subtitles-into-the-wrong-language.md deleted file mode 100644 index 0131d935..00000000 --- a/backlog/completed/task-128 - Prevent-AI-subtitle-fix-from-translating-primary-YouTube-subtitles-into-the-wrong-language.md +++ /dev/null @@ -1,36 +0,0 @@ ---- -id: TASK-128 -title: >- - Prevent AI subtitle fix from translating primary YouTube subtitles into the - wrong language -status: Done -assignee: [] -created_date: '2026-03-08 09:02' -updated_date: '2026-03-16 05:13' -labels: - - bug - - youtube-subgen - - ai -dependencies: [] -priority: high -ordinal: 58500 ---- - -## Description - - -AI subtitle cleanup can preserve cue structure while changing subtitle language, causing primary Japanese subtitle files to come back in English. Add guards so AI-fixed subtitles preserve expected language and fall back to raw Whisper output when language drifts. - - -## Acceptance Criteria - -- [x] #1 Primary AI subtitle fix rejects output that drifts away from the expected source language. -- [x] #2 Rejected AI fixes fall back to the raw Whisper subtitle without corrupting published subtitle language. -- [x] #3 Regression tests cover a primary Japanese subtitle batch being translated into English by the AI fixer. - - -## Final Summary - - -Added a primary-language guard to AI subtitle fixing so Japanese source subtitles are rejected if the AI rewrites them into English while preserving SRT structure. The fixer now receives the expected source language from the YouTube orchestrator, and regression coverage verifies that language drift falls back to the raw Whisper subtitle path. - diff --git a/backlog/completed/task-129 - Split-AI-model-and-system-prompt-config-between-Anki-and-YouTube-subtitle-generation.md b/backlog/completed/task-129 - Split-AI-model-and-system-prompt-config-between-Anki-and-YouTube-subtitle-generation.md deleted file mode 100644 index 2e569d33..00000000 --- a/backlog/completed/task-129 - Split-AI-model-and-system-prompt-config-between-Anki-and-YouTube-subtitle-generation.md +++ /dev/null @@ -1,38 +0,0 @@ ---- -id: TASK-129 -title: >- - Split AI model and system prompt config between Anki and YouTube subtitle - generation -status: Done -assignee: [] -created_date: '2026-03-08 09:40' -updated_date: '2026-03-16 05:13' -labels: - - config - - ai - - anki - - youtube-subgen -dependencies: [] -priority: high -ordinal: 57500 ---- - -## Description - - -The current top-level shared AI config forces Anki translation and YouTube subtitle fixing to share the same model and system prompt, which caused subtitle-fix requests to inherit a translation prompt and translate Japanese primary subtitles into English. Refactor config so provider credentials stay shared while model and system prompt can be configured per feature. - - -## Acceptance Criteria - -- [x] #1 Anki integration can use its own AI model and system prompt independently of YouTube subtitle generation. -- [x] #2 YouTube subtitle generation can use its own AI model and system prompt independently of Anki integration. -- [x] #3 Existing shared provider credentials remain reusable without duplicating API key/base URL config. -- [x] #4 Config example, defaults, validation, and regression tests cover the new per-feature override shape. - - -## Final Summary - - -Added per-feature AI model/systemPrompt overrides for Anki and YouTube subtitle generation while keeping shared provider transport settings reusable. Anki now accepts `ankiConnect.ai` object config with `enabled`, `model`, and `systemPrompt`; YouTube subtitle generation accepts `youtubeSubgen.ai` overrides and merges them over the shared AI provider config. Updated config resolution, launcher parsing, runtime wiring, hot-reload handling, example config, and regression coverage. - diff --git a/backlog/completed/task-130 - Keep-background-SubMiner-alive-after-launcher-managed-mpv-exits.md b/backlog/completed/task-130 - Keep-background-SubMiner-alive-after-launcher-managed-mpv-exits.md deleted file mode 100644 index bc04793a..00000000 --- a/backlog/completed/task-130 - Keep-background-SubMiner-alive-after-launcher-managed-mpv-exits.md +++ /dev/null @@ -1,78 +0,0 @@ ---- -id: TASK-130 -title: Keep background SubMiner alive after launcher-managed mpv exits -status: Done -assignee: - - codex -created_date: '2026-03-08 10:08' -updated_date: '2026-03-16 05:13' -labels: - - bug - - launcher - - mpv - - overlay -dependencies: [] -priority: high -ordinal: 55500 ---- - -## Description - - -The launcher currently tears down the running SubMiner background process when a launcher-managed mpv session exits. Background SubMiner should remain alive so a later mpv instance can reconnect and request the overlay without restarting the app. - - -## Acceptance Criteria - -- [x] #1 Closing a launcher-managed mpv session does not send `--stop` to the running SubMiner background process. -- [x] #2 Closing a launcher-managed mpv session does not SIGTERM the tracked SubMiner process just because mpv exited. -- [x] #3 Launcher cleanup still terminates mpv and launcher-owned helper children without regressing existing overlay start behavior. -- [x] #4 Automated tests cover the no-stop-on-mpv-exit behavior. - - -## Implementation Plan - - -1. Add a launcher regression test that proves mpv exit no longer triggers SubMiner `--stop` or launcher SIGTERM of the tracked overlay process. -2. Update launcher teardown so normal mpv-session cleanup only stops mpv/helper children and preserves the background SubMiner process for future reconnects. -3. Run the focused launcher tests and smoke coverage for the affected behavior, then record results in the task. - - -## Implementation Notes - - -Split launcher cleanup so normal mpv-session shutdown no longer sends `--stop` to SubMiner or SIGTERM to the tracked overlay process. Added `cleanupPlaybackSession()` for mpv/helper-child cleanup only, and switched playback finalization to use it. - -Updated launcher smoke coverage to assert the background app stays alive after mpv exits, and added a focused unit regression for the new cleanup path. - -Validation: `bun test launcher/mpv.test.ts launcher/smoke.e2e.test.ts` passed; `bun run typecheck` passed. `bun run test:launcher:unit:src` still reports an unrelated pre-existing failure in `launcher/aniskip-metadata.test.ts`. - -Added changelog fragment `changes/task-130.md` for the launcher fix and verified it with `bun run changelog:lint`. - -User verified the bug still reproduces when closing playback with `q`. Root cause narrowed further: the mpv plugin `plugin/subminer/lifecycle.lua` calls `process.stop_overlay()` on mpv `shutdown`, which still sends SubMiner `--stop` even after launcher cleanup was fixed. - -Patched the remaining stop path in `plugin/subminer/lifecycle.lua`: mpv `shutdown` no longer calls `process.stop_overlay()`. Pressing mpv `q` should now preserve the background app and only tear down the mpv session. - -Validation update: `lua scripts/test-plugin-start-gate.lua` passed after adding a shutdown regression, and `bun test launcher/mpv.test.ts launcher/smoke.e2e.test.ts` still passed. - -Fixed a second-instance reconnect bug in `src/core/services/cli-command.ts`: `--start` on an already-initialized running instance now still updates the MPV socket path and reconnects the MPV client instead of treating the command as a no-op. This keeps the already-warmed background app reusable for later mpv launches. - - -## Final Summary - - -Kept the background SubMiner process reusable across both mpv shutdown and later reconnects. The first fix separated launcher playback cleanup from full app shutdown. The second fix removed the mpv plugin `shutdown` stop call so default mpv `q` no longer sends SubMiner `--stop`. The third fix corrected second-instance CLI handling so `--start` on an already-running, already-initialized instance still reconnects MPV instead of being ignored. - -Net effect: background SubMiner can stay alive, keep its warm state, and reconnect to later mpv instances without rerunning startup/warmup work in a fresh app instance. - -Coverage now includes: launcher playback cleanup (`launcher/mpv.test.ts`), launcher smoke reconnect/keep-alive flow (`launcher/smoke.e2e.test.ts`), mpv plugin shutdown preservation (`scripts/test-plugin-start-gate.lua`), and second-instance start/reconnect behavior (`src/core/services/cli-command.test.ts`). - -Tests run: - -- `bun test src/core/services/cli-command.test.ts launcher/mpv.test.ts launcher/smoke.e2e.test.ts` -- `lua scripts/test-plugin-start-gate.lua` -- `bun run typecheck` -- `bun run changelog:lint` - -Note: the broader `bun run test:launcher:unit:src` lane still has an unrelated pre-existing failure in `launcher/aniskip-metadata.test.ts`. - diff --git a/backlog/completed/task-131 - Make-default-overlay-fullscreen-and-AniSkip-end-jump-keybindings-easier-to-reach.md b/backlog/completed/task-131 - Make-default-overlay-fullscreen-and-AniSkip-end-jump-keybindings-easier-to-reach.md deleted file mode 100644 index d1916ba8..00000000 --- a/backlog/completed/task-131 - Make-default-overlay-fullscreen-and-AniSkip-end-jump-keybindings-easier-to-reach.md +++ /dev/null @@ -1,75 +0,0 @@ ---- -id: TASK-131 -title: >- - Make default overlay fullscreen and AniSkip end-jump keybindings easier to - reach -status: Done -assignee: - - codex -created_date: '2026-03-09 00:00' -updated_date: '2026-03-18 05:28' -labels: - - enhancement - - overlay - - mpv - - aniskip -dependencies: [] -ordinal: 43500 ---- - -## Description - - -Make two default keyboard actions easier to hit during playback: add `f` as the built-in overlay fullscreen toggle, and make AniSkip's default intro-end jump use `Tab`. - - -## Acceptance Criteria - -- [x] #1 Default overlay keybindings include `KeyF` mapped to mpv fullscreen toggle. -- [x] #2 Default AniSkip hint/button key defaults to `Tab` and the plugin registers that binding. -- [x] #3 Automated regression coverage exists for both default bindings. - - -## Implementation Plan - - -1. Add a failing TypeScript regression proving default overlay keybindings include fullscreen on `KeyF`. -2. Add a failing Lua/plugin regression proving AniSkip defaults to `Tab`, updates the OSD hint text, and registers the expected keybinding. -3. Patch the default keybinding/config values with minimal behavior changes and keep fallback binding behavior intentional. -4. Run focused tests plus touched verification commands, then record results and a short changelog fragment. - - -## Implementation Notes - - -Added `KeyF -> ['cycle', 'fullscreen']` to the built-in overlay keybindings in `src/config/definitions/shared.ts`. - -Changed the mpv plugin AniSkip default button key from `y-k` to `TAB` in both the runtime default options and the shipped `plugin/subminer.conf`. The AniSkip OSD hint now also falls back to `TAB` when no explicit key is configured. - -Adjusted `plugin/subminer/ui.lua` fallback registration so the legacy `y-k` binding is only added for custom non-default AniSkip bindings, instead of always shadowing the new default. - -Extended regression coverage: - -- `src/config/definitions/domain-registry.test.ts` now asserts the default fullscreen binding on `KeyF`. -- `scripts/test-plugin-start-gate.lua` now isolates plugin runs correctly, records keybinding/observer registration, and asserts the default AniSkip keybinding/prompt behavior for `TAB`. - -Verification: - -- `bun test src/config/definitions/domain-registry.test.ts` -- `bun run test:config:src` -- `lua scripts/test-plugin-start-gate.lua` -- `bun run changelog:lint` -- `bun run typecheck` - -Known unrelated verification gap: - -- `bun run test:plugin:src` still fails in `scripts/test-plugin-binary-windows.lua` on this Linux host (`windows env override should resolve .exe suffix`), outside the keybinding changes in this task. - - -## Final Summary - - -Default overlay playback now has an easier fullscreen toggle on `f`, and AniSkip's default intro-end jump now uses `Tab`. The mpv plugin hint text and registration logic were updated to match the new default, while keeping legacy `y-k` fallback behavior limited to custom non-default bindings. - -Regression coverage was added for both defaults, and the plugin test harness now resets plugin bootstrap state between scenarios so keybinding assertions can run reliably. - diff --git a/backlog/completed/task-132 - Gate-macOS-overlay-shortcuts-to-the-focused-mpv-window.md b/backlog/completed/task-132 - Gate-macOS-overlay-shortcuts-to-the-focused-mpv-window.md deleted file mode 100644 index 31d60bdf..00000000 --- a/backlog/completed/task-132 - Gate-macOS-overlay-shortcuts-to-the-focused-mpv-window.md +++ /dev/null @@ -1,70 +0,0 @@ ---- -id: TASK-132 -title: Gate macOS overlay shortcuts to the focused mpv window -status: Done -assignee: - - codex -created_date: '2026-03-08 18:24' -updated_date: '2026-03-18 05:28' -labels: - - bug - - macos - - shortcuts -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/overlay-shortcut.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/window-trackers/macos-tracker.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/scripts/get-mpv-window-macos.swift -priority: high -ordinal: 53500 ---- - -## Description - - -Fix the macOS shortcut handling so SubMiner overlay keybinds do not intercept system or other-app shortcuts while SubMiner is in the background. Overlay shortcuts should only be active while the tracked mpv window is present and focused, and should stop grabbing keyboard input when mpv is not the frontmost window. - - -## Acceptance Criteria - -- [x] #1 On macOS, overlay shortcuts do not trigger while mpv is not the focused/frontmost window. -- [x] #2 On macOS, overlay shortcuts remain available while the tracked mpv window is open and focused. -- [x] #3 Existing non-macOS shortcut behavior is unchanged. -- [x] #4 Automated tests cover the macOS focus-gating behavior and guard against background shortcut interception. -- [x] #5 Any user-facing docs/config notes affected by the behavior change are updated in the same task if needed. - - -## Implementation Plan - - -1. Add a failing macOS-focused shortcut lifecycle test that proves overlay shortcuts stay inactive when the tracked mpv window exists but is not frontmost, and activate when that tracked window becomes frontmost. -2. Add a failing tracker/helper test that covers the focused/frontmost signal parsed from the macOS helper output. -3. Extend the macOS helper/tracker contract to surface both geometry and focused/frontmost state for the tracked mpv window. -4. Wire overlay shortcut activation to require both overlay runtime initialization and tracked-mpv focus on macOS, while leaving non-macOS behavior unchanged. -5. Re-run the targeted shortcut/tracker tests, then the broader related shortcut/runtime suite, and update task notes/acceptance criteria based on results. - - -## Implementation Notes - - -Added a macOS-specific shortcut activation predicate so global overlay shortcuts now require both overlay runtime readiness and a focused tracked mpv window; non-macOS behavior still keys off runtime readiness only. - -Extended the base window tracker with optional focus-state callbacks/getters and wired initializeOverlayRuntime to re-sync overlay shortcuts whenever tracker focus changes. - -Updated the macOS helper/tracker contract to return geometry plus frontmost/focused state for the tracked mpv process and added parser coverage for focused and unfocused output. - -Verified with `bun x tsc -p tsconfig.json --noEmit`, targeted shortcut/tracker tests, and `bun run test:core:src` (439 passing). - -No user-facing config or documentation surface changed, so no docs update was required for this fix. - - -## Final Summary - - -Fixed the macOS background shortcut interception bug by gating SubMiner's global overlay shortcuts on tracked mpv focus instead of overlay-runtime initialization alone. The macOS window helper now reports whether the tracked mpv process is frontmost, the tracker exposes focus change callbacks, and overlay shortcut synchronization re-runs when that focus state flips so `Ctrl+C`/`Ctrl+V` and similar shortcuts are no longer captured while mpv is in the background. - -The change keeps existing non-macOS shortcut behavior unchanged. Added regression coverage for the activation decision, tracker focus-change re-sync, and macOS helper output parsing. Verification: `bun x tsc -p tsconfig.json --noEmit`, targeted shortcut/tracker tests, and `bun run test:core:src` (439 passing). - diff --git a/backlog/completed/task-134 - Harden-Windows-release-signing-against-transient-SignPath-failures.md b/backlog/completed/task-134 - Harden-Windows-release-signing-against-transient-SignPath-failures.md deleted file mode 100644 index b34e942a..00000000 --- a/backlog/completed/task-134 - Harden-Windows-release-signing-against-transient-SignPath-failures.md +++ /dev/null @@ -1,67 +0,0 @@ ---- -id: TASK-134 -title: Harden Windows release signing against transient SignPath failures -status: Done -assignee: - - codex -created_date: '2026-03-09 00:00' -updated_date: '2026-03-18 05:28' -labels: - - ci - - release - - windows - - signing -dependencies: [] -references: - - .github/workflows/release.yml - - package.json - - src/release-workflow.test.ts - - 'https://github.com/ksyasuda/SubMiner/actions/runs/22836585479' -priority: high -ordinal: 52500 ---- - -## Description - - -The tag-driven Release workflow currently fails the Windows lane if the SignPath connector returns transient 502 errors during submission, and the tagged build scripts also allow electron-builder to implicitly publish unsigned artifacts before the final release job runs. Harden the workflow so transient SignPath outages get bounded retries and release packaging never auto-publishes unsigned assets. - - -## Acceptance Criteria - -- [ ] #1 Windows release signing retries transient SignPath submission failures within the release workflow before failing the job. -- [ ] #2 Release packaging scripts disable electron-builder implicit publish so build jobs do not upload unsigned assets on tag builds. -- [ ] #3 Regression coverage fails if SignPath retry scaffolding or publish suppression is removed. - - -## Implementation Plan - - -1. Add a regression test for the release workflow/package script shape covering SignPath retries and `--publish never`. -2. Patch the Windows release job to retry SignPath submission a bounded number of times and still fail hard if every attempt fails. -3. Update tagged package build scripts to disable implicit electron-builder publishing during release builds. -4. Run targeted release-workflow verification and capture any remaining manual release cleanup needed for `v0.5.0`. - - -## Implementation Notes - - -The failed Windows signing step in GitHub Actions run `22836585479` was not caused by missing secrets or an artifact-shape mismatch. The SignPath GitHub action retried repeated `502` responses from the SignPath connector for several minutes and then failed the job. - -Hardened `.github/workflows/release.yml` by replacing the single SignPath submission with three bounded attempts. The second and third submissions only run if the previous attempt failed, and the job now fails with an explicit rerun message only after all three attempts fail. Signed-artifact upload is keyed to the successful attempt so the release job still consumes the normal `windows` artifact name. - -Also fixed a separate release regression exposed by the same run: `electron-builder` was implicitly publishing unsigned release assets during tag builds because the packaging scripts did not set `--publish never` and the workflow injected `GH_TOKEN` into build jobs. Updated the relevant package scripts to pass `--publish never`, removed `GH_TOKEN` from the packaging jobs, and made the final publish step force `--draft=false` when editing an existing tag release so previously-created draft releases get published. - -Verification: `bun test src/release-workflow.test.ts`, `bun run typecheck`, and `bun run test:fast` all passed locally after restoring the missing local `libsql` install with `bun install --frozen-lockfile`. - - -## Final Summary - - -Windows release signing is now resilient to transient SignPath connector outages. The release workflow retries the SignPath submission up to three times before failing, and only uploads the signed Windows artifact from the attempt that succeeded. - -Release packaging also no longer auto-publishes unsigned assets on tag builds. The `electron-builder` scripts now force `--publish never`, the build jobs no longer pass `GH_TOKEN` into packaging steps, and the final GitHub release publish step explicitly clears draft state when updating an existing tag release. - -Validation: `bun test src/release-workflow.test.ts`, `bun run typecheck`, `bun run test:fast`. -Manual follow-up for the failed `v0.5.0` release: rerun the `Release` workflow after merging/pushing this fix, then clean up the stray draft/untagged release assets created by the failed run if they remain. - diff --git a/backlog/completed/task-135 - Cut-patch-release-v0.5.1-for-Windows-signing-fix.md b/backlog/completed/task-135 - Cut-patch-release-v0.5.1-for-Windows-signing-fix.md deleted file mode 100644 index 23df28c2..00000000 --- a/backlog/completed/task-135 - Cut-patch-release-v0.5.1-for-Windows-signing-fix.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-135 -title: Cut patch release v0.5.1 for Windows signing fix -status: Done -assignee: - - codex -created_date: '2026-03-08 20:24' -updated_date: '2026-03-18 05:28' -labels: - - release - - patch -dependencies: - - TASK-134 -references: - - package.json - - CHANGELOG.md - - release/release-notes.md -priority: high -ordinal: 51500 ---- - -## Description - - -Publish a patch release from the workflow-signing fix on `main` by bumping the app version, generating the committed changelog artifacts for the new version, and pushing a new `v0.5.1` tag instead of rewriting the failed `v0.5.0` tag. - - -## Acceptance Criteria - -- [ ] #1 Repository version metadata is updated to `0.5.1`. -- [ ] #2 `CHANGELOG.md` and `release/release-notes.md` contain the committed `v0.5.1` section and released fragments are removed. -- [ ] #3 New `v0.5.1` commit and tag are pushed to `origin`. - - -## Implementation Plan - - -1. Bump the package version to `0.5.1`. -2. Run the changelog builder so `CHANGELOG.md`/`release-notes.md` match the release workflow contract. -3. Run the relevant verification commands. -4. Commit the release-prep changes, create `v0.5.1`, and push both commit and tag. - - -## Implementation Notes - - -Bumped `package.json` from `0.5.0` to `0.5.1`, then ran `bun run changelog:build` so the committed release artifacts match the release workflow contract. That prepended the `v0.5.1` section to `CHANGELOG.md`, regenerated `release/release-notes.md`, and removed the consumed changelog fragments from `changes/`. - -Verification before tagging: `bun run changelog:lint`, `bun run changelog:check --version 0.5.1`, `bun run typecheck`, and `bun run test:fast`. - - -## Final Summary - - -Prepared patch release `v0.5.1` from the signing-workflow fix on `main` instead of rewriting the failed `v0.5.0` tag. Repository version metadata, changelog, and committed release notes are all aligned with the new release tag, and the consumed changelog fragments were removed. - -Validation: `bun run changelog:lint`, `bun run changelog:check --version 0.5.1`, `bun run typecheck`, `bun run test:fast`. - diff --git a/backlog/completed/task-136 - Pin-SignPath-artifact-configuration-in-release-workflow.md b/backlog/completed/task-136 - Pin-SignPath-artifact-configuration-in-release-workflow.md deleted file mode 100644 index f6d9376c..00000000 --- a/backlog/completed/task-136 - Pin-SignPath-artifact-configuration-in-release-workflow.md +++ /dev/null @@ -1,62 +0,0 @@ ---- -id: TASK-136 -title: Pin SignPath artifact configuration in release workflow -status: Done -assignee: - - codex -created_date: '2026-03-08 20:41' -updated_date: '2026-03-18 05:28' -labels: - - ci - - release - - windows - - signing -dependencies: - - TASK-134 -references: - - .github/workflows/release.yml - - build/signpath-windows-artifact-config.xml - - src/release-workflow.test.ts -priority: high -ordinal: 49500 ---- - -## Description - - -The Windows release workflow currently relies on the default SignPath artifact configuration configured in the SignPath UI. Pin the workflow to an explicit artifact-configuration slug so the checked-in signing configuration and CI behavior stay deterministic across future SignPath project changes. - - -## Acceptance Criteria - -- [ ] #1 The Windows release workflow validates a dedicated SignPath artifact-configuration secret/input. -- [ ] #2 Every SignPath submission attempt passes `artifact-configuration-slug`. -- [ ] #3 Regression coverage fails if the explicit SignPath artifact-configuration binding is removed. - - -## Implementation Plan - - -1. Add a failing workflow regression test for the explicit SignPath artifact-configuration slug. -2. Patch the Windows signing secret validation and SignPath action inputs to require the slug. -3. Run targeted release-workflow verification plus the standard fast lane. -4. Cut a new patch release so the tag-triggered release workflow runs with the pinned SignPath configuration. - - -## Implementation Notes - - -Added regression coverage in `src/release-workflow.test.ts` for an explicit SignPath artifact-configuration slug so the release workflow test now fails if the slug validation or action input is removed. - -Patched `.github/workflows/release.yml` so Windows signing now requires `SIGNPATH_ARTIFACT_CONFIGURATION_SLUG` during secret validation and passes `artifact-configuration-slug: ${{ secrets.SIGNPATH_ARTIFACT_CONFIGURATION_SLUG }}` on every SignPath submission attempt. - -Verification: `bun test src/release-workflow.test.ts`, `bun run typecheck`, `bun run test:fast`. - - -## Final Summary - - -The release workflow is now pinned to an explicit SignPath artifact configuration instead of relying on whichever SignPath artifact config is marked default in the UI. Windows signing secret validation fails fast if `SIGNPATH_ARTIFACT_CONFIGURATION_SLUG` is missing, and every SignPath submission attempt now includes the pinned slug. - -Validation: `bun test src/release-workflow.test.ts`, `bun run typecheck`, `bun run test:fast`. - diff --git a/backlog/completed/task-137 - Cut-patch-release-v0.5.2-for-SignPath-artifact-config-pinning.md b/backlog/completed/task-137 - Cut-patch-release-v0.5.2-for-SignPath-artifact-config-pinning.md deleted file mode 100644 index f958d906..00000000 --- a/backlog/completed/task-137 - Cut-patch-release-v0.5.2-for-SignPath-artifact-config-pinning.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-137 -title: Cut patch release v0.5.2 for SignPath artifact config pinning -status: Done -assignee: - - codex -created_date: '2026-03-08 20:44' -updated_date: '2026-03-18 05:28' -labels: - - release - - patch -dependencies: - - TASK-136 -references: - - package.json - - CHANGELOG.md - - release/release-notes.md -priority: high -ordinal: 50500 ---- - -## Description - - -Publish a patch release from the SignPath artifact-configuration pinning change by bumping the app version, generating the committed changelog artifacts for the new version, and pushing a new `v0.5.2` tag. - - -## Acceptance Criteria - -- [ ] #1 Repository version metadata is updated to `0.5.2`. -- [ ] #2 `CHANGELOG.md` and `release/release-notes.md` contain the committed `v0.5.2` section and consumed fragments are removed. -- [ ] #3 New `v0.5.2` commit and tag are pushed to `origin`. - - -## Implementation Plan - - -1. Add the release fragment for the SignPath configuration pinning change. -2. Bump `package.json` to `0.5.2` and run the changelog builder. -3. Run changelog/typecheck/test verification. -4. Commit the release-prep change set, create `v0.5.2`, and push commit plus tag. - - -## Implementation Notes - - -Bumped `package.json` from `0.5.1` to `0.5.2`, ran `bun run changelog:build`, and committed the generated release artifacts. That prepended the `v0.5.2` section to `CHANGELOG.md`, regenerated `release/release-notes.md`, and removed the consumed `changes/signpath-artifact-config-pin.md` fragment. - -Verification before tagging: `bun run changelog:lint`, `bun run changelog:check --version 0.5.2`, `bun run typecheck`, and `bun run test:fast`. - - -## Final Summary - - -Prepared patch release `v0.5.2` so the explicit SignPath artifact-configuration pin ships on a fresh release tag. Version metadata, committed changelog artifacts, and release notes are aligned with the new patch version. - -Validation: `bun run changelog:lint`, `bun run changelog:check --version 0.5.2`, `bun run typecheck`, `bun run test:fast`. - diff --git a/backlog/completed/task-138 - Publish-unsigned-Windows-release-artifacts-and-add-local-unsigned-build-script.md b/backlog/completed/task-138 - Publish-unsigned-Windows-release-artifacts-and-add-local-unsigned-build-script.md deleted file mode 100644 index 7c0fab58..00000000 --- a/backlog/completed/task-138 - Publish-unsigned-Windows-release-artifacts-and-add-local-unsigned-build-script.md +++ /dev/null @@ -1,64 +0,0 @@ ---- -id: TASK-138 -title: Publish unsigned Windows release artifacts and add local unsigned build script -status: Done -assignee: - - codex -created_date: '2026-03-09 00:00' -updated_date: '2026-03-18 05:28' -labels: - - release - - windows -dependencies: [] -references: - - .github/workflows/release.yml - - package.json - - src/release-workflow.test.ts -priority: high -ordinal: 45500 ---- - -## Description - - -Stop the tag-driven release workflow from depending on SignPath and publish unsigned Windows `.exe` and `.zip` artifacts directly. Add an explicit local `build:win:unsigned` script without changing the existing `build:win` command. - - -## Acceptance Criteria - -- [x] #1 Windows release CI builds unsigned artifacts without requiring SignPath secrets. -- [x] #2 The Windows release job uploads `release/*.exe` and `release/*.zip` directly as the `windows` artifact. -- [x] #3 The repo exposes a local `build:win:unsigned` script for explicit unsigned Windows packaging. -- [x] #4 Regression coverage fails if the workflow reintroduces SignPath submission or drops the unsigned script. - - -## Implementation Plan - - -1. Update workflow regression tests to assert unsigned Windows release behavior and the new local script. -2. Patch `package.json` to add `build:win:unsigned`. -3. Patch `.github/workflows/release.yml` to build unsigned Windows artifacts and upload them directly. -4. Add the release changelog fragment and run focused verification. - - -## Implementation Notes - - -Removed the Windows SignPath secret validation and submission steps from `.github/workflows/release.yml`. The Windows release job now runs `bun run build:win:unsigned` and uploads `release/*.exe` and `release/*.zip` directly as the `windows` artifact consumed by the release job. - -Added `scripts/build-win-unsigned.mjs` plus the `build:win:unsigned` package script. The wrapper clears Windows code-signing environment variables and disables identity auto-discovery before invoking `electron-builder`, so release CI stays unsigned even if signing credentials are configured elsewhere. - -Updated `src/release-workflow.test.ts` to assert the unsigned workflow contract and added the release changelog fragment in `changes/unsigned-windows-release-builds.md`. - - -## Final Summary - - -Windows release CI now publishes unsigned artifacts directly and no longer depends on SignPath. Local developers also have an explicit `bun run build:win:unsigned` path for unsigned packaging without changing the existing `build:win` command. - -Verification: - -- `bun test src/release-workflow.test.ts` -- `bun run typecheck` -- `node --check scripts/build-win-unsigned.mjs` - diff --git a/backlog/completed/task-139 - Cut-patch-release-v0.5.3-for-unsigned-Windows-release-builds.md b/backlog/completed/task-139 - Cut-patch-release-v0.5.3-for-unsigned-Windows-release-builds.md deleted file mode 100644 index 2253b671..00000000 --- a/backlog/completed/task-139 - Cut-patch-release-v0.5.3-for-unsigned-Windows-release-builds.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-139 -title: Cut patch release v0.5.3 for unsigned Windows release builds -status: Done -assignee: - - codex -created_date: '2026-03-09 00:00' -updated_date: '2026-03-18 05:28' -labels: - - release - - patch -dependencies: - - TASK-138 -references: - - package.json - - CHANGELOG.md - - release/release-notes.md -priority: high -ordinal: 46500 ---- - -## Description - - -Publish a patch release from the unsigned Windows release-build change by bumping the app version, generating committed changelog artifacts for `v0.5.3`, and pushing the release-prep commit. - - -## Acceptance Criteria - -- [x] #1 Repository version metadata is updated to `0.5.3`. -- [x] #2 `CHANGELOG.md` and `release/release-notes.md` contain the committed `v0.5.3` section and consumed fragments are removed. -- [x] #3 New `v0.5.3` release-prep commit is pushed to `origin/main`. - - -## Implementation Plan - - -1. Bump `package.json` from `0.5.2` to `0.5.3`. -2. Run `bun run changelog:build` so committed changelog artifacts match the new patch version. -3. Run changelog/typecheck/test verification. -4. Commit the release-prep change set and push `main`. - - -## Implementation Notes - - -Bumped `package.json` from `0.5.2` to `0.5.3`, ran `bun run changelog:build`, and committed the generated release artifacts. That prepended the `v0.5.3` section to `CHANGELOG.md`, regenerated `release/release-notes.md`, and removed the consumed `changes/unsigned-windows-release-builds.md` fragment. - -Verification before push: `bun run changelog:lint`, `bun run changelog:check --version 0.5.3`, `bun run typecheck`, and `bun run test:fast`. - - -## Final Summary - - -Prepared patch release `v0.5.3` so the unsigned Windows release-build change is captured in committed release metadata on `main`. Version metadata, changelog output, and release notes are aligned with the new patch version. - -Validation: `bun run changelog:lint`, `bun run changelog:check --version 0.5.3`, `bun run typecheck`, `bun run test:fast`. - diff --git a/backlog/completed/task-140 - Fix-guessit-title-parsing-for-character-dictionary-sync.md b/backlog/completed/task-140 - Fix-guessit-title-parsing-for-character-dictionary-sync.md deleted file mode 100644 index a9961010..00000000 --- a/backlog/completed/task-140 - Fix-guessit-title-parsing-for-character-dictionary-sync.md +++ /dev/null @@ -1,41 +0,0 @@ ---- -id: TASK-140 -title: Fix guessit title parsing for character dictionary sync -status: Done -assignee: [] -created_date: '2026-03-09 00:00' -updated_date: '2026-03-18 05:28' -labels: - - dictionary - - anilist - - bug - - guessit -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/anilist/anilist-updater.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/anilist/anilist-updater.test.ts -priority: high -ordinal: 44500 ---- - -## Description - - -Fix AniList character dictionary auto-sync for filenames where `guessit` misparses the full path and our title extraction keeps only the first array segment, causing AniList resolution to match the wrong anime and abort merged dictionary refresh. - - -## Acceptance Criteria - -- [x] #1 AniList media guessing passes basename-only targets to `guessit` so parent folder names do not corrupt series title detection. -- [x] #2 Guessit title arrays are combined into one usable title instead of truncating to the first segment. -- [x] #3 Regression coverage includes the Bunny Girl Senpai filename shape that previously resolved to the wrong AniList entry. -- [x] #4 Verification confirms the targeted AniList guessing tests pass. - - -## Implementation Notes - - -Root repro: `guessit` parsed the Bunny Girl Senpai full path as `title: ["Rascal", "Does-not-Dream-of-Bunny-Girl-Senapi"]`, and our `firstString` helper kept only `Rascal`, which resolved to AniList 3490 (`rayca`) and produced zero character results. Fixed by sending basename-only input to `guessit` and joining multi-part guessit title arrays. - diff --git a/backlog/completed/task-141 - Refresh-current-subtitle-after-character-dictionary-sync-completes.md b/backlog/completed/task-141 - Refresh-current-subtitle-after-character-dictionary-sync-completes.md deleted file mode 100644 index fd8fd8f7..00000000 --- a/backlog/completed/task-141 - Refresh-current-subtitle-after-character-dictionary-sync-completes.md +++ /dev/null @@ -1,38 +0,0 @@ ---- -id: TASK-141 -title: Refresh current subtitle after character dictionary sync completes -status: Done -assignee: [] -created_date: '2026-03-09 00:00' -updated_date: '2026-03-18 05:28' -labels: - - dictionary - - overlay - - bug -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.ts - - /home/sudacode/projects/japanese/SubMiner/src/main.ts -priority: high -ordinal: 42500 ---- - -## Description - - -When character dictionary auto-sync finishes after startup tokenization, invalidate cached subtitle tokenization and refresh the current subtitle so character-name highlighting catches up without waiting for the next subtitle line. - - -## Acceptance Criteria - -- [x] #1 Successful character dictionary sync exposes a completion hook for main runtime follow-up. -- [x] #2 Main runtime clears Yomitan parser caches and refreshes the current subtitle after sync completion. -- [x] #3 Regression coverage verifies the sync completion callback fires on successful sync. - - -## Implementation Notes - - -Observed on Bunny Girl Senpai startup: autoplay/tokenization became ready around 8s, but snapshot/import/state write completed roughly 31s after launch, leaving the current subtitle tokenized without the newly imported character dictionary. Fixed by adding an auto-sync completion hook that clears parser caches and refreshes the current subtitle. - diff --git a/backlog/completed/task-142 - Show-character-dictionary-auto-sync-progress-on-OSD.md b/backlog/completed/task-142 - Show-character-dictionary-auto-sync-progress-on-OSD.md deleted file mode 100644 index 9922d04d..00000000 --- a/backlog/completed/task-142 - Show-character-dictionary-auto-sync-progress-on-OSD.md +++ /dev/null @@ -1,40 +0,0 @@ ---- -id: TASK-142 -title: Show character dictionary auto-sync progress on OSD -status: Done -assignee: [] -created_date: '2026-03-09 01:10' -updated_date: '2026-03-18 05:28' -labels: - - dictionary - - overlay - - ux -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync-notifications.ts - - /home/sudacode/projects/japanese/SubMiner/src/main.ts -priority: medium -ordinal: 41500 ---- - -## Description - - -When character dictionary auto-sync runs for a newly opened anime, surface progress so users know why character-name lookup/highlighting is temporarily unavailable via the mpv OSD without desktop notification popups. - - -## Acceptance Criteria - -- [x] #1 Character dictionary auto-sync emits progress events for syncing, importing, ready, and failure states. -- [x] #2 Main runtime routes those progress events through OSD notifications without desktop notifications. -- [x] #3 Regression coverage verifies progress events and notification routing behavior. - - -## Implementation Notes - - -OSD now shows auto-sync phase changes while the dictionary updates. Desktop notifications were removed for this path to avoid startup popup spam. - diff --git a/backlog/completed/task-143 - Keep-character-dictionary-auto-sync-non-blocking-during-startup.md b/backlog/completed/task-143 - Keep-character-dictionary-auto-sync-non-blocking-during-startup.md deleted file mode 100644 index 6fcf1496..00000000 --- a/backlog/completed/task-143 - Keep-character-dictionary-auto-sync-non-blocking-during-startup.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-143 -title: Keep character dictionary auto-sync non-blocking during startup -status: Done -assignee: - - codex -created_date: '2026-03-09 01:45' -updated_date: '2026-03-23 03:22' -labels: - - dictionary - - startup - - performance -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/main.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/current-media-tokenization-gate.ts -priority: high -ordinal: 144500 ---- - -## Description - - -Keep character dictionary auto-sync running in parallel during startup without delaying playback. Only tokenization readiness should gate playback; character dictionary import/settings updates should wait until tokenization is already ready and then refresh annotations afterward. - - -## Acceptance Criteria - -- [x] #1 Character dictionary snapshot/build work can run immediately during startup. -- [x] #2 Yomitan dictionary mutation work waits until current-media tokenization is ready. -- [x] #3 Regression coverage verifies auto-sync builds before the gate and only mutates Yomitan after the gate resolves. - - -## Implementation Plan - - -1. Add a regression test for startup autoplay release surviving delayed mpv readiness or late subtitle refresh after dictionary sync. -2. Harden the autoplay-ready release path so paused startup keeps retrying until mpv is actually released or media changes, without resuming user-paused playback later. -3. Keep the existing character-dictionary revisit fixes and paused-startup OSD fixes aligned with the autoplay change, then run targeted runtime tests and typecheck. - - -## Implementation Notes - - -Added a small current-media tokenization gate in main runtime. Media changes reset the gate, the first tokenization-ready event marks it ready, and auto-sync now waits on that gate only before Yomitan dictionary inspection/import/settings updates. Snapshot generation and merged ZIP build still run immediately in parallel. - -2026-03-20: User reports startup remains paused after annotations/tokenization are visible and only resumes after character-dictionary generation/import finishes. Investigating autoplay-ready release regression vs dictionary sync completion refresh. - -2026-03-20: Added startup autoplay retry-budget helper so paused startup retries cover the full plugin gate window instead of only ~2.8s. Verification: bun test src/main/runtime/startup-autoplay-release-policy.test.ts src/main/runtime/character-dictionary-auto-sync.test.ts src/main/runtime/startup-osd-sequencer.test.ts src/main/runtime/character-dictionary-auto-sync-completion.test.ts; bun run typecheck; bun run test:fast; bun run test:env; bun run build; bun run test:smoke:dist; runtime-compat verifier passed at .tmp/skill-verification/subminer-verify-20260320-022106-nM28Nk. Pending real installed-app/mpv validation. - diff --git a/backlog/completed/task-144 - Sequence-startup-OSD-notifications-for-tokenization-annotations-and-character-dictionary-sync.md b/backlog/completed/task-144 - Sequence-startup-OSD-notifications-for-tokenization-annotations-and-character-dictionary-sync.md deleted file mode 100644 index df9140c6..00000000 --- a/backlog/completed/task-144 - Sequence-startup-OSD-notifications-for-tokenization-annotations-and-character-dictionary-sync.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-144 -title: >- - Sequence startup OSD notifications for tokenization, annotations, and - character dictionary sync -status: Done -assignee: [] -created_date: '2026-03-09 10:40' -updated_date: '2026-03-18 05:28' -labels: - - startup - - overlay - - ux -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/main.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/startup-osd-sequencer.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/subtitle-tokenization-main-deps.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync-notifications.ts -priority: medium -ordinal: 37500 ---- - -## Description - - -Keep startup OSD progress ordered. While tokenization is still pending, only show the tokenization loading message. After tokenization becomes ready, show annotation loading if annotation warmup still remains. Only surface character dictionary auto-sync progress after annotation loading clears, and only if the dictionary work is still active. - - -## Acceptance Criteria - -- [x] #1 Character dictionary progress stays hidden while tokenization startup loading is still active. -- [x] #2 Annotation loading OSD appears after tokenization readiness and before any later character dictionary progress. -- [x] #3 Regression coverage verifies buffered dictionary progress/failure ordering during startup. - - -## Implementation Notes - - -Added a small startup OSD sequencer in main runtime. Annotation warmup OSD now flows through that sequencer, and character dictionary sync notifications buffer until tokenization plus annotation loading clear. Buffered `ready` updates are dropped if dictionary progress finished before it ever became visible, while buffered failures still surface after annotation loading completes. - diff --git a/backlog/completed/task-145 - Show-checking-and-generation-OSD-for-character-dictionary-auto-sync.md b/backlog/completed/task-145 - Show-checking-and-generation-OSD-for-character-dictionary-auto-sync.md deleted file mode 100644 index e00bbe53..00000000 --- a/backlog/completed/task-145 - Show-checking-and-generation-OSD-for-character-dictionary-auto-sync.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-145 -title: Show checking and generation OSD for character dictionary auto-sync -status: Done -assignee: [] -created_date: '2026-03-09 11:20' -updated_date: '2026-03-16 05:13' -labels: - - dictionary - - overlay - - ux -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/main.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/startup-osd-sequencer.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts -priority: medium -ordinal: 35500 ---- - -## Description - - -Surface an immediate startup OSD that the character dictionary is being checked, and show a distinct generating message only when the current AniList media actually needs a fresh snapshot build instead of reusing a cached one. - - -## Acceptance Criteria - -- [x] #1 Auto-sync emits a `checking` progress event before snapshot resolution completes. -- [x] #2 Auto-sync emits `generating` only for snapshot cache misses and keeps `updating`/`importing` as later phases. -- [x] #3 Startup OSD sequencing still prioritizes tokenization then annotation loading before buffered dictionary progress. - - -## Final Summary - - -Character dictionary auto-sync now emits `Checking character dictionary...` as soon as the AniList media is resolved, then emits `Generating character dictionary...` only when the snapshot layer misses and a real rebuild begins. Cached snapshots skip the generating phase and continue straight into the later update/import flow. - -Wired those progress callbacks through the character-dictionary runtime boundary, updated the startup OSD sequencer to treat checking/generating as dictionary-progress phases with the same tokenization and annotation precedence, and added regression coverage for cache-hit vs cache-miss behavior plus buffered startup ordering. - diff --git a/backlog/completed/task-146 - Forward-overlay-Tab-to-mpv-for-AniSkip.md b/backlog/completed/task-146 - Forward-overlay-Tab-to-mpv-for-AniSkip.md deleted file mode 100644 index 8fdd0726..00000000 --- a/backlog/completed/task-146 - Forward-overlay-Tab-to-mpv-for-AniSkip.md +++ /dev/null @@ -1,59 +0,0 @@ ---- -id: TASK-146 -title: Forward overlay Tab to mpv for AniSkip -status: Done -assignee: - - codex -created_date: '2026-03-09 00:00' -updated_date: '2026-03-18 05:28' -labels: - - bug - - overlay - - aniskip - - linux -dependencies: [] -ordinal: 47500 ---- - -## Description - - -Fix visible-overlay keyboard handling so bare `Tab` is forwarded to mpv instead of being consumed by Electron focus navigation. This restores the default AniSkip `TAB` binding while the overlay has focus, especially on Linux. - - -## Acceptance Criteria - -- [x] #1 Visible overlay forwards bare `Tab` to mpv as `keypress TAB`. -- [x] #2 Modal overlays keep their existing local `Tab` behavior. -- [x] #3 Automated regression coverage exists for the input handler and overlay factory wiring. - - -## Implementation Plan - - -1. Add a failing regression around visible-overlay `before-input-event` handling for bare `Tab`. -2. Add/extend overlay factory tests so the new mpv-forward callback is wired through runtime construction. -3. Patch overlay input handling to intercept visible-overlay `Tab` and send mpv `keypress TAB`. -4. Run focused overlay tests, typecheck, and changelog validation. - - -## Implementation Notes - - -Extracted visible-overlay input handling into `src/core/services/overlay-window-input.ts` so the `Tab` forwarding decision can be unit tested without loading Electron window primitives. - -Visible overlay `before-input-event` now intercepts bare `Tab`, prevents the browser default, and forwards mpv `keypress TAB` through the existing mpv runtime command path. Modal overlays remain unchanged. - -Verification: - -- `bun test src/core/services/overlay-window.test.ts src/main/runtime/overlay-window-factory.test.ts src/main/runtime/overlay-window-factory-main-deps.test.ts src/main/runtime/overlay-window-runtime-handlers.test.ts` -- `bun x tsc --noEmit` - - -## Final Summary - - -Visible overlay focus no longer blocks the default AniSkip `Tab` binding. Bare `Tab` is now forwarded straight to mpv while the visible overlay is active, and modal overlays still retain their own normal focus behavior. - -Added regression coverage for both the input-routing decision and the runtime plumbing that carries the new mpv forwarder into overlay window creation. - diff --git a/backlog/completed/task-148 - Fix-Windows-plugin-env-binary-override-resolution.md b/backlog/completed/task-148 - Fix-Windows-plugin-env-binary-override-resolution.md deleted file mode 100644 index ac4e6487..00000000 --- a/backlog/completed/task-148 - Fix-Windows-plugin-env-binary-override-resolution.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-148 -title: Fix Windows plugin env binary override resolution -status: Done -assignee: - - codex -created_date: '2026-03-09 00:00' -updated_date: '2026-03-18 05:28' -labels: - - windows - - plugin - - regression -dependencies: [] -priority: medium -ordinal: 48500 ---- - -## Description - - -Fix the mpv plugin's Windows binary override lookup so `SUBMINER_BINARY_PATH` still resolves when `SUBMINER_APPIMAGE_PATH` is unset. The current Lua resolver builds an array with a leading `nil`, which causes `ipairs` iteration to stop before the later Windows override candidate. - - -## Acceptance Criteria - -- [x] #1 `scripts/test-plugin-binary-windows.lua` passes the env override regression that expects `.exe` suffix resolution from `SUBMINER_BINARY_PATH`. -- [x] #2 Existing plugin start/binary test gate stays green after the fix. - - -## Final Summary - - -Updated `plugin/subminer/binary.lua` so env override lookup checks `SUBMINER_APPIMAGE_PATH` and `SUBMINER_BINARY_PATH` sequentially instead of via a Lua array literal that truncates at the first `nil`. This restores Windows `.exe` suffix resolution for `SUBMINER_BINARY_PATH` when the AppImage env var is unset. - -Verification: - -- `lua scripts/test-plugin-binary-windows.lua` -- `bun run test:plugin:src` - diff --git a/backlog/completed/task-149 - Cut-patch-release-v0.5.5-for-character-dictionary-updates-and-release-guarding.md b/backlog/completed/task-149 - Cut-patch-release-v0.5.5-for-character-dictionary-updates-and-release-guarding.md deleted file mode 100644 index 50b7abd9..00000000 --- a/backlog/completed/task-149 - Cut-patch-release-v0.5.5-for-character-dictionary-updates-and-release-guarding.md +++ /dev/null @@ -1,72 +0,0 @@ ---- -id: TASK-149 -title: Cut patch release v0.5.5 for character dictionary updates and release guarding -status: Done -assignee: - - codex -created_date: '2026-03-09 01:10' -updated_date: '2026-03-18 05:28' -labels: - - release - - patch -dependencies: - - TASK-140 - - TASK-141 - - TASK-142 - - TASK-143 - - TASK-144 - - TASK-145 - - TASK-146 - - TASK-148 -references: - - package.json - - CHANGELOG.md - - scripts/build-changelog.ts - - scripts/build-changelog.test.ts - - docs/RELEASING.md -priority: high -ordinal: 39500 ---- - -## Description - - -Prepare and publish patch release `v0.5.5` after the failed `v0.5.4` tag by aligning package version metadata, generating committed changelog output from the pending release fragments, and hardening release validation so a future tag cannot ship with a mismatched `package.json` version. - - -## Acceptance Criteria - -- [x] #1 Repository version metadata is updated to `0.5.5`. -- [x] #2 `CHANGELOG.md` contains the committed `v0.5.5` section and the consumed fragments are removed. -- [x] #3 Release validation rejects a requested release version when it differs from `package.json`. -- [x] #4 Release docs capture the required version/changelog prep before tagging. -- [x] #5 New `v0.5.5` release-prep commit and tag are pushed to `origin/main`. - - -## Implementation Plan - - -1. Add a regression test for tagged-release/package version mismatch. -2. Update changelog validation to reject mismatched explicit release versions. -3. Bump `package.json`, generate committed `v0.5.5` changelog output, and remove consumed fragments. -4. Add a short `docs/RELEASING.md` checklist for the prep flow. -5. Run release verification, commit, tag, and push. - - -## Implementation Notes - - -Added a regression test in `scripts/build-changelog.test.ts` that proves `changelog:check --version ...` rejects tag/package mismatches. Updated `scripts/build-changelog.ts` so tagged release validation now compares the explicit requested version against `package.json` before looking for pending fragments or the committed changelog section. - -Bumped `package.json` from `0.5.3` to `0.5.5`, ran `bun run changelog:build --version 0.5.5 --date 2026-03-09`, and committed the generated `CHANGELOG.md` output while removing the consumed task fragments. Added `docs/RELEASING.md` with the required release-prep checklist so version bump + changelog generation happen before tagging. - -Verification: `bun run changelog:lint`, `bun run changelog:check --version 0.5.5`, `bun run typecheck`, `bun run test:fast`, and `bun test scripts/build-changelog.test.ts src/release-workflow.test.ts`. `bun run format:check` still reports many unrelated pre-existing repo-wide Prettier warnings, so touched files were checked/formatted separately with `bunx prettier`. - - -## Final Summary - - -Prepared patch release `v0.5.5` after the failed `v0.5.4` release attempt. Release metadata now matches the upcoming tag, the pending character-dictionary/overlay/plugin fragments are committed into `CHANGELOG.md`, and release validation now blocks future tag/package mismatches before publish. - -Docs now include a short release checklist in `docs/RELEASING.md`. Validation passed for changelog lint/check, typecheck, targeted workflow tests, and the full fast test suite. Repo-wide Prettier remains noisy from unrelated existing files, but touched release files were formatted and verified. - diff --git a/backlog/completed/task-150 - Restore-repo-wide-Prettier-cleanliness-after-release-prep.md b/backlog/completed/task-150 - Restore-repo-wide-Prettier-cleanliness-after-release-prep.md deleted file mode 100644 index bc32ef45..00000000 --- a/backlog/completed/task-150 - Restore-repo-wide-Prettier-cleanliness-after-release-prep.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-150 -title: Restore repo-wide Prettier cleanliness after release prep -status: Done -assignee: - - codex -created_date: '2026-03-09 01:11' -updated_date: '2026-03-18 05:28' -labels: - - tooling - - formatting -dependencies: [] -references: - - backlog/config.yml - - backlog/tasks - - config.example.jsonc - - launcher/types.ts - - launcher/util.ts - - launcher/youtube/orchestrator.ts - - scripts/build-win-unsigned.mjs - - src -priority: medium -ordinal: 40500 ---- - -## Description - - -Bring `bun run format:check` back to green after the `v0.5.5` release-prep work exposed repo-wide Prettier drift across backlog markdown, config files, and maintained TypeScript sources. - - -## Acceptance Criteria - -- [x] #1 `bun run format:check` passes. -- [x] #2 `bun run changelog:lint` still passes. -- [x] #3 Typecheck and fast tests stay green after the formatting-only rewrite. - - -## Implementation Plan - - -1. Re-run format and lint checks to confirm failing files. -2. Apply Prettier to the warned repo-managed files. -3. Re-run formatting, lint, typecheck, and fast tests. -4. Commit and push the formatting-only cleanup. - - -## Implementation Notes - - -Ran `bunx prettier --write` across the repo-managed files reported by `bun run format:check`, covering backlog markdown/YAML, `config.example.jsonc`, selected launcher/scripts files, and maintained TypeScript sources under `src/`. - -Verification: `bun run format:check`, `bun run changelog:lint`, `bun run typecheck`, and `bun run test:fast`. - - -## Final Summary - - -Repo-wide Prettier drift is cleaned up, including backlog task markdown, config/example files, and the maintained code files that `format:check` was flagging. Formatting and lint checks are green again, and typecheck/fast tests stayed green after the formatting-only rewrite. - diff --git a/backlog/completed/task-151 - Keep-JLPT-underline-color-stable-during-Yomitan-text-selection.md b/backlog/completed/task-151 - Keep-JLPT-underline-color-stable-during-Yomitan-text-selection.md deleted file mode 100644 index ca813838..00000000 --- a/backlog/completed/task-151 - Keep-JLPT-underline-color-stable-during-Yomitan-text-selection.md +++ /dev/null @@ -1,100 +0,0 @@ ---- -id: TASK-151 -title: Keep JLPT underline color stable during Yomitan text selection -status: Done -assignee: - - OpenCode -created_date: '2026-03-10 06:42' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -references: - - src/renderer/style.css - - src/renderer/subtitle-render.test.ts -documentation: - - ../subminer-docs/development.md - - ../subminer-docs/architecture.md -priority: medium -ordinal: 33500 ---- - -## Description - - -Fix the subtitle overlay so JLPT underlines keep their JLPT color when Yomitan lookups trigger hover/selection styling on tokens that are also known, N+1, or frequency-highlighted. - - -## Acceptance Criteria - -- [x] #1 JLPT-tagged subtitle tokens keep their JLPT underline color during hover/selection states used by Yomitan lookup. -- [x] #2 Tokens that combine JLPT with known, N+1, name-match, or frequency styling preserve their primary text color while keeping the JLPT underline color. -- [x] #3 Renderer regression coverage verifies the JLPT underline color remains explicit in the stylesheet for combined styling states. - - -## Implementation Plan - - -1. Revert the temporary box-shadow JLPT marker experiment and restore native JLPT underline styling in `src/renderer/style.css`. -2. Add explicit JLPT hover/selection color rules with higher specificity so Yomitan lookup highlight states cannot repaint the underline to the token hover color. -3. Update `src/renderer/subtitle-render.test.ts` to verify JLPT hover/selection rules keep the predefined JLPT underline color, then rerun focused and relevant verification commands. - -4. Add JLPT-specific `text-decoration-color` overrides directly on child `.c` spans and their hover/selection states, since Yomitan lookup likely paints the decorated child text runs rather than only the parent token span. - - -## Implementation Notes - - -Added a renderer regression test that asserts JLPT underline color stays explicit through hover and selection styling. - -Updated `src/renderer/style.css` to route JLPT underline color through `--subtitle-jlpt-underline-color` and re-apply it on word/character hover and selection states. - -Verification: `bun test src/renderer/subtitle-render.test.ts`, `bun run typecheck`, `bun run test:fast`, `bun run build`, `bun run changelog:lint`, `bunx prettier --check src/renderer/style.css src/renderer/subtitle-render.test.ts changes/jlpt-underline-yomitan.md`. `bun run format:check:src` still fails because of unrelated existing formatting issues in `src/main-entry-runtime.test.ts` and `src/main-entry-runtime.ts`. - -User verified the original CSS variable propagation fix did not resolve the live issue; continuing investigation and reopening the task. - -Confirmed Chromium was repainting native `text-decoration` underlines with the selected text color; reproduced it in a temporary browser repro and verified that switching the JLPT marker to an inset box-shadow keeps the JLPT color stable during selection. - -Replaced the previous native underline approach with a fragment-safe JLPT marker using `box-shadow` plus `box-decoration-break`, then updated stylesheet regression coverage to match the new implementation. - -Verification: `bun test src/renderer/subtitle-render.test.ts`, `bunx prettier --check src/renderer/style.css src/renderer/subtitle-render.test.ts`, `bun run typecheck`, `bun run test:fast`, `bun run build`. - -User requested reverting the box-shadow marker experiment. Narrowing the fix to preserve native JLPT underline color during Yomitan hover/selection instead of changing the underline rendering method. - -Reverted the box-shadow experiment per user request. Restored native JLPT underline styling and added explicit JLPT hover/selection rules so Yomitan lookup states keep the predefined JLPT underline color with `!important`. - -Verification after revert/fix: `bun test src/renderer/subtitle-render.test.ts`, `bunx prettier --check src/renderer/style.css src/renderer/subtitle-render.test.ts`, `bun run typecheck`, `bun run build`. - -Issue still reproduces specifically during Shift-held Yomitan lookup. Investigating decoration propagation onto child `.c` spans during lookup-triggered hover/selection states. - -Added JLPT-specific `text-decoration-color` overrides directly to child `.c` spans and their hover/selection states, in addition to the token span itself, so lookup-triggered decoration painting on child runs keeps the JLPT color. - -Verification: `bun test src/renderer/subtitle-render.test.ts`, `bunx prettier --check src/renderer/style.css src/renderer/subtitle-render.test.ts`, `bun run typecheck`, `bun run build`. - -Added a final high-specificity combined-state JLPT override after the annotation hover/selection rules. It targets tokens that are both JLPT-tagged and known/N+1/name-match/frequency-highlighted, forcing `text-decoration-color` back to the JLPT variable after the later annotation state blocks. - -Verification: `bun test src/renderer/subtitle-render.test.ts`, `bunx prettier --check src/renderer/style.css src/renderer/subtitle-render.test.ts`, `bun run build`. - -Switched the JLPT underline from native `text-decoration` to a separate painted underline layer using `background-image` on JLPT tokens. Also changed hover token highlight rules to use `background-color` so the JLPT underline layer survives Shift+Yomitan hover/lookup interactions. - -Verification: `bun test src/renderer/subtitle-render.test.ts`, `bunx prettier --check src/renderer/style.css src/renderer/subtitle-render.test.ts`, `bun run build`. - -User reports the latest background-image JLPT underline change introduced grey-looking token highlights. Investigating the interaction between the new underline layer and hover background styling. - -The background-image underline layer interacts poorly with hover fills and makes highlighted tokens look grey. Switching the separate JLPT underline layer to an inset box-shadow so hover background color and JLPT underline paint can coexist cleanly. - -Adjusted the separate JLPT underline layer from `background-image` to inset `box-shadow`. This keeps the underline decoupled from Yomitan hover color while avoiding the grey-looking underline artifact introduced by the background-image approach. - -User reports the separate underline layer still disappears/greys out during lookup. Switching strategy again: use a dedicated `border-bottom` JLPT marker instead of box-shadow/background so the underline stays independent from Yomitan hover paint without blending artifacts. - -Replaced the separate JLPT underline layer with `border-bottom` plus a small bottom padding. This keeps the underline visually separate from Yomitan hover paint and avoids the disappearing/grey artifact seen with background-image and box-shadow. - - -## Final Summary - - -Switched the JLPT underline layer in `src/renderer/style.css` to `border-bottom` plus `padding-bottom`, keeping it independent from Yomitan hover/selection repainting while avoiding the disappearing or grey artifact seen with the background-image and box-shadow approaches. - -Updated `src/renderer/subtitle-render.test.ts` to assert the border-bottom-based JLPT underline layer. - -Verification: `bun test src/renderer/subtitle-render.test.ts`, `bunx prettier --check src/renderer/style.css src/renderer/subtitle-render.test.ts`, `bun run build`. - diff --git a/backlog/completed/task-152 - Fix-early-Electron-userData-path-casing-to-stay-under-SubMiner-config-dir.md b/backlog/completed/task-152 - Fix-early-Electron-userData-path-casing-to-stay-under-SubMiner-config-dir.md deleted file mode 100644 index fe213e53..00000000 --- a/backlog/completed/task-152 - Fix-early-Electron-userData-path-casing-to-stay-under-SubMiner-config-dir.md +++ /dev/null @@ -1,66 +0,0 @@ ---- -id: TASK-152 -title: Fix early Electron userData path casing to stay under SubMiner config dir -status: Done -assignee: - - codex -created_date: '2026-03-10 06:46' -updated_date: '2026-03-16 05:13' -labels: - - bug - - config - - electron -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/main-entry.ts - - /home/sudacode/projects/japanese/SubMiner/src/main.ts - - /home/sudacode/projects/japanese/SubMiner/src/config/path-resolution.ts -documentation: - - /home/sudacode/projects/japanese/subminer-docs/development.md - - /home/sudacode/projects/japanese/subminer-docs/architecture.md -priority: high -ordinal: 34500 ---- - -## Description - - -Electron startup touches the app object before the main-process bootstrap overrides userData, which can create/write the default lowercase ~/.config/subminer directory on Linux/macOS. Ensure early startup pins the app identity and userData path to the canonical SubMiner config directory before any Electron APIs can materialize the default path, and keep regression coverage around the bootstrap path behavior. - - -## Acceptance Criteria - -- [x] #1 Electron startup uses the canonical SubMiner config directory as userData before other Electron app calls can create the default lowercase directory. -- [x] #2 Regression tests cover the early bootstrap path setup and fail if startup falls back to a lowercase subminer config path. -- [x] #3 Existing config path resolution behavior for SubMiner casing remains intact. - - -## Implementation Plan - - -1. Add regression coverage for early Electron bootstrap path setup, including a case that would otherwise fall back to lowercase subminer. -2. Extract a pure helper that computes and applies the canonical app name/userData path from config resolution. -3. Call the helper from main-entry before any Electron app interactions that could materialize the default userData directory. -4. Run focused tests for startup/config path behavior, then the relevant fast gate if green. - - -## Implementation Notes - - -Added early Electron bootstrap path setup in src/main-entry so app name and userData are pinned to the canonical SubMiner config dir before single-instance/whenReady handling. - -Added a regression test in src/main-entry-runtime.test.ts covering the lowercase subminer fallback case. - -Validation: bun test src/main-entry-runtime.test.ts src/config/path-resolution.test.ts; bun run typecheck. bun run test:fast still fails on an existing unrelated renderer JLPT CSS test in src/renderer/subtitle-render.test.ts. - - -## Final Summary - - -Pinned Electron's app identity and userData path during entry bootstrap so startup uses the canonical SubMiner config directory before any other Electron app calls can materialize the default lowercase path. Added a regression test covering the lowercase subminer fallback case and kept existing config-path resolution coverage green. - -Validation: -- bun test src/main-entry-runtime.test.ts src/config/path-resolution.test.ts -- bun run typecheck -- bun run test:fast (fails on existing unrelated JLPT CSS renderer test in src/renderer/subtitle-render.test.ts) - diff --git a/backlog/completed/task-153 - Fix-character-dictionary-MRU-eviction-after-revisits.md b/backlog/completed/task-153 - Fix-character-dictionary-MRU-eviction-after-revisits.md deleted file mode 100644 index 057cd646..00000000 --- a/backlog/completed/task-153 - Fix-character-dictionary-MRU-eviction-after-revisits.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-153 -title: Fix character dictionary MRU eviction after revisits -status: Done -assignee: - - '@codex' -created_date: '2026-03-10 07:56' -updated_date: '2026-03-16 05:13' -labels: - - character-dictionary - - yomitan - - anilist -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.test.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts -documentation: - - /home/sudacode/projects/japanese/subminer-docs/development.md - - /home/sudacode/projects/japanese/subminer-docs/architecture.md -priority: high -ordinal: 32500 ---- - -## Description - - -Keep merged character dictionary retention truly MRU-based when a currently retained anime is revisited before opening a new title, so the oldest retained title is evicted instead of the revisited one. - - -## Acceptance Criteria - -- [x] #1 Revisiting an anime already retained in the merged character dictionary updates MRU ordering before the next new title is added. -- [x] #2 When retention exceeds maxLoaded after that revisit-plus-new-title sequence, the least recently used retained anime is evicted rather than the revisited title. -- [x] #3 Auto-sync rebuilds or reloads the merged dictionary so an evicted anime becomes available again when reopened. -- [x] #4 Regression tests cover the revisit-before-eviction flow. - - -## Implementation Plan - - -1. Reproduce the revisit-before-eviction scenario with a focused regression test in `src/main/runtime/character-dictionary-auto-sync.test.ts` using a retained set that revisits an existing anime before introducing a new anime. -2. Run the focused test to confirm current behavior fails for the expected MRU ordering / eviction case. -3. Adjust `src/main/runtime/character-dictionary-auto-sync.ts` so retained ordering stays MRU-correct across revisits and subsequent additions without regressing unchanged revisit behavior. -4. Re-run the focused auto-sync suite, then run the relevant broader checks required for handoff. - - -## Implementation Notes - - -Added a focused regression in `src/main/runtime/character-dictionary-auto-sync.test.ts` for the `1,2,3,1,4,1` revisit-before-eviction flow. The current MRU auto-sync logic passed: merged builds were `[1]`, `[2,1]`, `[3,2,1]`, `[1,3,2]`, `[4,1,3]`, `[1,4,3]`, so I have not reproduced the reported eviction bug in the in-process auto-sync service yet. - -Inspected local cache under `~/.config/SubMiner/character-dictionaries/` and found Little Witch Academia snapshot `anilist-21858.json` already present, so the reported regeneration path was not a snapshot-cache miss. The on-disk `merged.zip` revision (`9251ae23e136`) also differed from `auto-sync-state.json` (`bc16c5b5af17`), indicating a rebuilt merged dictionary artifact could land without the MRU state being persisted. - -Fixed `src/main/runtime/character-dictionary-auto-sync.ts` to persist the rebuilt retained-set state immediately after a merged dictionary revision/title is known, before later Yomitan mutation steps. This keeps MRU eviction state aligned even if import/settings work fails after the rebuild artifact is written. - -Added regression coverage in `src/main/runtime/character-dictionary-auto-sync.test.ts` for the revisit-before-eviction sequence and for post-build import failure preserving the rebuilt MRU state. Verified with `bun test src/main/runtime/character-dictionary-auto-sync.test.ts src/main/character-dictionary-runtime.test.ts`, `bun run typecheck`, `bun run changelog:lint`, and `bun run test:fast`. - - -## Final Summary - - -Persisted merged character-dictionary MRU state as soon as a rebuilt retained set is known in `src/main/runtime/character-dictionary-auto-sync.ts`, so revisits are not lost if later Yomitan import/settings work fails after `merged.zip` has already been rewritten. Added regression coverage for revisit-before-eviction ordering and import-failure state preservation in `src/main/runtime/character-dictionary-auto-sync.test.ts`, plus a changelog fragment in `changes/character-dictionary-mru-state-recovery.md`. - -Validation: `bun test src/main/runtime/character-dictionary-auto-sync.test.ts src/main/character-dictionary-runtime.test.ts`, `bun run typecheck`, `bun run changelog:lint`, `bun run test:fast`. - diff --git a/backlog/completed/task-154 - Avoid-merged-dictionary-rebuilds-on-MRU-reorder-only-revisits.md b/backlog/completed/task-154 - Avoid-merged-dictionary-rebuilds-on-MRU-reorder-only-revisits.md deleted file mode 100644 index 1e5df54f..00000000 --- a/backlog/completed/task-154 - Avoid-merged-dictionary-rebuilds-on-MRU-reorder-only-revisits.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-154 -title: Avoid merged dictionary rebuilds on MRU reorder-only revisits -status: Done -assignee: - - '@codex' -created_date: '2026-03-10 09:16' -updated_date: '2026-03-16 05:13' -labels: - - character-dictionary - - yomitan - - anilist -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.test.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.test.ts -documentation: - - /home/sudacode/projects/japanese/subminer-docs/development.md - - /home/sudacode/projects/japanese/subminer-docs/architecture.md -priority: high -ordinal: 31500 ---- - -## Description - - -Keep per-title MRU retention ordering for eviction decisions, but do not rebuild or reimport the merged character dictionary when the retained set membership is unchanged and only the MRU order changes. - - -## Acceptance Criteria - -- [x] #1 Revisiting an anime already inside the retained set updates MRU ordering used for later eviction decisions without rebuilding or reimporting the merged dictionary when retained membership is unchanged. -- [x] #2 Merged dictionary revisions and contents are stable for the same retained membership regardless of MRU ordering. -- [x] #3 Adding a new anime that changes retained membership still rebuilds and imports the merged dictionary with the correct eviction behavior. -- [x] #4 Regression tests cover reorder-only revisits and stable merged revisions for equivalent retained sets. - - -## Implementation Plan - - -1. Add a failing auto-sync regression showing that a revisit which only reorders MRU state should update `activeMediaIds` but skip merged rebuild/import. -2. Add a runtime-level regression showing `buildMergedDictionary` produces a stable revision for equivalent retained memberships regardless of input order. -3. Update merged-dictionary build normalization and auto-sync rebuild gating so rebuilds are driven by retained membership changes (or snapshot changes), not MRU reordering alone. -4. Re-run focused dictionary tests plus the local verification lanes impacted by the change. - - -## Implementation Notes - - -Changed `src/main/runtime/character-dictionary-auto-sync.ts` so MRU order still updates in `activeMediaIds`, but merged rebuild/import now keys off retained membership changes rather than order-only reordering. Order-only revisits no longer force a merged ZIP rewrite or Yomitan reimport. - -Changed `src/main/character-dictionary-runtime.ts` to canonicalize merged dictionary media ids before building, which makes merged revisions stable for equivalent retained memberships regardless of MRU ordering. - -Updated regression coverage in `src/main/runtime/character-dictionary-auto-sync.test.ts` for reorder-only revisits and membership-change rebuilds, and extended `src/main/character-dictionary-runtime.test.ts` to assert stable merged revisions for reordered inputs. Verified with `bun test src/main/runtime/character-dictionary-auto-sync.test.ts src/main/character-dictionary-runtime.test.ts`, `bun run typecheck`, `bun run changelog:lint`, and `bun run test:fast`. - - -## Final Summary - - -Updated merged character-dictionary syncing so MRU ordering is still tracked for eviction in `src/main/runtime/character-dictionary-auto-sync.ts`, but reorder-only revisits no longer rebuild or reimport the merged dictionary unless retained membership or snapshot data changes. Canonicalized merged build input ordering in `src/main/character-dictionary-runtime.ts` so revisions remain stable for the same retained set regardless of MRU order, and added regressions in `src/main/runtime/character-dictionary-auto-sync.test.ts` plus `src/main/character-dictionary-runtime.test.ts`. Also updated `changes/character-dictionary-mru-state-recovery.md` to cover the new behavior. - -Validation: `bun test src/main/runtime/character-dictionary-auto-sync.test.ts src/main/character-dictionary-runtime.test.ts`, `bun run typecheck`, `bun run changelog:lint`, `bun run test:fast`. - diff --git a/backlog/completed/task-155 - Move-user-docs-site-back-into-main-repo.md b/backlog/completed/task-155 - Move-user-docs-site-back-into-main-repo.md deleted file mode 100644 index f898d461..00000000 --- a/backlog/completed/task-155 - Move-user-docs-site-back-into-main-repo.md +++ /dev/null @@ -1,50 +0,0 @@ ---- -id: TASK-155 -title: Move user docs site back into main repo -status: Done -assignee: [] -created_date: '2026-03-10 19:20' -updated_date: '2026-03-10 19:38' -labels: [] -dependencies: [] -priority: medium -ordinal: 15500 ---- - -## Description - - - -Move the standalone VitePress docs site from the sibling `../subminer-docs` checkout back into the main `SubMiner` repo so docs can be updated alongside code and local tooling can reference one repository. - -Scope: - -- import the tracked docs-site source into a dedicated in-repo subdirectory -- update scripts/tests/docs instructions that assume a sibling `../subminer-docs` checkout -- preserve Cloudflare Pages deployability from a repo subdirectory -- verify the app repo and docs site both still build/test from the new layout - - - -## Acceptance Criteria - - - -- [x] #1 The user-facing VitePress docs source lives inside the `SubMiner` repo in a dedicated subdirectory. -- [x] #2 First-party scripts/tests/docs no longer require `../subminer-docs` for normal operation. -- [x] #3 In-repo docs instructions include the Cloudflare Pages subdirectory deploy settings. -- [x] #4 Verification covers the relocated docs site build/tests plus affected app-repo checks. - - - -## Final Summary - - - -Imported the VitePress site into `docs-site/` inside the main repo and updated project instructions, docs contributor guidance, generator logic, and regression tests to treat that in-repo directory as the docs source of truth. - -Added root proxy scripts for `docs:dev`, `docs:build`, `docs:preview`, and `docs:test`, repointed config-example generation to `docs-site/public/config.example.jsonc`, switched docs edit links to the main `SubMiner` repo, and documented the Cloudflare Pages subdirectory settings (`docs-site` root, `.vitepress/dist` output, `docs-site/**` watch path). - -Verified with `bun run format:check:src`, `bun run typecheck`, `bun run docs:test`, `bun run docs:build`, `bun run test:config:src`, and `bun run test:fast`. - - diff --git a/backlog/completed/task-156 - Fix-docs-site-Plausible-geo-attribution-through-analytics-worker.md b/backlog/completed/task-156 - Fix-docs-site-Plausible-geo-attribution-through-analytics-worker.md deleted file mode 100644 index d38070cb..00000000 --- a/backlog/completed/task-156 - Fix-docs-site-Plausible-geo-attribution-through-analytics-worker.md +++ /dev/null @@ -1,37 +0,0 @@ ---- -id: TASK-156 -title: Fix docs-site Plausible geo attribution through analytics worker -status: Done -assignee: [] -created_date: '2026-03-11 02:19' -updated_date: '2026-03-16 05:13' -labels: - - docs-site - - analytics -dependencies: [] -priority: medium -ordinal: 99500 ---- - -## Description - - -Investigate and fix missing city/region data for docs.subminer.moe visits in Plausible. The docs site already proxies analytics events to worker.subminer.moe, so the remaining work is to verify and correct the worker-side forwarding contract Plausible needs for geolocation. - - -## Acceptance Criteria - -- [ ] #1 The analytics worker forwards Plausible event requests in a way that preserves the original client IP information needed for location attribution. -- [ ] #2 The docs-site analytics flow remains proxied through worker.subminer.moe after the fix. -- [ ] #3 Coverage or documentation records the worker-side header/forwarding requirement for Plausible geo reporting. - - -## Implementation Notes - - -Worker implementation lives in `/home/sudacode/projects/blog-proxy`, not in the SubMiner repo. - -Patched `worker.js` to forward client IP via `x-forwarded-for`/`x-real-ip` from `cf-connecting-ip` (fallbacks retained) and added `worker.test.js` regression coverage. - -Local verification in `blog-proxy`: `node --test worker.test.js` passes. Deployment not performed in this session. - diff --git a/backlog/completed/task-157 - Fix-Cloudflare-Pages-watch-path-for-docs-site.md b/backlog/completed/task-157 - Fix-Cloudflare-Pages-watch-path-for-docs-site.md deleted file mode 100644 index 33e5883c..00000000 --- a/backlog/completed/task-157 - Fix-Cloudflare-Pages-watch-path-for-docs-site.md +++ /dev/null @@ -1,35 +0,0 @@ ---- -id: TASK-157 -title: Fix Cloudflare Pages watch path for docs-site -status: Done -assignee: [] -created_date: '2026-03-10 20:15' -updated_date: '2026-03-16 05:13' -labels: - - docs-site - - cloudflare -dependencies: [] -priority: medium -ordinal: 98500 ---- - -## Description - - -Cloudflare Pages skipped a docs-site deployment after the docs repo moved into the main `SubMiner` repository. The documented/configured watch path uses `docs-site/**`, but Pages monorepo watch paths use a single `*` wildcard pattern. Correct the documented setting and leave a regression test so future repo moves or docs rewrites do not reintroduce the bad pattern. - - -## Acceptance Criteria - -- [x] #1 Docs contributor guidance points Cloudflare Pages watch paths at `docs-site/*`, not `docs-site/**`. -- [x] #2 Regression coverage fails if the docs revert to the incorrect watch-path string. -- [x] #3 Implementation notes record that the Cloudflare dashboard setting must be updated manually and the docs deploy retriggered. - - -## Implementation Notes - - -Added docs regression coverage in `docs-site/docs-sync.test.ts` for the Pages watch-path string, then corrected the Cloudflare Pages instructions in `docs-site/README.md` and `docs-site/development.md`. - -Manual follow-up still required outside git: update the Cloudflare Pages project include path from `docs-site/**` to `docs-site/*`, then trigger a fresh deployment against `main`. - diff --git a/backlog/completed/task-158 - Enforce-generated-config-example-drift-checks.md b/backlog/completed/task-158 - Enforce-generated-config-example-drift-checks.md deleted file mode 100644 index 85154101..00000000 --- a/backlog/completed/task-158 - Enforce-generated-config-example-drift-checks.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-158 -title: Enforce generated config example drift checks -status: Done -assignee: [] -created_date: '2026-03-10 20:35' -updated_date: '2026-03-16 05:13' -labels: - - config - - docs-site -dependencies: [] -priority: medium -ordinal: 30500 ---- - -## Description - - -The generated `config.example.jsonc` artifact is covered by generation-path tests, but there is no hard gate that fails when the checked-in example drifts from the canonical template. The in-repo docs-site copy can also drift silently. - -Scope: - -- add a first-party verification path that compares generated config-example content against committed artifacts -- fail fast when repo-root `config.example.jsonc` is stale or missing -- fail fast when `docs-site/public/config.example.jsonc` is stale or missing, when the docs site exists -- wire the verification into the normal gate and release flow - - -## Acceptance Criteria - -- [x] #1 Automated verification fails when repo-root `config.example.jsonc` is missing or stale. -- [x] #2 Automated verification fails when in-repo docs-site `public/config.example.jsonc` is missing or stale, when docs-site exists. -- [x] #3 CI/release or equivalent project gates run the verification automatically. - - -## Final Summary - - -Added `src/verify-config-example.ts`, which renders the canonical config template and compares it against the checked-in repo-root `config.example.jsonc` plus `docs-site/public/config.example.jsonc` when the docs site exists. - -Wired the new verification into `package.json` as `bun run verify:config-example`, added regression coverage for missing and stale artifacts, and enforced the new check in both CI and release workflows. - -Regenerated the checked-in config example artifacts so the new gate passes in the repo-local docs-site layout, and documented the release-step expectation in `docs/RELEASING.md`. - diff --git a/backlog/completed/task-159 - Create-SubMiner-automated-testing-skill-for-agents.md b/backlog/completed/task-159 - Create-SubMiner-automated-testing-skill-for-agents.md deleted file mode 100644 index a5d72630..00000000 --- a/backlog/completed/task-159 - Create-SubMiner-automated-testing-skill-for-agents.md +++ /dev/null @@ -1,59 +0,0 @@ ---- -id: TASK-159 -title: Create SubMiner automated testing skill for agents -status: Done -assignee: - - codex -created_date: '2026-03-11 05:55' -updated_date: '2026-03-16 05:13' -labels: - - tooling - - testing - - skills -dependencies: [] -priority: medium -ordinal: 29500 ---- - -## Description - - -Design and implement a SubMiner-specific skill that agents can use to verify code changes with automated checks across launcher, mpv, overlay, and related workflows. - - -## Acceptance Criteria - -- [x] #1 Define the skill trigger surface and intended use cases for SubMiner change verification. -- [x] #2 Implement a SubMiner-specific skill package with concise workflow guidance and any required helper scripts or references. -- [x] #3 Document how agents should run automated verification for common SubMiner change types, including launcher/mpv/overlay-sensitive changes. -- [x] #4 Verify the skill itself is usable in this repo context. - - -## Implementation Plan - - -1. Add a design doc at `docs/plans/2026-03-10-subminer-change-verification-design.md` capturing the approved skill contract, lane selection rules, helper script design, and trigger/workflow guidance. -2. Create an in-repo source package for the new SubMiner-specific verification skill with `SKILL.md` plus helper shell scripts for diff classification and coordinated verification/artifact capture. -3. Implement cheap-first verification logic: map changed paths to verification lanes, run repo-native commands, capture stdout/stderr and metadata under `.tmp/skill-verification//`, and report pass/fail/skipped states with artifact paths. -4. Encode repo-specific heuristics for docs/config, launcher/plugin, runtime/dist, and optional real-GUI escalation guidance without making GUI launch the default. -5. Verify the skill locally by running the classifier/verifier against representative paths and confirming artifact generation and summaries. -6. Optionally install the finished skill to `~/.codex/skills/subminer-change-verification/` after user approval because that target is outside the writable sandbox. - - -## Implementation Notes - - -Planned outputs: SKILL.md plus small helper shell scripts for diff classification and coordinated verification/artifact capture. Default to repo-native commands; only escalate to real GUI/mpv verification when affected paths or requested behavior require it. - -2026-03-10: Brainstorming completed with user approval for a SubMiner-specific automated verification skill. Chosen shape: auto-triggering, cheap-first verification workflow with optional real GUI/mpv escalation and artifact capture. - -2026-03-10: Added design doc at docs/plans/2026-03-10-subminer-change-verification-design.md and created the in-repo skill source at tools/skills/subminer-change-verification/. - -2026-03-10: Verified classifier output with representative launcher/runtime/config/docs paths and ran the verifier in dry-run mode plus one real config lane (`bun run test:config`). Artifacts written under .tmp/skill-verification/20260310-231320 and .tmp/skill-verification/20260310-231326. - - -## Final Summary - - -Implemented a SubMiner-specific change verification skill source with a concise SKILL.md, a diff classifier, and a cheap-first verifier that captures artifacts under `.tmp/skill-verification/`. Verified the flow with representative path classification, a dry-run multi-lane plan, and a passing real config verification run. - diff --git a/backlog/completed/task-160 - Create-repo-local-scrum-master-orchestration-skill.md b/backlog/completed/task-160 - Create-repo-local-scrum-master-orchestration-skill.md deleted file mode 100644 index ea8d416e..00000000 --- a/backlog/completed/task-160 - Create-repo-local-scrum-master-orchestration-skill.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-160 -title: Create repo-local scrum master orchestration skill -status: Done -assignee: - - codex -created_date: '2026-03-11 06:32' -updated_date: '2026-03-16 05:13' -labels: - - skills - - workflow - - backlog - - subagents - - automation -dependencies: [] -priority: high -ordinal: 28500 ---- - -## Description - - -Design and implement a repo-local skill that can turn incoming requests/issues into well-scoped Backlog tasks, then coordinate one or more subagents to implement and verify the resulting work using the repo's established skills and verification workflow. - - -## Acceptance Criteria - -- [x] #1 Define the trigger surface, responsibilities, and limits of the scrum master skill for request intake, backlog updates, and execution orchestration. -- [x] #2 Implement the skill package with concise guidance for intake, task search/create/update, planning, and subagent dispatch. -- [x] #3 Specify how the skill coordinates with existing repo workflows, including Backlog.md requirements and SubMiner change verification. -- [x] #4 Verify the skill is usable in this repo context for at least one representative request flow. - - -## Implementation Plan - - -1. Add a design doc at `docs/plans/2026-03-10-subminer-scrum-master-design.md` capturing the approved contract, backlog decision rules, orchestration policy, and verification handoff. -2. Create the repo-local skill at `.agents/skills/subminer-scrum-master/` with a concise `SKILL.md`. -3. Keep v1 instruction-heavy: backlog-or-not decision first, search/create/update task structure when needed, require planning before dispatch, use parent + subtasks for multi-part work, dispatch conservatively with explicit ownership, and require `subminer-change-verification` before handoff. -4. Include representative flows for trivial no-ticket work, single-task implementation, and multi-part parent+subtask execution. -5. Verify the skill in-repo with one representative request flow and update `TASK-160` with results. - - -## Implementation Notes - - -V1 will be instruction-heavy rather than script-heavy. The skill will decide whether backlog is warranted, record plans before dispatch, create parent+subtasks when needed, dispatch conservatively with explicit ownership, and require `subminer-change-verification` before handoff. - -2026-03-10: Added design doc at docs/plans/2026-03-10-subminer-scrum-master-design.md and created the repo-local skill at .agents/skills/subminer-scrum-master/. - -2026-03-10: Verified the skill against a representative request flow ('Fix launcher auto-start pause bug and make sure it is verified') by checking that the instructions cover backlog decisioning, planning-before-dispatch, single-task execution, explicit worker ownership, and verification via subminer-change-verification. - - -## Final Summary - - -Implemented a repo-local `subminer-scrum-master` skill that assesses whether backlog tracking is needed, manages task structure and planning when appropriate, dispatches subagents conservatively, and requires verification before handoff. Verified the skill in-repo against a representative launcher bug workflow. - diff --git a/backlog/completed/task-161 - Add-Arch-Linux-PKGBUILD-and-.SRCINFO-for-SubMiner-release-artifacts.md b/backlog/completed/task-161 - Add-Arch-Linux-PKGBUILD-and-.SRCINFO-for-SubMiner-release-artifacts.md deleted file mode 100644 index 1773e9f9..00000000 --- a/backlog/completed/task-161 - Add-Arch-Linux-PKGBUILD-and-.SRCINFO-for-SubMiner-release-artifacts.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-161 -title: Add Arch Linux PKGBUILD and .SRCINFO for SubMiner release artifacts -status: Done -assignee: - - codex -created_date: '2026-03-11 07:50' -updated_date: '2026-03-16 05:13' -labels: - - packaging - - linux - - docs -dependencies: [] -references: - - package.json - - .github/workflows/release.yml - - README.md -documentation: - - docs-site/development.md - - docs-site/installation.md - - docs/RELEASING.md -priority: medium -ordinal: 27500 ---- - -## Description - - -Add repo-maintained Arch packaging metadata so Arch/AUR users can install the packaged SubMiner release artifacts without relying on npm. Cover the binary package flow that matches the current GitHub Releases distribution model and document the install path for Arch users. - - -## Acceptance Criteria - -- [x] #1 A dedicated Arch packaging directory exists with a PKGBUILD and matching .SRCINFO for the SubMiner binary release flow. -- [x] #2 The package installs the shipped Linux release artifact and wrapper in paths consistent with current runtime auto-detection expectations. -- [x] #3 Package metadata declares the required Arch runtime dependencies for the packaged workflow. -- [x] #4 The packaging files remain isolated from the main app/release/docs surfaces so they can be moved to a separate repository later. -- [x] #5 The packaging metadata is validated with an appropriate local Arch packaging check or an explicitly documented limitation if the tool is unavailable in this environment. - - -## Implementation Plan - - -1. Add isolated Arch packaging under packaging/arch/subminer-bin for the binary release flow that matches current GitHub Releases artifacts. -2. Install the Linux AppImage to /opt/SubMiner/SubMiner.AppImage, add PATH symlinks for SubMiner.AppImage and subminer, and ship optional plugin/theme/config assets under /usr/share/subminer. -3. Generate and commit matching .SRCINFO metadata in the same packaging directory. -4. Validate the PKGBUILD metadata locally with shell parsing plus makepkg --printsrcinfo and namcap if available. -5. Leave the new files isolated so they can be moved to a separate packaging repository later. - - -## Implementation Notes - - -User requested no commit and no broad repo integration; keep the Arch packaging files isolated in a dedicated directory for later extraction. - -Created isolated Arch packaging under packaging/arch/subminer-bin with PKGBUILD and generated .SRCINFO only; no docs or release workflow changes. - -Validation run: bash -n PKGBUILD, makepkg --printsrcinfo > .SRCINFO, namcap PKGBUILD. - -PKGBUILD uses current v0.5.6 GitHub release assets and recorded SHA-256 values for SubMiner-0.5.6.AppImage, subminer, and subminer-assets.tar.gz. - -Per user follow-up, moved packaging/arch/subminer-bin out of the repo to /home/sudacode/packages/maintaining/subminer-bin for separate maintenance. Repo docs/workflows were still left untouched. - - -## Final Summary - - -Added an isolated Arch Linux packaging directory at packaging/arch/subminer-bin containing a `subminer-bin` PKGBUILD and generated `.SRCINFO`. The package installs the current GitHub release AppImage to `/opt/SubMiner/SubMiner.AppImage`, adds PATH access for `SubMiner.AppImage` and `subminer`, and ships optional plugin/theme/config assets under `/usr/share/subminer`. Verified locally with `bash -n PKGBUILD`, `makepkg --printsrcinfo`, and `namcap PKGBUILD`. - diff --git a/backlog/completed/task-162 - Normalize-packaged-Linux-paths-to-canonical-SubMiner-directories.md b/backlog/completed/task-162 - Normalize-packaged-Linux-paths-to-canonical-SubMiner-directories.md deleted file mode 100644 index 89cad890..00000000 --- a/backlog/completed/task-162 - Normalize-packaged-Linux-paths-to-canonical-SubMiner-directories.md +++ /dev/null @@ -1,66 +0,0 @@ ---- -id: TASK-162 -title: Normalize packaged Linux paths to canonical SubMiner directories -status: Done -assignee: - - codex -created_date: '2026-03-11 08:28' -updated_date: '2026-03-18 05:28' -labels: - - linux - - packaging - - docs -dependencies: [] -references: - - launcher/mpv.ts - - launcher/picker.ts - - plugin/subminer/binary.lua - - plugin/subminer.conf - - docs-site/installation.md - - docs-site/launcher-script.md - - README.md -priority: medium -ordinal: 116500 ---- - -## Description - - -Align packaged Linux path conventions so system-installed assets use canonical `SubMiner` directories and match runtime auto-detection. Cover AppImage binary discovery, rofi theme discovery/docs, and related path references while preserving lowercase names only for the launcher wrapper, rofi theme filename, and mpv Lua plugin/conf. - - -## Acceptance Criteria - -- [x] #1 Launcher/runtime path discovery prefers canonical packaged Linux locations that use `SubMiner` casing for shared data and config directories. -- [x] #2 Tests cover the expected packaged Linux discovery paths for the AppImage and rofi theme search behavior. -- [x] #3 User-facing docs reference the canonical packaged Linux locations consistently. -- [x] #4 Lowercase names remain only where intentionally required for the launcher wrapper, rofi theme filename, and mpv Lua plugin/conf. - - -## Implementation Plan - - -1. Add failing launcher tests for canonical packaged Linux discovery paths: /usr/lib/subminer/SubMiner.AppImage via PATH symlink flow and /usr/share/SubMiner/themes/subminer.rasi for rofi theme lookup. -2. Update launcher runtime path discovery to prefer canonical packaged Linux shared-data locations using SubMiner casing. -3. Update plugin auto-detection comments and binary search defaults so packaged Linux paths stay consistent with launcher/runtime expectations. -4. Update user-facing docs to reference canonical SubMiner-cased config/share paths while keeping lowercase names only for the launcher wrapper, rofi theme filename, and mpv Lua plugin/conf. -5. Run targeted launcher tests plus docs checks. - -Remaining work (2026-03-15): -- binary.lua: add lowercase fallback candidates /usr/bin/subminer and /usr/local/bin/subminer after existing title-case entries -- launcher tests: add findAppBinary Linux candidates and findRofiTheme /usr/share + /usr/local/share tests - - -## Implementation Notes - - -2026-03-15: Adding launcher tests for Linux packaged path discovery (findAppBinary + findRofiTheme). Implementing in mpv.test.ts and new picker.test.ts following node:test / assert/strict patterns from mpv.test.ts. - -2026-03-15: AC#2 complete. Added findAppBinary tests (3) to launcher/mpv.test.ts and findRofiTheme tests (4) to new launcher/picker.test.ts. All 76 launcher tests pass. Added picker.test.ts to test:launcher:src script. - - -## Final Summary - - -## Completed changes\n\n### `plugin/subminer/binary.lua`\nAdded lowercase fallback candidates after existing title-case entries in the non-Windows `find_binary()` search list:\n- `/usr/local/bin/subminer` (after `/usr/local/bin/SubMiner`)\n- `/usr/bin/subminer` (after `/usr/bin/SubMiner`)\n\n### `plugin/subminer.conf`\nUpdated the comment documenting the Linux binary search list to include the two new lowercase candidates.\n\n### `launcher/mpv.test.ts`\nAdded 3 new tests for `findAppBinary` Linux candidates:\n- Resolves `~/.local/bin/SubMiner.AppImage` when it exists\n- Resolves `/opt/SubMiner/SubMiner.AppImage` when `~/.local/bin` candidate absent\n- Finds `subminer` on PATH when AppImage candidates absent\n\n### `launcher/picker.test.ts` (new file)\nAdded 4 tests for `findRofiTheme` Linux packaged paths:\n- Resolves `/usr/local/share/SubMiner/themes/subminer.rasi`\n- Resolves `/usr/share/SubMiner/themes/subminer.rasi` when `/usr/local/share` absent\n- Resolves `$XDG_DATA_HOME/SubMiner/themes/subminer.rasi` when set\n- Resolves `~/.local/share/SubMiner/themes/subminer.rasi` when `XDG_DATA_HOME` unset\n\n### `package.json`\nAdded `launcher/picker.test.ts` to `test:launcher:src` file list.\n\n## Verification\n- `launcher-plugin` lane: passed (76 launcher tests, 524 fast tests — all green)\n\n## Policy checks\n- Docs update required? No — docs already reflected canonical paths.\n- Changelog fragment required? Yes — user-visible fix to plugin binary auto-detection. Fragment should be added under `changes/`. - diff --git a/backlog/completed/task-163 - Resolve-current-lint-format-and-style-check-failures.md b/backlog/completed/task-163 - Resolve-current-lint-format-and-style-check-failures.md deleted file mode 100644 index baf25da5..00000000 --- a/backlog/completed/task-163 - Resolve-current-lint-format-and-style-check-failures.md +++ /dev/null @@ -1,74 +0,0 @@ ---- -id: TASK-163 -title: 'Resolve current lint, format, and style check failures' -status: Done -assignee: - - Codex -created_date: '2026-03-11 08:48' -updated_date: '2026-03-16 05:13' -labels: - - maintenance - - tooling -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/package.json - - /home/sudacode/projects/japanese/SubMiner/docs-site/development.md - - /home/sudacode/projects/japanese/SubMiner/docs-site/architecture.md -ordinal: 26500 ---- - -## Description - - -Run the repo's maintained static/style gates, fix any failures they report, and leave the working tree with those checks passing without disturbing unrelated in-progress work. - - -## Acceptance Criteria - -- [x] #1 The repo's maintained static/style commands for this cleanup are identified and recorded. -- [x] #2 Any failures from those commands are fixed in-scope in the codebase. -- [x] #3 The same static/style commands pass after the fixes. -- [x] #4 Verification results and any skipped checks are documented before handoff. - - -## Implementation Plan - - -1. Run the maintained static/style gates for this repo: `bun run typecheck` and `bun run format:check:src`. -2. Inspect each failure and patch only the files implicated by the failing command, preserving unrelated user changes. -3. Re-run the failing gate after each fix until both commands pass. -4. Run one final consolidated verification pass, record exact commands/results, and note any intentionally skipped broader gates outside lint/style scope. - - -## Implementation Notes - - -Identified maintained commands from repo docs/scripts: `bun run typecheck` and `bun run format:check:src`. `changelog:lint` exists but is release-fragment specific, not a general lint/style gate for this request. - -Ran `bun run typecheck` at 2026-03-11 01:48 PDT: passed. - -Ran `bun run format:check:src` at 2026-03-11 01:48 PDT: failed on `src/release-workflow.test.ts`. - -Applied a scoped Prettier rewrite with `./node_modules/.bin/prettier --write src/release-workflow.test.ts`. - -Re-ran `bun run format:check:src` at 2026-03-11 01:49 PDT: passed. - -Re-ran `bun run typecheck` at 2026-03-11 01:49 PDT: passed. - -Skipped broader test/build/docs gates because the user asked specifically for lint/format/style cleanup and the only required change was a formatting-only update in one test file. - - -## Final Summary - - -Resolved the repo's current static/style failure by reformatting `src/release-workflow.test.ts` to match the maintained Prettier scope. The only code change was line wrapping in the `generate:config-example` assertion; behavior did not change. - -Verification run: -- `bun run typecheck` -- `bun run format:check:src` -- `./node_modules/.bin/prettier --write src/release-workflow.test.ts` -- `bun run format:check:src` -- `bun run typecheck` - -Result: both maintained gates requested for this cleanup now pass. Broader build/test/docs lanes were intentionally not run because this task was limited to lint/format/style checks and required a formatting-only fix. - diff --git a/backlog/completed/task-164 - Run-maintained-test-gate-and-fix-failing-regressions.md b/backlog/completed/task-164 - Run-maintained-test-gate-and-fix-failing-regressions.md deleted file mode 100644 index bd591541..00000000 --- a/backlog/completed/task-164 - Run-maintained-test-gate-and-fix-failing-regressions.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-164 -title: Run maintained test gate and fix failing regressions -status: Done -assignee: - - Codex -created_date: '2026-03-11 08:52' -updated_date: '2026-03-16 05:13' -labels: - - maintenance - - testing -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/package.json - - /home/sudacode/projects/japanese/SubMiner/docs-site/development.md - - /home/sudacode/projects/japanese/SubMiner/docs-site/architecture.md -ordinal: 25500 ---- - -## Description - - -Execute the repo's maintained test verification flow, fix any regressions surfaced by those commands, and leave the requested test gate passing without disturbing unrelated in-progress work. - - -## Acceptance Criteria - -- [x] #1 The maintained test commands chosen for this pass are recorded in the task plan. -- [x] #2 Any test failures encountered in that gate are fixed in-scope with appropriate regression coverage when needed. -- [x] #3 The same maintained test gate passes after the fixes. -- [x] #4 Verification results, skips, and remaining risks are documented before handoff. - - -## Implementation Plan - - -1. Run the maintained verification gate documented for local handoff: `bun run test:fast`, `bun run test:env`, `bun run build`, and `bun run test:smoke:dist`. -2. Stop at the first failing command, inspect the exact failure, and use a red/green loop with the smallest targeted failing test before writing any production-code fix. -3. Re-run the targeted failing test, then the original failing command, and continue through the remaining gate. -4. Record results, any skips, and residual risks before handoff. - - -## Implementation Notes - - -Using the docs-site recommended local gate as the maintained test/build verification flow for this request. - -Ran `bun run test:fast` at 2026-03-11 01:52 PDT: passed. - -Ran `bun run test:env` at 2026-03-11 01:53 PDT: passed. - -Ran `bun run build` at 2026-03-11 01:53 PDT: passed. - -Ran `bun run test:smoke:dist` at 2026-03-11 01:53 PDT: passed. - -No failing tests surfaced in the maintained gate, so no production-code or test changes were required in this pass. - -Working tree still includes unrelated user edits plus the previously-applied formatting change in `src/release-workflow.test.ts`; this task did not add new source changes. - - -## Final Summary - - -Executed the repo's maintained local verification gate from the development docs: `bun run test:fast`, `bun run test:env`, `bun run build`, and `bun run test:smoke:dist`. - -Result: every command passed. No failing tests surfaced, so no additional fixes or new regression tests were required for this task. - -Working tree note: existing unrelated user changes remain in place, along with the prior formatting-only change to `src/release-workflow.test.ts` from TASK-163. This task introduced no new code changes. - diff --git a/backlog/completed/task-165 - Make-controller-configuration-easier-with-inline-remapping-modal.md b/backlog/completed/task-165 - Make-controller-configuration-easier-with-inline-remapping-modal.md deleted file mode 100644 index a215d3b7..00000000 --- a/backlog/completed/task-165 - Make-controller-configuration-easier-with-inline-remapping-modal.md +++ /dev/null @@ -1,94 +0,0 @@ ---- -id: TASK-165 -title: Make controller configuration easier with inline remapping modal -status: To Do -assignee: - - Codex -created_date: '2026-03-13 00:10' -updated_date: '2026-03-13 00:10' -labels: - - enhancement - - renderer - - overlay - - input - - config -dependencies: - - TASK-159 -references: - - src/renderer/modals/controller-select.ts - - src/renderer/modals/controller-debug.ts - - src/renderer/handlers/gamepad-controller.ts - - src/renderer/index.html - - src/renderer/style.css - - src/renderer/utils/dom.ts - - src/preload.ts - - src/core/services/ipc.ts - - src/main.ts - - src/types.ts - - src/config/definitions/defaults-core.ts - - src/config/definitions/options-core.ts - - config.example.jsonc - - docs/plans/2026-03-13-overlay-controller-config-remap-design.md - - docs/plans/2026-03-13-overlay-controller-config-remap.md ---- - -## Description - - -Replace the current controller-selection-only modal with a denser controller configuration surface that keeps device selection and adds inline controller remapping. The new flow should feel like emulator configuration: pick an overlay action, arm capture, then press the matching controller button, trigger, d-pad direction, or stick direction to bind it. Keep the current overlay-local renderer architecture, preserve controller gating to keyboard-only mode, and retain the separate raw debug modal for troubleshooting. - - -## Acceptance Criteria - - -- [ ] #1 `Alt+C` opens a controller modal that includes both preferred-controller selection and controller-config editing in one surface. -- [ ] #2 Controller device selection uses a compact dropdown or equivalent compact picker instead of the current full-height device list. -- [ ] #3 Each remappable controller action shows its current binding and supports learn/capture, clear, and reset-to-default flows. -- [ ] #4 Learn mode captures the next fresh controller input edge or stick/d-pad direction, not a held/stale input. -- [ ] #5 Captured bindings can represent non-standard controllers without depending only on the browser's standard semantic button names. -- [ ] #6 Updated bindings persist through the existing config pipeline and take effect in the renderer without restart unless a field explicitly requires reopen/reload. -- [ ] #7 Existing controller behavior remains gated to keyboard-only mode except for the controller action that toggles keyboard-only mode itself. -- [ ] #8 Renderer/config/IPC regression tests cover the new modal layout, capture flow, persistence, and runtime mapping behavior. -- [ ] #9 Docs/config example explain the new controller-config flow and when to use the debug modal. - - -## Implementation Plan - - -1. Add the design doc and implementation plan for inline controller remapping, tied to a new backlog task instead of reopening the already-completed base controller-support task. -2. Expand controller config types/defaults/template output so action bindings can store captured input descriptors, not only semantic button-name enums. -3. Extend preload/main/IPC write paths from preferred-controller-only saves to full controller-config patching needed by the modal. -4. Redesign the controller modal UI into a compact device picker plus action-binding editor with learn, clear, and reset affordances. -5. Add renderer capture state and a learn-mode runtime that waits for neutral-to-active transitions before saving a binding. -6. Update the gamepad runtime to resolve the new stored descriptors into actions while preserving current gating and repeat/deadzone behavior. -7. Keep the raw debug modal as a separate advanced surface; optionally expose copyable input-descriptor text for troubleshooting. -8. Add focused regression tests first, then run the maintained gate needed for docs/config/renderer/main changes. - - -## Implementation Notes - - -Planning only in this pass. - -Current-state findings: - -- `src/renderer/modals/controller-select.ts` only persists `preferredGamepadId` / `preferredGamepadLabel`. -- `src/preload.ts`, `src/core/services/ipc.ts`, and `src/main.ts` only expose a narrow save path for preferred controller, not general controller config writes. -- `src/renderer/handlers/gamepad-controller.ts` currently resolves actions from semantic button bindings plus a few axis slots; this is fine for defaults but too narrow for emulator-style learn mode on non-standard controllers. -- `src/renderer/modals/controller-debug.ts` already provides the raw input surface needed for troubleshooting and for validating capture behavior. - -Recommended direction: - -- keep `Alt+C` as the single controller-config entrypoint -- keep `Alt+Shift+C` as raw debug -- introduce stored input descriptors for discrete bindings so learn mode can capture buttons, triggers, d-pad directions, and stick directions directly -- defer per-controller profiles; keep one global binding set plus preferred-controller selection for this pass - - -## Final Summary - - -Planned follow-up work to make controller configuration materially easier than the current “pick preferred device” modal. The proposed change keeps existing controller runtime/debug foundations, but upgrades the selection modal into a compact controller-config surface with inline learn-mode remapping and persistent binding storage. - -Main architectural change in scope: move from semantic-button-only binding storage toward captured input descriptors so the UI can reliably learn from buttons, triggers, d-pad directions, and stick directions on non-standard controllers. - diff --git a/backlog/completed/task-165 - Rewrite-SubMiner-agentic-testing-automation-plan.md b/backlog/completed/task-165 - Rewrite-SubMiner-agentic-testing-automation-plan.md deleted file mode 100644 index d5329952..00000000 --- a/backlog/completed/task-165 - Rewrite-SubMiner-agentic-testing-automation-plan.md +++ /dev/null @@ -1,65 +0,0 @@ ---- -id: TASK-165 -title: Rewrite SubMiner agentic testing automation plan -status: Done -assignee: [] -created_date: '2026-03-13 04:45' -updated_date: '2026-03-16 05:13' -labels: - - planning - - testing - - agents -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/testing-plan.md - - >- - /home/sudacode/projects/japanese/SubMiner/.agents/skills/subminer-change-verification/SKILL.md - - >- - /home/sudacode/projects/japanese/SubMiner/.agents/skills/subminer-scrum-master/SKILL.md -documentation: - - /home/sudacode/projects/japanese/SubMiner/docs-site/development.md - - /home/sudacode/projects/japanese/SubMiner/docs-site/architecture.md -ordinal: 23500 ---- - -## Description - - -Replace the current generic Electron/mpv testing plan with a SubMiner-specific plan that uses the existing skills as the source of truth, treats real launcher/plugin/mpv runtime verification as primary, and defines a non-interference contract for parallel agent work. - - -## Acceptance Criteria - -- [x] #1 `testing-plan.md` is rewritten for SubMiner rather than a generic Electron+mpv app -- [x] #2 The plan keeps `subminer-scrum-master` and `subminer-change-verification` as the primary orchestration and verification entrypoints -- [x] #3 The plan defines real launcher/plugin/mpv runtime verification as the authoritative lane for runtime bug claims -- [x] #4 The plan defines explicit session isolation and non-interference rules for parallel agent work -- [x] #5 The plan defines artifact/reporting expectations and phased rollout, with synthetic/headless verification clearly secondary to real-runtime verification - - -## Implementation Plan - - -1. Review the existing testing plan and compare it against current SubMiner architecture, verification lanes, and skills. -2. Replace the generic Electron/mpv harness framing with a SubMiner-specific control plane centered on existing skills. -3. Define the authoritative real-runtime lane, session isolation rules, concurrency classes, and reporting contract. -4. Sanity-check the rewritten document against current repo docs and skill contracts before handoff. - - -## Implementation Notes - - -Rewrote `testing-plan.md` around existing `subminer-scrum-master` and `subminer-change-verification` responsibilities instead of proposing a competing new top-level testing skill. - -Set real launcher/plugin/mpv/runtime verification as the authoritative lane for runtime bug claims and made synthetic/headless verification explicitly secondary. - -Defined session-scoped paths, unique mutable resources, concurrency classes, and an exclusive lease for conflicting real-runtime verification to prevent parallel interference. - -Sanity-checked the final document by inspecting the rewritten file content and diff. - - -## Final Summary - - -Rewrote `testing-plan.md` into a SubMiner-specific agentic verification plan. The new document keeps `subminer-scrum-master` and `subminer-change-verification` as the primary orchestration and verification entrypoints, treats the real launcher/plugin/mpv/runtime path as authoritative for runtime bug claims, and defines a hard non-interference contract for parallel work through session isolation and an exclusive real-runtime lease. The plan now also includes an explicit reporting schema, capture policy, phased rollout, and a clear statement that true parallel full-app instances are not a phase-1 requirement. Verification for this task was a document sanity pass against the current repo docs, skills, and the resulting file diff. - diff --git a/backlog/completed/task-166 - Prevent-AUR-upgrade-cache-collisions-for-unversioned-release-assets.md b/backlog/completed/task-166 - Prevent-AUR-upgrade-cache-collisions-for-unversioned-release-assets.md deleted file mode 100644 index 258ab358..00000000 --- a/backlog/completed/task-166 - Prevent-AUR-upgrade-cache-collisions-for-unversioned-release-assets.md +++ /dev/null @@ -1,76 +0,0 @@ ---- -id: TASK-166 -title: Prevent AUR upgrade cache collisions for unversioned release assets -status: Done -assignee: - - Codex -created_date: '2026-03-17 18:10' -updated_date: '2026-03-18 05:28' -labels: - - release - - packaging - - linux -dependencies: - - TASK-165 -references: - - /home/sudacode/projects/japanese/SubMiner/.github/workflows/release.yml - - /home/sudacode/projects/japanese/SubMiner/scripts/update-aur-package.sh - - /home/sudacode/projects/japanese/SubMiner/scripts/update-aur-package.test.ts - - >- - /home/sudacode/projects/japanese/SubMiner/packaging/aur/subminer-bin/PKGBUILD - - >- - /home/sudacode/projects/japanese/SubMiner/packaging/aur/subminer-bin/.SRCINFO -priority: medium -ordinal: 107500 ---- - -## Description - - -Fix the AUR release metadata generated by the tagged-release workflow so end-user upgrades do not reuse stale cached downloads for unversioned `subminer` and `subminer-assets.tar.gz` source names. - - -## Acceptance Criteria - -- [x] #1 AUR packaging generated for a new `pkgver` uses versioned local source aliases for the non-versioned GitHub release assets. -- [x] #2 The package install step references the versioned local launcher filename correctly. -- [x] #3 Regression coverage fails if metadata generation reintroduces stable cache-colliding source aliases. -- [x] #4 Targeted verification records the commands run and results. - - -## Implementation Plan - - -1. Add a failing regression test around `scripts/update-aur-package.sh` output for versioned local source aliases. -2. Update the repo AUR template and `.SRCINFO` rewrite logic to stamp versioned alias names for `subminer` and `subminer-assets`. -3. Verify the generated metadata and targeted workflow/package tests, then record results here. - - -## Implementation Notes - - -Root cause: the AUR package used stable local source aliases for the unversioned `subminer` and `subminer-assets.tar.gz` GitHub release assets. `makepkg`/AUR helpers can reuse those cached filenames across upgrades, so a stale cached download survives into a newer `pkgver` and then fails checksum validation. - -Patched the repo AUR template to version the local cache aliases: -- `subminer-${pkgver}::.../subminer` -- `subminer-assets-${pkgver}.tar.gz::.../subminer-assets.tar.gz` - -Updated `package()` to install the versioned local wrapper filename, and updated `scripts/update-aur-package.sh` so the generated `.SRCINFO` stamps matching concrete versioned aliases for release automation. - -Added regression assertions in `scripts/update-aur-package.test.ts` covering both versioned source aliases and the launcher install path, then watched that test fail before the patch and pass after it. - -Verification: -- `bun test scripts/update-aur-package.test.ts` -- `bash -n scripts/update-aur-package.sh && bash -n packaging/aur/subminer-bin/PKGBUILD` -- `bun run typecheck` -- `bun run test:fast` -- `bun run test:env` -- `bun run build` -- `bun run test:smoke:dist` - - -## Final Summary - - -The tagged-release AUR metadata path now emits versioned local source aliases for the non-versioned GitHub release assets, preventing stale `makepkg` cache reuse across `subminer-bin` upgrades. The change is covered by a regression test and passed the repo's maintained verification gate. - diff --git a/backlog/completed/task-167 - Track-shared-SubMiner-agent-skills-in-git-and-clean-up-ignore-rules.md b/backlog/completed/task-167 - Track-shared-SubMiner-agent-skills-in-git-and-clean-up-ignore-rules.md deleted file mode 100644 index 0aaad3e9..00000000 --- a/backlog/completed/task-167 - Track-shared-SubMiner-agent-skills-in-git-and-clean-up-ignore-rules.md +++ /dev/null @@ -1,52 +0,0 @@ ---- -id: TASK-167 -title: Track shared SubMiner agent skills in git and clean up ignore rules -status: Done -assignee: [] -created_date: '2026-03-13 05:46' -updated_date: '2026-03-16 05:13' -labels: - - git - - agents - - repo-hygiene -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/.gitignore - - >- - /home/sudacode/projects/japanese/SubMiner/.agents/skills/subminer-change-verification/SKILL.md - - >- - /home/sudacode/projects/japanese/SubMiner/.agents/skills/subminer-scrum-master/SKILL.md -documentation: - - /home/sudacode/projects/japanese/SubMiner/testing-plan.md -ordinal: 21500 ---- - -## Description - - -Adjust the repository ignore rules so the shared SubMiner agent skill files can be committed while keeping unrelated local agent state ignored. Also ensure generated local verification artifacts like `.tmp/` do not pollute git status. - - -## Acceptance Criteria - -- [x] #1 Root ignore rules allow the shared SubMiner skill files under `.agents/skills/` to be tracked without broadly unignoring local agent state -- [x] #2 The changed shared skill files appear in git status as trackable files after the ignore update -- [x] #3 Local generated verification artifact directories remain ignored so git status stays clean -- [x] #4 The updated ignore rules are minimal and scoped to the repo-shared skill files - - -## Implementation Notes - - -Updated `.gitignore` to keep `.agents` ignored by default while narrowly unignoring the repo-shared SubMiner skill files and verifier scripts. - -Added `.tmp/` to the root ignore rules so local verification artifacts stop polluting `git status`. - -Verified the result with `git status --untracked-files=all` and `git check-ignore -v`, confirming the shared skill files are now trackable and `.tmp/` remains ignored. - - -## Final Summary - - -Adjusted the root `.gitignore` so the shared SubMiner agent skill files can be committed cleanly without broadly unignoring local agent state. The repo now tracks the shared `subminer-change-verification` skill files and the `subminer-scrum-master` skill doc, while `.tmp/` is ignored so generated verification artifacts do not pollute git status. Verified with `git status --untracked-files=all` and `git check-ignore -v` that the intended skill files are commit-ready and `.tmp/` remains ignored. - diff --git a/backlog/completed/task-168 - Document-immersion-stats-dashboard-and-config.md b/backlog/completed/task-168 - Document-immersion-stats-dashboard-and-config.md deleted file mode 100644 index 49b99bde..00000000 --- a/backlog/completed/task-168 - Document-immersion-stats-dashboard-and-config.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-168 -title: Document immersion stats dashboard and config -status: Done -assignee: - - codex -created_date: '2026-03-12 22:53' -updated_date: '2026-03-16 05:13' -labels: - - docs - - immersion -dependencies: [] -priority: medium -ordinal: 24500 ---- - -## Description - - -Refresh user-facing docs for the new immersion stats dashboard so README, docs-site pages, changelog notes, and generated config examples describe how to access the dashboard and which `stats.*` settings control it. - - -## Acceptance Criteria - -- [x] #1 README mentions the new stats surface in product-facing feature/docs copy. -- [x] #2 Docs explain how to access the stats dashboard in-app and via localhost, and document the `stats` config block. -- [x] #3 Changelog/release-note input includes the new stats dashboard. -- [x] #4 Generated config examples include the new `stats` section. - - -## Final Summary - - -Updated README and the docs-site immersion/config/mining/shortcut/homepage copy to describe the new stats dashboard, including the overlay toggle (`stats.toggleKey`, default `Backquote`) and the localhost browser UI (`http://127.0.0.1:5175` by default). - -Added a changelog fragment for the stats dashboard release notes and extended the config template sections so regenerated `config.example.jsonc` artifacts now include the `stats` block. - -Verified with `bun run test:config`, `bun run generate:config-example`, `bun run docs:test`, `bun run docs:build`, and `bun run changelog:lint`. - diff --git a/backlog/completed/task-169 - Add-anime-level-immersion-metadata-and-link-videos.md b/backlog/completed/task-169 - Add-anime-level-immersion-metadata-and-link-videos.md deleted file mode 100644 index 113c9f4d..00000000 --- a/backlog/completed/task-169 - Add-anime-level-immersion-metadata-and-link-videos.md +++ /dev/null @@ -1,80 +0,0 @@ ---- -id: TASK-169 -title: Add anime-level immersion metadata and link videos -status: Done -assignee: - - codex -created_date: '2026-03-13 19:34' -updated_date: '2026-03-16 05:13' -labels: - - immersion - - stats - - database - - anilist -milestone: m-1 -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/docs/plans/2026-03-13-immersion-anime-metadata-design.md - - >- - /home/sudacode/projects/japanese/SubMiner/docs/plans/2026-03-13-immersion-anime-metadata.md -ordinal: 20500 ---- - -## Description - - -Add first-class anime metadata to the immersion tracker so stats can group sessions and videos by anime, season, and episode instead of relying only on per-video canonical titles. The new model should deduplicate anime-level metadata across rewatches and multiple files, use guessit-first filename parsing with built-in parser fallback, and create provisional anime rows even when AniList lookup fails. - - -## Acceptance Criteria - -- [x] #1 The immersion schema includes a new anime-level table plus additive video linkage/parsed metadata fields needed for anime, season, and episode stats. -- [x] #2 Media ingest creates or reuses anime rows, stores parsed season/episode metadata on videos, and upgrades provisional anime rows when AniList data becomes available. -- [x] #3 Query surfaces expose anime-level aggregation suitable for library/detail/episode stats without breaking current video/session queries. -- [x] #4 Focused regression coverage exists for schema/storage/query/service behavior, including provisional anime rows and guessit-first parser fallback behavior. -- [x] #5 Verification covers the SQLite immersion lane and any broader lanes required by the touched runtime/query files. - - -## Implementation Plan - - -1. Add red tests for the new schema shape in the SQLite immersion lane before changing storage code. -2. Implement `imm_anime` plus additive `imm_videos` metadata fields and focused storage helpers for provisional anime creation and AniList upgrade. -3. Add a guessit-first parser helper with built-in fallback and wire media ingest to persist anime/video metadata during `handleMediaChange(...)`. -4. Add anime-level query surfaces for library/detail/episode aggregation and expose them only where needed. -5. Run focused SQLite verification first, then broader verification lanes only if touched runtime/API files require them. - - -## Implementation Notes - - -2026-03-13: Design approved in-thread. Initial scope excluded migration/backfill work, but implementation was corrected in-thread to add a legacy DB migration/backfill path based on filename parsing. -2026-03-13: Detailed implementation plan written at `docs/plans/2026-03-13-immersion-anime-metadata.md`. -2026-03-13: Task 6 export/API work was intentionally skipped because no current stats API/UI consumer needs the anime query surface yet, and widening the contract would have touched unrelated dirty stats files. -2026-03-13: Verification commands run: - - `bun test src/core/services/immersion-tracker/storage-session.test.ts` - - `bun test src/core/services/immersion-tracker/metadata.test.ts` - - `bun test src/core/services/immersion-tracker-service.test.ts` - - `bun test src/core/services/immersion-tracker/__tests__/query.test.ts` - - `bun run test:immersion:sqlite:src` - - `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh src/core/services/immersion-tracker/storage.ts src/core/services/immersion-tracker/storage-session.test.ts src/core/services/immersion-tracker/metadata.ts src/core/services/immersion-tracker/metadata.test.ts src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker/types.ts src/core/services/immersion-tracker/__tests__/query.test.ts src/core/services/immersion-tracker-service.ts src/core/services/immersion-tracker-service.test.ts` - - `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/core/services/immersion-tracker/storage.ts src/core/services/immersion-tracker/storage-session.test.ts src/core/services/immersion-tracker/metadata.ts src/core/services/immersion-tracker/metadata.test.ts src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker/types.ts src/core/services/immersion-tracker/__tests__/query.test.ts src/core/services/immersion-tracker-service.ts src/core/services/immersion-tracker-service.test.ts` -2026-03-13: Verification results: - - `bun run test:immersion:sqlite:src`: passed - - verifier lane selection: `core` - - verifier result: passed (`bun run typecheck`, `bun run test:fast`) - - verifier artifacts: `.tmp/skill-verification/subminer-verify-20260313-214533-Ciw3L0/` - - -## Final Summary - - -Added `imm_anime`, additive `imm_videos` anime/parser metadata fields, and a legacy migration/backfill path that links existing videos to provisional anime rows from parsed filenames. - -Added focused storage helpers for normalized anime identity reuse, later AniList upgrades, and per-video season/episode/parser metadata linking. Media ingest now parses and links anime metadata during `handleMediaChange(...)`. - -Added anime-level query surfaces for library/detail/episode aggregation and regression coverage for schema, migration, storage, parser fallback, service ingest wiring, and anime stats queries. - -Verified with the focused SQLite lane plus verifier-selected `core` coverage (`typecheck`, `test:fast`). No stats API/UI export was added yet because there is no current consumer for the new anime query surface. - diff --git a/backlog/completed/task-169 - Cut-minor-release-v0.7.0-for-stats-and-runtime-polish.md b/backlog/completed/task-169 - Cut-minor-release-v0.7.0-for-stats-and-runtime-polish.md deleted file mode 100644 index 093dfd0c..00000000 --- a/backlog/completed/task-169 - Cut-minor-release-v0.7.0-for-stats-and-runtime-polish.md +++ /dev/null @@ -1,80 +0,0 @@ ---- -id: TASK-169 -title: Cut minor release v0.7.0 for stats and runtime polish -status: Done -assignee: - - codex -created_date: '2026-03-19 17:20' -updated_date: '2026-03-19 17:31' -labels: - - release - - docs - - minor -dependencies: - - TASK-168 -references: - - package.json - - README.md - - docs/RELEASING.md - - docs-site/changelog.md - - CHANGELOG.md - - release/release-notes.md -priority: high -ordinal: 108000 ---- - -## Description - - -Prepare the next release cut as `v0.7.0`, keeping 0-ver semantics by rolling the accumulated stats/dashboard, launcher, overlay, and stability work into the next minor line instead of a `1.0.0` release. - - -## Acceptance Criteria - -- [x] #1 Repository version metadata is updated to `0.7.0`. -- [x] #2 Root release-facing docs are refreshed for the `0.7.0` release cut. -- [x] #3 `CHANGELOG.md` and `release/release-notes.md` contain the committed `v0.7.0` section and consumed fragments are removed. -- [x] #4 Public changelog/docs surfaces reflect the new release. -- [x] #5 Release-prep verification is recorded. - - -## Implementation Plan - - -1. Bump `package.json` to `0.7.0`. -2. Refresh release-facing docs: root `README.md`, release guide versioning note, and public docs changelog summary. -3. Run `bun run changelog:build --version 0.7.0` to commit release artifacts and consume pending fragments. -4. Run release-prep verification (`changelog`, typecheck, tests, docs build if docs-site changed). -5. Update this task with notes, verification, and final summary. - - -## Implementation Notes - - -Bumped `package.json` from `0.6.5` to `0.7.0` and refreshed the root release-facing copy in `README.md` so the release prep explicitly calls out the new stats/dashboard line plus the background stats daemon commands. Updated `docs/RELEASING.md` with the repo's 0-ver versioning policy and an explicit `--date` reminder after the changelog generator initially stamped `2026-03-20` from UTC instead of the intended local release date `2026-03-19`. - -Ran `bun run changelog:build --version 0.7.0`, which generated `CHANGELOG.md` and `release/release-notes.md` and removed the queued `changes/*.md` fragments for the accumulated stats, launcher, overlay, JLPT, and stability work. Added a curated `v0.7.0` summary to `docs-site/changelog.md` so the public docs changelog stays aligned with the committed root changelog while remaining user-facing. - -Verification: -- `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh` -- `bun run changelog:lint` -- `bun run changelog:check --version 0.7.0` -- `bun run verify:config-example` -- `bun run typecheck` -- `bun run test:fast` -- `bun run test:env` -- `bun run build` -- `bun run docs:test` -- `bun run docs:build` - - -## Final Summary - - -Prepared minor release `v0.7.0` as the next 0-ver major line. Version metadata, root changelog, generated release notes, README release copy, release-guide policy, and the public docs changelog are now aligned for the release cut. - -Docs update required: yes. Completed in `README.md`, `docs/RELEASING.md`, and `docs-site/changelog.md`. -Changelog fragment required: no new fragment for this task. Existing pending release fragments were consumed into the committed `v0.7.0` changelog section and `release/release-notes.md`. - -Release-prep verification passed across changelog validation, config-example verification, typecheck, fast/env tests, full build, and docs-site test/build. - diff --git a/backlog/completed/task-170 - Fix-imm_words-POS-filtering-and-add-stats-cleanup-maintenance-command.md b/backlog/completed/task-170 - Fix-imm_words-POS-filtering-and-add-stats-cleanup-maintenance-command.md deleted file mode 100644 index cd17c251..00000000 --- a/backlog/completed/task-170 - Fix-imm_words-POS-filtering-and-add-stats-cleanup-maintenance-command.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-170 -title: Fix imm_words POS filtering and add stats cleanup maintenance command -status: Done -assignee: [] -created_date: '2026-03-13 00:00' -updated_date: '2026-03-18 05:31' -labels: [] -milestone: m-1 -dependencies: [] -priority: high -ordinal: 9010 ---- - -## Description - - -`imm_words` is currently populated from raw subtitle text instead of tokenized subtitle metadata, so ignored functional/noise tokens leak into stats and no POS metadata is stored. Fix live persistence to follow the existing token annotation exclusion rules and add an on-demand stats cleanup command to remove stale bad vocabulary rows from the stats DB. - - -## Acceptance Criteria - -- [x] #1 New `imm_words` inserts use tokenized subtitle data, persist POS metadata, and skip tokens excluded by existing POS-based vocabulary ignore rules. -- [x] #2 `subminer stats cleanup` supports `-v` / `--vocab`, defaults to vocab cleanup, and removes stale bad `imm_words` rows on demand. -- [x] #3 Regression coverage exists for persistence filtering, cleanup behavior, and stats cleanup CLI wiring. - - -## Final Summary - - -Fixed `imm_words` persistence so the tracker now consumes tokenized subtitle data, stores POS metadata (`part_of_speech`, `pos1`, `pos2`, `pos3`), preserves distinct surface/lemma fields (`word` vs `headword`) when tokenization provides them, and skips vocabulary rows excluded by the existing POS/noise rules instead of mining raw subtitle fragments. Added `subminer stats cleanup` with default vocab cleanup plus `-v/--vocab`; the cleanup pass now repairs stale `headword`, `reading`, and `part_of_speech` values, attempts best-effort MeCab backfill for legacy rows, and removes rows that still have no usable POS metadata or fail the vocab filters. - -Verification: - -- `bun run typecheck` -- `bun test src/core/services/immersion-tracker-service.test.ts src/core/services/immersion-tracker/__tests__/query.test.ts src/core/services/immersion-tracker/storage-session.test.ts launcher/parse-args.test.ts launcher/commands/command-modules.test.ts src/main/runtime/stats-cli-command.test.ts src/main/runtime/mpv-main-event-main-deps.test.ts src/core/services/cli-command.test.ts` -- `bun run docs:test` -- `bun run docs:build` - diff --git a/backlog/completed/task-171 - Add-normalized-immersion-word-and-kanji-occurrence-tracking.md b/backlog/completed/task-171 - Add-normalized-immersion-word-and-kanji-occurrence-tracking.md deleted file mode 100644 index 1ca5c5fe..00000000 --- a/backlog/completed/task-171 - Add-normalized-immersion-word-and-kanji-occurrence-tracking.md +++ /dev/null @@ -1,80 +0,0 @@ ---- -id: TASK-171 -title: Add normalized immersion word and kanji occurrence tracking -status: Done -assignee: - - codex -created_date: '2026-03-14 11:30' -updated_date: '2026-03-16 05:13' -labels: - - immersion - - stats - - database -milestone: m-1 -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/docs/plans/2026-03-14-immersion-occurrence-tracking-design.md - - >- - /home/sudacode/projects/japanese/SubMiner/docs/plans/2026-03-14-immersion-occurrence-tracking.md -ordinal: 19500 ---- - -## Description - - -Add normalized occurrence tables for immersion-tracked words and kanji so stats can map vocabulary back to the exact anime, episode, timestamp, and subtitle line where each item appeared. Preserve repeated tokens within the same line via counted occurrences instead of deduping, while avoiding duplicated token text storage. - - -## Acceptance Criteria - -- [x] #1 The immersion schema adds normalized subtitle-line and counted occurrence tables for words and kanji, with additive migration support for existing databases. -- [x] #2 Subtitle-line tracking writes one subtitle-line row per seen line plus counted word/kanji occurrences linked back to the line, session, video, and anime context. -- [x] #3 Query surfaces can map a word or kanji back to anime/episode/line/timestamp rows without breaking current top-level vocabulary and kanji stats. -- [x] #4 Focused regression coverage exists for schema, counted occurrence persistence, and reverse-mapping queries. -- [x] #5 Verification covers the SQLite immersion lane and any broader lanes required by touched service/API files. - - -## Implementation Plan - - -1. Add red tests for new line/occurrence schema and migration shape in the SQLite immersion lane. -2. Add red tests for service-level subtitle persistence that writes one line row plus counted word/kanji occurrences. -3. Implement additive schema, write-path plumbing, and counted occurrence upserts with minimal disruption to existing aggregate tables. -4. Add reverse-mapping query surfaces for word and kanji occurrences, plus focused API/service exposure only where needed. -5. Run focused SQLite verification first, then broader verification only if touched runtime/API files require it. - - -## Implementation Notes - - -2026-03-14: Design approved in-thread. Chosen shape: `imm_subtitle_lines` plus counted bridge tables `imm_word_line_occurrences` and `imm_kanji_line_occurrences`, retaining repeated tokens within a line via `occurrence_count`. -2026-03-14: Implemented additive schema version bump to 7. `recordSubtitleLine(...)` now queues one normalized subtitle-line write that owns aggregate word/kanji upserts plus counted bridge-row inserts. -2026-03-14: Added reverse-mapping query surfaces for exact word triples and single kanji lookups. No stats API/UI consumer was widened in this change. -2026-03-14: Verification commands run: - - `bun test src/core/services/immersion-tracker-service.test.ts` - - `bun test src/core/services/immersion-tracker/storage-session.test.ts` - - `bun test src/core/services/immersion-tracker/__tests__/query.test.ts` - - `bun run typecheck` - - `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh src/core/services/immersion-tracker/types.ts src/core/services/immersion-tracker/storage.ts src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker-service.ts src/core/services/immersion-tracker/storage-session.test.ts src/core/services/immersion-tracker-service.test.ts src/core/services/immersion-tracker/__tests__/query.test.ts` - - `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/core/services/immersion-tracker/types.ts src/core/services/immersion-tracker/storage.ts src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker-service.ts src/core/services/immersion-tracker/storage-session.test.ts src/core/services/immersion-tracker-service.test.ts src/core/services/immersion-tracker/__tests__/query.test.ts` - - `bun run test:immersion:sqlite:src` -2026-03-14: Verification results: - - targeted tracker/query tests: passed - - verifier lane selection: `core` - - verifier result: passed (`typecheck`, `test:fast`) - - verifier artifacts: `.tmp/skill-verification/subminer-verify-20260314-114630-abO7mb/` - - maintained immersion SQLite lane: passed - - -## Final Summary - - -Added normalized subtitle-line occurrence tracking to immersion stats with three additive tables: `imm_subtitle_lines`, `imm_word_line_occurrences`, and `imm_kanji_line_occurrences`. - -`recordSubtitleLine(...)` now preserves repeated allowed tokens and repeated kanji within the same subtitle line via `occurrence_count`, while still updating canonical `imm_words` and `imm_kanji` aggregates. - -Added reverse-mapping queries for exact word triples and kanji so callers can fetch anime/video/session/line/timestamp context for each occurrence without duplicating token text storage. - -Verified with targeted tracker/query tests, `bun run typecheck`, verifier-selected `core` coverage, and the maintained `bun run test:immersion:sqlite:src` lane. - diff --git a/backlog/completed/task-172 - Stabilize-macOS-fullscreen-overlay-layering-and-tracker-flaps.md b/backlog/completed/task-172 - Stabilize-macOS-fullscreen-overlay-layering-and-tracker-flaps.md deleted file mode 100644 index 7b19fb12..00000000 --- a/backlog/completed/task-172 - Stabilize-macOS-fullscreen-overlay-layering-and-tracker-flaps.md +++ /dev/null @@ -1,76 +0,0 @@ ---- -id: TASK-172 -title: Stabilize macOS fullscreen overlay layering and tracker flaps -status: Done -assignee: - - '@codex' -created_date: '2026-03-16 10:45' -updated_date: '2026-03-18 05:28' -labels: - - bug - - macos - - overlay -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/overlay-window.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/overlay-visibility.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/overlay-runtime-init.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/window-trackers/macos-tracker.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main.ts -priority: high -ordinal: 54500 ---- - -## Description - - -Fix the macOS fullscreen overlay bug where the visible overlay can slip behind mpv or become briefly hidden/non-interactable after tracker/helper churn. Keep the passive visible overlay from stealing focus, reassert topmost ordering more aggressively on macOS, and tolerate transient tracker misses so fullscreen playback does not flash the overlay away. - - -## Acceptance Criteria - -- [x] #1 On macOS, passive visible-overlay refreshes do not call `focus()` just to stay visible. -- [x] #2 macOS overlay window level reassertion actively raises the visible overlay above fullscreen video. -- [x] #3 A single transient macOS tracker/helper miss does not immediately drop tracking and hide the overlay. -- [x] #4 Focused regression coverage exists for the macOS overlay/runtime/tracker paths touched by the fix. -- [x] #5 Subtitle tokenization warmup only gates the first ready cycle per app launch, even if fullscreen/macOS runtime churn re-emits media updates later. -- [x] #6 macOS fullscreen enter/leave churn does not immediately hide the overlay just because the helper reports a short burst of transient misses. -- [x] #7 Initial startup does not invalidate subtitle/tokenization state again when the character dictionary auto-sync completes with `changed=false`. - - -## Implementation Notes - - -Changed `src/core/services/overlay-visibility.ts` so the passive visible overlay no longer calls `focus()` on macOS just to stay visible, which avoids the fullscreen activation tug-of-war with mpv while preserving the existing Windows click-through path and the existing non-macOS focus behavior. - -Changed `src/core/services/overlay-window.ts` to call `moveTop()` as part of macOS level reassertion, and changed `src/core/services/overlay-runtime-init.ts` so tracker focus flips now refresh visible-overlay visibility before shortcut re-sync. That gives the visible overlay another z-order recovery path during fullscreen focus churn instead of waiting for a later blur/show cycle. - -Changed `src/window-trackers/macos-tracker.ts` to add a small helper runner seam plus consecutive-miss tolerance. The tracker now keeps the last-known tracked geometry through one transient helper miss and only drops tracking after repeated misses, which prevents immediate hide/flash-back behavior when the macOS helper briefly times out or returns `not-found`. - -Follow-up after live macOS fullscreen feedback: changed `src/main/runtime/current-media-tokenization-gate.ts` so the tokenization-ready gate becomes one-shot for the lifetime of the app after the first successful ready signal, and changed `src/main/runtime/startup-osd-sequencer.ts` so media-change resets no longer clear that ready bit after first warmup. That keeps later fullscreen/runtime churn from pausing on a fresh tokenization warmup or replaying the startup sequencing path after the app has already warmed once. - -Second follow-up after reproducer refinement around fullscreen toggles: changed `src/window-trackers/macos-tracker.ts` again so helper misses use a bounded loss-grace window instead of dropping tracking as soon as a short burst crosses the raw miss threshold. The tracker now keeps the last-known mpv geometry through fullscreen enter/leave transitions long enough for the macOS helper to restabilize, which avoids the overlay hide/reload loop driven by `Overlay loading...` during transient fullscreen churn. - -Third follow-up after initial-startup testing: extracted the character-dictionary auto-sync completion side effects into `src/main/runtime/character-dictionary-auto-sync-completion.ts` and stopped running the expensive parser-cache/tokenization/subtitle refresh path when sync completes with `changed=false`. That leaves the completion log/ready notification intact, but avoids replaying subtitle refresh work for media whose character dictionary was already current at startup. - -Added focused regressions in `src/core/services/overlay-visibility.test.ts`, `src/core/services/overlay-runtime-init.test.ts`, `src/window-trackers/macos-tracker.test.ts`, `src/main/runtime/current-media-tokenization-gate.test.ts`, and `src/main/runtime/startup-osd-sequencer.test.ts`. Verified with targeted Bun tests, `bun run typecheck`, and the repo runtime-compat verifier lane except for an unrelated pre-existing `bun run build` failure in `src/main/runtime/stats-cli-command.test.ts`. - - -## Final Summary - - -Stabilized the macOS fullscreen/startup overlay path by removing passive visible-overlay focus stealing, reasserting the overlay window level with `moveTop()` on macOS, refreshing visible-overlay visibility when tracker focus changes, adding a bounded macOS tracker loss-grace window for fullscreen-transition misses, making subtitle tokenization warmup sticky for the rest of the app session after the first successful ready cycle, and skipping expensive subtitle/tokenization refresh work when character-dictionary auto-sync completes without any real dictionary change. This reduces the main failure modes from the investigation: the visible overlay slipping behind fullscreen mpv, tracker flaps hiding the overlay during fullscreen transitions, fullscreen/runtime churn replaying startup warmup after playback was already running, and initial startup flashing/reloading after an already-current character dictionary reports ready. - -Verification: -- `bun test src/core/services/overlay-window.test.ts src/core/services/overlay-visibility.test.ts src/core/services/overlay-runtime-init.test.ts src/window-trackers/x11-tracker.test.ts src/window-trackers/macos-tracker.test.ts` -- `bun run typecheck` -- `bun test src/main/runtime/current-media-tokenization-gate.test.ts src/main/runtime/startup-osd-sequencer.test.ts src/main/runtime/character-dictionary-auto-sync.test.ts src/main/runtime/composers/mpv-runtime-composer.test.ts` -- `bun test src/window-trackers/macos-tracker.test.ts src/core/services/overlay-visibility.test.ts src/core/services/overlay-runtime-init.test.ts` -- `bun test src/main/runtime/character-dictionary-auto-sync-completion.test.ts src/main/runtime/character-dictionary-auto-sync.test.ts src/main/runtime/current-media-tokenization-gate.test.ts src/main/runtime/startup-osd-sequencer.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane runtime-compat src/core/services/overlay-visibility.ts src/core/services/overlay-window.ts src/core/services/overlay-runtime-init.ts src/window-trackers/macos-tracker.ts src/core/services/overlay-visibility.test.ts src/core/services/overlay-runtime-init.test.ts src/window-trackers/macos-tracker.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane runtime-compat src/main/runtime/current-media-tokenization-gate.ts src/main/runtime/startup-osd-sequencer.ts src/main/runtime/current-media-tokenization-gate.test.ts src/main/runtime/startup-osd-sequencer.test.ts` [build blocked by unrelated `src/main/runtime/stats-cli-command.test.ts` typing errors already present in workspace] - diff --git a/backlog/completed/task-173 - Deduplicate-character-dictionary-auto-sync-startup-triggers.md b/backlog/completed/task-173 - Deduplicate-character-dictionary-auto-sync-startup-triggers.md deleted file mode 100644 index 3c6ce4af..00000000 --- a/backlog/completed/task-173 - Deduplicate-character-dictionary-auto-sync-startup-triggers.md +++ /dev/null @@ -1,55 +0,0 @@ ---- -id: TASK-173 -title: Deduplicate character dictionary auto-sync startup triggers -status: Done -assignee: [] -created_date: '2026-03-16 11:05' -updated_date: '2026-03-16 11:20' -labels: - - bug - - character-dictionary - - startup -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/main.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/mpv-client-event-bindings.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/mpv-main-event-actions.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts -priority: medium -ordinal: 36500 ---- - -## Description - - -Reduce duplicate character dictionary auto-sync work during startup and media changes. The current runtime schedules auto-sync from mpv connection, media-path, and media-title events, and the auto-sync runtime only debounces bursty calls for 800ms before queueing another full run. On slower macOS startup paths this can surface repeated checking/generating/building/importing progress for the same title and unnecessarily retrigger tokenization/annotation refresh work after sync completion. - - -## Acceptance Criteria - -- [x] #1 Startup for one stable media path/title triggers at most one expensive snapshot/build/import run for the same AniList media unless the resolved media actually changes. -- [x] #2 Repeated mpv connection/title/path events within the same startup sequence are coalesced without losing legitimate media-change updates. -- [x] #3 Focused regression coverage exists for the deduped trigger path and same-media cache-miss races. - - -## Implementation Notes - - -Reduced the auto-sync trigger surface to mpv `media-path-change` only. `connection-change` still refreshes Discord presence and overlay subtitle suppression, and `media-title-change` still updates title/guess/immersion state, but neither path schedules character-dictionary auto-sync anymore. - -That keeps the auto-sync runtime itself unchanged and fixes the duplicate-startup behavior at the source: one stable startup sequence now produces one path-triggered sync instead of stacking extra runs from connection and title events that often arrive slightly later on macOS. - -Updated focused regression coverage in `src/main/runtime/mpv-client-event-bindings.test.ts` and `src/main/runtime/mpv-main-event-actions.test.ts`, then re-ran the related mpv binding/deps tests plus `src/main/runtime/character-dictionary-auto-sync.test.ts`. - - -## Final Summary - - -Fixed repeated character-dictionary startup work by stopping auto-sync scheduling from mpv `connection-change` and `media-title-change`; only `media-path-change` now triggers the sync. This preserves the existing media-state updates while removing the two extra startup triggers that were queueing redundant auto-sync runs for the same title. - -Verification: -- `bun test src/main/runtime/mpv-client-event-bindings.test.ts src/main/runtime/mpv-main-event-actions.test.ts` -- `bun test src/main/runtime/mpv-client-event-bindings.test.ts src/main/runtime/mpv-main-event-actions.test.ts src/main/runtime/mpv-main-event-bindings.test.ts src/main/runtime/mpv-main-event-main-deps.test.ts src/main/runtime/character-dictionary-auto-sync.test.ts` -- `bun run typecheck` - diff --git a/backlog/completed/task-173 - Remove-Avg-Frequency-metric-from-Vocabulary-tab-summary-cards.md b/backlog/completed/task-173 - Remove-Avg-Frequency-metric-from-Vocabulary-tab-summary-cards.md deleted file mode 100644 index 90efcc3c..00000000 --- a/backlog/completed/task-173 - Remove-Avg-Frequency-metric-from-Vocabulary-tab-summary-cards.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -id: TASK-173 -title: Remove Avg Frequency metric from Vocabulary tab summary cards -status: Done -assignee: [] -created_date: '2026-03-15 00:13' -updated_date: '2026-03-16 05:13' -labels: - - stats - - ui -milestone: m-1 -dependencies: [] -priority: low -ordinal: 17500 ---- - -## Description - - -User requested removing the Avg Frequency card/metric because it is not useful. Remove the UI card and stop computing/storing the summary field in dashboard summary shaping code. - - -## Acceptance Criteria - -- [x] #1 Vocabulary tab no longer renders an "Avg Frequency" stat card. -- [x] #2 Vocabulary summary model no longer exposes or computes averageFrequency. -- [x] #3 Typecheck/tests covering dashboard summary and vocabulary tab pass. - - -## Final Summary - - -Removed the Vocabulary tab "Avg Frequency" card and deleted the corresponding `averageFrequency` field from `VocabularySummary` and `buildVocabularySummary`. - -Verification run: -- `bun test stats/src/lib/dashboard-data.test.ts` -- `bun run typecheck` -- `bun run test:fast` -- `bun run build` -- `bun run test:env` -- `bun run test:smoke:dist` - diff --git a/backlog/completed/task-174 - Fix-missing-frequency-highlights-for-merged-tokenizer-tokens.md b/backlog/completed/task-174 - Fix-missing-frequency-highlights-for-merged-tokenizer-tokens.md deleted file mode 100644 index 7dabebf2..00000000 --- a/backlog/completed/task-174 - Fix-missing-frequency-highlights-for-merged-tokenizer-tokens.md +++ /dev/null @@ -1,68 +0,0 @@ ---- -id: TASK-174 -title: Fix missing frequency highlights for merged tokenizer tokens -status: Done -assignee: - - codex -created_date: '2026-03-15 10:18' -updated_date: '2026-03-18 05:28' -labels: - - bug - - tokenizer - - frequency-highlighting -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer/parser-selection-stage.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer/yomitan-parser-runtime.ts - - /Users/sudacode/projects/japanese/SubMiner/scripts/get_frequency.ts - - /Users/sudacode/projects/japanese/SubMiner/scripts/test-yomitan-parser.ts -priority: high -ordinal: 115500 ---- - -## Description - - -Frequency highlighting can miss words that should color within the configured top-X limit when tokenizer candidate selection keeps merged Yomitan units that combine a content word with trailing function text. The annotation stage then conservatively clears frequency for the whole merged token, so visible high-frequency words lose highlighting. The standalone debug CLIs are also failing to initialize the shared Yomitan runtime, which blocks reliable repro for this class of bug. - - -## Acceptance Criteria - -- [x] #1 Tokenizer no longer drops frequency highlighting for content words in merged-token cases where a better scanning parse candidate would preserve highlightable tokens. -- [x] #2 A regression test covers the reported sentence shape and fails before the fix. -- [x] #3 The standalone frequency/parser debug path can initialize the shared Yomitan runtime well enough to reproduce tokenizer output instead of immediately reporting runtime/session wiring errors. - - -## Implementation Plan - - -1. Add a regression test for the reported merged-token frequency miss, centered on Yomitan scanning candidate selection and downstream frequency annotation. -2. Update tokenizer candidate selection so merged content+function tokens do not win over candidates that preserve highlightable content tokens. -3. Repair the standalone frequency/parser debug scripts so their Electron/Yomitan runtime wiring matches current shared runtime expectations. -4. Verify with targeted tokenizer/parser tests and the standalone debug repro command. - - -## Implementation Notes - - -Initial triage: shared frequency class logic looks correct; likely failure is upstream tokenizer candidate selection producing merged content+function tokens that annotation later excludes from frequency. Standalone debug scripts also fail to initialize a usable Electron/Yomitan runtime, blocking reliable repro from the current CLI path. - -Repro after fixing the standalone Electron wrapper does not support the original highlight claim for `誰でもいいから かかってこいよ`: the tokenizer reports `かかってこい` with `frequencyRank` 63098, so it correctly stays uncolored at `--color-top-x 10000` and becomes colorable once the threshold is raised above that rank. The concrete bug fixed in this pass is the standalone Electron debug path: package scripts now unset `ELECTRON_RUN_AS_NODE`, and the scripts normalize Electron imports/guards so `get-frequency:electron` can reach real Electron/Yomitan runtime state instead of immediately falling back to Node-mode diagnostics. `test-yomitan-parser:electron` still shows extension/service-worker issues against the existing profile and was not stabilized in this pass. - -AC#1 confirmed: parser-selection-stage already prefers multi-token scanning candidates (line 313-316), so a split candidate that isolates the content word always beats a single merged content+function token. annotation-stage.ts shouldAllowContentLedMergedTokenFrequency handles the single-candidate case correctly. - -AC#2 done: added two regression tests to parser-selection-stage.test.ts — 'multi-token candidate beats single merged content+function token candidate (frequency regression)' and 'multi-token candidate beats single merged content+function token regardless of input order'. Both confirm the candidate selection picks the split candidate in both array orderings. - -AC#3 confirmed: scripts/get_frequency.ts and scripts/test-yomitan-parser.ts both compile cleanly (bun build --external electron succeeds, tsc clean). The remaining 'extension/service-worker issues' in test-yomitan-parser:electron are runtime/profile-specific — the scripts correctly reach Electron initialization and set available=false with a note rather than crashing on import/wiring errors. No code changes needed. - -All 526 tests pass (test:fast green). - - -## Final Summary - - -Fixed all three acceptance criteria for missing frequency highlights on merged tokenizer tokens.\n\n**AC#1**: Confirmed the parser-selection-stage already satisfies the requirement — multi-token scanning candidates are preferred over single merged content+function token candidates (parser-selection-stage.ts:313-316). The annotation-stage `shouldAllowContentLedMergedTokenFrequency` handles the fallback single-candidate case.\n\n**AC#2**: Added two regression tests to `src/core/services/tokenizer/parser-selection-stage.test.ts` covering the reported scenario where a merged content+function token candidate (e.g. `かかってこいよ` → headword `かかってくる`) competes against a split candidate (`かかってこい` + `よ`). Tests verify the split candidate wins in both array orderings.\n\n**AC#3**: Confirmed `scripts/get_frequency.ts` and `scripts/test-yomitan-parser.ts` compile cleanly. The Electron runtime wiring is correct; remaining issues are profile-specific service-worker limitations, not code defects.\n\n**Verification**: `bun run test:fast` green (526 tests). `bun run tsc` clean. Both scripts build with `bun build --external electron`.\n\n**Docs update required**: No — internal implementation detail.\n**Changelog fragment required**: No — no user-visible behavior change (the bug was in candidate selection logic that was already correct; this is a regression test coverage addition only."] - diff --git a/backlog/completed/task-176 - Exclude-interjections-and-sound-effects-from-subtitle-annotations.md b/backlog/completed/task-176 - Exclude-interjections-and-sound-effects-from-subtitle-annotations.md deleted file mode 100644 index 592eff43..00000000 --- a/backlog/completed/task-176 - Exclude-interjections-and-sound-effects-from-subtitle-annotations.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-176 -title: Exclude interjections and sound effects from subtitle annotations -status: Done -assignee: - - codex -created_date: '2026-03-15 12:07' -updated_date: '2026-03-16 05:13' -labels: - - bug - - tokenizer - - renderer -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer/annotation-stage.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer.test.ts - - /home/sudacode/projects/japanese/SubMiner/src/renderer/subtitle-render.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/renderer/subtitle-render.test.ts -priority: high -ordinal: 16500 ---- - -## Description - - -Subtitle tokens that are not useful annotation targets, especially interjections and sound-effect / onomatopoeia-style exclamations such as `ぐはっ` and `はあ`, can still survive tokenization and become interactive hover annotations. Keep the subtitle text visible, but remove these tokens from annotation payloads so they do not render hover targets or dictionary popovers. - - -## Acceptance Criteria - -- [x] #1 Interjection / sound-effect style tokens are excluded from subtitle annotation payloads and do not create interactive hover spans. -- [x] #2 Excluded tokens remain visible in rendered subtitle text as plain text. -- [x] #3 Regression tests cover at least one MeCab-tagged interjection case and one rendering-visible/plain-text case. - - -## Implementation Plan - - -1. Add regression coverage proving excluded tokens still come through visibly in subtitle text but no longer survive as annotation tokens. -2. Introduce a shared annotation-eligibility predicate in the tokenizer annotation stage for interjections / SFX-like tokens. -3. Filter subtitle token payloads through that predicate before renderer hover ranges/spans are built. -4. Verify with targeted tokenizer and renderer tests. - - -## Final Summary - - -Added a subtitle-annotation exclusion pass after token annotation so interjections and obvious SFX-style tokens are removed from returned token payloads while the original subtitle text stays intact. Coverage now includes MeCab-tagged `感動詞`, repeated-kana interjections such as `ああ`, a mixed `ぐはっ 猫` tokenizer case, and a renderer check proving omitted tokens stay visible as plain text instead of interactive hover spans. - diff --git a/backlog/completed/task-177 - Track-intentional-Yomitan-lookups-in-stats.md b/backlog/completed/task-177 - Track-intentional-Yomitan-lookups-in-stats.md deleted file mode 100644 index 1b231213..00000000 --- a/backlog/completed/task-177 - Track-intentional-Yomitan-lookups-in-stats.md +++ /dev/null @@ -1,74 +0,0 @@ ---- -id: TASK-177 -title: Track intentional Yomitan lookups in stats -status: Done -assignee: - - codex -created_date: '2026-03-17 09:15' -updated_date: '2026-03-18 05:28' -labels: - - stats - - immersion-tracking - - yomitan -milestone: m-1 -dependencies: [] -references: - - vendor/subminer-yomitan/ext/js/app/frontend.js - - src/core/services/immersion-tracker-service.ts - - src/core/services/immersion-tracker/query.ts - - src/core/services/ipc.ts - - src/preload.ts - - stats/src/components/sessions/SessionDetail.tsx - - stats/src/components/library/MediaHeader.tsx - - stats/src/components/anime/AnimeDetailView.tsx -documentation: - - docs/plans/2026-03-17-yomitan-lookup-stats-design.md -priority: medium -ordinal: 114500 ---- - -## Description - - -Add a dedicated intentional-Yomitan lookup metric so the stats app can show when and how often the user performed real Yomitan lookups while watching video. Keep existing annotation/known-word lookup counters unchanged. Surface the new metric in session detail, episode/media detail, and anime detail, including lookup rate based on words seen. - - -## Acceptance Criteria - -- [x] #1 Successful Yomitan searches while watching create a dedicated Yomitan lookup event and aggregate counter without changing existing lookupCount or lookupHits behavior -- [x] #2 Session detail shows Yomitan lookup timeline markers plus lookup count and lookup rate using words seen -- [x] #3 Episode/media detail shows aggregated Yomitan lookup count and lookup rate using episode totals -- [x] #4 Anime detail shows aggregated Yomitan lookup count and lookup rate using anime totals -- [x] #5 Automated tests cover the new lookup event path, aggregate queries, and affected stats UI surfaces -- [x] #6 Internal docs/plans reflect the approved design and implementation approach - - -## Implementation Plan - - -1. Add a SubMiner-specific Yomitan lookup signal emitted from vendored Yomitan on searchSuccess and bridge it through renderer, preload, and main IPC to a tracker hook. -2. Extend immersion tracking with a dedicated Yomitan lookup event type and yomitanLookupCount aggregate, preserving existing lookupCount and lookupHits semantics. -3. Update session, media, anime, and anime-episode queries plus shared stats types to expose the new aggregate count. -4. Update stats UI to show Yomitan lookup markers in session detail and lookup count/rate at session, episode/media, and anime levels using lookups per 100 words copy. -5. Verify with focused unit tests first, then repo typecheck/test/build lanes, and finalize TASK-177 with implementation notes and acceptance-criteria checks. - - -## Implementation Notes - - -Approved design recorded in docs/plans/2026-03-17-yomitan-lookup-stats-design.md. - -Observed pre-existing local changes in tracker/query/session stats files; implementation plan must preserve those edits while layering Yomitan lookup tracking on top. - -Implemented a dedicated Yomitan lookup signal on vendored searchSuccess, bridged it through renderer/preload/main IPC, and persisted YOMITAN_LOOKUP events plus yomitanLookupCount without changing existing annotation lookup counters. - -Extended stats queries/types for session, media, anime, and episode aggregates; updated session detail, media header, episode list, and anime overview to show Yomitan lookup counts and lookup rate copy as lookups per 100 words. - -Focused verification passed for IPC, tracker service/query, and stats UI tests. stats typecheck still has pre-existing unrelated failures in stats/src/components/anime/AnilistSelector.tsx and stats/src/lib/reading-utils.ts. - - -## Final Summary - - -Added intentional Yomitan lookup tracking end-to-end: vendored Yomitan searchSuccess now emits a SubMiner event, the app records dedicated YOMITAN_LOOKUP events and yomitanLookupCount aggregates, and the stats UI surfaces lookup counts/rates for sessions, episodes/media, and anime. Focused regression tests pass for the IPC bridge, tracker persistence/querying, and new stats UI helpers/components. Full `bun run typecheck:stats` remains blocked by unrelated existing errors in `stats/src/components/anime/AnilistSelector.tsx` and `stats/src/lib/reading-utils.ts`. - diff --git a/backlog/completed/task-177.1 - Fix-overview-lookup-rate-metric.md b/backlog/completed/task-177.1 - Fix-overview-lookup-rate-metric.md deleted file mode 100644 index 00ff3856..00000000 --- a/backlog/completed/task-177.1 - Fix-overview-lookup-rate-metric.md +++ /dev/null @@ -1,65 +0,0 @@ ---- -id: TASK-177.1 -title: Fix overview lookup rate metric -status: Done -assignee: - - '@codex' -created_date: '2026-03-19 17:46' -updated_date: '2026-03-23 03:22' -labels: - - stats - - immersion-tracking - - yomitan -dependencies: [] -references: - - stats/src/components/overview/OverviewTab.tsx - - stats/src/lib/dashboard-data.ts - - stats/src/lib/yomitan-lookup.ts - - src/core/services/immersion-tracker/query.ts - - src/core/services/stats-server.ts -parent_task_id: TASK-177 -priority: medium -ordinal: 132500 ---- - -## Description - - -Update the stats homepage Tracking Snapshot so Lookup Rate reflects lifetime intentional Yomitan lookups normalized by total tokens seen, matching the newer stats semantics already used in session, media, and anime views. - - -## Acceptance Criteria - -- [x] #1 Overview data exposes the lifetime totals needed to compute global Yomitan lookups per 100 tokens on the homepage -- [x] #2 The homepage Tracking Snapshot Lookup Rate card shows Yomitan lookup rate as `X / 100 tokens` with tooltip/copy aligned to that meaning -- [x] #3 Automated tests cover the lifetime totals plumbing and homepage summary/rendering change - - -## Implementation Plan - - -1. Extend overview lifetime hints/query plumbing to include total tokens seen and total intentional Yomitan lookups from finished sessions. -2. Add/adjust focused tests first for query hints, stats overview API typing/mocks, and overview summary formatting so the homepage metric fails under old semantics. -3. Update the overview summary/card to derive Lookup Rate from lifetime Yomitan lookups per 100 tokens and align tooltip/copy with that meaning. -4. Run focused verification on the touched query, stats-server, and stats UI tests; record results and blockers in the task notes. - - -## Implementation Notes - - -Extended overview lifetime hints to include total tokens seen and total intentional Yomitan lookups from finished sessions so the homepage can compute a true global lookup rate. - -Extracted the homepage Tracking Snapshot into a dedicated presentational component to keep OverviewTab smaller and make the Lookup Rate card copy directly testable. - -Focused verification passed for query hints, IPC/stats overview plumbing, stats server overview response, dashboard summary logic, and homepage snapshot rendering. - -SubMiner verifier core lane artifact: .tmp/skill-verification/subminer-verify-20260319-105320-7FDlwh. `bun run typecheck` passed there; `bun run test:fast` failed for a pre-existing/unrelated environment issue in scripts/update-aur-package.test.ts because scripts/update-aur-package.sh reported `mapfile: command not found`. - - -## Final Summary - - -Homepage Lookup Rate now uses lifetime intentional Yomitan lookups normalized by lifetime tokens seen, matching the existing session/media/anime semantics instead of the old known-word hit-rate metric. I extended overview query hints and API typings with total token and Yomitan lookup totals, updated the overview summary builder to reuse the shared per-100-token formatter, and replaced the inline Tracking Snapshot block with a dedicated component that renders `X / 100 tokens` plus Yomitan-specific tooltip copy. - -Tests added/updated: query hints coverage for the new lifetime totals, stats server and IPC overview fixtures, overview summary assertions, and a dedicated Tracking Snapshot render test for the homepage card text. Focused `bun test` runs passed for those touched areas. Repo-native verifier `--lane core` also passed `bun run typecheck`; its `bun run test:fast` step still fails for the unrelated existing `scripts/update-aur-package.sh: line 71: mapfile: command not found` environment issue. - diff --git a/backlog/completed/task-177.2 - Count-homepage-new-words-by-headword.md b/backlog/completed/task-177.2 - Count-homepage-new-words-by-headword.md deleted file mode 100644 index 8194fb1a..00000000 --- a/backlog/completed/task-177.2 - Count-homepage-new-words-by-headword.md +++ /dev/null @@ -1,63 +0,0 @@ ---- -id: TASK-177.2 -title: Count homepage new words by headword -status: Done -assignee: - - '@codex' -created_date: '2026-03-19 19:38' -updated_date: '2026-03-23 03:22' -labels: - - stats - - immersion-tracking - - vocabulary -dependencies: [] -references: - - src/core/services/immersion-tracker/query.ts - - stats/src/components/overview/TrackingSnapshot.tsx - - stats/src/lib/dashboard-data.ts -parent_task_id: TASK-177 -priority: medium -ordinal: 130500 ---- - -## Description - - -Align the homepage New Words metric with the Known Words semantics by counting distinct headwords first seen in the selected window, so inflected or alternate forms of the same word do not inflate the summary. - - -## Acceptance Criteria - -- [x] #1 Homepage new-word counts use distinct headwords by earliest first-seen timestamp instead of counting separate word-form rows -- [x] #2 Homepage tooltip/copy reflects the headword-based semantics -- [x] #3 Automated tests cover the headword de-duplication behavior and affected overview copy - - -## Implementation Plan - - -1. Change the new-word aggregate query to group `imm_words` by headword, compute each headword's earliest `first_seen`, and count headwords whose first sighting falls within today/week windows. -2. Add failing tests first for the aggregate path so multiple rows sharing a headword only contribute once. -3. Update homepage tooltip/copy to say unique headwords first seen today/week. -4. Run focused query and stats overview tests, then record verification and any blockers. - - -## Implementation Notes - - -Updated the new-word aggregate to count distinct headwords by each headword's earliest `first_seen` timestamp, so multiple inflected/form rows for the same headword contribute only once. - -Adjusted homepage tooltip copy to say unique headwords first seen today/week, keeping the visible card labels unchanged. - -Focused verification passed for the query aggregate and homepage snapshot tests. - -SubMiner verifier core lane artifact: .tmp/skill-verification/subminer-verify-20260319-123942-4intgW. `bun run typecheck` passed there; `bun run test:fast` still fails for the unrelated environment issue in scripts/update-aur-package.test.ts (`mapfile: command not found`). - - -## Final Summary - - -Homepage New Words now uses headword-level semantics instead of counting separate `(headword, word, reading)` rows. The aggregate query groups `imm_words` by headword, uses each headword's earliest `first_seen`, and counts headwords first seen today or this week so alternate forms do not inflate the summary. The homepage tooltip copy now explicitly says the metric is based on unique headwords. - -Added focused regression coverage for the de-duplication rule in `getQueryHints` and for the updated homepage tooltip text. Targeted `bun test` runs passed for the touched query and stats UI files. Repo verifier `--lane core` again passed `bun run typecheck`; `bun run test:fast` remains blocked by the unrelated existing `scripts/update-aur-package.sh: line 71: mapfile: command not found` failure. - diff --git a/backlog/completed/task-177.3 - Fix-attached-stats-command-flow-and-browser-config.md b/backlog/completed/task-177.3 - Fix-attached-stats-command-flow-and-browser-config.md deleted file mode 100644 index 3758747e..00000000 --- a/backlog/completed/task-177.3 - Fix-attached-stats-command-flow-and-browser-config.md +++ /dev/null @@ -1,65 +0,0 @@ ---- -id: TASK-177.3 -title: Fix attached stats command flow and browser config -status: Done -assignee: - - '@codex' -created_date: '2026-03-19 20:15' -updated_date: '2026-03-23 03:22' -labels: - - launcher - - stats - - cli -dependencies: [] -references: - - launcher/commands/stats-command.ts - - launcher/commands/command-modules.test.ts - - launcher/main.test.ts - - src/main/runtime/stats-cli-command.ts - - src/main/runtime/stats-cli-command.test.ts -parent_task_id: TASK-177 -priority: medium -ordinal: 129500 ---- - -## Description - - -Make `subminer stats` stay attached to the foreground app process instead of routing through daemon startup, while keeping background/stop behavior on the daemon path. Ensure browser opening for stats respects only `stats.autoOpenBrowser` in the normal stats flow. - - -## Acceptance Criteria - -- [x] #1 Default `subminer stats` forwards through the attached foreground stats command path instead of the daemon-start path -- [x] #2 `subminer stats --background` and `subminer stats --stop` continue using the daemon control path -- [x] #3 Normal stats launches do not open a browser when `stats.autoOpenBrowser` is false, and automated tests cover the launcher/runtime regressions - - -## Implementation Plan - - -1. Add failing launcher tests first so default `stats` expects `--stats` forwarding while `--background` and `--stop` continue to expect daemon control flags. -2. Add/adjust runtime stats command tests to prove `stats.autoOpenBrowser=false` suppresses browser opening on the normal attached stats path. -3. Patch launcher forwarding logic in `launcher/commands/stats-command.ts` to choose foreground vs daemon flags correctly without changing cleanup handling. -4. Run targeted launcher and stats runtime tests, then record verification results and blockers. - - -## Implementation Notes - - -Confirmed root cause: launcher default `stats` flow always forwarded `--stats-daemon-start` plus `--stats-daemon-open-browser`, which detached the terminal process and bypassed `stats.autoOpenBrowser` because browser opening happened in daemon control instead of the normal stats CLI handler. - -Updated launcher forwarding so plain `subminer stats` now uses the attached `--stats` path, while explicit `--background` and `--stop` continue using daemon control flags. - -Added launcher regression coverage for the attached/default path and preserved background/stop expectations; added runtime coverage proving `stats.autoOpenBrowser=false` suppresses browser opening on the normal stats path. - -Verifier passed for `launcher-plugin` and `runtime-compat` lanes. Artifact: .tmp/skill-verification/subminer-verify-20260319-131703-ZaAaUV. - - -## Final Summary - - -Fixed `subminer stats` so the default command now forwards to the normal attached `--stats` app path instead of the daemon-start path. That keeps the foreground process attached to the terminal as expected, while `subminer stats --background` and `subminer stats --stop` still use daemon control. Because the normal stats CLI path already respects `config.stats.autoOpenBrowser`, this also fixes the unwanted browser-open behavior that previously bypassed config via `--stats-daemon-open-browser`. - -Added launcher command and launcher integration regressions for the new forwarding behavior, plus a runtime stats CLI regression that asserts `stats.autoOpenBrowser=false` suppresses browser opening. Verification passed with targeted launcher tests, targeted runtime stats tests, and the SubMiner verifier `launcher-plugin` + `runtime-compat` lanes. - diff --git a/backlog/completed/task-178 - Address-PR-19-Codex-review-feedback-on-immersion-session-deletion.md b/backlog/completed/task-178 - Address-PR-19-Codex-review-feedback-on-immersion-session-deletion.md deleted file mode 100644 index 2a1938fe..00000000 --- a/backlog/completed/task-178 - Address-PR-19-Codex-review-feedback-on-immersion-session-deletion.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-178 -title: 'Address PR #19 Codex review feedback on immersion session deletion' -status: Done -assignee: - - codex -created_date: '2026-03-17 14:59' -updated_date: '2026-03-18 05:28' -labels: - - pr-review - - immersion-tracker - - stats -milestone: m-1 -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker-service.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/query.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker-service.test.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/__tests__/query.test.ts -priority: medium -ordinal: 113500 ---- - -## Description - - -Assess the open Codex review items on PR #19 and fix verified deletion-path regressions in immersion tracking so dashboard deletes cannot corrupt tracker state or leave stale aggregate stats. - - -## Acceptance Criteria - -- [x] #1 Deleting the active immersion session is rejected safely and does not leave the tracker in a flush-failure loop -- [x] #2 Deleting sessions rebuilds or updates vocabulary and kanji aggregates so stats no longer include removed session data -- [x] #3 Regression tests cover the active-session deletion guard and aggregate cleanup after session deletion - - -## Implementation Plan - - -1. Add failing regression tests for deleting the active session through ImmersionTrackerService and for deleteSession/deleteSessions keeping imm_words and imm_kanji aggregates in sync after rows are removed. -2. Verify the failures are caused by the current deletion path, then patch the service guard and query-layer aggregate maintenance with the smallest safe change. -3. Re-run focused tests for the touched files, then run SubMiner verification lanes appropriate for core/runtime-compat changes and record results. - - -## Implementation Notes - - -Verified Codex PR #19 findings against current code: active-session/video deletes could orphan the live tracker session, and deleteSession/deleteSessions/deleteVideo left imm_words/imm_kanji aggregates stale after subtitle-line removal. - -Implemented service guards that ignore deletes targeting the active session or active video and log a warning instead of deleting live tracker rows. - -Updated query-layer delete helpers to capture affected word/kanji ids before deletion, remove session/video rows in a transaction, then recompute surviving imm_words/imm_kanji frequency and first/last-seen values from remaining subtitle-line occurrences, deleting orphan aggregate rows when no occurrences remain. - -Focused verification passed: bun test src/core/services/immersion-tracker-service.test.ts and bun test src/core/services/immersion-tracker/__tests__/query.test.ts. - -SubMiner verifier: classify_subminer_diff.sh selected lane core; verify_subminer_change.sh passed typecheck and failed on unrelated existing launcher test `stats command tolerates slower dashboard startup before timing out` in launcher/main.test.ts (timeout waiting for dashboard startup response). - - -## Final Summary - - -Assessed the open Codex PR #19 review items on immersion deletion paths and fixed the confirmed regressions. ImmersionTrackerService now ignores delete requests that target the currently active session or its active video, preventing the dashboard from deleting the live parent rows that subsequent telemetry/event flushes still depend on. On the query side, session/video deletion now captures affected vocabulary and kanji aggregate ids before removing subtitle/session rows, then recomputes imm_words and imm_kanji frequency plus first/last seen timestamps from surviving line occurrences inside the same transaction, deleting orphan aggregate rows when no occurrences remain. - -Regression coverage was added for active-session delete protection, active-video delete protection, and aggregate rebuild after session deletion. Focused verification passed with `bun test src/core/services/immersion-tracker-service.test.ts` and `bun test src/core/services/immersion-tracker/__tests__/query.test.ts`. Repo-native verification selected the `core` lane; `bun run typecheck` passed, while `bun run test:fast` failed in an unrelated launcher test (`launcher/main.test.ts`: `stats command tolerates slower dashboard startup before timing out`) that times out waiting for dashboard startup response. - diff --git a/backlog/completed/task-179 - Tune-immersion-tracker-SQLite-pragmas-and-maintenance-defaults.md b/backlog/completed/task-179 - Tune-immersion-tracker-SQLite-pragmas-and-maintenance-defaults.md deleted file mode 100644 index be89acb9..00000000 --- a/backlog/completed/task-179 - Tune-immersion-tracker-SQLite-pragmas-and-maintenance-defaults.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-179 -title: Tune immersion tracker SQLite pragmas and maintenance defaults -status: Done -assignee: - - codex -created_date: '2026-03-17 15:15' -updated_date: '2026-03-18 05:28' -labels: - - sqlite - - immersion-tracking - - performance -dependencies: [] -documentation: - - >- - /Users/sudacode/projects/japanese/SubMiner/docs/plans/2026-03-17-sqlite-tuning.md -priority: medium -ordinal: 111500 ---- - -## Description - - -Apply low-risk SQLite tuning improvements for the immersion tracker: add modern recommended maintenance/tuning pragmas where appropriate, cover them with regression tests, and update user-facing docs to reflect the actual tuning policy. Scope limited to low-risk local-DB changes already discussed: keep WAL + synchronous=NORMAL, add optimize path, consider WAL growth control, and document workload-dependent knobs left at defaults. - - -## Acceptance Criteria - -- [x] #1 Immersion tracker applies the agreed low-risk SQLite tuning changes without regressing current behavior -- [x] #2 Regression tests cover the new pragma/maintenance behavior -- [x] #3 Immersion tracking docs describe the tuning policy and notable defaults left unchanged - - -## Implementation Plan - - -1. Add regression coverage for connection pragmas and verify the new WAL growth cap fails before implementation. -2. Add regression coverage for maintenance-time PRAGMA optimize and verify the test fails before implementation. -3. Implement the minimal SQLite tuning changes. -4. Update immersion-tracking docs for the new tuning policy. -5. Run targeted SQLite verification lanes and record results. - - -## Implementation Notes - - -Verification: `bun test src/core/services/immersion-tracker/storage-session.test.ts src/core/services/immersion-tracker/maintenance.test.ts` passed (15 tests). - -Verification: `bun run test:immersion:sqlite:src` passed (37 tests). - -Verification: `bun run typecheck`, `bun run docs:test`, `bun run docs:build`, `bun run test:fast`, `bun run test:env`, and `bun run build` all passed. - - -## Final Summary - - -Added low-risk SQLite tuning improvements for the immersion tracker: `journal_size_limit` now bounds WAL growth, periodic maintenance runs `PRAGMA optimize`, regression tests cover both behaviors, and the immersion-tracking docs explain the maintained pragmas plus workload-dependent defaults left unchanged. - diff --git a/backlog/completed/task-180 - Fix-launcher-stats-command-timeout-for-slow-dashboard-startup.md b/backlog/completed/task-180 - Fix-launcher-stats-command-timeout-for-slow-dashboard-startup.md deleted file mode 100644 index e500b0e2..00000000 --- a/backlog/completed/task-180 - Fix-launcher-stats-command-timeout-for-slow-dashboard-startup.md +++ /dev/null @@ -1,62 +0,0 @@ ---- -id: TASK-180 -title: Fix launcher stats command timeout for slow dashboard startup -status: Done -assignee: - - codex -created_date: '2026-03-17 15:16' -updated_date: '2026-03-18 05:28' -labels: - - launcher - - stats - - tests -milestone: m-1 -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/commands/stats-command.ts - - /Users/sudacode/projects/japanese/SubMiner/launcher/main.test.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/launcher/commands/command-modules.test.ts -priority: medium -ordinal: 112500 ---- - -## Description - - -Address the failing launcher stats startup path so the CLI tolerates the intended slow dashboard startup window instead of timing out early. - - -## Acceptance Criteria - -- [x] #1 The launcher stats command no longer times out before the intended slow-start window used by tests -- [x] #2 Regression coverage verifies the slower stats startup path succeeds -- [x] #3 The failing launcher stats startup test passes locally - - -## Implementation Plan - - -1. Add a focused launcher command regression that simulates a stats response arriving after the current timeout boundary and expects success. -2. Adjust the stats startup wait timeout in launcher/commands/stats-command.ts to match the intended slow-start tolerance. -3. Re-run the targeted command test, the previously failing launcher/main.test.ts case, and then the full launcher/main.test.ts file. - - -## Implementation Notes - - -Verified the failing launcher path: launcher/main.test.ts timed out because launcher/commands/stats-command.ts only waited 8000ms for the stats startup response while the supported slow-start test writes the response after 9s. - -Raised the stats startup response timeout to 12000ms so attached stats startup tolerates the existing slow cold-start window without changing command flow. - -Verification passed: bun test launcher/commands/command-modules.test.ts --test-name-pattern "stats command launches attached app command with response path|stats command returns after startup response even if app process stays running|stats command throws when stats response reports an error"; bun test launcher/main.test.ts --test-name-pattern "stats command tolerates slower dashboard startup before timing out"; bun test launcher/main.test.ts; bun run test:fast. - - -## Final Summary - - -Fixed the launcher stats startup timeout by extending the response-file wait window in launcher/commands/stats-command.ts from 8s to 12s. The command flow was left unchanged; the launcher now simply gives the stats dashboard enough time to report readiness during slower cold starts, which matches the existing supported behavior exercised by launcher/main.test.ts. - -Verification passed with the targeted launcher command tests, the previously failing slow-start launcher/main.test.ts case, the full launcher/main.test.ts file, and the full `bun run test:fast` gate. - diff --git a/backlog/completed/task-181 - Add-background-managed-stats-server-lifecycle-commands.md b/backlog/completed/task-181 - Add-background-managed-stats-server-lifecycle-commands.md deleted file mode 100644 index db1e2fb5..00000000 --- a/backlog/completed/task-181 - Add-background-managed-stats-server-lifecycle-commands.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -id: TASK-181 -title: Add background-managed stats server lifecycle commands -status: Done -assignee: - - codex -created_date: '2026-03-17 15:31' -updated_date: '2026-03-18 05:28' -labels: - - cli - - launcher - - stats -milestone: m-1 -dependencies: [] -priority: medium -ordinal: 110500 ---- - -## Description - - -Add a dedicated background stats server mode that can be started and stopped from the launcher without blocking normal SubMiner instances. Launcher UX: `subminer stats -b` starts the stats server in the background, `subminer stats -s` stops the background stats server only, and plain `subminer stats` preserves the existing foreground/open-browser flow. - - -## Acceptance Criteria - -- [x] #1 `subminer stats -b` starts a background stats server without blocking other SubMiner instances. -- [x] #2 `subminer stats -s` stops only the background stats server and succeeds cleanly when state is stale. -- [x] #3 Plain `subminer stats` preserves current dashboard-open behavior. -- [x] #4 Automated tests cover launcher parsing/dispatch and app-side start-stop lifecycle behavior. - - -## Implementation Plan - - -1. Extend launcher stats parsing so `subminer stats -b` maps to background-start and `subminer stats -s` maps to stop-only while preserving existing cleanup/rebuild parsing. -2. Add launcher execution branches: detached background start with startup acknowledgement wait, stop command forwarding with response wait, and preserve existing attached foreground behavior for plain `stats` and cleanup flows. -3. Extend app CLI args and stats command handler for background start/stop lifecycle responses, including already-running and stale-state handling. -4. Add a dedicated stats-daemon runtime/state-file path in the app and bypass the normal single-instance lock only for that mode. -5. Verify with focused tests first, then launcher/env lane, and update task acceptance criteria/final summary before handoff. - - -## Implementation Notes - - -User approved option 2 design: dedicated app-side stats daemon, `subminer stats -b` to start, `subminer stats -s` to stop server only. - -Implemented launcher `stats -b` and `stats -s` flows plus app-side `--stats-background` / `--stats-stop` handling. - -Added background stats daemon state-file management and remote-daemon reuse so normal SubMiner instances do not try to bind a second stats server when the daemon is already running. - -Verification: `bun test launcher/main.test.ts launcher/commands/command-modules.test.ts launcher/parse-args.test.ts src/main/runtime/stats-cli-command.test.ts src/main/early-single-instance.test.ts`, `bun run typecheck`, `bun run test:env`, `bun run test:fast`, `bun run build`, `bun run test:smoke:dist`, `bun run docs:test`, `bun run docs:build`, `bun run changelog:lint`. - -Non-blocking note: `bun run test:launcher` still showed unrelated existing failures in `launcher/picker.test.ts` and an intermittent `launcher/smoke.e2e.test.ts` mpv-status check on this machine; the narrowed launcher suites covering the changed stats paths passed. - - -## Final Summary - - -Added a dedicated background stats-daemon lifecycle for the launcher and app runtime. `subminer stats -b` now starts or reuses a detached stats server and returns after startup acknowledgement, while `subminer stats -s` stops that daemon without touching browser tabs. On the app side, new stats background/stop CLI flags bypass the normal single-instance lock only for daemon helper processes, write/read a daemon state file under user data, and reuse an already-running daemon instead of attempting a second local stats bind when another SubMiner instance needs stats access. Updated docs-site stats docs, added a changelog fragment, and covered the new flows with launcher parse/dispatch tests, app stats CLI handler tests, and single-instance bypass tests. Verification run: `bun run typecheck`, `bun run test:env`, `bun run test:fast`, `bun run build`, `bun run test:smoke:dist`, `bun run docs:test`, `bun run docs:build`, `bun run changelog:lint`, plus narrowed changed-path launcher/app test bundles. - diff --git a/backlog/completed/task-182 - Fix-session-stats-chart-known-word-totals-exceeding-total-words.md b/backlog/completed/task-182 - Fix-session-stats-chart-known-word-totals-exceeding-total-words.md deleted file mode 100644 index 6c4aba21..00000000 --- a/backlog/completed/task-182 - Fix-session-stats-chart-known-word-totals-exceeding-total-words.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-182 -title: Fix session stats chart known-word totals exceeding total words -status: Done -milestone: m-1 -assignee: - - codex -created_date: '2026-03-17 16:07' -updated_date: '2026-03-18 05:28' -labels: [] -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/stats-server.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/sessions/SessionDetail.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/__tests__/stats-server.test.ts - - /Users/sudacode/projects/japanese/SubMiner/stats/src/hooks/useSessions.ts -ordinal: 109500 ---- - -## Description - - -Fix the session detail stats display so the known-word series cannot exceed the total-word series for the same sample. Ground the fix in the actual immersion-tracker metrics used by the stats UI and cover the regression with automated tests. - - -## Acceptance Criteria - -- [x] #1 Session detail data uses a consistent cumulative word metric so known-word counts do not exceed total words for a sample -- [x] #2 Automated tests cover the session known-word timeline contract and reproduce the regression scenario -- [x] #3 Session stats UI still renders the timeline and tooltip values correctly after the fix - - -## Implementation Plan - - -1. Add a regression test for `/api/stats/sessions/:id/known-words-timeline` covering a Japanese-style session where telemetry word counts can be lower than token-derived known-word counts. -2. Update the stats known-word timeline contract/server implementation so the series is expressed in the same cumulative unit used for total words in the session detail view. -3. Adjust the session detail UI/types to consume the corrected series and keep tooltip/legend copy coherent. -4. Run targeted tests for stats server and stats UI transforms, then summarize any wider verification skipped. - - -## Implementation Notes - - -Implemented server-side known-word timeline fix to preserve stored line positions and accumulate known-word occurrences rather than compressed unique-headword counts. - -Updated session-facing stats views to prefer `tokensSeen` over `wordsSeen` when available so displayed session word totals align with the session chart and lookup-rate denominator. - -Verification: `bun test src/core/services/__tests__/stats-server.test.ts`, `bun test stats/src/lib/yomitan-lookup.test.tsx`, `bun test src/core/services/immersion-tracker/__tests__/query.test.ts`, `bun run typecheck` all passed. - -Verification skipped/blocker: `bun run typecheck:stats` still fails in pre-existing unrelated files `stats/src/components/anime/AnilistSelector.tsx`, `stats/src/lib/reading-utils.test.ts`, and `stats/src/lib/reading-utils.ts`. - - -## Final Summary - - -Fixed the session stats mismatch that let known words outrun total words. The stats server now preserves actual subtitle-line positions and accumulates known-word occurrences for the session timeline, while session-facing stats views prefer token-based word totals when available. Added regression coverage for the known-word timeline API and for session-row word-count rendering, plus a user-visible changelog fragment. - diff --git a/backlog/completed/task-182.1 - Remove-misleading-session-new-word-metric-from-session-detail-chart.md b/backlog/completed/task-182.1 - Remove-misleading-session-new-word-metric-from-session-detail-chart.md deleted file mode 100644 index 73255c0c..00000000 --- a/backlog/completed/task-182.1 - Remove-misleading-session-new-word-metric-from-session-detail-chart.md +++ /dev/null @@ -1,64 +0,0 @@ ---- -id: TASK-182.1 -title: Remove misleading session new-word metric from session detail chart -status: Done -assignee: - - '@codex' -created_date: '2026-03-18 01:41' -updated_date: '2026-03-18 05:28' -labels: - - bug - - stats - - ui -milestone: m-1 -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/sessions/SessionDetail.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/sessions/SessionsTab.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/lib/media-session-list.test.tsx -parent_task_id: TASK-182 -ordinal: 101500 ---- - -## Description - - -Remove the misleading `New words` series from the session detail chart so the stats UI no longer presents a fabricated metric that mirrors total words. Keep the session chart focused on the real cumulative totals already backed by tracker data. - - -## Acceptance Criteria - -- [x] #1 Expanded session detail chart no longer renders or labels a `New words` metric in the graph, tooltip, or legend -- [x] #2 Session detail still renders total-word and known-word series correctly after the metric removal -- [x] #3 Automated frontend coverage prevents the `New words` label from reappearing in expanded session detail - - -## Implementation Plan - - -1. Add a focused stats frontend regression test that renders expanded session detail and asserts the misleading `New words` label is absent while `Total words` remains. -2. Remove the fabricated `New words` area series, tooltip mapping, legend chip, and now-unused left-axis chart plumbing from `stats/src/components/sessions/SessionDetail.tsx`. -3. Add a user-visible changelog fragment describing the session chart cleanup. -4. Run targeted frontend tests plus cheap verification and record any blockers. - - -## Implementation Notes - - -Added a focused server-render regression test for SessionDetail copy to ensure the misleading `New words` label stays removed. - -Removed the fabricated `New words` chart series and its legend/tooltip plumbing from the expanded session detail view. - -Verification: `bun test stats/src/lib/session-detail.test.tsx stats/src/lib/media-session-list.test.tsx` passed. `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core stats/src/components/sessions/SessionDetail.tsx stats/src/lib/session-detail.test.tsx changes/2026-03-18-remove-session-new-words-series.md` passed and wrote artifacts under `.tmp/skill-verification/subminer-verify-20260317-184440-1aMWkM`. - -Manual spot-check note: `bun test stats/src/lib/yomitan-lookup.test.tsx` is currently red on a pre-existing `AnimeOverviewStats` lookup-rate assertion unrelated to this session-detail change. - - -## Final Summary - - -Removed the misleading `New words` metric from expanded session charts. Session detail now shows only the real total-word and known-word lines, backed by existing tracker data, with regression coverage that prevents the `New words` label from reappearing. - diff --git a/backlog/completed/task-182.2 - Improve-session-detail-known-word-chart-scaling.md b/backlog/completed/task-182.2 - Improve-session-detail-known-word-chart-scaling.md deleted file mode 100644 index 9abc17cb..00000000 --- a/backlog/completed/task-182.2 - Improve-session-detail-known-word-chart-scaling.md +++ /dev/null @@ -1,67 +0,0 @@ ---- -id: TASK-182.2 -title: Improve session detail known-word chart scaling -status: Done -assignee: - - codex -created_date: '2026-03-19 20:31' -updated_date: '2026-03-23 03:22' -labels: - - bug - - stats - - ui -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/sessions/SessionDetail.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/lib/session-detail.test.tsx -parent_task_id: TASK-182 -ordinal: 128500 ---- - -## Description - - -Adjust the expanded session-detail known-word percentage chart so the vertical range reflects the session's actual percent range instead of always spanning 0-100. Keep the chart easier to read while preserving the percent-based tooltip/legend behavior already used in the stats UI. - - -## Acceptance Criteria - -- [x] #1 Expanded session detail scales the known/unknown percent chart to the session's observed percent range instead of hard-coding a 0-100 top bound -- [x] #2 The chart keeps a small headroom above the highest observed known-word percent so the line remains visually readable near the top edge -- [x] #3 Automated frontend coverage locks the new percent-domain behavior and preserves existing session-detail rendering - - -## Implementation Plan - - -1. Add a focused frontend regression test for the session-detail ratio chart domain calculation, covering a session whose known-word percentage stays in a narrow band below 100% and expecting a dynamic top bound with headroom. -2. Update `stats/src/components/sessions/SessionDetail.tsx` to compute a dynamic percent-axis domain and matching ticks for the ratio chart, keeping the lower bound at 0%, adding modest padding above the highest known percentage, rounding to clean tick steps, and capping at 100%. -3. Apply the computed percent-axis bounds consistently to the right-side Y axis and the session chart pause overlays so the visual framing stays aligned. -4. Run targeted frontend tests and the SubMiner verification helper on the touched files, then record results and any blockers in the task. - - -## Implementation Notes - - -Implemented dynamic known-percentage axis scaling in `stats/src/components/sessions/SessionDetail.tsx`: the ratio chart now keeps a 0% floor, uses the highest observed known percentage plus 5 points of headroom for the top bound, rounds that bound up to clean 10-point ticks, caps at 100%, and enables `allowDataOverflow` so the stacked area chart actually honors the tighter domain. - -Added frontend regression coverage in `stats/src/lib/session-detail.test.tsx` for the axis-max helper, covering both a narrow-band session and near-100% cap behavior. - -Added user-visible changelog fragment `changes/2026-03-19-session-detail-chart-scaling.md`. - -Verification: `bun test stats/src/lib/session-detail.test.tsx` passed; `bun run typecheck` passed; `bun run changelog:lint` passed; `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core stats/src/components/sessions/SessionDetail.tsx stats/src/lib/session-detail.test.tsx` ran and passed `typecheck` but failed `bun run test:fast` on a pre-existing unrelated issue in `scripts/update-aur-package.test.ts` / `scripts/update-aur-package.sh` (`mapfile: command not found`). Artifacts: `.tmp/skill-verification/subminer-verify-20260319-134440-JRHAUJ`. - -Docs decision: no internal docs update required; the behavior change is localized UI presentation with no API/workflow change. Changelog decision: yes, required and completed because the fix is user-visible. - - -## Final Summary - - -Improved expanded session-detail chart readability by replacing the fixed 0-100 known-word percentage axis with a dynamic top bound based on the session’s highest observed known percentage plus modest headroom, rounded to clean ticks and capped at 100%. The ratio chart now also enables `allowDataOverflow` so Recharts preserves the tighter percent domain even though the stacked known/unknown areas sum to 100%. - -Added frontend regression coverage for the new axis-max behavior and a changelog fragment for the user-visible stats fix. - -Verification: `bun test stats/src/lib/session-detail.test.tsx`, `bun run typecheck`, and `bun run changelog:lint` passed. The SubMiner verification helper’s `core` lane also passed `typecheck`, but `bun run test:fast` remains red on a pre-existing unrelated bash-compat failure in `scripts/update-aur-package.test.ts` / `scripts/update-aur-package.sh` (`mapfile: command not found`). - diff --git a/backlog/completed/task-183 - Fix-blank-stats-vocabulary-page-regression.md b/backlog/completed/task-183 - Fix-blank-stats-vocabulary-page-regression.md deleted file mode 100644 index d4a5285b..00000000 --- a/backlog/completed/task-183 - Fix-blank-stats-vocabulary-page-regression.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-183 -title: Fix blank stats vocabulary page regression -status: Done -milestone: m-1 -assignee: - - codex -created_date: '2026-03-17 16:23' -updated_date: '2026-03-18 05:28' -labels: [] -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/vocabulary/VocabularyTab.tsx - - /Users/sudacode/projects/japanese/SubMiner/stats/src/App.tsx - - /Users/sudacode/projects/japanese/SubMiner/stats/src/lib/api-client.ts -ordinal: 108500 ---- - -## Description - - -Diagnose and fix the stats dashboard regression where the Vocabulary tab renders blank at runtime. Capture the frontend failure with browser debugging, add regression coverage, and restore the vocabulary view. - - -## Acceptance Criteria - -- [x] #1 Vocabulary tab renders without a blank-screen failure in the stats dashboard -- [x] #2 Automated test coverage reproduces the failing code path and passes with the fix -- [x] #3 Targeted verification covers the affected stats UI/runtime path - - -## Implementation Plan - - -1. Reproduce the blank Vocabulary tab locally with a browser-visible stats UI instance and capture console/network failure details. -2. Add a focused regression test for the failing Vocabulary tab code path before editing production code. -3. Implement the minimal fix in the stats UI/runtime path. -4. Re-run targeted browser and automated verification, then record any skipped broader checks. - - -## Implementation Notes - - -Identified the runtime failure in the browser console: React reported a hook-order change in `VocabularyTab` after the tab moved from loading to loaded state (`Rendered more hooks than during the previous render`). - -Fixed `stats/src/components/vocabulary/VocabularyTab.tsx` by removing the late `useMemo` hook and computing `knownWordCount` as a plain derived value after the loading/error guards. - -Added regression coverage in `stats/src/lib/vocabulary-tab.test.ts` to assert that `VocabularyTab` declares all hooks before the loading/error early returns. - -Verification: `bun test stats/src/lib/vocabulary-tab.test.ts`, `bun test stats/src/lib/yomitan-lookup.test.tsx`, `bun run build:stats`, and a live Playwright check against the Vite app with stubbed stats API data all passed. - - -## Final Summary - - -Fixed the blank Vocabulary tab regression in the stats UI. The root cause was a late `useMemo` hook declared after the loading/error early returns in `VocabularyTab`, which caused React to crash once vocabulary data finished loading. Removed that late hook, added a regression test guarding hook placement, verified the stats bundle builds, and confirmed in a live browser that the Vocabulary tab now renders loaded content instead of white-screening. - diff --git a/backlog/completed/task-184 - Stabilize-branch-verification-gate.md b/backlog/completed/task-184 - Stabilize-branch-verification-gate.md deleted file mode 100644 index 89853867..00000000 --- a/backlog/completed/task-184 - Stabilize-branch-verification-gate.md +++ /dev/null @@ -1,57 +0,0 @@ ---- -id: TASK-184 -title: Stabilize branch verification gate -status: Done -assignee: - - Codex -created_date: '2026-03-17 19:28' -updated_date: '2026-03-18 05:28' -labels: - - stabilization - - ci -dependencies: [] -references: - - package.json - - docs/workflow/verification.md -priority: medium -ordinal: 106500 ---- - -## Description - - -Bring the current PR branch back to a green verification state by fixing any failing lint/format or test checks required for local handoff. - - -## Acceptance Criteria - -- [x] #1 Repo source formatting checks pass for the current branch. -- [x] #2 Required local verification checks for this branch pass without introducing new failures. -- [x] #3 Any code or test adjustments stay scoped to the failing checks and preserve existing branch behavior. - - -## Implementation Plan - - -1. Fix the current source-formatting failures reported by `bun run format:check:src` using the minimal repo-standard Prettier output. -2. Re-run `bun run format:check:src` to confirm the lint/format gate is green. -3. Re-run the default handoff gate from `docs/workflow/verification.md`: `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, and `bun run test:smoke:dist`. -4. Because `docs-site/` is modified on this branch, also run `bun run docs:test` and `bun run docs:build`. -5. If any verification step fails after formatting, fix only the blocking issue and re-run the relevant lane until green. - - -## Implementation Notes - - -Initial gate snapshot before edits: `typecheck`, `test:fast`, `test:env`, `build`, and `test:smoke:dist` passed; `format:check:src` failed on 15 files. - -Applied repo-standard Prettier formatting to the 15 files reported by `bun run format:check:src`; no additional logic changes were introduced in this stabilization pass. - -Verification after formatting: `bun run format:check:src` passed; `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core --lane runtime-compat --lane docs` passed with artifacts under `.tmp/skill-verification/subminer-verify-20260317-122947-hEInF0`; `bun run test:env` passed separately. - - -## Final Summary - - -Branch verification gate is green again. Fixed the only failing local gate by applying Prettier formatting to the 15 flagged source files, then re-ran the required verification lanes: source format check, core lane (`typecheck` + `test:fast`), runtime-compat lane (`build`, `test:runtime:compat`, `test:smoke:dist`), docs lane (`docs:test`, `docs:build`), and `test:env`. All passed. - diff --git a/backlog/completed/task-185 - Clarify-library-stats-word-count-labels.md b/backlog/completed/task-185 - Clarify-library-stats-word-count-labels.md deleted file mode 100644 index 90cc4516..00000000 --- a/backlog/completed/task-185 - Clarify-library-stats-word-count-labels.md +++ /dev/null @@ -1,67 +0,0 @@ ---- -id: TASK-185 -title: Clarify library stats word-count labels -status: Done -assignee: - - codex -created_date: '2026-03-17 22:58' -updated_date: '2026-03-18 05:28' -labels: - - bug - - stats - - ui -milestone: m-1 -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/library/MediaHeader.tsx - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/stats-server.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/query.ts -priority: medium -ordinal: 104500 ---- - -## Description - - -Fix the library/media detail stats header so occurrence-based subtitle counts are not presented as unique-word vocabulary totals. The UI should clearly distinguish subtitle word occurrences from unique known-word headword coverage to avoid misleading comparisons. - - -## Acceptance Criteria - -- [x] #1 Library/media detail view labels subtitle occurrence totals with wording that does not imply unique vocabulary counts -- [x] #2 Known-words summary in the same view explicitly communicates that its denominator is unique words/headwords -- [x] #3 Frontend tests cover the updated copy so the mismatch does not regress - - -## Implementation Plan - - -1. Add a focused stats frontend test for MediaHeader copy that distinguishes occurrence totals from unique known-word coverage. -2. Update MediaHeader labels so occurrence-based totals no longer imply unique vocabulary counts. -3. Update the known-words label copy to explicitly state it is based on unique words/headwords. -4. Run targeted stats tests and record results. - - -## Implementation Notes - - -Root cause confirmed: library header compares occurrence-based totalWordsSeen against unique-headword known-words summary. Awaiting plan approval before code changes. - -Updated library header copy to label totalWordsSeen as word occurrences and known-word coverage as known unique words. Added an optional initialKnownWordsSummary prop to support deterministic server-render tests without changing runtime behavior. - -Verification: `bun test stats/src/lib/yomitan-lookup.test.tsx` passes. `bun run typecheck:stats` remains blocked by preexisting unrelated errors in stats/src/components/anime/AnilistSelector.tsx, stats/src/lib/reading-utils.ts, stats/src/lib/reading-utils.test.ts, and stats/src/lib/vocabulary-tab.test.ts. - - -## Final Summary - - -Clarified the library/media header so occurrence-based subtitle counts are no longer presented as if they were unique vocabulary totals. The header now labels `totalWordsSeen` as `word occurrences`, and the known-words summary explicitly says `known unique words`, which matches the backend's DISTINCT headword calculation. - -For regression coverage, added a focused MediaHeader render test that exercises the exact mismatch case (30 occurrences vs 34 unique words) and verifies the new copy. Also updated one stale AnimeOverviewStats assertion in the same targeted test file so the focused stats test lane is green. - -Tests run: -- `bun test stats/src/lib/yomitan-lookup.test.tsx` ✅ -- `bun run typecheck:stats` ⚠️ blocked by preexisting unrelated errors in AnilistSelector and reading-utils/vocabulary-tab stats files. - diff --git a/backlog/completed/task-186 - Remove-stats-Library-tab-and-add-episode-detail-navigation-from-anime-page.md b/backlog/completed/task-186 - Remove-stats-Library-tab-and-add-episode-detail-navigation-from-anime-page.md deleted file mode 100644 index c3af978b..00000000 --- a/backlog/completed/task-186 - Remove-stats-Library-tab-and-add-episode-detail-navigation-from-anime-page.md +++ /dev/null @@ -1,77 +0,0 @@ ---- -id: TASK-186 -title: Remove stats Library tab and add episode detail navigation from anime page -status: Done -assignee: - - codex -created_date: '2026-03-17 23:19' -updated_date: '2026-03-18 05:28' -labels: - - stats - - ui -milestone: m-1 -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/stats/src/App.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/layout/TabBar.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/anime/AnimeDetailView.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/anime/EpisodeList.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/library/MediaDetailView.tsx -priority: medium -ordinal: 103500 ---- - -## Description - - -Update the stats UI so watched-file detail is no longer exposed as a top-level Library tab. Users should open dedicated episode detail pages from the anime detail page while preserving inline quick-peek session expansion. - - -## Acceptance Criteria - -- [x] #1 Stats navigation no longer shows a top-level Library tab. -- [x] #2 Anime episode rows keep inline quick-peek expansion and also expose an explicit control to open the dedicated episode detail page. -- [x] #3 Dedicated episode detail navigation lands on the existing watched-file detail view with a back action that returns to the originating anime detail page. -- [x] #4 Relevant stats component tests cover the new navigation flow and removed tab behavior. - - -## Implementation Plan - - -1. Add app-level stats navigation state for dedicated media detail so anime flows can open watched-file detail without a Library tab. -2. Remove the Library tab from the tab bar and top-level tab panels while preserving existing Overview/Anime/Trends/Vocabulary/Sessions behavior. -3. Update anime detail episode list to keep row expansion for quick peek and add an explicit button that opens the dedicated detail view for the selected episode. -4. Reuse MediaDetailView for episode detail and adjust its back action to return to the originating anime detail page. -5. Add or update stats component tests to cover the removed Library tab and the new anime-to-episode-detail navigation flow. -6. Run targeted stats tests, then targeted SubMiner verification lanes if needed for touched files. - - -## Implementation Notes - - -Implemented app-level stats navigation state for dedicated media detail and removed the Library tab from the tab bar and top-level panels. - -Anime episode rows now keep inline quick-peek expansion and expose a visible Details button that opens the dedicated watched-file detail view. - -Reused MediaDetailView for anime-origin episode navigation with a Back to Anime label and app-level return path. - -Verification: bun test stats/src/lib/stats-navigation.test.ts stats/src/lib/stats-ui-navigation.test.tsx; bun run build:stats; bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core ... => passed. - -Observed unrelated existing stats workspace issues outside this task when running bun run typecheck:stats, including AnilistSelector/reading-utils/vocabulary-tab and an outdated AnimeOverviewStats test signature. - -Reopened for bugfix: episode Details button is a no-op when anime detail is open from within AnimeTab because app-level selectedAnimeId is not retained there. Follow-up fix will pass animeId explicitly through the callback chain instead of depending on App route state. - -Bugfix: the Details button now passes animeId explicitly from AnimeTab/AnimeDetailView into app-level media-detail navigation, so dedicated episode navigation works even when the anime page was opened from within the tab rather than seeded by App state. - -Bugfix verification: bun test stats/src/lib/stats-navigation.test.ts stats/src/lib/stats-ui-navigation.test.tsx; bun run build:stats => passed. - - -## Final Summary - - -Removed the stats Library tab and replaced that navigation path with app-level dedicated media-detail routing from the anime page. Episode rows still support inline quick peek, and now also provide a Details button that opens the dedicated episode view and returns cleanly to the anime detail page. Added navigation-focused tests for the removed tab and anime-origin media-detail flow, and verified the change with targeted tests, stats bundle build, and the repo core verification lane. - diff --git a/backlog/completed/task-187 - Replace-episode-detail-session-history-with-expandable-inline-session-details.md b/backlog/completed/task-187 - Replace-episode-detail-session-history-with-expandable-inline-session-details.md deleted file mode 100644 index 33d20ca7..00000000 --- a/backlog/completed/task-187 - Replace-episode-detail-session-history-with-expandable-inline-session-details.md +++ /dev/null @@ -1,81 +0,0 @@ ---- -id: TASK-187 -title: Replace episode detail session history with expandable inline session details -status: Done -assignee: - - codex -created_date: '2026-03-17 23:42' -updated_date: '2026-03-18 05:28' -labels: - - stats - - ui -milestone: m-1 -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/library/MediaDetailView.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/library/MediaSessionList.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/sessions/SessionRow.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/sessions/SessionDetail.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/sessions/SessionsTab.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/overview/OverviewTab.tsx - - >- - /Users/sudacode/projects/japanese/SubMiner/stats/src/components/overview/RecentSessions.tsx -documentation: - - >- - /Users/sudacode/projects/japanese/SubMiner/docs/plans/2026-03-17-episode-detail-session-accordion-design.md - - >- - /Users/sudacode/projects/japanese/SubMiner/docs/plans/2026-03-17-episode-detail-session-accordion.md -priority: medium -ordinal: 102500 ---- - -## Description - - -Update the dedicated episode detail page so its session history uses the same expandable session-row behavior as the Sessions page, including inline timeline details and session deletion, instead of navigating away to the Sessions tab. Also update home-page session navigation so recent session links open the associated episode detail page rather than the Sessions tab. - - -## Acceptance Criteria - -- [x] #1 Dedicated episode detail session history uses expandable inline rows styled like the Sessions page instead of linking to the Sessions tab. -- [x] #2 Expanding a session on the episode detail page shows the full existing session detail panel, including the timeline chart and stats. -- [x] #3 Episode detail session rows retain a session delete control with the same behavior and safeguards as the Sessions page. -- [x] #4 Home-page recent session navigation opens the associated episode detail page when a session is tied to a video, instead of routing to the Sessions tab. -- [x] #5 Relevant stats tests cover the inline session expansion/delete behavior and the updated home-page navigation path. - - -## Implementation Plan - - -1. Add failing tests for media-detail session accordion structure and for overview-to-media-detail navigation, keeping orphan-session fallback coverage. -2. Rework MediaSessionList to reuse SessionRow and SessionDetail with local expansion state and delete affordance matching the Sessions page. -3. Move media-detail session mutation/delete ownership into MediaDetailView so deletes update the current episode page immediately. -4. Add app-level direct media-detail navigation from overview/home-page session rows when videoId exists; keep Sessions-tab fallback for sessions without videoId. -5. Run targeted tests, stats build, and the SubMiner core verification lane; then update TASK-187 with results. - - -## Implementation Notes - - -Added approved design/plan docs at docs/plans/2026-03-17-episode-detail-session-accordion-design.md and docs/plans/2026-03-17-episode-detail-session-accordion.md before implementation. - -MediaDetailView now owns local session state and delete handling, derives displayed media aggregates from the current session list, and renders MediaSessionList as an inline accordion instead of a session-page link list. - -MediaSessionList now reuses SessionRow and full SessionDetail so episode-level session history matches Sessions-page dropdown behavior and keeps the same delete affordance. - -Overview/home-page recent session navigation now prefers dedicated media detail when session.videoId exists and falls back to the Sessions tab only for orphan sessions without videoId. - -Verification passed: bun test stats/src/lib/stats-navigation.test.ts stats/src/lib/stats-ui-navigation.test.tsx stats/src/lib/media-session-list.test.tsx; bun run build:stats; bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core stats/src/App.tsx stats/src/components/overview/OverviewTab.tsx stats/src/components/overview/RecentSessions.tsx stats/src/components/library/MediaDetailView.tsx stats/src/components/library/MediaSessionList.tsx stats/src/lib/stats-navigation.ts stats/src/lib/stats-navigation.test.ts stats/src/lib/stats-ui-navigation.test.tsx stats/src/lib/media-session-list.test.tsx => passed. - - -## Final Summary - - -Dedicated episode detail pages now show inline expandable session rows using the same shared SessionRow + SessionDetail UI as the Sessions page, including per-session delete controls. Overview/home-page recent session clicks now open the episode detail page whenever a backing video exists, with Sessions-tab fallback only for sessions missing videoId. Added navigation and media-session-list tests plus design/implementation docs, and verified the change with targeted tests, stats bundle build, and the SubMiner core verification lane. - diff --git a/backlog/completed/task-187.1 - Auto-expand-targeted-session-when-opening-media-detail.md b/backlog/completed/task-187.1 - Auto-expand-targeted-session-when-opening-media-detail.md deleted file mode 100644 index 8a41c137..00000000 --- a/backlog/completed/task-187.1 - Auto-expand-targeted-session-when-opening-media-detail.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-187.1 -title: Auto-expand targeted session when opening media detail -status: Done -assignee: - - codex -created_date: '2026-03-18 01:32' -updated_date: '2026-03-18 05:28' -labels: - - stats - - ui -milestone: m-1 -dependencies: [] -references: - - stats/src/lib/stats-navigation.ts - - stats/src/App.tsx - - stats/src/components/overview/RecentSessions.tsx - - stats/src/components/library/MediaDetailView.tsx - - stats/src/components/library/MediaSessionList.tsx - - stats/src/lib/stats-navigation.test.ts -parent_task_id: TASK-187 -priority: medium -ordinal: 117500 ---- - -## Description - - -When a navigation path opens episode/media detail with a known session ID, the matching session row in media detail should auto-expand so the user lands directly on the intended session details instead of only the episode history page. - - -## Acceptance Criteria - -- [x] #1 Media detail navigation state can carry an optional target session ID alongside the selected video. -- [x] #2 Any navigation path that opens media detail with a known session ID causes that session row to auto-expand when the episode history loads. -- [x] #3 Session-tab fallback for orphan sessions without a video still behaves as it does now. -- [x] #4 Media detail auto-expansion clears or stabilizes its one-shot navigation state so normal manual expand/collapse behavior still works after landing. -- [x] #5 Relevant navigation/component tests cover the targeted media-detail auto-expand behavior. - - -## Implementation Plan - - -1. Extend media-detail navigation state to optionally carry a target session ID while preserving the existing orphan-session fallback to the Sessions tab. -2. Update app-level navigation helpers and overview recent-session click handling to pass session IDs into media-detail navigation whenever both video and session are known. -3. Thread the one-shot target session ID into MediaDetailView and MediaSessionList so the matching accordion row auto-expands on load, then clear/stabilize that state so manual toggling still behaves normally. -4. Update targeted stats navigation/component tests to cover media-detail auto-expansion and fallback behavior. - - -## Implementation Notes - - -Extended media-detail navigation state to carry an optional `initialSessionId`, updated overview/app navigation to pass session IDs into media detail whenever a video-backed session is clicked, and wired `MediaDetailView` + `MediaSessionList` to auto-expand and then consume that one-shot session target. - -Updated `stats-navigation.test.ts` to cover the new navigation-state shape. Validation not run in this pass, so acceptance criteria remain unchecked pending verification. - diff --git a/backlog/completed/task-188 - Refactor-stats-chart-data-pipeline-to-use-backend-aggregated-series.md b/backlog/completed/task-188 - Refactor-stats-chart-data-pipeline-to-use-backend-aggregated-series.md deleted file mode 100644 index cc85efeb..00000000 --- a/backlog/completed/task-188 - Refactor-stats-chart-data-pipeline-to-use-backend-aggregated-series.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -id: TASK-188 -title: Refactor stats chart data pipeline to use backend-aggregated series -status: Done -assignee: - - codex -created_date: '2026-03-18 00:29' -updated_date: '2026-03-23 03:22' -labels: - - stats - - performance - - refactor -milestone: m-1 -dependencies: [] -references: - - src/core/services/immersion-tracker/query.ts - - src/core/services/immersion-tracker-service.ts - - src/core/services/stats-server.ts - - stats/src/hooks/useTrends.ts - - stats/src/components/trends/TrendsTab.tsx - - stats/src/lib/api-client.ts - - stats/src/types/stats.ts - - stats/src/lib/dashboard-data.ts -priority: medium -ordinal: 138500 ---- - -## Description - - -Reduce long-term dashboard performance debt by moving chart aggregation out of the stats UI and into the tracker/stats API layer. The trends dashboard should consume chart-ready series from backend rollups instead of reconstructing multiple datasets from raw session lists in the browser. - - -## Acceptance Criteria - -- [x] #1 Stats API exposes chart-oriented aggregated trend data needed by the trends dashboard without requiring raw session lists for those charts. -- [x] #2 The trends dashboard consumes the new aggregated API responses and no longer rebuilds its main chart datasets from raw sessions in the render path. -- [x] #3 Time-range and grouping behavior remain correct for recent and all-time views, with explicit handling that keeps older history performant. -- [x] #4 Existing overview and anime detail charts continue to behave correctly, or are migrated to the shared aggregation path where it reduces debt. -- [x] #5 Tests cover backend aggregation/query behavior and frontend consumption of the new response shapes. -- [x] #6 Internal docs are updated to describe the new stats chart data flow and scaling rationale. - - -## Implementation Plan - - -1. Add a chart-oriented trends dashboard API response on the stats server that returns pre-aggregated series by range/grouping instead of requiring raw session lists in the UI. -2. Implement tracker/query-layer helpers that aggregate trend series on the backend, preferring rollups for scalable time-series data and centralizing chart shaping there. -3. Update stats client types and `useTrends` to consume the new response shape and stop fetching raw sessions for main chart construction. -4. Simplify `TrendsTab` and related chart components so they render backend-provided series with only lightweight UI-level filtering/state. -5. Keep overview/anime detail chart behavior intact, and reuse shared aggregation paths where it meaningfully reduces debt without widening scope. -6. Add/adjust backend and frontend tests plus internal docs to describe the new chart-data flow and performance rationale. - - -## Implementation Notes - - -Implemented a new `/api/stats/trends/dashboard` server route backed by tracker/query-layer aggregation, updated the stats client and `useTrends` to consume the new chart-ready payload, simplified `TrendsTab` to render backend-provided series, added route/query/api-client tests, and documented the new trends data flow in `docs/architecture/stats-trends-data-flow.md`. - -Did not run validation commands in this pass; acceptance criteria remain unchecked pending requested verification. - diff --git a/backlog/completed/task-189 - Replace-stats-word-counts-with-Yomitan-token-counts.md b/backlog/completed/task-189 - Replace-stats-word-counts-with-Yomitan-token-counts.md deleted file mode 100644 index 3d42d903..00000000 --- a/backlog/completed/task-189 - Replace-stats-word-counts-with-Yomitan-token-counts.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-189 -title: Replace stats word counts with Yomitan token counts -status: Done -assignee: - - codex -created_date: '2026-03-18 01:35' -updated_date: '2026-03-18 05:28' -labels: - - stats - - tokenizer - - bug -milestone: m-1 -dependencies: [] -references: - - src/core/services/immersion-tracker-service.ts - - src/core/services/immersion-tracker/reducer.ts - - src/core/services/immersion-tracker/storage.ts - - src/core/services/immersion-tracker/query.ts - - src/core/services/immersion-tracker/lifetime.ts - - stats/src/components - - stats/src/lib/yomitan-lookup.ts -priority: medium -ordinal: 100500 ---- - -## Description - - -Replace heuristic immersion stats word counting with Yomitan token counts. Session/media/anime stats should use the exact merged Yomitan token stream as the denominator and display metric, with no whitespace/CJK-character fallback and no active `wordsSeen` concept in the runtime, storage, API, or stats UI. - - -## Acceptance Criteria - -- [x] #1 `recordSubtitleLine` derives session count deltas from Yomitan token arrays instead of `calculateTextMetrics`. -- [x] #2 Active immersion tracking/storage/query code no longer depends on `wordsSeen` / `totalWordsSeen` fields for stats behavior. -- [x] #3 Stats UI labels and lookup-rate copy refer to tokens instead of words where those counts are shown to users. -- [x] #4 Regression tests cover token-count sourcing, zero-count behavior when tokenization payload is absent, and updated stats copy. -- [x] #5 A changelog fragment documents the user-visible stats denominator change. - - -## Implementation Plan - - -1. Add failing tracker tests proving subtitle count metrics come from Yomitan token arrays and stay zero when tokenization is absent. -2. Add failing stats UI tests for token-based copy and token-count display helpers. -3. Remove `wordsSeen` from active tracker/session/query/type paths and use `tokensSeen` as the single stats count field. -4. Update stats UI labels and lookup-rate copy from words to tokens. -5. Run targeted verification, then add the changelog fragment and any needed docs update. - - -## Outcome - - -Completed. Stats subtitle counts now come directly from Yomitan merged-token counts, `wordsSeen` is removed from the active tracker/storage/query/UI path, token-facing copy is updated, and focused regression coverage plus `bun run typecheck` are green. - diff --git a/backlog/completed/task-190 - Add-hover-popups-for-session-chart-events.md b/backlog/completed/task-190 - Add-hover-popups-for-session-chart-events.md deleted file mode 100644 index f5e33f36..00000000 --- a/backlog/completed/task-190 - Add-hover-popups-for-session-chart-events.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -id: TASK-190 -title: Add hover popups for session chart events -status: Done -assignee: - - Codex -created_date: '2026-03-17 22:20' -updated_date: '2026-03-18 05:28' -labels: - - stats - - ui - - bug -milestone: m-1 -dependencies: [] -references: - - stats/src/components/sessions/SessionDetail.tsx - - stats/src/lib/session-events.ts - - stats/src/hooks/useSessions.ts - - stats/src/lib/api-client.ts - - docs/plans/2026-03-17-session-event-hover-popups-design.md -priority: medium -ordinal: 105500 ---- - -## Description - - -Add hover/focus popups to session chart event markers so pauses, seeks, lookups, and card-mine events explain themselves inline. Card-mine events should lazy-load available Anki note info and present it in a richer popup with browse affordances. - - -## Acceptance Criteria - -- [x] #1 Hovering or focusing a session-chart marker opens an event-specific popup. -- [x] #2 Pause, seek, and lookup popups show concise event copy derived from marker metadata. -- [x] #3 Card-mine popups lazily fetch and cache Anki note info by note id. -- [x] #4 Card-mine popups show a formatted fallback when note info is missing or still loading. -- [x] #5 Regression tests cover event payload shaping and popup rendering behavior. - - -## Implementation Plan - - -1. Add failing tests for event metadata shaping and popup content selection. -2. Extend session-event shaping to parse payload JSON into typed marker metadata. -3. Add lazy note-info fetch/cache state for card-mine markers. -4. Render interactive marker overlay + custom popup in the session detail chart. -5. Run targeted stats/core verification and update this task with the result. - - -## Outcome - - -Completed. Session-chart event markers now open event-specific hover/focus popups, including lazy-loaded Anki note info for card-mine events with browse affordances. Verification passed via targeted stats tests, `bun run typecheck`, and the core verification lane in `.tmp/skill-verification/subminer-verify-20260317-222545-CQzyqK`. - diff --git a/backlog/completed/task-191 - Assess-PR-19-CodeRabbit-review-follow-ups.md b/backlog/completed/task-191 - Assess-PR-19-CodeRabbit-review-follow-ups.md deleted file mode 100644 index 494e1070..00000000 --- a/backlog/completed/task-191 - Assess-PR-19-CodeRabbit-review-follow-ups.md +++ /dev/null @@ -1,68 +0,0 @@ ---- -id: TASK-191 -title: 'Assess PR #19 CodeRabbit review follow-ups' -status: Done -assignee: - - codex -created_date: '2026-03-17 23:15' -updated_date: '2026-03-23 03:22' -labels: - - pr-review - - stats - - immersion-tracker -milestone: m-1 -dependencies: [] -references: - - src/core/services/immersion-tracker-service.ts - - src/core/services/immersion-tracker-service.test.ts -priority: medium -ordinal: 139500 ---- - -## Description - - -Validate the open CodeRabbit review comments on PR #19 against the current branch, implement only the confirmed fixes, and record which bot suggestions are stale or technically incomplete. - - -## Acceptance Criteria - -- [x] #1 Each open CodeRabbit PR #19 comment is validated against the current branch behavior -- [x] #2 Confirmed issues are fixed with regression coverage where it fits -- [x] #3 Non-actionable or partially-wrong bot guidance is documented explicitly - - -## Implementation Plan - - -1. Inspect the open CodeRabbit review threads on PR #19 and restate each finding in codebase terms. -2. Add failing regression tests for any verified bugs before changing production code. -3. Patch the smallest safe service-layer behavior, rerun focused verification, and record which suggestions were accepted versus rejected. - - -## Implementation Notes - - -Validated the two open CodeRabbit inline findings on PR #19 against the current branch. Both reported real bugs in `ImmersionTrackerService`, but the first suggestion's exact remediation was incomplete for this codebase. - -`reassignAnimeAnilist` did overwrite `imm_anime.description` with `NULL` when callers omitted `description`. Fixed with a presence-aware SQL update that preserves the existing description when the field is omitted while still allowing explicit `description: null` to clear the stored value. Rejected the bot's `COALESCE(?, description)` prompt because that would silently remove the explicit-clear behavior the API already supports. - -`ensureCoverArt` could return `true` after a fetcher reported success even when no cover-art row/blob was stored, because `undefined !== null` evaluated truthy through optional chaining. Fixed by loading the row into a local variable and requiring a non-null blob. - -Added regression coverage in `src/core/services/immersion-tracker-service.test.ts` for omitted-description preservation, explicit-null clearing, and the no-row `ensureCoverArt` false-positive case. - -Verification passed: -- `bun test src/core/services/immersion-tracker-service.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh src/core/services/immersion-tracker-service.ts src/core/services/immersion-tracker-service.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/core/services/immersion-tracker-service.ts src/core/services/immersion-tracker-service.test.ts` - -Verifier artifact directory: `.tmp/skill-verification/subminer-verify-20260317-231743-wHFNnN` - - -## Final Summary - - -Assessed the open PR #19 CodeRabbit comments and fixed the two confirmed service-layer regressions. `reassignAnimeAnilist` now preserves an existing anime description when callers omit the `description` field but still clears it on explicit `null`, and `ensureCoverArt` no longer reports success when no cover-art row/blob exists after a fetch attempt. - -Both comments were actionable, but one bot-proposed fix was not correct as written for this branch: replacing the description update with `COALESCE(?, description)` would have broken intentional description clearing. Added regression tests for the accepted behaviors and verified the change with the full touched service test file plus the SubMiner `core` verification lane. - diff --git a/backlog/completed/task-192 - Fix-stale-anime-cover-art-after-AniList-reassignment.md b/backlog/completed/task-192 - Fix-stale-anime-cover-art-after-AniList-reassignment.md deleted file mode 100644 index 3106c62d..00000000 --- a/backlog/completed/task-192 - Fix-stale-anime-cover-art-after-AniList-reassignment.md +++ /dev/null @@ -1,68 +0,0 @@ ---- -id: TASK-192 -title: Fix stale anime cover art after AniList reassignment -status: Done -assignee: - - codex -created_date: '2026-03-20 00:12' -updated_date: '2026-03-23 03:22' -labels: - - stats - - immersion-tracker - - anilist -milestone: m-1 -dependencies: [] -references: - - src/core/services/immersion-tracker-service.ts - - src/core/services/immersion-tracker/query.ts - - src/core/services/immersion-tracker-service.test.ts -priority: medium -ordinal: 127500 ---- - -## Description - - -Fix the stats anime-detail cover image path so reassigning an anime to a different AniList entry replaces the stored cover art bytes instead of keeping the previous image blob under updated metadata. - - -## Acceptance Criteria - -- [x] #1 Reassigning an anime to a different AniList entry stores the new cover art bytes for that anime's videos -- [x] #2 Shared blob deduplication still works when multiple videos in the anime use the same new cover image -- [x] #3 Focused regression coverage proves stale cover blobs are replaced on reassignment - - -## Implementation Plan - - -1. Add a failing regression test that reassigns an anime twice with different downloaded cover bytes and asserts the resolved cover updates. -2. Update cover-art upsert logic so new blob bytes generate a new shared hash instead of reusing an existing hash for the row. -3. Run the focused immersion tracker service test file and record the result. - - -## Implementation Notes - - -2026-03-20: Created during live debugging of a user-reported stale anime profile picture after changing the AniList entry from the stats UI. -2026-03-20: Root cause was in `upsertCoverArt(...)`. When a row already had `cover_blob_hash`, a later AniList reassignment with a freshly downloaded cover reused the existing hash instead of hashing the new bytes, so the blob store kept serving the old image while metadata changed. -2026-03-20: Added a regression in `src/core/services/immersion-tracker-service.test.ts` that reassigns the same anime twice with different fetched image bytes and asserts the resolved anime cover changes to the second blob while both videos still deduplicate to one shared hash. -2026-03-20: Fixed `src/core/services/immersion-tracker/query.ts` so incoming cover blob bytes compute a fresh hash before falling back to an existing row hash. Existing hashes are now reused only when no new bytes were fetched. -2026-03-20: Verification commands run: - - `bun test src/core/services/immersion-tracker-service.test.ts` - - `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker-service.test.ts` - - `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker-service.test.ts` -2026-03-20: Verification results: - - focused service test: passed - - verifier lane selection: `core` - - verifier result: passed (`bun run typecheck`, `bun run test:fast`) - - verifier artifacts: `.tmp/skill-verification/subminer-verify-20260320-001433-IZLFqs/` - - -## Final Summary - - -Fixed stale anime cover art after AniList reassignment by correcting cover-blob hash replacement in the immersion tracker storage layer. Reassignments now store the new fetched image bytes instead of reusing the previous blob hash from the row, while still deduplicating the updated image across videos in the same anime. - -Added focused regression coverage that reproduces the exact failure mode: same anime reassigned twice with different cover downloads, with the second image expected to replace the first. Verified with the touched service test file plus the SubMiner `core` verification lane. - diff --git a/backlog/completed/task-193 - Fix-session-chart-event-popup-position-drift.md b/backlog/completed/task-193 - Fix-session-chart-event-popup-position-drift.md deleted file mode 100644 index 9a8f71fd..00000000 --- a/backlog/completed/task-193 - Fix-session-chart-event-popup-position-drift.md +++ /dev/null @@ -1,62 +0,0 @@ ---- -id: TASK-193 -title: Fix session chart event popup position drift -status: Done -assignee: - - Codex -created_date: '2026-03-17 23:55' -updated_date: '2026-03-17 23:59' -labels: - - stats - - ui - - bug -milestone: m-1 -dependencies: [] -references: - - stats/src/components/sessions/SessionDetail.tsx - - stats/src/components/sessions/SessionEventOverlay.tsx - - stats/src/lib/session-events.ts -priority: medium -ordinal: 105600 ---- - -## Description - - - -Fix the session timeline event popup trigger positions so hover markers stay aligned with the underlying chart event lines across the full visible time range. - - - -## Acceptance Criteria - - - -- [x] #1 Event popup triggers stay horizontally aligned with chart event lines from session start through session end. -- [x] #2 Alignment logic uses the rendered chart plot area rather than guessed container percentages. -- [x] #3 Regression coverage locks the marker-position projection math. - - -## Implementation Plan - - - -1. Add a failing regression test for marker-position projection with chart offsets. -2. Capture the rendered plot box from Recharts and pass it into the overlay. -3. Position overlay markers in plot-area pixels, rerun targeted stats verification, then record the result. - - -## Outcome - - - -Completed. Session event hover markers now read the actual Recharts plot-area offset and width, then project marker X positions into plot-area pixels instead of full-container percentages. That keeps popup triggers aligned with the underlying reference lines across long session timelines. - -Verification: - -- `bun test stats/src/lib/session-events.test.ts stats/src/lib/session-detail.test.tsx stats/src/components/sessions/SessionEventPopover.test.tsx` -- `cd stats && bun run build` -- `bun x prettier --check 'stats/src/components/sessions/SessionDetail.tsx' 'stats/src/components/sessions/SessionEventOverlay.tsx' 'stats/src/lib/session-events.ts' 'stats/src/lib/session-events.test.ts' 'backlog/tasks/task-193 - Fix-session-chart-event-popup-position-drift.md'` -- `bun run typecheck:stats` still fails on pre-existing unrelated errors in `src/components/anime/AnilistSelector.tsx`, `src/components/library/LibraryTab.tsx`, `src/lib/reading-utils.test.ts`, `src/lib/reading-utils.ts`, `src/lib/vocabulary-tab.test.ts`, and `src/lib/yomitan-lookup.test.tsx` - - diff --git a/backlog/completed/task-194 - App-owned-YouTube-subtitle-picker-flow.md b/backlog/completed/task-194 - App-owned-YouTube-subtitle-picker-flow.md deleted file mode 100644 index ff6d0d9b..00000000 --- a/backlog/completed/task-194 - App-owned-YouTube-subtitle-picker-flow.md +++ /dev/null @@ -1,35 +0,0 @@ ---- -id: TASK-194 -title: App-owned YouTube subtitle picker flow -status: Done -assignee: [] -created_date: '2026-03-18 07:52' -updated_date: '2026-03-23 03:22' -labels: [] -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/launcher/youtube/orchestrator.ts - - /home/sudacode/projects/japanese/SubMiner/launcher/youtube/manual-subs.ts - - /home/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer.ts -documentation: - - /home/sudacode/projects/japanese/SubMiner/youtube.md -priority: medium -ordinal: 137500 ---- - -## Description - - -Replace the YouTube subtitle-generation-first flow with an app-owned picker flow that boots mpv paused, opens an overlay track picker, downloads selected subtitles into external subtitle files, and preserves generation as an explicit mode. Keep the existing SubMiner tokenization and annotation pipeline as the downstream consumer of downloaded subtitle files. - - -## Acceptance Criteria - -- [x] #1 Launcher and app expose YouTube subtitle acquisition modes `download` and `generate`, with `download` as the default. -- [x] #2 YouTube playback boots mpv paused and presents an overlay selection UI for primary and secondary subtitle choices. -- [x] #3 Selected YouTube subtitle tracks are downloaded to external subtitle files and loaded into mpv before playback resumes. -- [x] #4 `generate` mode preserves the existing subtitle generation path as an explicit opt-in behavior. -- [x] #5 Downloaded YouTube subtitle files integrate with the existing SubMiner subtitle/tokenization/annotation pipeline without regressing current overlay behavior. -- [x] #6 Tests cover mode selection, subtitle-track enumeration/selection flow, and the paused bootstrap plus app handoff path. -- [x] #7 User-facing config and launcher docs are updated to describe the new modes and default behavior. - diff --git a/backlog/completed/task-195 - Keep-final-card-mine-OSD-result-from-being-overwritten-by-progress-spinner.md b/backlog/completed/task-195 - Keep-final-card-mine-OSD-result-from-being-overwritten-by-progress-spinner.md deleted file mode 100644 index e7f6fcf2..00000000 --- a/backlog/completed/task-195 - Keep-final-card-mine-OSD-result-from-being-overwritten-by-progress-spinner.md +++ /dev/null @@ -1,64 +0,0 @@ ---- -id: TASK-195 -title: Keep final card-mine OSD result from being overwritten by progress spinner -status: Done -assignee: - - Codex -created_date: '2026-03-18 19:40' -updated_date: '2026-03-18 19:49' -labels: - - anki - - ui - - bug -milestone: m-1 -dependencies: [] -references: - - src/anki-integration/ui-feedback.ts - - src/anki-integration.ts - - src/anki-integration/card-creation.ts -priority: medium -ordinal: 105610 ---- - -## Description - - - -When a card mine finishes, the mpv OSD currently tries to show the final status text but the in-flight Anki progress spinner can immediately overwrite it on the next tick. Stop the spinner first, then show a single-line final result with a success/failure marker and the mined-word notification. - - - -## Acceptance Criteria - - - -- [x] #1 Successful mine/update OSD results render after the spinner is stopped and do not get overwritten by a later spinner tick. -- [x] #2 Failure results that replace the spinner show an `x` marker and stay visible on the same OSD line. -- [x] #3 Regression coverage locks the spinner teardown/result-notification ordering. - - -## Implementation Plan - - - -1. Add a focused failing regression test around the Anki UI-feedback spinner/result helper. -2. Add a helper that stops progress before emitting the final OSD result line with `✓`/`x`. -3. Route mine/update result notifications through that helper, then run targeted verification. - - -## Outcome - - - -Added a dedicated Anki UI-feedback result helper that force-clears the in-flight spinner state before emitting the final OSD result line. Successful card-update notifications now render as `✓ Updated card: ...`, and sentence-card creation failures now render as `x Sentence card failed: ...` without a later spinner tick reclaiming the line. - -Verification: - -- `bun test src/anki-integration/ui-feedback.test.ts` -- `bun test src/anki-integration/ui-feedback.test.ts src/anki-integration/note-update-workflow.test.ts src/anki-integration.test.ts src/core/services/mining.test.ts src/main/runtime/mining-actions.test.ts` -- `bun x prettier --check src/anki-integration/ui-feedback.ts src/anki-integration/ui-feedback.test.ts src/anki-integration.ts src/anki-integration/card-creation.ts "backlog/tasks/task-195 - Keep-final-card-mine-OSD-result-from-being-overwritten-by-progress-spinner.md" changes/2026-03-18-mine-osd-spinner-result.md` -- `bun run changelog:lint` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/anki-integration/ui-feedback.ts src/anki-integration/ui-feedback.test.ts src/anki-integration.ts src/anki-integration/card-creation.ts changes/2026-03-18-mine-osd-spinner-result.md` -- Verifier artifacts: `.tmp/skill-verification/subminer-verify-20260318-194614-uZMrAx/` - - diff --git a/backlog/completed/task-196 - Fix-subtitle-prefetch-cache-key-mismatch-and-active-cue-window.md b/backlog/completed/task-196 - Fix-subtitle-prefetch-cache-key-mismatch-and-active-cue-window.md deleted file mode 100644 index 19c60190..00000000 --- a/backlog/completed/task-196 - Fix-subtitle-prefetch-cache-key-mismatch-and-active-cue-window.md +++ /dev/null @@ -1,46 +0,0 @@ ---- -id: TASK-196 -title: Fix subtitle prefetch cache-key mismatch and active-cue window -status: Done -assignee: [] -created_date: '2026-03-18 16:05' -updated_date: '2026-03-23 03:22' -labels: [] -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/subtitle-processing-controller.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/subtitle-prefetch.ts -priority: high -ordinal: 136500 ---- - -## Description - - -Investigate and fix file-backed subtitle annotation latency where prefetch should warm upcoming lines but live playback still tokenizes each subtitle line. Likely causes: cache-key mismatch between parsed cue text and mpv `sub-text`, and priority-window selection skipping the currently active cue during mid-line starts/seeks. - - -## Acceptance Criteria - -- [x] #1 Prefetched subtitle entries are reused when live subtitle text differs only by normalization details such as ASS `\N`, newline collapsing, or surrounding whitespace. -- [x] #2 Priority-window selection includes the currently active cue when playback starts or seeks into the middle of a cue. -- [x] #3 Regression tests cover the cache-hit normalization path and active-cue priority-window behavior. -- [x] #4 Verification covers the touched prefetch/controller lane. - - -## Implementation Plan - - -1. Add failing regression tests in `subtitle-processing-controller.test.ts` and `subtitle-prefetch.test.ts`. -2. Normalize cache keys in the subtitle processing controller so prefetch/live paths share keys. -3. Adjust prefetch priority-window selection to include the active cue. -4. Run targeted tests, then SubMiner verification lane for touched files. - - -## Outcome - - -Normalized subtitle cache keys inside the processing controller so prefetched ASS/VTT/live subtitle text variants reuse the same cache entry, and changed priority-window selection to include the currently active cue based on cue end time. Added regression coverage for both paths and verified the change with the `core` lane. - diff --git a/backlog/completed/task-197 - Eliminate-per-line-plain-subtitle-flash-on-prefetch-cache-hit.md b/backlog/completed/task-197 - Eliminate-per-line-plain-subtitle-flash-on-prefetch-cache-hit.md deleted file mode 100644 index 51a1130a..00000000 --- a/backlog/completed/task-197 - Eliminate-per-line-plain-subtitle-flash-on-prefetch-cache-hit.md +++ /dev/null @@ -1,49 +0,0 @@ ---- -id: TASK-197 -title: Eliminate per-line plain subtitle flash on prefetch cache hit -status: Done -assignee: [] -created_date: '2026-03-18 16:28' -updated_date: '2026-03-23 03:22' -labels: [] -dependencies: - - TASK-196 -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/subtitle-processing-controller.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/mpv-main-event-actions.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/mpv-main-event-main-deps.ts -priority: high -ordinal: 135500 ---- - -## Description - - -Remove the remaining small per-line subtitle annotation delay after prefetch warmup by avoiding the unconditional plain-subtitle broadcast on mpv subtitle-change events when a cached annotated payload already exists. - - -## Acceptance Criteria - -- [x] #1 On a subtitle cache hit, the mpv subtitle-change path can emit annotated subtitle payload synchronously instead of first broadcasting `tokens: null`. -- [x] #2 Cache-miss behavior still preserves immediate plain-text subtitle display while async tokenization runs. -- [x] #3 Regression tests cover the controller cache-consume path and the mpv subtitle-change handler cache-hit branch. -- [x] #4 Verification covers the touched core/runtime lane. - - -## Implementation Plan - - -1. Add failing tests for controller cache consumption and mpv subtitle-change immediate annotated emission. -2. Add a controller method that consumes cached subtitle payload synchronously while updating internal latest/emitted state. -3. Wire the mpv subtitle-change handler to use the immediate cached payload when present, falling back to the existing plain-text path on misses. -4. Run focused tests and the cheapest sufficient verification lane. - - -## Outcome - - -Added `consumeCachedSubtitle` to the subtitle processing controller so cache hits can be claimed synchronously without reprocessing, then wired the mpv subtitle-change handler to emit cached annotated payloads immediately while preserving the existing plain-text fallback for misses. Verified with focused unit tests plus the `runtime-compat` lane. - diff --git a/backlog/completed/task-199 - Forward-launcher-log-level-into-mpv-plugin-script-opts.md b/backlog/completed/task-199 - Forward-launcher-log-level-into-mpv-plugin-script-opts.md deleted file mode 100644 index b42489be..00000000 --- a/backlog/completed/task-199 - Forward-launcher-log-level-into-mpv-plugin-script-opts.md +++ /dev/null @@ -1,46 +0,0 @@ ---- -id: TASK-199 -title: Forward launcher log level into mpv plugin script opts -status: Done -assignee: [] -created_date: '2026-03-18 21:16' -updated_date: '2026-03-23 03:22' -labels: [] -dependencies: - - TASK-198 -references: - - /home/sudacode/projects/japanese/SubMiner/launcher/aniskip-metadata.ts - - /home/sudacode/projects/japanese/SubMiner/launcher/mpv.ts - - /home/sudacode/projects/japanese/SubMiner/launcher/main.test.ts - - /home/sudacode/projects/japanese/SubMiner/launcher/aniskip-metadata.test.ts -priority: medium -ordinal: 134500 ---- - -## Description - - -Make `subminer --log-level=debug ...` reach the mpv plugin auto-start path by forwarding the launcher log level into `--script-opts`, so plugin-started overlay and texthooker subprocesses inherit debug logging. - - -## Acceptance Criteria - -- [x] #1 Launcher mpv playback includes `subminer-log_level=` in `--script-opts` when a non-info CLI log level is used. -- [x] #2 Detached idle mpv launch uses the same script-opt forwarding. -- [x] #3 Regression tests cover launcher script-opt forwarding. - - -## Implementation Plan - - -1. Add a failing launcher regression test that captures mpv argv and expects `subminer-log_level=debug` inside `--script-opts`. -2. Extend the shared script-opt builder to accept launcher log level and emit `subminer-log_level` for non-info runs. -3. Reuse that builder in both normal mpv playback and detached idle mpv launch. -4. Run focused launcher tests and launcher-plugin verification. - - -## Outcome - - -Forwarded launcher log level into mpv plugin script opts via the shared builder and reused that builder for idle mpv launch. `subminer --log-level=debug ...` now gives the plugin `opts.log_level=debug`, so auto-started overlay and texthooker subprocesses include `--log-level debug` and the tokenizer timing logs can actually appear in the app log. - diff --git a/backlog/completed/task-200 - Address-latest-PR-19-CodeRabbit-follow-ups.md b/backlog/completed/task-200 - Address-latest-PR-19-CodeRabbit-follow-ups.md deleted file mode 100644 index fa7dce9d..00000000 --- a/backlog/completed/task-200 - Address-latest-PR-19-CodeRabbit-follow-ups.md +++ /dev/null @@ -1,92 +0,0 @@ ---- -id: TASK-200 -title: 'Address latest PR #19 CodeRabbit follow-ups' -status: Done -assignee: - - '@codex' -created_date: '2026-03-19 07:18' -updated_date: '2026-03-23 03:22' -labels: - - pr-review - - anki-integration - - launcher -milestone: m-1 -dependencies: [] -references: - - launcher/mpv.test.ts - - src/anki-integration.ts - - src/anki-integration/card-creation.ts - - src/anki-integration/runtime.ts - - src/anki-integration/known-word-cache.ts -priority: medium -ordinal: 133500 ---- - -## Description - - -Validate the latest 2026-03-19 CodeRabbit review round on PR #19, implement only the confirmed fixes, and verify the touched launcher and Anki integration paths. - - -## Acceptance Criteria - -- [x] #1 Each latest-round PR #19 CodeRabbit inline comment is validated against the current branch and classified as actionable or not warranted -- [x] #2 Confirmed correctness issues in launcher and Anki integration code are fixed with focused regression coverage where practical -- [x] #3 Targeted verification runs for the touched areas and the task notes record what changed versus what was rejected - - -## Implementation Plan - - -1. Validate the five inline comments from the 2026-03-19 CodeRabbit PR #19 review against current launcher and Anki integration code. -2. Add or extend focused tests for any confirmed launcher env-sandbox, notification-state, AVIF lead-in propagation, or known-word-cache lifecycle/scope regressions. -3. Apply the smallest safe fixes in `launcher/mpv.test.ts`, `src/anki-integration.ts`, `src/anki-integration/card-creation.ts`, `src/anki-integration/runtime.ts`, and `src/anki-integration/known-word-cache.ts` as needed. -4. Run targeted unit tests plus the SubMiner verification helper on the touched files, then record which comments were accepted or rejected in task notes. - - -## Implementation Notes - - -Validated the five latest inline comments from CodeRabbit review `3973222927` on PR #19. - -Accepted fixes: -- Hardened the three `findAppBinary` launcher tests against host leakage by sandboxing `SUBMINER_APPIMAGE_PATH` / `SUBMINER_BINARY_PATH` and stubbing executable checks so `/opt` and PATH resolution are deterministic. -- `showNotification()` now marks OSD/both updates as failed when `errorSuffix` is present instead of always rendering a success marker. -- `applyRuntimeConfigPatch()` now avoids starting or stopping known-word cache lifecycle work while the runtime is stopped, while still clearing cached state when highlighting is disabled. -- Extracted shared known-word cache lifecycle helpers and switched the persisted cache identity to the same lifecycle config used by runtime restart detection, so changes to `fields.word`, per-deck field mappings, or refresh interval invalidate stale cache state correctly. - -Rejected fix: -- The `createSentenceCard()` AVIF lead-in comment was technically incomplete for this branch. There is no current caller that computes an `animatedLeadInSeconds` input for sentence-card creation, and the existing lead-in resolver depends on note media fields that do not exist before the new card's media is generated. - -Regression coverage added: -- `src/anki-integration.test.ts` partial-failure OSD result marker. -- `src/anki-integration/runtime.test.ts` stopped-runtime known-word lifecycle guards. -- `src/anki-integration/known-word-cache.test.ts` cache invalidation when `fields.word` or per-deck field mappings change. - -Verification: -- `bun test src/anki-integration/runtime.test.ts` -- `bun test src/anki-integration/known-word-cache.test.ts` -- `bun test src/anki-integration.test.ts --test-name-pattern 'marks partial update notifications as failures in OSD mode'` -- `bun test launcher/mpv.test.ts --test-name-pattern 'findAppBinary resolves ~/.local/bin/SubMiner.AppImage when it exists|findAppBinary resolves /opt/SubMiner/SubMiner.AppImage when ~/.local/bin candidate does not exist|findAppBinary finds subminer on PATH when AppImage candidates do not exist'` -- `bun test src/anki-integration.test.ts src/anki-integration/runtime.test.ts src/anki-integration/known-word-cache.test.ts launcher/mpv.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh launcher/mpv.test.ts src/anki-integration.ts src/anki-integration/runtime.ts src/anki-integration/known-word-cache.ts src/anki-integration/runtime.test.ts src/anki-integration/known-word-cache.test.ts src/anki-integration.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane launcher-plugin --lane core launcher/mpv.test.ts src/anki-integration.ts src/anki-integration/runtime.ts src/anki-integration/known-word-cache.ts src/anki-integration/runtime.test.ts src/anki-integration/known-word-cache.test.ts src/anki-integration.test.ts` - -Verifier result: -- `launcher-plugin` lane passed (`test:launcher:smoke:src`, `test:plugin:src`). -- `core/typecheck` passed. -- `core/test-fast` failed for an unrelated existing environment issue in `scripts/update-aur-package.test.ts`: `scripts/update-aur-package.sh: line 71: mapfile: command not found` under the local macOS Bash environment. -- Verifier artifacts: `.tmp/skill-verification/subminer-verify-20260319-002617-UgpKUy` - -Classification: actionable and fixed -> `launcher/mpv.test.ts` env leakage hardening, `src/anki-integration.ts` partial-failure OSD marker, `src/anki-integration/runtime.ts` started-guard for known-word lifecycle calls, `src/anki-integration/known-word-cache.ts` cache identity alignment with runtime lifecycle config. - -Classification: not warranted as written -> `src/anki-integration/card-creation.ts` lead-in threading comment. No current `createSentenceCard()` caller computes or owns an `animatedLeadInSeconds` value, and the existing lead-in helper derives from preexisting note media fields, so blindly adding an optional parameter would not fix a real branch behavior bug. - - -## Final Summary - - -Fixed four confirmed PR #19 latest-round CodeRabbit issues locally: deterministic launcher `findAppBinary` tests, correct partial-failure OSD result markers, started-state guards around known-word cache lifecycle restarts, and shared known-word cache identity logic so field-mapping changes invalidate stale cache state. Added focused regression coverage for each confirmed behavior. - -One comment was intentionally not applied: the `createSentenceCard()` AVIF lead-in suggestion does not match the current branch architecture because no caller computes that value today and the existing resolver requires preexisting note media fields. Verification is green for all touched targeted tests plus the launcher-plugin/core typecheck lanes; the only remaining red is an unrelated existing `test:fast` failure in `scripts/update-aur-package.test.ts` caused by `mapfile` being unavailable in the local Bash environment. - diff --git a/backlog/completed/task-201 - Suppress-repeated-macOS-overlay-loading-OSD-during-fullscreen-tracker-flaps.md b/backlog/completed/task-201 - Suppress-repeated-macOS-overlay-loading-OSD-during-fullscreen-tracker-flaps.md deleted file mode 100644 index 8700beec..00000000 --- a/backlog/completed/task-201 - Suppress-repeated-macOS-overlay-loading-OSD-during-fullscreen-tracker-flaps.md +++ /dev/null @@ -1,67 +0,0 @@ ---- -id: TASK-201 -title: Suppress repeated macOS overlay loading OSD during fullscreen tracker flaps -status: Done -assignee: - - '@codex' -created_date: '2026-03-19 18:47' -updated_date: '2026-03-23 03:22' -labels: - - bug - - macos - - overlay -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/overlay-visibility.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/overlay-visibility-runtime.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main/state.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/overlay-visibility.test.ts -priority: high -ordinal: 131500 ---- - -## Description - - -Reduce macOS fullscreen annoyance where the visible overlay briefly loses tracking and re-shows the `Overlay loading...` OSD even though the overlay runtime is already initialized and no new instance is launching. Keep the first startup/loading feedback, but suppress repeat loading notifications caused by subsequent tracker churn during fullscreen enter/leave or focus flaps. - - -## Acceptance Criteria - -- [x] #1 The first macOS visible-overlay load still shows the existing `Overlay loading...` OSD when tracker data is not yet ready. -- [x] #2 Repeated macOS tracker flaps after the overlay has already recovered do not immediately re-show `Overlay loading...` on every loss/recovery cycle. -- [x] #3 Focused regression tests cover the repeated tracker-loss/recovery path and preserve the initial-load notification behavior. -- [x] #4 The change does not alter overlay runtime bootstrap or single-instance behavior; only notification suppression behavior changes. - - -## Implementation Plan - - -1. Add focused failing regressions in `src/core/services/overlay-visibility.test.ts` that preserve the first macOS `Overlay loading...` OSD and suppress an immediate second OSD after tracker recovery/loss churn. -2. Extend the overlay-visibility state/runtime plumbing with a small macOS loading-OSD suppression state so tracker flap retries can be rate-limited without touching overlay bootstrap or single-instance logic. -3. Reset the suppression when the user explicitly hides the visible overlay so intentional hide/show retries can still surface first-load feedback. -4. Run focused verification for the touched overlay visibility/runtime tests and update the task with results. - - -## Implementation Notes - - -Added optional loading-OSD suppression hooks to `src/core/services/overlay-visibility.ts` so macOS can rate-limit repeated `Overlay loading...` notifications without changing overlay bootstrap behavior. - -Implemented service-local suppression state in `src/main/overlay-visibility-runtime.ts` with a 30s cooldown and explicit reset when the visible overlay is manually hidden, so fullscreen tracker flaps stay quiet but intentional hide/show retries can still show loading feedback. - -Added focused regressions in `src/core/services/overlay-visibility.test.ts` for `loss -> recover -> immediate loss` suppression and for manual hide resetting suppression. - -Verification: `bun test src/core/services/overlay-visibility.test.ts`; `bun test src/main/runtime/overlay-visibility-runtime-main-deps.test.ts src/main/runtime/overlay-visibility-runtime.test.ts`; `bun run typecheck`; `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane runtime-compat src/core/services/overlay-visibility.ts src/main/overlay-visibility-runtime.ts src/core/services/overlay-visibility.test.ts` -> passed. Real-runtime lane skipped: change is notification suppression logic and cheap/runtime-compat coverage was sufficient for this scoped behavior change; no live mpv/macOS fullscreen session was run in this turn. - -Docs update required: no. Changelog fragment required: yes; added `changes/2026-03-19-overlay-loading-osd-fullscreen-flaps.md`. - - -## Final Summary - - -Reduced repeated macOS `Overlay loading...` popups caused by fullscreen tracker flap churn without touching overlay bootstrap or single-instance behavior. `src/core/services/overlay-visibility.ts` now accepts optional suppression hooks around the loading OSD path, and `src/main/overlay-visibility-runtime.ts` uses service-local state to rate-limit that OSD for 30 seconds while resetting the suppression when the visible overlay is explicitly hidden. Added focused regressions in `src/core/services/overlay-visibility.test.ts` to preserve the first-load notification, suppress immediate repeat notifications after tracker recovery/loss churn, and keep manual hide/show retries able to surface the loading OSD again. Added changelog fragment `changes/2026-03-19-overlay-loading-osd-fullscreen-flaps.md`. Verification passed with targeted overlay tests, typecheck, and the `runtime-compat` verifier lane; live macOS/mpv fullscreen runtime validation was not run in this turn. - diff --git a/backlog/completed/task-202 - Use-ended-session-media-position-for-anime-episode-progress.md b/backlog/completed/task-202 - Use-ended-session-media-position-for-anime-episode-progress.md deleted file mode 100644 index f643c78f..00000000 --- a/backlog/completed/task-202 - Use-ended-session-media-position-for-anime-episode-progress.md +++ /dev/null @@ -1,70 +0,0 @@ ---- -id: TASK-202 -title: Use ended session media position for anime episode progress -status: Done -assignee: - - Codex -created_date: '2026-03-19 14:55' -updated_date: '2026-03-19 17:36' -labels: - - stats - - ui - - bug -milestone: m-1 -dependencies: [] -references: - - stats/src/components/anime/EpisodeList.tsx - - stats/src/types/stats.ts - - src/core/services/immersion-tracker/session.ts - - src/core/services/immersion-tracker/query.ts - - src/core/services/immersion-tracker/storage.ts -priority: medium -ordinal: 105720 ---- - -## Description - - - -The anime episode list currently computes the `Progress` column from cumulative `totalActiveMs / durationMs`, which can exceed the intended watch-position meaning after rewatches or repeated sessions. Persist the playback position at the time a session ends and drive episode progress from that stored stop position instead. - - - -## Acceptance Criteria - - - -- [x] #1 Session finalization persists the playback position reached when the session ended. -- [x] #2 Anime episode queries expose the most recent ended-session media position for each episode. -- [x] #3 Episode-list progress renders from ended media position instead of cumulative active watch time. -- [x] #4 Regression coverage locks storage/query/UI behavior for the new progress source. - - -## Implementation Plan - - - -1. Add failing regression coverage for persisted ended media position and episode progress rendering. -2. Add `ended_media_ms` to the immersion-session schema and persist `lastMediaMs` when ending a session. -3. Thread the new field through episode queries/types and render episode progress from `endedMediaMs / durationMs`. -4. Run targeted verification plus typecheck, then record the outcome. - - -## Outcome - - - -Added nullable `ended_media_ms` storage to immersion sessions, persisted `lastMediaMs` when sessions finalize, and exposed the most recent ended-session media position through anime episode queries/types. The anime episode list now renders `Progress` from `endedMediaMs / durationMs` instead of cumulative active watch time, so rewatches no longer inflate the displayed percentage. - -Verification: - -- `bun test src/core/services/immersion-tracker/storage-session.test.ts` -- `bun test src/core/services/immersion-tracker/__tests__/query.test.ts` -- `bun test stats/src/lib/yomitan-lookup.test.tsx stats/src/lib/stats-ui-navigation.test.tsx` -- `bun run typecheck` -- `bun run changelog:lint` -- `bun x prettier --check 'src/core/services/immersion-tracker/types.ts' 'src/core/services/immersion-tracker/storage.ts' 'src/core/services/immersion-tracker/session.ts' 'src/core/services/immersion-tracker/query.ts' 'src/core/services/immersion-tracker/storage-session.test.ts' 'src/core/services/immersion-tracker/__tests__/query.test.ts' 'stats/src/types/stats.ts' 'stats/src/components/anime/EpisodeList.tsx' 'stats/src/lib/yomitan-lookup.test.tsx' 'stats/src/lib/stats-ui-navigation.test.tsx' 'backlog/tasks/task-202 - Use-ended-session-media-position-for-anime-episode-progress.md' 'changes/2026-03-19-stats-ended-media-progress.md'` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core 'src/core/services/immersion-tracker/types.ts' 'src/core/services/immersion-tracker/storage.ts' 'src/core/services/immersion-tracker/session.ts' 'src/core/services/immersion-tracker/query.ts' 'src/core/services/immersion-tracker/storage-session.test.ts' 'src/core/services/immersion-tracker/__tests__/query.test.ts' 'stats/src/types/stats.ts' 'stats/src/components/anime/EpisodeList.tsx' 'stats/src/lib/yomitan-lookup.test.tsx' 'stats/src/lib/stats-ui-navigation.test.tsx' 'backlog/tasks/task-202 - Use-ended-session-media-position-for-anime-episode-progress.md' 'changes/2026-03-19-stats-ended-media-progress.md'` -- Verifier artifacts: `.tmp/skill-verification/subminer-verify-20260319-173511-AV7kUg/` - - diff --git a/backlog/completed/task-203 - Restore-known-and-JLPT-annotation-for-reading-mismatch-tokens.md b/backlog/completed/task-203 - Restore-known-and-JLPT-annotation-for-reading-mismatch-tokens.md deleted file mode 100644 index 11a79bd6..00000000 --- a/backlog/completed/task-203 - Restore-known-and-JLPT-annotation-for-reading-mismatch-tokens.md +++ /dev/null @@ -1,47 +0,0 @@ ---- -id: TASK-203 -title: Restore known and JLPT annotation for reading-mismatch subtitle tokens -status: Done -assignee: - - Codex -created_date: '2026-03-19 18:25' -updated_date: '2026-03-19 18:25' -labels: - - subtitle - - bug -dependencies: [] -references: - - src/core/services/tokenizer/annotation-stage.ts - - src/core/services/tokenizer/annotation-stage.test.ts -priority: medium -ordinal: 105721 ---- - -## Description - - - -Some subtitle tokens lose both known-word coloring and JLPT underline even though the popup resolves a valid dictionary term. Repro example: `大体` in `大体 僕だって困ってたんですよ！` can be known via kana-only Anki data (`だいたい`) while JLPT lookup should still resolve from the kanji surface/headword. - - - -## Acceptance Criteria - - - -- [x] #1 Subtitle annotation can mark a token known via its reading when the configured headword/surface lookup misses. -- [x] #2 JLPT eligibility no longer drops valid kanji terms just because their reading contains repeated kana patterns. -- [x] #3 Regression coverage locks the combined known + JLPT case for `大体`. - - -## Outcome - - - -Known-word annotation now falls back to the token reading after the configured headword/surface lookup misses, so kana-only known-card entries still light up matching subtitle tokens. JLPT eligibility now ignores repeated-kana noise checks on the reading when a real surface/headword is present, which preserves JLPT tagging for words like `大体`. - -Verification: - -- `bun test src/core/services/tokenizer/annotation-stage.test.ts` - - diff --git a/backlog/completed/task-204 - Make-known-word-cache-incremental-and-avoid-full-rebuilds.md b/backlog/completed/task-204 - Make-known-word-cache-incremental-and-avoid-full-rebuilds.md deleted file mode 100644 index 18e7da21..00000000 --- a/backlog/completed/task-204 - Make-known-word-cache-incremental-and-avoid-full-rebuilds.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-204 -title: Make known-word cache incremental and avoid full rebuilds -status: Done -assignee: - - Codex -created_date: '2026-03-19 19:05' -updated_date: '2026-03-19 19:12' -labels: - - anki - - cache - - performance -dependencies: [] -references: - - src/anki-integration/known-word-cache.ts - - src/anki-integration.ts - - src/config/resolve/anki-connect.ts - - src/config/definitions/defaults-integrations.ts -priority: high -ordinal: 105722 ---- - -## Description - - - -Replace the known-word cache rebuild behavior with incremental synchronization. Startup should load existing cache state without immediately pulling all tracked Anki notes. Config-timed sync should reconcile adds, deletes, and in-place field edits against cached per-note state. Mined cards should optionally append their extracted words immediately after mining, enabled by default. Full rebuild should remain available only through explicit doctor tooling. - - - -## Acceptance Criteria - - - -- [x] #1 Known-word cache startup no longer performs an automatic full rebuild. -- [x] #2 Config-timed sync incrementally reconciles note additions, deletions, and edited word fields for the tracked known-word deck scope. -- [x] #3 Newly mined cards update the known-word cache immediately when the new config flag is enabled, and skip that fast path when disabled. -- [x] #4 Persisted cache state remains usable by stats endpoints that read the `words` set from disk. -- [x] #5 Regression tests cover startup behavior, incremental sync diffs, and the new config flag. - - -## Outcome - - - -Known-word cache startup now loads persisted state and schedules sync based on refresh timing instead of wiping and rebuilding immediately. Persisted cache state now includes per-note word snapshots so timed refreshes can remove deleted notes, update edited notes, and keep the global `words` set stable for stats consumers. Added `ankiConnect.knownWords.addMinedWordsImmediately`, default `true`, so newly mined cards can update the cache immediately without waiting for the next timed sync. - -Verification: - -- `bun test src/anki-integration/known-word-cache.test.ts` -- `bun test src/config/resolve/anki-connect.test.ts src/config/config.test.ts` -- `bun test src/anki-integration.test.ts src/anki-integration/runtime.test.ts src/core/services/__tests__/stats-server.test.ts` -- `bun run test:config:src` -- `bun run typecheck` -- `bun run test:fast` -- `bun run test:env` -- `bun run build` -- `bun run test:smoke:dist` - - diff --git a/backlog/completed/task-204.1 - Restore-stale-only-startup-known-word-cache-refresh.md b/backlog/completed/task-204.1 - Restore-stale-only-startup-known-word-cache-refresh.md deleted file mode 100644 index 21ea2131..00000000 --- a/backlog/completed/task-204.1 - Restore-stale-only-startup-known-word-cache-refresh.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -id: TASK-204.1 -title: Restore stale-only startup known-word cache refresh -status: Done -assignee: - - '@Codex' -created_date: '2026-03-20 02:52' -updated_date: '2026-03-23 03:22' -labels: - - anki - - cache - - bug -dependencies: [] -references: - - src/anki-integration/known-word-cache.ts - - src/anki-integration/known-word-cache.test.ts - - docs/plans/2026-03-19-known-word-cache-incremental-sync-design.md -parent_task_id: TASK-204 -priority: high -ordinal: 124500 ---- - -## Description - - -Follow up on the incremental known-word cache change so startup still performs a refresh when the persisted cache is older than the configured refresh interval, while leaving fresh persisted state untouched. - - -## Acceptance Criteria - -- [x] #1 Startup refreshes known words immediately when persisted cache state is stale for the configured interval. -- [x] #2 Startup skips the immediate refresh when persisted cache state is still fresh. -- [x] #3 Regression tests cover both stale and fresh startup paths. - - -## Implementation Plan - - -1. Add focused known-word cache lifecycle tests that distinguish fresh startup state from stale startup state and verify the stale path currently fails. -2. Update startup scheduling in src/anki-integration/known-word-cache.ts so persisted cache still loads immediately, but startup only triggers an immediate refresh when the cache is stale for the configured interval or the cache scope/config changed. -3. Run focused known-word cache tests and targeted SubMiner verification for the touched cache/runtime lane, then update the task with results. - - -## Implementation Notes - - -Verified current lifecycle behavior: fresh persisted known-word cache already skips immediate startup refresh when the cache scope/config matches; stale persisted cache already refreshes immediately. Added regression coverage for both startup paths plus a proxy integration test showing addNote responses return without waiting for background enrichment. - - -## Final Summary - - -Added regression coverage for known-word cache startup behavior and proxy response timing. The cache tests now lock in the intended lifecycle: fresh persisted state stays load-only on startup, while stale persisted state refreshes immediately. Added a proxy integration test proving addNote responses return without waiting for background enrichment. Verification: targeted Bun tests passed (`bun test src/anki-connect.test.ts src/anki-integration/anki-connect-proxy.test.ts src/anki-integration/known-word-cache.test.ts src/anki-integration/note-update-workflow.test.ts src/anki-integration/runtime.test.ts`) and direct `bun run test:fast` passed. The `subminer-change-verification` helper repeatedly reported `bun run test:fast` as failed in its isolated lane despite the direct command passing, so that helper lane remains a flaky/blocking verification artifact rather than a reproduced code failure. - diff --git a/backlog/completed/task-205 - Address-PR-19-Claude-frontend-review-follow-ups.md b/backlog/completed/task-205 - Address-PR-19-Claude-frontend-review-follow-ups.md deleted file mode 100644 index 7e5c81d0..00000000 --- a/backlog/completed/task-205 - Address-PR-19-Claude-frontend-review-follow-ups.md +++ /dev/null @@ -1,63 +0,0 @@ ---- -id: TASK-205 -title: 'Address PR #19 Claude frontend review follow-ups' -status: Done -assignee: - - codex -created_date: '2026-03-20 02:41' -updated_date: '2026-03-23 03:22' -labels: [] -milestone: m-1 -dependencies: [] -references: - - stats/src/components/vocabulary/VocabularyTab.tsx - - stats/src/hooks/useSessions.ts - - stats/src/hooks/useTrends.ts -priority: medium -ordinal: 126500 ---- - -## Description - - -Assess Claude's latest PR #19 review, apply any valid frontend fixes from that review batch, and verify the stats dashboard behavior stays unchanged aside from the targeted performance and error-handling improvements. - - -## Acceptance Criteria - -- [x] #1 VocabularyTab avoids recomputing expensive known-word and summary aggregates on unrelated rerenders while preserving current displayed values. -- [x] #2 useSessions and useSessionDetail normalize rejected values into stable string errors without throwing from the catch handler. -- [x] #3 Targeted tests cover the addressed review items and pass locally. -- [x] #4 Any user-facing docs remain accurate after the changes. - - -## Implementation Plan - - -1. Add focused tests that fail on the current branch for the two valid Claude findings: render-time aggregate recomputation in VocabularyTab and unsafe non-Error rejection handling in useSessions/useSessionDetail. -2. Update VocabularyTab to memoize the expensive summary and known-word aggregate calculations off the existing filteredWords/kanji/knownWords inputs without changing rendered values. -3. Normalize hook error handling to convert unknown rejection values into stable strings, matching the existing useTrends pattern. -4. Run the targeted stats/frontend test lane, verify no docs changes are needed, and record results in task notes. - - -## Implementation Notes - - -Validated Claude's latest PR #19 review comment from 2026-03-20 and narrowed it to two valid frontend follow-ups: memoized VocabularyTab aggregates and non-Error-safe session hook error handling. - -Added focused regression tests in stats/src/lib/vocabulary-tab.test.ts and stats/src/hooks/useSessions.test.ts before patching the implementation. - -Verification: `cd stats && bun test src/lib/vocabulary-tab.test.ts src/hooks/useSessions.test.ts` passed; `bun run format:check:stats` passed. - -Project-native verifier (`.agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core ...`) passed root `bun run typecheck` and failed at `bun run test:fast` due an unrelated existing failure in `scripts/update-aur-package.test.ts` (`mapfile: command not found`). Artifact: `.tmp/skill-verification/subminer-verify-20260319-194525-vxVD9V`. - -No user-facing docs changes were needed because the fixes only affect render-time memoization and error normalization. - - -## Final Summary - - -Assessed Claude's latest PR #19 review and applied the two valid follow-ups. `stats/src/components/vocabulary/VocabularyTab.tsx` now memoizes `buildVocabularySummary(filteredWords, kanji)` and the known-word count so unrelated rerenders do not rescan the filtered vocabulary list. `stats/src/hooks/useSessions.ts` now exports a small `toErrorMessage` helper and uses it in both `useSessions` and `useSessionDetail`, preventing `.catch()` handlers from throwing when a promise rejects with a non-`Error` value. - -Added targeted regressions in `stats/src/lib/vocabulary-tab.test.ts` and `stats/src/hooks/useSessions.test.ts` to lock in the memoization shape and error normalization behavior. Verification passed for `cd stats && bun test src/lib/vocabulary-tab.test.ts src/hooks/useSessions.test.ts` and `bun run format:check:stats`. The repo-native verification wrapper for the classified `core` lane also passed root `bun run typecheck`, but `bun run test:fast` is currently blocked by an unrelated existing failure in `scripts/update-aur-package.test.ts` (`mapfile: command not found`); artifacts are recorded under `.tmp/skill-verification/subminer-verify-20260319-194525-vxVD9V`. - diff --git a/backlog/completed/task-206 - Assess-latest-PR-19-CodeRabbit-review-comments.md b/backlog/completed/task-206 - Assess-latest-PR-19-CodeRabbit-review-comments.md deleted file mode 100644 index 57923a42..00000000 --- a/backlog/completed/task-206 - Assess-latest-PR-19-CodeRabbit-review-comments.md +++ /dev/null @@ -1,81 +0,0 @@ ---- -id: TASK-206 -title: 'Assess latest PR #19 CodeRabbit review comments' -status: Done -assignee: - - '@codex' -created_date: '2026-03-20 02:51' -updated_date: '2026-03-23 03:22' -labels: - - pr-review - - launcher - - anki-integration - - docs -milestone: m-1 -dependencies: [] -references: - - launcher/commands/command-modules.test.ts - - launcher/commands/stats-command.ts - - launcher/config/cli-parser-builder.ts - - launcher/mpv.ts - - README.md - - src/anki-integration.ts - - src/anki-integration/known-word-cache.ts -priority: medium -ordinal: 125500 ---- - -## Description - - -Validate the latest 2026-03-20 CodeRabbit review round on PR #19 against the current branch, implement only the confirmed fixes, and record which bot suggestions are stale, incorrect, or incomplete. - - -## Acceptance Criteria - -- [x] #1 Each latest-round 2026-03-20 CodeRabbit inline comment on PR #19 is validated against current branch behavior and classified as actionable or not warranted -- [x] #2 Confirmed correctness issues in launcher, Anki integration, and docs are fixed with focused regression coverage where practical -- [x] #3 Targeted verification runs for the touched areas succeed or remaining unrelated failures are documented in task notes - - -## Implementation Plan - - -1. Pull the 2026-03-20 CodeRabbit review threads from PR #19 and validate each comment against the current branch, separating real issues from stale or incomplete bot guidance. -2. For each confirmed behavior bug, add or extend a focused failing test before changing production code; keep docs-only fixes scoped to the exact markdownlint/install issue. -3. Patch the smallest safe fixes in launcher, README, and Anki integration code, taking care not to overwrite unrelated local edits. -4. Run targeted tests and relevant SubMiner verification lanes for touched files, then record accepted versus rejected review comments in task notes and summary. - - -## Implementation Notes - - -Validated the 2026-03-20 CodeRabbit PR #19 round as eight actionable items: one launcher test-name mismatch, three launcher behavior/test fixes, two README markdown/install fixes, one dead-code cleanup in Anki integration, and one real known-word cache deck-scoping bug. - -Known-word cache review comment was correct in substance but needed a branch-specific fix: preserve deck->field scoping by querying per deck and carrying the allowed field list per note, rather than changing `notesInfo` shape. - -Verification passed for targeted tests plus verifier docs/launcher-plugin lanes. Core verifier failed on unrelated pre-existing typecheck worktree state in `src/anki-integration/anki-connect-proxy.test.ts` (`TS2349` at line 395, `releaseProcessing?.()`), which is outside this task's touched files. - - -## Final Summary - - -Assessed the latest 2026-03-20 CodeRabbit review round on PR #19 and applied all eight confirmed action items. Launcher behavior now surfaces non-zero stats-process exits after the startup handshake, rejects cleanup-only stats flags unless `cleanup` is selected, preserves empty quoted `mpv` args, and has updated regression coverage for each case. The known-word cache now preserves deck-specific field mappings during refresh by querying configured decks separately and extracting only the fields assigned to each deck; the unused `getPreferredWordValue` wrapper in `src/anki-integration.ts` was removed. - -Documentation/test hygiene fixes also landed: the README platform badge no longer has an empty link target, Linux AppImage install instructions create `~/.local/bin` before downloads, the stats-command timing test was renamed to match actual behavior, and `launcher/picker.test.ts` now restores `XDG_DATA_HOME` safely while forcing Linux-path expectations explicitly so the file passes on macOS hosts. - -Verification run: -- `bun test launcher/commands/command-modules.test.ts` -- `bun test launcher/parse-args.test.ts` -- `bun test launcher/mpv.test.ts` -- `bun test launcher/picker.test.ts` -- `bun test src/anki-integration/known-word-cache.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh README.md launcher/commands/command-modules.test.ts launcher/commands/stats-command.ts launcher/config/cli-parser-builder.ts launcher/mpv.test.ts launcher/mpv.ts launcher/parse-args.test.ts launcher/picker.test.ts src/anki-integration.ts src/anki-integration/known-word-cache.test.ts src/anki-integration/known-word-cache.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane docs --lane launcher-plugin --lane core README.md launcher/commands/command-modules.test.ts launcher/commands/stats-command.ts launcher/config/cli-parser-builder.ts launcher/mpv.test.ts launcher/mpv.ts launcher/parse-args.test.ts launcher/picker.test.ts src/anki-integration.ts src/anki-integration/known-word-cache.test.ts src/anki-integration/known-word-cache.ts` - -Verifier results: -- `docs` lane passed (`docs:test`, `docs:build`) -- `launcher-plugin` lane passed (`test:launcher:smoke:src`, `test:plugin:src`) -- `core/typecheck` failed on unrelated existing worktree changes in `src/anki-integration/anki-connect-proxy.test.ts(395,5)`: `TS2349 This expression is not callable. Type 'never' has no call signatures.` -- Verifier artifacts: `.tmp/skill-verification/subminer-verify-20260319-195752-RNLVgE` - diff --git a/backlog/completed/task-207 - Verify-PR-19-follow-up-typecheck-blocker-is-cleared.md b/backlog/completed/task-207 - Verify-PR-19-follow-up-typecheck-blocker-is-cleared.md deleted file mode 100644 index 604345c9..00000000 --- a/backlog/completed/task-207 - Verify-PR-19-follow-up-typecheck-blocker-is-cleared.md +++ /dev/null @@ -1,68 +0,0 @@ ---- -id: TASK-207 -title: 'Verify PR #19 follow-up typecheck blocker is cleared' -status: Done -assignee: - - '@codex' -created_date: '2026-03-20 03:03' -updated_date: '2026-03-23 03:22' -labels: - - pr-review - - anki-integration - - verification -milestone: m-1 -dependencies: [] -references: - - src/anki-integration/anki-connect-proxy.test.ts -priority: medium -ordinal: 123500 ---- - -## Description - - -Confirm the previously unrelated `anki-connect-proxy.test.ts` typecheck failure no longer blocks verification for the PR #19 CodeRabbit follow-up work, and only patch it if the failure still reproduces. - - -## Acceptance Criteria - -- [x] #1 Reproduce or clear the `src/anki-integration/anki-connect-proxy.test.ts` typecheck blocker with current workspace state -- [x] #2 If the blocker still exists, apply the smallest safe fix and verify it -- [x] #3 Document the verification result and any remaining unrelated blockers - - -## Implementation Plan - - -1. Re-run `bun run typecheck` and a focused proxy test against the current workspace to confirm whether the previous `anki-connect-proxy.test.ts` failure still reproduces. -2. If the failure reproduces, use the typecheck failure itself as the red test, patch the smallest type-safe fix in the test, and rerun focused verification. -3. Re-run the relevant verifier lane(s), then record whether the blocker is cleared or if any unrelated failures remain. - - -## Implementation Notes - - -Re-ran `bun run typecheck` against the current workspace and the prior `src/anki-integration/anki-connect-proxy.test.ts` blocker no longer reproduces. - -Focused verification passed for `bun test src/anki-integration/anki-connect-proxy.test.ts`. Core verifier now passes `typecheck` and reaches `test:fast`. - -Current remaining unrelated verifier failure is unchanged local environment behavior in `scripts/update-aur-package.test.ts`: `scripts/update-aur-package.sh: line 71: mapfile: command not found` under macOS Bash. Artifact: `.tmp/skill-verification/subminer-verify-20260319-200320-vy2YHa`. - - -## Final Summary - - -Verified the previously reported PR #19 follow-up typecheck blocker is cleared in the current workspace. `bun run typecheck` now passes, and the focused proxy regression file `src/anki-integration/anki-connect-proxy.test.ts` also passes, including the background-enrichment response timing test. - -Re-running the SubMiner core verifier confirms the blocker moved forward: `core/typecheck` passes, and the remaining `core/test-fast` failure is unrelated to the proxy test. The only red is the existing macOS Bash compatibility issue in `scripts/update-aur-package.test.ts`, where `scripts/update-aur-package.sh` uses `mapfile` and exits with `line 71: mapfile: command not found`. - -Verification run: -- `bun run typecheck` -- `bun test src/anki-integration/anki-connect-proxy.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/anki-integration/anki-connect-proxy.test.ts` - -Verifier result: -- `core/typecheck` passed -- `core/test-fast` failed only in `scripts/update-aur-package.test.ts` because local macOS Bash lacks `mapfile` -- Artifact: `.tmp/skill-verification/subminer-verify-20260319-200320-vy2YHa` - diff --git a/backlog/completed/task-208 - Assess-newest-PR-19-CodeRabbit-round-after-1227706.md b/backlog/completed/task-208 - Assess-newest-PR-19-CodeRabbit-round-after-1227706.md deleted file mode 100644 index 9ca5b96a..00000000 --- a/backlog/completed/task-208 - Assess-newest-PR-19-CodeRabbit-round-after-1227706.md +++ /dev/null @@ -1,73 +0,0 @@ ---- -id: TASK-208 -title: 'Assess newest PR #19 CodeRabbit round after 1227706' -status: Done -assignee: - - '@codex' -created_date: '2026-03-20 03:37' -updated_date: '2026-03-23 03:22' -labels: - - pr-review - - launcher - - anki-integration -milestone: m-1 -dependencies: [] -references: - - launcher/commands/stats-command.ts - - launcher/mpv.ts - - src/anki-integration.ts -priority: medium -ordinal: 122500 ---- - -## Description - - -Validate the newest 2026-03-20 03:23 CodeRabbit review round on PR #19 after commit `1227706`, implement only the confirmed fixes, and record any bot suggestions that are stale or technically incomplete. - - -## Acceptance Criteria - -- [x] #1 Each newest-round CodeRabbit inline comment posted after commit `1227706` is validated against current branch behavior and classified as actionable or not warranted -- [x] #2 Confirmed issues are fixed with focused regression coverage where practical -- [x] #3 Targeted verification runs for the touched areas succeed or remaining unrelated failures are documented - - -## Implementation Plan - - -1. Pull the three newest CodeRabbit inline threads posted after commit `1227706` and restate each finding against the current branch code. -2. For each confirmed behavior bug, add or extend a focused failing test before changing production code; reject any stale or incorrect bot suggestion with notes. -3. Patch the smallest safe fixes in `launcher/commands/stats-command.ts`, `launcher/mpv.ts`, and/or `src/anki-integration.ts` as warranted, without disturbing unrelated local edits. -4. Run targeted tests and the cheapest sufficient verifier lanes, then record accepted versus rejected comments in task notes and summary. - - -## Implementation Notes - - -Validated the newest 2026-03-20 03:23 CodeRabbit round as three comments: two actionable launcher issues and one non-warranted Anki suggestion. - -Accepted fixes: cancel the pending stats response poll when the attached app exits non-zero before startup response, and surface `spawnSync()` launch/stop errors in launcher mpv helpers instead of treating `result.status ?? 0` / ignored status as success. - -Rejected fix: the `src/anki-integration.ts` / card-creation suggestion would double count locally mined cards. Local sentence mining already records stats in `src/main/runtime/anki-actions.ts` when `mineSentenceCardCore` returns `true`; adding a second callback in card creation would increment tracker counts twice for the same card. - - -## Final Summary - - -Assessed the newest CodeRabbit PR #19 round after commit `1227706` and fixed the two confirmed launcher regressions. `runStatsCommand()` now gives the startup response waiter an abort signal and cancels the polling loop immediately when the attached app exits non-zero before startup response, covering both the normal stats startup race and the cleanup/startup race. `launchTexthookerOnly()` now fails non-zero when `spawnSync()` reports an execution error, and `stopOverlay()` logs a warning when the stop command cannot be spawned or exits non-zero instead of silently treating that path as success. - -One bot comment was intentionally rejected: recording mined-card stats inside the direct card-creation path would double count locally mined cards, because the successful local mining flow already records cards in `src/main/runtime/anki-actions.ts` after `mineSentenceCardCore()` returns `true`. - -Verification run: -- `bun test launcher/commands/command-modules.test.ts` -- `bun test launcher/mpv.test.ts` -- `bun run typecheck` -- `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh launcher/commands/stats-command.ts launcher/commands/command-modules.test.ts launcher/mpv.ts launcher/mpv.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane launcher-plugin launcher/commands/stats-command.ts launcher/commands/command-modules.test.ts launcher/mpv.ts launcher/mpv.test.ts` - -Verifier result: -- `launcher-plugin` lane passed (`test:launcher:smoke:src`, `test:plugin:src`) -- `typecheck` passed -- Verifier artifacts: `.tmp/skill-verification/subminer-verify-20260319-204639-dzUj16` - diff --git a/backlog/completed/task-209 - Exclude-grammar-tail-そうだ-from-subtitle-annotations.md b/backlog/completed/task-209 - Exclude-grammar-tail-そうだ-from-subtitle-annotations.md deleted file mode 100644 index 28372ad7..00000000 --- a/backlog/completed/task-209 - Exclude-grammar-tail-そうだ-from-subtitle-annotations.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-209 -title: Exclude grammar-tail そうだ from subtitle annotations -status: Done -assignee: - - codex -created_date: '2026-03-20 04:06' -updated_date: '2026-03-23 03:22' -labels: - - bug - - tokenizer -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer/annotation-stage.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer/annotation-stage.test.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer.test.ts -priority: high -ordinal: 120500 ---- - -## Description - - -Sentence-final grammar-tail `そうだ` tokens can still receive subtitle annotation styling, including frequency highlighting, when Yomitan returns a standalone `そうだ` token and MeCab enriches it as an auxiliary-stem/coupla pattern (`名詞|助動詞`, `助動詞語幹`). Keep the subtitle text visible, but treat this grammar tail like other grammar-only endings so it renders without annotation metadata. - - -## Acceptance Criteria - -- [x] #1 Sentence-final grammar-tail `そうだ` tokens enriched as auxiliary-stem/copula patterns do not receive frequency highlighting or other subtitle annotation metadata. -- [x] #2 The preceding lexical token in cases like `与えるそうだ` keeps its existing annotation behavior. -- [x] #3 Regression tests cover the annotation-stage exclusion and end-to-end subtitle tokenization for the `そうだ` grammar-tail case. - - -## Implementation Plan - - -1. Add focused regression coverage for the reported `与えるそうだ` case at both annotation-stage and tokenizeSubtitle levels. -2. Reproduce failure by modeling the MeCab-enriched grammar-tail shape (`名詞|助動詞`, `特殊`, `助動詞語幹`) that currently keeps frequency metadata. -3. Update subtitle-annotation exclusion logic to recognize auxiliary-stem/copula grammar tails via POS metadata plus normalized tail text, not a raw sentence-specific string match. -4. Re-run targeted tokenizer and annotation-stage tests, then record the verification commands and outcome in the task notes. - - -## Implementation Notes - - -Investigated reported `与えるそうだ` case. MeCab tags `そう` as `名詞,特殊,助動詞語幹` and `だ` as `助動詞`; after overlap enrichment the Yomitan token becomes `pos1=名詞|助動詞`, `pos2=特殊`, `pos3=助動詞語幹`, which currently escapes subtitle-annotation exclusion and can keep a frequency rank. - -Implemented a POS-shape subtitle-annotation exclusion for MeCab-enriched auxiliary-stem grammar tails. The new predicate keys off merged tokens whose POS tags stay within `名詞/助動詞/助詞` and whose POS3 includes `助動詞語幹`, which clears annotation metadata for `そうだ`-style tails without hard-coding the full subtitle text. - -Verification: `bun test src/core/services/tokenizer/annotation-stage.test.ts`, `bun test src/core/services/tokenizer.test.ts --test-name-pattern 'explanatory ending|interjection|single-kana merged tokens from frequency highlighting|auxiliary-stem そうだ grammar tails|composite function/content token from frequency highlighting|keeps frequency for content-led merged token with trailing colloquial suffixes'` - - -## Final Summary - - -Added regression coverage for `与えるそうだ` and updated subtitle annotation exclusion logic to drop annotation metadata for MeCab-enriched auxiliary-stem grammar tails. The fix is POS-driven rather than sentence-specific, so `そうだ`-style grammar endings stay visible/hoverable as plain text while neighboring lexical tokens keep their existing frequency/JLPT behavior. - diff --git a/backlog/completed/task-210 - Show-latest-session-position-in-anime-episode-progress.md b/backlog/completed/task-210 - Show-latest-session-position-in-anime-episode-progress.md deleted file mode 100644 index 43dfe306..00000000 --- a/backlog/completed/task-210 - Show-latest-session-position-in-anime-episode-progress.md +++ /dev/null @@ -1,63 +0,0 @@ ---- -id: TASK-210 -title: Show latest session position in anime episode progress -status: Done -assignee: - - '@Codex' -created_date: '2026-03-20 04:09' -updated_date: '2026-03-23 03:22' -labels: - - stats - - bug - - ui -milestone: m-1 -dependencies: [] -references: - - stats/src/components/anime/EpisodeList.tsx - - src/core/services/immersion-tracker/query.ts - - src/core/services/immersion-tracker/session.ts - - src/core/services/immersion-tracker-service.ts -ordinal: 121500 ---- - -## Description - - -Anime episode rows in stats can show watch time and lookups from the latest session while the Progress column stays blank because it only reads `ended_media_ms` from ended sessions. Update the progress source so a just-watched episode reflects the latest known session stop position without falling back to cumulative watch time. - - -## Acceptance Criteria - -- [x] #1 Anime episode progress uses the latest known session position for the episode, including the most recent active session when available. -- [x] #2 Ended-session progress remains correct and does not regress to cumulative watch time. -- [x] #3 Regression coverage locks query and/or UI behavior for active-session and ended-session episode progress. - - -## Implementation Plan - - -1. Add failing regression coverage for anime episode progress when the latest session is still active but has a known playback position. -2. Persist the latest playback position on the active `imm_sessions` row during playback so stats queries can read it before session finalization. -3. Update anime episode queries to use the newest known session position for progress while preserving ended-session behavior. -4. Run targeted verification for immersion tracker, stats query, and cheap repo checks; record results and task outcome. - - -## Implementation Notes - - -Root cause: stale active-session recovery rebuilt session state with `lastMediaMs = null`, so `finalizeSessionRecord` overwrote persisted progress checkpoints with `ended_media_ms = NULL` during startup reconciliation. - -Implemented telemetry-flush checkpointing to persist `lastMediaMs` onto the active `imm_sessions` row, preserved that checkpoint through stale-session reconciliation, and updated anime episode progress queries to read the latest known non-null session position across active or ended sessions. - -Verification: targeted regressions passed (`bun test src/core/services/immersion-tracker-service.test.ts --test-name-pattern 'flushTelemetry checkpoints latest playback position on the active session row|startup finalizes stale active sessions and applies lifetime summaries'`, `bun test src/core/services/immersion-tracker/__tests__/query.test.ts --test-name-pattern 'getAnimeEpisodes prefers the latest session media position when the latest session is still active|getAnimeEpisodes returns latest ended media position and aggregate metrics'`), broader tracker/query suite passed (`bun test src/core/services/immersion-tracker-service.test.ts src/core/services/immersion-tracker/__tests__/query.test.ts`), `bun run typecheck` passed via verifier, `bun run changelog:lint` passed. - -Verification blocker: `.agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core ...` reported `bun run test:fast` failure from pre-existing `scripts/update-aur-package.test.ts` (`mapfile: command not found` under bash), unrelated to this change set. - - -## Final Summary - - -Persist anime episode progress checkpoints before session finalization so stats can survive crashes/restarts and still show the latest known watch position. Telemetry flushes now checkpoint `lastMediaMs` onto the active `imm_sessions` row, stale-session recovery preserves that checkpoint when finalizing recovered sessions, and `getAnimeEpisodes` now reads the newest non-null session position whether it came from an active or ended session. - -Added regressions for active-session checkpoint persistence, stale-session recovery preserving `ended_media_ms`, and episode queries preferring the latest known session position. Verification passed for the targeted and broader immersion tracker/query suites, plus `bun run typecheck` and `bun run changelog:lint`. The verifier's `bun run test:fast` step still fails on the pre-existing `scripts/update-aur-package.test.ts` bash `mapfile` issue, which is outside this task's scope. - diff --git a/backlog/completed/task-211 - Recover-anime-episode-progress-from-subtitle-timing-when-checkpoints-are-missing.md b/backlog/completed/task-211 - Recover-anime-episode-progress-from-subtitle-timing-when-checkpoints-are-missing.md deleted file mode 100644 index a29119e7..00000000 --- a/backlog/completed/task-211 - Recover-anime-episode-progress-from-subtitle-timing-when-checkpoints-are-missing.md +++ /dev/null @@ -1,41 +0,0 @@ ---- -id: TASK-211 -title: >- - Recover anime episode progress from subtitle timing when checkpoints are - missing -status: Done -assignee: - - '@Codex' -created_date: '2026-03-20 10:15' -updated_date: '2026-03-23 03:22' -labels: - - stats - - bug -milestone: m-1 -dependencies: [] -references: - - src/core/services/immersion-tracker/query.ts - - src/core/services/immersion-tracker/__tests__/query.test.ts -ordinal: 119500 ---- - -## Description - - -Anime episode progress can still show `0%` for older sessions that have watch-time and subtitle timing but no persisted `ended_media_ms` checkpoint. Recover progress from the latest retained subtitle/event segment end so already-recorded sessions render a useful progress percentage. - - -## Acceptance Criteria - -- [x] #1 `getAnimeEpisodes` returns the latest known session position even when `ended_media_ms` is null but subtitle/event timing exists. -- [x] #2 Existing ended-session metrics and aggregation totals do not regress. -- [x] #3 Regression coverage locks the fallback behavior. - - -## Implementation Notes - - -Added a query-side fallback for anime episode progress: when the newest session for a video has no persisted `ended_media_ms`, `getAnimeEpisodes` now uses the latest retained subtitle-line or session-event `segment_end_ms` from that same session. This recovers useful progress for already-recorded sessions that have timing data but predate or missed checkpoint persistence. - -Verification: `bun test src/core/services/immersion-tracker/__tests__/query.test.ts` passed. `bun run typecheck` passed. - diff --git a/backlog/completed/task-212 - Fix-mac-texthooker-helper-startup-blocking-mpv-launch.md b/backlog/completed/task-212 - Fix-mac-texthooker-helper-startup-blocking-mpv-launch.md deleted file mode 100644 index cc05b459..00000000 --- a/backlog/completed/task-212 - Fix-mac-texthooker-helper-startup-blocking-mpv-launch.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-212 -title: Fix mac texthooker helper startup blocking mpv launch -status: Done -assignee: [] -created_date: '2026-03-20 08:27' -updated_date: '2026-03-23 03:22' -labels: - - bug - - macos - - startup -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/startup.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main.ts - - /Users/sudacode/projects/japanese/SubMiner/plugin/subminer/process.lua -priority: high -ordinal: 140500 ---- - -## Description - - -`subminer` mpv auto-start on mac can stall before the video is usable because the helper process launched with `--texthooker` still runs heavy app-ready startup. Recent logs show the helper loading the Yomitan Chromium extension, emitting `Permission 'contextMenus' is unknown` warnings, then hitting Chromium runtime errors before SubMiner signals readiness back to the mpv plugin. The texthooker helper should take the minimal startup path needed to serve texthooker traffic without loading overlay/window-only startup work that can crash or delay readiness. - - -## Acceptance Criteria - -- [x] #1 Launching SubMiner with `--texthooker` avoids heavy app-ready startup work that is not required for texthooker helper mode. -- [x] #2 A regression test covers texthooker helper startup so it fails if Yomitan extension loading is reintroduced on that path. -- [x] #3 The change preserves existing startup behavior for non-texthooker app launches. - - -## Implementation Notes - - -Follow-up: user confirmed the root issue is the plugin auto-start ordering. Adjust mpv plugin sequencing so `--start` launches before any separate `--texthooker` helper, then verify plugin regressions still pass. - - -## Final Summary - - -Fixed the mac mpv startup hang caused by the `--texthooker` helper taking the full app-ready path. `runAppReadyRuntime` now fast-paths texthooker-only mode through minimal startup (`reloadConfig` plus CLI handling) so it no longer loads Yomitan or first-run setup work before serving texthooker traffic. Added regression coverage in `src/core/services/app-ready.test.ts`, then verified with `bun test src/core/services/app-ready.test.ts src/core/services/startup.test.ts`, `bun test src/cli/args.test.ts src/main/early-single-instance.test.ts src/main/runtime/stats-cli-command.test.ts`, and `bun run typecheck`. - diff --git a/backlog/completed/task-213 - Show-character-dictionary-progress-during-paused-startup-waits.md b/backlog/completed/task-213 - Show-character-dictionary-progress-during-paused-startup-waits.md deleted file mode 100644 index f3f2782c..00000000 --- a/backlog/completed/task-213 - Show-character-dictionary-progress-during-paused-startup-waits.md +++ /dev/null @@ -1,43 +0,0 @@ ---- -id: TASK-213 -title: Show character dictionary progress during paused startup waits -status: Done -assignee: [] -created_date: '2026-03-20 08:59' -updated_date: '2026-03-23 03:22' -labels: - - bug - - ux - - dictionary - - startup -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/startup-osd-sequencer.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync-notifications.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main.ts -priority: medium -ordinal: 141500 ---- - -## Description - - -During startup on mpv auto-start, character dictionary regeneration/update can be active while playback remains paused. The current startup OSD sequencer buffers dictionary progress behind annotation-loading OSD, which leaves the user with no visible dictionary-specific progress while the pause is active. Adjust the startup OSD sequencing so dictionary progress can surface once tokenization is ready during the paused startup window, without regressing later ready/failure handling. - - -## Acceptance Criteria - -- [ ] #1 When tokenization is ready during startup, later character dictionary progress updates are shown on OSD even if annotation-loading state is still active. -- [ ] #2 Startup OSD completion/failure behavior for character dictionary sync remains coherent after the new progress ordering. -- [ ] #3 Regression coverage exercises the paused startup sequencing for dictionary progress. - - -## Implementation Notes - - -2026-03-20: Confirmed issue is broader than OSD-only. Paused-startup OSD fixes remain relevant, but current user report also points at a regression in non-blocking startup playback release (tracked in TASK-143). - -2026-03-20: OSD sequencing fix remains in local patch alongside TASK-143 regression fix. Covered by startup-osd-sequencer tests; pending installed-app/mpv validation before task finalization. - diff --git a/backlog/completed/task-214 - Jump-subtitle-sidebar-directly-to-resume-position-on-first-resolved-cue.md b/backlog/completed/task-214 - Jump-subtitle-sidebar-directly-to-resume-position-on-first-resolved-cue.md deleted file mode 100644 index 229efe58..00000000 --- a/backlog/completed/task-214 - Jump-subtitle-sidebar-directly-to-resume-position-on-first-resolved-cue.md +++ /dev/null @@ -1,40 +0,0 @@ ---- -id: TASK-214 -title: Jump subtitle sidebar directly to resume position on first resolved cue -status: Done -assignee: [] -created_date: '2026-03-21 11:15' -updated_date: '2026-03-23 03:22' -labels: - - bug - - ux - - overlay - - subtitles -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/modals/subtitle-sidebar.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/modals/subtitle-sidebar.test.ts -priority: medium -ordinal: 142500 ---- - -## Description - - -When playback starts from a resumed timestamp while the subtitle sidebar is open, the sidebar currently smooth-scrolls from the top of the cue list to the resumed cue. Change the first resolved active-cue positioning to jump immediately to the resume location while preserving smooth auto-follow for later playback-driven cue advances. - - -## Acceptance Criteria - -- [x] #1 The first active cue resolved after open/resume uses an instant jump instead of smooth-scrolling through the list. -- [x] #2 Normal subtitle-sidebar auto-follow remains smooth after the first active cue has been positioned. -- [x] #3 Regression coverage distinguishes the initial jump behavior from later smooth auto-follow updates. - - -## Implementation Notes - - -2026-03-21: Fixed by treating the first auto-scroll from `previousActiveCueIndex < 0` as `behavior: 'auto'` in the subtitle sidebar scroll helper. Added renderer regression coverage for initial jump plus later smooth follow. - diff --git a/backlog/completed/task-215 - Add-startup-auto-open-option-for-subtitle-sidebar.md b/backlog/completed/task-215 - Add-startup-auto-open-option-for-subtitle-sidebar.md deleted file mode 100644 index 904786f1..00000000 --- a/backlog/completed/task-215 - Add-startup-auto-open-option-for-subtitle-sidebar.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-215 -title: Add startup auto-open option for subtitle sidebar -status: Done -assignee: [] -created_date: '2026-03-21 11:35' -updated_date: '2026-03-23 03:22' -labels: - - feature - - ux - - overlay - - subtitles -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/types.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/config/definitions/defaults-subtitle.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/config/resolve/subtitle-domains.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/modals/subtitle-sidebar.ts - - /Users/sudacode/projects/japanese/SubMiner/src/renderer/renderer.ts -priority: medium -ordinal: 143500 ---- - -## Description - - -Add a subtitle sidebar config option that auto-opens the sidebar once during overlay startup. The option should default to `false`, only apply when the sidebar feature is enabled, and should not force the sidebar back open later in the same session after manual close or later visibility changes. - - -## Acceptance Criteria - -- [x] #1 `subtitleSidebar.autoOpen` is available in config with default `false`. -- [x] #2 When enabled, overlay startup opens the subtitle sidebar once after initial sidebar config/snapshot load. -- [x] #3 Regression coverage covers config resolution and startup-only auto-open behavior. - - -## Implementation Notes - - -2026-03-21: Added `subtitleSidebar.autoOpen` to types/defaults/config registry and resolver. Renderer bootstrap now calls a startup-only subtitle sidebar helper after the initial snapshot refresh. Modal regression coverage verifies startup auto-open requires both `enabled` and `autoOpen`. - diff --git a/backlog/completed/task-217 - Fix-embedded-overlay-passthrough-sync-between-subtitle-and-sidebar.md b/backlog/completed/task-217 - Fix-embedded-overlay-passthrough-sync-between-subtitle-and-sidebar.md deleted file mode 100644 index f9ab82ef..00000000 --- a/backlog/completed/task-217 - Fix-embedded-overlay-passthrough-sync-between-subtitle-and-sidebar.md +++ /dev/null @@ -1,70 +0,0 @@ ---- -id: TASK-217 -title: Fix embedded overlay passthrough sync between subtitle and sidebar -status: Done -assignee: - - codex -created_date: '2026-03-21 23:16' -updated_date: '2026-03-23 03:22' -labels: - - bug - - overlay - - macos -dependencies: [] -references: - - src/renderer/handlers/mouse.ts - - src/renderer/modals/subtitle-sidebar.ts - - src/renderer/renderer.ts -documentation: - - docs/workflow/verification.md -priority: high -ordinal: 118500 ---- - -## Description - - -On macOS, when both the subtitle overlay and embedded subtitle sidebar are visible, mouse passthrough to mpv can remain stale until the user hovers the sidebar. After closing the sidebar, passthrough can likewise remain stale until the user hovers the subtitle again. Fix the overlay input-state synchronization so passthrough reflects the current hover/open state immediately instead of relying on the last hover target. - - -## Acceptance Criteria - -- [x] #1 When the embedded subtitle sidebar is open and the pointer is not over subtitle or sidebar content, the overlay returns to mouse passthrough immediately without requiring a sidebar hover cycle. -- [x] #2 When transitioning between subtitle hover and sidebar hover states on macOS embedded sidebar mode, mouse ignore state stays in sync with the currently interactive region. -- [x] #3 Closing the embedded subtitle sidebar restores the correct passthrough state based on remaining subtitle hover/modal state without requiring an additional hover. -- [x] #4 Regression tests cover the passthrough synchronization behavior. - - -## Implementation Plan - - -1. Add a shared renderer-side passthrough sync helper that derives whether the overlay should ignore mouse events from subtitle hover, embedded sidebar visibility/hover, popup visibility, and modal state. -2. Replace direct embedded-sidebar passthrough toggles in subtitle hover/sidebar handlers with calls to the shared sync helper so state is recomputed on every transition. -3. Add regression tests for macOS embedded sidebar mode covering sidebar-open idle passthrough, subtitle-to-sidebar transitions, and sidebar-close restore behavior. -4. Run targeted renderer tests for mouse/sidebar passthrough coverage, then summarize any residual risk. - - -## Implementation Notes - - -Added shared renderer overlay mouse-ignore recompute so subtitle hover, embedded sidebar hover/open/close, and popup idle transitions all derive passthrough from current state instead of last hover target. - -Added regression coverage for embedded sidebar idle passthrough on subtitle leave and for sidebar-close recompute behavior. - -Verification: `bun run typecheck` passed; `bun test src/renderer/handlers/mouse.test.ts` passed; `bun test src/renderer/modals/subtitle-sidebar.test.ts` passed; core verification wrapper artifact at `.tmp/skill-verification/subminer-verify-20260321-162743-XhSBxw` hit an unrelated `bun run test:fast` failure in `scripts/update-aur-package.test.ts` because macOS system bash lacks `mapfile`. - - -## Final Summary - - -Fixed stale embedded-sidebar passthrough sync on macOS by introducing a shared renderer mouse-ignore recompute path and tracking sidebar-hover state separately from subtitle hover. Subtitle hover leave, sidebar hover enter/leave, sidebar open, and sidebar close now all recompute passthrough from the current overlay state instead of waiting for a later hover event to repair it. Added regression tests covering subtitle-leave passthrough while the embedded sidebar is open but idle, plus sidebar-close restore behavior based on remaining subtitle hover state. - -Tests run: -- `bun run typecheck` -- `bun test src/renderer/handlers/mouse.test.ts` -- `bun test src/renderer/modals/subtitle-sidebar.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh src/renderer/state.ts src/renderer/overlay-mouse-ignore.ts src/renderer/handlers/mouse.ts src/renderer/handlers/mouse.test.ts src/renderer/modals/subtitle-sidebar.ts src/renderer/modals/subtitle-sidebar.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/renderer/state.ts src/renderer/overlay-mouse-ignore.ts src/renderer/handlers/mouse.ts src/renderer/handlers/mouse.test.ts src/renderer/modals/subtitle-sidebar.ts src/renderer/modals/subtitle-sidebar.test.ts` (typecheck passed; `test:fast` blocked by unrelated `scripts/update-aur-package.test.ts` failure on macOS Bash 3.2 lacking `mapfile`) - -Risk: the classifier flagged this as a real-runtime candidate, so actual Electron/mpv macOS pointer behavior was not exercised in a live runtime during this turn. - diff --git a/backlog/completed/task-218 - Delete-zero-session-media-from-stats-library-and-trends.md b/backlog/completed/task-218 - Delete-zero-session-media-from-stats-library-and-trends.md deleted file mode 100644 index ee8fc40c..00000000 --- a/backlog/completed/task-218 - Delete-zero-session-media-from-stats-library-and-trends.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-218 -title: Delete zero-session media from stats library and trends -status: Done -assignee: - - codex -created_date: '2026-03-22 16:20' -updated_date: '2026-03-24 06:41' -labels: - - stats - - immersion-tracker -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/query.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/lifetime.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/maintenance.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/__tests__/query.test.ts -priority: medium -ordinal: 153500 ---- - -## Description - - -Deleting the last retained session for a video still left stale lifetime media rows and trend rollups behind, so the stats dashboard could continue showing ghost entries in Library and Trends after all sessions were gone. - - -## Acceptance Criteria - -- [x] #1 Deleting the final session for a video removes that media from Library queries and detail reads -- [x] #2 Deleting the final session for a video removes stale daily/monthly trend rollups for that media -- [x] #3 Regression coverage proves zero-session media disappears from affected stats surfaces after deletion - - -## Implementation Plan - - -1. Add a failing regression around deleting the only retained session for a video while preexisting lifetime and rollup rows exist. -2. Patch the deletion path to rebuild lifetime and rollup state from retained sessions inside the same transaction. -3. Run focused immersion-tracker tests plus the repo-native verifier core lane and record results. - - -## Implementation Notes - - -Added a query regression that seeds a finished session plus stale lifetime media/anime rows and daily/monthly rollups, deletes that only session, and asserts Library, Anime detail, and Trends all drop the media immediately. - -Refactored lifetime rebuild logic so it can run inside an existing delete transaction, then reused that helper from `deleteSession`, `deleteSessions`, and `deleteVideo`. - -Added a rollup rebuild helper that clears existing daily/monthly rollups and reconstructs them from retained telemetry inside the current transaction so deleted sessions cannot leave ghost trend points behind. - -Verification passed: -- `bun test src/core/services/immersion-tracker/__tests__/query.test.ts` -- `bun test src/core/services/immersion-tracker-service.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker/lifetime.ts src/core/services/immersion-tracker/maintenance.ts src/core/services/immersion-tracker/__tests__/query.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/core/services/immersion-tracker/query.ts src/core/services/immersion-tracker/lifetime.ts src/core/services/immersion-tracker/maintenance.ts src/core/services/immersion-tracker/__tests__/query.test.ts` - -Verifier artifact dir: `.tmp/skill-verification/subminer-verify-20260322-210718-n6sGL8` - - -## Final Summary - - -Delete paths now rebuild lifetime summaries and trend rollups after removing sessions, so when the last session for a video disappears the stats database also drops that media from Library, related detail reads, and chart data. Added a regression proving a video with only stale lifetime/rollup rows vanishes after its final session is deleted, and verified the change with focused immersion-tracker tests plus the SubMiner core verification lane. - diff --git a/backlog/completed/task-220 - Restore-YouTube-overlay-mpv-keybindings-after-picker-routing.md b/backlog/completed/task-220 - Restore-YouTube-overlay-mpv-keybindings-after-picker-routing.md deleted file mode 100644 index 099fcea3..00000000 --- a/backlog/completed/task-220 - Restore-YouTube-overlay-mpv-keybindings-after-picker-routing.md +++ /dev/null @@ -1,66 +0,0 @@ ---- -id: TASK-220 -title: Restore YouTube overlay mpv keybindings after picker routing -status: Done -assignee: - - codex -created_date: '2026-03-22 00:00' -updated_date: '2026-03-22 23:49' -labels: - - bug - - overlay - - youtube - - keyboard -dependencies: [] -references: - - src/renderer/handlers/keyboard.ts - - src/renderer/modals/youtube-track-picker.ts - - src/renderer/handlers/keyboard.test.ts - - src/renderer/modals/youtube-track-picker.test.ts -documentation: - - docs/workflow/verification.md -priority: high -ordinal: 118800 ---- - -## Description - - -Regression: after adding the YouTube subtitle picker modal path, visible-overlay keydown handling can stop before reaching the shared mpv keybinding dispatch path. Result: default overlay mpv bindings like `Space` pause/play and `q` quit stop working while the overlay owns focus during YouTube playback. - - -## Acceptance Criteria - -- [x] #1 Unhandled keys while the YouTube track picker state is active still fall through to the shared overlay mpv keybinding dispatcher. -- [x] #2 The YouTube picker continues to consume `Enter` and `Escape` for its own actions. -- [x] #3 Renderer regression tests cover both the picker modal key contract and the shared keyboard dispatch fallback. - - -## Implementation Plan - - -1. Add a failing renderer keyboard regression test covering YouTube picker state plus shared mpv keybinding fallback. -2. Update the global keyboard handler to return early only when the YouTube picker actually handles the key event. -3. Update the picker modal handler to return false for unhandled keys while preserving `Enter`/`Escape`. -4. Run the cheap renderer verification lane and record results. - - -## Implementation Notes - - -Fixed the regression by making the global renderer keyboard handler stop early for the YouTube picker only when the picker actually consumes the key. The picker modal now returns `false` for unrelated keys, so shared overlay mpv bindings like `Space` and `KeyQ` still dispatch while the visible overlay has focus. - -Added regression coverage in the keyboard handler suite for mpv keybinding fallback during YouTube picker state, plus a picker-modal contract test that keeps `Escape` handled but leaves unrelated keys unclaimed. - -Verification: -- `bun test src/renderer/handlers/keyboard.test.ts src/renderer/modals/youtube-track-picker.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh src/renderer/handlers/keyboard.ts src/renderer/handlers/keyboard.test.ts src/renderer/modals/youtube-track-picker.ts src/renderer/modals/youtube-track-picker.test.ts` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/renderer/handlers/keyboard.ts src/renderer/handlers/keyboard.test.ts src/renderer/modals/youtube-track-picker.ts src/renderer/modals/youtube-track-picker.test.ts` -- verifier artifact: `.tmp/skill-verification/subminer-verify-20260322-234831-b2m6nJ` - - -## Final Summary - - -Restored YouTube-session overlay mpv keybindings by removing an unconditional early return added to the renderer keyboard path for the YouTube subtitle picker modal. Unhandled keys now fall through to the shared mpv keybinding dispatcher, while handled picker keys (`Enter`, `Escape`) still stay local to the picker. Added renderer regression tests for both the keyboard fallback path and the picker modal key-consumption contract. - diff --git a/backlog/completed/task-221 - Assess-and-address-PR-31-latest-CodeRabbit-review.md b/backlog/completed/task-221 - Assess-and-address-PR-31-latest-CodeRabbit-review.md deleted file mode 100644 index dc030338..00000000 --- a/backlog/completed/task-221 - Assess-and-address-PR-31-latest-CodeRabbit-review.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-221 -title: 'Assess and address PR #31 latest CodeRabbit review' -status: Done -assignee: [] -created_date: '2026-03-23 07:53' -updated_date: '2026-03-24 06:41' -labels: - - pr-review - - coderabbit -dependencies: [] -references: - - >- - PR #31 feat: add app-owned YouTube subtitle flow with absPlayer-style - parsing -priority: medium -ordinal: 152500 ---- - -## Description - - -Inspect the latest CodeRabbit review on PR #31, evaluate each actionable comment against the current branch, implement valid fixes, verify the changes, and prepare PR thread updates. - - -## Implementation Plan - - -1. Inspect latest CodeRabbit review on PR #31 and separate valid action items from non-blocking suggestions. -2. Add regression coverage for any real bugs before changing production code. -3. Implement the minimal fixes for confirmed issues in runtime, renderer modal flow, and test fixtures. -4. Run targeted tests plus repo-native verification lanes. -5. Update PR threads with fix status and rationale for any comments not actioned yet. - - -## Implementation Notes - - -Implemented and pushed commit 207151db to PR #31. - -Replied in-thread to the CodeRabbit comments for YouTube host matching, duplicate picker submissions, and missing MediaDetailView test fixture videoId fields. - -Follow-up scope added: update release-facing docs/changelog for the YouTube subtitle picker work and run a release-readiness gate before handoff. - -Added release-facing docs/changelog updates in commit b7e0026d and pushed them to PR #31. - -Ran the release-readiness gate: changelog:lint, changelog:pr-check, verify:config-example, typecheck, test:fast, test:env, build, test:smoke:dist, docs:test, docs:build. - - -## Final Summary - - -Assessed the latest CodeRabbit review on PR #31 and applied the confirmed fixes. Tightened `isYoutubeMediaPath()` to match only exact YouTube hosts or subdomains with a regression test for `notyoutube.com`, added an in-flight guard plus temporary control disabling to the YouTube track picker with a duplicate-submit regression test, replaced the picker empty-state `innerHTML` fallback with explicit DOM construction, and added the missing `videoId` fields to the `MediaDetailView` test fixtures. Verified with targeted Bun tests and the `runtime-compat` verification lane (`build`, `test:runtime:compat`, `test:smoke:dist`). - -Updated `README.md`, `docs-site/usage.md`, and `changes/2026-03-23-immersion-youtube.md` so the PR is release-facing and user-visible surfaces describe the YouTube subtitle picker flow plus its latest hardening. - -Release-readiness checks passed locally: `bun run changelog:lint`, `bun run changelog:pr-check`, `bun run verify:config-example`, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, `bun run test:smoke:dist`, `bun run docs:test`, and `bun run docs:build`. - diff --git a/backlog/completed/task-222 - Fix-YouTube-overlay-keybindings-in-subtitle-path.md b/backlog/completed/task-222 - Fix-YouTube-overlay-keybindings-in-subtitle-path.md deleted file mode 100644 index 027a0700..00000000 --- a/backlog/completed/task-222 - Fix-YouTube-overlay-keybindings-in-subtitle-path.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-222 -title: Fix YouTube overlay keybindings in subtitle path -status: Done -assignee: - - codex -created_date: '2026-03-23 08:32' -updated_date: '2026-03-24 06:41' -labels: - - bug -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime - - /Users/sudacode/projects/japanese/SubMiner/src/core/services -priority: high -ordinal: 151500 ---- - -## Description - - -Users watching video through the YouTube subtitle path cannot use some overlay keyboard controls such as quit and pause/play. Restore expected overlay keybinding behavior for that playback path without regressing other overlay input handling. - - -## Acceptance Criteria - -- [x] #1 Overlay quit and pause/play keybindings work while using the YouTube subtitle path. -- [x] #2 Existing overlay keybinding behavior for non-YouTube playback remains unchanged. -- [x] #3 Regression coverage exercises the YouTube subtitle path keyboard handling. - - -## Implementation Plan - - -1. Add a regression test around YouTube track-picker close to verify it requests main-process main-window focus restoration before returning overlay focus locally. -2. Update the YouTube track-picker close flow to call `window.electronAPI.focusMainWindow()` alongside the existing `window.focus()` and `overlay.focus()` restoration. -3. Run targeted tests for the picker/keyboard paths to verify YouTube playback regains overlay keybindings without regressing existing overlay behavior. - - -## Implementation Notes - - -Investigated overlay input path. Renderer already maps Space/KeyQ to mpv commands, but YouTube track-picker close only restores DOM focus (`window.focus` + `overlay.focus`) and does not invoke main-process window focus recovery, unlike the keyboard-mode focus reclaim path. Suspected root cause: overlay BrowserWindow focus is not restored after the YouTube picker closes, so playback keybindings stop reaching renderer keydown handlers. - -User approved implementation plan on 2026-03-23. Proceeding with TDD: add failing regression first, then minimal fix, then targeted verification. - -Implemented fix in the YouTube track-picker close path: request main-process `focusMainWindow()` before restoring renderer window/overlay focus so overlay keydown handlers regain input after YouTube subtitle selection. - -Verification: `bun test src/renderer/modals/youtube-track-picker.test.ts` and `bun test src/renderer/handlers/keyboard.test.ts` both pass. - - -## Final Summary - - -Restored overlay keyboard focus after closing the YouTube subtitle picker by invoking the main-process `focusMainWindow()` recovery path before local window/overlay focus restoration. Added regression coverage to the YouTube picker modal test and verified existing keyboard handler coverage for YouTube picker passthrough keys (`Space`, `KeyQ`) remains green. - diff --git a/backlog/completed/task-223 - Fix-YouTube-overlay-Anki-initialization-regression.md b/backlog/completed/task-223 - Fix-YouTube-overlay-Anki-initialization-regression.md deleted file mode 100644 index 650edd40..00000000 --- a/backlog/completed/task-223 - Fix-YouTube-overlay-Anki-initialization-regression.md +++ /dev/null @@ -1,109 +0,0 @@ ---- -id: TASK-223 -title: Fix YouTube overlay Anki initialization regression -status: Done -assignee: - - codex -created_date: '2026-03-23 08:41' -updated_date: '2026-03-24 06:41' -labels: - - bug - - youtube - - anki -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/main.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/overlay-runtime-init.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/cli-command-runtime-handler.ts -documentation: - - /Users/sudacode/projects/japanese/SubMiner/docs/workflow/verification.md -priority: high -ordinal: 154500 ---- - -## Description - - -Restore Anki-backed lookup and known-word behavior during YouTube playback. Recent startup changes appear to let the YouTube flow initialize the overlay before runtime prerequisites exist, leaving the Anki integration unavailable for popup Mine actions and known-word highlighting. - - -## Acceptance Criteria - -- [x] #1 YouTube playback initializes Anki integration once overlay startup prerequisites are available so lookup can offer card-add actions again -- [x] #2 Known-word / N+1 state is available during YouTube playback when the user has Anki-backed known-word highlighting enabled -- [x] #3 Regression coverage fails before the fix and passes after it for the YouTube startup path - - -## Implementation Plan - - -1. Add a regression test covering the YouTube playback command path and assert overlay startup prerequisites are established before the flow runs. -2. Reuse the overlay startup prerequisite bootstrap for the YouTube playback path so Anki integration sees subtitle tracker, mpv client, and runtime options manager before initialization. -3. Verify with focused runtime/CLI tests, then run the cheapest sufficient verification lane for the touched files. - - -## Implementation Notes - - -Identified regression path in CLI command runtime: YouTube playback commands could reach overlay initialization without first materializing overlay startup prerequisites, leaving Anki integration unavailable during the initial startup attempt. - -Added a regression test at src/main/runtime/cli-command-runtime-handler.test.ts covering youtubePlay command dispatch outside texthooker-only mode. - -Verified with bun test src/main/runtime/cli-command-runtime-handler.test.ts src/main/runtime/cli-command-prechecks.test.ts src/main/runtime/cli-command-prechecks-main-deps.test.ts and bun test src/core/services/cli-command.test.ts src/main/runtime/cli-command-context-main-deps.test.ts src/main/runtime/cli-command-prechecks-main-deps.test.ts src/main/runtime/cli-command-runtime-handler.test.ts. - -Removed the YouTube-only ensureOverlayRuntimeReady path from src/main.ts after confirming regular app startup already loads Yomitan and the shared CLI overlay pre-dispatch bootstrap now covers overlay prerequisites. - -Moved overlay bootstrap into the generic initial-args startup path for any initial command that needs overlay runtime, so overlay prerequisites and overlay initialization happen before CLI dispatch instead of inside a YouTube-only or last-moment command path. - -Additional verification passed: bun test src/main/runtime/initial-args-runtime-handler.test.ts src/main/runtime/initial-args-handler.test.ts src/main/runtime/initial-args-main-deps.test.ts, bun run typecheck, bun run test:runtime:compat - -Follow-up regression: subtitle picker was still auto-submitting the default selection during YouTube startup. Investigating renderer-side immediate Enter key bleed-through on picker open. - -Root cause for remaining picker regression: the YouTube track picker accepted Enter immediately on open, so the launch keypress could auto-submit the default track selection before the modal was visible to the user. - -Added renderer regression coverage in src/renderer/modals/youtube-track-picker.test.ts proving immediate Enter after open is ignored and a later Enter still submits normally. - -Implemented a 200ms open-key guard in src/renderer/modals/youtube-track-picker.ts for Enter-based submission only; Escape/click behavior unchanged. - -New follow-up regression report: YouTube subtitle picker can open before the mpv playback window is ready, leaving the picker behind the overlay after geometry snaps into place. Investigating picker-open gating and modal-targeting timing. - -Identified likely cause of picker-behind-overlay regression: YouTube picker open logic mixed overlay targets. First attempt preferred the visible main overlay, timeout retry switched to the dedicated modal window, allowing a late first open to cover the modal. - -Extracted picker-open policy into src/main/runtime/youtube-picker-open.ts and changed YouTube picker startup to always target the dedicated modal window, including retries. This keeps the picker on a single window path and lets overlay-runtime hide/click-through the main overlay while the modal is active. - -Added regression tests in src/main/runtime/youtube-picker-open.test.ts covering dedicated modal first-open, dedicated-modal retry, and failure when no modal target is available. - -User reports overlay flow still feels wrong: YouTube path appears to preload subtitles before mandatory selection and may open the picker before mpv window readiness. Re-evaluating flow design against regular video startup before further implementation. - -New follow-up regression report: duplicate overlay windows appear during YouTube playback and only one window shows subtitles. Investigating main-overlay versus dedicated modal-window handoff/cleanup. - - -## Final Summary - - -Fixed the YouTube Anki initialization regression by making CLI commands that require overlay runtime bootstrap overlay startup prerequisites before command dispatch when not in texthooker-only mode. This ensures the YouTube playback flow has the mpv client, runtime options manager, and subtitle timing tracker ready before overlay/Anki initialization runs, restoring Mine actions and known-word-backed behavior. - -Added a regression test covering youtubePlay command dispatch in src/main/runtime/cli-command-runtime-handler.test.ts. - -Verification: -- bun test src/main/runtime/cli-command-runtime-handler.test.ts src/main/runtime/cli-command-prechecks.test.ts src/main/runtime/cli-command-prechecks-main-deps.test.ts -- bun test src/core/services/cli-command.test.ts src/main/runtime/cli-command-context-main-deps.test.ts src/main/runtime/cli-command-prechecks-main-deps.test.ts src/main/runtime/cli-command-runtime-handler.test.ts - -Updated the fix to avoid a YouTube-specific startup path: removed the dedicated ensureOverlayRuntimeReady helper from src/main.ts and relied on the shared CLI overlay prerequisite bootstrap instead. - -Additional verification: bun run typecheck - -Follow-up adjustment: initial overlay-runtime commands now bootstrap overlay prerequisites and initialize overlay during the shared initial-args startup path, rather than waiting for command dispatch. This keeps YouTube on the regular startup path while preserving earlier overlay availability. - -Additional verification: bun test src/main/runtime/initial-args-runtime-handler.test.ts src/main/runtime/initial-args-handler.test.ts src/main/runtime/initial-args-main-deps.test.ts; bun run test:runtime:compat - -Follow-up fix: the YouTube subtitle picker now ignores immediate Enter key bleed-through right after opening, preventing the startup keypress from auto-submitting the default track selection before the modal is visible. - -Added renderer regression coverage for immediate Enter suppression and verified with bun test src/renderer/modals/youtube-track-picker.test.ts plus the runtime-compat verification lane for the touched files. - -Follow-up fix: YouTube subtitle picker startup now uses a dedicated modal-window path consistently instead of mixing main-overlay first-open with modal-window retry. That prevents late overlay opens from covering the interactive picker while mpv/window tracking settles. - -Verified with bun test src/main/runtime/youtube-picker-open.test.ts, bun test src/renderer/modals/youtube-track-picker.test.ts, and the runtime-compat verification lane for src/main.ts plus the touched picker files. - diff --git a/backlog/completed/task-224 - Auto-load-default-YouTube-subtitles-at-playback-start-and-make-picker-manual-only.md b/backlog/completed/task-224 - Auto-load-default-YouTube-subtitles-at-playback-start-and-make-picker-manual-only.md deleted file mode 100644 index 4eba01b6..00000000 --- a/backlog/completed/task-224 - Auto-load-default-YouTube-subtitles-at-playback-start-and-make-picker-manual-only.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -id: TASK-224 -title: >- - Auto-load default YouTube subtitles at playback start and make picker - manual-only -status: Done -assignee: - - Codex -created_date: '2026-03-23 18:51' -updated_date: '2026-03-24 06:41' -labels: - - youtube - - mpv - - overlay - - keybindings -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/youtube-flow.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/modals/youtube-track-picker.ts - - /Users/sudacode/projects/japanese/SubMiner/src/config/definitions/shared.ts -priority: high -ordinal: 150500 ---- - -## Description - - -Replace the mandatory YouTube subtitle picker startup flow with automatic default-track loading. On YouTube playback start, attempt to load the default primary subtitle and best-effort secondary subtitle without prompting. Gate playback only on primary subtitle load/tokenization readiness. If primary subtitle probing/download/loading fails, resume playback and report the failure through the configured notification/output path. Keep the YouTube subtitle picker as a regular overlay modal opened by a new default keybinding during active YouTube playback. - - -## Acceptance Criteria - -- [x] #1 Opening a YouTube URL auto-selects and attempts to load the default primary subtitle without opening the picker modal. -- [x] #2 Opening a YouTube URL also attempts to load the default secondary subtitle when available, but playback never waits on secondary success. -- [x] #3 Playback remains gated only until the primary subtitle is loaded and tokenization is ready; primary failure resumes playback immediately. -- [x] #4 Primary auto-load failures report through the existing configured notification/output path and keep playback running. -- [x] #5 The YouTube subtitle picker can be opened manually during active YouTube playback via a new default keybinding. -- [x] #6 Regression tests cover startup auto-load success, primary failure fallback, and the manual picker keybinding flow. - - -## Implementation Plan - - -1. Add failing tests for YouTube startup auto-load success, primary failure fallback, and manual picker keybinding flow. -2. Refactor the YouTube runtime to auto-select default tracks on startup, gate playback only on primary subtitle/tokenization readiness, and route failures through the configured notification/output path. -3. Add a new default keybinding and command path to open the YouTube picker manually during active YouTube playback. -4. Run targeted tests, then SubMiner verification lanes for launcher/runtime changes; update docs/changelog if required by the final behavior change. - - -## Implementation Notes - - -Verification blocker outside this change: `bun run test:fast` still fails at `scripts/update-aur-package.test.ts` on macOS because `scripts/update-aur-package.sh` uses `mapfile`, which is unavailable in the system Bash 3.x environment used here. - - -## Final Summary - - -Reworked app-owned YouTube playback to auto-load the default primary subtitle plus a best-effort secondary subtitle at startup instead of forcing the picker modal first. Playback now waits only on primary subtitle load/tokenization readiness, routes startup primary-failure messaging through the configured notification output path, and keeps the YouTube subtitle picker available on demand via a new default `Ctrl+Shift+J` keybinding during active YouTube playback. Updated the runtime/IPC/config plumbing, user-facing help/docs, and added regression coverage for startup auto-load, primary-failure fallback, and manual picker invocation. - diff --git a/backlog/completed/task-225 - Fix-frozen-primary-YouTube-subtitle-display-after-auto-load-startup.md b/backlog/completed/task-225 - Fix-frozen-primary-YouTube-subtitle-display-after-auto-load-startup.md deleted file mode 100644 index e3e674ef..00000000 --- a/backlog/completed/task-225 - Fix-frozen-primary-YouTube-subtitle-display-after-auto-load-startup.md +++ /dev/null @@ -1,41 +0,0 @@ ---- -id: TASK-225 -title: Fix frozen primary YouTube subtitle display after auto-load startup -status: Done -assignee: [] -created_date: '2026-03-23 20:07' -updated_date: '2026-03-24 06:41' -labels: - - bug - - youtube - - subtitles -dependencies: - - TASK-224 -priority: high -ordinal: 149500 ---- - -## Description - - -After the new YouTube auto-load startup flow, the primary subtitle overlay can stay stuck on an older line while the subtitle sidebar continues advancing. Investigate startup suppression / subtitle refresh timing and restore live primary overlay updates after auto-loaded subtitles are injected. - - -## Acceptance Criteria - -- [x] #1 When YouTube auto-load succeeds, the visible primary subtitle continues advancing after playback resumes. -- [x] #2 Startup suppression does not leave the primary subtitle display stuck on a stale line. -- [x] #3 A regression test covers the startup path that previously froze the visible primary subtitle while sidebar timing continued advancing. - - -## Implementation Notes - - -Root cause: applyStartupState seeded youtubePlaybackFlowPending from initialArgs.youtubePlay, and runYoutubePlaybackFlowMain restored that preexisting true value after startup auto-load. Result: primary subtitle events stayed suppressed for startup-launched YouTube playback while sidebar timing still advanced. - - -## Final Summary - - -Stopped pre-seeding youtubePlaybackFlowPending from startup CLI args so only the actual YouTube playback bootstrap window suppresses subtitle events. Added a regression test covering startup YouTube args and re-ran targeted YouTube/runtime subtitle tests plus typecheck. - diff --git a/backlog/completed/task-226 - Restore-subtitle-sidebar-cues-for-auto-loaded-YouTube-subtitles.md b/backlog/completed/task-226 - Restore-subtitle-sidebar-cues-for-auto-loaded-YouTube-subtitles.md deleted file mode 100644 index e5972035..00000000 --- a/backlog/completed/task-226 - Restore-subtitle-sidebar-cues-for-auto-loaded-YouTube-subtitles.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -id: TASK-226 -title: Restore subtitle sidebar cues for auto-loaded YouTube subtitles -status: Done -assignee: [] -created_date: '2026-03-23 20:21' -updated_date: '2026-03-24 06:41' -labels: - - bug - - youtube - - subtitle-sidebar -dependencies: - - TASK-224 - - TASK-225 -priority: high -ordinal: 148500 ---- - -## Description - - -After fixing startup subtitle event suppression, the primary subtitle overlay updates for auto-loaded YouTube playback but the subtitle sidebar reports no parsed subtitle cues available. Investigate parsed subtitle source registration / refresh for auto-loaded YouTube subtitle files and restore sidebar cue population. - - -## Acceptance Criteria - -- [x] #1 When YouTube auto-load succeeds, the subtitle sidebar receives parsed cues for the active primary subtitle source. -- [x] #2 Auto-loaded YouTube subtitle source changes refresh the sidebar snapshot without requiring manual picker interaction. -- [x] #3 A regression test covers the startup auto-load path where live primary subtitles render but sidebar cues remain empty. - - -## Implementation Notes - - -Root cause: successful YouTube auto-load refreshed visible primary subtitle state, but did not explicitly initialize parsed subtitle cues from the resolved downloaded primary subtitle file. Sidebar cue population depended on later mpv source rediscovery, which could leave snapshots empty. - - -## Final Summary - - -Added a regression test for YouTube auto-load sidebar cue refresh and wired the YouTube subtitle flow to explicitly refresh parsed subtitle cues from the resolved primary subtitle path after a successful load. Verified with targeted YouTube/sidebar/runtime tests plus typecheck. - diff --git a/backlog/completed/task-227 - Assess-and-address-PR-31-latest-CodeRabbit-review-round.md b/backlog/completed/task-227 - Assess-and-address-PR-31-latest-CodeRabbit-review-round.md deleted file mode 100644 index 3fd7000b..00000000 --- a/backlog/completed/task-227 - Assess-and-address-PR-31-latest-CodeRabbit-review-round.md +++ /dev/null @@ -1,65 +0,0 @@ ---- -id: TASK-227 -title: 'Assess and address PR #31 latest CodeRabbit review round' -status: Done -assignee: - - codex -created_date: '2026-03-24 03:53' -updated_date: '2026-03-24 06:41' -labels: - - pr-review - - coderabbit -dependencies: [] -references: - - >- - PR #31 feat: add app-owned YouTube subtitle flow with absPlayer-style - parsing -priority: medium -ordinal: 147500 ---- - -## Description - - -Inspect the latest CodeRabbit review round on PR #31, verify each actionable comment against the current branch, implement only the valid fixes, add regression coverage where appropriate, and prepare thread replies for resolved or declined items. - - -## Acceptance Criteria - -- [x] #1 Latest CodeRabbit comments on PR #31 are triaged into valid fixes vs non-actioned suggestions with rationale. -- [x] #2 Confirmed issues are fixed with regression coverage where appropriate. -- [x] #3 Relevant verification passes for the touched areas. -- [x] #4 PR reply notes are ready for each addressed or declined latest-review comment. - - -## Implementation Plan - - -1. Verify the five latest CodeRabbit inline comments against the current branch and separate valid bugs from non-actioned suggestions. -2. Add failing regression coverage for confirmed issues in launcher playback tests, CLI YouTube flow error handling, and renderer YouTube picker disabled-state behavior. -3. Implement the minimal production fixes for the confirmed issues, plus remove the duplicate overlay Anki initialization if still redundant. -4. Inspect the YouTube primary-subtitle failure timer wiring to decide whether a code change is warranted in this round or whether a technical reply declining the comment is more correct. -5. Run targeted Bun tests for the touched files and prepare concise PR thread replies for each latest-review comment. - - -## Implementation Notes - - -Triaged the latest PR #31 CodeRabbit round: five inline comments were current action items; implemented all five. Strengthened the launcher playback test fixture so YouTube pause coverage no longer piggybacks on generic overlay auto-pause settings. - -Added regression tests for CLI YouTube flow rejection handling, no-track picker disabled-state restoration, and app-owned YouTube notification suppression while subtitle acquisition is still in flight. - -Implemented `runAsyncWithOsd(...)` handling for `args.youtubePlay`, kept no-track picker controls disabled after failed continue attempts, added `setAppOwnedFlowInFlight(...)` to the YouTube primary-subtitle notification runtime with main-process wiring around `runYoutubePlaybackFlowMain(...)`, and removed the duplicate `initializeOverlayAnkiIntegrationCore(...)` call from `initializeOverlayRuntime()`. - -Verification passed: `bun test launcher/commands/playback-command.test.ts src/core/services/cli-command.test.ts src/renderer/modals/youtube-track-picker.test.ts src/main/runtime/youtube-primary-subtitle-notification.test.ts` and `bun run typecheck`. - - -## Final Summary - - -Assessed the latest CodeRabbit review round on PR #31 and implemented all five current inline action items. Strengthened the launcher playback regression test so app-owned YouTube pause behavior is asserted independently from generic overlay auto-pause settings, wrapped the CLI `youtubePlay` branch in the existing `runAsyncWithOsd(...)` path so probe/download/startup failures surface in logs and OSD, kept the no-track YouTube picker controls disabled after rejected continue attempts, suppressed the generic primary-subtitle failure timer while the app-owned YouTube flow is still probing/downloading and restarted it only after the flow settles, and removed the duplicate overlay Anki initialization from `initializeOverlayRuntime()`. - -Verification passed with `bun test launcher/commands/playback-command.test.ts src/core/services/cli-command.test.ts src/renderer/modals/youtube-track-picker.test.ts src/main/runtime/youtube-primary-subtitle-notification.test.ts` and `bun run typecheck`. - -Prepared thread-reply notes for the five latest inline comments; did not post them because GitHub replies are an external side effect. - diff --git a/backlog/completed/task-228 - Assess-and-address-PR-31-subsequent-CodeRabbit-review-round.md b/backlog/completed/task-228 - Assess-and-address-PR-31-subsequent-CodeRabbit-review-round.md deleted file mode 100644 index dd2d0773..00000000 --- a/backlog/completed/task-228 - Assess-and-address-PR-31-subsequent-CodeRabbit-review-round.md +++ /dev/null @@ -1,64 +0,0 @@ ---- -id: TASK-228 -title: 'Assess and address PR #31 subsequent CodeRabbit review round' -status: Done -assignee: - - codex -created_date: '2026-03-24 04:10' -updated_date: '2026-03-24 06:41' -labels: - - pr-review - - coderabbit -dependencies: [] -references: - - >- - PR #31 feat: add app-owned YouTube subtitle flow with absPlayer-style - parsing - - 'commit cdb12827 fix: address PR #31 latest review follow-ups' -priority: medium -ordinal: 146500 ---- - -## Description - - -Inspect the subsequent CodeRabbit review round on PR #31 after commit cdb12827, verify each newly reported issue against the current branch, implement the valid fixes with regression coverage where appropriate, and prepare/update PR thread replies. - - -## Acceptance Criteria - -- [x] #1 New CodeRabbit comments after cdb12827 are triaged into valid fixes vs declined suggestions with rationale. -- [x] #2 Confirmed issues are fixed with regression coverage where appropriate. -- [x] #3 Relevant verification passes for the touched areas. -- [x] #4 PR threads are updated for the addressed comments. - - -## Implementation Plan - - -1. Verify the new CodeRabbit comments after cdb12827 and separate valid bugs from refactor-only suggestions. -2. Add failing regression coverage for the valid runtime issues: `track.selected` fallback in the YouTube primary-subtitle notifier and consistent no-track handling in the picker. -3. Inspect existing test seams for the `main.ts` flow-entry guards; if lightweight coverage exists, add it before patching. Otherwise apply the minimal `main.ts` fixes and rely on typecheck plus targeted regression tests around the affected runtime helpers. -4. Implement the confirmed fixes: picker re-entry guard, broader `inFlight` cleanup, `track.selected` fallback, and a single canonical `hasTracks` check. -5. Run targeted tests/typecheck and update the new PR threads with landed fix refs. - - -## Implementation Notes - - -Triaged the post-cdb12827 CodeRabbit round. Implemented the 4 concrete follow-ups: manual picker re-entry guard, broader `setAppOwnedFlowInFlight(...)` cleanup, `track.selected` fallback in the YouTube primary-subtitle notifier, and a single canonical `payloadHasTracks(...)` helper in the picker. Also took the adjacent `replaceChildren()` cleanup while touching the same picker paths. - -Verification passed: `bun test src/main/runtime/youtube-primary-subtitle-notification.test.ts src/renderer/modals/youtube-track-picker.test.ts launcher/commands/playback-command.test.ts src/core/services/cli-command.test.ts` and `bun run typecheck`. - -Updated the new CodeRabbit inline threads with landed fix refs and left a top-level PR comment noting the large refactor suggestions are intentionally out of scope for this bugfix round. - - -## Final Summary - - -Assessed the subsequent CodeRabbit review round on PR #31 after cdb12827 and applied the valid follow-ups in commit 5f6f93cd. Added a guard in `openYoutubeTrackPickerFromPlayback()` so the manual picker cannot re-enter while another YouTube flow session is active, widened the app-owned in-flight suppression to cover synchronous Windows mpv bootstrap and connect failures, taught the primary-subtitle notifier to honor `track.selected` before `sid` arrives, and unified the picker’s subtitle-availability logic behind `payloadHasTracks(...)` while swapping node clearing to `replaceChildren()`. - -Verification passed with `bun test src/main/runtime/youtube-primary-subtitle-notification.test.ts src/renderer/modals/youtube-track-picker.test.ts launcher/commands/playback-command.test.ts src/core/services/cli-command.test.ts` and `bun run typecheck`. - -Updated the latest inline CodeRabbit threads plus a top-level PR comment summarizing the round and explicitly deferred the large refactor suggestions as non-blocking maintainability nits. - diff --git a/backlog/completed/task-229 - Address-PR-31-final-CodeRabbit-picker-test-follow-up.md b/backlog/completed/task-229 - Address-PR-31-final-CodeRabbit-picker-test-follow-up.md deleted file mode 100644 index 315a92c8..00000000 --- a/backlog/completed/task-229 - Address-PR-31-final-CodeRabbit-picker-test-follow-up.md +++ /dev/null @@ -1,55 +0,0 @@ ---- -id: TASK-229 -title: 'Address PR #31 final CodeRabbit picker test follow-up' -status: Done -assignee: - - codex -created_date: '2026-03-24 04:27' -updated_date: '2026-03-24 06:41' -labels: - - pr-review - - coderabbit -dependencies: [] -references: - - >- - PR #31 feat: add app-owned YouTube subtitle flow with absPlayer-style - parsing - - >- - CodeRabbit comment on src/renderer/modals/youtube-track-picker.test.ts - global restoration / harness duplication -priority: medium -ordinal: 145500 ---- - -## Description - - -Fix the remaining CodeRabbit comment on the YouTube picker test file by restoring absent globals correctly and reducing repeated test harness setup so global stubbing is consistent and isolated. - - -## Acceptance Criteria - -- [x] #1 Picker tests restore `window`, `document`, and `CustomEvent` without leaving undefined-valued globals behind. -- [x] #2 Repeated picker test setup is consolidated enough to remove the current review complaint. -- [x] #3 Relevant picker tests pass and PR thread is updated. - - -## Implementation Plan - - -1. Add a failing regression around global restoration semantics in the YouTube picker test harness. -2. Extract shared DOM/environment helpers and restore logic using delete when globals were originally absent. -3. Re-run focused tests and typecheck, then commit/push and reply on the PR thread. - - -## Implementation Notes - - -Latest CodeRabbit comment targets youtube-track-picker.test.ts harness cleanup and correct restoration of global properties. - - -## Final Summary - - -Addressed the last PR #31 CodeRabbit comment by refactoring the YouTube picker test harness to use shared DOM/env helpers, restoring absent globals via delete semantics, adding a regression for cleanup behavior, and pushing commit 039e2f56 with focused picker tests plus typecheck passing. - diff --git a/backlog/completed/task-231 - Restore-controller-input-while-subtitle-sidebar-is-open.md b/backlog/completed/task-231 - Restore-controller-input-while-subtitle-sidebar-is-open.md deleted file mode 100644 index c7357c7e..00000000 --- a/backlog/completed/task-231 - Restore-controller-input-while-subtitle-sidebar-is-open.md +++ /dev/null @@ -1,57 +0,0 @@ ---- -id: TASK-231 -title: Restore controller input while subtitle sidebar is open -status: Done -assignee: - - '@codex' -created_date: '2026-03-24 00:15' -updated_date: '2026-03-24 00:15' -labels: - - bug - - controller - - subtitle-sidebar - - overlay -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/renderer/renderer.ts - - /home/sudacode/projects/japanese/SubMiner/src/renderer/controller-interaction-blocking.ts - - /home/sudacode/projects/japanese/SubMiner/src/renderer/controller-interaction-blocking.test.ts -priority: high -ordinal: 54900 ---- - -## Description - - - -When keyboard-only mode is active, opening the subtitle sidebar should not disable controller navigation and lookup/mining controls. Restore controller input while the sidebar is open, while keeping true modal dialogs blocking controller actions. - - - -## Acceptance Criteria - - - -- [x] #1 Opening the subtitle sidebar does not block controller input for keyboard-only mode actions. -- [x] #2 Controller-select/debug and other true modal dialogs still block controller actions while open. -- [x] #3 Focused regression coverage exists for the sidebar-open controller gating rule. - - - -## Implementation Notes - - - -Root cause: renderer gamepad polling used the broad `isAnyModalOpen()` check as its interaction gate, and that list includes `subtitleSidebarModalOpen`. The subtitle sidebar is non-modal for controller usage, so gamepad input was being suppressed whenever the sidebar was visible. - -Fixed by extracting a dedicated controller-interaction blocking helper that excludes the subtitle sidebar but keeps the existing blocking behavior for true modal dialogs. - - - -## Final Summary - - - -Restored controller input while the subtitle sidebar is open by switching gamepad polling to a dedicated modal-blocking rule that leaves the sidebar controller-passive. Added a regression test covering the sidebar-open exception and preserving hard blocks for actual modal dialogs. - - diff --git a/backlog/completed/task-232 - Trim-release-package-size-by-pruning-duplicate-and-source-only-assets.md b/backlog/completed/task-232 - Trim-release-package-size-by-pruning-duplicate-and-source-only-assets.md deleted file mode 100644 index 73d4c345..00000000 --- a/backlog/completed/task-232 - Trim-release-package-size-by-pruning-duplicate-and-source-only-assets.md +++ /dev/null @@ -1,66 +0,0 @@ ---- -id: TASK-232 -title: Trim release package size by pruning duplicate and source-only assets -status: Done -assignee: - - '@codex' -created_date: '2026-03-24 12:05' -updated_date: '2026-03-24 12:30' -labels: - - release - - packaging -priority: medium -ordinal: 54700 -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/package.json - - /home/sudacode/projects/japanese/SubMiner/src/release-workflow.test.ts - - /home/sudacode/projects/japanese/SubMiner/src/core/services/texthooker.ts ---- - -## Description - - - -Reduce packaged release artifact size without changing user-visible functionality by pruning files that are duplicated between `app.asar` and `extraResources`, excluding source/test/doc-only trees from Electron packaging, and trimming obviously non-runtime vendored payload. - - - -## Acceptance Criteria - - - -- [x] #1 Electron packaging excludes repo content that is source-only, test-only, docs-only, or duplicated by `extraResources`. -- [x] #2 Release packaging tests cover the new exclusion rules. -- [x] #3 Verification includes at least targeted release-packaging tests and one packaging-oriented validation step. - - -## Implementation Notes - - - -Completed scope: -- Exclude `assets`, `plugin`, and `vendor/yomitan-jlpt-vocab` from `files` because they are already staged via `extraResources`. -- Exclude `dist` sourcemaps/tests, repo docs/tests/packaging metadata, and stats source leftovers from `files`. -- Exclude non-runtime `vendor/texthooker-ui` payload such as `public/`, `.vscode/`, and package metadata. -- Exclude Linux musl libsql binary from packaged app payload for AppImage-focused savings. - -Verification: -- `bun test src/release-workflow.test.ts` -- `bun run build` -- `node_modules/.bin/electron-builder --linux dir --publish never` -- `node_modules/.bin/electron-builder --linux AppImage --publish never` - -Observed result: -- `release/linux-unpacked/resources/app.asar` dropped from about `100 MB` to `29 MB`. -- `release/SubMiner-0.9.0.AppImage` dropped from about `256 MB` to `194 MB`. - - - -## Final Summary - - - -Trimmed Electron packaging so release artifacts no longer bundle duplicated `extraResources`, source/test/doc-only repo content, non-runtime `texthooker-ui` files, or the Linux musl libsql binary. Added release-packaging regression coverage and verified the Linux package shrink with fresh local builds. - - diff --git a/backlog/completed/task-243 - Assess-and-address-PR-36-latest-CodeRabbit-review-round.md b/backlog/completed/task-243 - Assess-and-address-PR-36-latest-CodeRabbit-review-round.md deleted file mode 100644 index cdd612ae..00000000 --- a/backlog/completed/task-243 - Assess-and-address-PR-36-latest-CodeRabbit-review-round.md +++ /dev/null @@ -1,35 +0,0 @@ ---- -id: TASK-243 -title: 'Assess and address PR #36 latest CodeRabbit review round' -status: Done -assignee: [] -created_date: '2026-03-29 07:39' -updated_date: '2026-03-29 07:41' -labels: - - code-review - - pr-36 -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/36' -priority: high -ordinal: 3600 ---- - -## Description - - -Inspect the latest CodeRabbit review round on PR #36, verify each actionable comment against the current branch, implement the confirmed fixes, and verify the touched paths. - - -## Acceptance Criteria - -- [ ] #1 Confirmed review comments are implemented or explicitly deferred with rationale. -- [ ] #2 Touched paths are verified with the smallest sufficient test/build lane. -- [ ] #3 Current PR feedback is reduced to resolved or intentionally deferred suggestions. - - -## Final Summary - - -Addressed the confirmed latest CodeRabbit review items on PR #36. `scripts/run-coverage-lane.ts` now uses the Bun-style `import.meta.main` entrypoint check with a local ts-ignore to preserve the repo's CommonJS typecheck settings. `src/core/services/immersion-tracker/maintenance.ts` no longer shadows the imported `nowMs` helper in retention functions. `src/main.ts` now centralizes the startup-mode predicates behind a shared helper and releases `resolvedSource.cleanup` on the cached-subtitle fast path so materialized sources do not leak. - diff --git a/backlog/completed/task-244 - Assess-and-address-PR-36-latest-CodeRabbit-review-round-2.md b/backlog/completed/task-244 - Assess-and-address-PR-36-latest-CodeRabbit-review-round-2.md deleted file mode 100644 index dd7bcef7..00000000 --- a/backlog/completed/task-244 - Assess-and-address-PR-36-latest-CodeRabbit-review-round-2.md +++ /dev/null @@ -1,35 +0,0 @@ ---- -id: TASK-244 -title: 'Assess and address PR #36 latest CodeRabbit review round 2' -status: Done -assignee: [] -created_date: '2026-03-29 08:09' -updated_date: '2026-03-29 08:10' -labels: - - code-review - - pr-36 -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/36' -priority: high -ordinal: 3610 ---- - -## Description - - -Inspect the newest CodeRabbit review round on PR #36, verify the actionable comment against the current branch, implement the confirmed fix, and verify the touched path. - - -## Acceptance Criteria - -- [ ] #1 The actionable review comment is implemented or explicitly deferred with rationale. -- [ ] #2 Touched path is verified with the smallest sufficient test lane. -- [ ] #3 Current PR feedback is reduced to resolved or intentionally deferred suggestions. - - -## Final Summary - - -Addressed the actionable latest CodeRabbit comment on PR #36. `src/core/services/immersion-tracker/maintenance.ts` now skips retention deletions when a window is disabled with `Infinity`, so `toDbMs(...)` is only called for finite retention values. Added a regression test in `maintenance.test.ts` that verifies disabled retention windows preserve session events, telemetry, and sessions while returning zero deletions. - diff --git a/backlog/completed/task-272 - Assess-and-address-PR-40-CodeRabbit-review-follow-ups.md b/backlog/completed/task-272 - Assess-and-address-PR-40-CodeRabbit-review-follow-ups.md deleted file mode 100644 index dfe53ddf..00000000 --- a/backlog/completed/task-272 - Assess-and-address-PR-40-CodeRabbit-review-follow-ups.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-272 -title: 'Assess and address PR #40 CodeRabbit review follow-ups' -status: Done -assignee: [] -created_date: '2026-04-03 07:52' -updated_date: '2026-04-03 08:04' -labels: - - coderabbit - - review - - launcher -milestone: 'PR #40' -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/40' -priority: medium ---- - -## Description - - -Implement the valid CodeRabbit findings on PR #40 and keep the Windows mpv shortcut / first-run setup flow consistent end to end. - - -## Acceptance Criteria - -- [ ] #1 Windows binary resolution does not return install directories as executable candidates -- [ ] #2 Launch-mpv arg parsing preserves space-separated mpv option values and target separation -- [ ] #3 Windows mpv launch args keep the final input-ipc-server and script-opts socket path in sync when custom values are supplied -- [ ] #4 First-run setup navigation swallows stale or invalid custom-scheme actions without navigating away -- [ ] #5 Setup messaging and footer copy reflect configReady, plugin, and dictionary gates consistently -- [ ] #6 Regression tests cover the fixed behaviors - - -## Final Summary - - -Addressed CodeRabbit follow-ups for PR #40. Hardened launcher binary discovery on Windows and PATH resolution, fixed launch-mpv argument parsing for value-bearing flags, synced custom Windows mpv IPC socket values into script opts, and tightened first-run setup messaging/navigation to handle stale actions and blocker copy. Verified with `bun test src/main-entry-runtime.test.ts src/main/runtime/windows-mpv-launch.test.ts src/main/runtime/first-run-setup-window.test.ts launcher/mpv.test.ts`. - diff --git a/backlog/completed/task-285 - Rename-anime-visibility-filter-heading-to-title-visibility.md b/backlog/completed/task-285 - Rename-anime-visibility-filter-heading-to-title-visibility.md deleted file mode 100644 index 86cddba9..00000000 --- a/backlog/completed/task-285 - Rename-anime-visibility-filter-heading-to-title-visibility.md +++ /dev/null @@ -1,34 +0,0 @@ ---- -id: TASK-285 -title: Rename anime visibility filter heading to title visibility -status: Done -assignee: - - codex -created_date: '2026-04-10 00:00' -updated_date: '2026-04-10 00:00' -labels: - - stats - - ui - - bug -milestone: m-1 -dependencies: [] -references: - - stats/src/components/trends/TrendsTab.tsx - - stats/src/components/trends/TrendsTab.test.tsx -priority: low -ordinal: 200000 ---- - -## Description - - -Align the library cumulative trends filter UI with the new terminology by renaming the hardcoded anime visibility heading to title visibility. - - -## Acceptance Criteria - - -- [x] #1 The trends filter heading uses `Title Visibility` -- [x] #2 The component behavior and props stay unchanged -- [x] #3 A regression test covers the rendered heading text - diff --git a/backlog/completed/task-314 - Improve-Jellyfin-setup-popup-and-tray-discovery-toggle.md b/backlog/completed/task-314 - Improve-Jellyfin-setup-popup-and-tray-discovery-toggle.md deleted file mode 100644 index 30f503da..00000000 --- a/backlog/completed/task-314 - Improve-Jellyfin-setup-popup-and-tray-discovery-toggle.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-314 -title: Improve Jellyfin setup popup and tray discovery toggle -status: Done -assignee: [] -created_date: '2026-05-02 22:45' -updated_date: '2026-05-02 23:11' -labels: - - jellyfin -dependencies: [] -references: - - src/main/runtime/jellyfin-setup-window.ts - - src/main/runtime/jellyfin-cli-auth.ts - - src/main/runtime/tray-runtime.ts - - src/main/runtime/jellyfin-remote-session-lifecycle.ts -documentation: - - docs-site/jellyfin-integration.md - - docs-site/configuration.md -priority: medium ---- - -## Description - - -Improve the Jellyfin integration setup experience and remove the need to use command-line discovery mode for normal tray-driven use. The existing `--jellyfin` setup popup should become a frontend for the same auth persistence path used by CLI login, with manual/recent server selection and inline feedback. The tray should expose a runtime-only Jellyfin Discovery checkbox when Jellyfin is configured so users can start or stop cast/discovery mode without changing config. - - -## Acceptance Criteria - -- [x] #1 The Jellyfin setup popup supports config/recent/default server choices, manual URL entry, username/password login, logout when a session exists, done/close, and inline success/error status without persisting passwords. -- [x] #2 CLI login and setup popup login share the same auth persistence behavior, including encrypted token storage, enabled/server/username/client metadata config patching, and recent server updates. -- [x] #3 `jellyfin.recentServers` is parsed, normalized, deduplicated, capped, documented, and included in generated config examples if exposed. -- [x] #4 The tray keeps Configure Jellyfin visible and shows a Jellyfin Discovery checkbox only when Jellyfin is configured with enabled integration, server URL, access token, and user ID. -- [x] #5 The tray Jellyfin Discovery checkbox starts/stops the current remote session at runtime only, announces after start, reports OSD/log status, and does not patch config. -- [x] #6 Startup auto-connect behavior remains governed by existing config, including `remoteControlAutoConnect`; explicit tray start can start discovery without requiring `remoteControlAutoConnect`. -- [x] #7 Focused tests cover setup popup actions/rendering, shared auth persistence, config parsing, tray toggle visibility/state/click behavior, and remote lifecycle auto-connect versus explicit-start behavior. -- [x] #8 Jellyfin docs and changelog fragment are updated. - - -## Final Summary - - -Implemented Jellyfin setup popup improvements, shared auth persistence for CLI/setup config shape, recent server config support, runtime-only tray Jellyfin Discovery toggle, docs/config examples, and changelog fragment. Verified focused Jellyfin/tray tests, config tests, launcher tests, typecheck, and docs tests. - diff --git a/backlog/completed/task-336 - Fix-Hyprland-fullscreen-overlay-downward-offset.md b/backlog/completed/task-336 - Fix-Hyprland-fullscreen-overlay-downward-offset.md deleted file mode 100644 index 2a583cdf..00000000 --- a/backlog/completed/task-336 - Fix-Hyprland-fullscreen-overlay-downward-offset.md +++ /dev/null @@ -1,76 +0,0 @@ ---- -id: TASK-336 -title: Fix Hyprland fullscreen overlay downward offset -status: Done -assignee: [] -created_date: '2026-05-04 05:42' -updated_date: '2026-05-04 06:10' -labels: - - linux - - hyprland - - overlay - - bug -dependencies: [] -references: - - src/window-trackers/hyprland-tracker.ts - - src/core/services/overlay-window-bounds.ts - - src/main/runtime/linux-mpv-fullscreen-overlay-refresh.ts -priority: medium ---- - -## Description - - -SubMiner visible overlay is slightly below mpv when mpv is fullscreen on Linux Hyprland. Align overlay bounds with mpv fullscreen client/monitor bounds. - - -## Acceptance Criteria - -- [x] #1 Hyprland fullscreen mpv overlay uses top-aligned geometry instead of inheriting a downward offset. -- [x] #2 Regression coverage captures the fullscreen Hyprland geometry case. -- [x] #3 Targeted tests pass. - - -## Implementation Notes - - -Added follow-up Hyprland placement handling after the fullscreenClient geometry fix. SubMiner overlay/stats windows now get stable titles and, on Hyprland, are resolved from `hyprctl -j clients` by current PID/title, then set floating before bounds are applied. The stats overlay reapplies bounds after showing because Hyprland cannot see the hidden window before it is mapped. - -2026-05-04 follow-up: offset remains after removing pinning. User reports stats modal still has a top gap from mpv in Hyprland fullscreen. Need inspect exact stats overlay CSS/window bounds after float-only placement. - -2026-05-04 follow-up fix: stats CSS already had zero body margin, so the remaining gap points at native Hyprland placement after float-only handling. Added exact `movewindowpixel`/`resizewindowpixel` Hyprland dispatches using the same tracked mpv bounds passed to Electron. - -2026-05-04 second follow-up: live `hyprctl -j clients` showed the SubMiner client was already full monitor size at `[0,0]`, so the remaining visible top strip was inside Electron's transparent stats surface rather than compositor geometry. Made the stats overlay BrowserWindow opaque with the stats base background. Also prevented page titles from overwriting the stable SubMiner overlay/stats titles used for Hyprland client matching. - -2026-05-04 third follow-up: user confirmed native overlay placement is correct and the remaining gap is stats-page-specific. Made stats overlay mode paint an opaque full-viewport root/background and constrained the stats app to `h-screen` with an internal scrolling main pane, so the overlay page itself covers the mpv frame from y=0. - -2026-05-04 fourth follow-up: live Hyprland data showed mpv and SubMiner shared the same outer geometry while stats content still rendered lower. Stats window placement now compensates for Electron/Wayland content insets using `getContentBounds()` versus `getBounds()`, then sends the adjusted outer bounds to Hyprland exact placement so the content area, not just the native surface, aligns to mpv. - -2026-05-04 fifth follow-up: user confirmed the offset is Hyprland-fullscreen-only and not present while mpv is windowed. Added Hyprland `setprop` decoration cleanup during exact overlay placement (`rounding 0`, `border_size 0`, `no_shadow 1`, `no_blur 1`, `decorate 0`) because fullscreen mpv has square fullscreen edges while a floating SubMiner stats window can retain Hyprland floating-window decoration. - - -## Final Summary - - -Summary: -- Treated Hyprland `fullscreenClient` as a fullscreen signal when resolving mpv overlay geometry. -- Added Hyprland window placement handling so SubMiner overlay/stats windows are set floating before bounds are applied. -- Added exact Hyprland move/resize dispatches so floating overlay/stats windows are force-aligned to the tracked mpv bounds. -- Gave overlay/stats windows stable titles for Hyprland client matching, and reapplied stats bounds after show. -- Locked overlay/stats window titles against page title changes and made the stats overlay window opaque so mpv cannot show through transparent Electron insets. -- Made the stats overlay page paint an opaque full-viewport background and added CSS regression coverage for overlay mode. -- Compensated stats overlay outer placement for Electron/Wayland content insets. -- Disabled Hyprland floating-window decoration for exact overlay placement over fullscreen mpv. -- Added regression coverage for the 28px fullscreen geometry shape and Hyprland placement dispatches. -- Added a changelog fragment for the overlay fix. - -Verification: -- `bun test src/core/services/hyprland-window-placement.test.ts src/core/services/overlay-window-config.test.ts src/core/services/stats-window.test.ts src/core/services/overlay-window-bounds.test.ts src/window-trackers/hyprland-tracker.test.ts` -- `bun run typecheck` -- `bun run changelog:lint` -- `bun run test:fast` -- `bun test stats/src/styles/globals.test.ts stats/src/lib/api-client.test.ts src/core/services/stats-window.test.ts` -- `bun run build:stats` -- `bun test src/core/services/stats-window.test.ts src/core/services/hyprland-window-placement.test.ts stats/src/styles/globals.test.ts` -- `bun test src/core/services/hyprland-window-placement.test.ts src/core/services/stats-window.test.ts stats/src/styles/globals.test.ts` - diff --git a/backlog/completed/task-339 - Stop-pinning-Hyprland-overlay-windows.md b/backlog/completed/task-339 - Stop-pinning-Hyprland-overlay-windows.md deleted file mode 100644 index 242316b0..00000000 --- a/backlog/completed/task-339 - Stop-pinning-Hyprland-overlay-windows.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-339 -title: Stop pinning Hyprland overlay windows -status: Done -assignee: [] -created_date: '2026-05-04 06:07' -updated_date: '2026-05-04 06:09' -labels: - - linux - - hyprland - - overlay - - bug -dependencies: [] -references: - - src/core/services/hyprland-window-placement.ts - - src/core/services/overlay-window.ts - - src/core/services/stats-window.ts -priority: high ---- - -## Description - - -Recent Hyprland placement fix pins SubMiner overlay/stats windows, making them follow across workspaces instead of staying attached to mpv. Keep the float-for-bounds behavior, but never pin overlay windows. - - -## Acceptance Criteria - -- [x] #1 Hyprland placement dispatches set floating state only and does not dispatch pin. -- [x] #2 Regression coverage proves pinned clients are unpinned or at least not re-pinned by SubMiner. -- [x] #3 Targeted tests and typecheck pass. - - -## Implementation Notes - - -Changed Hyprland placement dispatch construction so unpinned overlay windows only get `setfloating`; pinned overlay windows get a single `pin` dispatch to toggle the bad prior pinned state off. This preserves floating placement for bounds while keeping overlay windows workspace-local with mpv. - - -## Final Summary - - -Summary: -- Stopped re-pinning Hyprland overlay/stats windows during placement. -- Added cleanup behavior for previously pinned SubMiner windows by toggling pin only when Hyprland reports `pinned: true`. -- Updated regression coverage and added a changelog fragment. - -Verification: -- `bun test src/core/services/hyprland-window-placement.test.ts src/core/services/overlay-window-config.test.ts src/core/services/stats-window.test.ts src/core/services/overlay-window-bounds.test.ts src/window-trackers/hyprland-tracker.test.ts` -- `bun run typecheck` -- `bun run changelog:lint` -- `bun run test:fast` - diff --git a/backlog/completed/task-351 - Remove-legacy-global-mpv-plugin-from-setup.md b/backlog/completed/task-351 - Remove-legacy-global-mpv-plugin-from-setup.md deleted file mode 100644 index 88cfbd0e..00000000 --- a/backlog/completed/task-351 - Remove-legacy-global-mpv-plugin-from-setup.md +++ /dev/null @@ -1,37 +0,0 @@ ---- -id: TASK-351 -title: Remove legacy global mpv plugin from setup -status: Done -assignee: [] -created_date: '2026-05-12 19:57' -updated_date: '2026-05-12 20:03' -labels: - - setup - - mpv-plugin - - launcher - - windows -dependencies: [] -priority: high ---- - -## Description - - -Add first-run setup support for detecting all legacy SubMiner mpv plugin auto-load entries and removing them via the OS trash after user confirmation, so regular mpv stops loading SubMiner while SubMiner-managed playback can use runtime plugin loading. - - -## Acceptance Criteria - -- [x] #1 Setup detects all SubMiner mpv auto-load candidates under normal mpv scripts directories and Windows portable_config scripts directories. -- [x] #2 Setup displays detected legacy plugin paths and offers a Remove legacy mpv plugin action. -- [x] #3 Removal uses Electron shell.trashItem for detected script files/directories and never permanently deletes as fallback. -- [x] #4 script-opts/subminer.conf is not removed by the legacy plugin removal action. -- [x] #5 Partial trash failures report exact failed paths and keep legacy plugin warning visible. -- [x] #6 Successful removal refreshes setup status and reports that regular mpv will no longer load SubMiner while SubMiner-managed playback keeps working. - - -## Final Summary - - -Implemented setup detection for all legacy SubMiner mpv auto-load candidates in normal and portable mpv script directories, added a confirmed Remove legacy mpv plugin action that uses Electron shell.trashItem only, preserves script-opts/subminer.conf, reports exact partial failures, and refreshes setup status after successful removal. Added focused tests plus changelog/docs updates. - diff --git a/backlog/completed/task-352 - Inject-bundled-mpv-plugin-for-managed-launches.md b/backlog/completed/task-352 - Inject-bundled-mpv-plugin-for-managed-launches.md deleted file mode 100644 index cc0af7a4..00000000 --- a/backlog/completed/task-352 - Inject-bundled-mpv-plugin-for-managed-launches.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-352 -title: Inject bundled mpv plugin for managed launches -status: Done -assignee: [] -created_date: '2026-05-12 20:06' -updated_date: '2026-05-12 20:15' -labels: - - launcher - - mpv-plugin - - windows - - setup -dependencies: [] -references: - - app-managed-mpv-runtime-plugin-plan.md -priority: high ---- - -## Description - - -Implement app-managed mpv runtime plugin loading so SubMiner-managed launcher and Windows mpv shortcut launches do not require a globally installed mpv plugin, while installed legacy/global plugins are detected and take precedence until removed. - - -## Acceptance Criteria - -- [x] #1 Launcher-managed mpv launch injects the bundled plugin when no installed SubMiner mpv plugin is detected. -- [x] #2 Launcher idle/Jellyfin mpv launch follows the same bundled-vs-installed plugin policy. -- [x] #3 Windows SubMiner mpv shortcut launch skips bundled injection when an installed plugin is detected and injects bundled plugin otherwise. -- [x] #4 First-run setup no longer requires global mpv plugin installation to finish; plugin install remains optional compatibility action. -- [x] #5 Runtime plugin path resolution is test-covered and reports a clear failure when no bundled plugin path is available and no installed plugin exists. -- [x] #6 Release docs/changelog explain that managed launches no longer require global plugin installation and legacy plugin removal switches to bundled runtime loading. - - -## Final Summary - - -Implemented app-managed mpv runtime plugin policy. Launcher-managed playback and idle/Jellyfin mpv startup now inject the bundled plugin when no global SubMiner plugin is detected, and keep using/logging the installed plugin when one is present. Windows SubMiner mpv shortcut launches use the same installed-vs-bundled policy while still passing SubMiner script opts. First-run setup no longer requires global plugin installation to finish, keeps legacy install as optional compatibility, and documents/removes legacy global plugin files via OS trash. - diff --git a/backlog/completed/task-353 - Remove-Makefile-global-mpv-plugin-installer.md b/backlog/completed/task-353 - Remove-Makefile-global-mpv-plugin-installer.md deleted file mode 100644 index 33221093..00000000 --- a/backlog/completed/task-353 - Remove-Makefile-global-mpv-plugin-installer.md +++ /dev/null @@ -1,37 +0,0 @@ ---- -id: TASK-353 -title: Remove Makefile global mpv plugin installer -status: Done -assignee: [] -created_date: '2026-05-12 14:07' -updated_date: '2026-05-12 14:07' -labels: - - launcher - - mpv-plugin - - docs -dependencies: [] -references: - - app-managed-mpv-runtime-plugin-plan.md -priority: medium ---- - -## Description - - -Remove the legacy Makefile path that installs SubMiner into mpv's global scripts directory, including the Windows config rewrite script hook, because managed playback now injects the bundled runtime plugin. - - -## Acceptance Criteria - -- [x] #1 Makefile no longer exposes an `install-plugin` target or help entry. -- [x] #2 Windows install no longer delegates to global mpv plugin installation. -- [x] #3 The obsolete config rewrite bun script is removed when no longer referenced. -- [x] #4 Docs no longer tell users to run `make install-plugin`. -- [x] #5 Regression coverage prevents reintroducing the target or script hook. - - -## Final Summary - - -Removed the legacy global mpv plugin install target from the Makefile, removed the obsolete Windows config rewrite script, updated docs to describe bundled runtime plugin loading instead of separate installation, and removed the setup window's legacy install action while keeping legacy plugin removal available. - diff --git a/backlog/completed/task-354 - Show-legacy-mpv-plugin-removal-before-managed-playback.md b/backlog/completed/task-354 - Show-legacy-mpv-plugin-removal-before-managed-playback.md deleted file mode 100644 index 8b42444b..00000000 --- a/backlog/completed/task-354 - Show-legacy-mpv-plugin-removal-before-managed-playback.md +++ /dev/null @@ -1,38 +0,0 @@ ---- -id: TASK-354 -title: Show legacy mpv plugin removal before managed playback -status: Done -assignee: [] -created_date: '2026-05-12 14:30' -updated_date: '2026-05-12 14:35' -labels: - - launcher - - mpv-plugin - - setup - - windows -dependencies: [] -references: - - app-managed-mpv-runtime-plugin-plan.md -priority: high ---- - -## Description - - -When SubMiner-managed playback detects a legacy global SubMiner mpv plugin, show the removal UI before mpv starts so users can optionally trash the legacy files and then launch with the bundled runtime plugin. - - -## Acceptance Criteria - -- [x] #1 Launcher playback opens first-run setup before mpv starts when legacy global plugin files are detected, even if setup is already completed. -- [x] #2 Launcher playback resumes with bundled runtime plugin after the legacy plugin is removed. -- [x] #3 Windows mpv shortcut/app launch prompts before spawning mpv and re-detects after removal so bundled injection is used. -- [x] #4 Users can continue without removal; removal remains optional. -- [x] #5 Regression coverage prevents bypassing the removal prompt due to completed setup or installed-plugin detection. - - -## Final Summary - - -Managed launcher playback now checks for legacy global SubMiner mpv plugin files before choosing/loading a video, opens first-run setup even when setup is already complete, and waits for removal or explicit user continuation before starting mpv. Windows managed mpv launches now show a pre-launch removal dialog, move detected legacy files to the OS trash on confirmation, re-detect, and inject the bundled runtime plugin after successful removal. - diff --git a/backlog/completed/task-70 - Overlay-runtime-refactor-remove-invisible-mode-and-bind-visible-overlay-to-mpv-subtitles.md b/backlog/completed/task-70 - Overlay-runtime-refactor-remove-invisible-mode-and-bind-visible-overlay-to-mpv-subtitles.md deleted file mode 100644 index a271788e..00000000 --- a/backlog/completed/task-70 - Overlay-runtime-refactor-remove-invisible-mode-and-bind-visible-overlay-to-mpv-subtitles.md +++ /dev/null @@ -1,51 +0,0 @@ ---- -id: TASK-70 -title: >- - Overlay runtime refactor: remove invisible mode and bind visible overlay to - mpv subtitles -status: Done -assignee: [] -created_date: '2026-02-28 02:38' -updated_date: '2026-02-28 22:36' -labels: [] -dependencies: [] -references: - - 'commit:a14c9da' - - 'commit:74554a3' - - 'commit:75442a4' - - 'commit:dde51f8' - - 'commit:9e4e588' - - src/main/overlay-runtime.ts - - src/main/runtime/overlay-mpv-sub-visibility.ts - - src/renderer/renderer.ts - - docs/plans/2026-02-26-secondary-subtitles-main-overlay.md -priority: medium -ordinal: 1000 ---- - -## Description - - - -Scope: Branch-only commits main..HEAD on refactor-overlay (a14c9da through 9e4e588) rebuilt overlay behavior around visible overlay mode and removed legacy invisible overlay paths. - -Delivered behavior: - -- Removed renderer invisible overlay layout/offset helpers and main hover-highlight runtime code paths. -- Added explicit overlay-to-mpv subtitle visibility synchronization so visible overlay state controls primary subtitle visibility consistently. -- Hardened overlay runtime/bootstrap lifecycle around modal fallback open state and bridge send path edge cases. -- Updated plugin/config/docs defaults to reflect visible-overlay-first behavior and subtitle binding controls. - -Risk/impact context: - -- Large cross-layer refactor touching runtime wiring, renderer event handling, and plugin behavior. -- Regression coverage added/updated for overlay runtime, mpv protocol handling, renderer cleanup, and subtitle rendering paths. - - -## Final Summary - - - -Completed and validated in branch commit set before merge. Refactor reduces dead overlay modes, centralizes subtitle visibility behavior, and documents new defaults/constraints. - - diff --git a/backlog/completed/task-71 - Anki-integration-add-local-AnkiConnect-proxy-transport-for-push-based-auto-enrichment.md b/backlog/completed/task-71 - Anki-integration-add-local-AnkiConnect-proxy-transport-for-push-based-auto-enrichment.md deleted file mode 100644 index 6b778f30..00000000 --- a/backlog/completed/task-71 - Anki-integration-add-local-AnkiConnect-proxy-transport-for-push-based-auto-enrichment.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-71 -title: >- - Anki integration: add local AnkiConnect proxy transport for push-based - auto-enrichment -status: Done -assignee: [] -created_date: '2026-02-28 02:38' -updated_date: '2026-03-04 13:55' -labels: [] -dependencies: [] -references: - - src/anki-integration/anki-connect-proxy.ts - - src/anki-integration/anki-connect-proxy.test.ts - - src/anki-integration.ts - - src/config/resolve/anki-connect.ts - - src/core/services/tokenizer/yomitan-parser-runtime.ts - - src/core/services/tokenizer/yomitan-parser-runtime.test.ts - - docs/anki-integration.md - - config.example.jsonc -priority: medium -ordinal: 2000 ---- - -## Description - - - -Scope: Current unmerged working-tree changes implement an optional local AnkiConnect-compatible proxy and transport switching for card enrichment. - -Delivered behavior: - -- Added proxy server that forwards AnkiConnect requests and enqueues addNote/addNotes note IDs for post-create enrichment, with de-duplication and loop-configuration protection. -- Added follow-up response-shape compatibility handling so proxy enqueue works for both envelope (`{result,error}`) and bare JSON payloads, including `multi` variants. -- Added config schema/defaults/resolution for ankiConnect.proxy (enabled, host, port, upstreamUrl) with validation warnings and fallback behavior. -- Runtime now supports transport switching (polling vs proxy) and restarts transport when runtime config patches change transport keys. -- Added Yomitan default-profile server sync helper to keep bundled parser profile aligned with configured Anki endpoint. -- Updated user docs/config examples for proxy mode setup, troubleshooting, and mining workflow behavior. - -Risk/impact context: - -- New network surface on local host/port; correctness depends on safe proxy upstream configuration and robust response handling. -- Tests added for proxy queue behavior, config resolution, and parser sync routines. - - -## Final Summary - - - -Completed implementation in branch working tree; ready to merge once local changes are committed and test gate passes. - -Follow-up fix (2026-03-04): - -- Updated bundled Yomitan server-sync behavior to target `profileCurrent` instead of hardcoded `profiles[0]`. -- Added proxy-mode force override so bundled Yomitan always points at SubMiner proxy URL when `ankiConnect.proxy.enabled=true`; this ensures mined cards pass through proxy and trigger auto-enrichment. -- Added regression tests for blocked existing-server case and force-override injection path. - - diff --git a/backlog/completed/task-72 - macOS-config-validation-UX-show-full-warning-details-in-native-dialog.md b/backlog/completed/task-72 - macOS-config-validation-UX-show-full-warning-details-in-native-dialog.md deleted file mode 100644 index 731ee525..00000000 --- a/backlog/completed/task-72 - macOS-config-validation-UX-show-full-warning-details-in-native-dialog.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -id: TASK-72 -title: 'macOS config validation UX: show full warning details in native dialog' -status: Done -assignee: [] -created_date: '2026-02-28 02:38' -updated_date: '2026-02-28 22:36' -labels: [] -dependencies: [] -references: - - 'commit:cc2f9ef' - - src/main/config-validation.ts - - src/main/runtime/startup-config.ts - - docs/configuration.md -priority: low -ordinal: 3000 ---- - -## Description - - - -Scope: Commit cc2f9ef improves startup config-warning visibility on macOS by ensuring full details are surfaced in the native UI path and reflected in docs. - -Delivered behavior: - -- Config validation/runtime wiring updated so macOS users can access complete warning details instead of truncated notification-only text. -- Added/updated tests around config validation and startup config warning flows. -- Updated configuration docs to clarify platform-specific warning presentation behavior. - -Risk/impact context: - -- Low runtime risk; primarily user-facing diagnostics clarity improvement. - - -## Final Summary - - - -Completed small follow-up fix to reduce config-debug friction on macOS. - - diff --git a/backlog/completed/task-73 - MPV-plugin-split-into-modules-and-optimize-startup-command-runtime.md b/backlog/completed/task-73 - MPV-plugin-split-into-modules-and-optimize-startup-command-runtime.md deleted file mode 100644 index 922d1bc5..00000000 --- a/backlog/completed/task-73 - MPV-plugin-split-into-modules-and-optimize-startup-command-runtime.md +++ /dev/null @@ -1,84 +0,0 @@ ---- -id: TASK-73 -title: 'MPV plugin: split into modules and optimize startup/command runtime' -status: Done -assignee: [] -created_date: '2026-02-28 20:50' -updated_date: '2026-02-28 22:36' -labels: [] -dependencies: [] -references: - - plugin/subminer/main.lua - - plugin/subminer/bootstrap.lua - - plugin/subminer/process.lua - - plugin/subminer/aniskip.lua - - plugin/subminer/environment.lua - - plugin/subminer/lifecycle.lua - - plugin/subminer/messages.lua - - plugin/subminer/ui.lua - - plugin/subminer/hover.lua - - plugin/subminer/options.lua - - plugin/subminer/state.lua - - plugin/subminer.conf - - scripts/test-plugin-start-gate.lua - - scripts/test-plugin-process-start-retries.lua - - launcher/commands/playback-command.ts - - launcher/mpv.ts - - launcher/mpv.test.ts - - launcher/smoke.e2e.test.ts - - Makefile - - package.json - - docs/mpv-plugin.md - - docs/installation.md - - docs/architecture.md - - README.md -priority: medium -ordinal: 4000 ---- - -## Description - - - -Scope: Replace monolithic `plugin/subminer.lua` with modular plugin runtime; optimize command execution paths; align install/docs/tests; fix launcher smoke instability. - -Delivered behavior: - -- Full plugin cutover to `plugin/subminer/main.lua` + module directory (no runtime compatibility shim with old monolith file). -- Process/control command path moved toward async subprocess usage for non-start actions (`stop`, `toggle`, `settings`, restart stop leg), reducing synchronous blocking in mpv script runtime. -- AniSkip path guarded: lookup runs only in SubMiner context (launcher metadata, explicit script-message refresh, or detected running app), instead of every opened file. -- AniSkip lookup pipeline moved to async subprocess calls (no sync `ps`/`curl` on `file-loaded`) with deferred fetch after auto-start and session-level MAL/title/payload caching. -- Startup/runtime loading updated with lazy module initialization via bootstrap proxies. -- Plugin install flow updated to copy `plugin/subminer/` directory and remove legacy `~/.config/mpv/scripts/subminer.lua` file. -- Added plugin gate script wiring to package scripts (`test:plugin:src`) and launcher test flow. -- Smoke tests stabilized across sandbox environments where UNIX socket bind can return `EPERM` while preserving normal-path assertions. -- Playback command cleanup race fixed when mpv exits before exit-listener registration. - -Risk/impact context: - -- mpv plugin loading path changed from single-file to module directory; packaging/install paths must stay consistent with release assets. -- Async control/AniSkip path changes reduce blocking but can surface timing differences; regression checks added for cold start, file-load gating, and explicit refresh behavior. - - -## Final Summary - - - -AniSkip gate/async update delivered in plugin runtime: - -- `plugin/subminer/lifecycle.lua`: deferred AniSkip fetch and overlay-start trigger. -- `plugin/subminer/aniskip.lua`: async lookup pipeline + context guard + session caches. -- `plugin/subminer/environment.lua`: async app-running detection with short cache. -- `plugin/subminer/messages.lua`: explicit script-message trigger wiring. - -Regression coverage updated: - -- `scripts/test-plugin-start-gate.lua` now verifies: - - no sync `ps`/`curl` on non-context file load - - no AniSkip network lookup on non-context file load - - script-message refresh forces async AniSkip lookup - -Validation run: - -- `bun run test:plugin:src` pass. - diff --git a/backlog/completed/task-74 - Startup-warmups-configurable-warmup-vs-defer-with-low-power-mode.md b/backlog/completed/task-74 - Startup-warmups-configurable-warmup-vs-defer-with-low-power-mode.md deleted file mode 100644 index 2220a9f8..00000000 --- a/backlog/completed/task-74 - Startup-warmups-configurable-warmup-vs-defer-with-low-power-mode.md +++ /dev/null @@ -1,76 +0,0 @@ ---- -id: TASK-74 -title: 'Startup warmups: configurable warmup vs defer with low-power mode' -status: Done -assignee: [] -created_date: '2026-02-27 21:05' -updated_date: '2026-03-01 04:14' -labels: [] -dependencies: [] -references: - - src/types.ts - - src/config/definitions/defaults-core.ts - - src/config/definitions/options-core.ts - - src/config/definitions/template-sections.ts - - src/config/resolve/core-domains.ts - - src/main/runtime/startup-warmups.ts - - src/main/runtime/startup-warmups-main-deps.ts - - src/main/runtime/composers/mpv-runtime-composer.ts - - src/core/services/startup.ts - - src/main.ts - - src/config/config.test.ts - - src/main/runtime/startup-warmups.test.ts - - src/main/runtime/startup-warmups-main-deps.test.ts - - src/core/services/app-ready.test.ts -priority: medium -ordinal: 7000 ---- - -## Description - - - -Add startup warmup controls to allow per-integration warmup or deferred first-use loading. - -Scope: - -- New config section `startupWarmups` with toggles for `mecab`, `yomitanExtension`, `subtitleDictionaries`, and `jellyfinRemoteSession`. -- New `startupWarmups.lowPowerMode` policy: defer everything except Yomitan extension. -- Keep default behavior as full warmup. -- Ensure deferred integrations lazy-load on first real usage path. -- Add test coverage for config parsing/defaults and warmup scheduling behavior. - - -## Final Summary - - - -Implemented: - -- Added `startupWarmups` to config types/defaults/options/template/resolve. -- Warmup scheduler now uses per-integration gating functions. -- Low-power mode now defers MeCab, subtitle dictionaries, and Jellyfin remote session warmups while still warming Yomitan extension. -- Tokenization path guarantees lazy first-use init for deferred dependencies (Yomitan extension, MeCab when missing, subtitle dictionaries). -- Added/updated tests across config and runtime warmup modules. - -Validation: - -- `bun run test:config:src` -- `bun run test:core:src` -- `tsc --noEmit` - -Follow-up updates: - -- Startup now triggers warmups earlier in app-ready flow (right after config validation/log-level setup) instead of waiting for initial args/overlay actions. Goal: tokenization warmup is already done or mostly done by first visible-subs toggle. -- Tokenization warmup scheduling consolidated as `subtitle-tokenization` stage; when enabled by toggles, it runs Yomitan extension first, then MeCab/dictionary warmups. -- Added per-stage debug logs for warmup progress and skip reasons: - - `stage start/ready: yomitan-extension` - - `stage start/ready: mecab` - - `stage start/ready: subtitle-dictionaries` - - `stage start/ready: jellyfin-remote-session` - - `stage skipped: jellyfin-remote-session (disabled|auto-connect off)` -- Added regression tests for stage-level logging and earlier startup ordering: - - `src/main/runtime/startup-warmups.test.ts` - - `src/main/runtime/startup-warmups-main-deps.test.ts` - - `src/core/services/app-ready.test.ts` - diff --git a/backlog/completed/task-75 - Tokenizer-configurable-POS-exclusions-for-N1-and-frequency-annotations.md b/backlog/completed/task-75 - Tokenizer-configurable-POS-exclusions-for-N1-and-frequency-annotations.md deleted file mode 100644 index 1b6eede2..00000000 --- a/backlog/completed/task-75 - Tokenizer-configurable-POS-exclusions-for-N1-and-frequency-annotations.md +++ /dev/null @@ -1,41 +0,0 @@ ---- -id: TASK-75 -title: 'Tokenizer: configurable POS exclusions for N+1 and frequency annotations' -status: Done -assignee: [] -created_date: '2026-03-01 01:23' -updated_date: '2026-03-01 04:14' -labels: [] -dependencies: [] -priority: medium -ordinal: 6000 ---- - -## Description - - - -N+1 and frequency highlighting should ignore non-learning tokens (e.g., particles/auxiliary forms) based on MeCab POS1 tags, while remaining user-configurable. - -Problem example: for subtitle phrase containing になれば, the highlighted N+1 target should not be the non-useful inflection/token piece when POS indicates an excluded class. - -Implement configurable exclusion defaults with add/remove overrides so users can tune behavior without code changes. - - - -## Acceptance Criteria - - - -- [x] #1 Default exclusion set omits non-useful POS1 classes from both N+1 candidate selection and frequency highlighting. -- [x] #2 Users can add extra POS1 exclusions and remove defaults via config. -- [x] #3 Tokenizer/annotation tests cover default behavior and config add/remove overrides. - - -## Final Summary - - - -Implemented configurable annotation POS exclusions with defaults+add/remove for both MeCab POS1 and POS2, wired to N+1 candidate selection and frequency highlighting. Added POS2 default exclusion (非自立), expanded POS1 defaults for function words, added Yomitan->MeCab enrichment to carry pos2/pos3 metadata, updated config docs/examples, and added regression tests including になれば case. - - diff --git a/backlog/completed/task-76 - Tokenizer-remove-POS-exclusion-config-surface-and-keep-hardcoded-defaults.md b/backlog/completed/task-76 - Tokenizer-remove-POS-exclusion-config-surface-and-keep-hardcoded-defaults.md deleted file mode 100644 index ff345dca..00000000 --- a/backlog/completed/task-76 - Tokenizer-remove-POS-exclusion-config-surface-and-keep-hardcoded-defaults.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-76 -title: 'Tokenizer: remove POS exclusion config surface and keep hardcoded defaults' -status: Done -assignee: [] -created_date: '2026-03-01 02:45' -updated_date: '2026-03-01 04:14' -labels: [] -dependencies: [] -priority: medium -ordinal: 5000 ---- - -## Description - - - -Remove user-facing config keys for annotation POS exclusions. Keep N+1/frequency POS exclusion behavior as built-in defaults with no config required. - -Scope: remove config parsing/registry/docs/example for annotationFilters.pos1Exclusions/pos2Exclusions while preserving runtime filtering behavior. - - - -## Acceptance Criteria - - - -- [x] #1 No user-facing config option exists for annotation POS exclusions. -- [x] #2 Runtime N+1/frequency exclusion behavior remains active via built-in defaults. -- [x] #3 Config/docs/example/tests updated accordingly. - - -## Final Summary - - - -Removed user-facing subtitleStyle.annotationFilters POS exclusion configuration (schema/resolver/options/docs/example). POS-based N+1/frequency filtering now always uses built-in defaults in runtime. Preserved robust exclusion behavior including merged-token overlap POS handling and N+1-only MeCab enrichment path. - - diff --git a/backlog/completed/task-77 - Subtitle-hover-auto-pause-config-and-runtime-behavior.md b/backlog/completed/task-77 - Subtitle-hover-auto-pause-config-and-runtime-behavior.md deleted file mode 100644 index d5a42f48..00000000 --- a/backlog/completed/task-77 - Subtitle-hover-auto-pause-config-and-runtime-behavior.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-77 -title: 'Subtitle hover: auto-pause playback with config toggle' -status: Done -assignee: [] -created_date: '2026-02-28 22:43' -updated_date: '2026-03-04 12:07' -labels: [] -dependencies: [] -priority: medium -ordinal: 8000 ---- - -## Description - - - -Add a user-facing subtitle config option to pause mpv playback when the cursor hovers subtitle text and resume playback when the cursor leaves. - -Scope: - -- New config key: `subtitleStyle.autoPauseVideoOnHover`. -- Default should be enabled. -- Hover pause/resume must not unpause if playback was already paused before hover. -- Docs/examples/tests updated. - - - -## Acceptance Criteria - - - -- [x] #1 `subtitleStyle.autoPauseVideoOnHover` exists and defaults to `true`. -- [x] #2 Overlay pauses playback on subtitle hover and resumes on leave only when hover-triggered pause occurred. -- [x] #3 Main/renderer IPC exposes pause-state query for safe hover behavior. -- [x] #4 Config docs/examples and user docs/readme mention the new behavior and toggle. -- [x] #5 Regression tests cover config parsing/validation and hover behavior edge cases. - - -## Final Summary - - - -Implemented `subtitleStyle.autoPauseVideoOnHover` with default `true`, wired through config defaults/resolution/types, renderer state/style, and mouse hover handlers. Added playback pause-state IPC (`getPlaybackPaused`) to avoid false resume when media was already paused. Added renderer hover behavior tests (including race/cancel case) and config/resolve tests. Updated config examples and docs (`README`, usage, shortcuts, mining workflow, configuration) to document default hover pause/resume behavior and disable path. - -Follow-up adjustments (2026-03-04): - -- Hover pause now resumes immediately when leaving subtitle text (no Yomitan-popup hover retention). -- Added `subtitleStyle.autoPauseVideoOnYomitanPopup` (default `false`) to optionally keep playback paused while Yomitan popup is open, with auto-resume on close only when SubMiner initiated the popup pause. -- Yomitan popup control keybinds added while popup is open: `J/K` scroll, `M` mine, `P` audio play, `[` previous audio variant, `]` next audio variant (within selected source). -- Extension copy drift detection widened so popup runtime changes are reliably re-copied on launch (`popup.js`, `popup-main.js`, `display.js`, `display-audio.js`). - - diff --git a/backlog/completed/task-78 - Launcher-and-mpv-plugin-auto-start-pause-until-ready-and-single-start-guard.md b/backlog/completed/task-78 - Launcher-and-mpv-plugin-auto-start-pause-until-ready-and-single-start-guard.md deleted file mode 100644 index 073f1756..00000000 --- a/backlog/completed/task-78 - Launcher-and-mpv-plugin-auto-start-pause-until-ready-and-single-start-guard.md +++ /dev/null @@ -1,55 +0,0 @@ ---- -id: TASK-78 -title: 'Launcher + mpv plugin: auto-start visible overlay pause-until-ready and single-start guard' -status: Done -assignee: [] -created_date: '2026-02-28 22:45' -updated_date: '2026-02-28 22:45' -labels: [] -dependencies: [] -priority: medium -ordinal: 9000 ---- - -## Description - - - -Add startup gating behavior for wrapper + mpv plugin flow so playback starts paused when visible overlay auto-start is enabled, then auto-resumes only after subtitle tokenization is ready. - -Scope: - -- Plugin option `auto_start_pause_until_ready` (default `yes`). -- Launcher reads plugin runtime config and starts mpv paused when `auto_start=yes`, `auto_start_visible_overlay=yes`, and `auto_start_pause_until_ready=yes`. -- Main process signals readiness via mpv script message after tokenized subtitle delivery. -- Prevent duplicate auto-start attempts from showing `SubMiner already running` OSD. -- Keep startup/loading OSD messaging visible and update docs/tests. - - - -## Acceptance Criteria - - - -- [x] #1 Launcher reads `auto_start`, `auto_start_visible_overlay`, and `auto_start_pause_until_ready` from `subminer.conf` and starts mpv with `--pause=yes` when all are enabled. -- [x] #2 Plugin pauses on eligible auto-start and resumes only on readiness signal or timeout fallback. -- [x] #3 Main process emits `script-message subminer-autoplay-ready` after subtitle tokenization is ready. -- [x] #4 Auto-start duplicate triggers are idempotent (no duplicate `--start` behavior and no spurious `Already running` OSD for auto-start path). -- [x] #5 Docs and regression tests cover defaults, startup gating behavior, and duplicate-start suppression. - - - -## Final Summary - - - -Implemented startup pause gate across launcher/plugin/main runtime: - -- Added plugin runtime config parsing in launcher (`auto_start`, `auto_start_visible_overlay`, `auto_start_pause_until_ready`) and mpv start-paused behavior for eligible runs. -- Added plugin auto-play gate state, timeout fallback, and readiness release via `subminer-autoplay-ready` script message. -- Added main-process readiness signaling after tokenization delivery, including unpause fallback command path. -- Split auto-start visibility control into separate control commands and added duplicate auto-start idempotency guard to suppress repeated auto-start `Already running` noise. -- Updated plugin defaults to enabled (`auto_start=yes`, `auto_start_visible_overlay=yes`, `auto_start_pause_until_ready=yes`) and refreshed docs (`README`, usage, launcher, installation, plugin/config docs). -- Added/updated regression coverage (`scripts/test-plugin-start-gate.lua`, launcher smoke/unit tests) validating paused startup, readiness resume, and duplicate-start suppression. - - diff --git a/backlog/completed/task-79 - Jimaku-modal-auto-close-after-successful-subtitle-load.md b/backlog/completed/task-79 - Jimaku-modal-auto-close-after-successful-subtitle-load.md deleted file mode 100644 index 7a9f1c84..00000000 --- a/backlog/completed/task-79 - Jimaku-modal-auto-close-after-successful-subtitle-load.md +++ /dev/null @@ -1,50 +0,0 @@ ---- -id: TASK-79 -title: 'Jimaku modal: auto-close after successful subtitle load' -status: Done -assignee: [] -created_date: '2026-03-01 13:52' -updated_date: '2026-03-01 14:06' -labels: [] -dependencies: [] -priority: medium -ordinal: 10000 ---- - -## Description - - - -Fix Jimaku modal UX so selecting a subtitle file closes the modal automatically once subtitle download+load succeeds. - -Current behavior: - -- Subtitle file downloads and loads into mpv. -- Jimaku modal remains open until manual close. - -Expected behavior: - -- On successful `jimakuDownloadFile` result, close modal immediately. -- Keep error behavior unchanged (stay open + show error). - - - -## Acceptance Criteria - - - -- [x] #1 Successful subtitle file selection/download in Jimaku closes modal automatically. -- [x] #2 Existing error path keeps modal open and shows error. -- [x] #3 Regression test covers success auto-close behavior. - - - -## Final Summary - - - -Fixed renderer Jimaku success flow to close modal immediately after successful `jimakuDownloadFile` result. Added regression test (`src/renderer/modals/jimaku.test.ts`) that reproduces keyboard file-selection success path and asserts modal close state + `notifyOverlayModalClosed('jimaku')` emission. Kept failure path unchanged. - -Also wired new test into `test:core:src` and `test:core:dist` package scripts. - - diff --git a/backlog/completed/task-80 - Jimaku-download-rename-subtitle-to-match-current-video.md b/backlog/completed/task-80 - Jimaku-download-rename-subtitle-to-match-current-video.md deleted file mode 100644 index 5d7c1fa4..00000000 --- a/backlog/completed/task-80 - Jimaku-download-rename-subtitle-to-match-current-video.md +++ /dev/null @@ -1,50 +0,0 @@ ---- -id: TASK-80 -title: 'Jimaku download: rename subtitle to current video basename' -status: Done -assignee: [] -created_date: '2026-03-01 14:17' -updated_date: '2026-03-01 14:19' -labels: [] -dependencies: [] -priority: medium -ordinal: 11000 ---- - -## Description - - - -When user selects a Jimaku subtitle, save subtitle with filename derived from currently playing media filename instead of Jimaku release filename. - -Example: - -- Current media: `anime.mkv` -- Downloaded subtitle extension: `.srt` -- Saved subtitle path: `anime.ja.srt` - -Scope: - -- Apply in Jimaku download IPC path before writing file. -- Preserve collision-avoidance behavior (suffix with jimaku entry id/counter when target exists). -- Keep mpv load flow unchanged except using renamed path. - - - -## Acceptance Criteria - - - -- [x] #1 Jimaku subtitle destination name uses current media basename plus `.ja` and subtitle extension. -- [x] #2 Existing duplicate filename conflict handling still works. -- [x] #3 Regression tests cover renamed destination path behavior. - - - -## Final Summary - - - -Jimaku download path generation now derives subtitle filename from currently playing media basename and keeps subtitle extension from Jimaku file (`anime.mkv` + `.srt` => `anime.ja.srt`). Added pure helper `buildJimakuSubtitleFilenameFromMediaPath` and routed IPC download flow through it before existing duplicate-path conflict handling. Added regression tests for local path, missing extension fallback, and remote URL media paths. - - diff --git a/backlog/completed/task-81 - Tokenization-performance-disable-yomitan-mecab-and-persistent-local-mecab.md b/backlog/completed/task-81 - Tokenization-performance-disable-yomitan-mecab-and-persistent-local-mecab.md deleted file mode 100644 index 57367fa0..00000000 --- a/backlog/completed/task-81 - Tokenization-performance-disable-yomitan-mecab-and-persistent-local-mecab.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-81 -title: 'Tokenization performance: disable Yomitan MeCab parser, gate local MeCab init, and add persistent MeCab process' -status: Done -assignee: [] -created_date: '2026-03-02 07:44' -updated_date: '2026-03-02 20:44' -labels: [] -dependencies: [] -priority: high -ordinal: 9001 ---- - -## Description - - - -Reduce subtitle annotation latency by: - -- disabling Yomitan-side MeCab parser requests (`useMecabParser=false`); -- initializing local MeCab only when POS-dependent annotations are enabled (N+1 / JLPT / frequency); -- replacing per-line local MeCab process spawning with a persistent parser process that auto-shuts down after idle time and restarts on demand. - - - -## Acceptance Criteria - - - -- [x] #1 Yomitan parse requests disable MeCab parser path. -- [x] #2 MeCab warmup/init is skipped when all POS-dependent annotation toggles are off. -- [x] #3 Local MeCab tokenizer uses persistent process across subtitle lines. -- [x] #4 Persistent MeCab process auto-shuts down after idle timeout and restarts on next tokenize activity. -- [x] #5 Tests cover parser flag, warmup gating, and persistent MeCab lifecycle behavior. - - - -## Final Summary - - - -Implemented tokenizer latency optimizations: - -- switched Yomitan parse requests to `useMecabParser: false`; -- added annotation-aware MeCab initialization gating in runtime warmup flow; -- added persistent local MeCab process (default idle shutdown: 30s) with queued requests, retry-on-process-end, idle auto-shutdown, and automatic restart on new work; -- added regression tests for Yomitan parse flag, MeCab warmup gating, and persistent/idle lifecycle behavior; -- fixed tokenization warmup gate so first-use warmup completion is sticky (`tokenizationWarmupCompleted`) and sequential `tokenizeSubtitle` calls no longer re-run Yomitan/dictionary warmup path; -- added regression coverage in `src/main/runtime/composers/mpv-runtime-composer.test.ts` for sequential tokenize calls (`warmup` side effects run once); -- post-review critical fix: treat Yomitan default-profile Anki server sync `no-change` as successful check, so `lastSyncedYomitanAnkiServer` is cached and expensive sync checks do not repeat on every subtitle line; -- added regression assertion in `src/core/services/tokenizer/yomitan-parser-runtime.test.ts` for `updated: false` path returning sync success; -- post-review performance fix: refactored POS enrichment to pre-index MeCab tokens by surface plus character-position overlap index, replacing repeated active-candidate filtering/full-scan behavior with direct overlap candidate lookup per token; -- added regression tests in `src/core/services/tokenizer/parser-enrichment-stage.test.ts` for repeated distant-token scan access and repeated active-candidate filter scans; both fail on scan-based behavior and pass with indexed lookup; -- post-review startup fix: moved JLPT/frequency dictionary initialization from synchronous FS APIs to async `fs/promises` path inspection/read and cooperative chunked entry processing to reduce main-thread stall risk during cold start; -- post-review first-line latency fix: decoupled tokenization warmup gating so first `tokenizeSubtitle` only waits on Yomitan extension readiness, while MeCab check + dictionary prewarm continue in parallel background warmups; -- validated with targeted tests and `tsc --noEmit`. - - diff --git a/backlog/completed/task-82 - Subtitle-frequency-highlighting-fixes-for-noisy-readings-and-known-token-color-priority.md b/backlog/completed/task-82 - Subtitle-frequency-highlighting-fixes-for-noisy-readings-and-known-token-color-priority.md deleted file mode 100644 index d7b43b94..00000000 --- a/backlog/completed/task-82 - Subtitle-frequency-highlighting-fixes-for-noisy-readings-and-known-token-color-priority.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-82 -title: 'Subtitle frequency highlighting: fix noisy Yomitan readings and restore known/N+1 color priority' -status: Done -assignee: [] -created_date: '2026-03-02 20:10' -updated_date: '2026-03-02 01:44' -labels: [] -dependencies: [] -priority: high -ordinal: 9002 ---- - -## Description - - - -Address frequency-highlighting regressions: - -- tokens like `断じて` missed rank assignment when Yomitan merged-token reading was truncated/noisy; -- known/N+1 tokens were incorrectly colored by frequency color instead of known/N+1 color. - -Expected behavior: - -- known/N+1 color always wins; -- if token is frequent and within `topX`, frequency rank label can still appear on hover/metadata. - - - -## Acceptance Criteria - - - -- [x] #1 Frequency lookup succeeds for noisy/truncated merged-token readings via robust fallback behavior. -- [x] #2 Merged-token reading normalization restores missing kana suffixes where safe (`headword === surface` path). -- [x] #3 Known/N+1 tokens keep known/N+1 color classes; frequency color class does not override them. -- [x] #4 Frequency rank hover label remains available for in-range frequent tokens, including known/N+1. -- [x] #5 Regression tests added for tokenizer and renderer behavior. - - - -## Final Summary - - - -Implemented and validated: - -- tokenizer now normalizes selected Yomitan merged-token readings by appending missing trailing kana suffixes when safe (`headword === surface`); -- frequency lookup now does lazy fallback: requests `{term, reading}` first, and only requests `{term, reading: null}` for misses; -- this removes eager `(term, null)` payload inflation on medium-frequency lines and reduces extension RPC payload/load; -- renderer restored known/N+1 color priority over frequency class coloring; -- frequency rank label display remains available for frequent known/N+1 tokens; -- added regression tests covering noisy-reading fallback, lazy fallback-query behavior, and renderer class/label precedence. - -Related commits: - -- `17a417e` (`fix(subtitle): improve frequency highlight reliability`) -- `79f37f3` (`fix(subtitle): prioritize known and n+1 colors over frequency`) - - diff --git a/backlog/completed/task-83 - Jellyfin-subtitle-delay-shift-to-adjacent-cue-without-seek-jumps.md b/backlog/completed/task-83 - Jellyfin-subtitle-delay-shift-to-adjacent-cue-without-seek-jumps.md deleted file mode 100644 index 66e7d495..00000000 --- a/backlog/completed/task-83 - Jellyfin-subtitle-delay-shift-to-adjacent-cue-without-seek-jumps.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-83 -title: 'Jellyfin subtitle delay: shift to adjacent cue without seek jumps' -status: Done -assignee: [] -created_date: '2026-03-02 00:06' -updated_date: '2026-03-02 00:06' -labels: [] -dependencies: [] -priority: high -ordinal: 9003 ---- - -## Description - - - -Add keybinding-friendly special commands that shift `sub-delay` to align current subtitle start with next/previous cue start, without `sub-seek` probing (avoid playback jump). - -Scope: - -- add special commands for next/previous line alignment; -- compute delta from active subtitle cue timeline (external subtitle file/URL, including Jellyfin-delivered URLs); -- apply `add sub-delay ` and show OSD value; -- keep existing proxy OSD behavior for direct `sub-delay` keybinding commands. - - - -## Acceptance Criteria - - - -- [x] #1 New special commands exist for subtitle-delay shift to next/previous cue boundary. -- [x] #2 Shift logic parses active external subtitle source timings (SRT/VTT/ASS) and computes delta from current `sub-start`. -- [x] #3 Runtime applies delay shift without `sub-seek` and shows OSD feedback. -- [x] #4 Direct `sub-delay` proxy commands also show OSD current value. -- [x] #5 Tests added for cue parsing/shift behavior and IPC dispatch wiring. - - - -## Final Summary - - - -Implemented no-jump subtitle-delay alignment commands: - -- added `__sub-delay-next-line` and `__sub-delay-prev-line` special commands; -- added `createShiftSubtitleDelayToAdjacentCueHandler` to parse cue start times from active external subtitle source and apply `add sub-delay` delta from current `sub-start`; -- wired command handling through IPC runtime deps into main runtime; -- retained/extended OSD proxy feedback for `sub-delay` keybindings; -- updated configuration docs and added regression tests for subtitle-delay shift and IPC command routing. - - diff --git a/backlog/completed/task-84 - Migrate-AniSkip-metadatalookup-orchestration-to-launcher-Electron.md b/backlog/completed/task-84 - Migrate-AniSkip-metadatalookup-orchestration-to-launcher-Electron.md deleted file mode 100644 index 7fc1ffb7..00000000 --- a/backlog/completed/task-84 - Migrate-AniSkip-metadatalookup-orchestration-to-launcher-Electron.md +++ /dev/null @@ -1,64 +0,0 @@ ---- -id: TASK-84 -title: Migrate AniSkip metadata+lookup orchestration to launcher/Electron -status: Done -assignee: - - Codex -created_date: '2026-03-03 08:31' -updated_date: '2026-03-16 05:13' -labels: - - enhancement - - aniskip - - launcher - - mpv-plugin -dependencies: [] -references: - - launcher/aniskip-metadata.ts - - launcher/mpv.ts - - plugin/subminer/aniskip.lua - - plugin/subminer/options.lua - - plugin/subminer/state.lua - - plugin/subminer/lifecycle.lua - - plugin/subminer/messages.lua - - plugin/subminer.conf - - launcher/aniskip-metadata.test.ts -documentation: - - docs/mpv-plugin.md - - launcher/aniskip-metadata.ts - - plugin/subminer/aniskip.lua - - docs/architecture.md -priority: medium -ordinal: 97500 ---- - -## Description - - -Move AniSkip MAL/title-to-MAL lookup and intro payload resolution from mpv Lua to launcher Electron flow, while keeping mpv-side intro skip UX and chapter/chapter prompt behavior in plugin. Launcher should infer/analyze file metadata, fetch AniSkip payload when launching files, and pass resolved skip window via script options; plugin should trust launcher payload and fall back only when absent. - - -## Acceptance Criteria - -- [x] #1 Launcher infers AniSkip metadata for file targets using existing guessit/fallback logic and performs AniSkip MAL + payload resolution during mpv startup. -- [x] #2 Launcher injects script options containing resolved MAL id and intro window fields (or explicit lookup-failure status) into mpv startup. -- [x] #3 Lua plugin consumes launcher-provided AniSkip intro data and skips all network lookups when payload is present. -- [x] #4 Standalone mpv/plugin usage without launcher payload continues to function using existing async in-plugin lookup path. -- [x] #5 Docs and defaults are updated to document new script-option contract. -- [x] #6 Launcher tests cover payload generation contract and fallback behavior where metadata is unavailable. - - -## Implementation Plan - - -1. Add launcher-side AniSkip payload resolution helpers in launcher/aniskip-metadata.ts (MAL prefix lookup + AniSkip payload fetch + result normalization). -2. Wire launcher/mpv.ts + buildSubminerScriptOpts to pass resolved AniSkip fields/mode in --script-opts for file playback. -3. Update plugin/subminer/aniskip.lua plus options/state to consume injected payload: if intro_start/end present, apply immediately and skip network lookup; otherwise retain existing async behavior. -4. Ensure fallback for standalone mpv usage remains intact for no-launcher/manual refresh. -5. Add/update tests/docs/config references for new script-opt contract and edge cases. - - -## Final Summary - - -Executed end-to-end migration so launcher resolves AniSkip title/MAL/payload before mpv start and injects it via --script-opts. Plugin now parses and consumes launcher payload (JSON/url/base64), applies OP intro from payload, tracks payload metadata in state, and keeps legacy async lookup path for non-launcher/absent payload playback. Added launcher config key aniskip_payload and updated launcher/aniskip-metadata tests for resolve/payload behavior and contract validation. - diff --git a/backlog/completed/task-85 - Add-launcher-dictionary-subcommand-and-initial-AniList-character-dictionary-zip-generation.md b/backlog/completed/task-85 - Add-launcher-dictionary-subcommand-and-initial-AniList-character-dictionary-zip-generation.md deleted file mode 100644 index 9505679d..00000000 --- a/backlog/completed/task-85 - Add-launcher-dictionary-subcommand-and-initial-AniList-character-dictionary-zip-generation.md +++ /dev/null @@ -1,51 +0,0 @@ ---- -id: TASK-85 -title: >- - Add launcher dictionary subcommand and initial AniList character dictionary - zip generation -status: Done -assignee: [] -created_date: '2026-03-03 08:47' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -priority: high -ordinal: 96500 ---- - -## Description - - -Implement initial character dictionary flow: launcher `dictionary` subcommand, app `--dictionary` command, AniList media resolution from current playback, Yomitan zip generation to local file, and local cache to avoid repeated API fetches for same AniList id. Manual Yomitan import path only in this phase. - - -## Acceptance Criteria - -- [x] #1 Launcher supports `dictionary` (and alias) and forwards to app command path. -- [x] #2 App CLI accepts `--dictionary` and dispatches to dictionary runtime command. -- [x] #3 Dictionary command resolves current anime to AniList id, generates Yomitan-compatible zip, and logs output path for manual load. -- [x] #4 Generated dictionaries are cached by AniList id so repeated commands reuse existing zip when available. -- [x] #5 Backlog task is updated with implementation notes and completion summary for this phase. - - -## Implementation Notes - - -Implemented launcher `dictionary`/`dict` subcommand parsing and normalized args flow (`launcher/config/cli-parser-builder.ts`, `launcher/config/args-normalizer.ts`, `launcher/types.ts`). - -Added launcher command dispatch (`launcher/commands/dictionary-command.ts`) and wired `launcher/main.ts` to forward `--dictionary` (plus non-default `--log-level`) to app binary. - -Added app CLI flag `--dictionary` in parser/help and startup routing (`src/cli/args.ts`, `src/cli/help.ts`). - -Added dictionary runtime service (`src/main/character-dictionary-runtime.ts`) that resolves AniList media id from current playback guess, fetches AniList character edges, builds Yomitan-compatible banks/index, writes zip, and caches by AniList id in user data. - -Threaded dictionary generation dependency through CLI runtime/context builders and `src/main.ts` context composition so command executes from launcher/app entrypoints. - -Added/updated tests for parser, command modules, launcher main forwarding, CLI command dispatch, and context/deps wiring. Updated docs for launcher/usage command lists to include dictionary subcommand. - - -## Final Summary - - -Initial phase shipped: `subminer dictionary` now routes to `SubMiner.AppImage --dictionary`, generates a Yomitan-importable character dictionary zip for the current anime (AniList-based), logs zip output path for manual import, and reuses cached zips by AniList id to avoid repeated API fetches. - diff --git a/backlog/completed/task-85 - Remove-docs-plausible-analytics-integration.md b/backlog/completed/task-85 - Remove-docs-plausible-analytics-integration.md deleted file mode 100644 index d0b5afe4..00000000 --- a/backlog/completed/task-85 - Remove-docs-plausible-analytics-integration.md +++ /dev/null @@ -1,38 +0,0 @@ ---- -id: TASK-85 -title: 'Remove docs Plausible analytics integration' -status: Done -assignee: [] -created_date: '2026-03-03 00:00' -updated_date: '2026-03-03 00:00' -labels: [] -dependencies: [] -priority: medium -ordinal: 12001 ---- - -## Description - - - -Remove Plausible analytics integration from docs theme and dependency graph. Keep docs build/runtime analytics-free. - - - -## Acceptance Criteria - - - -- [x] #1 Docs theme no longer imports or initializes Plausible tracker. -- [x] #2 `@plausible-analytics/tracker` removed from dependencies and lockfile. -- [x] #3 Docs analytics test reflects absence of Plausible wiring. - - - -## Final Summary - - - -Deleted Plausible runtime wiring from VitePress theme, removed tracker package via `bun remove`, and updated docs test to assert no Plausible integration remains. - - diff --git a/backlog/completed/task-85.1 - Address-PR-14-character-dictionary-review-follow-ups.md b/backlog/completed/task-85.1 - Address-PR-14-character-dictionary-review-follow-ups.md deleted file mode 100644 index 9639c17a..00000000 --- a/backlog/completed/task-85.1 - Address-PR-14-character-dictionary-review-follow-ups.md +++ /dev/null @@ -1,65 +0,0 @@ ---- -id: TASK-85.1 -title: 'Address PR #14 character dictionary review follow-ups' -status: Done -assignee: - - codex -created_date: '2026-03-06 07:48' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/launcher/commands/dictionary-command.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts - - /home/sudacode/projects/japanese/SubMiner/launcher/types.ts -documentation: - - 'https://docs.anilist.co/guide/rate-limiting' -parent_task_id: TASK-85 -ordinal: 93500 ---- - -## Description - - -Apply the accepted follow-up fixes from Claude's PR review for the AniList character dictionary work: remove dead launcher code, deduplicate video extension handling where practical, and add explicit pacing for AniList character-page requests / character image downloads so the integration stays within AniList rate-limiting expectations. - - -## Acceptance Criteria - -- [x] #1 Launcher dictionary command no longer contains unreachable dead code after the app handoff. -- [x] #2 Character dictionary runtime no longer maintains a separate ad hoc video extension list when existing shared extension data can be reused safely. -- [x] #3 Character dictionary generation spaces outbound AniList-related requests with explicit named delays, and tests cover the pacing behavior and unchanged command forwarding behavior. - - -## Implementation Plan - - -1. Add failing tests for dictionary command handoff semantics and dictionary runtime request pacing. -2. Remove unreachable boolean return path from the launcher dictionary command while preserving call sites. -3. Reuse the shared launcher video extension set inside the character dictionary runtime with extname normalization, then add named AniList pacing constants for page fetches and character image downloads. -4. Run targeted tests, then broader relevant test slices, and update acceptance criteria / notes with the validated result. - - -## Implementation Notes - - -Added a shared `src/shared/video-extensions.ts` source and rewired both launcher/runtime consumers to remove the duplicated runtime extension list. - -Replaced the hardcoded AniList page sleep with a per-generation AniList request pacer (2000ms between API requests) plus 250ms spacing between character image download attempts, including failed image fetches. - -Hardened `runDictionaryCommand` so an unexpected return from the `never`-typed app handoff throws immediately instead of silently falling through. - -Validated with targeted and adjacent test slices plus `bun run tsc --noEmit`. - - -## Final Summary - - -Removed the dead post-handoff return from the launcher dictionary command and replaced it with an explicit invariant error if the `never`-typed app handoff ever returns unexpectedly. Extracted video extension data into `src/shared/video-extensions.ts` so the launcher and character dictionary runtime share one source of truth. - -Adjusted character dictionary generation to use a per-run AniList request pacer with a conservative 2000ms delay between AniList API calls, and added 250ms spacing between character image download attempts so repeated image fetches are not bursty even when an image URL fails. Added regression coverage for the pacing behavior and the launcher handoff invariant. - -Validation: `bun test src/main/character-dictionary-runtime.test.ts`, `bun test launcher/commands/command-modules.test.ts`, `bun test launcher/main.test.ts launcher/parse-args.test.ts src/cli/args.test.ts src/core/services/cli-command.test.ts src/main/runtime/character-dictionary-auto-sync.test.ts`, `bun run tsc --noEmit`. - diff --git a/backlog/completed/task-86 - Require-target-path-for-launcher-dictionary-command-and-forward-dictionary-target-to-app-runtime.md b/backlog/completed/task-86 - Require-target-path-for-launcher-dictionary-command-and-forward-dictionary-target-to-app-runtime.md deleted file mode 100644 index 82ca2168..00000000 --- a/backlog/completed/task-86 - Require-target-path-for-launcher-dictionary-command-and-forward-dictionary-target-to-app-runtime.md +++ /dev/null @@ -1,55 +0,0 @@ ---- -id: TASK-86 -title: >- - Require target path for launcher dictionary command and forward dictionary - target to app runtime -status: Done -assignee: [] -created_date: '2026-03-03 09:22' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -priority: high -ordinal: 95500 ---- - -## Description - - -Change dictionary flow so launcher uses `subminer dictionary ` and forwards target to app without playback launch. Keep direct app `--dictionary` behavior for in-session/mpv-triggered use, adding optional `--dictionary-target` path override. - - -## Acceptance Criteria - -- [x] #1 Launcher `dictionary`/`dict` requires a target path argument and parses optional log level. -- [x] #2 Launcher forwards target to app as `--dictionary-target ` together with `--dictionary`. -- [x] #3 App CLI parses optional `--dictionary-target` and dictionary command passes it into dictionary runtime. -- [x] #4 Dictionary runtime resolves explicit file/directory target for AniList guess flow; falls back to current playback when target is absent. -- [x] #5 Docs/tests are updated for new launcher invocation syntax. - - -## Implementation Notes - - -Launcher dictionary subcommand now requires a positional target path (`subminer dictionary ` / `dict `) via commander argument wiring in `launcher/config/cli-parser-builder.ts`. - -Added `dictionaryTarget` flow in launcher normalization/types and path validation (must be existing local file or directory) in `launcher/config/args-normalizer.ts`. - -Launcher dictionary command now forwards `--dictionary --dictionary-target ` to app binary in `launcher/commands/dictionary-command.ts`. - -App CLI now parses optional `--dictionary-target` in `src/cli/args.ts`; dictionary handler passes target through to runtime in `src/core/services/cli-command.ts`. - -Dictionary runtime now resolves explicit target inputs in `src/main/character-dictionary-runtime.ts`: file target uses file path/title; directory target selects first video file recursively (fallback to directory name), and still falls back to current playback when target is absent. - -Updated context/dependency pass-through for dictionary target argument (`src/main.ts`, `src/main/runtime/cli-command-context-main-deps.ts`). - -Updated tests/docs for new syntax and forwarding behavior (`launcher/main.test.ts`, `launcher/parse-args.test.ts`, `launcher/commands/command-modules.test.ts`, `src/cli/args.test.ts`, `src/cli/help.test.ts`, `docs/usage.md`, `docs/launcher-script.md`). - -Follow-up noise reduction: dictionary commands now opt into lightweight startup path by extending `shouldSkipHeavyStartup` in `src/main.ts` to include `initialArgs.dictionary`. This skips heavy app-ready initialization (mpv client creation/background warmups/overlay bootstrap) for dictionary CLI runs. - - -## Final Summary - - -Launcher dictionary flow now uses explicit targets: run `subminer dictionary `. It forwards target to app and performs dictionary generation without depending on currently playing media. Direct app `--dictionary` remains available for in-session/mpv-triggered workflows, with optional `--dictionary-target` override support. - diff --git a/backlog/completed/task-87.1 - Testing-workflow-make-standard-test-commands-reflect-the-maintained-test-surface.md b/backlog/completed/task-87.1 - Testing-workflow-make-standard-test-commands-reflect-the-maintained-test-surface.md deleted file mode 100644 index 1cd55df7..00000000 --- a/backlog/completed/task-87.1 - Testing-workflow-make-standard-test-commands-reflect-the-maintained-test-surface.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-87.1 -title: >- - Testing workflow: make standard test commands reflect the maintained test - surface -status: Done -assignee: - - OpenCode -created_date: '2026-03-06 03:19' -updated_date: '2026-03-16 05:13' -labels: - - tests - - maintainability -milestone: m-0 -dependencies: [] -references: - - package.json - - src/main-entry-runtime.test.ts - - src/anki-integration/anki-connect-proxy.test.ts - - src/main/runtime/jellyfin-remote-playback.test.ts - - src/main/runtime/registry.test.ts -documentation: - - docs/reports/2026-02-22-task-100-dead-code-report.md -parent_task_id: TASK-87 -priority: high -ordinal: 86500 ---- - -## Description - - -The current package scripts hand-enumerate a small subset of test files, which leaves the standard green signal misleading. A local audit found 241 test/type-test files under src/ and launcher/, but only 53 unique files referenced by the standard package.json test scripts. This task should redesign the runnable test matrix so maintained tests are either executed by the standard commands or intentionally excluded through a documented rule, instead of silently drifting out of coverage. - - -## Acceptance Criteria - -- [x] #1 The repository has a documented and reproducible test matrix for standard development commands, including which suites belong in the default lane versus slower or environment-specific lanes. -- [x] #2 The standard test entrypoints stop relying on a brittle hand-maintained allowlist for the currently covered unit and integration suites, or an explicit documented mechanism exists that prevents silent omission of new tests. -- [x] #3 Representative tests that were previously outside the standard lane from src/main/runtime, src/anki-integration, and entry/runtime surfaces are executed by an automated command and included in the documented matrix. -- [x] #4 Documentation for contributors explains which command to run for fast verification, full verification, and environment-specific verification. - - -## Implementation Plan - - -1. Update `package.json` to replace the current file-by-file test allowlists with a documented lane matrix: keep `test`/`test:fast` as the quick default lane, add `test:full` for the maintained source test surface, and add `test:env` for slower or environment-specific checks. -2. Use directory-based discovery for maintained suites so new tests under stable surfaces such as `src/main`, `src/anki-integration`, and `launcher` are not silently omitted by default script maintenance. -3. Split environment-specific verification into explicit commands for checks such as launcher smoke/plugin coverage and sqlite-gated tests, instead of leaving them undocumented or mixed into the default signal. -4. Update `README.md` with a contributor-facing testing matrix that explains fast, full, and environment-specific verification, including any prerequisites or expected skip behavior. -5. Verify the matrix by running representative targeted tests plus the documented lane commands, demonstrating that previously omitted entry/runtime, Anki integration, and main runtime tests now belong to automated commands. - - -## Implementation Notes - - -Reviewed task context via Backlog MCP plus repo audit. Current package.json test scripts still rely on hand-maintained file allowlists and omit large maintained areas including src/main/runtime, src/anki-integration, and src/main-entry-runtime.test.ts. Preparing an implementation plan and contributor-facing test matrix update before code changes. - -Saved detailed implementation plan to docs/plans/2026-03-06-testing-workflow-test-matrix.md and recorded the approved direction in the Backlog task before implementation. - -Implemented a lane-based test matrix. Added `scripts/run-test-lane.mjs` so Bun-managed `src/**` and launcher unit lanes discover files automatically while excluding a small explicit Node-only set instead of relying on large hand-maintained allowlists. Added `test:node:compat` for `ipc`, `anki-jimaku-ipc`, `overlay-manager`, `config-validation`, `startup-config`, and `registry` suites, kept `test:env` for launcher smoke/plugin plus SQLite-backed immersion checks, and updated `README.md` with the contributor-facing matrix and exclusions. - -Validated the new matrix with `bun run test:fast`, `bun run test:full`, `bun run test:env`, `bun run test:src`, `bun run test:launcher:unit:src`, `bun run test:node:compat`, and targeted `bun test src/core/services/anilist/anilist-updater.test.ts`. Representative previously omitted surfaces now run through automated commands: `src/main-entry-runtime.test.ts` via `test:fast`, `src/anki-integration/anki-connect-proxy.test.ts` via `test:fast`/`test:src`, and `src/main/runtime/registry.test.ts` via `test:node:compat`/`test:full`. - - -## Final Summary - - -Reworked the repository test matrix so standard commands reflect the maintained test surface without relying on brittle file allowlists. Added automated Bun discovery lanes for Bun-compatible `src/**` and launcher unit suites, a documented Node compatibility lane for Electron/sqlite-sensitive tests, and updated the contributor docs with fast/full/environment-specific guidance plus explicit exclusions. Verified with `bun run test:fast`, `bun run test:full`, and `bun run test:env`, along with the component lanes and targeted regression coverage for the updated AniList guessit test seam. - diff --git a/backlog/completed/task-87.2 - Subtitle-sync-verification-replace-the-no-op-subtitle-lane-with-real-automated-coverage.md b/backlog/completed/task-87.2 - Subtitle-sync-verification-replace-the-no-op-subtitle-lane-with-real-automated-coverage.md deleted file mode 100644 index e92a31f8..00000000 --- a/backlog/completed/task-87.2 - Subtitle-sync-verification-replace-the-no-op-subtitle-lane-with-real-automated-coverage.md +++ /dev/null @@ -1,87 +0,0 @@ ---- -id: TASK-87.2 -title: >- - Subtitle sync verification: replace the no-op subtitle lane with real - automated coverage -status: Done -assignee: - - Kyle Yasuda -created_date: '2026-03-06 03:19' -updated_date: '2026-03-16 05:13' -labels: - - tests - - subsync -milestone: m-0 -dependencies: [] -references: - - package.json - - README.md - - src/core/services/subsync.ts - - src/core/services/subsync.test.ts - - src/subsync/utils.ts -documentation: - - docs/reports/2026-02-22-task-100-dead-code-report.md -parent_task_id: TASK-87 -priority: high -ordinal: 92500 ---- - -## Description - - -SubMiner advertises subtitle syncing with alass and ffsubsync, but the dedicated test:subtitle command currently does not run any tests. There is already lower-level coverage in src/core/services/subsync.test.ts, but the test matrix and contributor-facing commands do not reflect that reality. This task should replace the no-op lane with real verification, align scripts with the existing subsync test surface, and make the user-facing docs honest about how subtitle sync is verified. - - -## Acceptance Criteria - -- [x] #1 The test:subtitle entrypoint runs real automated verification instead of echoing a placeholder message. -- [x] #2 The subtitle verification lane covers both alass and ffsubsync behavior, including at least one non-happy-path scenario relevant to current functionality. -- [x] #3 Contributor-facing documentation points to the real subtitle verification command and no longer implies a dedicated test lane exists when it does not. -- [x] #4 The resulting verification strategy integrates cleanly with the repository-wide test matrix without duplicating or hiding existing subsync coverage. - - -## Implementation Plan - - -Plan of record: - -1. Replace the placeholder package-script lane with a real `test:subtitle:src` command that runs the maintained subtitle-sync tests directly (`src/core/services/subsync.test.ts` and `src/subsync/utils.test.ts`), and point `test:subtitle` at that lane instead of build+echo behavior. -2. Add one focused ffsubsync non-happy-path test in `src/core/services/subsync.test.ts` so the dedicated lane explicitly covers both engines plus failure propagation relevant to current functionality. -3. Update `README.md` contributor guidance to name `bun run test:subtitle` as the subtitle verification command and explain that it reuses the maintained subsync tests already included in broader core coverage. -4. Verify the final strategy by running `bun run test:subtitle` and `bun run test:core:src` so the dedicated lane stays aligned with the repository-wide matrix instead of creating a divergent hidden suite. - -Detailed execution plan saved at `docs/plans/2026-03-06-subtitle-sync-verification.md`. - - -## Implementation Notes - - -Reviewed task references and current subtitle verification surface. Existing coverage already lives in `src/core/services/subsync.test.ts` and `src/subsync/utils.test.ts`; `test:subtitle` is still a placeholder build+echo wrapper. The referenced report `docs/reports/2026-02-22-task-100-dead-code-report.md` is not present in the workspace, so planning used the task body plus repository state instead. - -Implementation plan written and saved to `docs/plans/2026-03-06-subtitle-sync-verification.md`. Proceeding with execution per the task request. - -Replaced the placeholder subtitle lane with `test:subtitle:src` in `package.json`, pointing `test:subtitle` directly at `src/core/services/subsync.test.ts` and `src/subsync/utils.test.ts` instead of build+echo behavior. - -Added explicit ffsubsync failure-path coverage in `src/core/services/subsync.test.ts`, asserting non-zero command failures surface detailed `ffsubsync synchronization failed` messaging alongside existing alass coverage. - -Updated `README.md` verification guidance to point contributors at `bun run test:subtitle` and explain that the lane reuses the maintained subsync tests already included in `bun run test:core`. - -Verification: `bun run test:subtitle` passed (15 tests across 2 files). `bun run test:core:src` also passed (373 pass, 6 skip, 0 fail), confirming the dedicated subtitle lane stays aligned with the broader matrix. - - -## Final Summary - - -Implemented a real subtitle verification lane by replacing the placeholder `test:subtitle` build+echo flow with a source-level `test:subtitle:src` command that runs the maintained subtitle-sync tests directly from `src/core/services/subsync.test.ts` and `src/subsync/utils.test.ts`. This keeps subtitle verification explicit for contributors while still reusing the same maintained test surface already covered by `test:core`. - -Expanded subtitle-sync coverage with an explicit ffsubsync failure-path test so the dedicated lane now exercises both engines plus a user-visible non-happy path. Updated `README.md` to document `bun run test:subtitle` as the contributor-facing subtitle verification command and to explain its relationship to the broader core suite. - -Verification run: - -- `bun run test:subtitle` -- `bun run test:core:src` - -Notes: - -- The task reference `docs/reports/2026-02-22-task-100-dead-code-report.md` was not present in the workspace during execution, so implementation used the task body and live repository state as the source of truth. - diff --git a/backlog/completed/task-87.3 - Immersion-tracking-verification-make-SQLite-backed-persistence-tests-visible-and-reproducible.md b/backlog/completed/task-87.3 - Immersion-tracking-verification-make-SQLite-backed-persistence-tests-visible-and-reproducible.md deleted file mode 100644 index 68208cef..00000000 --- a/backlog/completed/task-87.3 - Immersion-tracking-verification-make-SQLite-backed-persistence-tests-visible-and-reproducible.md +++ /dev/null @@ -1,76 +0,0 @@ ---- -id: TASK-87.3 -title: >- - Immersion tracking verification: make SQLite-backed persistence tests visible - and reproducible -status: Done -assignee: - - Kyle Yasuda -created_date: '2026-03-06 03:19' -updated_date: '2026-03-16 05:13' -labels: - - tests - - immersion-tracking -milestone: m-0 -dependencies: [] -references: - - src/core/services/immersion-tracker-service.test.ts - - src/core/services/immersion-tracker/storage-session.test.ts - - src/core/services/immersion-tracker-service.ts - - package.json -documentation: - - docs/reports/2026-02-22-task-100-dead-code-report.md -parent_task_id: TASK-87 -priority: medium -ordinal: 90500 ---- - -## Description - - -The immersion tracker is persistence-heavy, but its SQLite-backed tests are conditionally skipped in the standard Bun run when node:sqlite support is unavailable. That creates a blind spot around session finalization, telemetry persistence, and retention behavior. This task should establish a reliable automated verification path for the database-backed cases and make the prerequisite/runtime behavior explicit to contributors and CI. - - -## Acceptance Criteria - -- [x] #1 Database-backed immersion tracking tests run in at least one documented automated command that is practical for contributors or CI to execute. -- [x] #2 If the current runtime cannot execute the SQLite-backed tests, the repository exposes that limitation clearly instead of silently reporting a misleading green result. -- [x] #3 Contributor-facing documentation explains how to run the immersion tracker verification lane and any environment prerequisites it depends on. -- [x] #4 The resulting verification covers session persistence or finalization behavior that is not exercised by the pure seam tests alone. - - -## Implementation Plan - - -Implementation plan recorded in `docs/plans/2026-03-06-immersion-sqlite-verification.md`. - -1. Update `src/core/services/immersion-tracker-service.test.ts` and `src/core/services/immersion-tracker/storage-session.test.ts` so unsupported `node:sqlite` runtimes emit an explicit skip reason instead of a silent top-level skip alias. -2. Add a dedicated `package.json` SQLite verification lane that runs both immersion persistence suites together under a runtime with `node:sqlite` support, likely via built `dist/**` tests executed by Node. -3. Wire that lane into `.github/workflows/ci.yml` and `.github/workflows/release.yml` so automated verification includes a real DB-backed persistence/finalization check. -4. Document the new command, prerequisites, and coverage in `README.md`, including the distinction between Bun's default lane and the reproducible SQLite lane. -5. Validate the final lane by running the dedicated command and confirming it exercises persistence/finalization behavior beyond the seam-only tests. - -Execution adjustment: the reproducible lane uses `node --experimental-sqlite --test ...` because Node 22 exposes `node:sqlite` behind the experimental flag. Running that lane also exposed placeholder-count mismatches in `src/core/services/immersion-tracker/storage.ts`, so the final implementation includes a small SQL placeholder fix required for the new cross-runtime verification path. - - -## Implementation Notes - - -Confirmed Bun 1.3.5 lacks `node:test` `t.skip()` support, so explicit unsupported-runtime messaging is surfaced with file-level warnings while the SQLite-backed tests remain conditionally skipped. - -Added `test:immersion:sqlite:src`, `test:immersion:sqlite:dist`, and `test:immersion:sqlite` scripts; the source lane now prints explicit warnings when `node:sqlite` is unavailable, and the dist lane runs both SQLite-backed immersion suites under Node with `--experimental-sqlite`. - -Wired the dist SQLite lane into `.github/workflows/ci.yml` and `.github/workflows/release.yml` after the bundle build, with explicit `actions/setup-node@v4` provisioning for Node 22.12.0. - -Fixed SQL prepared-statement placeholder counts in `src/core/services/immersion-tracker/storage.ts`, which the new Node-backed SQLite lane surfaced immediately. - -Verification: `bun run test:immersion:sqlite:src` -> pass with explicit unsupported-runtime warnings and 10 skips under Bun 1.3.5; `bun run test:immersion:sqlite` -> pass with 14/14 tests under Node 22.12.0 + `--experimental-sqlite`. - - -## Final Summary - - -Added an explicit SQLite-backed immersion verification lane and documented it so persistence-heavy coverage is no longer hidden behind Bun-only skips. `package.json` now exposes source and dist SQLite scripts, the source test files print actionable warnings when `node:sqlite` is unavailable, and `README.md` explains the dedicated contributor command plus its Node 22 `--experimental-sqlite` prerequisite. - -Automated verification now includes the new dist lane in both `.github/workflows/ci.yml` and `.github/workflows/release.yml` after build output is available. While wiring the reproducible Node lane, it exposed placeholder-count mismatches in `src/core/services/immersion-tracker/storage.ts`; fixing those placeholders makes the SQLite-backed persistence/finalization tests pass cross-runtime, covering session finalization, telemetry persistence, and storage-session write paths. - diff --git a/backlog/completed/task-87.4 - Runtime-composition-root-remove-dead-symbols-and-tighten-module-boundaries-in-src-main.ts.md b/backlog/completed/task-87.4 - Runtime-composition-root-remove-dead-symbols-and-tighten-module-boundaries-in-src-main.ts.md deleted file mode 100644 index b8b553d3..00000000 --- a/backlog/completed/task-87.4 - Runtime-composition-root-remove-dead-symbols-and-tighten-module-boundaries-in-src-main.ts.md +++ /dev/null @@ -1,59 +0,0 @@ ---- -id: TASK-87.4 -title: >- - Runtime composition root: remove dead symbols and tighten module boundaries in - src/main.ts -status: Done -assignee: [] -created_date: '2026-03-06 03:19' -updated_date: '2026-03-16 05:13' -labels: - - tech-debt - - runtime - - maintainability -milestone: m-0 -dependencies: - - TASK-87.1 -references: - - src/main.ts - - src/main/runtime - - package.json -documentation: - - docs/reports/2026-02-22-task-100-dead-code-report.md -parent_task_id: TASK-87 -priority: high -ordinal: 78500 ---- - -## Description - - -A noUnusedLocals/noUnusedParameters compile pass reports a large concentration of dead imports and dead locals in src/main.ts. The file is also far beyond the repo’s preferred size guideline, which makes the runtime composition root difficult to review and easy to break. This task should remove confirmed dead symbols, continue extracting coherent slices where that improves readability, and leave the entrypoint materially easier to understand without changing behavior. - - -## Acceptance Criteria - -- [x] #1 src/main.ts no longer emits dead-symbol diagnostics under a noUnusedLocals/noUnusedParameters compile pass for the areas touched by this cleanup. -- [x] #2 Unused imports, destructured values, and stale locals identified in the current composition root are removed or relocated without behavior changes. -- [x] #3 The resulting composition root has clearer ownership boundaries for at least one runtime slice that is currently buried in the monolith. -- [x] #4 Relevant runtime and startup verification commands pass after the cleanup, and any command changes are documented if needed. - - -## Implementation Plan - - -1. Re-run the noUnusedLocals/noUnusedParameters compile pass and capture the src/main.ts diagnostics cluster before editing. -2. Remove dead imports, destructured values, and stale locals in small reviewable slices; extract a coherent helper/module only where that materially reduces coupling. -3. Keep changes behavior-preserving and avoid mixing unrelated cleanup outside src/main.ts unless required to compile. -4. Verify with the updated runtime/startup test commands from TASK-87.1 plus a noUnused compile pass. - - -## Completion Notes - -- Removed the dead import/destructure backlog from `src/main.ts` and deleted stale wrapper seams that no longer owned runtime behavior after the composer/runtime extractions. -- Tightened module boundaries so the composition root depends on the composed/public runtime surfaces it actually uses instead of retaining unused lower-level domain factory symbols. -- Cleared the remaining strict `noUnusedLocals`/`noUnusedParameters` failures in nearby touched files required for a clean repo-wide pass: `launcher/commands/playback-command.ts`, `src/anki-integration.ts`, `src/anki-integration/field-grouping-workflow.ts`, `src/core/services/tokenizer/yomitan-parser-runtime.test.ts`, and `src/main/runtime/composers/composer-contracts.type-test.ts`. -- Verification: - - `bunx tsc --noEmit -p tsconfig.typecheck.json --noUnusedLocals --noUnusedParameters --pretty false` - - `bun run test:fast` -- Commit: `e659b5d` (`refactor(runtime): remove dead symbols from composition roots`) diff --git a/backlog/completed/task-87.5 - Dead-architecture-cleanup-delete-unused-registry-and-pipeline-modules-that-are-off-the-live-path.md b/backlog/completed/task-87.5 - Dead-architecture-cleanup-delete-unused-registry-and-pipeline-modules-that-are-off-the-live-path.md deleted file mode 100644 index 9867aa64..00000000 --- a/backlog/completed/task-87.5 - Dead-architecture-cleanup-delete-unused-registry-and-pipeline-modules-that-are-off-the-live-path.md +++ /dev/null @@ -1,62 +0,0 @@ ---- -id: TASK-87.5 -title: >- - Dead architecture cleanup: delete unused registry and pipeline modules that - are off the live path -status: Done -assignee: [] -created_date: '2026-03-06 03:20' -updated_date: '2026-03-16 05:13' -labels: - - tech-debt - - dead-code -milestone: m-0 -dependencies: - - TASK-87.1 - - TASK-87.2 -references: - - src/translators/index.ts - - src/subsync/engines.ts - - src/subtitle/pipeline.ts - - src/tokenizers/index.ts - - src/token-mergers/index.ts - - src/core/services/subsync.ts - - src/core/services/tokenizer.ts -documentation: - - docs/reports/2026-02-22-task-100-dead-code-report.md -parent_task_id: TASK-87 -priority: high -ordinal: 79500 ---- - -## Description - - -The review found several modules that appear self-contained but unused from the application’s live execution paths: src/translators/index.ts, src/subsync/engines.ts, src/subtitle/pipeline.ts, src/tokenizers/index.ts, and src/token-mergers/index.ts. At the same time, the real runtime behavior is implemented elsewhere. This task should verify those modules are truly unused, remove or consolidate them, and clean up any stale exports, docs, or tests so contributors are not misled by duplicate architecture. - - -## Acceptance Criteria - -- [x] #1 Each candidate module identified in the review is either removed as dead code or justified and reconnected to a real supported execution path. -- [x] #2 Any stale exports, imports, or tests associated with the removed or consolidated modules are cleaned up so the codebase has a single obvious path for the affected behavior. -- [x] #3 The cleanup does not regress live tokenization or subtitle sync behavior and the relevant verification commands remain green. -- [x] #4 Contributor-facing documentation or internal notes no longer imply that removed duplicate architecture is part of the current design. - - -## Implementation Plan - - -1. Re-verify each candidate module is off the live path by tracing imports from current runtime entrypoints before deleting anything. -2. Remove or consolidate truly dead modules and clean associated exports/imports/tests so only the supported path remains obvious. -3. Pay special attention to subtitle sync and tokenization surfaces, since duplicate architecture exists near active code. -4. Verify the relevant tokenization and subsync commands/tests still pass and update any stale docs or notes. - - -## Implementation Notes - - -- Traced imports from `src/main.ts`, `src/main/runtime/**`, `src/core/services/subsync-runner.ts`, and `src/core/services/tokenizer.ts`; confirmed the candidate registry/pipeline modules were isolated from the maintained runtime path. -- Deleted dead modules: `src/translators/index.ts`, `src/subsync/engines.ts`, `src/subtitle/pipeline.ts`, `src/subtitle/stages/{merge,normalize,tokenize}.ts`, `src/subtitle/stages/normalize.test.ts`, `src/tokenizers/index.ts`, and `src/token-mergers/index.ts`. -- Moved the useful zero-width separator normalization into the live tokenizer path in `src/core/services/tokenizer.ts` and added regression coverage plus a repository-level dead-architecture guard in `src/dead-architecture-cleanup.test.ts`. -- Verified with `bun test src/core/services/tokenizer.test.ts`, `bun test src/dead-architecture-cleanup.test.ts`, `bun test src/core/services/subsync.test.ts src/subsync/utils.test.ts`, `bun run tsc`, and `bun run test:src`. - diff --git a/backlog/completed/task-87.6 - Anki-integration-maintainability-continue-decomposing-the-oversized-orchestration-layer.md b/backlog/completed/task-87.6 - Anki-integration-maintainability-continue-decomposing-the-oversized-orchestration-layer.md deleted file mode 100644 index b26c0772..00000000 --- a/backlog/completed/task-87.6 - Anki-integration-maintainability-continue-decomposing-the-oversized-orchestration-layer.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-87.6 -title: >- - Anki integration maintainability: continue decomposing the oversized - orchestration layer -status: Done -assignee: [] -created_date: '2026-03-06 03:20' -updated_date: '2026-03-16 05:13' -labels: - - tech-debt - - anki - - maintainability -milestone: m-0 -dependencies: - - TASK-87.1 -references: - - src/anki-integration.ts - - src/anki-integration/field-grouping-workflow.ts - - src/anki-integration/note-update-workflow.ts - - src/anki-integration/card-creation.ts - - src/anki-integration/anki-connect-proxy.ts - - src/anki-integration.test.ts -documentation: - - docs/reports/2026-02-22-task-100-dead-code-report.md - - docs/anki-integration.md -parent_task_id: TASK-87 -priority: medium -ordinal: 83500 ---- - -## Description - - -src/anki-integration.ts remains an oversized orchestration file even after earlier extractions. It still mixes config normalization, polling setup, media generation, duplicate resolution, field grouping workflows, and user feedback coordination in one class. This task should continue the decomposition so the remaining orchestration surface is smaller and easier to reason about, while preserving existing Anki, proxy, field grouping, and note update behavior. - - -## Acceptance Criteria - -- [x] #1 The responsibilities currently concentrated in src/anki-integration.ts are split into clearer modules or services with narrow ownership boundaries. -- [x] #2 The resulting orchestration surface is materially smaller and easier to review, with at least one mixed-responsibility cluster extracted behind a well-named interface. -- [x] #3 Existing Anki integration behavior remains covered by automated verification, including note update, field grouping, and proxy-related flows that the refactor touches. -- [x] #4 Any developer-facing docs or notes needed to understand the new structure are updated in the same task. - - -## Implementation Plan - - -1. Map the remaining responsibility clusters inside src/anki-integration.ts and choose one or more extraction seams that reduce mixed concerns without changing behavior. -2. Move logic behind narrow interfaces/modules rather than creating another giant helper; keep orchestration readable. -3. Preserve coverage for field grouping, note update, proxy, and card creation flows touched by the refactor. -4. Update docs or internal notes if the new structure changes where contributors should look for a given behavior. - diff --git a/backlog/completed/task-88 - Fix-second-instance-start-handling-when-overlay-runtime-is-already-initialized.md b/backlog/completed/task-88 - Fix-second-instance-start-handling-when-overlay-runtime-is-already-initialized.md deleted file mode 100644 index d90e8c94..00000000 --- a/backlog/completed/task-88 - Fix-second-instance-start-handling-when-overlay-runtime-is-already-initialized.md +++ /dev/null @@ -1,71 +0,0 @@ ---- -id: TASK-88 -title: >- - Fix second-instance --start handling when overlay runtime is already - initialized -status: Done -assignee: - - codex -created_date: '2026-03-06 07:30' -updated_date: '2026-03-16 05:13' -labels: [] -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/core/services/cli-command.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/cli-command.test.ts -priority: medium -ordinal: 94500 ---- - -## Description - - -Restore the CLI command guard so a second-instance `--start` request does not reconnect or reinitialize overlay work when the overlay runtime is already active, while preserving other second-instance commands. - - -## Acceptance Criteria - -- [x] #1 Second-instance `--start` logs that the app is already running when the overlay runtime is initialized. -- [x] #2 Second-instance `--start` does not reconnect the MPV client when the overlay runtime is already initialized. -- [x] #3 Second-instance commands that include non-start actions still execute those actions. -- [x] #4 Regression coverage documents the guarded second-instance behavior. - - -## Implementation Plan - - -1. Reproduce the failing `handleCliCommand` second-instance `--start` regression in `src/core/services/cli-command.test.ts`. -2. Update `src/core/services/cli-command.ts` so second-instance `--start` is ignored when the overlay runtime is already initialized, while still allowing non-start actions in the same invocation. -3. Run focused CLI command tests, then rerun the core test target if practical, and record acceptance criteria/results. - - -## Implementation Notes - - -Reproduced the failing second-instance `--start` regression in `src/core/services/cli-command.test.ts` before editing. - -Restored a guard in `src/core/services/cli-command.ts` that ignores second-instance `--start` when the overlay runtime is already initialized, but still allows other flags in the same invocation to run. - -Verification: `bun test src/core/services/cli-command.test.ts`, `bun run test:core:src`, and `bun run test` all pass; the six immersion tracker tests remain skipped as before. - - -## Final Summary - - -Restored the missing second-instance `--start` guard in `src/core/services/cli-command.ts`. - -- Added an `ignoreSecondInstanceStart` check so `handleCliCommand` logs `Ignoring --start because SubMiner is already running.` when a second-instance `--start` arrives after the overlay runtime is already initialized. -- Updated start gating so pure duplicate `--start` requests no longer reconnect the MPV client, while combined commands such as `--start --toggle-visible-overlay` still execute their non-start behavior and can connect through those paths. -- Verified the regression with existing CLI command coverage and reran the broader test targets. - -Tests run: - -- `bun test src/core/services/cli-command.test.ts` -- `bun run test:core:src` -- `bun run test` - -Notes: - -- The six skipped immersion tracker tests are unchanged from the pre-fix baseline. - diff --git a/backlog/completed/task-89 - Replace-per-anime-Yomitan-imports-with-merged-usage-based-character-dictionary.md b/backlog/completed/task-89 - Replace-per-anime-Yomitan-imports-with-merged-usage-based-character-dictionary.md deleted file mode 100644 index 0b19a2fc..00000000 --- a/backlog/completed/task-89 - Replace-per-anime-Yomitan-imports-with-merged-usage-based-character-dictionary.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-89 -title: Replace per-anime Yomitan imports with merged usage-based character dictionary -status: Done -assignee: - - '@codex' -created_date: '2026-03-06 07:59' -updated_date: '2026-03-16 05:13' -labels: - - character-dictionary - - yomitan - - anilist -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/character-dictionary-auto-sync.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/config/definitions/defaults-integrations.ts -priority: high -ordinal: 91500 ---- - -## Description - - -Replace TTL-based per-anime character dictionary imports with a single merged Yomitan dictionary built from locally stored per-media metadata snapshots. Retain only most-recently-used anime up to configured maxLoaded, rebuild merged import when retained set membership/order changes, and avoid rebuilding on revisits that do not change the retained set. - - -## Acceptance Criteria - -- [x] #1 Character dictionary retention becomes usage-based rather than TTL-based. -- [x] #2 Only one Yomitan character dictionary import is maintained and updated as a merged dictionary. -- [x] #3 Local storage keeps only metadata/snapshots needed to rebuild the merged dictionary; per-anime source zip cache is removed. -- [x] #4 Merged dictionary rebuild occurs when retained-set membership or order changes, not on unchanged revisits. -- [x] #5 Tests cover merged rebuild, MRU eviction, and no-op revisits. - - -## Implementation Notes - - -Replaced per-media auto-sync imports with one merged Yomitan dictionary. Added snapshot persistence in `src/main/character-dictionary-runtime.ts` so auto-sync stores normalized per-media term/image metadata locally under `character-dictionaries/snapshots/` and rebuilds `merged.zip` from the MRU retained media ids. - -Updated `src/main/runtime/character-dictionary-auto-sync.ts` to keep only MRU `activeMediaIds` plus merged revision/title state, rebuild/import the merged dictionary only when retained-set membership/order changes or the merged import is missing/stale, and skip rebuild on unchanged revisits. - -Kept manual `generateForCurrentMedia` support by generating a one-off per-media zip from the stored snapshot, but removed the old per-media zip cache path from auto-sync state. - -Updated config/help text to describe usage-based merged retention and mark legacy TTL/eviction knobs as ignored. - - -## Final Summary - - -Implemented MRU-based merged character dictionary sync. Auto-sync now stores per-media normalized snapshots locally, rebuilds a single merged Yomitan dictionary when the retained anime set/order changes, and keeps `maxLoaded` as the cap on most-recently-used anime included in that merged import. Unchanged revisits no longer rebuild/import the dictionary. - -Validation: `bun test src/main/runtime/character-dictionary-auto-sync.test.ts src/main/character-dictionary-runtime.test.ts`, `bun run tsc --noEmit`. - diff --git a/backlog/completed/task-90 - Expand-TypeScript-typecheck-coverage-beyond-src.md b/backlog/completed/task-90 - Expand-TypeScript-typecheck-coverage-beyond-src.md deleted file mode 100644 index 5661cad9..00000000 --- a/backlog/completed/task-90 - Expand-TypeScript-typecheck-coverage-beyond-src.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-90 -title: Expand TypeScript typecheck coverage beyond src -status: Done -assignee: [] -created_date: '2026-03-06 08:18' -updated_date: '2026-03-16 05:13' -labels: - - tooling - - typescript -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/tsconfig.json - - /home/sudacode/projects/japanese/SubMiner/package.json - - /home/sudacode/projects/japanese/SubMiner/launcher - - /home/sudacode/projects/japanese/SubMiner/scripts -priority: medium -ordinal: 89500 ---- - -## Description - - -Bring all repository TypeScript entrypoints outside src/ into the enforced typecheck gate so CI and local checks cover launcher/ and script files, then resolve any surfaced diagnostics. - - -## Acceptance Criteria - -- [x] #1 TypeScript typecheck covers repository TypeScript entrypoints outside src/ that should be maintained in this repo, including launcher/ and script files. -- [x] #2 The enforced typecheck command used by CI and local development passes with the expanded coverage. -- [x] #3 Any diagnostics surfaced by the expanded coverage are fixed without weakening existing strictness for src/. -- [x] #4 Relevant documentation or command wiring is updated if the typecheck entrypoint changes. - - -## Final Summary - - -Added a dedicated repo-wide typecheck config at tsconfig.typecheck.json and wired package.json/CI to use `bun run typecheck` for launcher and scripts coverage without changing the existing src build config. Fixed the strict-null/indexing diagnostics surfaced in launcher/_ and scripts/_, keeping src strictness intact. Verified with `bun run typecheck`, `bun run tsc --noEmit`, and `bun run test:launcher:src` (47 passing, plugin start gate OK). - diff --git a/backlog/completed/task-91 - Keep-unsupported-subtitle-characters-visible-while-excluding-them-from-token-hover.md b/backlog/completed/task-91 - Keep-unsupported-subtitle-characters-visible-while-excluding-them-from-token-hover.md deleted file mode 100644 index 311b9b4a..00000000 --- a/backlog/completed/task-91 - Keep-unsupported-subtitle-characters-visible-while-excluding-them-from-token-hover.md +++ /dev/null @@ -1,36 +0,0 @@ ---- -id: TASK-91 -title: >- - Keep unsupported subtitle characters visible while excluding them from token - hover -status: Done -assignee: [] -created_date: '2026-03-06 08:29' -updated_date: '2026-03-16 05:13' -labels: - - bug - - tokenizer - - renderer -dependencies: [] -priority: medium -ordinal: 88500 ---- - -## Description - - -Tokenizer/rendering bug: symbols and other unsupported characters with no lookup result are removed from the rendered subtitle line after tokenization, causing the displayed line to diverge from the source subtitle text. Update rendering so unsupported spans remain visible as plain text but are not tokenized/hoverable, and add regression coverage. - - -## Acceptance Criteria - -- [x] #1 Subtitle rendering preserves unsupported symbols and special characters from the original line. -- [x] #2 Unsupported symbols and special characters do not create interactive token hover targets. -- [x] #3 Regression tests cover a mixed line containing tokenizable text plus unsupported characters. - - -## Final Summary - - -Updated tokenized subtitle rendering to preserve unsupported punctuation and symbol spans as plain text while keeping only matched tokens interactive. Added renderer and alignment regression coverage for mixed lines so hover offsets stay correct after non-tokenizable characters remain visible. - diff --git a/backlog/completed/task-92 - Fix-merged-Yomitan-headword-selection-for-katakana-subtitle-tokens.md b/backlog/completed/task-92 - Fix-merged-Yomitan-headword-selection-for-katakana-subtitle-tokens.md deleted file mode 100644 index 2b1c8cbd..00000000 --- a/backlog/completed/task-92 - Fix-merged-Yomitan-headword-selection-for-katakana-subtitle-tokens.md +++ /dev/null @@ -1,35 +0,0 @@ ---- -id: TASK-92 -title: Fix merged Yomitan headword selection for katakana subtitle tokens -status: Done -assignee: [] -created_date: '2026-03-06 08:43' -updated_date: '2026-03-16 05:13' -labels: - - bug - - tokenizer - - yomitan -dependencies: [] -priority: medium -ordinal: 87500 ---- - -## Description - - -Tokenizer/parser-selection bug: when a scanning-parser line is merged from multiple segments, the merged token currently keeps the first segment headword even if a later segment provides the full dictionary-backed term. This truncates katakana names such as バニール to バニ in the lookup payload and prevents correct dictionary matching. Also align kana classification so the prolonged sound mark is treated as kana in tokenizer heuristics. - - -## Acceptance Criteria - -- [x] #1 Merged scanning-parser tokens prefer a full cross-segment headword when one segment expands to the full term. -- [x] #2 Standalone later segment headwords do not override the primary token headword in normal content-word + auxiliary merges. -- [x] #3 Katakana prolonged sound mark is treated as kana in tokenizer heuristics. -- [x] #4 Regression tests cover the merged katakana headword case. - - -## Final Summary - - -Adjusted merged scanning-parser headword selection so later segments only override the first headword when they provide an expanded cross-segment dictionary term, which fixes truncated katakana lookups like バニール -> バニ. Also updated kana classification to include the katakana prolonged sound mark and added regression coverage for both the expanded-headword case and the normal content-word-plus-auxiliary case. - diff --git a/backlog/completed/task-93 - Replace-subtitle-tokenizer-with-left-to-right-Yomitan-scanning-parser.md b/backlog/completed/task-93 - Replace-subtitle-tokenizer-with-left-to-right-Yomitan-scanning-parser.md deleted file mode 100644 index f5eb8382..00000000 --- a/backlog/completed/task-93 - Replace-subtitle-tokenizer-with-left-to-right-Yomitan-scanning-parser.md +++ /dev/null @@ -1,35 +0,0 @@ ---- -id: TASK-93 -title: Replace subtitle tokenizer with left-to-right Yomitan scanning parser -status: Done -assignee: [] -created_date: '2026-03-06 09:02' -updated_date: '2026-03-16 05:13' -labels: - - tokenizer - - yomitan - - refactor -dependencies: [] -priority: high -ordinal: 85500 ---- - -## Description - - -Replace the current parseText candidate-selection tokenizer with a GSM-style left-to-right Yomitan scanning tokenizer for all subtitles. Preserve downstream token contracts for rendering, JLPT/frequency/N+1 annotation, and MeCab enrichment while improving full-term matching for names and katakana compounds. - - -## Acceptance Criteria - -- [x] #1 Subtitle tokenization uses a left-to-right Yomitan scanning strategy instead of parseText candidate selection. -- [x] #2 Token surfaces, readings, headwords, and offsets remain compatible with existing renderer and annotation stages. -- [x] #3 Known problematic name cases such as カズマ and バニール resolve to full-token dictionary matches when Yomitan can match them. -- [x] #4 Regression tests cover left-to-right exact-match scanning, unmatched text handling, and downstream tokenizeSubtitle integration. - - -## Final Summary - - -Replaced the live subtitle tokenization path with a left-to-right Yomitan `termsFind` scanner that greedily advances through the normalized subtitle text, preserving downstream `MergedToken` contracts for renderer, MeCab enrichment, JLPT, frequency, and N+1 annotation. Added runtime and integration coverage for exact-match scanning plus name cases like カズマ and kept compatibility fallback handling for older mocked parseText-style test payloads. - diff --git a/backlog/completed/task-94 - Add-kana-aliases-for-AniList-character-dictionary-entries.md b/backlog/completed/task-94 - Add-kana-aliases-for-AniList-character-dictionary-entries.md deleted file mode 100644 index b2896c1b..00000000 --- a/backlog/completed/task-94 - Add-kana-aliases-for-AniList-character-dictionary-entries.md +++ /dev/null @@ -1,41 +0,0 @@ ---- -id: TASK-94 -title: Add kana aliases for AniList character dictionary entries -status: Done -assignee: [] -created_date: '2026-03-06 09:20' -updated_date: '2026-03-16 05:13' -labels: - - dictionary - - tokenizer - - anilist -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.test.ts -priority: high -ordinal: 84500 ---- - -## Description - - -Generate katakana/hiragana-friendly aliases from AniList romanized character names so subtitle katakana names like カズマ match character dictionary entries even when AniList native name is kanji. - - -## Acceptance Criteria - -- [x] #1 AniList character dictionary generation adds kana aliases for romanized names when native name is not already kana-only -- [x] #2 Generated dictionary entries allow katakana subtitle names like カズマ to resolve against a kanji-native AniList character entry -- [x] #3 Regression tests cover alias generation and resulting term bank output - - -## Final Summary - - -Added katakana aliases synthesized from AniList romanized character names during character dictionary generation, so kanji-native entries such as 佐藤和真 / Satou Kazuma now also emit terms like カズマ and サトウカズマ with hiragana readings. Added regression coverage verifying generated term-bank output for the Konosuba case. - -Verified with `bun test src/main/character-dictionary-runtime.test.ts` and `bun run tsc --noEmit`. - diff --git a/backlog/completed/task-95 - Invalidate-old-character-dictionary-snapshots-after-kana-alias-schema-change.md b/backlog/completed/task-95 - Invalidate-old-character-dictionary-snapshots-after-kana-alias-schema-change.md deleted file mode 100644 index 8344c37e..00000000 --- a/backlog/completed/task-95 - Invalidate-old-character-dictionary-snapshots-after-kana-alias-schema-change.md +++ /dev/null @@ -1,40 +0,0 @@ ---- -id: TASK-95 -title: Invalidate old character dictionary snapshots after kana alias schema change -status: Done -assignee: [] -created_date: '2026-03-06 09:25' -updated_date: '2026-03-16 05:13' -labels: - - dictionary - - cache -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.test.ts -priority: high -ordinal: 82500 ---- - -## Description - - -Bump character dictionary snapshot format/version so cached AniList snapshots created before kana alias generation are rebuilt automatically on next auto-sync or generation run. - - -## Acceptance Criteria - -- [x] #1 Old cached character dictionary snapshots are treated as invalid after the schema/version bump -- [x] #2 Current snapshot generation tests cover rebuild behavior across version mismatch -- [x] #3 No manual cache deletion is required for users to pick up kana alias term generation - - -## Final Summary - - -Bumped the character dictionary snapshot format version so cached AniList snapshots created before kana alias generation are automatically treated as stale and rebuilt. Added regression coverage that seeds an older-format snapshot and verifies `getOrCreateCurrentSnapshot` fetches fresh data and overwrites the stale cache. - -Verified with `bun test src/main/character-dictionary-runtime.test.ts` and `bun run tsc --noEmit`. - diff --git a/backlog/completed/task-96 - Add-launcher-app-log-progress-for-anime-dictionary-generate-update-flow.md b/backlog/completed/task-96 - Add-launcher-app-log-progress-for-anime-dictionary-generate-update-flow.md deleted file mode 100644 index 462ee3ed..00000000 --- a/backlog/completed/task-96 - Add-launcher-app-log-progress-for-anime-dictionary-generate-update-flow.md +++ /dev/null @@ -1,48 +0,0 @@ ---- -id: TASK-96 -title: Add launcher/app log progress for anime dictionary generate/update flow -status: Done -assignee: [] -created_date: '2026-03-06 09:30' -updated_date: '2026-03-16 05:13' -labels: - - logging - - dictionary - - launcher -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts - - /home/sudacode/projects/japanese/SubMiner/src/core/services/cli-command.ts - - >- - /home/sudacode/projects/japanese/SubMiner/launcher/commands/playback-command.ts -priority: medium -ordinal: 81500 ---- - -## Description - - -Surface user-visible log progress while the anime character dictionary is being generated or refreshed so launcher/app output no longer appears hung before mpv launches. - - -## Acceptance Criteria - -- [x] #1 Dictionary generation logs a start/progress message before the first AniList/network/cache work begins. -- [x] #2 Dictionary refresh/update path logs progress messages during the wait before completion. -- [x] #3 Regression coverage verifies the new progress logging behavior. - - -## Implementation Notes - - -Added progress logging to character dictionary generation at anime resolution, AniList match, snapshot miss, character-page fetch, image download start, and ZIP build stages. - -Added auto-sync progress logging at snapshot sync start, active AniList set selection, merged rebuild, Yomitan import, and settings application stages. - - -## Final Summary - - -Character dictionary generation/update no longer appears hung before mpv resumes. Added runtime progress logs for anime resolution, AniList lookup, snapshot rebuild, image-download phase, ZIP build, and auto-sync merged-dictionary import/settings stages. Added regression coverage in the runtime and auto-sync test suites and verified with focused Bun tests. - diff --git a/backlog/completed/task-97 - Add-configurable-character-name-token-highlighting.md b/backlog/completed/task-97 - Add-configurable-character-name-token-highlighting.md deleted file mode 100644 index 2c07e2e6..00000000 --- a/backlog/completed/task-97 - Add-configurable-character-name-token-highlighting.md +++ /dev/null @@ -1,40 +0,0 @@ ---- -id: TASK-97 -title: Add configurable character-name token highlighting -status: Done -assignee: [] -created_date: '2026-03-06 10:15' -updated_date: '2026-03-16 05:13' -labels: - - subtitle - - dictionary - - renderer -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer/yomitan-parser-runtime.ts - - /home/sudacode/projects/japanese/SubMiner/src/renderer/subtitle-render.ts -priority: medium -ordinal: 80500 ---- - -## Description - - -Color subtitle tokens that match entries from the SubMiner character dictionary, with a configurable default color and a config toggle that disables both rendering and name-match detection work. - - -## Acceptance Criteria - -- [x] #1 Tokens matched from the SubMiner character dictionary receive dedicated renderer styling. -- [x] #2 `subtitleStyle.nameMatchEnabled` disables name-match detection work when false. -- [x] #3 `subtitleStyle.nameMatchColor` overrides the default `#f5bde6`. -- [x] #4 Regression coverage verifies config parsing, tokenizer propagation, scanner gating, and renderer class/CSS behavior. - - -## Final Summary - - -Added configurable character-name token highlighting with default color `#f5bde6` and config gate `subtitleStyle.nameMatchEnabled`. When enabled, left-to-right Yomitan scanning tags tokens whose winning dictionary entry comes from the SubMiner character dictionary; when disabled, the tokenizer skips that metadata work and the renderer suppresses name-match styling. Added focused regression tests for config parsing, main-deps wiring, Yomitan scan gating, token propagation, renderer classes, and CSS behavior. - diff --git a/backlog/completed/task-98 - Gate-subtitle-character-name-highlighting-on-character-dictionary-enablement.md b/backlog/completed/task-98 - Gate-subtitle-character-name-highlighting-on-character-dictionary-enablement.md deleted file mode 100644 index 242b4409..00000000 --- a/backlog/completed/task-98 - Gate-subtitle-character-name-highlighting-on-character-dictionary-enablement.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -id: TASK-98 -title: Gate subtitle character-name highlighting on character dictionary enablement -status: Done -assignee: - - codex -created_date: '2026-03-07 00:54' -updated_date: '2026-03-16 05:13' -labels: - - subtitle - - character-dictionary -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/main.ts - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/tokenizer.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/config/definitions/defaults-subtitle.ts -priority: medium -ordinal: 74500 ---- - -## Description - - -Ensure subtitle tokenization and other annotations continue to work, but character-name lookup/highlighting is disabled whenever the AniList character dictionary feature is disabled. This avoids unnecessary name-match processing when the backing dictionary is unavailable. - - -## Acceptance Criteria - -- [x] #1 When anilist.characterDictionary.enabled is false, subtitle tokenization does not request character-name match metadata or highlight character names. -- [x] #2 When anilist.characterDictionary.enabled is true and subtitleStyle.nameMatchEnabled is true, existing character-name matching behavior remains enabled. -- [x] #3 Subtitle tokenization, JLPT, frequency, and other non-name annotation behavior remain unchanged when character dictionaries are disabled. -- [x] #4 Automated tests cover the runtime gating behavior. - - -## Implementation Plan - - -1. Add a failing test in `src/main/runtime/subtitle-tokenization-main-deps.test.ts` proving name-match enablement resolves to false when `anilist.characterDictionary.enabled` is false even if `subtitleStyle.nameMatchEnabled` is true. -2. Update `src/main/runtime/subtitle-tokenization-main-deps.ts` and `src/main.ts` so subtitle tokenization only enables name matching when both the subtitle setting and the character dictionary setting are enabled. -3. Run focused Bun tests for the updated runtime deps and subtitle processing seams. -4. If verification stays green, check off acceptance criteria and record the result. - -Implementation plan saved in `docs/plans/2026-03-06-character-name-gating.md`. - - -## Implementation Notes - - -Created plan doc `docs/plans/2026-03-06-character-name-gating.md` after user approved the narrow runtime-gating approach. Proceeding with TDD from the subtitle tokenization main-deps seam. - -Implemented the gate at the subtitle tokenization runtime-deps boundary so `getNameMatchEnabled` is false unless both `subtitleStyle.nameMatchEnabled` and `anilist.characterDictionary.enabled` are true. - -Verification: `bun test src/main/runtime/subtitle-tokenization-main-deps.test.ts`, `bun test src/core/services/subtitle-processing-controller.test.ts`, `bun run typecheck`. - - -## Final Summary - - -Character-name lookup/highlighting is now suppressed when the AniList character dictionary is disabled, while subtitle tokenization and other annotation paths remain active. Added focused runtime-deps coverage and wired the main runtime to pass the character-dictionary enabled flag into subtitle tokenization. - diff --git a/backlog/completed/task-99 - Add-configurable-character-dictionary-collapsible-section-open-states.md b/backlog/completed/task-99 - Add-configurable-character-dictionary-collapsible-section-open-states.md deleted file mode 100644 index 14269678..00000000 --- a/backlog/completed/task-99 - Add-configurable-character-dictionary-collapsible-section-open-states.md +++ /dev/null @@ -1,41 +0,0 @@ ---- -id: TASK-99 -title: Add configurable character dictionary collapsible section open states -status: Done -assignee: [] -created_date: '2026-03-07 00:00' -updated_date: '2026-03-16 05:13' -labels: - - dictionary - - config -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts - - /home/sudacode/projects/japanese/SubMiner/src/config/resolve/integrations.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/config/definitions/defaults-integrations.ts -priority: medium -ordinal: 75500 ---- - -## Description - - -Add per-section config for character dictionary collapsible glossary sections so Description, Character Information, and Voiced by can each default open or closed independently. Default all sections closed. - - -## Acceptance Criteria - -- [x] #1 Config supports `anilist.characterDictionary.collapsibleSections.description`. -- [x] #2 Config supports `anilist.characterDictionary.collapsibleSections.characterInformation`. -- [x] #3 Config supports `anilist.characterDictionary.collapsibleSections.voicedBy`. -- [x] #4 Default config keeps all generated character dictionary collapsible sections closed. -- [x] #5 Regression coverage verifies config parsing/warnings and generated glossary `details.open` behavior. - - -## Final Summary - - -Added per-section open-state config under `anilist.characterDictionary.collapsibleSections` for `description`, `characterInformation`, and `voicedBy`, all defaulting to `false`. Wired the glossary generator to read those settings so generated `details.open` matches config, and added regression coverage for defaults, parsing/warnings, registry exposure, and runtime glossary output. - diff --git a/backlog/config.yml b/backlog/config.yml deleted file mode 100644 index cf450d57..00000000 --- a/backlog/config.yml +++ /dev/null @@ -1,16 +0,0 @@ -project_name: "SubMiner" -default_status: "To Do" -statuses: ["To Do", "In Progress", "Done"] -labels: [] -definition_of_done: [] -date_format: yyyy-mm-dd -max_column_width: 20 -default_editor: "nvim" -auto_open_browser: false -default_port: 6420 -remote_operations: true -auto_commit: false -bypass_git_hooks: false -check_active_branches: true -active_branch_days: 30 -task_prefix: "task" diff --git a/backlog/milestones/m-0 - codebase-health-remediation.md b/backlog/milestones/m-0 - codebase-health-remediation.md deleted file mode 100644 index a207f3fb..00000000 --- a/backlog/milestones/m-0 - codebase-health-remediation.md +++ /dev/null @@ -1,8 +0,0 @@ ---- -id: m-0 -title: 'Codebase Health Remediation' ---- - -## Description - -Follow-up work from the March 6, 2026 codebase review: strengthen the runnable test gate, remove confirmed dead architecture, and continue decomposition of oversized runtime entrypoints. diff --git a/backlog/milestones/m-1 - stats-dashboard.md b/backlog/milestones/m-1 - stats-dashboard.md deleted file mode 100644 index e3604184..00000000 --- a/backlog/milestones/m-1 - stats-dashboard.md +++ /dev/null @@ -1,8 +0,0 @@ ---- -id: m-1 -title: "Stats Dashboard" ---- - -## Description - -Milestone: Stats Dashboard diff --git a/backlog/milestones/m-2 - mining-workflow-upgrades.md b/backlog/milestones/m-2 - mining-workflow-upgrades.md deleted file mode 100644 index 32b1e656..00000000 --- a/backlog/milestones/m-2 - mining-workflow-upgrades.md +++ /dev/null @@ -1,8 +0,0 @@ ---- -id: m-2 -title: 'Mining Workflow Upgrades' ---- - -## Description - -Future user-facing workflow improvements that directly improve discoverability, previewability, and mining control without depending on speculative platform integrations like OCR, marketplace infrastructure, or cloud sync. diff --git a/backlog/tasks/task-119 - Add-Jellyfin-remote-session-subtitle-streaming-to-texthooker.md b/backlog/tasks/task-119 - Add-Jellyfin-remote-session-subtitle-streaming-to-texthooker.md deleted file mode 100644 index 02c08f5e..00000000 --- a/backlog/tasks/task-119 - Add-Jellyfin-remote-session-subtitle-streaming-to-texthooker.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-119 -title: Add Jellyfin remote-session subtitle streaming to texthooker -status: To Do -assignee: [] -created_date: '2026-03-08 03:46' -updated_date: '2026-03-18 05:27' -labels: - - jellyfin - - texthooker - - subtitle -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/jellyfin-remote-commands.ts - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/jellyfin.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/subtitle-processing-controller.ts - - 'https://api.jellyfin.org/' -documentation: - - 'https://api.jellyfin.org/' -priority: medium -ordinal: 1000 ---- - -## Description - - -Allow SubMiner to follow subtitles from a separate Jellyfin client session, such as a TV app, without requiring local mpv playback. The feature should fetch the active subtitle stream from Jellyfin, map the remote playback position to subtitle cues, and feed the existing subtitle tokenization plus annotated texthooker websocket pipeline so texthooker-only mode can be used while watching on another device. - - -## Acceptance Criteria - -- [ ] #1 User can target a remote Jellyfin session and stream its current subtitle cue into SubMiner's existing subtitle-processing pipeline without launching local Jellyfin playback in mpv. -- [ ] #2 Texthooker-only mode can display subtitle updates from the tracked remote Jellyfin session through the existing annotation websocket feed. -- [ ] #3 Remote session changes are handled safely: item changes, subtitle-track changes, pause/seek/stop, and session disconnects clear or refresh subtitle state without crashing. -- [ ] #4 The feature degrades clearly when the remote session has no usable text subtitle stream or uses an unsupported subtitle format. -- [ ] #5 Automated tests cover session tracking, subtitle cue selection, and feed integration; user-facing docs/config docs are updated. - diff --git a/backlog/tasks/task-125 - Add-native-AI-API-key-secret-storage.md b/backlog/tasks/task-125 - Add-native-AI-API-key-secret-storage.md deleted file mode 100644 index e501d61a..00000000 --- a/backlog/tasks/task-125 - Add-native-AI-API-key-secret-storage.md +++ /dev/null @@ -1,37 +0,0 @@ ---- -id: TASK-125 -title: Add native AI API key secret storage -status: To Do -assignee: [] -created_date: '2026-03-08 07:25' -updated_date: '2026-03-18 05:27' -labels: - - ai - - config - - security -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/ai/client.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/anilist/anilist-token-store.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/jellyfin-token-store.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main.ts -priority: medium -ordinal: 2000 ---- - -## Description - - -Store the shared AI provider API key using the app's native secret-storage pattern so users do not need to keep the OpenRouter key in config files or shell commands. - - -## Acceptance Criteria - -- [ ] #1 Users can configure the shared AI provider without storing the API key in config.jsonc. -- [ ] #2 The app persists and reloads the shared AI API key using encrypted native secret storage when available. -- [ ] #3 Behavior is defined for existing ai.apiKey and ai.apiKeyCommand configs, including compatibility during migration. -- [ ] #4 The feature has regression tests covering key resolution and storage behavior. -- [ ] #5 User-facing configuration/docs are updated to describe the supported setup. - diff --git a/backlog/tasks/task-133 - Improve-AniList-character-dictionary-parity-with-upstream-guide.md b/backlog/tasks/task-133 - Improve-AniList-character-dictionary-parity-with-upstream-guide.md deleted file mode 100644 index fc6286c3..00000000 --- a/backlog/tasks/task-133 - Improve-AniList-character-dictionary-parity-with-upstream-guide.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -id: TASK-133 -title: Improve AniList character dictionary parity with upstream guide -status: To Do -assignee: - - OpenCode -created_date: '2026-03-08 21:06' -updated_date: '2026-03-18 05:27' -labels: - - dictionary - - anilist - - planning -dependencies: [] -references: - - >- - https://github.com/bee-san/Japanese_Character_Name_Dictionary/blob/main/docs/agents_read_me.md - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/character-dictionary-runtime.test.ts -documentation: - - >- - /Users/sudacode/projects/japanese/SubMiner/docs/plans/2026-03-08-anilist-character-dictionary-parity-design.md - - >- - /Users/sudacode/projects/japanese/SubMiner/docs/plans/2026-03-08-anilist-character-dictionary-parity.md -priority: high -ordinal: 3000 ---- - -## Description - - -Plan and implement guide-faithful parity improvements for the AniList character dictionary flow inside SubMiner's current single-media generation path. Scope includes AniList first/last name hints, hint-aware reading generation for kanji/native names, expanded honorific coverage, 160x200 JPEG thumbnail handling, and AniList 429 retry/backoff behavior. - - -## Acceptance Criteria - -- [ ] #1 AniList character queries include first/last name fields and preserve them through runtime data models. -- [ ] #2 Dictionary generation uses hint-aware name splitting and reading generation for kanji and mixed native names, not only kana-only readings. -- [ ] #3 Honorific generation is expanded substantially toward upstream coverage and is covered by regression tests. -- [ ] #4 Character and voice-actor images are resized or re-encoded to bounded JPEG thumbnails with fallback behavior. -- [ ] #5 AniList requests handle 429 responses with bounded exponential backoff and tests cover retry behavior. - - -## Implementation Plan - - -1. Add targeted regression tests in `src/main/character-dictionary-runtime.test.ts` for AniList 429 retry behavior and thumbnail conversion/fallback image paths before changing runtime code. -2. Update `fetchAniList` in `src/main/character-dictionary-runtime.ts` to retry 429 responses with bounded exponential backoff or `Retry-After` delays, while preserving existing request pacing hook behavior. -3. Update `downloadCharacterImage` to run downloaded bytes through `convertImageToThumbnail`, returning `.jpg` paths when conversion succeeds and preserving original bytes/extensions on fallback. -4. Run focused character-dictionary tests first, then broader required verification commands if the focused lane passes. -5. Record progress against acceptance criteria #4 and #5 in TASK-133 notes/final checklist once verified. - - -## Implementation Notes - - -Approved design and implementation plan captured on 2026-03-08. Scope stays within current single-media AniList dictionary flow; excludes username-driven CURRENT-list fetching and Yomitan auto-update schema work. - -Resumed TASK-133 to finish remaining AC #4 image thumbnail wiring and AC #5 AniList 429 retry handling. Existing code already contains helper constants/functions; next work is wiring plus regression coverage. - diff --git a/backlog/tasks/task-216 - Address-PR-28-CodeRabbit-follow-ups-on-subtitle-sidebar.md b/backlog/tasks/task-216 - Address-PR-28-CodeRabbit-follow-ups-on-subtitle-sidebar.md deleted file mode 100644 index 867dce05..00000000 --- a/backlog/tasks/task-216 - Address-PR-28-CodeRabbit-follow-ups-on-subtitle-sidebar.md +++ /dev/null @@ -1,79 +0,0 @@ ---- -id: TASK-216 -title: 'Address PR #28 CodeRabbit follow-ups on subtitle sidebar' -status: Completed -assignee: - - '@codex' -created_date: '2026-03-21 00:00' -updated_date: '2026-03-21 00:00' -labels: - - pr-review - - subtitle-sidebar - - renderer -dependencies: [] -references: - - src/main/runtime/subtitle-prefetch-init.ts - - src/main/runtime/subtitle-prefetch-init.test.ts - - src/renderer/handlers/mouse.ts - - src/renderer/handlers/mouse.test.ts - - src/renderer/modals/subtitle-sidebar.ts - - src/renderer/modals/subtitle-sidebar.test.ts - - src/renderer/style.css -priority: medium ---- - -## Description - - -Validate the CodeRabbit follow-ups on PR #28 for the subtitle sidebar workstream, implement the confirmed fixes, and verify the touched runtime and renderer paths. - - -## Acceptance Criteria - -- [x] #1 Review comments that described real regressions are fixed in code -- [x] #2 Focused regression coverage exists for the fixed behaviors -- [x] #3 Targeted typecheck and runtime-compat verification pass - - -## Implementation Notes - - -Completed follow-up fixes for PR #28: -- Cleared parsed subtitle cues on subtitle prefetch init failure so stale snapshot cache entries do not survive a failed refresh. -- Treated primary and secondary subtitle containers as one hover region so moving between them does not resume playback mid-transition. -- Kept the subtitle sidebar closed when disabled, serialized snapshot polling with timeouts, made cue rows keyboard-activatable, resolved stale cue selection fallback, and resumed hover-paused playback when the modal closes. - -Regression coverage added: -- `src/main/runtime/subtitle-prefetch-init.test.ts` -- `src/renderer/handlers/mouse.test.ts` -- `src/renderer/modals/subtitle-sidebar.test.ts` - -Verification: -- `bun test src/main/runtime/subtitle-prefetch-init.test.ts` -- `bun test src/renderer/handlers/mouse.test.ts` -- `bun test src/renderer/modals/subtitle-sidebar.test.ts` -- `bun run typecheck` -- `bun run test:runtime:compat` - -2026-03-21: Reopened to assess a newer CodeRabbit review pass on PR #28 and address any remaining valid action items before push/reply. - -2026-03-21: Addressed the latest CodeRabbit follow-up pass in commit d70c6448 after rebasing onto the updated remote branch tip. - -2026-03-21: Reopened for the latest CodeRabbit round on commit d70c6448; current actionable item is the invalid ctx.state.isOverSubtitleSidebar assignment in subtitle-sidebar.ts. - -2026-03-22: Addressed the live hover-state and startup mouse-ignore follow-ups from the latest CodeRabbit pass. `handleMouseLeave()` now clears `isOverSubtitle` and drops `secondary-sub-hover-active` when leaving the secondary subtitle container toward the primary container, and renderer startup now calls `syncOverlayMouseIgnoreState(ctx)` instead of forcing `setIgnoreMouseEvents(true, { forward: true })`. The sidebar IPC hover catch and CSS spacing comments were already satisfied in the current tree. - -2026-03-22: Regenerated `bun.lock` from a clean install so the `electron-builder-squirrel-windows` override now resolves at `26.8.2` in the lockfile alongside `app-builder-lib@26.8.2`. - -2026-03-21: Finished the remaining cleanup pass from the latest review. `subtitleSidebar.layout` now uses enum validation, `SubtitleCue` is re-exported from `src/types.ts` as the single public type path, and the subtitle sidebar resize listener now has unload cleanup wired through the renderer. - - -## Final Summary - - -Implemented the confirmed PR #28 CodeRabbit follow-ups for subtitle sidebar behavior and added regression coverage plus verification for the touched renderer and runtime paths. - -Handled the latest CodeRabbit review pass for PR #28: accepted zero sidebar opacity, closed/inerted the sidebar when refresh sees config disabled, moved poll rescheduling out of finally, caught hover pause IPC failures, and fixed the stylelint spacing issue. - -Verification: bun test src/config/resolve/subtitle-sidebar.test.ts; bun test src/renderer/modals/subtitle-sidebar.test.ts; bun test src/renderer/handlers/mouse.test.ts; bun run typecheck; bun run test:fast; bun run test:env; bun run build; SubMiner verifier lanes config + runtime-compat (including test:runtime:compat and test:smoke:dist). - diff --git a/backlog/tasks/task-219 - Restore-streamed-video-progress-in-anime-episodes.md b/backlog/tasks/task-219 - Restore-streamed-video-progress-in-anime-episodes.md deleted file mode 100644 index 47f744db..00000000 --- a/backlog/tasks/task-219 - Restore-streamed-video-progress-in-anime-episodes.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-219 -title: Restore streamed video progress in anime episodes -status: Done -assignee: - - codex -created_date: '2026-03-22 21:25' -updated_date: '2026-03-31 19:37' -labels: - - stats - - immersion-tracker - - youtube -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/query.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker-service.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/__tests__/query.test.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker-service.test.ts -priority: medium -ordinal: 178500 ---- - -## Description - - -Episode progress for streamed media can stay at `0%` because some remote sessions persist `ended_media_ms = 0` even when subtitle timing and watch activity clearly advanced, and the anime episode query currently treats `0` as a valid progress checkpoint. - - -## Acceptance Criteria - -- [x] #1 Anime episode progress ignores zero-valued session checkpoints and falls back to subtitle/event timing -- [x] #2 New streamed sessions persist meaningful progress even when playback-position updates are missing or sparse -- [x] #3 Regression tests cover the zero-checkpoint remote-session case - - -## Final Summary - - -Restored anime episode progress handling for streamed sessions by ignoring zero-valued `ended_media_ms` checkpoints and falling back to subtitle/event timing, with regression coverage for the remote-session zero-checkpoint case. - diff --git a/backlog/tasks/task-233 - Cut-patch-release-v0.9.1-for-package-size-pruning.md b/backlog/tasks/task-233 - Cut-patch-release-v0.9.1-for-package-size-pruning.md deleted file mode 100644 index 23bdaa2c..00000000 --- a/backlog/tasks/task-233 - Cut-patch-release-v0.9.1-for-package-size-pruning.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-233 -title: Cut patch release v0.9.1 for package size pruning -status: Done -assignee: - - '@codex' -created_date: '2026-03-24 12:40' -updated_date: '2026-03-24 12:55' -labels: - - release - - patch -dependencies: - - TASK-232 -references: - - /home/sudacode/projects/japanese/SubMiner/package.json - - /home/sudacode/projects/japanese/SubMiner/CHANGELOG.md - - /home/sudacode/projects/japanese/SubMiner/release/release-notes.md - - /home/sudacode/projects/japanese/SubMiner/docs-site/changelog.md -priority: high -ordinal: 54800 ---- - -## Description - - - -Publish a patch release for the packaging-size cleanup by bumping the app version to `0.9.1`, generating committed release metadata, and keeping release-facing docs/changelog surfaces aligned. - - - -## Acceptance Criteria - - - -- [x] #1 Repository version metadata is updated to `0.9.1`. -- [x] #2 `CHANGELOG.md`, `release/release-notes.md`, and `docs-site/changelog.md` contain the committed `v0.9.1` release line and the consumed fragment is removed. -- [x] #3 Release-readiness verification passes for changelog, docs, tests, and build lanes. - - -## Implementation Notes - - - -Completed: -- Bumped `package.json` to `0.9.1`. -- Ran `bun run changelog:build --version 0.9.1 --date 2026-03-24`, which generated `CHANGELOG.md` + `release/release-notes.md` and consumed both pending release fragments. -- Synced `docs-site/changelog.md` with the generated `v0.9.1` release line. -- Confirmed no additional README/docs wording changes were needed beyond changelog surfaces. - -Verification: -- `bun run changelog:lint` -- `bun run changelog:check --version 0.9.1` -- `bun run verify:config-example` -- `bun run typecheck` -- `bun run test:fast` -- `bun run test:env` -- `bun run build` -- `bun run docs:test` -- `bun run docs:build` - - - -## Final Summary - - - -Prepared patch release `v0.9.1` locally. Version metadata, committed changelog artifacts, release notes, and docs-site changelog are aligned, and the release gate is green. Pending manual release actions are the release-prep commit, `git tag v0.9.1`, and push/tag publication. - - diff --git a/backlog/tasks/task-234 - Address-PR-35-latest-CodeRabbit-review-round.md b/backlog/tasks/task-234 - Address-PR-35-latest-CodeRabbit-review-round.md deleted file mode 100644 index a1172de6..00000000 --- a/backlog/tasks/task-234 - Address-PR-35-latest-CodeRabbit-review-round.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-234 -title: 'Address PR #35 latest CodeRabbit review round' -status: Done -assignee: - - codex -created_date: '2026-03-26 03:59' -updated_date: '2026-03-31 19:37' -labels: - - review-comments - - coderabbit -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/main.ts - - /Users/sudacode/projects/japanese/SubMiner/src/cli/args.test.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/cli-command-prechecks.test.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/youtube-playback-launch.ts -priority: medium -ordinal: 177500 ---- - -## Description - - -Assess and implement the latest actionable CodeRabbit feedback on PR #35 for the Windows YouTube playback flow. Scope includes fixing the overlapping youtubePlay cleanup race in main runtime state and any low-risk follow-up test/clarity comments from the same review round. - - -## Acceptance Criteria - -- [x] #1 Overlapping youtubePlay requests no longer let an older flow clear active quit-on-disconnect/app-owned-flow state for a newer flow. -- [x] #2 Latest low-risk CodeRabbit test and clarity follow-ups for this PR round are addressed or intentionally rejected based on code verification. -- [x] #3 Relevant tests covering the touched areas pass locally. - - -## Implementation Plan - - -1. Update runYoutubePlaybackFlowMain in src/main.ts to use a per-request generation guard around shared YouTube flow state so overlapping requests cannot clear the active timer, armed flag, or app-owned-flow marker for a newer request. -2. Address verified low-risk latest-round follow-ups: add direct startup-prereq assertions in src/cli/args.test.ts, extend side-effect assertions in src/main/runtime/cli-command-prechecks.test.ts, and rename the youtube-playback-launch polling variable for clarity. -3. Run targeted Bun tests for the touched areas and record results in the task notes/final summary. - - -## Implementation Notes - - -Implemented per-request youtubePlaybackFlowGeneration guard in src/main.ts so superseded youtubePlay flows cannot clear the active arm timer, armed flag, or app-owned-flow state for a newer request. - -Added explicit startup-prereq assertions in src/cli/args.test.ts and stronger warmup/log side-effect assertions in src/main/runtime/cli-command-prechecks.test.ts for the latest CodeRabbit follow-ups. - -Renamed youtube-playback-launch polling variable from pathChanged to pathDiffersFromInitial for accuracy without behavior change. - -Verification: bun test src/cli/args.test.ts; bun test src/main/runtime/cli-command-prechecks.test.ts; bun test src/main/runtime/youtube-playback-launch.test.ts; bun run typecheck. - - -## Final Summary - - -Addressed the latest PR #35 CodeRabbit round by making YouTube playback flow cleanup generation-safe in src/main.ts. Overlapping youtubePlay requests now isolate timer/armed/app-owned-flow cleanup to the currently active request so an older flow cannot clear state for its replacement. - -Also folded in the latest low-risk follow-ups: args tests now assert that youtube playback requires overlay startup prerequisites, cli-command precheck tests now assert warmup/log side effects for the youtube transition, and youtube-playback-launch.ts uses a clearer variable name for the initial-path comparison. - -Verification: -- bun test src/cli/args.test.ts -- bun test src/main/runtime/cli-command-prechecks.test.ts -- bun test src/main/runtime/youtube-playback-launch.test.ts -- bun run typecheck - diff --git a/backlog/tasks/task-235 - Address-PR-35-autoplay-retry-CodeRabbit-follow-up.md b/backlog/tasks/task-235 - Address-PR-35-autoplay-retry-CodeRabbit-follow-up.md deleted file mode 100644 index aa242697..00000000 --- a/backlog/tasks/task-235 - Address-PR-35-autoplay-retry-CodeRabbit-follow-up.md +++ /dev/null @@ -1,57 +0,0 @@ ---- -id: TASK-235 -title: 'Address PR #35 autoplay retry CodeRabbit follow-up' -status: Done -assignee: - - codex -created_date: '2026-03-26 04:30' -updated_date: '2026-03-31 19:37' -labels: - - review-comments - - coderabbit -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/src/main.ts -priority: medium -ordinal: 176500 ---- - -## Description - - -Assess and implement the latest CodeRabbit follow-up on PR #35 concerning stale autoplay-ready fallback retries interfering with a new app-owned YouTube playback flow in main.ts. - - -## Acceptance Criteria - -- [x] #1 Starting a new app-owned YouTube playback flow invalidates any pending autoplay-ready fallback retries from older playback state before mpv prep begins. -- [x] #2 Relevant verification for the touched main.ts autoplay retry logic passes locally. -- [x] #3 Task notes/final summary capture the fix and verification. - - -## Implementation Plan - - -1. Add a helper in src/main.ts that invalidates pending autoplay-ready fallback retry state by clearing the tracked media path and advancing the autoplay generation counter. -2. Invoke that helper at the start of runYoutubePlaybackFlowMain before app-owned YouTube playback takes over so stale retries cannot unpause reused playback. -3. Run relevant verification for the touched main.ts path and record results in the task notes/final summary. - - -## Implementation Notes - - -Added invalidatePendingAutoplayReadyFallbacks() in src/main.ts to clear the tracked autoplay-ready media path and advance the autoplay generation before a new app-owned YouTube flow claims playback. This invalidates stale fallback retry closures even when the reused playback path is the same. - -Verification: bun test src/main/runtime/mpv-main-event-actions.test.ts; bun test src/main/runtime/startup-autoplay-release-policy.test.ts; bun run typecheck. - - -## Final Summary - - -Addressed the latest PR #35 CodeRabbit follow-up by invalidating pending autoplay-ready fallback retries before a new app-owned YouTube playback flow takes over in src/main.ts. The new helper clears the tracked autoplay media path and advances the autoplay generation counter, so retry closures from older playback state cannot later unpause the newly prepared flow when reusing the same media path. - -Verification: -- bun test src/main/runtime/mpv-main-event-actions.test.ts -- bun test src/main/runtime/startup-autoplay-release-policy.test.ts -- bun run typecheck - diff --git a/backlog/tasks/task-236 - Gate-Jimaku-and-SubSync-modal-actions-when-setup-is-missing.md b/backlog/tasks/task-236 - Gate-Jimaku-and-SubSync-modal-actions-when-setup-is-missing.md deleted file mode 100644 index 4e0824fb..00000000 --- a/backlog/tasks/task-236 - Gate-Jimaku-and-SubSync-modal-actions-when-setup-is-missing.md +++ /dev/null @@ -1,29 +0,0 @@ ---- -id: TASK-236 -title: Gate Jimaku and SubSync modal actions when setup is missing -status: To Do -assignee: [] -created_date: '2026-03-26 05:48' -labels: - - ui - - setup-validation -dependencies: [] ---- - -## Description - - -Add safeguards in the Jimaku and SubSync modals so users cannot proceed with unsupported flows when required setup is missing. SubSync should clearly block use when alass/ffsubsync detection fails. Jimaku should surface a visible warning when no API key is configured and prevent proceeding with actions that require it. - - -## Acceptance Criteria - -- [ ] #1 SubSync modal detects availability of alass and ffsubsync before enabling related action option -- [ ] #2 When only one of alass/ffsubsync is available, only the available path is selectable and clearly labeled; unavailable options are visually disabled -- [ ] #3 When neither alass nor ffsubsync are available, the unsupported action option is disabled and/or hidden, and cannot navigate to next step -- [ ] #4 If a user tries to proceed while detection says unavailable, submission is blocked with explanatory inline feedback -- [ ] #5 Jimaku modal detects missing API key (or invalid/missing key) and shows an immediate warning on search results or related UI area -- [ ] #6 When Jimaku API key is absent, actions that require key-based operations are disabled or blocked and cannot be submitted -- [ ] #7 All new/updated UX states include clear copy explaining what to fix (e.g., install binary, add API key, restart if needed) -- [ ] #8 Add or update tests for setup detection and blocked-state behavior in relevant modal/components - diff --git a/backlog/tasks/task-237 - Improve-config-validation-error-reporting-and-logging.md b/backlog/tasks/task-237 - Improve-config-validation-error-reporting-and-logging.md deleted file mode 100644 index 3fc53422..00000000 --- a/backlog/tasks/task-237 - Improve-config-validation-error-reporting-and-logging.md +++ /dev/null @@ -1,34 +0,0 @@ ---- -id: TASK-237 -title: Improve config validation error reporting and logging -status: To Do -assignee: [] -created_date: '2026-03-26 05:51' -labels: - - errors - - config - - validation - - ux -dependencies: [] -references: - - /docs/README.md - - /docs/workflow/verification.md ---- - -## Description - - -Replace raw error body system notifications during config validation with clearer, user-friendly summaries while retaining full technical detail in logs. The flow should surface what is wrong, where, and how to fix it without overloading the user with raw stack traces, and write structured details to console/file logs. - - -## Acceptance Criteria - -- [ ] #1 When config validation fails, show a user-facing notification with cleaned, human-readable summary instead of dumping raw error text directly -- [ ] #2 Notification content includes actionable context (what field/setting failed, expected format/type, and next steps where possible) -- [ ] #3 Raw technical error details are preserved in console logs in a consistently formatted, presentable way -- [ ] #4 Config validation failures also write to persistent log file output in the same presentable format -- [ ] #5 When validation fails repeatedly or with multiple errors, aggregate and group errors for easier reading instead of showing one opaque blob -- [ ] #6 Warning/error notification should map to the specific invalid config section so users can jump to/identify what to fix -- [ ] #7 Add/update tests (unit/integration) that assert notification formatting and logging behavior for at least one malformed config case -- [ ] #8 No sensitive data (API keys/secrets) is written to logs/notifications when sanitizing errors - diff --git a/backlog/tasks/task-238 - Codebase-health-follow-up-decompose-remaining-oversized-runtime-surfaces.md b/backlog/tasks/task-238 - Codebase-health-follow-up-decompose-remaining-oversized-runtime-surfaces.md deleted file mode 100644 index 0dc3ab94..00000000 --- a/backlog/tasks/task-238 - Codebase-health-follow-up-decompose-remaining-oversized-runtime-surfaces.md +++ /dev/null @@ -1,59 +0,0 @@ ---- -id: TASK-238 -title: Codebase health follow-up: decompose remaining oversized runtime surfaces -status: To Do -assignee: [] -created_date: '2026-03-26 20:49' -labels: - - tech-debt - - maintainability - - runtime -milestone: m-0 -dependencies: [] -references: - - src/main.ts - - src/types.ts - - src/main/character-dictionary-runtime.ts - - src/core/services/immersion-tracker/query.ts - - backlog/tasks/task-87 - Codebase-health-harden-verification-and-retire-dead-architecture-identified-in-the-March-2026-review.md - - backlog/completed/task-87.4 - Runtime-composition-root-remove-dead-symbols-and-tighten-module-boundaries-in-src-main.ts.md - - backlog/completed/task-87.6 - Anki-integration-maintainability-continue-decomposing-the-oversized-orchestration-layer.md - - backlog/tasks/task-238.6 - Extract-remaining-inline-runtime-logic-and-composer-gaps-from-src-main.ts.md - - backlog/tasks/task-238.7 - Split-src-main.ts-into-boot-phase-services-runtimes-and-handlers.md -priority: high ---- - -## Description - - -Follow up the March 2026 codebase-health work with a narrower pass over the biggest remaining production hotspots. The latest review correctly flags `src/main.ts` and `src/types.ts` as maintainability pressure, but it also misses the next real large surfaces that will keep slowing future work: `src/main/character-dictionary-runtime.ts` and `src/core/services/immersion-tracker/query.ts`. This parent task should track focused decomposition work that preserves behavior, avoids redoing already-completed dead-architecture cleanup, and keeps each slice small enough for isolated implementation. - - -## Acceptance Criteria - - -- [ ] #1 Child tasks exist for each focused cleanup slice instead of one broad “split the monoliths” effort. -- [ ] #2 The parent task records sequencing so agents do not overlap on `src/main.ts` and other shared surfaces. -- [ ] #3 The selected follow-up tasks target still-live pressure points, not already-completed work like TASK-87.4, TASK-87.5, or TASK-87.6. -- [ ] #4 Completion of the child tasks leaves runtime wiring, shared types, character-dictionary orchestration, and immersion-tracker queries materially easier to review and extend. - - -## Implementation Plan - - -Recommended sequencing: - -1. Start TASK-238.3 first. A compatibility-first type split reduces churn risk for the later runtime/query refactors. -2. Run TASK-238.4 and TASK-238.5 in parallel after TASK-238.3 if desired; they touch different domains. -3. Run TASK-238.1 after or alongside the domain refactors, but keep it focused on window/bootstrap composition only. -4. Run TASK-238.2 after TASK-238.1 because both touch `src/main.ts` and the CLI/headless flow should build on the cleaner composition root. -5. Run TASK-238.6 after the current composer/setup-window-factory work lands, so the remaining inline runtime logic and composer gaps are extracted from the already-cleaned composition root. -6. Run TASK-238.7 only after TASK-238.6 confirms the remaining entrypoint surface still justifies a boot-phase split; then move the boot wiring into dedicated service/runtime/handler modules. - -Shared guardrails: - -- Do not reopen already-completed dead-module cleanup from TASK-87.5 unless new evidence appears. -- Keep `src/types.ts` migration compatibility-first; avoid a repo-wide import churn bomb. -- Prefer extracting named runtime/domain modules over moving code into new giant helper files. -- Verify each slice with the cheapest sufficient lane, then escalate when a task crosses runtime/build boundaries. - diff --git a/backlog/tasks/task-238.1 - Extract-main-window-and-overlay-window-composition-from-src-main.ts.md b/backlog/tasks/task-238.1 - Extract-main-window-and-overlay-window-composition-from-src-main.ts.md deleted file mode 100644 index 2a38570e..00000000 --- a/backlog/tasks/task-238.1 - Extract-main-window-and-overlay-window-composition-from-src-main.ts.md +++ /dev/null @@ -1,45 +0,0 @@ ---- -id: TASK-238.1 -title: Extract main-window and overlay-window composition from src/main.ts -status: To Do -assignee: [] -created_date: '2026-03-26 20:49' -labels: - - tech-debt - - runtime - - windows - - maintainability -milestone: m-0 -dependencies: [] -references: - - src/main.ts - - src/main/runtime/composers - - src/main/runtime/overlay-runtime-bootstrap.ts - - docs/architecture/README.md -parent_task_id: TASK-238 -priority: high ---- - -## Description - - -`src/main.ts` still directly owns several `BrowserWindow` construction and window-lifecycle paths, including overlay-adjacent windows and setup flows. That keeps the composition root far larger than intended and makes window behavior hard to test in isolation. Extract the remaining window/bootstrap composition into named runtime modules so `src/main.ts` mostly wires dependencies and app lifecycle events together. - - -## Acceptance Criteria - - -- [ ] #1 At least the main overlay window path plus two other window/setup flows are extracted from direct `BrowserWindow` construction inside `src/main.ts`. -- [ ] #2 The extracted modules expose narrow factory/handler APIs that can be tested without booting the whole app. -- [ ] #3 `src/main.ts` becomes materially smaller and easier to scan, with window creation concentrated behind well-named runtime surfaces. -- [ ] #4 Relevant runtime/window tests pass, and new tests are added for any newly isolated window composition helpers. - - -## Implementation Plan - - -1. Map the remaining direct `BrowserWindow` creation sites in `src/main.ts` and group them by shared lifecycle concerns. -2. Extract coherent modules for construction, preload/path resolution, and open/focus/reuse behavior rather than moving raw option objects wholesale. -3. Update the composition root to consume the new modules and keep side effects/app state ownership explicit. -4. Verify with focused runtime/window tests plus `bun run typecheck`. - diff --git a/backlog/tasks/task-238.2 - Extract-CLI-and-headless-command-wiring-from-src-main.ts.md b/backlog/tasks/task-238.2 - Extract-CLI-and-headless-command-wiring-from-src-main.ts.md deleted file mode 100644 index d536d688..00000000 --- a/backlog/tasks/task-238.2 - Extract-CLI-and-headless-command-wiring-from-src-main.ts.md +++ /dev/null @@ -1,46 +0,0 @@ ---- -id: TASK-238.2 -title: Extract CLI and headless command wiring from src/main.ts -status: To Do -assignee: [] -created_date: '2026-03-26 20:49' -labels: - - tech-debt - - cli - - runtime - - maintainability -milestone: m-0 -dependencies: - - TASK-238.1 -references: - - src/main.ts - - src/main/cli-runtime.ts - - src/cli/args.ts - - launcher -parent_task_id: TASK-238 -priority: high ---- - -## Description - - -`src/main.ts` still owns the headless-initial-command flow, argument handling, and a large amount of CLI/runtime bridging. That makes non-window startup paths difficult to reason about and keeps CLI behavior coupled to unrelated desktop boot logic. Extract the remaining CLI/headless orchestration into dedicated runtime services so the main entrypoint only decides which startup path to invoke. - - -## Acceptance Criteria - - -- [ ] #1 CLI parsing, initial-command dispatch, and headless command execution no longer live as large inline flows in `src/main.ts`. -- [ ] #2 The new modules make the desktop startup path and headless startup path visibly separate and easier to test. -- [ ] #3 Existing CLI behaviors remain unchanged, including help output and startup gating behavior. -- [ ] #4 Targeted CLI/runtime tests cover the extracted path, and `bun run typecheck` passes. - - -## Implementation Plan - - -1. Map the current `parseArgs` / `handleInitialArgs` / `runHeadlessInitialCommand` / `handleCliCommand` flow in `src/main.ts`. -2. Extract a small startup-path selector plus dedicated runtime services for headless execution and interactive startup dispatch. -3. Keep Electron app ownership in `src/main.ts`; move only CLI orchestration and context assembly. -4. Verify with CLI-focused tests plus `bun run typecheck`. - diff --git a/backlog/tasks/task-238.3 - Introduce-domain-type-entrypoints-and-shrink-src-types.ts-import-surface.md b/backlog/tasks/task-238.3 - Introduce-domain-type-entrypoints-and-shrink-src-types.ts-import-surface.md deleted file mode 100644 index eec525fa..00000000 --- a/backlog/tasks/task-238.3 - Introduce-domain-type-entrypoints-and-shrink-src-types.ts-import-surface.md +++ /dev/null @@ -1,59 +0,0 @@ ---- -id: TASK-238.3 -title: Introduce domain type entrypoints and shrink src/types.ts import surface -status: Done -assignee: [] -created_date: '2026-03-26 20:49' -updated_date: '2026-03-31 19:37' -labels: - - tech-debt - - types - - maintainability -milestone: m-0 -dependencies: [] -references: - - src/types.ts - - src/shared/ipc/contracts.ts - - src/config/service.ts - - docs/architecture/README.md -parent_task_id: TASK-238 -priority: medium -ordinal: 174500 ---- - -## Description - - -`src/types.ts` has become the repo-wide dumping ground for unrelated domains. Splitting it is still worthwhile, but a big-bang move would create noisy churn across a large import graph. Introduce domain entrypoints under `src/types/` and migrate the highest-churn imports first while leaving `src/types.ts` as a compatibility barrel until the new structure is proven. - - -## Acceptance Criteria - -- [x] #1 Domain-focused type modules exist for the main clusters currently mixed together in `src/types.ts` (for example Anki, config/runtime, subtitle/media, and integration/runtime-option types). -- [x] #2 `src/types.ts` becomes a thinner compatibility layer or barrel instead of the sole source of truth for every shared type. -- [x] #3 A meaningful set of imports is migrated to the new entrypoints without breaking the maintained typecheck/test lanes. -- [x] #4 The new structure is documented well enough that contributors can tell where new shared types should live. - - -## Implementation Plan - - -1. Inventory the main type clusters in `src/types.ts` and choose stable domain seams. -2. Create `src/types/` modules and re-export through `src/types.ts` so the migration can be incremental. -3. Migrate the highest-value import sites first, especially config/runtime and Anki-heavy surfaces. -4. Verify with `bun run typecheck` and the cheapest test lane covering touched domains. - - -## Implementation Notes - - -Implemented domain entrypoints under `src/types/` and kept `src/types.ts` as a compatibility barrel (`src/types/anki.ts`, `src/types/config.ts`, `src/types/integrations.ts`, `src/types/runtime.ts`, `src/types/runtime-options.ts`, `src/types/subtitle.ts`). Migrated the highest-value import surfaces away from `src/types.ts` in config/runtime/Anki-related modules and shared IPC surfaces. Added type-level regression coverage in `src/types-domain-entrypoints.type-test.ts`. - -Aligned docs in `docs/architecture/README.md`, `docs/architecture/domains.md`, and `docs-site/changelog.md` to support the change and clear docs-site sync mismatch. - - -## Final Summary - - -Task completed with commit `5dd8bb7f` (`refactor: split shared type entrypoints`). The refactor introduced domain type entrypoints, shrank the `src/types.ts` import surface, updated import consumers, and recorded verification evidence in the local verifier artifacts. Backlog now tracks TASK-238.3 as done. - diff --git a/backlog/tasks/task-238.4 - Decompose-character-dictionary-runtime-into-fetch-build-and-cache-modules.md b/backlog/tasks/task-238.4 - Decompose-character-dictionary-runtime-into-fetch-build-and-cache-modules.md deleted file mode 100644 index d5679da6..00000000 --- a/backlog/tasks/task-238.4 - Decompose-character-dictionary-runtime-into-fetch-build-and-cache-modules.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-238.4 -title: 'Decompose character dictionary runtime into fetch, build, and cache modules' -status: Done -assignee: [] -created_date: '2026-03-26 20:49' -updated_date: '2026-03-31 19:37' -labels: - - tech-debt - - runtime - - anilist - - maintainability -milestone: m-0 -dependencies: - - TASK-238.3 -references: - - src/main/character-dictionary-runtime.ts - - src/main/runtime/character-dictionary-auto-sync.ts - - docs/architecture/README.md -parent_task_id: TASK-238 -priority: medium -ordinal: 173500 ---- - -## Description - - -`src/main/character-dictionary-runtime.ts` is now one of the largest live production files in the repo and combines AniList transport, name normalization, snapshot/image shaping, cache management, and zip packaging. That file will keep growing as character-dictionary features evolve. Split it into focused modules so the runtime surface becomes orchestration instead of a catch-all implementation blob. - - -## Acceptance Criteria - -- [x] #1 AniList fetch/parsing logic, dictionary-entry building, and snapshot/cache/zip persistence no longer live in one giant file. -- [x] #2 The public runtime API stays behavior-compatible for current callers. -- [x] #3 The top-level runtime/orchestration file becomes materially smaller and easier to review. -- [x] #4 Existing character-dictionary tests still pass, and new focused tests cover the extracted modules where needed. - - -## Implementation Plan - - -1. Identify the dominant concern boundaries inside `src/main/character-dictionary-runtime.ts`. -2. Extract fetch/transform/persist modules with narrow interfaces, keeping data-shape ownership explicit. -3. Leave the exported runtime API stable for current main-process callers. -4. Verify with the maintained character-dictionary/runtime test lane plus `bun run typecheck`. - - -## Implementation Notes - - -Split `src/main/character-dictionary-runtime.ts` into focused modules under `src/main/character-dictionary-runtime/` (`fetch`, `build`, `cache`, plus helper modules). The orchestrator stayed as a compatibility shim/API surface with delegated module functions. Added focused tests for cache snapshot semantics and term rebuild + collapsible-open-state behavior in the new modules. Updated runtime architecture docs in `docs/architecture/domains.md` and `docs-site/architecture.md`. - - -## Final Summary - - -Task completed with commit `5b06579e` (`refactor: split character dictionary runtime modules`). Runtime refactor landed with regression coverage and verification including runtime-compat lanes, and all changed behavior was validated as API-compatible for callers. - diff --git a/backlog/tasks/task-238.5 - Split-immersion-tracker-query-layer-into-focused-read-model-modules.md b/backlog/tasks/task-238.5 - Split-immersion-tracker-query-layer-into-focused-read-model-modules.md deleted file mode 100644 index a318b9ad..00000000 --- a/backlog/tasks/task-238.5 - Split-immersion-tracker-query-layer-into-focused-read-model-modules.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -id: TASK-238.5 -title: Split immersion tracker query layer into focused read-model modules -status: Done -assignee: - - codex -created_date: '2026-03-26 20:49' -updated_date: '2026-03-31 19:37' -labels: - - tech-debt - - stats - - database - - maintainability -milestone: m-0 -dependencies: - - TASK-238.3 -references: - - src/core/services/immersion-tracker/query.ts - - src/core/services/stats-server.ts - - src/core/services/immersion-tracker-service.ts -parent_task_id: TASK-238 -priority: medium -ordinal: 175500 ---- - -## Description - - -`src/core/services/immersion-tracker/query.ts` has grown into a large mixed read/write/maintenance surface that owns library queries, timeline/detail queries, cleanup helpers, and rollup rebuild hooks. That size makes stats work harder to change safely. Split the query layer into focused read-model and maintenance modules so future stats/dashboard work does not keep landing in one 2500-line file. - - -## Acceptance Criteria - -- [x] #1 Query responsibilities are grouped into focused modules such as library/session detail, vocabulary/kanji detail, and maintenance/cleanup helpers. -- [x] #2 The stats server and immersion tracker service depend on stable exported query surfaces instead of one monolithic file. -- [x] #3 The refactor preserves current SQL behavior and existing statistics outputs. -- [x] #4 Existing stats/immersion tests still pass, with added focused coverage where extraction creates new seams. - - -## Implementation Plan - - -1. Inventory the major query clusters and choose modules that match current caller boundaries. -2. Extract without changing schema or response contracts unless a narrow cleanup is required for compile/test health. -3. Keep SQL ownership close to the domain module that consumes it; avoid a giant `queries/` dump with no structure. -4. Verify with the maintained stats/immersion test lane plus `bun run typecheck`. - - -## Implementation Notes - - -Split the monolithic query surface into focused read-model modules for sessions, trends, lexical data, library lookups, and maintenance helpers. Updated the service and test imports to use the new module boundaries. - -Verification: `bun run typecheck` passed. Focused query and stats-server tests passed, including the `stats-server.test.ts` coverage around the new Bun fallback path. - - -## Final Summary - - -Extracted the immersion-tracker query layer into smaller read-model modules and kept the compatibility barrel in place so existing call sites can transition cleanly. Added focused coverage and verified the refactor with typecheck plus targeted tests. - diff --git a/backlog/tasks/task-238.6 - Extract-remaining-inline-runtime-logic-and-composer-gaps-from-src-main.ts.md b/backlog/tasks/task-238.6 - Extract-remaining-inline-runtime-logic-and-composer-gaps-from-src-main.ts.md deleted file mode 100644 index 551fbe53..00000000 --- a/backlog/tasks/task-238.6 - Extract-remaining-inline-runtime-logic-and-composer-gaps-from-src-main.ts.md +++ /dev/null @@ -1,84 +0,0 @@ ---- -id: TASK-238.6 -title: Extract remaining inline runtime logic and composer gaps from src/main.ts -status: Done -assignee: [] -created_date: '2026-03-27 00:00' -updated_date: '2026-03-31 19:37' -labels: - - tech-debt - - runtime - - maintainability - - composers -milestone: m-0 -dependencies: - - TASK-238.1 - - TASK-238.2 -references: - - src/main.ts - - src/main/runtime/youtube-flow.ts - - src/main/runtime/autoplay-ready-gate.ts - - src/main/runtime/subtitle-prefetch-init.ts - - src/main/runtime/discord-presence-runtime.ts - - src/main/overlay-modal-state.ts - - src/main/runtime/composers -parent_task_id: TASK-238 -priority: high -ordinal: 172500 ---- - -## Description - - -`src/main.ts` still mixes two concerns: pure dependency wiring and inline runtime logic. The earlier composer extractions reduce the wiring burden, but the file still owns several substantial behavior blocks and a few large inline dependency groupings. This task tracks the next maintainability pass: move the remaining runtime logic into the appropriate domain modules, add missing composer wrappers for the biggest grouped handler blocks, and reassess whether a boot-phase split is still necessary after the entrypoint becomes mostly wiring. - - -## Acceptance Criteria - -- [x] #1 `runYoutubePlaybackFlow`, `maybeSignalPluginAutoplayReady`, `refreshSubtitlePrefetchFromActiveTrack`, `publishDiscordPresence`, and `handleModalInputStateChange` no longer live as substantial inline logic in `src/main.ts`. -- [x] #2 The large subtitle/prefetch, stats startup, and overlay visibility dependency groupings are wrapped behind named composer helpers instead of remaining inline in `src/main.ts`. -- [x] #3 `src/main.ts` reads primarily as a boot and lifecycle coordinator, with domain behavior concentrated in named runtime modules. -- [x] #4 Focused tests cover the extracted behavior or the new composer surfaces. -- [x] #5 The task records whether the remaining size still justifies a boot-phase split or whether that follow-up can wait. - - -## Implementation Plan - - -Recommended sequence: - -1. Let the current composer and `setup-window-factory` work land first so this slice starts from a stable wiring baseline. -2. Extract the five inline runtime functions into their natural domain modules or direct equivalents. -3. Add or extend composer helpers for subtitle/prefetch, stats startup, and overlay visibility handler grouping. -4. Re-scan `src/main.ts` after the extraction and decide whether a boot-phase split is still the right next task. -5. Verify the extracted behavior with focused tests first, then run the relevant broader runtime gate if the slice crosses startup boundaries. - -Guardrails: - -- Keep the work behavior-preserving. -- Prefer moving logic to existing runtime surfaces over creating new giant helper files. -- Do not expand into unrelated `src/main.ts` cleanup that is already tracked by other TASK-238 slices. - - -## Implementation Notes - - -Extracted the remaining inline runtime seams from `src/main.ts` into focused runtime modules: -`src/main/runtime/youtube-playback-runtime.ts`, -`src/main/runtime/autoplay-ready-gate.ts`, -`src/main/runtime/subtitle-prefetch-runtime.ts`, -`src/main/runtime/discord-presence-runtime.ts`, -and `src/main/runtime/overlay-modal-input-state.ts`. - -Added named composer wrappers for the grouped subtitle/prefetch, stats startup, and overlay visibility wiring in `src/main/runtime/composers/`. - -Re-scan result for the boot-phase split follow-up: the entrypoint is materially closer to a boot/lifecycle coordinator now, so TASK-238.7 remains a valid future cleanup but no longer feels urgent or blocking for maintainability. - - -## Final Summary - - -TASK-238.6 is complete. Verification passed with `bun run typecheck`, focused runtime/composer tests, `bun run test:fast`, `bun run test:env`, and `bun run build`. The remaining `src/main.ts` work is now better isolated behind runtime modules and composer helpers, and the boot-phase split can wait for a later cleanup pass instead of being treated as immediate follow-on work. - -Backlog completion now includes changelog artifact `changes/2026-03-27-task-238.6-main-runtime-refactor.md` under runtime internals. - diff --git a/backlog/tasks/task-238.7 - Split-src-main.ts-into-boot-phase-services-runtimes-and-handlers.md b/backlog/tasks/task-238.7 - Split-src-main.ts-into-boot-phase-services-runtimes-and-handlers.md deleted file mode 100644 index bde5e06b..00000000 --- a/backlog/tasks/task-238.7 - Split-src-main.ts-into-boot-phase-services-runtimes-and-handlers.md +++ /dev/null @@ -1,85 +0,0 @@ ---- -id: TASK-238.7 -title: 'Split src/main.ts into boot-phase services, runtimes, and handlers' -status: Done -assignee: [] -created_date: '2026-03-27 00:00' -updated_date: '2026-03-31 19:37' -labels: - - tech-debt - - runtime - - maintainability - - architecture -milestone: m-0 -dependencies: - - TASK-238.6 -references: - - src/main.ts - - src/main/boot/services.ts - - src/main/boot/runtimes.ts - - src/main/boot/handlers.ts - - src/main/runtime/composers -parent_task_id: TASK-238 -priority: high -ordinal: 171500 ---- - -## Description - - -After the remaining inline runtime logic and composer gaps are extracted, `src/main.ts` should be split along boot-phase boundaries so the entrypoint stops mixing service construction, domain runtime composition, and handler wiring in one file. This task tracks that structural split: move service instantiation, runtime composition, and handler orchestration into dedicated boot modules, then leave `src/main.ts` as a thin lifecycle coordinator with clear startup-path selection. - - -## Acceptance Criteria - -- [x] #1 Service instantiation lives in a dedicated boot module instead of a large inline setup block in `src/main.ts`. -- [x] #2 Domain runtime composition lives in a dedicated boot module, separate from lifecycle and handler dispatch. -- [x] #3 Handler/composer invocation lives in a dedicated boot module, with `src/main.ts` reduced to app lifecycle and startup-path selection. -- [x] #4 Existing startup behavior remains unchanged across desktop and headless flows. -- [x] #5 Focused tests cover the split surfaces, and the relevant runtime/typecheck gate passes. - - -## Implementation Plan - - -Recommended sequence: - -1. Re-scan `src/main.ts` after TASK-238.6 lands and mark the remaining boot-phase seams by responsibility. -2. Extract service instantiation into `src/main/boot/services.ts` or equivalent. -3. Extract runtime composition into `src/main/boot/runtimes.ts` or equivalent. -4. Extract handler/composer orchestration into `src/main/boot/handlers.ts` or equivalent. -5. Shrink `src/main.ts` to startup-path selection, app lifecycle hooks, and minimal boot wiring. -6. Verify the split with focused entrypoint/runtime tests first, then run the broader runtime gate if the refactor crosses startup boundaries. - -Guardrails: - -- Keep the split behavior-preserving. -- Prefer small boot modules with narrow ownership over a new monolithic bootstrap layer. -- Do not reopen the inline logic work already tracked by TASK-238.6 unless a remaining seam truly belongs here. - - -## Implementation Notes - - -Added boot-phase modules under `src/main/boot/`: -`services.ts` for config/user-data/runtime-registry/overlay bootstrap service construction, -`runtimes.ts` for named runtime/composer entrypoints and grouped boot-phase seams, -and `handlers.ts` for handler/composer boot entrypoints. - -Rewired `src/main.ts` to source boot-phase service construction from `createMainBootServices(...)` and to route runtime/handler composition through boot-level exports instead of keeping the entrypoint as the direct owner of every composition import. - -Added focused tests for the new boot seams in -`src/main/boot/services.test.ts`, -`src/main/boot/runtimes.test.ts`, -and `src/main/boot/handlers.test.ts`. - -Updated internal architecture docs to note that `src/main/boot/` now owns boot-phase assembly seams so `src/main.ts` can stay centered on lifecycle coordination and startup-path selection. - - -## Final Summary - - -TASK-238.7 is complete. Verification passed with focused boot tests, `bun run typecheck`, `bun run test:fast`, and `bun run build`. `src/main.ts` still acts as the composition root, but the boot-phase split now moves service instantiation, runtime composition seams, and handler composition seams into dedicated `src/main/boot/*` modules so the entrypoint reads more like a lifecycle coordinator than a single monolithic bootstrap file. - -Backlog completion now includes changelog artifact `changes/2026-03-27-task-238.7-main-boot-split.md` for the internal runtime architecture pass. - diff --git a/backlog/tasks/task-239 - Mining-workflow-upgrades-prioritize-high-value-user-facing-improvements.md b/backlog/tasks/task-239 - Mining-workflow-upgrades-prioritize-high-value-user-facing-improvements.md deleted file mode 100644 index 6e1138dc..00000000 --- a/backlog/tasks/task-239 - Mining-workflow-upgrades-prioritize-high-value-user-facing-improvements.md +++ /dev/null @@ -1,51 +0,0 @@ ---- -id: TASK-239 -title: Mining workflow upgrades: prioritize high-value user-facing improvements -status: To Do -assignee: [] -created_date: '2026-03-26 20:49' -labels: - - feature - - ux - - planning -milestone: m-2 -dependencies: [] -references: - - src/main.ts - - src/renderer - - src/anki-integration.ts - - src/config/service.ts -priority: medium ---- - -## Description - - -Track the next set of high-value workflow improvements surfaced by the March 2026 review. The goal is to capture bounded, implementation-sized feature slices with clear user value and avoid prematurely committing to much larger bets like hard-sub OCR, plugin marketplace infrastructure, or cloud config sync. Focus this parent task on features that improve the core mining workflow directly: profile-aware setup, action discoverability, previewing output before mining, and selecting richer subtitle ranges. - - -## Acceptance Criteria - - -- [ ] #1 Child tasks exist for the selected near-to-medium-term workflow upgrades with explicit scope and exclusions. -- [ ] #2 The parent task records the recommended sequencing so future work starts with the best value/risk ratio. -- [ ] #3 The tracked feature set stays grounded in existing product surfaces instead of speculative external-platform integrations. - - -## Implementation Plan - - -Recommended sequencing: - -1. Start TASK-239.3 first. Template preview is the smallest high-signal UX win on a core mining path. -2. Start TASK-239.2 next. A command palette improves discoverability across existing actions without large backend upheaval. -3. Start TASK-239.4 after the preview/palette work. Sentence clipping is high-value but touches runtime, subtitle selection, and card creation flows together. -4. Keep TASK-239.1 as a foundation project and scope it narrowly to local multi-profile support. Do not expand it into cloud sync in the same slice. - -Deliberate exclusions for now: - -- hard-sub OCR -- plugin marketplace infrastructure -- cloud/device sync -- site-specific streaming source auto-detection beyond narrow discovery spikes - diff --git a/backlog/tasks/task-239.1 - Add-profile-aware-config-foundations-and-profile-selection-flow.md b/backlog/tasks/task-239.1 - Add-profile-aware-config-foundations-and-profile-selection-flow.md deleted file mode 100644 index e0f8ad5d..00000000 --- a/backlog/tasks/task-239.1 - Add-profile-aware-config-foundations-and-profile-selection-flow.md +++ /dev/null @@ -1,46 +0,0 @@ ---- -id: TASK-239.1 -title: Add profile-aware config foundations and profile selection flow -status: To Do -assignee: [] -created_date: '2026-03-26 20:49' -labels: - - feature - - config - - launcher - - ux -milestone: m-2 -dependencies: [] -references: - - src/config/service.ts - - src/config/load.ts - - launcher/config.ts - - src/main.ts -parent_task_id: TASK-239 -priority: high ---- - -## Description - - -Introduce the foundation for local multi-profile use so users can keep separate setups for different workflows without hand-editing or swapping config files manually. Keep the first slice intentionally narrow: named local profiles, explicit selection, separate config/data paths, and safe migration from the current single-profile setup. Do not couple this task to cloud sync or remote profile sharing. - - -## Acceptance Criteria - - -- [ ] #1 Users can create/select a named local profile and launch SubMiner against that profile explicitly. -- [ ] #2 Each profile uses separate config and data storage paths for settings and profile-scoped runtime state that should not bleed across workflows. -- [ ] #3 Existing single-profile users migrate safely to a default profile without losing settings. -- [ ] #4 The active profile is visible in the launcher/app surface where it materially affects user behavior. -- [ ] #5 Tests cover profile resolution, migration/defaulting behavior, and at least one end-to-end selection path. - - -## Implementation Plan - - -1. Design a minimal profile storage layout and resolution strategy that works for launcher and desktop runtime entrypoints. -2. Add profile selection plumbing before changing feature behavior inside individual services. -3. Migrate config/data-path resolution to be profile-aware while preserving a safe default-profile fallback. -4. Verify with config/launcher tests plus targeted runtime coverage. - diff --git a/backlog/tasks/task-239.2 - Add-a-searchable-command-palette-for-desktop-actions.md b/backlog/tasks/task-239.2 - Add-a-searchable-command-palette-for-desktop-actions.md deleted file mode 100644 index b33a6f30..00000000 --- a/backlog/tasks/task-239.2 - Add-a-searchable-command-palette-for-desktop-actions.md +++ /dev/null @@ -1,46 +0,0 @@ ---- -id: TASK-239.2 -title: Add a searchable command palette for desktop actions -status: To Do -assignee: [] -created_date: '2026-03-26 20:49' -labels: - - feature - - ux - - desktop - - shortcuts -milestone: m-2 -dependencies: [] -references: - - src/renderer - - src/shared/ipc/contracts.ts - - src/main/runtime/overlay-runtime-options.ts - - src/main.ts -parent_task_id: TASK-239 -priority: medium ---- - -## Description - - -SubMiner already exposes many actions through scattered shortcuts, menus, and modal flows. Add a searchable command palette so users can discover and execute high-value desktop actions from one keyboard-first surface. Build on the existing runtime-options/modal infrastructure where practical instead of creating a completely separate interaction model. - - -## Acceptance Criteria - - -- [ ] #1 A keyboard-accessible command palette opens from the desktop app and lists supported actions with searchable labels. -- [ ] #2 Commands are backed by an explicit registry so action availability and labels are not hard-coded in one renderer component. -- [ ] #3 Users can navigate and execute commands entirely from the keyboard. -- [ ] #4 The first slice includes the highest-value existing actions rather than trying to cover every possible command on day one. -- [ ] #5 Tests cover command filtering, execution dispatch, and at least one disabled/unavailable command state. - - -## Implementation Plan - - -1. Define a small command-registry contract shared across renderer and main-process dispatch. -2. Reuse existing modal/runtime plumbing where it fits so the palette is a thin discoverability layer over current actions. -3. Ship a narrow but useful initial command set, then expand later based on usage. -4. Verify with renderer tests plus targeted IPC/runtime tests. - diff --git a/backlog/tasks/task-239.3 - Add-live-Anki-template-preview-for-card-output.md b/backlog/tasks/task-239.3 - Add-live-Anki-template-preview-for-card-output.md deleted file mode 100644 index 214ffb8a..00000000 --- a/backlog/tasks/task-239.3 - Add-live-Anki-template-preview-for-card-output.md +++ /dev/null @@ -1,45 +0,0 @@ ---- -id: TASK-239.3 -title: Add live Anki template preview for card output -status: To Do -assignee: [] -created_date: '2026-03-26 20:49' -labels: - - feature - - anki - - ux -milestone: m-2 -dependencies: [] -references: - - src/anki-integration.ts - - src/anki-integration/card-creation.ts - - src/config/resolve/anki-connect.ts - - src/renderer -parent_task_id: TASK-239 -priority: high ---- - -## Description - - -Users currently have to infer what card output will look like from config fields and post-mine results. Add a live preview surface that shows the resolved card template output before mining so users can catch broken field mappings, missing media, or undesirable formatting earlier. - - -## Acceptance Criteria - - -- [ ] #1 Users can open a preview that renders the resolved front/back field output for the current note/card template configuration. -- [ ] #2 The preview clearly surfaces missing or unmapped fields instead of silently showing blank content. -- [ ] #3 Preview generation uses the same transformation logic as the live card-creation path so it stays trustworthy. -- [ ] #4 The first slice works with representative sample mining payloads and handles missing optional media gracefully. -- [ ] #5 Tests cover preview rendering for at least one valid and one invalid/missing-field configuration. - - -## Implementation Plan - - -1. Identify the current card-creation data path and extract any logic needed to render a preview without duplicating transformation rules. -2. Add a focused preview UI in the most relevant existing configuration/setup surface. -3. Surface validation/warning states for empty mappings, missing fields, and media-dependent outputs. -4. Verify with Anki integration tests plus renderer coverage for preview states. - diff --git a/backlog/tasks/task-239.4 - Add-sentence-clipping-from-arbitrary-subtitle-ranges.md b/backlog/tasks/task-239.4 - Add-sentence-clipping-from-arbitrary-subtitle-ranges.md deleted file mode 100644 index aa86097f..00000000 --- a/backlog/tasks/task-239.4 - Add-sentence-clipping-from-arbitrary-subtitle-ranges.md +++ /dev/null @@ -1,46 +0,0 @@ ---- -id: TASK-239.4 -title: Add sentence clipping from arbitrary subtitle ranges -status: To Do -assignee: [] -created_date: '2026-03-26 20:49' -labels: - - feature - - subtitle - - anki - - ux -milestone: m-2 -dependencies: [] -references: - - src/renderer/modals/subtitle-sidebar.ts - - src/main/runtime/subtitle-position.ts - - src/anki-integration/card-creation.ts - - src/main/runtime/mpv-main-event-actions.ts -parent_task_id: TASK-239 -priority: medium ---- - -## Description - - -Current mining flows are optimized around the active subtitle line. Add a sentence-clipping workflow that lets users select an arbitrary contiguous subtitle range, preview the combined text/timing, and mine from that selection. This should improve multi-line dialogue capture without forcing manual copy/paste or separate post-processing. - - -## Acceptance Criteria - - -- [ ] #1 Users can select a contiguous subtitle range from the existing subtitle UI instead of being limited to the active cue. -- [ ] #2 The workflow previews the combined text and resulting timing range before mining. -- [ ] #3 Mining from a clipped range uses the combined subtitle payload in card generation while preserving existing single-line behavior. -- [ ] #4 The feature handles overlapping/edge timing cases predictably and does not corrupt the normal active-cue flow. -- [ ] #5 Tests cover range selection, combined payload generation, and at least one card-creation path using a clipped selection. - - -## Implementation Plan - - -1. Define a selection model that fits the existing subtitle sidebar/runtime data flow. -2. Add preview + confirmation UI before routing the clipped payload into mining. -3. Keep the existing single-line path intact and treat clipping as an additive workflow. -4. Verify with subtitle-sidebar, runtime, and Anki/card-creation tests. - diff --git a/backlog/tasks/task-240 - Migrate-SubMiner-agent-skills-into-a-repo-local-plugin-workflow.md b/backlog/tasks/task-240 - Migrate-SubMiner-agent-skills-into-a-repo-local-plugin-workflow.md deleted file mode 100644 index cf2c44c0..00000000 --- a/backlog/tasks/task-240 - Migrate-SubMiner-agent-skills-into-a-repo-local-plugin-workflow.md +++ /dev/null @@ -1,81 +0,0 @@ ---- -id: TASK-240 -title: Migrate SubMiner agent skills into a repo-local plugin workflow -status: Done -assignee: - - codex -created_date: '2026-03-26 00:00' -updated_date: '2026-03-26 23:23' -labels: - - skills - - plugin - - workflow - - backlog - - tooling -dependencies: - - TASK-159 - - TASK-160 -priority: high -ordinal: 24000 ---- - -## Description - - - -Turn the current SubMiner-specific repo skills into a reproducible repo-local plugin workflow. The plugin should become the canonical source of truth for the SubMiner scrum-master and change-verification skills, bundle the scripts and metadata needed to test and validate changes, and preserve compatibility for existing repo references through thin `.agents/skills/` shims while the migration settles. - - - -## Acceptance Criteria - - - -- [x] #1 A repo-local plugin scaffold exists for the SubMiner workflow, with manifest and marketplace metadata wired according to the repo-local plugin layout. -- [x] #2 `subminer-scrum-master` and `subminer-change-verification` live under the plugin as the canonical skill sources, along with any helper scripts or supporting files needed for reproducible use. -- [x] #3 Existing repo-level `.agents/skills/` entrypoints are reduced to compatibility shims or redirects instead of remaining as duplicate sources of truth. -- [x] #4 The plugin-owned workflow explicitly documents backlog-first orchestration and change verification expectations, including how the skills work together. -- [x] #5 The migration is validated with the cheapest sufficient repo-native verification lane and the task records the exact commands and any skips/blockers. - - -## Implementation Plan - - - -1. Inspect the plugin-creator contract and current repo skill/script layout, then choose the plugin name, directory structure, and migration boundaries. -2. Scaffold a repo-local plugin plus marketplace entry, keeping the plugin payload under `plugins//` and the catalog entry under `.agents/plugins/marketplace.json`. -3. Move the two SubMiner-specific skills and their helper scripts into the plugin as the canonical source, adding any plugin docs or supporting metadata needed for reproducible testing/validation. -4. Replace the existing `.agents/skills/subminer-*` surfaces with minimal compatibility shims that point agents at the plugin-owned sources without duplicating logic. -5. Update internal docs or references that should now describe the plugin-first workflow. -6. Run the cheapest sufficient verification lane for plugin/internal-doc changes and record the results in this task. - - -## Implementation Notes - - - -2026-03-26: User approved the migration shape where the plugin becomes the canonical source of truth and `.agents/skills/` stays only as compatibility shims. Repo-local plugin chosen over home-local plugin. - -2026-03-26: Backlog MCP resources/tools are not available in this Codex session (`MCP startup failed`), so this task is being initialized directly in the repo-local `backlog/` files instead of through the live Backlog MCP interface. - -2026-03-26: Scaffolded `plugins/subminer-workflow/` plus `.agents/plugins/marketplace.json`, moved the scrum-master and change-verification skill definitions into the plugin as the canonical sources, and converted the old `.agents/skills/` surfaces into compatibility shims. Preserved the old verifier script entrypoints as wrappers because backlog/docs history already calls them directly. - -2026-03-26: Verification passed. - -- `bash -n plugins/subminer-workflow/skills/subminer-change-verification/scripts/classify_subminer_diff.sh` -- `bash -n plugins/subminer-workflow/skills/subminer-change-verification/scripts/verify_subminer_change.sh` -- `bash -n .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh` -- `bash -n .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh` -- `bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh plugins/subminer-workflow/.codex-plugin/plugin.json docs/workflow/agent-plugins.md .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh` -- `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane docs plugins/subminer-workflow .agents/skills/subminer-scrum-master/SKILL.md .agents/skills/subminer-change-verification/SKILL.md .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh .agents/plugins/marketplace.json docs/workflow/README.md docs/workflow/agent-plugins.md 'backlog/tasks/task-240 - Migrate-SubMiner-agent-skills-into-a-repo-local-plugin-workflow.md'` -- Verifier artifacts: `.tmp/skill-verification/subminer-verify-20260326-232300-E2NQVX/` - - - -## Final Summary - - - -Created a repo-local `subminer-workflow` plugin as the canonical packaging for the SubMiner scrum-master and change-verification workflow. The plugin now owns both skills, the verifier helper scripts, plugin metadata, and workflow docs. The old `.agents/skills/` surfaces remain only as compatibility shims, and the old verifier script paths now forward to the plugin-owned scripts so existing docs and backlog commands continue to work. Targeted plugin/docs verification passed, including wrapper-script syntax checks and a real verifier run through the legacy entrypoint. - - diff --git a/backlog/tasks/task-241 - Add-optional-setup-action-to-seed-subminer-mpv-profile.md b/backlog/tasks/task-241 - Add-optional-setup-action-to-seed-subminer-mpv-profile.md deleted file mode 100644 index 71f1e1a7..00000000 --- a/backlog/tasks/task-241 - Add-optional-setup-action-to-seed-subminer-mpv-profile.md +++ /dev/null @@ -1,37 +0,0 @@ -id: TASK-241 -title: Add optional setup action to seed SubMiner mpv profile -type: feature -status: Open -assignee: [] -created_date: '2026-03-27 11:22' -updated_date: '2026-03-27 11:22' -labels: - - setup - - mpv - - docs - - ux -dependencies: [] -references: [] -documentation: - - /home/sudacode/projects/japanese/SubMiner/docs-site/usage.md - - /home/sudacode/projects/japanese/SubMiner/docs-site/launcher-script.md -ordinal: 24100 ---- - -## Description - - -Add an optional control in the first-run / setup flow to write or update the user’s mpv configuration with SubMiner-recommended defaults (especially the `subminer` profile), so users can recover from a missing profile without manual config editing. - -The docs for launcher usage must explicitly state that SubMiner’s Windows mpv launcher path runs mpv with `--profile=subminer` by default. - - -## Acceptance Criteria - - -- [ ] #1 Add an optional setup UI action/button to generate or overwrite a user-confirmed mpv config that includes a `subminer` profile. -- [ ] #2 The action should be non-destructive by default, show diff/contents before write, and support append/update mode when other mpv settings already exist. -- [ ] #3 Document how to resolve the missing-profile scenario and clearly state that the SubMiner mpv launcher runs with `--profile=subminer` by default (`--launch-mpv` / Windows mpv shortcut path). -- [ ] #4 Add/adjust setup validation messaging so users are not blocked if `subminer` profile is initially missing, but can opt into one-click setup recovery. -- [ ] #5 Include a short verification path for both Windows and non-Windows flows (for example dry-run + write path). - diff --git a/backlog/tasks/task-242 - Fix-stats-server-Bun-fallback-in-coverage-lane.md b/backlog/tasks/task-242 - Fix-stats-server-Bun-fallback-in-coverage-lane.md deleted file mode 100644 index 1466e0da..00000000 --- a/backlog/tasks/task-242 - Fix-stats-server-Bun-fallback-in-coverage-lane.md +++ /dev/null @@ -1,36 +0,0 @@ ---- -id: TASK-242 -title: Fix stats server Bun fallback in coverage lane -status: Done -assignee: [] -created_date: '2026-03-29 07:31' -updated_date: '2026-03-31 19:37' -labels: - - ci - - bug -milestone: cleanup -dependencies: [] -references: - - 'PR #36' -priority: high -ordinal: 170500 ---- - -## Description - - -Coverage CI fails when `startStatsServer` reaches the Bun server seam under the maintained source lane. Add a runtime fallback that works when `Bun.serve` is unavailable and keep the stats-server startup path testable. - - -## Acceptance Criteria - -- [x] #1 `bun run test:coverage:src` passes in GitHub CI -- [x] #2 `startStatsServer` uses `Bun.serve` when present and a Node server fallback otherwise -- [x] #3 Regression coverage exists for the fallback startup path - - -## Final Summary - - -Fixed the CI failure in the coverage lane by replacing the Bun-only stats server path with a Bun-or-node/http startup fallback and by normalizing setup window options so undefined BrowserWindow fields are omitted. Verified the exact coverage lane under Bun 1.3.5 and confirmed the GitHub Actions run for PR #36 completed successfully. - diff --git a/backlog/tasks/task-245 - Cut-minor-release-v0.10.0-for-docs-and-release-prep.md b/backlog/tasks/task-245 - Cut-minor-release-v0.10.0-for-docs-and-release-prep.md deleted file mode 100644 index 3807634f..00000000 --- a/backlog/tasks/task-245 - Cut-minor-release-v0.10.0-for-docs-and-release-prep.md +++ /dev/null @@ -1,68 +0,0 @@ ---- -id: TASK-245 -title: Cut minor release v0.10.0 for docs and release prep -status: Done -assignee: - - '@codex' -created_date: '2026-03-29 08:10' -updated_date: '2026-03-29 08:13' -labels: - - release - - docs - - minor -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner/package.json - - /home/sudacode/projects/japanese/SubMiner/README.md - - /home/sudacode/projects/japanese/SubMiner/docs/RELEASING.md - - /home/sudacode/projects/japanese/SubMiner/docs/README.md - - /home/sudacode/projects/japanese/SubMiner/docs-site/changelog.md - - /home/sudacode/projects/japanese/SubMiner/CHANGELOG.md - - /home/sudacode/projects/japanese/SubMiner/release/release-notes.md -priority: high -ordinal: 54850 ---- - -## Description - - -Prepare the next 0-ver minor release cut as `v0.10.0`, keeping release-facing docs, backlog, and changelog artifacts aligned, then run the release-prep verification gate. - - -## Acceptance Criteria - -- [x] #1 Repository version metadata is updated to `0.10.0`. -- [x] #2 Release-facing docs and public changelog surfaces are aligned for the `v0.10.0` cut. -- [x] #3 `CHANGELOG.md` and `release/release-notes.md` contain the committed `v0.10.0` section and any consumed fragments are removed. -- [x] #4 Release-prep verification passes for changelog, config example, typecheck, tests, and build. - - -## Implementation Notes - - -Completed: -- Bumped `package.json` from `0.9.3` to `0.10.0`. -- Ran `bun run changelog:build --version 0.10.0 --date 2026-03-29`, which generated `CHANGELOG.md` and `release/release-notes.md` and removed the queued `changes/*.md` fragments. -- Updated `docs-site/changelog.md` with the public-facing `v0.10.0` summary. - -Verification: -- `bun run changelog:lint` -- `bun run changelog:check --version 0.10.0` -- `bun run verify:config-example` -- `bun run typecheck` -- `bunx bun@1.3.5 run test:fast` -- `bunx bun@1.3.5 run test:env` -- `bunx bun@1.3.5 run build` -- `bunx bun@1.3.5 run docs:test` -- `bunx bun@1.3.5 run docs:build` - -Notes: -- The local `bun` binary is `1.3.11`, which tripped Bun's nested `node:test` handling in `test:fast`; rerunning with the repo-pinned `bun@1.3.5` cleared the issue. -- No README content change was necessary for this cut. - - -## Final Summary - - -Prepared the `v0.10.0` release cut locally. Bumped `package.json`, generated committed root changelog and release notes, updated the public docs changelog summary, and verified the release gate with the repo-pinned Bun `1.3.5` runtime. The release prep is green and ready for tagging/publishing when desired. - diff --git a/backlog/tasks/task-246 - Migrate-Discord-Rich-Presence-to-maintained-RPC-wrapper.md b/backlog/tasks/task-246 - Migrate-Discord-Rich-Presence-to-maintained-RPC-wrapper.md deleted file mode 100644 index 32a2c445..00000000 --- a/backlog/tasks/task-246 - Migrate-Discord-Rich-Presence-to-maintained-RPC-wrapper.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-246 -title: Migrate Discord Rich Presence to maintained RPC wrapper -status: Done -assignee: [] -created_date: '2026-03-29 08:17' -updated_date: '2026-03-31 19:37' -labels: - - dependency - - discord - - presence -dependencies: [] -priority: medium -ordinal: 169500 ---- - -## Description - - -Replace the deprecated Discord Rich Presence wrapper with a maintained JavaScript alternative while preserving the current IPC-based presence behavior in the Electron main process. - - -## Acceptance Criteria - -- [x] #1 The app no longer depends on `discord-rpc` -- [x] #2 Discord Rich Presence still logs in and publishes activity updates from the main process -- [x] #3 Existing Discord presence tests continue to pass or are updated to cover the new client API -- [x] #4 The change is documented in the release notes or changelog fragment - - -## Implementation Notes - - -Completed: -- Swapped the app's Discord RPC dependency from `discord-rpc` to `@xhayper/discord-rpc`. -- Extracted the client adapter into `src/main/runtime/discord-rpc-client.ts` so the main process can keep using a small wrapper around the maintained library. -- Added `src/main/runtime/discord-rpc-client.test.ts` to verify the adapter forwards login/activity/clear/destroy calls through `client.user`. -- Documented the dependency swap in `CHANGELOG.md`, `release/release-notes.md`, and `docs-site/changelog.md`. - -Verification: -- `bunx bun@1.3.5 test src/main/runtime/discord-rpc-client.test.ts src/core/services/discord-presence.test.ts` -- `bunx bun@1.3.5 run changelog:lint` -- `bunx bun@1.3.5 run changelog:check --version 0.10.0` -- `bunx bun@1.3.5 run docs:test` -- `bunx bun@1.3.5 run docs:build` - -Notes: -- The existing release prep artifacts for v0.10.0 were kept intact and updated in place. -- No README change was needed for this dependency swap. - - -## Final Summary - - -Replaced the deprecated `discord-rpc` dependency with the maintained `@xhayper/discord-rpc` wrapper while preserving the main-process rich presence flow. Added a focused runtime wrapper test, kept the existing Discord presence service tests green, and documented the dependency swap in the release notes and changelog. - diff --git a/backlog/tasks/task-247 - Strip-inline-subtitle-markup-from-subtitle-sidebar-cues.md b/backlog/tasks/task-247 - Strip-inline-subtitle-markup-from-subtitle-sidebar-cues.md deleted file mode 100644 index 3b0f9b5e..00000000 --- a/backlog/tasks/task-247 - Strip-inline-subtitle-markup-from-subtitle-sidebar-cues.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -id: TASK-247 -title: Strip inline subtitle markup from subtitle sidebar cues -status: Done -assignee: - - codex -created_date: '2026-03-29 10:01' -updated_date: '2026-03-31 19:37' -labels: [] -dependencies: [] -references: - - src/core/services/subtitle-cue-parser.ts - - src/renderer/modals/subtitle-sidebar.ts - - src/core/services/subtitle-cue-parser.test.ts -ordinal: 168500 ---- - -## Description - - -Subtitle sidebar should display readable subtitle text when loaded subtitle files include inline markup such as HTML-like font tags. Parsed cue text currently preserves markup, causing raw tags to appear in the sidebar instead of clean subtitle content. - - -## Acceptance Criteria - -- [x] #1 Subtitle sidebar cue text omits inline subtitle markup such as HTML-like font tags while preserving visible subtitle content. -- [x] #2 Parsed subtitle cues used by the sidebar keep timing order and expected line-break behavior after markup sanitization. -- [x] #3 Regression tests cover markup-bearing subtitle cue parsing so raw tags do not reappear in the sidebar. - - -## Implementation Plan - - -1. Add regression tests in src/core/services/subtitle-cue-parser.test.ts for subtitle cues containing HTML-like font tags, including multi-line content. -2. Verify the new parser test fails against current behavior to confirm the bug is covered. -3. Update src/core/services/subtitle-cue-parser.ts to sanitize inline subtitle markup while preserving visible text and expected newline handling. -4. Re-run focused parser tests, then run broader verification commands required for handoff as practical. -5. Update task notes/acceptance criteria based on verified results and finalize the task record. - - -## Implementation Notes - - -User approved implementation on 2026-03-29. - -Implemented parser-level subtitle cue sanitization for HTML-like tags so loaded sidebar cues render readable text while preserving cue line breaks. - -Added regression coverage for SRT and ASS cue parsing with markup. - -Verification: bun test src/core/services/subtitle-cue-parser.test.ts; bun run typecheck; bun run test:fast; bun run test:env; bun run build; bun run test:smoke:dist. - - -## Final Summary - - -Sanitized parsed subtitle cue text in src/core/services/subtitle-cue-parser.ts so HTML-like inline markup such as is removed before cues reach the subtitle sidebar. The sanitizer is shared across SRT/VTT-style parsing and ASS parsing, while existing cue timing and line-break semantics remain intact. - -Added regression tests in src/core/services/subtitle-cue-parser.test.ts covering markup-bearing SRT lines and ASS dialogue lines with \N breaks, and verified the original failure before implementing the fix. - -Tests run: bun test src/core/services/subtitle-cue-parser.test.ts; bun run typecheck; bun run test:fast; bun run test:env; bun run build; bun run test:smoke:dist. - diff --git a/backlog/tasks/task-248 - Fix-macOS-visible-overlay-toggle-getting-immediately-restored.md b/backlog/tasks/task-248 - Fix-macOS-visible-overlay-toggle-getting-immediately-restored.md deleted file mode 100644 index 1e9bfb0a..00000000 --- a/backlog/tasks/task-248 - Fix-macOS-visible-overlay-toggle-getting-immediately-restored.md +++ /dev/null @@ -1,70 +0,0 @@ ---- -id: TASK-248 -title: Fix macOS visible overlay toggle getting immediately restored -status: Done -assignee: [] -created_date: '2026-03-29 10:03' -updated_date: '2026-03-31 19:37' -labels: [] -dependencies: [] -references: - - /Users/sudacode/projects/japanese/SubMiner/plugin/subminer/process.lua - - /Users/sudacode/projects/japanese/SubMiner/plugin/subminer/ui.lua - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/cli-command.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/overlay-visibility-runtime.ts -ordinal: 165500 ---- - -## Description - - -Investigate and fix the visible overlay toggle path on macOS so the user can reliably hide the overlay after it has been shown. The current behavior can ignore the toggle or hide the overlay briefly before it is restored immediately. - - -## Acceptance Criteria - -- [x] #1 Pressing the visible-overlay toggle hides the overlay when it is currently shown on macOS. -- [x] #2 A manual hide is not immediately undone by startup or readiness flows. -- [x] #3 The mpv/plugin toggle path matches the intended visible-overlay toggle behavior. -- [x] #4 Regression tests cover the failing toggle path. - - -## Implementation Plan - - -1. Reproduce the toggle/re-show logic from code paths around mpv plugin control commands and auto-play readiness. -2. Add regression coverage for manual toggle-off staying hidden through readiness completion. -3. Patch the plugin/control path so manual visible-overlay toggles are not undone by readiness auto-show. -4. Run targeted tests, then the relevant verification lane. - - -## Implementation Notes - - -Root cause: the mpv plugin readiness callback (`subminer-autoplay-ready`) could re-issue `--show-visible-overlay` after a manual toggle/hide. Initial fix only suppressed the next readiness restore, but repeated readiness callbacks in the same media session could still re-show the overlay. The plugin toggle path also still used legacy `--toggle` instead of the explicit visible-overlay command. - -Implemented a session-scoped suppression flag in the Lua plugin so a manual hide/toggle during the pause-until-ready window blocks readiness auto-show for the rest of the current auto-start session, then resets on the next auto-start session. - -Added Lua regression coverage for both behaviors: manual toggle-off stays hidden through readiness completion, repeated readiness callbacks in the same session stay suppressed, and `subminer-toggle` emits `--toggle-visible-overlay` rather than legacy `--toggle`. - -Follow-up investigation found a second issue in `src/core/services/cli-command.ts`: pure visible-overlay toggle commands still ran the MPV connect/start path (`connectMpvClient`) because `--toggle` and `--toggle-visible-overlay` were classified as start-like commands. That side effect could retrigger startup visibility work even after the plugin-side fix. - -Updated CLI command handling so only `--start` reconnects MPV. Pure toggle/show/hide overlay commands still initialize overlay runtime when needed, but they no longer restart/reconnect the MPV control path. - -Renderer/modal follow-ups: restored focused-overlay mpv y-chord proxy in `src/renderer/handlers/keyboard.ts`, added a modal-close guard in `src/main/overlay-runtime.ts` so modal teardown does not re-show a manually hidden overlay, and added a duplicate-toggle debounce in `src/main/runtime/overlay-visibility-actions.ts` to ignore near-simultaneous toggle requests inside the main process. - -2026-03-29: added regression for repeated subminer-autoplay-ready signals after manual y-t hide. Root cause: Lua plugin suppression only blocked the first ready-time restore, so later ready callbacks in the same media session could re-show the visible overlay. Updated plugin suppression to remain active for the full current auto-start session and reset on the next auto-start trigger. - -2026-03-29: live mpv log showed repeated `subminer-autoplay-ready` script messages from Electron during paused startup, each triggering plugin `--show-visible-overlay` and immediate re-show. Fixed `src/main/runtime/autoplay-ready-gate.ts` so plugin readiness is signaled once per media while paused retry loops only re-issue `pause=false` instead of re-signaling readiness. - -2026-03-29: Added window-level guard for stray visible-overlay re-show on macOS. `src/core/services/overlay-window.ts` now immediately re-hides the visible overlay window on `show` if overlay state is false, covering native/Electron re-show paths that bypass normal visibility actions. Regression: `src/core/services/overlay-window.test.ts`. Verified with full gate and rebuilt unsigned mac bundle. - -2026-03-29: added a blur-path guard for the visible overlay window. `src/core/services/overlay-window.ts` now skips topmost restacking when a visible-overlay blur fires after overlay state already flipped off, covering a macOS hide-in-flight path that could immediately reassert the window. Regression coverage added in `src/core/services/overlay-window.test.ts`; verified with targeted overlay tests, full gate, and rebuilt unsigned mac bundle. - - -## Final Summary - - -Confirmed with user that macOS `y-t` now works. Cleaned the patch set down to the remaining justified fixes: explicit visible-overlay plugin toggle/suppression, pure-toggle CLI no longer reconnects MPV, autoplay-ready signaling only fires once per media, and the final visible-overlay blur guard that stops macOS restacking after a manual hide. Full gate passed again before commit `c939c580` (`fix: stabilize macOS visible overlay toggle`). - diff --git a/backlog/tasks/task-249 - Fix-AniList-token-persistence-on-setup-login.md b/backlog/tasks/task-249 - Fix-AniList-token-persistence-on-setup-login.md deleted file mode 100644 index b8ca93d5..00000000 --- a/backlog/tasks/task-249 - Fix-AniList-token-persistence-on-setup-login.md +++ /dev/null @@ -1,38 +0,0 @@ ---- -id: TASK-249 -title: Fix AniList token persistence on setup login -status: Done -assignee: [] -created_date: '2026-03-29 10:08' -updated_date: '2026-03-31 19:37' -labels: - - anilist - - bug -dependencies: [] -documentation: - - src/main/runtime/anilist-setup.ts - - src/core/services/anilist/anilist-token-store.ts - - src/main/runtime/anilist-token-refresh.ts - - docs-site/anilist-integration.md -priority: high -ordinal: 166500 ---- - -## Description - - -AniList setup can appear successful but the token is not persisted across restarts. Investigate the setup callback and token store path so the app either saves the token reliably or surfaces persistence failure instead of reopening setup on every launch. - - -## Acceptance Criteria - -- [ ] #1 AniList setup login persists a usable token across app restarts when safeStorage works -- [ ] #2 If token persistence fails the setup flow reports the failure instead of pretending login succeeded -- [ ] #3 Regression coverage exists for the callback/save path and the refresh path that reopens setup when no token is available - - -## Final Summary - - -Pinned installed mpv plugin configs to the current SubMiner binary so standalone mpv launches reuse the same app identity that saved AniList tokens. Added startup self-heal for existing blank binary_path configs, install-time binary_path writes for fresh plugin installs, regression tests for both paths, and docs updates describing the new behavior. - diff --git a/backlog/tasks/task-250 - Restore-macOS-mpv-passthrough-while-overlay-subtitle-sidebar-is-open.md b/backlog/tasks/task-250 - Restore-macOS-mpv-passthrough-while-overlay-subtitle-sidebar-is-open.md deleted file mode 100644 index d694b4fe..00000000 --- a/backlog/tasks/task-250 - Restore-macOS-mpv-passthrough-while-overlay-subtitle-sidebar-is-open.md +++ /dev/null @@ -1,73 +0,0 @@ ---- -id: TASK-250 -title: Restore macOS mpv passthrough while overlay subtitle sidebar is open -status: Done -assignee: - - '@codex' -created_date: '2026-03-29 10:10' -updated_date: '2026-03-31 19:37' -labels: - - bug - - macos - - subtitle-sidebar - - overlay - - mpv -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/overlay-mouse-ignore.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/modals/subtitle-sidebar.ts - - /Users/sudacode/projects/japanese/SubMiner/src/renderer/handlers/keyboard.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/modals/subtitle-sidebar.test.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/overlay-mouse-ignore.test.ts -priority: high -ordinal: 167500 ---- - -## Description - - -When the overlay-layout subtitle sidebar is open on macOS, users should still be able to click through outside the sidebar and return keyboard focus to mpv so native mpv keybindings continue to work. The sidebar should stay interactive when hovered or focused, but it must not make the whole visible overlay behave like a blocking modal. - - -## Acceptance Criteria - -- [x] #1 Opening the overlay-layout subtitle sidebar does not keep the entire visible overlay mouse-interactive outside sidebar hover or focus. -- [x] #2 With the subtitle sidebar open, clicking outside the sidebar can refocus mpv so native mpv keybindings continue to work. -- [x] #3 Focused regression coverage exists for overlay-layout sidebar passthrough behavior on mouse-ignore state changes. - - -## Implementation Plan - - -1. Add renderer regression coverage for overlay-layout subtitle sidebar passthrough so open-but-unhovered sidebar no longer holds global mouse interaction. -2. Update overlay mouse-ignore gating to keep the subtitle sidebar interactive only while hovered or otherwise actively interacting, instead of treating overlay layout as a blocking modal. -3. Run focused renderer tests for subtitle sidebar and mouse-ignore behavior, then update task notes/criteria with the verified outcome. - - -## Implementation Notes - - -Confirmed the regression only affects the default overlay-layout subtitle sidebar: open sidebar state was treated as a blocking overlay modal, which prevented click-through outside the sidebar and stranded native mpv keybindings until focus was manually recovered. - -Added a failing regression in src/renderer/modals/subtitle-sidebar.test.ts for overlay-layout passthrough before changing the gate. - -Verification: bun test src/renderer/modals/subtitle-sidebar.test.ts src/renderer/overlay-mouse-ignore.test.ts; bun run typecheck - -User reported the first renderer-only fix did not resolve the macOS issue in practice. Reopening investigation to trace visible-overlay window focus and hit-testing outside the renderer mouse-ignore gate. - -Follow-up root cause: sidebar hover handlers were attached to the full-screen `.subtitle-sidebar-modal` shell instead of the actual sidebar panel. On the transparent visible overlay that shell spans the viewport, so sidebar-active state could persist outside the panel and keep the overlay interactive longer than intended. - -Updated the sidebar modal to track hover/focus on `subtitleSidebarContent` and derive sidebar interaction state from panel hover or focus-within before recomputing mouse passthrough. - -Verification refresh: bun test src/renderer/modals/subtitle-sidebar.test.ts src/renderer/overlay-mouse-ignore.test.ts; bun run typecheck - - -## Final Summary - - -Restored overlay subtitle sidebar passthrough in two layers. First, the visible overlay mouse-ignore gate no longer treats the subtitle sidebar as a global blocking modal. Second, the sidebar panel now tracks interaction on the real sidebar content instead of the full-screen modal shell, and keeps itself active only while the panel is hovered or focused. Added regressions for overlay-layout passthrough and focus-within behavior. Verification: `bun test src/renderer/modals/subtitle-sidebar.test.ts src/renderer/overlay-mouse-ignore.test.ts` and `bun run typecheck`. - diff --git a/backlog/tasks/task-251 - Docs-add-subtitle-sidebar-and-Jimaku-integration-pages.md b/backlog/tasks/task-251 - Docs-add-subtitle-sidebar-and-Jimaku-integration-pages.md deleted file mode 100644 index 7b674910..00000000 --- a/backlog/tasks/task-251 - Docs-add-subtitle-sidebar-and-Jimaku-integration-pages.md +++ /dev/null @@ -1,33 +0,0 @@ ---- -id: TASK-251 -title: 'Docs: add subtitle sidebar and Jimaku integration pages' -status: Done -assignee: [] -created_date: '2026-03-29 22:36' -updated_date: '2026-03-31 19:37' -labels: - - docs -dependencies: [] -priority: medium -ordinal: 164500 ---- - -## Description - - -Track the docs-site update that adds a dedicated subtitle sidebar page, links Jimaku integration from the homepage/config docs, and refreshes the docs-site theme styling used by those pages. - - -## Acceptance Criteria - -- [x] #1 docs-site nav includes a Subtitle Sidebar entry -- [x] #2 Subtitle Sidebar page documents layout, shortcut, and config options -- [x] #3 Jimaku integration page and configuration docs link to the new docs page -- [x] #4 Changelog fragment exists for the user-visible docs release note - - -## Final Summary - - -Added the subtitle sidebar docs page and nav entry, linked Jimaku integration from the homepage/config docs, refreshed docs-site styling tokens, and recorded the release note fragment. Verified with `bun run changelog:lint`, `bun run docs:test`, `bun run docs:build`, and `bun run build`. Full repo test gate still has pre-existing failures in `bun run test:fast` and `bun run test:env` unrelated to these docs changes. - diff --git a/backlog/tasks/task-252 - Harden-AUR-publish-release-step-against-transient-SSH-failures.md b/backlog/tasks/task-252 - Harden-AUR-publish-release-step-against-transient-SSH-failures.md deleted file mode 100644 index 936a608c..00000000 --- a/backlog/tasks/task-252 - Harden-AUR-publish-release-step-against-transient-SSH-failures.md +++ /dev/null @@ -1,36 +0,0 @@ ---- -id: TASK-252 -title: Harden AUR publish release step against transient SSH failures -status: Done -assignee: [] -created_date: '2026-03-29 23:46' -updated_date: '2026-03-31 19:37' -labels: - - release - - ci - - aur -dependencies: [] -priority: high -ordinal: 163500 ---- - -## Description - - -Make tagged releases resilient when the automated AUR update hits transient SSH disconnects from GitHub-hosted runners. The GitHub Release should still complete successfully, while AUR publish should retry a few times and downgrade persistent AUR failures to warnings instead of failing the entire release workflow. - - -## Acceptance Criteria - -- [x] #1 Tagged release workflow retries the AUR clone/push path with bounded backoff when AUR SSH disconnects transiently. -- [x] #2 Persistent AUR publish failure does not fail the overall tagged release workflow or block GitHub Release publication. -- [x] #3 Release documentation notes that AUR publish is best-effort and may need manual follow-up when retries are exhausted. - - -## Implementation Notes - - -Updated .github/workflows/release.yml so AUR secret/configure/clone/push failures downgrade to warnings, clone/push retry three times with linear backoff, and the GitHub Release path remains green. - -Documented AUR publish as best-effort in docs/RELEASING.md and added changes/253-aur-release-best-effort.md for PR changelog compliance. - diff --git a/backlog/tasks/task-253 - Fix-animated-AVIF-lead-in-alignment-with-sentence-audio.md b/backlog/tasks/task-253 - Fix-animated-AVIF-lead-in-alignment-with-sentence-audio.md deleted file mode 100644 index ec5b5da0..00000000 --- a/backlog/tasks/task-253 - Fix-animated-AVIF-lead-in-alignment-with-sentence-audio.md +++ /dev/null @@ -1,69 +0,0 @@ ---- -id: TASK-253 -title: Fix animated AVIF lead-in alignment with sentence audio -status: Done -assignee: - - codex -created_date: '2026-03-30 01:59' -updated_date: '2026-03-31 19:37' -labels: [] -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/anki-integration/animated-image-sync.ts - - /Users/sudacode/projects/japanese/SubMiner/src/anki-integration.ts - - /Users/sudacode/projects/japanese/SubMiner/src/core/services/stats-server.ts - - /Users/sudacode/projects/japanese/SubMiner/src/media-generator.ts -ordinal: 162500 ---- - -## Description - - -Animated AVIF cards currently freeze only for the existing word-audio duration. Because generated sentence audio starts with configured audio padding before the spoken subtitle begins, animation motion can begin early instead of lining up with the spoken sentence. Update the shared lead-in calculation so animated motion begins when sentence speech begins after the chosen word audio finishes. - - -## Acceptance Criteria - -- [x] #1 Animated AVIF lead-in calculation includes both the chosen word-audio duration and the generated sentence-audio start offset so motion begins with spoken sentence audio -- [x] #2 Shared animated-image sync behavior is applied consistently across the Anki note update, card creation, and stats server media-generation paths -- [x] #3 Regression tests cover the corrected lead-in timing calculation and fail before the fix - - -## Implementation Plan - - -Approved plan: -1. Add a failing unit test proving animated-image lead-in must include sentence-audio start offset in addition to chosen word-audio duration. -2. Update shared animated-image lead-in resolution to add the configured sentence-audio offset used by generated sentence audio. -3. Thread the shared calculation through note update, card creation, and stats-server generation paths without duplicating timing logic. -4. Run targeted tests first, then the relevant fast verification lane for touched files. - - -## Implementation Notes - - -User approved implementation on 2026-03-29 local time. Root cause: lead-in omitted sentence-audio padding offset, so AVIF motion began before spoken sentence audio. - -Implemented shared animated-image lead-in fix in src/anki-integration/animated-image-sync.ts by adding the same sentence-audio start offset used by generated audio (`audioPadding`) after summing the chosen word-audio durations. - -Added regression coverage in src/anki-integration/animated-image-sync.test.ts for explicit `audioPadding` lead-in alignment and kept the zero-padding case covered. - -Verification passed: `bun test src/anki-integration/animated-image-sync.test.ts src/anki-integration/note-update-workflow.test.ts src/media-generator.test.ts`, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, `bun run test:smoke:dist`. - - -## Final Summary - - -Fixed animated AVIF lead-in alignment so motion starts when the spoken sentence starts, not at the padded beginning of the generated sentence-audio clip. The shared resolver in `src/anki-integration/animated-image-sync.ts` now adds the configured/default `audioPadding` offset after summing the selected word-audio durations, which keeps note update, card creation, and stats-server generation paths aligned through the same logic. - -Added regression coverage in `src/anki-integration/animated-image-sync.test.ts` for both zero-padding and explicit padding cases to prove the lead-in math matches sentence-audio timing. - -Verification: -- `bun test src/anki-integration/animated-image-sync.test.ts src/anki-integration/note-update-workflow.test.ts src/media-generator.test.ts` -- `bun run typecheck` -- `bun run test:fast` -- `bun run test:env` -- `bun run build` -- `bun run test:smoke:dist` - diff --git a/backlog/tasks/task-254 - Fix-AniList-token-persistence-when-safe-storage-is-unavailable.md b/backlog/tasks/task-254 - Fix-AniList-token-persistence-when-safe-storage-is-unavailable.md deleted file mode 100644 index d04bc155..00000000 --- a/backlog/tasks/task-254 - Fix-AniList-token-persistence-when-safe-storage-is-unavailable.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-254 -title: Fix AniList token persistence when safe storage is unavailable -status: Done -assignee: - - codex -created_date: '2026-03-30 02:10' -updated_date: '2026-03-31 19:37' -labels: - - bug - - anilist -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/anilist/anilist-token-store.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/anilist-setup.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/main/runtime/anilist-token-refresh.ts -priority: high -ordinal: 161500 ---- - -## Description - - -AniList login currently appears to succeed during setup, but some environments cannot persist the token because Electron safeStorage is unavailable or unusable. On the next app start, AniList tracking cannot load the token and re-prompts the user to set up AniList again. Align AniList token persistence with the intended login UX so a token the user already saved is reused on later sessions. - - -## Acceptance Criteria - -- [x] #1 Saved encrypted AniList token is reused on app-ready startup without reopening setup. -- [x] #2 AniList startup no longer attempts to open the setup BrowserWindow before Electron is ready. -- [x] #3 AniList auth/runtime tests cover stored-token reuse and the missing-token startup path that previously triggered pre-ready setup attempts. -- [x] #4 AniList token storage remains encrypted-only; no plaintext fallback is introduced. - - -## Implementation Plan - - -1. Add regression tests for AniList startup auth refresh so a stored encrypted token is reused without opening setup, and for the missing-token path so setup opening is deferred safely until the app can actually show a window. -2. Update AniList startup/auth runtime to separate token resolution from setup-window prompting, and gate prompting on app readiness instead of attempting BrowserWindow creation during early startup. -3. Preserve encrypted-only storage semantics in anilist-token-store; do not add plaintext fallback. If stored-token load fails, keep logging/diagnostics intact. -4. Run targeted AniList runtime/token tests, then summarize root cause and verification results. - - -## Implementation Notes - - -Investigated AniList auth persistence flow. Current setup path treats callback token as saved even when anilist-token-store refuses persistence because safeStorage is unavailable. Jellyfin token store already uses plaintext fallback in this environment class, which is a likely model for the AniList fix. - -Confirmed from local logs that safeStorage was explicitly unavailable on 2026-03-23 due macOS Keychain lookup failure with NSOSStatusErrorDomain Code=-128 userCanceledErr. Current environment also has an encrypted AniList token file at /Users/sudacode/.config/SubMiner/anilist-token-store.json updated 2026-03-29 18:49, so safeStorage did work recently for save. Repeated AniList setup prompts on 2026-03-29/30 correlate more strongly with startup auth flow deciding no token is available and opening setup immediately; logs show repeated 'Loaded AniList manual token entry page' and several 'Failed to refresh AniList client secret state during startup' errors with 'Cannot create BrowserWindow before app is ready'. No recent log lines indicate safeStorage.isEncryptionAvailable() false after 2026-03-23. - -Implemented encrypted-only startup fix by adding an allowSetupPrompt control to AniList token refresh and disabling setup-window prompting for the early pre-ready startup refresh in main.ts. App-ready reloadConfig still performs the normal prompt-capable refresh after Electron is ready. Added regression tests for stored-token reuse and prompt suppression when startup explicitly disables prompting. - - -## Final Summary - - -Root cause was a redundant early AniList auth refresh during startup. The app refreshed AniList auth once before Electron was ready and again during app-ready config reload. When the early refresh could not resolve a token, it tried to open the AniList setup window immediately, which produced the observed 'Cannot create BrowserWindow before app is ready' failures and repeated setup prompts. The fix keeps token storage encrypted-only, teaches AniList auth refresh to optionally suppress setup-window prompting, and uses that suppression for the early startup refresh. App-ready startup still performs the normal prompt-capable refresh once Electron is ready, so saved encrypted tokens are reused without reopening setup and missing-token setup only happens at a safe point. Verified with targeted AniList auth tests, typecheck, test:fast, test:env, build, and test:smoke:dist. - diff --git a/backlog/tasks/task-255 - Add-overlay-playlist-browser-modal-for-sibling-video-files-and-mpv-queue.md b/backlog/tasks/task-255 - Add-overlay-playlist-browser-modal-for-sibling-video-files-and-mpv-queue.md deleted file mode 100644 index a6e9a8e1..00000000 --- a/backlog/tasks/task-255 - Add-overlay-playlist-browser-modal-for-sibling-video-files-and-mpv-queue.md +++ /dev/null @@ -1,92 +0,0 @@ ---- -id: TASK-255 -title: Add overlay playlist browser modal for sibling video files and mpv queue -status: Done -assignee: - - '@codex' -created_date: '2026-03-30 05:46' -updated_date: '2026-03-31 19:37' -labels: - - feature - - overlay - - mpv - - launcher -dependencies: [] -ordinal: 180500 ---- - -## Description - - -Add an in-session overlay modal that opens from a keybinding during active playback and lets the user browse video files from the current file's parent directory alongside the active mpv playlist. The modal should sort local files in best-effort episode order, highlight the current item, and allow keyboard/mouse interaction to add files into the mpv queue, remove queued items, and reorder queued items without leaving playback. - - -## Acceptance Criteria - -- [x] #1 An overlay modal can be opened during active playback from a dedicated keybinding and closed without disrupting existing modal behavior. -- [x] #2 The modal shows video files from the current media file's parent directory in best-effort episode order and highlights the current file when present. -- [x] #3 The modal shows the active mpv playlist/queue with enough metadata to identify the current item and queued order. -- [x] #4 The user can add a directory file to the mpv playlist, remove playlist items, and reorder playlist items from the modal using both mouse and keyboard interactions. -- [x] #5 Modal state stays in sync after playlist mutations so the rendered queue reflects mpv's current playlist order. -- [x] #6 Feature coverage includes automated tests for ordering/playlist behavior and docs or shortcut/help updates for the new modal. - - -## Implementation Plan - - -1. Add playlist-browser domain types, IPC channels, overlay modal registration, special command, and default keybinding for Ctrl+Alt+P. -2. Write failing tests for best-effort episode sorting and main playlist-browser runtime snapshot/mutation behavior. -3. Implement playlist-browser main/runtime helpers for local sibling video discovery, mpv playlist normalization, and append/play/remove/move operations with refreshed snapshots. -4. Wire preload and main-process IPC handlers that expose snapshot and mutation methods to the renderer. -5. Write failing renderer and keyboard tests for modal open/close, split-pane interaction, keyboard controls, and degraded states. -6. Implement playlist-browser modal markup, DOM/state, renderer composition, keyboard routing, and session-help labeling. -7. Run targeted test lanes first, then the maintained verification gate relevant to the touched surfaces; update task notes/criteria as checks pass. - -2026-03-30 CodeRabbit follow-up: 1) add failing runtime coverage for unreadable playlist-browser file stat failures, 2) add failing renderer coverage for stale snapshot UI reset on refresh failure/close, 3) add failing renderer coverage to block playlist-browser open when another modal already owns the overlay, 4) implement minimal fixes, 5) rerun targeted tests plus typecheck for touched surfaces. - -2026-03-30 current CodeRabbit round: verify 4 unresolved threads, ignore already-fixed outdated dblclick thread if current code matches, add failing-first coverage for selection preservation / timestamp fixture consistency / string test-clock alignment, implement minimal fixes, rerun targeted tests plus typecheck. - -2026-03-30 latest CodeRabbit round on PR #37: 1) add failing coverage for negative fractional numeric __subminerTestNowMs input so nowMs() matches the string-backed path, 2) add failing coverage that playlist-browser modal tests restore absent window/document globals without leaving undefined-valued properties behind, 3) refactor repeated playlist-browser modal test harness into a shared setup/teardown fixture while preserving assertions, 4) implement minimal fixes, 5) rerun touched tests plus typecheck. - -2026-03-30 latest CodeRabbit follow-up after ff760ea: tighten the new cleanup regression so env.restore() always runs under assertion failure, and make the keydown test's append mock return a post-append mutated snapshot before exercising Ctrl+ArrowDown. Re-run targeted playlist-browser tests plus typecheck. - - -## Implementation Notes - - -Implemented overlay playlist browser modal with split directory/playlist panes, Ctrl+Alt+P keybinding, main/preload IPC, mpv queue mutations, and best-effort sibling episode sorting. - -Added tests for sort/runtime logic, IPC wiring, keyboard routing, and playlist-browser modal behavior. - -Verification: `bun run typecheck` passed; targeted playlist-browser and IPC tests passed; `bun run build` passed; `bun run test:smoke:dist` passed. - -Repo gate blockers outside this feature: `bun run test:fast` hits existing Bun `node:test` NotImplementedError cases plus unrelated immersion-tracker failures; `bun run test:env` fails in existing immersion-tracker sqlite tests. - -2026-03-30: Fixed playlist-browser local playback regression where subtitle track IDs leaked across episode jumps. `playPlaylistBrowserIndexRuntime` now reapplies local subtitle auto-selection defaults (`sub-auto=fuzzy`, `sid=auto`, `secondary-sid=auto`) before `playlist-play-index` for local filesystem targets only; remote playlist entries remain untouched. Added runtime regression tests for both paths. - -2026-03-30: Follow-up subtitle regression fix. Pre-jump `sid=auto` was ineffective because mpv resolved it against the current episode before `playlist-play-index`. Local playlist jumps now set `sub-auto=fuzzy`, switch episodes, then schedule a delayed rearm of `sid=auto` and `secondary-sid=auto` so selection happens against the new file's tracks. Added failing-first runtime coverage for delayed local rearm and remote no-op behavior. - -2026-03-30: Cleaned up playlist-browser runtime local-play subtitle-rearm flow by extracting focused helpers without changing behavior. Added public docs/readme coverage for the default `Ctrl+Alt+P` playlist browser keybinding and modal, plus changelog fragment `changes/260-playlist-browser.md`. Verification: `bun test src/main/runtime/playlist-browser-runtime.test.ts`, `bun run typecheck`, `bun run docs:test`, `bun run docs:build`, `bun run changelog:lint`, `bun run build`. - -2026-03-30: Pulled unresolved CodeRabbit review threads for PR #37. Actionable set is three items: unreadable-file stat error handling in playlist-browser runtime, stale playlist-browser DOM after failed refresh/close, and missing modal-ownership guard before opening the playlist-browser overlay. Proceeding test-first for each. - -2026-03-30: Addressed current CodeRabbit follow-up findings for PR #37. Fixed playlist-browser unreadable-file stat handling, stale playlist-browser DOM reset on refresh failure/close, modal-ownership guard before opening the playlist-browser overlay, async rejection surfacing for PLAYLIST_BROWSER_OPEN IPC commands, overlay bootstrap before playlist-browser open dispatch, texthooker option normalization in the mpv plugin, and superseded local subtitle-rearm suppression. Added targeted regressions plus new playlist-browser-open helper coverage. Verification: `bun test src/main/runtime/playlist-browser-runtime.test.ts src/main/runtime/playlist-browser-open.test.ts src/core/services/ipc-command.test.ts src/renderer/modals/playlist-browser.test.ts`, `lua scripts/test-plugin-start-gate.lua`, `bun run typecheck`, `bun run build`. - -Addressed CodeRabbit follow-ups on the playlist browser PR: clamped stale playingIndex values, failed mutation paths when MPV rejects send(), added temp-dir cleanup in runtime tests, and blocked action-button dblclick bubbling in the renderer. Verification: `bun run typecheck`, `bun run build`, `bun test src/main/runtime/playlist-browser-runtime.test.ts src/renderer/modals/playlist-browser.test.ts`. - -Additional follow-up: moved playlist-browser keydown handling ahead of keyboard-driven lookup controls so KeyH/ArrowLeft/ArrowRight and related chords are routed to the modal first. Verification refreshed with `bun test src/main/runtime/playlist-browser-runtime.test.ts src/renderer/modals/playlist-browser.test.ts src/renderer/handlers/keyboard.test.ts`, `bun run typecheck`, and `bun run build`. - -Split playlist-browser UI row rendering into `src/renderer/modals/playlist-browser-renderer.ts` and left `src/renderer/modals/playlist-browser.ts` as the controller/wiring layer. Moved playlist-browser IPC/runtime wiring into `src/main/runtime/playlist-browser-ipc.ts` and collapsed the `src/main.ts` registration block to use that helper. Verification after refactor: `bun run typecheck`, `bun run build`, `bun test src/main/runtime/playlist-browser-runtime.test.ts src/renderer/modals/playlist-browser.test.ts src/renderer/handlers/keyboard.test.ts`. - -2026-03-30 PR #37 unresolved CodeRabbit threads currently reduce to three likely-actionable items plus one outdated renderer dblclick thread to verify against HEAD before touching code. - -2026-03-30 Addressed latest unresolved CodeRabbit items on PR #37: preserved playlist-browser selection across mutation snapshots, taught nowMs() to honor string-backed test clocks so it stays aligned with currentDbTimestamp(), and normalized maintenance test timestamp fixtures to toDbTimestamp(). The older playlist-browser dblclick thread remains unresolved in GitHub state but current HEAD already contains that fix in playlist-browser-renderer.ts. - -2026-03-30 latest CodeRabbit remediation on PR #37: switched nowMs() numeric test-clock branch from Math.floor() to Math.trunc() so numeric and string-backed mock clocks agree for negative fractional values. Refactored playlist-browser modal tests onto a shared setup/teardown fixture that restores global window/document descriptors correctly, and added regression coverage that injected globals are deleted when originally absent. Verification: `bun test src/core/services/immersion-tracker/time.test.ts src/renderer/modals/playlist-browser.test.ts`, `bun run typecheck`. - -2026-03-30 CodeRabbit follow-up: wrapped the injected-globals cleanup regression in try/finally so restore always runs, and changed the keydown test append mock to return createMutationSnapshot() before exercising Ctrl+ArrowDown. Verified with `bun test src/renderer/modals/playlist-browser.test.ts` and `bun run typecheck`. - -2026-03-31 assessment: the playlist-browser feature is landed on `main` via `d51e7fe4 Add playlist browser overlay modal (#37)` with runtime, IPC, renderer, keybinding, and changelog/docs coverage present. Verified passes: `bun test src/main/runtime/playlist-browser-runtime.test.ts src/main/runtime/playlist-browser-open.test.ts src/main/runtime/playlist-browser-sort.test.ts src/renderer/handlers/keyboard.test.ts src/core/services/ipc.test.ts src/core/services/ipc-command.test.ts src/config/definitions/domain-registry.test.ts`. - -Remaining action item before close: fix `src/renderer/modals/playlist-browser.test.ts` so the cleanup regression does not assume `globalThis.window` / `globalThis.document` start absent under Bun, rerun the playlist-browser modal lane (and then typecheck/build if you want the full closeout proof), then finalize the task. - diff --git a/backlog/tasks/task-256 - Fix-texthooker-page-live-websocket-connect-send-regression.md b/backlog/tasks/task-256 - Fix-texthooker-page-live-websocket-connect-send-regression.md deleted file mode 100644 index cfccfb22..00000000 --- a/backlog/tasks/task-256 - Fix-texthooker-page-live-websocket-connect-send-regression.md +++ /dev/null @@ -1,57 +0,0 @@ ---- -id: TASK-256 -title: Fix texthooker page live websocket connect/send regression -status: Done -assignee: - - codex -created_date: '2026-03-30 06:04' -updated_date: '2026-03-31 19:37' -labels: - - bug - - texthooker - - websocket -dependencies: [] -priority: medium -ordinal: 160500 ---- - -## Description - - -Investigate why the bundled texthooker page loads at the local HTTP endpoint but does not reliably connect to the configured websocket feed or receive/display live subtitle lines. Identify the regression in the SubMiner startup/bootstrap or vendored texthooker client path, restore live line delivery, and cover the fix with focused regression tests and any required docs updates. - - -## Acceptance Criteria - -- [x] #1 Bundled texthooker connects to the intended websocket endpoint on launch using the configured/default SubMiner startup path. -- [x] #2 Incoming subtitle or annotation websocket messages are accepted by the bundled texthooker and rendered as live lines. -- [x] #3 Regression coverage fails before the fix and passes after the fix for the identified breakage. -- [x] #4 Relevant docs/config notes are updated if user-facing behavior or troubleshooting guidance changes. - - -## Implementation Plan - - -1. Add a focused CLI regression test covering `--texthooker` startup when the runtime has a resolved websocket URL, proving the handler currently starts texthooker without that URL. -2. Extend CLI texthooker dependencies/runtime wiring so the handler can retrieve the resolved texthooker websocket URL from current config/runtime state. -3. Update the CLI texthooker flow to pass the resolved websocket URL into texthooker startup instead of starting the HTTP server with only a port. -4. Run focused tests for CLI command handling and texthooker bootstrap behavior; update task notes/final summary with the verified root cause and fix. - - -## Implementation Notes - - -Root cause: the CLI `--texthooker` path started the HTTP texthooker server with only the port, so the served page never received `bannou-texthooker-websocketUrl` and fell back to the vendored default `ws://localhost:6677`. In environments where the regular websocket was skipped or the annotation websocket should have been used, the page stayed on `Connecting...` and never received lines. - -Fix: added a shared `resolveTexthookerWebsocketUrl(...)` helper for websocket selection, reused it in both app-ready startup and CLI texthooker context wiring, and threaded the resolved websocket URL through `handleCliCommand` into `Texthooker.start(...)`. - -Verification: `bun run typecheck`; focused Bun tests for texthooker bootstrap, startup, CLI command handling, and CLI context wiring; browser-level repro against a throwaway source-backed texthooker server confirmed the page bootstraps `ws://127.0.0.1:6678`, connects successfully, and renders live sample lines (`テスト一`, `テスト二`). - -Docs: no user-facing behavior change beyond restoring the intended existing behavior, so no docs update was required. - - -## Final Summary - - -Restored texthooker live line delivery for the CLI/startup path that launched the page without a resolved websocket URL. Shared websocket URL resolution between app-ready startup and CLI texthooker context, forwarded that URL into `Texthooker.start(...)`, added regression coverage for the CLI path, and verified both by focused tests and a browser-level throwaway server that connected on `ws://127.0.0.1:6678` and rendered live sample lines. - diff --git a/backlog/tasks/task-257 - Fix-texthooker-only-mode-startup-to-initialize-websocket-pipeline.md b/backlog/tasks/task-257 - Fix-texthooker-only-mode-startup-to-initialize-websocket-pipeline.md deleted file mode 100644 index b31fb0f3..00000000 --- a/backlog/tasks/task-257 - Fix-texthooker-only-mode-startup-to-initialize-websocket-pipeline.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-257 -title: Fix texthooker-only mode startup to initialize websocket pipeline -status: Done -assignee: - - codex -created_date: '2026-03-30 06:15' -updated_date: '2026-03-31 19:37' -labels: - - bug - - texthooker - - websocket - - startup -dependencies: [] -priority: high -ordinal: 159500 ---- - -## Description - - -Investigate and fix `--texthooker` / `subminer texthooker` startup so it launches the texthooker page without the overlay window but still initializes the runtime pieces required for live subtitle delivery. Today texthooker-only mode serves the page yet skips mpv client and websocket startup, leaving the page pointed at `ws://127.0.0.1:6678` with no listener behind it. - - -## Acceptance Criteria - -- [x] #1 `--texthooker` mode starts the texthooker page without opening the overlay window and still initializes the websocket path needed for live subtitle delivery. -- [x] #2 Texthooker-only startup creates the mpv/websocket runtime needed for the configured annotation or subtitle websocket feed. -- [x] #3 Regression coverage fails before the fix and passes after the fix for texthooker-only startup. -- [x] #4 Docs/help text remain accurate for texthooker-only behavior; update docs only if wording needs correction. - - -## Implementation Plan - - -1. Replace the existing texthooker-only startup regression test so it asserts websocket/mpv startup still happens while overlay window initialization stays skipped. -2. Remove or narrow the early texthooker-only short-circuit in app-ready startup so runtime config, mpv client, subtitle websocket, and annotation websocket still initialize. -3. Run focused tests plus a local process check proving `--texthooker` now opens the websocket listener expected by the served page. -4. Update task notes/final summary with the live-process root cause (`--texthooker` serving HTML on 5174 with no 6678 listener). - - -## Implementation Notes - - -Live-process repro on the user's machine: `ps` showed the active process as `/tmp/.mount_SubMin.../SubMiner --texthooker --port 5174`. `lsof` showed 5174 listening but no listener on 6678/6677, while `curl http://127.0.0.1:5174/` confirmed the served page was correctly bootstrapped to `ws://127.0.0.1:6678`. That proved the remaining failure was startup mode, not page injection. - -Root cause: `runAppReadyRuntime(...)` had an early `texthookerOnlyMode` return that reloaded config and handled initial args, but skipped `createMpvClient()`, subtitle websocket startup, annotation websocket startup, subtitle timing tracker creation, and the later texthooker-only branch that only skips the overlay window. - -Fix: removed the early texthooker-only short-circuit so texthooker-only mode now runs the normal startup pipeline, then falls through to the existing `Texthooker-only mode enabled; skipping overlay window.` branch. - -Verification: `bun run typecheck`; focused Bun tests for app-ready startup, startup bootstrap, CLI texthooker startup, and CLI context wiring. Existing local live-binary repro still reflects the old mounted AppImage until rebuilt/restarted. Current-binary workaround is to launch normal startup / `--start --texthooker` instead of plain `--texthooker`. - - -## Final Summary - - -Fixed the second texthooker regression: plain `--texthooker` mode was serving the page but skipping mpv/websocket initialization, so the page pointed at `ws://127.0.0.1:6678` with no listener. Removed the early texthooker-only startup return, kept the later overlay-skip behavior, updated the startup regression test to require websocket/mpv initialization in texthooker-only mode, and re-verified with typecheck plus focused test coverage. - diff --git a/backlog/tasks/task-258 - Stop-plugin-auto-start-from-spawning-separate-texthooker-helper.md b/backlog/tasks/task-258 - Stop-plugin-auto-start-from-spawning-separate-texthooker-helper.md deleted file mode 100644 index 4428d945..00000000 --- a/backlog/tasks/task-258 - Stop-plugin-auto-start-from-spawning-separate-texthooker-helper.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-258 -title: Stop plugin auto-start from spawning separate texthooker helper -status: Done -assignee: - - codex -created_date: '2026-03-30 06:25' -updated_date: '2026-03-31 19:37' -labels: - - bug - - texthooker - - launcher - - plugin - - startup -dependencies: [] -priority: high -ordinal: 158500 ---- - -## Description - - -Change the mpv/plugin auto-start path so normal SubMiner startup owns texthooker and websocket startup inside the main `--start` app instance. Keep standalone `subminer texthooker` / plain `--texthooker` available for explicit external use, but stop the plugin from spawning a second helper subprocess during regular auto-start. - - -## Acceptance Criteria - -- [x] #1 Plugin auto-start includes texthooker on the main `--start` command when texthooker is enabled. -- [x] #2 Plugin auto-start no longer spawns a separate standalone `--texthooker` helper subprocess during normal startup. -- [x] #3 Regression coverage fails before the fix and passes after the fix for the plugin auto-start path. -- [x] #4 Standalone external `subminer texthooker` / plain `--texthooker` entrypoints remain available for explicit helper use. - - -## Implementation Plan - - -1. Flip the mpv/plugin start-gate regression so enabled texthooker is folded into the main `--start` command and standalone helper subprocesses are rejected. -2. Update plugin process command construction so `start` includes `--texthooker` when enabled and the separate helper-launch path becomes a no-op for normal auto-start. -3. Run plugin Lua regressions, adjacent launcher tests, and typecheck to verify behavior and preserve explicit standalone `--texthooker` entrypoints. - - -## Implementation Notes - - -Design approved by user: normal in-app startup should own texthooker/websocket; `texthookerOnlyMode` should stay explicit external-only. - -Root cause path: mpv/plugin auto-start in `plugin/subminer/process.lua` launched `binary_path --start ...` and then separately spawned `binary_path --texthooker --port ...`. That created the standalone helper process observed live (`SubMiner --texthooker --port 5174`) instead of relying on the normal app instance. - -Fix: `build_command_args('start', overrides)` now appends `--texthooker` when texthooker is enabled, and the old helper-launch path is reduced to a no-op so normal auto-start remains single-process. - -Verification: `lua scripts/test-plugin-start-gate.lua`, `lua scripts/test-plugin-process-start-retries.lua`, `bun test launcher/mpv.test.ts launcher/commands/playback-command.test.ts launcher/config/args-normalizer.test.ts`, and `bun run typecheck`. Standalone launcher/app entrypoints for explicit `subminer texthooker` / plain `--texthooker` were left untouched. - - -## Final Summary - - -Stopped the mpv/plugin auto-start path from spawning a second standalone texthooker helper. Texthooker now rides on the main `--start` app instance for normal startup, with Lua regressions updated to require `--texthooker` on the main start command and reject separate helper subprocesses. Explicit standalone `subminer texthooker` / plain `--texthooker` entrypoints remain available. - diff --git a/backlog/tasks/task-259 - Fix-integrated-start-texthooker-startup-skipping-texthooker-server.md b/backlog/tasks/task-259 - Fix-integrated-start-texthooker-startup-skipping-texthooker-server.md deleted file mode 100644 index 9a902963..00000000 --- a/backlog/tasks/task-259 - Fix-integrated-start-texthooker-startup-skipping-texthooker-server.md +++ /dev/null @@ -1,34 +0,0 @@ ---- -id: TASK-259 -title: Fix integrated --start --texthooker startup skipping texthooker server -status: Done -assignee: [] -created_date: '2026-03-30 06:48' -updated_date: '2026-03-31 19:37' -labels: - - bug - - texthooker - - startup -dependencies: [] -priority: high -ordinal: 157500 ---- - -## Description - - -Integrated overlay startup with `--start --texthooker` currently takes the minimal-startup path because startup mode flags treat any `args.texthooker` as texthooker-only. That skips app-ready texthooker service startup, so no server binds on port 5174 during normal SubMiner playback launches. - - -## Acceptance Criteria - -- [x] #1 `--start --texthooker` uses full app-ready startup instead of minimal texthooker-only startup -- [x] #2 Integrated playback launch starts the texthooker server on the configured/default port -- [x] #3 Regression tests cover the startup-mode classification and integrated startup behavior - - -## Final Summary - - -Narrowed texthooker-only startup classification so integrated `--start --texthooker` no longer takes the minimal-startup path. Added CLI arg regression coverage, rebuilt the AppImage, installed it to `~/.local/bin/SubMiner.AppImage` with a timestamped backup, restarted against `/tmp/subminer-socket`, and verified listeners on 5174/6677/6678 plus browser connection state `Connected with ws://127.0.0.1:6678`. - diff --git a/backlog/tasks/task-260 - Fix-macOS-overlay-subtitle-sidebar-passthrough-without-requiring-a-subtitle-hover-cycle.md b/backlog/tasks/task-260 - Fix-macOS-overlay-subtitle-sidebar-passthrough-without-requiring-a-subtitle-hover-cycle.md deleted file mode 100644 index 490f732d..00000000 --- a/backlog/tasks/task-260 - Fix-macOS-overlay-subtitle-sidebar-passthrough-without-requiring-a-subtitle-hover-cycle.md +++ /dev/null @@ -1,68 +0,0 @@ ---- -id: TASK-260 -title: >- - Fix macOS overlay subtitle sidebar passthrough without requiring a subtitle - hover cycle -status: Done -assignee: - - '@codex' -created_date: '2026-03-31 00:58' -updated_date: '2026-03-31 19:37' -labels: - - bug - - macos - - overlay - - subtitle-sidebar - - passthrough -dependencies: [] -references: - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/modals/subtitle-sidebar.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/renderer/overlay-mouse-ignore.ts - - /Users/sudacode/projects/japanese/SubMiner/src/renderer/handlers/mouse.ts - - /Users/sudacode/projects/japanese/SubMiner/src/main/overlay-runtime.ts - - >- - /Users/sudacode/projects/japanese/SubMiner/src/core/services/overlay-visibility.ts -documentation: - - docs/workflow/verification.md -priority: high -ordinal: 156500 ---- - -## Description - - -On macOS, opening the overlay-layout subtitle sidebar should allow click-through outside the sidebar immediately. Users should not need to first hover subtitle content before passthrough/click-through starts working, including when no subtitle line is currently visible. - - -## Acceptance Criteria - -- [x] #1 With the overlay-layout subtitle sidebar open on macOS, areas outside the sidebar pass clicks through immediately after open without requiring a prior subtitle hover. -- [x] #2 When no subtitle line is currently visible, opening the subtitle sidebar still leaves non-sidebar overlay regions click-through on macOS. -- [x] #3 Regression coverage exercises the first-open/idle passthrough path so overlay interactivity does not depend on a later hover cycle. - - -## Implementation Plan - - -1. Add/adjust focused overlay visibility regressions for the tracked macOS visible overlay so the default idle state stays click-through instead of forcing mouse interaction. -2. Update main-process visible overlay visibility sync to keep the tracked macOS overlay passive by default and let renderer hover/sidebar state opt into interaction. -3. Run focused verification for overlay visibility and any dependent runtime tests, then update task notes/criteria/final summary with the confirmed outcome. - - -## Implementation Notes - - -Investigation points to a main-process override on macOS: renderer sidebar open path already requests mouse passthrough outside the panel, but visible-overlay visibility sync still hard-sets the tracked overlay window interactive on macOS (`mouse-ignore:false`). Window-tracker focus/visibility resync can therefore undo renderer passthrough until a later hover cycle re-applies it. - -Added a failing regression in `src/core/services/overlay-visibility.test.ts` showing the tracked macOS visible overlay was still forced interactive by main-process visibility sync (`mouse-ignore:false`) instead of staying forwarded click-through. - -Updated `src/core/services/overlay-visibility.ts` so tracked macOS visible overlays now default to `setIgnoreMouseEvents(true, { forward: true })`, matching the renderer-side passthrough model and preventing window-tracker/focus resync from undoing idle sidebar clickthrough. - - -## Final Summary - - -Fixed the macOS subtitle-sidebar passthrough regression by changing tracked visible-overlay startup/visibility sync to stay click-through by default in the main process. Previously `updateVisibleOverlayVisibility` forced the macOS overlay window interactive, which could override renderer sidebar passthrough until a later hover cycle repaired it. Added a regression in `src/core/services/overlay-visibility.test.ts` and verified with `bun test src/core/services/overlay-visibility.test.ts`, `bun test src/renderer/modals/subtitle-sidebar.test.ts src/renderer/handlers/mouse.test.ts`, and `bun run typecheck`. - diff --git a/backlog/tasks/task-261 - Fix-immersion-tracker-SQLite-timestamp-truncation.md b/backlog/tasks/task-261 - Fix-immersion-tracker-SQLite-timestamp-truncation.md deleted file mode 100644 index a228d753..00000000 --- a/backlog/tasks/task-261 - Fix-immersion-tracker-SQLite-timestamp-truncation.md +++ /dev/null @@ -1,40 +0,0 @@ ---- -id: TASK-261 -title: Fix immersion tracker SQLite timestamp truncation -status: Done -assignee: [] -created_date: '2026-03-31 01:45' -updated_date: '2026-03-31 19:37' -labels: - - immersion-tracker - - sqlite - - bug -dependencies: [] -references: - - src/core/services/immersion-tracker -priority: medium -ordinal: 179500 ---- - -## Description - - -Current-epoch millisecond values are being truncated by the libsql driver when bound as numeric parameters, which corrupts session, telemetry, lifetime, and rollup timestamps. - - -## Acceptance Criteria - -- [x] #1 Current-epoch millisecond timestamps persist correctly in session, telemetry, lifetime, and rollup tables -- [x] #2 Startup backfill and destroy/finalize flows keep retained sessions and lifetime summaries consistent -- [x] #3 Regression tests cover the destroyed-session, startup backfill, and distinct-day/distinct-video lifetime semantics - - -## Implementation Notes - - -2026-03-31 assessment: epoch-ms timestamp writes now route through `toDbMs()` / `toDbTimestamp()` in `src/core/services/immersion-tracker/query-shared.ts`, which avoids libsql numeric-parameter truncation by binding BigInt/string values before they hit SQLite. The fix is wired through the session, storage/telemetry, lifetime, and rollup-maintenance paths in `src/core/services/immersion-tracker/session.ts`, `src/core/services/immersion-tracker/storage.ts`, `src/core/services/immersion-tracker/lifetime.ts`, and `src/core/services/immersion-tracker/maintenance.ts`. - -Acceptance coverage is present: `bun test src/core/services/immersion-tracker-service.test.ts` passed with explicit regressions for destroy/finalize persistence, startup backfill when retained sessions exist but lifetime tables are empty, startup reconciliation of stale active sessions, `rebuildLifetimeSummaries`, and distinct-day / distinct-video lifetime semantics. `bun test src/core/services/immersion-tracker/time.test.ts src/core/services/immersion-tracker/maintenance.test.ts` also passed. - -Remaining action item before close: fix the two `src/main/runtime/stats-cli-command.test.ts` cleanup-lifetime assertions that currently use Bun-misparsed underscored millisecond literals (`1_710_000_000_000` evaluates to `-2147483648` under Bun 1.3.11), rerun that verification lane, then write the final summary and mark the task Done. - diff --git a/backlog/tasks/task-262 - Fix-duplicate-AniList-post-watch-updates-for-watched-episodes.md b/backlog/tasks/task-262 - Fix-duplicate-AniList-post-watch-updates-for-watched-episodes.md deleted file mode 100644 index 51890073..00000000 --- a/backlog/tasks/task-262 - Fix-duplicate-AniList-post-watch-updates-for-watched-episodes.md +++ /dev/null @@ -1,51 +0,0 @@ ---- -id: TASK-262 -title: Fix duplicate AniList post-watch updates for watched episodes -status: Done -assignee: - - codex -created_date: '2026-03-31 19:03' -updated_date: '2026-03-31 19:37' -labels: - - bug - - anilist -dependencies: [] -ordinal: 155500 ---- - -## Description - - -Watching an episode can currently produce two AniList activity updates for the same episode. The duplicate happens when the post-watch flow drains a queued retry for the current episode and then proceeds to run the live post-watch update for that same media/episode in the same pass. User report says this reproduces both when crossing the watched threshold naturally and when using the mark-watched keybinding. Fix the duplicate so one successful watch produces at most one AniList progress update for a given mediaKey/episode pair. - - -## Acceptance Criteria - -- [x] #1 A watched episode triggers at most one AniList post-watch progress update for a given media key and episode during a single post-watch pass, even if that episode already exists in the retry queue. -- [x] #2 Both watched-threshold and manual mark-watched flows are protected by regression coverage for the duplicate-update case. -- [x] #3 Relevant user-visible change note is added if required by repo policy. - - -## Implementation Plan - - -1. Reproduce the duplicate in a unit test around `createMaybeRunAnilistPostWatchUpdateHandler` by simulating a ready retry for the same `mediaKey::episode` the live path would also submit. -2. Fix the handler so that after processing a queued retry, it does not perform a second live update when the retry already satisfied the current attempt key. -3. Run focused AniList runtime tests and adjacent immersion tests to confirm both threshold-driven and manual mark-watched entry points stay covered through the shared post-watch path. - - -## Implementation Notes - - -Added a regression in `src/main/runtime/anilist-post-watch.test.ts` for the case where `processNextAnilistRetryUpdate()` already satisfies the current `mediaKey::episode` before the live path runs. - -Updated `createMaybeRunAnilistPostWatchUpdateHandler` to re-check `hasAttemptedUpdateKey(attemptKey)` immediately after draining the retry queue and short-circuit before a second live AniList submission. - -Verification: `bun test src/main/runtime/anilist-post-watch.test.ts src/main/runtime/anilist-post-watch-main-deps.test.ts`; `bun test src/core/services/immersion-tracker-service.test.ts --test-name-pattern 'recordPlaybackPosition marks watched at 85% completion|markActiveVideoWatched'`; `bun run typecheck`; `bun run changelog:lint`. - - -## Final Summary - - -Fixed duplicate AniList post-watch submissions by short-circuiting the live update path when a ready retry item already handled the current `mediaKey::episode` in the same pass. Added a focused regression test for the retry-plus-live duplicate scenario and a changelog fragment documenting the fix. - diff --git a/backlog/tasks/task-263 - Reuse-pre-add-duplicate-IDs-for-generic-Kiku-field-grouping.md b/backlog/tasks/task-263 - Reuse-pre-add-duplicate-IDs-for-generic-Kiku-field-grouping.md deleted file mode 100644 index c09e9050..00000000 --- a/backlog/tasks/task-263 - Reuse-pre-add-duplicate-IDs-for-generic-Kiku-field-grouping.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-263 -title: Reuse pre-add duplicate IDs for generic Kiku field grouping -status: Done -assignee: [] -created_date: '2026-03-31 20:44' -updated_date: '2026-03-31 20:48' -labels: - - anki - - kiku -dependencies: [] -priority: high ---- - -## Description - - -Avoid the extra post-add duplicate lookup on the generic sentence-card creation path by capturing duplicate note IDs before add and reusing that result for Kiku field grouping. Keep Yomitan semantics aligned where practical so duplicate selection is consistent across mining paths. - - -## Acceptance Criteria - -- [x] #1 Generic sentence-card creation captures duplicate note IDs before add and reuses them for Kiku field grouping instead of running the existing post-add duplicate finder -- [x] #2 Duplicate selection remains deterministic when multiple matching notes exist -- [x] #3 Regression tests cover the generic path duplicate reuse behavior and preserve existing non-Kiku behavior -- [x] #4 Internal docs/config comments are updated if the behavior or operator-facing semantics changed - - -## Implementation Notes - - -No docs update was required because this is internal duplicate-selection plumbing and does not change user-facing config surface. - - -## Final Summary - - -Generic sentence-card creation now captures exact duplicate note IDs before add when Kiku field grouping is enabled and stores that context by created note ID. Manual field grouping reuses the tracked duplicate IDs first and deterministically picks the most recent matching note, falling back to the legacy duplicate finder only when no tracked context exists. Verified with bun test src/anki-integration/duplicate.test.ts src/anki-integration/card-creation.test.ts src/anki-integration/field-grouping.test.ts and bun run typecheck. - diff --git a/backlog/tasks/task-263.1 - Reuse-Yomitan-popup-duplicate-IDs-in-SubMiner-bridge.md b/backlog/tasks/task-263.1 - Reuse-Yomitan-popup-duplicate-IDs-in-SubMiner-bridge.md deleted file mode 100644 index 7caf7fe4..00000000 --- a/backlog/tasks/task-263.1 - Reuse-Yomitan-popup-duplicate-IDs-in-SubMiner-bridge.md +++ /dev/null @@ -1,41 +0,0 @@ ---- -id: TASK-263.1 -title: Reuse Yomitan popup duplicate IDs in SubMiner bridge -status: Done -assignee: [] -created_date: '2026-03-31 22:15' -updated_date: '2026-03-31 22:21' -labels: - - anki - - kiku - - yomitan -dependencies: [] -parent_task_id: TASK-263 -priority: high ---- - -## Description - - -Thread Yomitan popup/search duplicate note IDs through the existing SubMiner bridge so Kiku/manual grouping can reuse the same duplicate context that already drives the Add duplicate button. Implement and test against the vendored Yomitan copy first; do not rely on upstreamed fork changes yet. - - -## Acceptance Criteria - -- [x] #1 Vendored Yomitan bridge returns duplicate note IDs for popup/search mining when available -- [x] #2 SubMiner consumes the bridged duplicate IDs and prefers them for Kiku/manual grouping on the Yomitan mining path -- [x] #3 Regression tests cover the popup/search bridge payload and duplicate-id reuse behavior -- [x] #4 No commit is made for vendored Yomitan-only changes in this repo state - - -## Implementation Notes - - -Vendored files changed locally for validation only: vendor/subminer-yomitan/ext/js/display/display-anki.js, vendor/subminer-yomitan/ext/js/comm/api.js, vendor/subminer-yomitan/ext/js/comm/anki-connect.js, vendor/subminer-yomitan/ext/js/background/backend.js. Do not commit those vendor changes in this repo; port them to the fork instead. - - -## Final Summary - - -Vendored Yomitan popup/search mining now precomputes duplicate note IDs, sends them to the SubMiner Anki proxy as private addNote metadata, and still returns note/duplicate data through the parser bridge. The proxy strips the private metadata before forwarding to upstream AnkiConnect, associates the duplicate IDs with the created note before auto-enrichment begins, and SubMiner also records the bridge result as a secondary cache path. Verified with bun test src/anki-integration/duplicate.test.ts src/anki-integration/card-creation.test.ts src/anki-integration/field-grouping.test.ts src/anki-integration/anki-connect-proxy.test.ts src/core/services/tokenizer/yomitan-parser-runtime.test.ts and bun run typecheck. - diff --git a/backlog/tasks/task-263.2 - Keep-Yomitan-popup-responsive-during-background-add-and-pause-close-before-Kiku-modal.md b/backlog/tasks/task-263.2 - Keep-Yomitan-popup-responsive-during-background-add-and-pause-close-before-Kiku-modal.md deleted file mode 100644 index 5b663ab9..00000000 --- a/backlog/tasks/task-263.2 - Keep-Yomitan-popup-responsive-during-background-add-and-pause-close-before-Kiku-modal.md +++ /dev/null @@ -1,43 +0,0 @@ ---- -id: TASK-263.2 -title: >- - Keep Yomitan popup responsive during background add and pause/close before - Kiku modal -status: Done -assignee: [] -created_date: '2026-04-01 00:42' -updated_date: '2026-04-01 02:35' -labels: - - anki - - yomitan - - kiku - - ux -dependencies: [] -parent_task_id: TASK-263 -priority: high ---- - -## Description - - -Make Yomitan popup add run in background without blocking popup responsiveness. Before opening Kiku field-grouping modal, pause MPV and close the Yomitan popup/parser window if open. - - -## Definition of Done - -- [x] #1 Popup save path returns immediately and prevents duplicate submits -- [x] #2 Field-grouping modal request pauses MPV and closes Yomitan popup window first -- [x] #3 Regression tests cover async save dispatch and main-side pause/close hook - - -## Implementation Notes - - -2026-03-31: Removed the custom pending label/gray save-button presentation from vendored Yomitan. Background add still runs asynchronously with the internal pending-save guard, so duplicate clicks are ignored while the button keeps its stock appearance. - - -## Final Summary - - -Yomitan popup save dispatches note creation/add in the background with an internal pending-save guard so repeated clicks are ignored without blocking the popup. Before opening the Kiku field-grouping modal, the renderer now closes the visible lookup popup and pauses MPV. Follow-up UX polish removed the custom pending label/gray styling so the save button keeps Yomitan’s stock presentation while the background action runs. - diff --git a/backlog/tasks/task-264 - Replace-axios-with-native-fetch-across-the-project.md b/backlog/tasks/task-264 - Replace-axios-with-native-fetch-across-the-project.md deleted file mode 100644 index 1ca38e59..00000000 --- a/backlog/tasks/task-264 - Replace-axios-with-native-fetch-across-the-project.md +++ /dev/null @@ -1,26 +0,0 @@ ---- -id: TASK-264 -title: Replace axios with native fetch across the project -status: To Do -assignee: [] -created_date: '2026-04-01 00:44' -labels: [] -dependencies: [] -priority: medium ---- - -## Description - - -Remove axios from the codebase and migrate all project HTTP requests to the platform fetch API, preserving existing request behavior and error handling where applicable. - - -## Acceptance Criteria - -- [ ] #1 No production code paths import or depend on axios. -- [ ] #2 All existing HTTP requests use fetch or a project-local abstraction built on fetch. -- [ ] #3 Request behavior remains functionally equivalent for headers, query params, bodies, status handling, and abort/error cases that are currently supported. -- [ ] #4 Tests are updated or added to cover the migrated request flows. -- [ ] #5 Documentation is updated if any request semantics or setup steps change. -- [ ] #6 axios is removed from project dependencies if it is no longer needed. - diff --git a/backlog/tasks/task-265 - Add-remote-backend-for-immersion-tracking-and-stats-prefer-Postgres.md b/backlog/tasks/task-265 - Add-remote-backend-for-immersion-tracking-and-stats-prefer-Postgres.md deleted file mode 100644 index c4410a6f..00000000 --- a/backlog/tasks/task-265 - Add-remote-backend-for-immersion-tracking-and-stats-prefer-Postgres.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-265 -title: Add remote backend for immersion tracking and stats (prefer Postgres) -status: To Do -assignee: [] -created_date: '2026-04-01 00:47' -labels: [] -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker-service.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/storage.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/immersion-tracker/sqlite.ts - - /home/sudacode/projects/japanese/SubMiner/src/stats-daemon-runner.ts - - /home/sudacode/projects/japanese/SubMiner/src/core/services/stats-server.ts - - /home/sudacode/projects/japanese/SubMiner/src/main/boot/services.ts - - /home/sudacode/projects/japanese/SubMiner/package.json -documentation: - - /home/sudacode/projects/japanese/SubMiner/docs/architecture/README.md - - >- - /home/sudacode/projects/japanese/SubMiner/docs/architecture/stats-trends-data-flow.md - - /home/sudacode/projects/japanese/SubMiner/README.md - - /home/sudacode/projects/japanese/SubMiner/config.example.jsonc -priority: high ---- - -## Description - - -Enable immersion tracking/stats to use a remote authoritative backend so multiple devices can share the same history. - -Current state: `ImmersionTrackerService` opens a local `immersion.sqlite` file from the app data/config path, `stats-daemon-runner` points at that same local file, and `config.example.jsonc` only exposes `immersionTracking.dbPath` for a local path override. The stats API/dashboard reads from the same tracker service and assumes the local database is the source of truth. - -Goal: add a remote backend option that avoids shared filesystem/database-file syncing between devices. Do not use SSH/rsync/shared network filesystem as the primary sync strategy for live multi-device use. - -Backend choice: prefer Postgres if it can be integrated without a broad new dependency surface or destabilizing the current runtime; otherwise use the least invasive remote backend that can be shipped with the current stack and document the tradeoff clearly. Preserve the current local SQLite mode as the default/offline fallback if possible. - -This ticket should cover the full product/architecture change: configuration, storage access, stats reads, startup/error handling, migration/bootstrap from existing local data, tests, and docs. - - -## Acceptance Criteria - -- [ ] #1 The app can be configured to use a remote authoritative backend for immersion tracking instead of only a local `immersion.sqlite` file. -- [ ] #2 The chosen backend persists tracker writes and serves the existing stats read models across app restarts. -- [ ] #3 Two devices can point at the same remote backend without relying on a shared filesystem or raw SQLite file sync. -- [ ] #4 Local SQLite remains supported as the default or fallback mode for offline use. -- [ ] #5 If the remote backend is unavailable or misconfigured, startup/write paths fail with actionable errors instead of silent data loss. -- [ ] #6 A migration or bootstrap path exists to move existing local immersion data into the remote backend or seed a new device from it. -- [ ] #7 Config/examples/docs explain the backend choice, required connection/setup details, and any security/network assumptions. -- [ ] #8 Tests cover backend selection plus at least one representative write/read path against the remote backend. - diff --git a/backlog/tasks/task-266 - Preserve-paused-state-for-configured-subtitle-jump-keybindings.md b/backlog/tasks/task-266 - Preserve-paused-state-for-configured-subtitle-jump-keybindings.md deleted file mode 100644 index d480d437..00000000 --- a/backlog/tasks/task-266 - Preserve-paused-state-for-configured-subtitle-jump-keybindings.md +++ /dev/null @@ -1,34 +0,0 @@ ---- -id: TASK-266 -title: Preserve paused state for configured subtitle-jump keybindings -status: Done -assignee: [] -created_date: '2026-04-01 03:19' -updated_date: '2026-04-01 03:19' -labels: - - renderer - - mpv - - keybindings - - regression -dependencies: [] -priority: high ---- - -## Description - - -Regression: configured overlay keybindings that forward raw mpv subtitle-jump commands (for example previous-subtitle on H) can resume playback when invoked while paused. Keyboard-driven edge jumps already preserve paused state; configured keybindings should match that behavior. - - -## Acceptance Criteria - -- [x] #1 Configured subtitle-jump keybindings preserve paused playback state after backward seek -- [x] #2 Existing keyboard-driven subtitle navigation behavior remains unchanged -- [x] #3 Regression test covers paused configured subtitle-jump keybinding handling - - -## Final Summary - - -Configured overlay keybindings that forward `sub-seek` commands now re-check paused state and reapply pause after the seek when playback was already paused. This aligns raw configured subtitle-jump keybindings with the existing keyboard-driven edge-jump behavior and adds regression coverage for the paused backward-seek case. - diff --git a/backlog/tasks/task-267 - Port-validated-Yomitan-popup-changes-to-fork-and-resync-submodule.md b/backlog/tasks/task-267 - Port-validated-Yomitan-popup-changes-to-fork-and-resync-submodule.md deleted file mode 100644 index 84332bdc..00000000 --- a/backlog/tasks/task-267 - Port-validated-Yomitan-popup-changes-to-fork-and-resync-submodule.md +++ /dev/null @@ -1,34 +0,0 @@ ---- -id: TASK-267 -title: Port validated Yomitan popup changes to fork and resync submodule -status: Done -assignee: [] -created_date: '2026-04-01 03:30' -updated_date: '2026-04-01 03:33' -labels: - - yomitan - - submodule - - git - - integration -dependencies: [] -priority: high ---- - -## Description - - -Take the locally validated Yomitan popup/bridge changes from the vendored copy, apply them to the standalone `../subminer-yomitan` fork, verify the fork, push the fork commit, then reset the vendored working tree in SubMiner and update the submodule pointer to the pushed fork commit. - - -## Acceptance Criteria - -- [x] #1 Standalone `../subminer-yomitan` contains the validated popup/bridge changes and passes the relevant regression test -- [x] #2 The fork commit is pushed to its configured remote branch -- [x] #3 SubMiner vendored Yomitan working tree is reset and the submodule pointer is updated to the pushed fork commit - - -## Final Summary - - -Applied the validated popup/bridge changes from the vendored Yomitan copy into `../subminer-yomitan`, added the focused async-save regression test there, installed fork deps, and verified with `npx vitest run test/display-anki-save.test.js`. Committed the fork changes as `feat: preserve async popup save state and duplicate metadata`, rebased onto the updated remote `main`, and pushed commit `69620abc` to `origin/main`. Then reset the vendored submodule working tree in SubMiner, checked it out at `69620abc`, and left the superproject with the submodule pointer updated from `3c9ee577` to `69620abc`. - diff --git a/backlog/tasks/task-268 - Address-CodeRabbit-review-action-items-for-PR-38.md b/backlog/tasks/task-268 - Address-CodeRabbit-review-action-items-for-PR-38.md deleted file mode 100644 index 52f156f7..00000000 --- a/backlog/tasks/task-268 - Address-CodeRabbit-review-action-items-for-PR-38.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-268 -title: 'Address CodeRabbit review action items for PR #38' -status: Done -assignee: [] -created_date: '2026-04-01 05:35' -updated_date: '2026-04-01 06:07' -labels: - - pr-review - - coderabbit -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/38' -priority: medium ---- - -## Description - - -Review unresolved CodeRabbit feedback on PR #38 and implement the actionable fixes without regressing duplicate grouping or popup behavior. - - -## Acceptance Criteria - -- [x] #1 All unresolved actionable CodeRabbit review comments on PR #38 are triaged and either fixed in code or explicitly identified as non-actionable or ambiguous. -- [x] #2 Code changes preserve duplicate grouping and popup flow behavior covered by existing or added regression tests. -- [x] #3 Relevant local verification for the affected areas passes. - - -## Implementation Notes - - -2026-04-01: Reopened for follow-up CodeRabbit round after commit 233bde58. Remaining actionable items: guard maxMatches <= 0 in duplicate exact-match helper and strengthen the duplicate tracking test fixture to prove deduplication as well as sorting. - -2026-04-01: Follow-up round addressed locally. Added guard for maxMatches <= 0 in duplicate exact-match scanning and strengthened the pre-add duplicate tracking test fixture to prove deduplication as well as sorting. - - -## Final Summary - - -Addressed all unresolved actionable CodeRabbit comments on PR #38. Fixed duplicate tracking so empty duplicate lists are not persisted after sentence-card creation, sanitized Yomitan add-note noteId values to accept only positive integers, preserved paused playback for configured subtitle-seek keybindings when pause state is unknown, and short-circuited duplicate exact-match scanning for single-result lookups. Added regression tests for each case and verified with `bun test` on the affected suites plus `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, and `bun run test:smoke:dist`. - -Follow-up CodeRabbit round addressed locally: `findExactDuplicateNoteIds()` now returns early when `maxMatches <= 0`, and the sentence-card duplicate tracking regression test now uses a repeated duplicate ID to assert deduplication plus sorting. Re-verified with targeted duplicate/card tests, `bun run typecheck`, and `bun run test:fast`. - diff --git a/backlog/tasks/task-270 - Make-Windows-mpv-shortcut-self-contained.md b/backlog/tasks/task-270 - Make-Windows-mpv-shortcut-self-contained.md deleted file mode 100644 index 44f2098e..00000000 --- a/backlog/tasks/task-270 - Make-Windows-mpv-shortcut-self-contained.md +++ /dev/null @@ -1,30 +0,0 @@ ---- -id: TASK-270 -title: Make Windows mpv shortcut self-contained -status: Done -assignee: [] -created_date: '2026-04-02 07:13' -updated_date: '2026-04-02 07:19' -labels: [] -dependencies: [] -priority: medium ---- - -## Description - - -Remove the Windows mpv shortcut's dependency on a pre-existing mpv profile so the installer-created `SubMiner mpv` flow works out of the box without requiring the user to edit `mpv.conf`. Keep docs aligned with the new behavior and preserve the optional profile guidance for manual mpv usage. - - -## Acceptance Criteria - -- [x] #1 `SubMiner.exe --launch-mpv` launches mpv with SubMiner's required default args without requiring an mpv profile named `subminer`. -- [x] #2 Windows shortcut/help/docs no longer describe `--launch-mpv` as depending on the SubMiner mpv profile. -- [x] #3 Automated tests cover the Windows launch args behavior and pass after the change. - - -## Final Summary - - -Updated the Windows `--launch-mpv` path to pass SubMiner's default mpv args directly instead of requiring `--profile=subminer`. Adjusted Windows shortcut/help text to describe the self-contained defaults-based launch, and updated Windows docs to state that `mpv.conf` is not required for the shortcut path while preserving the optional profile guidance for manual mpv launches. - diff --git a/backlog/tasks/task-271 - Fix-local-playback-subtitle-auto-selection-and-startup-pause-release.md b/backlog/tasks/task-271 - Fix-local-playback-subtitle-auto-selection-and-startup-pause-release.md deleted file mode 100644 index 18777c8a..00000000 --- a/backlog/tasks/task-271 - Fix-local-playback-subtitle-auto-selection-and-startup-pause-release.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-271 -title: Fix local playback subtitle auto-selection and startup pause release -status: Done -assignee: - - codex -created_date: '2026-04-03 07:47' -updated_date: '2026-04-03 08:03' -labels: - - bug - - playback - - subtitles -dependencies: [] ---- - -## Description - - -Investigate local-video startup on desktop playback where managed subtitle defaults can bind the wrong primary subtitle track and startup readiness retries can force playback to resume after the user manually pauses. Scope includes fixing the pause/unpause loop and making local subtitle auto-selection prefer the intended primary/secondary tracks for sentence mining sessions. - - -## Acceptance Criteria - -- [x] #1 Desktop local playback no longer forces `pause=no` after the user manually pauses during or after startup readiness handling. -- [x] #2 Managed local subtitle startup selects the expected primary track before secondary track selection for mixed-language subtitle sets like Japanese primary plus English secondary. -- [x] #3 Regression tests cover the pause-release bug and the local subtitle auto-selection behavior. -- [x] #4 Internal docs are updated if runtime behavior or operator expectations change. - - -## Implementation Plan - - -1. Add regression coverage for startup autoplay release so duplicate ready handling cannot unpause playback after the user manually pauses the same media. -2. Add regression coverage for managed local subtitle startup selection using configured primary/secondary subtitle language preferences, with JA/EN remaining the default fallback behavior. -3. Extract or add reusable subtitle track ranking logic that prefers configured primary and secondary subtitle languages, with stable scoring for external tracks and non-SDH labels. -4. Update local playback startup/runtime wiring so managed subtitle defaults use explicit ranked selection instead of raw sid=auto / secondary-sid=auto while preserving config-driven language preference ordering. -5. Run focused subtitle/playback tests, then update task notes/final summary with any behavior or docs impact. - - -## Implementation Notes - - -Implemented config-aware managed local subtitle selection runtime for local media path changes and playlist-browser local playback rearm, using `youtube.primarySubLanguages` for primary preference and `secondarySub.secondarySubLanguages` for secondary preference with JA/EN fallback defaults. - -Updated autoplay ready gate to ignore duplicate readiness signals for the same media so later manual pauses are not overridden by repeated tokenization-ready events. - -Updated config/template wording to document that the existing subtitle language preferences now drive managed subtitle auto-selection beyond YouTube-only flows. - -Verification: `bun test src/config/config.test.ts src/main/runtime/autoplay-ready-gate.test.ts src/main/runtime/local-subtitle-selection.test.ts src/main/runtime/playlist-browser-runtime.test.ts`; `bun run typecheck`. - - -## Final Summary - - -Stopped startup readiness retries from re-unpausing the same media after a later manual pause, and added config-aware managed local subtitle selection so local playback prefers the configured primary/secondary subtitle languages instead of relying on raw mpv `sid=auto` behavior. Added regression coverage for autoplay-ready gating, local subtitle selection, playlist-browser local playback rearm, and config template wording updates. - diff --git a/backlog/tasks/task-273 - Fix-first-run-setup-false-positive-when-canonical-mpv-plugin-is-already-installed.md b/backlog/tasks/task-273 - Fix-first-run-setup-false-positive-when-canonical-mpv-plugin-is-already-installed.md deleted file mode 100644 index 28b93a9b..00000000 --- a/backlog/tasks/task-273 - Fix-first-run-setup-false-positive-when-canonical-mpv-plugin-is-already-installed.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-273 -title: >- - Fix first-run setup false positive when canonical mpv plugin is already - installed -status: Done -assignee: - - Kyle Yasuda -created_date: '2026-04-03 23:26' -updated_date: '2026-04-04 00:31' -labels: - - bug - - macos - - first-run-setup -dependencies: [] -priority: high ---- - -## Description - - -Investigate and fix launcher/app first-run setup gating so playback does not block when the SubMiner mpv plugin is already installed at the canonical mpv config path on macOS. Align mpv path resolution with the actual install location, keep plugin detection scoped to the canonical plugin entrypoint, and make launcher setup gating resilient to stale cancelled setup state. - - -## Acceptance Criteria - -- [ ] #1 `resolveDefaultMpvInstallPaths` resolves the canonical macOS mpv config path used by existing installs. -- [ ] #2 Playback launcher bypasses first-run setup when the canonical `scripts/subminer/main.lua` plugin entrypoint already exists, even if `setup-state.json` is stale. -- [ ] #3 Regression tests cover canonical plugin detection and launcher handling of stale cancelled setup state. - - -## Implementation Notes - - -Root cause ended up split across path resolution and launcher gating. No automated test command was executed in this pass by request. - - -## Final Summary - - -Updated macOS mpv install path resolution to use the canonical `~/.config/mpv` location so first-run plugin detection matches the actual installed plugin path. - -Restricted plugin detection to the canonical `scripts/subminer/main.lua` entrypoint instead of config presence or legacy loader files. - -Updated the launcher setup gate to bypass stale `setup-state.json` when the mpv plugin is already installed, and to ignore an initially stale `cancelled` state after spawning setup. - -Added regression coverage for canonical macOS detection and launcher setup-gate bypass behavior. No automated test command was executed in this pass by request. - - -## Definition of Done - -- [ ] #1 Manual verification with scenario: existing plugin installed in custom mpv config path does not open first-run setup. - diff --git a/backlog/tasks/task-274 - Stabilize-current-failing-test-regressions.md b/backlog/tasks/task-274 - Stabilize-current-failing-test-regressions.md deleted file mode 100644 index 4369e3f1..00000000 --- a/backlog/tasks/task-274 - Stabilize-current-failing-test-regressions.md +++ /dev/null @@ -1,59 +0,0 @@ ---- -id: TASK-274 -title: Stabilize current failing test regressions -status: Done -assignee: - - codex -created_date: '2026-04-04 04:40' -updated_date: '2026-04-04 05:01' -labels: [] -dependencies: [] -documentation: - - docs/workflow/verification.md - - docs/architecture/README.md -priority: high ---- - -## Description - - -Investigate and fix the current src/test failures across stats CLI lifetime rebuild handling, immersion tracker lifetime rebuild idempotency, renderer test environment cleanup helpers, subtitle sidebar auto-follow behavior, and log retention pruning so the maintained test lanes pass again. - - -## Acceptance Criteria - -- [x] #1 Stats CLI lifetime rebuild behavior passes the current regression coverage. -- [x] #2 Immersion tracker lifetime rebuild backfill remains idempotent under the existing runtime test. -- [x] #3 Renderer modal test helpers restore injected globals exactly to prior state. -- [x] #4 Log pruning removes files older than the configured retention window deterministically. -- [x] #5 Relevant targeted test files pass after the fixes. - - -## Implementation Plan - - -1. Reproduce the failing specs in isolation to separate deterministic regressions from suite-order pollution. -2. Fix source or test-helper logic for the three isolated failures: log retention cutoff, stats CLI lifetime rebuild timestamp handling, and subtitle sidebar initial jump behavior. -3. Harden renderer modal cleanup regressions so tests verify descriptor restoration without assuming global window/document start absent. -4. Re-run the targeted failing files, then the required verification gate for the touched areas and record results. - - -## Implementation Notes - - -Targeted regressions fixed in log pruning, stats CLI lifetime logging/tests, subtitle sidebar auto-follow timing, and renderer global cleanup test isolation. - -Verification: `bun test src/main/runtime/stats-cli-command.test.ts src/shared/log-files.test.ts src/renderer/modals/playlist-browser.test.ts src/renderer/modals/youtube-track-picker.test.ts src/renderer/modals/subtitle-sidebar.test.ts` passed. - -Verification: `bun run test:src` still exits non-zero because of unrelated existing errors in `src/core/services/anilist/anilist-token-store.test.ts` (`Bun.serve is not a function`) plus one remaining non-task failure elsewhere; the originally reported regressions are green in the maintained lane. - -User reported `test:full` still failing after the first regression pass. Reopened to clear the remaining `test:src` fail plus the existing unhandled test errors before handoff. - -Verified final gate with `bun run test:launcher:unit:src` and `bun run test:full`; both pass after fixing the launcher AniSkip fallback title regression and the earlier src-lane regressions. - - -## Final Summary - - -Stabilized the failing test regressions across source and launcher lanes. Fixed log pruning cutoff math under Bun BigInt mtimes, subtitle sidebar auto-follow timing, renderer global cleanup test isolation, stats CLI lifetime rebuild logging/tests, stats-server node:http fallback isolation, and launcher AniSkip fallback title resolution so basename titles beat generic parent directories while episode-only filenames still prefer the series directory. Verification passed with `bun test launcher/aniskip-metadata.test.ts`, `bun run test:launcher:unit:src`, and `bun run test:full`. - diff --git a/backlog/tasks/task-275 - Patch-high-severity-audit-findings-with-minimal-dependency-changes.md b/backlog/tasks/task-275 - Patch-high-severity-audit-findings-with-minimal-dependency-changes.md deleted file mode 100644 index 5901d823..00000000 --- a/backlog/tasks/task-275 - Patch-high-severity-audit-findings-with-minimal-dependency-changes.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-275 -title: Patch high-severity audit findings with minimal dependency changes -status: Done -assignee: - - codex -created_date: '2026-04-04 04:45' -updated_date: '2026-04-04 04:50' -labels: - - security - - dependencies -dependencies: [] ---- - -## Description - - -Update SubMiner's direct Electron runtime and vulnerable build-time transitive dependencies to patched versions using the smallest safe version moves. Keep electron-builder on the current pinned line unless verification shows a blocker. Verify that bun audit no longer reports the current high-severity findings and that the standard project gate still passes. - - -## Acceptance Criteria - -- [x] #1 Electron is updated to a patched supported release on the current supported line with no broader dependency refresh -- [x] #2 Vulnerable transitive packages @xmldom/xmldom, lodash, and picomatch resolve to patched versions via targeted dependency changes -- [x] #3 `bun audit --audit-level high` no longer reports the currently listed high-severity findings -- [x] #4 The default handoff verification gate passes, or any failure is documented with the exact command and error output -- [x] #5 Any dependency or lockfile changes remain minimal and do not change the pinned electron-builder line unless required - - -## Implementation Plan - - -1. Update package.json with the smallest set of dependency changes: bump electron from ^37.10.3 to 39.8.6 and add overrides for @xmldom/xmldom 0.8.12, lodash 4.18.0, and picomatch 4.0.4 while leaving electron-builder pinned at 26.8.2. -2. Refresh bun.lock with a lockfile-only install/update and confirm the resolved versions for electron, @xmldom/xmldom, lodash, and picomatch. -3. Run bun audit --audit-level high and verify the current high-severity findings are gone. -4. Run the default verification gate: bun run typecheck, bun run test:fast, bun run test:env, bun run build, bun run test:smoke:dist. -5. If any verification step fails, capture the exact failing command and error, assess whether it is caused by the dependency updates, and stop without broadening scope. - - -## Implementation Notes - - -Updated package.json to pin electron 39.8.6 and add overrides for @xmldom/xmldom 0.8.12, lodash 4.18.0, and picomatch 4.0.4 while keeping electron-builder pinned at 26.8.2. - -Refreshed bun.lock with bun install and confirmed the patched versions resolved in the lockfile. - -Verification passed: bun audit --audit-level high, bun run typecheck, bun run test:fast, bun run test:env, bun run build, bun run test:smoke:dist. - -Added changelog fragment changes/patch-audit-dependencies.md for the security/dependency maintenance update. No internal docs or docs-site updates were needed because the change does not alter user-facing behavior, configuration, or workflows. - - -## Final Summary - - -Cleared the reported high-severity audit findings with minimal dependency churn by pinning electron to 39.8.6 and overriding @xmldom/xmldom, lodash, and picomatch to patched versions. Kept electron-builder on 26.8.2. bun audit is clean and the full default handoff gate passed: typecheck, fast tests, env tests, build, and dist smoke tests. - diff --git a/backlog/tasks/task-276 - Restore-canonical-SubMiner-Linux-app-id-metadata.md b/backlog/tasks/task-276 - Restore-canonical-SubMiner-Linux-app-id-metadata.md deleted file mode 100644 index b7f6ca82..00000000 --- a/backlog/tasks/task-276 - Restore-canonical-SubMiner-Linux-app-id-metadata.md +++ /dev/null @@ -1,62 +0,0 @@ ---- -id: TASK-276 -title: Restore canonical SubMiner Linux app-id metadata -status: Done -assignee: - - codex -created_date: '2026-04-04 06:31' -updated_date: '2026-04-04 06:34' -labels: - - bug - - linux - - electron -dependencies: [] -priority: medium ---- - -## Description - - -Fix the Linux/Wayland packaged app metadata so the OS-facing desktop/app-id metadata stays canonical `SubMiner` instead of the lowercase npm package name `subminer`. Add regression coverage around packaged metadata so future Electron/runtime changes do not silently reintroduce the lowercase class/app-id behavior. - - -## Acceptance Criteria - -- [x] #1 Top-level package metadata provides the canonical capitalized app name used by Electron runtime bootstrap on Linux -- [x] #2 Packaged Linux app metadata resolves to `SubMiner`/`SubMiner.desktop` instead of lowercase `subminer` -- [x] #3 Regression coverage fails before the fix and passes after it - - -## Implementation Plan - - -1. Add a focused packaging/runtime regression test that reads the packaged app metadata source and asserts the Linux Electron bootstrap-visible fields resolve to canonical `SubMiner` / `SubMiner.desktop`. -2. Run the targeted test first to capture the failing pre-fix state. -3. Update top-level package metadata in `package.json` with the canonical Electron runtime-facing fields needed for Linux bootstrap. -4. Re-run the targeted test and a lightweight packaging validation to confirm the packaged metadata now stays canonical. -5. Record verification notes and complete the task if all acceptance criteria pass. - - -## Implementation Notes - - -Added a regression in `src/release-workflow.test.ts` asserting top-level `productName` and `desktopName` stay canonical for Linux Electron runtime bootstrap. Verified the new test failed before the fix because both fields were missing from top-level package metadata. - -Updated top-level `package.json` metadata with `productName: SubMiner` and `desktopName: SubMiner.desktop` so packaged `app.asar` exposes the canonical Linux startup identity Electron reads before app code runs. - -Verification passed with `bun test src/release-workflow.test.ts`, `bun run build && ./node_modules/.bin/electron-builder --linux dir --publish never`, packaged `release/linux-unpacked/resources/app.asar` inspection showing `{ name: subminer, productName: SubMiner, desktopName: SubMiner.desktop }`, and `bun run changelog:lint`. - -Ran the full default handoff gate after the targeted/package verification: `bun run typecheck`, `bun run test:fast`, `bun run test:env`, and `bun run test:smoke:dist` all passed. - - -## Final Summary - - -Restored canonical Linux/Wayland app identity metadata by adding top-level Electron runtime fields to `package.json`: `productName: SubMiner` and `desktopName: SubMiner.desktop`. This fixes the packaged app metadata Electron reads before user code runs, so native Wayland compositors no longer need to derive the app-id/class from the lowercase npm package name alone. - -Added a regression test in `src/release-workflow.test.ts` that asserts the runtime-visible top-level metadata stays canonical. The new test was run first and failed before the fix because `productName` was missing, then passed after the metadata update. - -Verification: `bun test src/release-workflow.test.ts`; `bun run build && ./node_modules/.bin/electron-builder --linux dir --publish never`; inspected `release/linux-unpacked/resources/app.asar` and confirmed `productName: SubMiner` plus `desktopName: SubMiner.desktop`; `bun run changelog:lint`. Added changelog fragment `changes/2026-04-04-linux-app-id-metadata.md`. - -Full default handoff gate also passed: `bun run typecheck`; `bun run test:fast`; `bun run test:env`; `bun run test:smoke:dist`. - diff --git a/backlog/tasks/task-277 - Restore-Linux-shortcut-backed-modal-actions-after-Electron-39-upgrade.md b/backlog/tasks/task-277 - Restore-Linux-shortcut-backed-modal-actions-after-Electron-39-upgrade.md deleted file mode 100644 index 35f89b4b..00000000 --- a/backlog/tasks/task-277 - Restore-Linux-shortcut-backed-modal-actions-after-Electron-39-upgrade.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-277 -title: Restore Linux shortcut-backed modal actions after Electron 39 upgrade -status: Done -assignee: - - codex -created_date: '2026-04-04 06:49' -updated_date: '2026-04-04 07:08' -labels: - - bug - - linux - - electron - - shortcuts -dependencies: [] -priority: high ---- - -## Description - - -Linux builds on Electron 39 no longer open the runtime options, Jimaku, or Subsync flows from their configured shortcuts (`Ctrl/Cmd+Shift+O`, `Ctrl+Shift+J`, `Ctrl+Alt+S`). Other renderer-driven modals like session help, subtitle sidebar, and playlist browser still work, which points to the Linux `globalShortcut` / overlay shortcut path rather than modal rendering in general. Investigate the Electron 39 regression and restore these Linux shortcut-triggered actions without regressing macOS or Windows behavior. - - -## Acceptance Criteria - -- [x] #1 On Linux, the configured runtime options, Jimaku, and Subsync shortcuts trigger their existing actions again under Electron 39. -- [x] #2 The fix is covered by automated tests around the Linux shortcut/backend behavior that regressed. -- [x] #3 A changelog fragment is added for the Linux shortcut regression fix. - - -## Implementation Plan - - -1. Extend the special-command / mpv IPC command path to cover Jimaku alongside the existing runtime-options and subsync commands. -2. Add tests for IPC command dispatch and any keybinding/session-help metadata affected by the new special command. -3. Route Linux modal-opening shortcuts through the working mpv/IPC command path instead of depending on Electron globalShortcut delivery for those actions. -4. Re-run targeted tests, then the handoff verification gate, and update the changelog/task summary to reflect the final root cause and fix. - - -## Implementation Notes - - -User approved plan; proceeding with test-first implementation. - -Root cause: Linux startup unconditionally enabled Electron's GlobalShortcutsPortal path, so Electron 39 X11 sessions were routed through the portal-backed globalShortcut path even though that path should only be used for Wayland-style launches. The affected runtime-options, Jimaku, and Subsync actions all depend on that shortcut path, while renderer-driven modals did not regress. - -User retested after the portal gating fix; issue persists. Updating investigation scope from portal selection alone to Linux overlay shortcut delivery/registration under Electron 39. - -Revised fix path: Linux renderer now matches configured overlay shortcuts for runtime options, subsync, and Jimaku locally, then dispatches the existing mpv/IPC special-command route instead of depending on Electron globalShortcut delivery. - -Added Jimaku mpv special command plumbing through IPC/runtime deps and exposed an overlay-runtime helper for opening the Jimaku modal from that IPC path. - - -## Final Summary - - -Restored Linux shortcut-backed modal actions by routing runtime options, Subsync, and Jimaku through the working mpv/IPC special-command path. Added renderer-side Linux shortcut matching for configured overlay shortcuts, threaded a new Jimaku special command through IPC/runtime deps, refreshed configured shortcuts on hot reload, and covered the regression with IPC/runtime keyboard tests. Verification: bun test src/core/services/ipc-command.test.ts src/renderer/handlers/keyboard.test.ts src/main/runtime/ipc-mpv-command-main-deps.test.ts; bun run typecheck; bun run test:fast; bun run test:env; bun run build; bun run test:smoke:dist. - diff --git a/backlog/tasks/task-278 - Prepare-patch-release-0.11.1.md b/backlog/tasks/task-278 - Prepare-patch-release-0.11.1.md deleted file mode 100644 index 83020b79..00000000 --- a/backlog/tasks/task-278 - Prepare-patch-release-0.11.1.md +++ /dev/null @@ -1,67 +0,0 @@ ---- -id: TASK-278 -title: Prepare patch release 0.11.1 -status: Done -assignee: - - '@codex' -created_date: '2026-04-04 07:16' -updated_date: '2026-04-04 07:41' -labels: - - release -dependencies: [] -priority: medium ---- - -## Description - - -Bump SubMiner from 0.11.0 to 0.11.1, run the local release checklist, and confirm whether the branch is ready for tagging/publishing. - - -## Acceptance Criteria - -- [x] #1 package.json is bumped to 0.11.1 without overwriting unrelated local metadata edits. -- [x] #2 Release prep checks are run and summarized, including changelog/build verification and local build/test gates. -- [x] #3 Any remaining release blockers are called out explicitly. - - -## Implementation Plan - - -1. Generate release metadata with `bun run changelog:build --version 0.11.1 --date 2026-04-04`. -2. Review the resulting `CHANGELOG.md` and `release/release-notes.md` content for the 0.11.1 section. -3. Rerun the documented local release gate: `bun run changelog:check --version 0.11.1`, `bun run verify:config-example`, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, and `bun run build`. -4. Record results, remaining blockers, and ready-for-tagging status in the task notes/final summary. - - -## Implementation Notes - - -Bumped package.json from 0.11.0 to 0.11.1 while preserving the existing local productName/desktopName edits. - -Fixed the Linux shortcut changelog fragment metadata so changelog lint now passes and the previously failing CI cause is addressed locally. - -Release checks run: bun run changelog:lint, bun run changelog:check --version 0.11.1, bun run verify:config-example, bun run typecheck, bun run test:fast, bun run test:env, bun run build. All passed except changelog:check, which is expected until pending fragments are built into CHANGELOG.md/release/release-notes.md. - -Current release blocker: pending changelog fragments /changes/2026-04-04-linux-app-id-metadata.md and /changes/2026-04-04-linux-shortcut-portal-regression.md still need bun run changelog:build --version 0.11.1 --date 2026-04-04 before tagging. - -Reopened to complete the remaining release-prep work: generate changelog/release notes artifacts, rerun the documented release gate, and confirm ready-for-tagging status. - -Completed the remaining release-prep step with `bun run changelog:build --version 0.11.1 --date 2026-04-04`, which prepended `CHANGELOG.md`, generated `release/release-notes.md`, and removed the two pending `changes/*.md` fragments. - -Reran the release gate after changelog generation: `bun run changelog:check --version 0.11.1`, `bun run verify:config-example`, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, and `bun run build`; all passed. - -Extra confidence checks also passed: `bun run changelog:lint`, `bun run test:smoke:dist`, and `gh run list --workflow CI --limit 5` shows the two latest `main` CI runs succeeded on 2026-04-04 after the earlier pre-fix failure. - -`release/release-notes.md` is intentionally generated under the gitignored `release/` directory, so readiness evidence in git status is `CHANGELOG.md` plus deletion of the released change fragments. - - -## Final Summary - - -Finished the 0.11.1 release prep by generating the changelog artifacts from the pending Linux fix fragments and re-running the full documented local release gate. `CHANGELOG.md` now contains the `v0.11.1 (2026-04-04)` section, `release/release-notes.md` was regenerated in the ignored `release/` directory, and the released `changes/2026-04-04-linux-app-id-metadata.md` plus `changes/2026-04-04-linux-shortcut-portal-regression.md` fragments were removed. - -Verification results: `bun run changelog:check --version 0.11.1`, `bun run verify:config-example`, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, `bun run changelog:lint`, and `bun run test:smoke:dist` all passed locally. Remote CI also looks green for the latest release-prep head: `gh run list --workflow CI --limit 5` showed successful `main` runs for `chore: prep 0.11.1 release` and `Change demo image link to GitHub asset` on 2026-04-04, with the earlier `fix: restore linux modal shortcuts` failure already superseded by later green runs. - -Remaining manual release step: commit the generated release-prep changes if desired, tag `v0.11.1`, and push the commit plus tag when ready. - diff --git a/backlog/tasks/task-279 - Fix-Linux-AppImage-child-process-libffmpeg-resolution.md b/backlog/tasks/task-279 - Fix-Linux-AppImage-child-process-libffmpeg-resolution.md deleted file mode 100644 index 99255af4..00000000 --- a/backlog/tasks/task-279 - Fix-Linux-AppImage-child-process-libffmpeg-resolution.md +++ /dev/null @@ -1,62 +0,0 @@ ---- -id: TASK-279 -title: Fix Linux AppImage child-process libffmpeg resolution -status: Done -assignee: - - '@codex' -created_date: '2026-04-05 17:17' -updated_date: '2026-04-05 17:56' -labels: [] -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/issues/41' -documentation: - - docs/workflow/verification.md -priority: high ---- - -## Description - - -Fix the Linux AppImage packaging so Chromium child processes relaunched from the bundled binary can resolve the packaged libffmpeg shared library and SubMiner starts cleanly instead of crash-looping on network-service restarts. - - -## Acceptance Criteria - -- [x] #1 Linux AppImage packaging ensures bundled Chromium child processes can resolve the packaged libffmpeg shared library during relaunch. -- [x] #2 Regression coverage exercises the Linux packaging/build configuration that provides the AppImage shared-library path. -- [x] #3 Release notes/changelog reflect the Linux AppImage startup fix. - - -## Implementation Plan - - -1. Add focused regression tests for Linux release packaging that assert the build config invokes an `afterPack` hook and that the hook stages bundled `libffmpeg.so` into `usr/lib` for AppImage runtime lookup. -2. Implement a small electron-builder `afterPack` hook that runs only for Linux, copies `libffmpeg.so` from the packaged app root into `usr/lib`, and no-ops when the source library is absent. -3. Wire the hook into `package.json` build config and add a changelog fragment for the Linux AppImage startup fix. -4. Run the focused test lane first, then the default handoff gate because the change touches release-sensitive packaging behavior. - - -## Implementation Notes - - -Chose a repo-local electron-builder `afterPack` hook instead of patching/forking `electron-builder`. The hook copies bundled `libffmpeg.so` from the packaged Linux app root into `usr/lib`, matching the AppImage runtime's existing `LD_LIBRARY_PATH` search path. - -Added regression coverage for both config wiring (`src/release-workflow.test.ts`) and the hook behavior (`scripts/electron-builder-after-pack.test.ts`), then wired the new script test into `test:fast` so the maintained lane keeps exercising the fix. - -Verification passed: `bun test scripts/electron-builder-after-pack.test.ts src/release-workflow.test.ts`, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, `bun run test:smoke:dist`. - -Addressed PR #45 CodeRabbit review thread: Linux `afterPack` staging now hard-fails when `libffmpeg.so` is missing instead of silently no-oping. Updated focused hook tests to assert the new failure contract and that `afterPack` propagates Linux staging errors. - - -## Final Summary - - -Added a shared electron-builder `afterPack` hook at `scripts/electron-builder-after-pack.cjs` and wired it into `package.json` so Linux packaging stages the bundled `libffmpeg.so` into `usr/lib` inside the packaged app. This keeps Chromium child relaunches compatible with the AppImage runtime's existing `LD_LIBRARY_PATH` layout without forking or patching upstream `electron-builder`. - -Regression coverage now checks both the packaging config and the hook behavior: `src/release-workflow.test.ts` asserts the hook stays wired into release config, and `scripts/electron-builder-after-pack.test.ts` verifies Linux copies `libffmpeg.so` into `usr/lib` while non-Linux and missing-library cases no-op safely. The new script test is included in `test:fast`, and a changelog fragment was added under `changes/fix-appimage-libffmpeg-path.md`. - -Verification passed with `bun test scripts/electron-builder-after-pack.test.ts src/release-workflow.test.ts`, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, and `bun run test:smoke:dist`. - -Follow-up review fix on PR #45: Linux packaging now throws when `libffmpeg.so` is missing from the packaged app root, preventing silent shipment of a broken AppImage. Focused regression coverage was updated so the missing-library case rejects and `afterPack` propagates the failure. - diff --git a/backlog/tasks/task-280 - Force-launcher-spawned-mpv-onto-X11-when-backend-resolves-to-x11-or-no-supported-Wayland-tracker-is-available.md b/backlog/tasks/task-280 - Force-launcher-spawned-mpv-onto-X11-when-backend-resolves-to-x11-or-no-supported-Wayland-tracker-is-available.md deleted file mode 100644 index d7502337..00000000 --- a/backlog/tasks/task-280 - Force-launcher-spawned-mpv-onto-X11-when-backend-resolves-to-x11-or-no-supported-Wayland-tracker-is-available.md +++ /dev/null @@ -1,59 +0,0 @@ ---- -id: TASK-280 -title: >- - Force launcher-spawned mpv onto X11 when backend resolves to x11 or no - supported Wayland tracker is available -status: Done -assignee: - - codex -created_date: '2026-04-05 21:01' -updated_date: '2026-04-05 21:05' -labels: - - bug - - linux - - launcher - - overlay -dependencies: [] -priority: high ---- - -## Description - - -On Linux Plasma Wayland and similar sessions, `subminer --backend=x11` currently only changes SubMiner's window-tracker override. The launcher still spawns mpv without forcing an X11/XWayland backend, so the X11 tracker cannot find the mpv window and the overlay remains hidden. Update launcher-side mpv spawn behavior so launcher-managed mpv runs under X11 when backend resolves to `x11`, and also when auto detection cannot resolve to a supported Wayland tracker. Preserve existing Hyprland/Sway behavior. - - -## Acceptance Criteria - -- [x] #1 Launcher-managed mpv is spawned with X11/XWayland-forcing environment/config when backend resolves to `x11`. -- [x] #2 Linux auto mode falls back to X11/XWayland-forced mpv when no supported Wayland tracker backend is detected. -- [x] #3 Hyprland and Sway launcher flows do not regress to forced X11 mpv. -- [x] #4 Regression tests cover launcher env/backend selection for these Linux cases. - - -## Implementation Plan - - -1. Add focused launcher tests that assert the mpv spawn environment forces X11 when backend resolves to `x11`, and when Linux auto mode cannot use a supported Wayland tracker. -2. Refactor launcher mpv spawn code to compute an mpv-specific environment without changing existing Hyprland/Sway flows. -3. Route all launcher-managed mpv spawns through the new environment helper. -4. Run focused launcher tests, then summarize behavior and any remaining verification gaps. - - -## Implementation Notes - - -User approved scope: force launcher-managed mpv to X11 for explicit `--backend=x11` and for unsupported Linux Wayland auto-detect fallback; preserve Hyprland/Sway behavior. - -Implemented launcher-side `buildMpvEnv` to strip Wayland hints and force X11/XWayland for launcher-managed mpv when `--backend=x11`, and for Linux auto mode on unsupported Wayland desktops with an X11 display available. Wired both normal mpv launches and idle detached mpv launches through the helper. - -Verification: `bun test launcher/mpv.test.ts --test-name-pattern "buildMpvEnv"` passed; `bun run tsc --noEmit` passed. A broader `bun test launcher/mpv.test.ts` run still hits a pre-existing sandbox-specific failure in `launchAppCommandDetached handles child process spawn errors` because this environment cannot write the default app log path under `/home/sudacode/.config/SubMiner/logs`. - - -## Final Summary - - -Updated the launcher so mpv gets an X11/XWayland-oriented spawn environment whenever the user explicitly requests `--backend=x11`, and when Linux auto mode is running under an unsupported Wayland desktop that still exposes an X11 display. The new helper reuses the launcher child-process base environment, strips Wayland-specific hints (`WAYLAND_DISPLAY`, Hyprland/Sway markers), and flips `XDG_SESSION_TYPE` to `x11` only for those fallback cases. Both foreground mpv launches and detached idle mpv launches now use the same helper so overlay-tracked playback stays consistent. - -Added focused regression coverage in `launcher/mpv.test.ts` for three cases: explicit `x11` forcing, unsupported Wayland auto fallback (for example KDE Plasma Wayland), and preserving native Wayland env for supported Hyprland/Sway auto backends. Verification completed with `bun test launcher/mpv.test.ts --test-name-pattern "buildMpvEnv"` and `bun run tsc --noEmit`. A broader launcher mpv test run still shows an unrelated sandbox write failure for the default app log path in this environment. - diff --git a/backlog/tasks/task-281 - Prevent-Windows-launcher-tests-from-leaking-backslash-temp-files-on-POSIX.md b/backlog/tasks/task-281 - Prevent-Windows-launcher-tests-from-leaking-backslash-temp-files-on-POSIX.md deleted file mode 100644 index 6810b777..00000000 --- a/backlog/tasks/task-281 - Prevent-Windows-launcher-tests-from-leaking-backslash-temp-files-on-POSIX.md +++ /dev/null @@ -1,62 +0,0 @@ ---- -id: TASK-281 -title: Prevent Windows launcher tests from leaking backslash temp files on POSIX -status: Done -assignee: - - codex -created_date: '2026-04-05 21:13' -updated_date: '2026-04-05 21:20' -labels: - - tests - - launcher - - bug -dependencies: [] -documentation: - - /home/sudacode/github/SubMiner2/AGENTS.md -priority: medium ---- - -## Description - - -Windows-specific launcher tests in launcher/mpv.test.ts currently create real filesystem entries using path.win32.join(...) with a POSIX mkdtemp base. On Linux/macOS this produces literal backslash-named paths like \\tmp\\subminer-test-win-dir-* inside the repo/worktree, and the existing cleanup only removes the POSIX /tmp base directory. Fix the tests so they still cover Windows path resolution behavior without leaking stray files into the working tree. - - -## Acceptance Criteria - -- [x] #1 Running the Windows findAppBinary tests on a POSIX host does not create new untracked \\tmp\\subminer-test-win-* files in the repository root. -- [x] #2 The Windows launcher tests still validate PATH and install-directory resolution behavior. -- [x] #3 Relevant launcher tests pass after the change. - - -## Implementation Plan - - -1. Add a regression test in launcher/mpv.test.ts that exercises the Windows findAppBinary cases on a POSIX host and asserts they do not leave new backslash-named temp artifacts in the repository root. -2. Refactor the Windows launcher tests to avoid creating real filesystem paths from path.win32.join(...) on POSIX; keep Windows path assertions via stubs and only create real files with native POSIX paths where needed. -3. Run the targeted launcher tests and confirm no new \\tmp\\subminer-test-win-* artifacts appear in git status. - - -## Implementation Notes - - -Investigation: reproduced the leak locally. The source is launcher/mpv.test.ts Windows findAppBinary tests that combine a POSIX mkdtemp base with path.win32.join(...), creating literal backslash-named entries like \\tmp\\subminer-test-win-dir-* in the repo root. Existing cleanup only removes the POSIX /tmp base directory. - -User approved implementation plan on 2026-04-05. - -Implemented in launcher/mpv.test.ts by replacing the leaky Windows PATH/install-directory helpers with pure fs stubs (access/exists/stat) and fixed Windows path strings instead of creating real path.win32 filesystem entries on POSIX. Added a regression test that snapshots repo-root \\tmp\\subminer-test-win-* artifacts before/after running the Windows cases and asserts no new entries are created. - -Verification: `bun test launcher/mpv.test.ts --test-name-pattern 'findAppBinary Windows cases do not leak backslash temp artifacts on POSIX|findAppBinary resolves SubMiner.exe on PATH on Windows|findAppBinary resolves a Windows install directory to SubMiner.exe'` passed (3/3). `bun test launcher/mpv.test.ts` still has one unrelated pre-existing sandbox failure in `launchAppCommandDetached handles child process spawn errors` because the test opens `~/.config/SubMiner/logs/app-2026-04-05.log` and hits `EROFS` in this environment. - - -## Final Summary - - -Reworked the Windows `findAppBinary` tests in `launcher/mpv.test.ts` so they no longer create real backslash-named temp files on POSIX hosts. The PATH and install-directory cases now use synthetic Windows path strings plus `fs.accessSync` / `fs.existsSync` / `fs.statSync` stubs to exercise the same resolver behavior without writing `\\tmp\\subminer-test-win-*` entries into the repository root. - -Added a POSIX regression test that snapshots existing repo-root `\\tmp\\subminer-test-win-*` artifacts, runs the Windows path-resolution cases, and asserts the artifact set is unchanged. This catches future regressions where a Windows-path test accidentally writes literal backslash paths on Linux/macOS. - -Tests run: -- `bun test launcher/mpv.test.ts --test-name-pattern 'findAppBinary Windows cases do not leak backslash temp artifacts on POSIX|findAppBinary resolves SubMiner.exe on PATH on Windows|findAppBinary resolves a Windows install directory to SubMiner.exe'` -- `bun test launcher/mpv.test.ts` (all relevant `findAppBinary` tests passed; one unrelated existing sandbox failure remains in `launchAppCommandDetached handles child process spawn errors` due `EROFS` opening `~/.config/SubMiner/logs/...`) - diff --git a/backlog/tasks/task-282 - Force-launcher-managed-mpv-to-an-explicit-X11-GPU-context-when-X11-fallback-is-active.md b/backlog/tasks/task-282 - Force-launcher-managed-mpv-to-an-explicit-X11-GPU-context-when-X11-fallback-is-active.md deleted file mode 100644 index 9e0261e7..00000000 --- a/backlog/tasks/task-282 - Force-launcher-managed-mpv-to-an-explicit-X11-GPU-context-when-X11-fallback-is-active.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-282 -title: >- - Force launcher-managed mpv to an explicit X11 GPU context when X11 fallback is - active -status: Done -assignee: - - codex -created_date: '2026-04-05 21:14' -updated_date: '2026-04-05 21:15' -labels: - - bug - - linux - - launcher - - mpv - - overlay -dependencies: [] -priority: high ---- - -## Description - - -Follow-up to the launcher X11 fallback work: on Plasma Wayland, stripping Wayland env vars alone is not sufficient for launcher-managed mpv. mpv can still fail GPU initialization under the default video output path (`vo/gpu-next`) unless an explicit X11 GPU context is selected. Update launcher-managed mpv startup so X11 fallback mode also appends explicit mpv options for an X11 GPU context, while preserving supported Hyprland/Sway Wayland flows. - - -## Acceptance Criteria - -- [x] #1 Launcher-managed mpv appends explicit X11 GPU context args when explicit `--backend=x11` is used on Linux. -- [x] #2 Launcher-managed mpv appends the same explicit X11 GPU context args for Linux auto-mode fallback on unsupported Wayland desktops. -- [x] #3 Supported Hyprland/Sway Wayland flows do not receive the forced X11 GPU context args. -- [x] #4 Regression tests cover the forced-X11 mpv arg selection. - - -## Implementation Plan - - -1. Add focused launcher tests for explicit X11 GPU-context arg selection, unsupported Wayland auto fallback, and Hyprland/Sway no-regression cases. -2. Introduce a shared launcher helper that decides when mpv should be forced onto X11 fallback mode. -3. Use that helper to append explicit mpv X11 GPU-context args in both normal and detached idle mpv launch paths. -4. Run focused launcher tests plus TypeScript verification, then record remaining runtime follow-up guidance. - - -## Implementation Notes - - -User runtime log showed `vo/gpu-next` failing with `Failed initializing any suitable GPU context!` under forced-X11 playback, which indicates env forcing alone was insufficient. Selected `--gpu-context=x11egl,x11` as the explicit mpv fallback: prefer X11/EGL, with GLX as a compatibility fallback. - -Verification: `bun test launcher/mpv.test.ts --test-name-pattern "buildMpv(Env|BackendArgs)"` passed. `bun run tsc --noEmit` passed. - - -## Final Summary - - -Added explicit mpv backend args for launcher-managed X11 fallback mode. The launcher now uses a shared `shouldForceX11MpvBackend` decision for both env rewriting and mpv arg selection, so explicit `--backend=x11` and unsupported Linux Wayland auto fallback both append `--gpu-context=x11egl,x11` while still stripping Wayland env hints. This preserves supported Hyprland/Sway native Wayland flows and makes the X11 fallback more explicit for mpv's GPU initialization path. - -Wired the new X11 GPU-context args into both the normal playback launch path and the detached idle mpv launch path. Added focused regression coverage for explicit `x11`, Plasma-style unsupported Wayland auto fallback, and Hyprland/Sway no-regression behavior. Verification completed with `bun test launcher/mpv.test.ts --test-name-pattern "buildMpv(Env|BackendArgs)"` and `bun run tsc --noEmit`. - diff --git a/backlog/tasks/task-283 - Force-launcher-managed-X11-fallback-to-mpv-vogpu-with-OpenGL-on-Linux.md b/backlog/tasks/task-283 - Force-launcher-managed-X11-fallback-to-mpv-vogpu-with-OpenGL-on-Linux.md deleted file mode 100644 index a2867f09..00000000 --- a/backlog/tasks/task-283 - Force-launcher-managed-X11-fallback-to-mpv-vogpu-with-OpenGL-on-Linux.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-283 -title: Force launcher-managed X11 fallback to mpv vo=gpu with OpenGL on Linux -status: Done -assignee: - - codex -created_date: '2026-04-05 21:19' -updated_date: '2026-04-05 21:20' -labels: - - bug - - linux - - launcher - - mpv - - overlay -dependencies: [] -priority: high ---- - -## Description - - -Follow-up to explicit X11 gpu-context forcing: Plasma Wayland runtime logs still show mpv using `vo/gpu-next` and failing to initialize any suitable GPU context under launcher-managed X11 fallback. Update launcher-managed mpv X11 fallback mode to force a more compatible renderer stack: `--vo=gpu`, `--gpu-api=opengl`, and `--gpu-context=x11egl,x11`, while preserving supported native Wayland flows and allowing explicit user mpv args to override later on the command line. - - -## Acceptance Criteria - -- [x] #1 Launcher-managed mpv appends `--vo=gpu`, `--gpu-api=opengl`, and `--gpu-context=x11egl,x11` when explicit `--backend=x11` is used on Linux. -- [x] #2 Launcher-managed mpv appends the same renderer args for Linux auto-mode fallback on unsupported Wayland desktops. -- [x] #3 Supported Hyprland/Sway Wayland flows do not receive the forced X11 renderer args. -- [x] #4 Regression tests cover the forced-X11 renderer arg selection. - - -## Implementation Plan - - -1. Tighten launcher tests so forced-X11 renderer args require `--vo=gpu`, `--gpu-api=opengl`, and `--gpu-context=x11egl,x11`. -2. Update the shared launcher X11-fallback helper to return the full renderer arg stack for explicit `x11` and unsupported Wayland auto fallback. -3. Re-run focused launcher env/backend tests and TypeScript verification. -4. Hand back with retry instructions and next debugging branch if runtime still fails. - - -## Implementation Notes - - -Runtime log still showed `[vo/gpu-next] Failed initializing any suitable GPU context!`, which meant forcing only the context was not enough. Updated the fallback to force the classic OpenGL renderer path too: `--vo=gpu --gpu-api=opengl --gpu-context=x11egl,x11`. - -Verification: `bun test launcher/mpv.test.ts --test-name-pattern "buildMpv(Env|BackendArgs)"` passed. `bun run tsc --noEmit` passed. - - -## Final Summary - - -Updated launcher-managed X11 fallback mode to force a more compatible mpv renderer stack on Linux: `--vo=gpu`, `--gpu-api=opengl`, and `--gpu-context=x11egl,x11`. This applies both to explicit `--backend=x11` and to unsupported Wayland auto fallback, while supported Hyprland/Sway Wayland sessions still keep their native path. The renderer args are still inserted before user-supplied `--args`, so an explicit user override can win later on the command line if needed. - -Adjusted regression coverage to require the full renderer stack for forced-X11 mode and verified the helper behavior with focused launcher tests plus TypeScript compilation. Verification completed with `bun test launcher/mpv.test.ts --test-name-pattern "buildMpv(Env|BackendArgs)"` and `bun run tsc --noEmit`. - diff --git a/backlog/tasks/task-284 - Fix-CI-changelog-fragment-requirement-for-launcher-X11-MPV-fallback-change.md b/backlog/tasks/task-284 - Fix-CI-changelog-fragment-requirement-for-launcher-X11-MPV-fallback-change.md deleted file mode 100644 index d502887f..00000000 --- a/backlog/tasks/task-284 - Fix-CI-changelog-fragment-requirement-for-launcher-X11-MPV-fallback-change.md +++ /dev/null @@ -1,32 +0,0 @@ ---- -id: TASK-284 -title: Fix CI changelog fragment requirement for launcher X11 MPV fallback change -status: Done -assignee: [] -created_date: '2026-04-05 22:21' -updated_date: '2026-04-05 22:22' -labels: - - ci - - changelog -dependencies: [] -priority: high ---- - -## Description - - -Current CI is failing in `changelog:pr-check` because PR changes release-relevant files but does not include a required entry under `changes/` and lacks `skip-changelog` label. Add a release fragment describing the behavioral change and verify the CI gate passes. - - -## Acceptance Criteria - -- [x] #1 Add a correctly formatted changelog fragment under `changes/` for the current change -- [x] #2 Run the local changelog PR check (or equivalent) with passing result -- [x] #3 Run required CI gate commands after change and confirm no regressions - - -## Final Summary - - -Added `changes/2026.04.05-mpv-x11-fallback.md` with launcher release-note metadata so `changelog:pr-check` can pass. Verified local CI gate commands: `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, `bun run test:smoke:dist` all passed. Ran manual PR changelog verification by invoking `verifyPullRequestChangelog` with current git diff plus the new fragment and confirmed it passes. - diff --git a/backlog/tasks/task-285 - Investigate-inconsistent-mpv-y-t-overlay-toggle-after-menu-toggle.md b/backlog/tasks/task-285 - Investigate-inconsistent-mpv-y-t-overlay-toggle-after-menu-toggle.md deleted file mode 100644 index 6b344005..00000000 --- a/backlog/tasks/task-285 - Investigate-inconsistent-mpv-y-t-overlay-toggle-after-menu-toggle.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -id: TASK-285 -title: Investigate inconsistent mpv y-t overlay toggle after menu toggle -status: To Do -assignee: [] -created_date: '2026-04-07 22:55' -updated_date: '2026-04-07 22:55' -labels: - - bug - - overlay - - keyboard - - mpv -dependencies: [] -references: - - plugin/subminer/process.lua - - plugin/subminer/ui.lua - - src/renderer/handlers/keyboard.ts - - src/main/runtime/autoplay-ready-gate.ts - - src/core/services/overlay-window-input.ts - - backlog/tasks/task-248 - Fix-macOS-visible-overlay-toggle-getting-immediately-restored.md -priority: high ---- - -## Description - - -User report: toggling the visible overlay with mpv `y-t` is inconsistent. After manually toggling through the `y-y` menu, `y-t` may allow one hide, but after toggling back on it can stop hiding the overlay again, forcing the user back into the menu path. - -Initial assessment: - -- no active backlog item currently tracks this exact report -- nearest prior work is `TASK-248`, which fixed a macOS-specific visible-overlay restore bug and is marked done -- current targeted regressions for the old fix surface pass, including plugin ready-signal suppression, focused-overlay `y-t` proxy dispatch, autoplay-ready gate deduplication, and blur-path restacking guards - -This should be treated as a fresh investigation unless reproduction proves it is the same closed macOS issue resurfacing on the current build. - - -## Acceptance Criteria - -- [ ] #1 Reproduce the reported `y-t` / `y-y` inconsistency on the affected platform and identify the exact event sequence -- [ ] #2 Determine whether the failure is in mpv plugin command dispatch, focused-overlay key forwarding, or main-process visible-overlay state transitions -- [ ] #3 Fix the inconsistency so repeated hide/show/hide cycles work from `y-t` without requiring menu recovery -- [ ] #4 Add regression coverage for the reproduced failing sequence -- [ ] #5 Record whether this is a regression of `TASK-248` or a distinct bug - - -## Implementation Plan - - -1. Reproduce the report with platform/build details and capture whether the failing `y-t` press originates in raw mpv or the focused overlay y-chord proxy path. -2. Trace visible-overlay state mutations across plugin toggle commands, autoplay-ready callbacks, and main-process visibility/window blur handling. -3. Patch the narrowest failing path and add regression coverage for the exact hide/show/hide sequence. -4. Re-run targeted plugin, overlay visibility, overlay window, and renderer keyboard suites before broader verification. - diff --git a/backlog/tasks/task-286 - Assess-and-address-PR-49-CodeRabbit-review-follow-ups.md b/backlog/tasks/task-286 - Assess-and-address-PR-49-CodeRabbit-review-follow-ups.md deleted file mode 100644 index 6f146ee1..00000000 --- a/backlog/tasks/task-286 - Assess-and-address-PR-49-CodeRabbit-review-follow-ups.md +++ /dev/null @@ -1,63 +0,0 @@ ---- -id: TASK-286 -title: 'Assess and address PR #49 CodeRabbit review follow-ups' -status: Done -assignee: - - codex -created_date: '2026-04-11 18:55' -updated_date: '2026-04-11 22:40' -labels: - - bug - - code-review - - windows - - overlay -dependencies: [] -references: - - src/main/runtime/config-hot-reload-handlers.ts - - src/renderer/handlers/keyboard.ts - - src/renderer/handlers/mouse.ts - - vendor/subminer-yomitan -priority: high ---- - -## Description - - -Track the current PR #49 review round and resolve the actionable CodeRabbit findings on the Windows update branch. - -Focus areas include the renderer mouse interaction fix, config hot-reload keyboard state, and any other review items that still apply after verifying the current branch state. - - -## Acceptance Criteria - -- [x] #1 All actionable CodeRabbit comments on PR #49 are either fixed or shown to be obsolete with evidence. -- [x] #2 Regression tests are added or updated for any behavior change that could regress. -- [x] #3 The branch passes the repo's relevant verification checks for the touched areas. - - -## Implementation Plan - - -1. Pull the current unresolved CodeRabbit review threads for PR #49 and cluster them into still-actionable fixes versus obsolete/nit-only items. -2. For each still-actionable behavior bug, add or extend the narrowest failing test first in the touched suite before changing production code. -3. Implement the minimal fixes across the affected runtime, renderer, plugin, IPC, and Windows tracker files, keeping each change traceable to the review thread. -4. Run targeted verification for the touched areas, update task notes with assessment results, and capture which review comments were fixed versus assessed as obsolete or deferred nitpicks. - - -## Implementation Notes - - -Assessed PR #49 CodeRabbit threads. Fixed the real regressions in first-run CLI gating, IPC session-action validation, renderer controller-modal lifecycle notifications, async subtitle-sidebar toggle guarding, plugin config-dir resolution priority, prerelease artifact upload failure handling, immersion tracker lazy startup, win32 z-order error handling, and Windows socket-aware mpv matching. - -Review assessment: the overlay-shortcut lifecycle comment is obsolete for the current architecture because overlay-local shortcuts are intentionally handled through the local fallback path and the runtime only tracks configured-state/cleanup. Refactor-only nit comments for splitting `scripts/build-changelog.ts` and `src/core/services/session-bindings.ts` were left as follow-up quality work, not behavior bugs in this PR round. - -Verification: `bun test src/main/runtime/first-run-setup-service.test.ts src/core/services/session-bindings.test.ts src/core/services/app-ready.test.ts src/core/services/ipc.test.ts src/renderer/handlers/keyboard.test.ts src/main/overlay-runtime.test.ts src/window-trackers/mpv-socket-match.test.ts`, `bun test src/window-trackers/windows-tracker.test.ts`, `bun run typecheck`, `lua scripts/test-plugin-lua-compat.lua`. - - -## Final Summary - - -Assessed the current CodeRabbit round on PR #49 and addressed the still-valid behavior issues rather than blanket-applying every bot suggestion. The branch now treats the new session/stats CLI flags as explicit startup commands during first-run setup, validates the new session actions through IPC, points session-binding command diagnostics at the correct config field, keeps immersion tracker startup lazy until later runtime triggers, and notifies overlay modal lifecycle state when controller-select/debug are opened from local keyboard bindings. I also switched the subtitle-sidebar IPC callback to the async guarded path so promise rejections feed renderer recovery instead of being dropped. - -On the Windows/plugin side, the mpv plugin now prefers config-file matches before falling back to an existing config directory, prerelease workflow uploads fail if expected Linux/macOS artifacts are missing, the Win32 z-order bind path now validates the `GetWindowLongW` call for the window above mpv, and the Windows tracker now passes the target socket path into native polling and filters mpv instances by command line so multiple sockets can be distinguished on Windows. Added/updated regression coverage for first-run gating, IPC validation, session-binding diagnostics, controller modal lifecycle notifications, modal ready-listener dispatch, and socket-path matching. Verification run: `bun run typecheck`, the targeted Bun test suites for the touched areas, `bun test src/window-trackers/windows-tracker.test.ts`, and `lua scripts/test-plugin-lua-compat.lua`. - diff --git a/backlog/tasks/task-286.1 - Assess-and-address-PR-49-subsequent-CodeRabbit-review-round.md b/backlog/tasks/task-286.1 - Assess-and-address-PR-49-subsequent-CodeRabbit-review-round.md deleted file mode 100644 index 9b86647f..00000000 --- a/backlog/tasks/task-286.1 - Assess-and-address-PR-49-subsequent-CodeRabbit-review-round.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -id: TASK-286.1 -title: 'Assess and address PR #49 subsequent CodeRabbit review round' -status: Done -assignee: [] -created_date: '2026-04-11 23:14' -updated_date: '2026-04-11 23:16' -labels: - - bug - - code-review - - windows - - release -dependencies: [] -references: - - .github/workflows/prerelease.yml - - src/window-trackers/mpv-socket-match.ts - - src/window-trackers/win32.ts - - src/core/services/overlay-shortcut.ts -parent_task_id: TASK-286 -priority: high ---- - -## Description - - -Track the next unresolved CodeRabbit review threads on PR #49 after commit 9ce5de2f and resolve the still-valid follow-up issues without reopening already-assessed stale comments. - - -## Acceptance Criteria - -- [x] #1 All still-actionable CodeRabbit comments in the latest PR #49 round are fixed or explicitly shown stale with evidence. -- [x] #2 Regression coverage is added or updated for any behavior-sensitive fix in workflow or Windows socket matching. -- [x] #3 Relevant verification passes for the touched workflow, tracker, and shared matcher changes. - - -## Implementation Plan - - -1. Verify the five unresolved CodeRabbit threads against current branch state and separate still-valid bugs from stale comments. -2. Add or extend the narrowest failing tests for exact socket-path matching and prerelease workflow invariants before changing production code. -3. Implement minimal fixes in the prerelease workflow and Windows socket matching/cache path, leaving stale comments documented with evidence instead of forcing no-op changes. -4. Run targeted verification, then record the fixed-vs-stale assessment and close the subtask. - - -## Implementation Notes - - -Assessed five unresolved PR #49 threads after 9ce5de2f. Fixed prerelease workflow cache keys to include `runner.arch`, changed prerelease publishing to validate artifacts before release creation/edit and only undraft after uploads complete, tightened Windows socket matching to require exact argument boundaries, and stopped memoizing null command-line lookup misses in the Win32 cache path. - -Stale assessment: the `src/core/services/overlay-shortcut.ts` thread is still obsolete. Current code at `registerOverlayShortcuts()` returns `hasConfiguredOverlayShortcuts(shortcuts)`, not `false`, and the overlay-local handling remains intentionally driven by local fallback dispatch rather than global registration in this runtime path. - -Verification: `bun test src/prerelease-workflow.test.ts src/window-trackers/mpv-socket-match.test.ts`, `bun test src/window-trackers/windows-tracker.test.ts src/prerelease-workflow.test.ts src/window-trackers/mpv-socket-match.test.ts`, `bun run typecheck`. - - -## Final Summary - - -Handled the next CodeRabbit round on PR #49 by fixing the still-valid prerelease workflow and Windows socket-matching issues while documenting the stale overlay-shortcut comment instead of forcing a no-op code change. The prerelease workflow now scopes all dependency caches by `runner.arch`, validates the final artifact set before touching the GitHub release, creates/edits the prerelease as a draft during uploads, and only flips `--draft=false` after all assets succeed. On Windows, socket matching now requires an exact `--input-ipc-server` argument boundary so `subminer-1` no longer matches `subminer-10`, and transient PowerShell/CIM misses no longer get cached forever as null command lines. - -Regression coverage was added for the workflow invariants and exact socket matching. Verification passed with targeted prerelease workflow tests, Windows tracker tests, socket-matcher tests, and `bun run typecheck`. - diff --git a/backlog/tasks/task-286.2 - Assess-and-address-PR-49-next-CodeRabbit-review-round.md b/backlog/tasks/task-286.2 - Assess-and-address-PR-49-next-CodeRabbit-review-round.md deleted file mode 100644 index 20c7fd67..00000000 --- a/backlog/tasks/task-286.2 - Assess-and-address-PR-49-next-CodeRabbit-review-round.md +++ /dev/null @@ -1,49 +0,0 @@ ---- -id: TASK-286.2 -title: 'Assess and address PR #49 next CodeRabbit review round' -status: Done -assignee: [] -created_date: '2026-04-12 02:50' -updated_date: '2026-04-12 02:52' -labels: - - bug - - code-review - - release - - testing -dependencies: [] -references: - - .github/workflows/prerelease.yml - - src/prerelease-workflow.test.ts - - src/core/services/overlay-shortcut.ts -parent_task_id: TASK-286 -priority: high ---- - -## Description - - -Track the next unresolved CodeRabbit review threads on PR #49 after commit 62ad77dc and resolve the still-valid follow-up issues while documenting stale repeats. - - -## Acceptance Criteria - -- [x] #1 All still-actionable CodeRabbit comments in the latest PR #49 round are fixed or explicitly shown stale with evidence. -- [x] #2 Regression coverage is updated for any workflow or test changes made in this round. -- [x] #3 Relevant verification passes for the touched workflow and prerelease test changes. - - -## Implementation Notes - - -Assessed latest unresolved CodeRabbit round on PR #49. `src/core/services/overlay-shortcut.ts` comment is stale: `registerOverlayShortcuts()` returns `hasConfiguredOverlayShortcuts(shortcuts)`, so runtime registration is not hard-coded false. - -Added exact, line-ending-agnostic prerelease tag trigger assertions in `src/prerelease-workflow.test.ts` and a regression asserting `bun run test:env` sits in the prerelease quality gate before source coverage. - -Updated `.github/workflows/prerelease.yml` quality-gate to run `bun run test:env` after `bun run test:fast`. - - -## Final Summary - - -Assessed the latest CodeRabbit round for PR #49. Left the `overlay-shortcut.ts` thread open as stale with code evidence, tightened prerelease workflow trigger coverage, and added the missing `test:env` step to the prerelease quality gate. Verification: `bun test src/prerelease-workflow.test.ts`; `bun run typecheck`. - diff --git a/backlog/tasks/task-286.3 - Assess-and-address-PR-49-latest-CodeRabbit-review-round.md b/backlog/tasks/task-286.3 - Assess-and-address-PR-49-latest-CodeRabbit-review-round.md deleted file mode 100644 index a15913a8..00000000 --- a/backlog/tasks/task-286.3 - Assess-and-address-PR-49-latest-CodeRabbit-review-round.md +++ /dev/null @@ -1,48 +0,0 @@ ---- -id: TASK-286.3 -title: 'Assess and address PR #49 latest CodeRabbit review round' -status: Done -assignee: [] -created_date: '2026-04-12 03:08' -updated_date: '2026-04-12 03:09' -labels: - - bug - - code-review - - testing -dependencies: [] -references: - - 'PR #49' - - .github/workflows/prerelease.yml - - src -parent_task_id: TASK-286 -priority: high ---- - -## Description - - -Track the newest unresolved CodeRabbit review threads on PR #49 after commit 942c1649, fix the still-valid issues, verify them, and push the branch update. - - -## Acceptance Criteria - -- [x] #1 All still-actionable CodeRabbit comments in the newest PR #49 round are fixed or explicitly identified stale with evidence. -- [x] #2 Regression coverage is added or updated for behavior touched in this round. -- [x] #3 Relevant verification passes before commit and push. - - -## Implementation Notes - - -Fetched the newest unresolved CodeRabbit threads for PR #49 after commit `942c1649`; only one unresolved actionable thread remained, on prerelease checksum output using repo-relative paths instead of asset basenames. - -Added regression coverage in `src/prerelease-workflow.test.ts` and `src/release-workflow.test.ts` asserting checksum generation truncates to asset basenames and no longer writes the raw `sha256sum "${files[@]}" > release/SHA256SUMS.txt` form. - -Updated both `.github/workflows/prerelease.yml` and `.github/workflows/release.yml` checksum generation steps to iterate over the `files` array and write `SHA256 basename` lines into `release/SHA256SUMS.txt`. - - -## Final Summary - - -Resolved the latest CodeRabbit round for PR #49 by fixing checksum generation to emit basename-oriented `SHA256SUMS.txt` entries in both prerelease and release workflows, with matching regression coverage. Verification: `bun test src/prerelease-workflow.test.ts src/release-workflow.test.ts`; `bun run typecheck`. - diff --git a/backlog/tasks/task-287 - Restore-Lua-parser-compatibility-for-mpv-plugin-modules.md b/backlog/tasks/task-287 - Restore-Lua-parser-compatibility-for-mpv-plugin-modules.md deleted file mode 100644 index e2458c5b..00000000 --- a/backlog/tasks/task-287 - Restore-Lua-parser-compatibility-for-mpv-plugin-modules.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-287 -title: Restore Lua parser compatibility for mpv plugin modules -status: Done -assignee: [] -created_date: '2026-04-11 21:25' -updated_date: '2026-04-11 21:29' -labels: - - bug - - mpv-plugin - - lua -dependencies: [] ---- - -## Description - - -Users with Lua runtimes that do not accept the current `goto continue` pattern in the mpv plugin should be able to load the plugin without syntax errors. Remove the parser-incompatible control-flow usage from the affected plugin modules without changing plugin behavior. - - -## Acceptance Criteria - -- [x] #1 The mpv plugin source no longer relies on parser-incompatible `goto continue` labels in the affected Lua modules. -- [x] #2 Automated coverage fails on the old parser-incompatible source and passes once the compatibility fix is in place. -- [x] #3 Existing plugin start/gate verification still passes after the compatibility fix. - - -## Implementation Notes - - -Reused existing local cleanups in `plugin/subminer/hover.lua` and `plugin/subminer/environment.lua` to remove `goto continue` / `::continue::` control flow without behavior changes. - -Added `scripts/test-plugin-lua-compat.lua` and wired it into `test:plugin:src`; the regression checks reject the legacy pattern structurally and verify parse success with `luajit` when available. - -Verification run on 2026-04-11: `lua scripts/test-plugin-lua-compat.lua` ✅, `bun run test:plugin:src` ✅, `bun run changelog:lint` ✅, `bun run typecheck` ✅, `bun run test:env` ✅, `bun run build` ✅, `bun run test:smoke:dist` ✅. - -`bun run test:fast` remains red for unrelated existing immersion-tracker assertions in `src/core/services/immersion-tracker/__tests__/query-split-modules.test.ts` and `src/core/services/immersion-tracker/__tests__/query.test.ts` (`tsMs`/`lastWatchedMs` observed as `-2147483648`). - - -## Final Summary - - -Removed parser-incompatible `goto continue` usage from the affected mpv Lua plugin modules, added a dedicated Lua compatibility regression script to the plugin test lane, and added a changelog fragment for the user-visible fix. Requested plugin verification is green; unrelated existing `test:fast` immersion-tracker failures remain outside this task. - diff --git a/backlog/tasks/task-288 - Stabilize-immersion-tracker-CI-timestamp-handling-under-libsql-Bun.md b/backlog/tasks/task-288 - Stabilize-immersion-tracker-CI-timestamp-handling-under-libsql-Bun.md deleted file mode 100644 index a689b3a1..00000000 --- a/backlog/tasks/task-288 - Stabilize-immersion-tracker-CI-timestamp-handling-under-libsql-Bun.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -id: TASK-288 -title: Stabilize immersion-tracker CI timestamp handling under libsql/Bun -status: Done -assignee: [] -created_date: '2026-04-11 21:34' -updated_date: '2026-04-11 21:43' -labels: - - bug - - ci - - immersion-tracker -dependencies: [] ---- - -## Description - - -`bun run test:fast` is currently failing because large millisecond timestamps are not handled safely through the libsql/Bun path. Fix timestamp parsing/storage so lifetime/library and session-event queries return correct wall-clock values in CI and runtime. - - -## Acceptance Criteria - -- [x] #1 Large wall-clock timestamps round-trip correctly through immersion-tracker lifetime/library queries under the repo's Bun/libsql runtime. -- [x] #2 Session-event timestamps round-trip correctly for real wall-clock values used by runtime event inserts. -- [x] #3 Targeted immersion-tracker regression coverage passes, and the previously failing `test:fast` lane no longer fails on these timestamp assertions. - - -## Implementation Notes - - -Root cause split in two places: Bun/libsql corrupts large millisecond timestamp strings when coerced through `Number(...)`, and `imm_session_events.ts_ms` being `INTEGER` let runtime event inserts/readbacks return `-2147483648` on CI/runtime. - -Fix shipped by parsing timestamp strings without the broken `Number(largeString)` path, migrating `imm_session_events.ts_ms` to `TEXT`, ordering/retention queries via `CAST(ts_ms AS REAL)`, and avoiding `Number(currentMs)` when reusing already-normalized timestamp strings. - -Added regression coverage for both real runtime event inserts and schema migration/repair of previously truncated session-event rows. - - -## Final Summary - - -Fixed immersion-tracker timestamp handling under Bun/libsql so large wall-clock millisecond values survive runtime writes, query reads, and schema migration. `bun run test:fast`, `bun run typecheck`, `bun run test:env`, `bun run build`, `bun run test:smoke:dist`, and `bun run changelog:lint` all pass after the patch. - diff --git a/backlog/tasks/task-289 - Finish-current-windows-qol-rebase.md b/backlog/tasks/task-289 - Finish-current-windows-qol-rebase.md deleted file mode 100644 index a7bafec3..00000000 --- a/backlog/tasks/task-289 - Finish-current-windows-qol-rebase.md +++ /dev/null @@ -1,33 +0,0 @@ ---- -id: TASK-289 -title: Finish current windows-qol rebase -status: Done -assignee: [] -created_date: '2026-04-11 22:07' -updated_date: '2026-04-11 22:08' -labels: - - maintenance - - rebase -dependencies: [] -references: - - /home/sudacode/projects/japanese/SubMiner -priority: medium ---- - -## Description - - -Resolve the in-progress rebase on `windows-qol` and ensure the branch lands cleanly. - - -## Acceptance Criteria - -- [x] #1 Interactive rebase completes without conflicts. -- [x] #2 Working tree is clean after the rebase finishes. - - -## Final Summary - - -Completed the interactive rebase on `windows-qol` and resolved the transient editor-blocked `git rebase --continue` step. Branch now rebased cleanly onto `49e46e6b`. - diff --git a/backlog/tasks/task-290 - Cut-stable-release-v0.12.0-on-main.md b/backlog/tasks/task-290 - Cut-stable-release-v0.12.0-on-main.md deleted file mode 100644 index 0d418857..00000000 --- a/backlog/tasks/task-290 - Cut-stable-release-v0.12.0-on-main.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-290 -title: Cut stable release v0.12.0 on main -status: Done -assignee: - - codex -created_date: '2026-04-12 04:47' -updated_date: '2026-04-12 04:51' -labels: [] -dependencies: [] -documentation: - - docs/RELEASING.md -priority: high ---- - -## Description - - -Prepare the main branch for the stable SubMiner v0.12.0 release by applying the release-version updates, formatting changes required by the branch state, and rerunning the full release verification gate. - - -## Acceptance Criteria - -- [x] #1 Main branch version and stable release metadata are updated for v0.12.0. -- [x] #2 Required formatting changes for the release candidate tree are applied and verified. -- [x] #3 The documented release verification gate passes locally and any remaining push or tag prerequisites are documented. - - -## Implementation Plan - - -1. Audit main-branch release state: package version, release artifacts, current CI status, and current formatting debt. -2. Apply required formatting fixes to the files reported by `bun run format:check:src` and verify the formatting lane passes. -3. Update the package version to 0.12.0 and generate stable release metadata (`CHANGELOG.md`, `release/release-notes.md`, `docs-site/changelog.md`) using the documented release workflow. -4. Run the full local release gate on main (`changelog:lint`, `changelog:check --version 0.12.0`, `verify:config-example`, `typecheck`, `test:fast`, `test:env`, `build`, `docs:test`, `docs:build`, plus dist smoke) and document any remaining tag/push prerequisites. - - -## Implementation Notes - - -Applied Prettier to all 39 files reported by `bun run format:check:src` on main and verified the formatting lane now passes. - -Reapplied the stable changelog build entrypoint fix on main: added `writeStableReleaseArtifacts`, covered it with a focused regression test, and updated `package.json` so `changelog:build` forwards `--version` and `--date` through a single `build-release` command. - -Verified the formatted mainline release tree with `bun run changelog:lint`, `bun run changelog:check --version 0.12.0`, `bun run verify:config-example`, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, `bun run docs:test`, `bun run docs:build`, and `bun run test:smoke:dist`; all passed. - -Remote main CI also completed successfully for `Windows update (#49)` after the local release-prep pass. Remaining operational steps are commit/tag/push only. - - -## Final Summary - - -Prepared `main` for the stable `v0.12.0` cut. Formatted the previously failing source files so `bun run format:check:src` is now clean, bumped `package.json` from `0.12.0-beta.3` to `0.12.0`, and generated the stable release artifacts with the explicit local cut date `2026-04-11`, which consumed the pending changelog fragments into `CHANGELOG.md`, `docs-site/changelog.md`, and `release/release-notes.md`. - -Also reintroduced the release-script fix on main: the old `changelog:build` package script still used `build && docs`, which can drop `--version/--date` on the first step. Added a focused regression test in `scripts/build-changelog.test.ts`, implemented `writeStableReleaseArtifacts` in `scripts/build-changelog.ts`, and switched `package.json` to `build-release` so release flags propagate correctly. Verification on the final tree passed for formatting, changelog lint/check, config example verification, typecheck, fast tests, env tests, build, docs tests/build, dist smoke, and remote main CI. The branch is release-ready pending commit, tag, and push. - diff --git a/backlog/tasks/task-291 - Add-manual-AniList-selection-for-character-dictionary-resolution.md b/backlog/tasks/task-291 - Add-manual-AniList-selection-for-character-dictionary-resolution.md deleted file mode 100644 index 582bcf69..00000000 --- a/backlog/tasks/task-291 - Add-manual-AniList-selection-for-character-dictionary-resolution.md +++ /dev/null @@ -1,43 +0,0 @@ ---- -id: TASK-291 -title: Add manual AniList selection for character dictionary resolution -status: Done -assignee: - - '@codex' -created_date: '2026-04-25 21:29' -updated_date: '2026-04-25 22:51' -labels: - - dictionary - - anilist - - cli - - ui -dependencies: [] -priority: high ---- - -## Description - - -Add CLI and in-app UI support for correcting character dictionary anime resolution when guessit or AniList search picks the wrong series. Manual selections must apply to the whole detected series, persist across episodes, and replace stale incorrect entries in the auto-sync merged character dictionary state. Do not add tray UI. Known regression case: `Re - ZERO, Starting Life in Another World (2016) - S01E01 - - The End of the Beginning and the Beginning of the End [v2 Bluray-1080p Proper][10bit][x265][FLAC 2.0][EN+JA]-SCY.mkv` previously resolved to `10607 - Rerere no Tensai Bakabon`; it should be correctable to the chosen Re:ZERO AniList media and then reused for later files in that series. - - -## Acceptance Criteria - -- [x] #1 CLI can show AniList candidate matches for the current/target media and set a manual character-dictionary AniList override. -- [x] #2 In-app UI can show the current character-dictionary match, candidate matches, and apply an override without adding tray controls. -- [x] #3 Persisted overrides are keyed at series scope so all later episodes in the same series reuse the selected AniList media. -- [x] #4 Applying an override clears stale guess state, replaces the old incorrect active media entry in auto-sync state, rebuilds/imports the merged character dictionary, and refreshes subtitle dictionary usage. -- [x] #5 Regression tests cover the Re:ZERO filename, override reuse, stale active-media replacement, CLI handling, and IPC/UI contract behavior. -- [x] #6 Docs are updated for manual character dictionary anime selection. - - -## Implementation Plan - - -1. Add a focused override/resolution layer for character dictionary media selection: derive a stable series key from filename/guessit data, persist manual AniList media overrides under user data, and expose AniList candidate search helpers. -2. Update character dictionary snapshot resolution to check manual overrides before guessit-derived AniList search, and update auto-sync so applying an override removes stale incorrect media IDs and rebuilds/imports the merged dictionary. -3. Extend CLI with commands to list candidates and set an override for current or target media. -4. Extend existing in-app settings UI via IPC/preload contracts: show current match/candidates and let user apply an override. No tray controls. -5. Use TDD: add failing regressions first for Re:ZERO parsing/override behavior, auto-sync replacement, CLI handling, IPC contract, and UI state; then implement. -6. Update docs-site/manual docs for manual character dictionary anime selection, launcher usage, and the default `Ctrl+Alt+A` modal shortcut, then run focused tests and broader gates as time permits. - diff --git a/backlog/tasks/task-292 - Restore-Linux-multi-subtitle-copy-digit-capture.md b/backlog/tasks/task-292 - Restore-Linux-multi-subtitle-copy-digit-capture.md deleted file mode 100644 index 5ef5b4cc..00000000 --- a/backlog/tasks/task-292 - Restore-Linux-multi-subtitle-copy-digit-capture.md +++ /dev/null @@ -1,52 +0,0 @@ ---- -id: TASK-292 -title: Restore Linux multi-subtitle copy digit capture -status: Done -assignee: - - '@codex' -created_date: '2026-04-25 21:31' -updated_date: '2026-04-25 21:36' -labels: - - bug - - linux - - shortcuts - - clipboard -dependencies: [] -priority: high ---- - -## Description - - -On Linux, the copy-subtitle-multiple shortcut opens the numeric prompt but the follow-up digit is not captured, so the flow times out. User confirmed `wl-copy` itself is installed and working, so investigate the shortcut/digit capture path and restore multi-line subtitle copy without regressing existing session action behavior. - - -## Acceptance Criteria - -- [x] #1 Linux copy-subtitle-multiple shortcut accepts a follow-up digit and copies that number of recent subtitle lines instead of timing out. -- [x] #2 The fix avoids depending on Linux Electron global shortcut digit registration for the follow-up numeric selection when a renderer-visible session can handle it. -- [x] #3 Regression tests cover the Linux multi-copy shortcut/digit flow and existing non-Linux/global shortcut behavior remains intact. - - -## Implementation Plan - - -1. Add failing regression coverage for Linux copy-subtitle-multiple local shortcut fallback starting renderer/session numeric selection instead of main-process digit globalShortcut capture. -2. Patch the overlay shortcut fallback/runtime path so Linux visible-overlay multi-copy and mine-sentence-multiple can dispatch session-action numeric selection when renderer handling is available, while preserving main-process numeric sessions for CLI/non-renderer paths. -3. Run targeted tests for shortcut fallback, overlay runtime, and renderer keyboard numeric selection; then run typecheck or a wider focused gate if needed. -4. Update task acceptance criteria/final notes after verification. - - -## Implementation Notes - - -Implemented the approved path by keeping multi-step numeric overlay shortcuts out of the main-process local fallback. The visible overlay now receives the original keydown and uses the existing renderer/session-action numeric selection flow for follow-up digits, avoiding Linux Electron globalShortcut digit capture for multi-copy and mine-sentence-multiple. Verification: targeted shortcut/renderer tests and changelog lint pass. `bun run typecheck` is currently blocked by unrelated existing errors in CLI/AniList dictionary-candidate work and `src/main/dependencies.ts` manual-selection API shape. - - -## Final Summary - - -Restored Linux multi-line subtitle copy by preventing main-process overlay shortcut fallback from consuming multi-step numeric shortcuts (`copySubtitleMultiple` and `mineSentenceMultiple`). Those shortcuts now fall through to the visible overlay renderer, where the existing session binding flow prompts for a digit and dispatches the counted session action locally instead of relying on Electron globalShortcut digit registration. Added regression coverage for the fallback behavior and renderer follow-up digit dispatch, plus a changelog fragment. - -Verification: `bun test src/core/services/overlay-shortcut-handler.test.ts src/renderer/handlers/keyboard.test.ts`; `bun run changelog:lint`. Full `bun run typecheck` was attempted but is blocked by unrelated current worktree errors in CLI/AniList dictionary-candidate tests/types and `src/main/dependencies.ts`. - diff --git a/backlog/tasks/task-293 - Fix-interjection-tokens-receiving-subtitle-annotations.md b/backlog/tasks/task-293 - Fix-interjection-tokens-receiving-subtitle-annotations.md deleted file mode 100644 index 874b37df..00000000 --- a/backlog/tasks/task-293 - Fix-interjection-tokens-receiving-subtitle-annotations.md +++ /dev/null @@ -1,25 +0,0 @@ ---- -id: TASK-293 -title: Fix interjection tokens receiving subtitle annotations -status: In Progress -assignee: [] -created_date: '2026-04-25 22:50' -labels: - - tokenizer - - bug -dependencies: [] -priority: medium ---- - -## Description - - -Standalone interjections such as あ should remain hoverable dictionary tokens but must not receive N+1, frequency, JLPT, or known-word subtitle annotation metadata. - - -## Acceptance Criteria - -- [ ] #1 A MeCab 感動詞 token like あ is excluded by the shared subtitle annotation gate. -- [ ] #2 annotateTokens strips N+1/frequency/JLPT/known metadata from the interjection while preserving token lookup fields. -- [ ] #3 Focused tokenizer regression passes. - diff --git a/backlog/tasks/task-294 - Fix-annotated-subtitle-tokens-to-honor-subtitleStyle.md b/backlog/tasks/task-294 - Fix-annotated-subtitle-tokens-to-honor-subtitleStyle.md deleted file mode 100644 index c07f6a85..00000000 --- a/backlog/tasks/task-294 - Fix-annotated-subtitle-tokens-to-honor-subtitleStyle.md +++ /dev/null @@ -1,32 +0,0 @@ ---- -id: TASK-294 -title: Fix annotated subtitle tokens to honor subtitleStyle -status: Done -assignee: [] -created_date: '2026-04-25 23:04' -updated_date: '2026-04-25 23:07' -labels: - - subtitles - - renderer -dependencies: [] -priority: medium ---- - -## Description - - -Annotated token spans should inherit the configured subtitleStyle typography and only use annotation metadata to change token color. - - -## Acceptance Criteria - -- [x] #1 Tokenized/annotated subtitles preserve configured base subtitle typography such as font family, size, weight, line height, letter spacing, text rendering, and text shadow. -- [x] #2 Known/N+1/JLPT/frequency/name-match annotations affect token color only, plus existing token metadata/hover affordances. -- [x] #3 A renderer regression test covers annotated token rendering with custom subtitleStyle. - - -## Final Summary - - -Updated renderer subtitle annotation CSS so known/N+1/name/JLPT/frequency classes no longer override typography with token-specific shadows, underlines, padding, or hover font-weight. Added regression coverage using the user's custom subtitleStyle shape to verify annotated token spans inherit base typography and annotation CSS changes token color only. Verified with `bun test src/renderer/subtitle-render.test.ts`, `bun run typecheck`, and `bun run test:fast`. - diff --git a/backlog/tasks/task-295 - Add-primary-subtitle-visibility-keybinding.md b/backlog/tasks/task-295 - Add-primary-subtitle-visibility-keybinding.md deleted file mode 100644 index 844b22d2..00000000 --- a/backlog/tasks/task-295 - Add-primary-subtitle-visibility-keybinding.md +++ /dev/null @@ -1,66 +0,0 @@ ---- -id: TASK-295 -title: Add primary subtitle visibility keybinding -status: Done -assignee: - - Codex -created_date: '2026-04-25 23:09' -updated_date: '2026-04-25 23:45' -labels: - - renderer - - keybindings - - subtitles -dependencies: [] -priority: medium ---- - -## Description - - -Add a `v` keybinding that overrides mpv's default `v` subtitle visibility toggle and instead toggles SubMiner's primary subtitle bar visibility on and off. Secondary subtitle hover behavior is out of scope. - - -## Acceptance Criteria - -- [x] #1 Pressing `v` toggles the primary subtitle bar from visible to hidden. -- [x] #2 Pressing `v` again restores the primary subtitle bar visibility. -- [x] #3 The keybinding does not add or change secondary subtitle hover behavior. -- [x] #4 Relevant automated coverage verifies the toggle behavior. -- [x] #5 Pressing `v` in the mpv/plugin keybinding path also toggles the primary subtitle bar visibility instead of mpv native subtitle visibility. - - -## Implementation Plan - - -1. Inspect existing renderer keybinding and subtitle bar visibility code, including current local edits in touched files. -2. Add a focused failing test for `v` toggling primary subtitle bar visibility without changing secondary hover behavior. -3. Implement the minimal renderer/keybinding change. -4. Run targeted tests and update acceptance criteria/final notes. - - -## Implementation Notes - - -Implemented renderer-local `KeyV` handling before session/mpv binding dispatch so mpv `sub-visibility` is not touched. Visibility state is stored in renderer state and applied via `primary-sub-hidden` class on the primary subtitle container. - -Scope updated after user clarified the toggle must work when focus is in mpv as well as in the overlay renderer. Added a forced mpv plugin binding for `v` that runs `--toggle-primary-subtitle-bar`, then broadcasts a renderer IPC toggle event and reuses the same primary subtitle bar toggle path. - - -## Final Summary - - -Summary: -- Added a renderer-local `v` key handler that toggles primary subtitle bar visibility by adding/removing `primary-sub-hidden` on the primary subtitle container. -- Added renderer state for the toggle so repeated presses restore the bar without issuing mpv `sub-visibility` commands. -- Added a forced mpv plugin `v` binding that invokes `--toggle-primary-subtitle-bar` and broadcasts the same renderer toggle event. -- Added CSS for the hidden primary subtitle bar state and regression coverage for both overlay and mpv/plugin entry points. - -Tests: -- `bun test src/renderer/handlers/keyboard.test.ts --test-name-pattern "primary subtitle visibility key"` -- `bun test src/cli/args.test.ts --test-name-pattern "session action"` -- `bun test src/core/services/cli-command.test.ts --test-name-pattern "visibility and utility"` -- `bun test src/cli/args.test.ts src/cli/help.test.ts src/core/services/cli-command.test.ts src/main/runtime/cli-command-context.test.ts src/main/runtime/cli-command-context-deps.test.ts src/main/runtime/cli-command-context-main-deps.test.ts src/main/runtime/cli-command-context-factory.test.ts src/main/runtime/composers/cli-startup-composer.test.ts src/main/runtime/first-run-setup-service.test.ts` -- `lua scripts/test-plugin-start-gate.lua && lua scripts/test-plugin-lua-compat.lua` -- `bun run typecheck` -- `bun run test:fast` - diff --git a/backlog/tasks/task-296 - Suppress-crash-notification-when-closing-launcher-managed-video.md b/backlog/tasks/task-296 - Suppress-crash-notification-when-closing-launcher-managed-video.md deleted file mode 100644 index b2a18f89..00000000 --- a/backlog/tasks/task-296 - Suppress-crash-notification-when-closing-launcher-managed-video.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -id: TASK-296 -title: Suppress crash notification when closing launcher-managed video -status: Done -assignee: [] -created_date: '2026-04-25 23:12' -updated_date: '2026-04-26 02:44' -labels: - - bug - - launcher - - mpv -dependencies: [] -priority: high ---- - -## Description - - -Investigate and fix regression where closing a running mpv video causes SubMiner/Electron service crash notification (`/SubMiner has encountered a fatal error and was closed.`). Not present on origin/main/v0.12.0 path. - - -## Acceptance Criteria - -- [x] #1 Closing a launcher-managed video stops the overlay/app without desktop crash notification. -- [x] #2 Regression test covers the shutdown path that caused the notification. -- [x] #3 Relevant launcher/app tests pass. - - -## Implementation Plan - - -1. Confirm notification source from local crash metadata and mpv/app logs. -2. Add regression coverage for mpv quit/shutdown lifecycle helper spawning. -3. Update mpv Lua lifecycle to avoid Electron helper subprocesses during quit/shutdown while preserving normal end-file hide behavior. -4. Run plugin tests and changelog lint. - - -## Implementation Notes - - -Crash records in ~/.cache/drkonqi show SIGBUS in Electron NetworkService utility process for SubMiner AppImage. mpv log shows shutdown starts two `/home/sudacode/.local/bin/SubMiner.AppImage --hide-visible-overlay` subprocesses and kills them during close. Root cause is mpv plugin spawning Electron control helpers during quit/shutdown. - -Follow-up after retest: installed plugin matched source patch and no close-time hide command was spawned. New mpv log shows the initial `/home/sudacode/.local/bin/SubMiner.AppImage --start ...` subprocess remains owned by mpv for the whole playback and is killed when mpv quits. New DrKonqi crash at 2026-04-25 16:44 again shows SIGBUS in Electron NetworkService from that AppImage mount. Need detach the long-lived plugin-launched `--start` app process from mpv. - -Second fix: plugin-launched `--start` now includes `--background`, using SubMiner's existing background relaunch path so mpv owns only a short-lived starter process rather than the long-running Electron app. Ran `make install-plugin` so ~/.config/mpv/scripts/subminer now contains both lifecycle and background-start fixes. Full `scripts/test-plugin-start-gate.lua` is currently blocked by an unrelated dirty-worktree primary subtitle bar binding test from TASK-297. - - -## Final Summary - - -Changed the mpv Lua lifecycle so `shutdown` no longer spawns a `--hide-visible-overlay` helper, and `end-file` skips that helper when mpv reports `reason = "quit"`. Also changed plugin-launched `--start` to include `--background`, so mpv owns only SubMiner's short background launcher process instead of the long-running Electron/AppImage process. This addresses both observed crash sources: close-time helper commands and mpv killing the main SubMiner child process at quit. Installed the updated plugin into `~/.config/mpv/scripts/subminer` with `make install-plugin`, and the user confirmed the latest close no longer produced the notification. - -Tests: `lua scripts/test-plugin-start-gate.lua` initially proved the shutdown regression failed before the lifecycle fix; full start-gate is currently affected by other dirty work in this file. Passing checks for this commit: `lua scripts/test-plugin-lua-compat.lua && lua scripts/test-plugin-binary-windows.lua`; `bun run changelog:lint`. - diff --git a/backlog/tasks/task-297 - Fix-subtitle-annotation-color-priority-after-typography-cleanup.md b/backlog/tasks/task-297 - Fix-subtitle-annotation-color-priority-after-typography-cleanup.md deleted file mode 100644 index 52e503bc..00000000 --- a/backlog/tasks/task-297 - Fix-subtitle-annotation-color-priority-after-typography-cleanup.md +++ /dev/null @@ -1,32 +0,0 @@ ---- -id: TASK-297 -title: Fix subtitle annotation color priority after typography cleanup -status: Done -assignee: [] -created_date: '2026-04-25 23:44' -updated_date: '2026-04-25 23:46' -labels: - - subtitles - - renderer -dependencies: [] -priority: high ---- - -## Description - - -Known-word and frequency subtitle token colors should keep their configured priority after annotation CSS stopped using JLPT underlines. - - -## Acceptance Criteria - -- [x] #1 Known-word token color takes priority over JLPT and frequency color classes. -- [x] #2 Frequency single-mode token color takes priority over JLPT color classes when frequency annotation is active. -- [x] #3 Regression coverage verifies CSS selectors do not allow JLPT color rules to override higher-priority annotation colors. - - -## Final Summary - - -Scoped JLPT token color selectors so they only apply when no higher-priority known-word, N+1, name-match, or frequency class is present. This keeps known words green and frequency single-mode tokens using the single frequency color instead of being visually overridden by JLPT colors. Added CSS regression assertions for this priority behavior. Verified with `bun test src/renderer/subtitle-render.test.ts`, `bun run typecheck`, and `bun run test:fast`. - diff --git a/backlog/tasks/task-298 - Exclude-kana-grammar-helper-merges-like-ことに-from-subtitle-annotations.md b/backlog/tasks/task-298 - Exclude-kana-grammar-helper-merges-like-ことに-from-subtitle-annotations.md deleted file mode 100644 index 329d063b..00000000 --- a/backlog/tasks/task-298 - Exclude-kana-grammar-helper-merges-like-ことに-from-subtitle-annotations.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -id: TASK-298 -title: Exclude kana grammar-helper merges like ことに from subtitle annotations -status: Done -assignee: - - codex -created_date: '2026-04-26 00:08' -updated_date: '2026-04-26 00:15' -labels: - - tokenizer - - annotations - - bug -dependencies: [] -priority: medium ---- - -## Description - - -Investigate and fix subtitle tokenizer annotation behavior where all-hiragana grammar-helper merged tokens such as `ことに` can be marked as N+1. Current likely path: Yomitan emits `ことに` with headword `こと`; MeCab enrichment supplies content-led POS (`名詞|助詞`, likely `非自立|格助詞`); shared subtitle annotation filter does not exclude this family unless it matches narrower rules such as `これで` or explanatory endings. - - -## Acceptance Criteria - -- [x] #1 `ことに`-style kana grammar-helper merges are not marked known, N+1, JLPT, or frequency-highlighted when their MeCab metadata indicates a non-independent noun plus helper particle. -- [x] #2 Regression coverage demonstrates the reported subtitle phrase does not mark `ことに` as N+1 while preserving annotation for real lexical content tokens. -- [x] #3 Existing tokenizer annotation tests pass. - - -## Implementation Plan - - -Approved approach (user: "let's do it"): -1. Add a regression test for the reported `ことに` case using Yomitan token `ことに` -> headword `こと` and MeCab metadata `名詞|助詞` / `非自立|格助詞`; assert all annotation fields are stripped while nearby lexical content can still be N+1. -2. Verify the new test fails before production changes. -3. Update the shared subtitle annotation filter to exclude conservative kana-only grammar-helper merges: merged surface differs from headword, surface is kana-only, first POS component is `名詞`, first POS2 component is `非自立`, and remaining POS components are grammar helpers (`助詞`/`助動詞`). -4. Run targeted tokenizer/annotation tests and update the task acceptance criteria/final notes. - - -## Implementation Notes - - -Red test initially passed with headword `こと` because `こと` is already in `JLPT_EXCLUDED_TERMS` and the shared subtitle annotation filter checks that set. Updated regression to the live-risk shape `surface=ことに`, `headword=事`, with MeCab POS `名詞|助詞` / `非自立|格助詞`; this failed before the filter change and passed after. - - -## Final Summary - - -Implemented a conservative shared subtitle annotation filter for kana-only non-independent noun helper merges. Tokens such as `ことに` with a kanji dictionary headword like `事` are now stripped of known-word, N+1, JLPT, and frequency metadata when MeCab shows the first component as `名詞/非自立` and trailing components as grammar helpers. - -Added unit coverage in `src/core/services/tokenizer/annotation-stage.test.ts` and an integration-style tokenizer regression for the reported phrase shape in `src/core/services/tokenizer.test.ts`, verifying `ことに` stays plain while a real lexical token can still become the N+1 target. - -Validation: `bun test src/core/services/tokenizer/annotation-stage.test.ts`; `bun test src/core/services/tokenizer.test.ts`; `bun run test:fast`; `bun run changelog:lint`. - diff --git a/backlog/tasks/task-299 - Force-audio-replacement-during-manual-subtitle-mining.md b/backlog/tasks/task-299 - Force-audio-replacement-during-manual-subtitle-mining.md deleted file mode 100644 index b610bd54..00000000 --- a/backlog/tasks/task-299 - Force-audio-replacement-during-manual-subtitle-mining.md +++ /dev/null @@ -1,66 +0,0 @@ ---- -id: TASK-299 -title: Force audio replacement during manual subtitle mining -status: Done -assignee: - - Codex -created_date: '2026-04-26 00:10' -updated_date: '2026-04-26 02:42' -labels: - - anki - - mining -dependencies: [] -priority: medium ---- - -## Description - - -Manual subtitle mining via the Ctrl+C/Ctrl+V flow should replace expression and sentence audio fields even when the user has configured media overwrite fields to false. These fields can already contain proxy-inserted SubMiner audio on a new card, and manual update intent is to replace that generated content. - - -## Acceptance Criteria - -- [x] #1 Manual subtitle mining replaces existing expression audio content regardless of configured audio overwrite settings. -- [x] #2 Manual subtitle mining replaces existing sentence audio content regardless of configured audio overwrite settings. -- [x] #3 Non-manual mining/update flows continue to respect configured audio overwrite settings. -- [x] #4 A regression test covers manual audio replacement when overwrite settings are disabled. - - -## Implementation Plan - - -1. Locate the manual subtitle mining Ctrl+C/Ctrl+V flow and the Anki media field overwrite gate. -2. Add a failing regression test showing manual mining overwrites expression and sentence audio when configured audio overwrite is disabled. -3. Implement the smallest path-specific override so only manual subtitle mining forces audio replacement. -4. Run the focused mining test and update task acceptance criteria/final notes. - - -## Implementation Notes - - -Implemented focused manual clipboard update behavior in CardCreationService.updateLastAddedFromClipboard: generated manual audio is written to both resolved sentence audio and expression audio fields with forced overwrite. Other update flows still use existing overwrite config paths. - -Verification: focused Anki tests passed; typecheck passed; changelog lint and diff check passed. Full bun run test:fast was attempted but is blocked by unrelated existing tokenizer annotation-stage failures tied to dirty task 298 worktree changes. - - -## Final Summary - - -Summary: -- Manual clipboard subtitle updates now resolve both sentence audio and expression audio fields and replace both with the newly generated audio regardless of ankiConnect.behavior.overwriteAudio. -- Added a regression test for the Ctrl+C/Ctrl+V manual update path with existing proxy-inserted audio and overwriteAudio disabled. -- Registered the regression test in test:fast, documented the overwrite exception in user docs, and added a changelog fragment. - -Verification: -- bun test src/anki-integration/card-creation-manual-update.test.ts src/anki-integration/card-creation.test.ts -- bun run tsc --noEmit -- bun test src/main-entry-runtime.test.ts src/anki-integration.test.ts src/anki-integration/card-creation-manual-update.test.ts src/anki-integration/anki-connect-proxy.test.ts src/anki-integration/field-grouping-workflow.test.ts src/anki-integration/field-grouping.test.ts src/anki-integration/field-grouping-merge.test.ts src/release-workflow.test.ts src/prerelease-workflow.test.ts src/ci-workflow.test.ts scripts/build-changelog.test.ts scripts/electron-builder-after-pack.test.ts scripts/mkv-to-readme-video.test.ts scripts/run-coverage-lane.test.ts scripts/update-aur-package.test.ts -- bun run changelog:lint -- bun run docs:test -- bun run docs:build -- git diff --check - -Blocked gate: -- bun run test:fast currently fails in unrelated src/core/services/tokenizer/annotation-stage.test.ts tests for kana-only non-independent noun helper merges; those files have pre-existing dirty changes outside this task. - diff --git a/backlog/tasks/task-300 - Fix-transparent-subtitle-hover-background-config.md b/backlog/tasks/task-300 - Fix-transparent-subtitle-hover-background-config.md deleted file mode 100644 index 53cdc834..00000000 --- a/backlog/tasks/task-300 - Fix-transparent-subtitle-hover-background-config.md +++ /dev/null @@ -1,51 +0,0 @@ ---- -id: TASK-300 -title: Fix transparent subtitle hover background config -status: Done -assignee: [] -created_date: '2026-04-26 03:23' -updated_date: '2026-04-26 03:26' -labels: - - bug - - overlay - - config -dependencies: [] -priority: medium ---- - -## Description - - -User reports setting subtitleStyle.hoverTokenBackgroundColor to transparent still renders default hover background in overlay subtitles. - - -## Acceptance Criteria - -- [x] #1 Transparent hoverTokenBackgroundColor is accepted by config resolution. -- [x] #2 Renderer applies transparent hover token background instead of falling back to default. - - -## Implementation Plan - - -1. Reproduce config alias behavior with a failing config test. -2. Map subtitleStyle.hoverBackground to hoverTokenBackgroundColor in config resolution while keeping canonical key precedence. -3. Add renderer regression for transparent hover token background CSS variable. -4. Update docs and changelog fragment; run focused verification. - - -## Implementation Notes - - -Local user config used subtitleStyle.hoverBackground, which was ignored because only subtitleStyle.hoverTokenBackgroundColor was recognized. Canonical key still takes precedence when both are present. - -Verification passed: bun run test:config:src; bun test src/renderer/subtitle-render.test.ts; bun run changelog:lint; bun run docs:test; bun run docs:build. - - -## Final Summary - - -Implemented config compatibility for transparent hover token backgrounds. `subtitleStyle.hoverBackground` now maps to the canonical `subtitleStyle.hoverTokenBackgroundColor` during resolution, preserving canonical key precedence. Added regression coverage for the alias and renderer handling of `transparent`, documented the alias, and added a changelog fragment. - -Verification: `bun run test:config:src`; `bun test src/renderer/subtitle-render.test.ts`; `bun run changelog:lint`; `bun run docs:test`; `bun run docs:build`. - diff --git a/backlog/tasks/task-301 - Fix-launcher-managed-video-close-leaving-background-app-alive.md b/backlog/tasks/task-301 - Fix-launcher-managed-video-close-leaving-background-app-alive.md deleted file mode 100644 index 8127275b..00000000 --- a/backlog/tasks/task-301 - Fix-launcher-managed-video-close-leaving-background-app-alive.md +++ /dev/null @@ -1,55 +0,0 @@ ---- -id: TASK-301 -title: Fix launcher-managed video close leaving background app alive -status: Done -assignee: - - Codex -created_date: '2026-04-26 03:29' -updated_date: '2026-04-26 03:44' -labels: - - bug - - launcher - - mpv -dependencies: [] -priority: high ---- - -## Description - - -Launcher/plugin-managed video playback should not leave the SubMiner background app or tray icon running after the video closes unless the user explicitly launched SubMiner in background mode via --background or by starting with no app arguments. This is a regression after crash-avoidance work that added background startup for launcher-managed playback. - - -## Acceptance Criteria - -- [x] #1 Closing a launcher-managed video exits the launcher-started SubMiner app/tray instead of leaving it alive. -- [x] #2 Explicit background launches still keep SubMiner alive after windows close. -- [x] #3 No-argument app startup behavior remains unchanged. -- [x] #4 Regression coverage exercises the launcher-managed playback shutdown lifecycle. - - -## Implementation Plan - - -1. Add regression coverage first: plugin auto-start should tag launcher-managed playback, and app mpv shutdown handling should quit only when started in that managed playback mode. -2. Add a narrow CLI flag/state field for launcher-managed playback, separate from explicit persistent background mode. -3. Have plugin pass the new flag with its background start command. -4. On mpv shutdown/disconnect, request app quit only when managed playback mode is active; preserve explicit --background and no-arg startup persistence. -5. Run focused plugin/app tests, then relevant launcher/core gates if feasible. - - -## Implementation Notes - - -Implemented managed playback shutdown by adding a `--managed-playback` app flag that the mpv plugin passes only for launcher-managed starts. The main mpv shutdown path now quits the app when initial args indicate managed playback, while explicit background/no-arg startup remains persistent. Added plugin start-gate and mpv protocol regression coverage. - -Implemented managed playback lifecycle: mpv plugin auto-start passes --background --managed-playback; app quits on mpv shutdown only when initial args include managedPlayback. Explicit --background and no-arg startup remain persistent. Installed updated mpv plugin to ~/.config/mpv/scripts/subminer via make install-plugin. - -Retest showed tray still remained. Root cause: relying on mpv's JSON IPC shutdown event was insufficient; the app may only see the socket close. Added managed-playback quit on MpvIpcClient onClose before reconnect scheduling, with regression coverage. - - -## Final Summary - - -Launcher-managed playback now starts SubMiner with an internal --managed-playback marker alongside --background. The app requests quit either when mpv sends shutdown or when the mpv IPC socket closes, but only for managed playback mode; explicit background/no-arg startup remains persistent. Added CLI, mpv protocol, mpv socket-close, and plugin regression coverage plus a launcher changelog fragment. Rebuilt the app/launcher and confirmed focused checks, typecheck, build, plugin tests, dist smoke, and formatting. - diff --git a/backlog/tasks/task-302 - Add-visible-hover-affordance-for-annotated-subtitle-tokens.md b/backlog/tasks/task-302 - Add-visible-hover-affordance-for-annotated-subtitle-tokens.md deleted file mode 100644 index 41fe8e9a..00000000 --- a/backlog/tasks/task-302 - Add-visible-hover-affordance-for-annotated-subtitle-tokens.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-302 -title: Add visible hover affordance for annotated subtitle tokens -status: Done -assignee: [] -created_date: '2026-04-26 03:39' -updated_date: '2026-04-26 03:40' -labels: - - overlay - - subtitle - - ux -dependencies: [] -priority: medium ---- - -## Description - - -Annotated subtitle tokens keep annotation colors on hover, but with transparent hover backgrounds there is no visible hover indication. Add a subtle affordance that preserves annotation color semantics. - - -## Acceptance Criteria - -- [x] #1 Annotated token hover keeps annotation color instead of switching to hover text color. -- [x] #2 Annotated token hover has a visible indication when hover background is transparent. -- [x] #3 Regression tests cover the hover CSS contract. - - -## Implementation Plan - - -1. Add failing CSS contract test for annotated token hover affordance. -2. Add brightness/saturation filter to annotated token hover CSS without changing annotation color. -3. Add changelog fragment and run focused verification. - - -## Implementation Notes - - -Implemented option 1 from approved design: annotated subtitle word hover keeps annotation color and adds `filter: brightness(1.18) saturate(1.08)` for visible affordance when the hover background is transparent. - -Verification passed: `bun test src/renderer/subtitle-render.test.ts`; `bun run changelog:lint`. - - -## Final Summary - - -Added a visible hover affordance for annotated subtitle tokens without changing annotation color semantics. Annotated word hover now applies a small brightness/saturation lift while retaining the existing background behavior, so transparent hover backgrounds still show feedback. - -Regression coverage updated in `src/renderer/subtitle-render.test.ts` to assert the hover filter is present and that hover color overrides are still absent for annotated tokens. Added changelog fragment `changes/302-annotated-hover-affordance.md`. - -Verification: `bun test src/renderer/subtitle-render.test.ts`; `bun run changelog:lint`. - diff --git a/backlog/tasks/task-303 - Update-tray-menu-help-action.md b/backlog/tasks/task-303 - Update-tray-menu-help-action.md deleted file mode 100644 index 6b8148a6..00000000 --- a/backlog/tasks/task-303 - Update-tray-menu-help-action.md +++ /dev/null @@ -1,57 +0,0 @@ ---- -id: TASK-303 -title: Update tray menu help action -status: Done -assignee: - - Codex -created_date: '2026-04-26 03:54' -updated_date: '2026-04-26 04:12' -labels: - - tray - - overlay -dependencies: [] -priority: medium ---- - -## Description - - -Replace the tray menu's direct visible-overlay open action with an action that opens the existing in-session help modal. The tray should no longer expose an "Open Overlay" menu item; users should be able to open help from the tray instead. - - -## Acceptance Criteria - -- [x] #1 Tray menu no longer includes an "Open Overlay" option. -- [x] #2 Tray menu includes an option to open the session help modal. -- [x] #3 Selecting the new tray help option initializes overlay runtime if needed and invokes the existing session help modal path. -- [x] #4 Focused regression tests cover the menu label and action wiring. - - -## Implementation Plan - - -1. Add focused regression coverage for tray menu template labels and main-process action wiring: assert Open Overlay is absent, Open Help is present, and clicking help initializes overlay runtime if needed before opening the existing session help modal path. -2. Update tray runtime action types/template to replace openOverlay with openSessionHelp. -3. Update tray main action builder dependencies to call the existing openSessionHelpModal function after overlay runtime initialization. -4. Run targeted tray tests, then broader relevant fast tests if needed. -5. Check acceptance criteria and finalize backlog notes. - - -## Implementation Notes - - -Implemented tray menu replacement via existing session help overlay path. Verification passed: targeted tray tests (`bun test src/main/runtime/tray-runtime.test.ts src/main/runtime/tray-main-actions.test.ts src/main/runtime/tray-main-deps.test.ts src/main/runtime/tray-runtime-handlers.test.ts`), SubMiner verifier lanes `runtime-compat` and `docs`, and `bun run changelog:lint`. - - -## Final Summary - - -Replaced the tray menu's `Open Overlay` item with `Open Help`, wired it to initialize overlay runtime when needed, and then open the existing session help modal path. Updated tray runtime/main-deps/action tests to assert the old label is absent, the new label is present, and the new action calls the help modal. Added changelog fragment `changes/303-tray-help-menu.md`. - -Verification: -- `bun test src/main/runtime/tray-runtime.test.ts src/main/runtime/tray-main-actions.test.ts src/main/runtime/tray-main-deps.test.ts src/main/runtime/tray-runtime-handlers.test.ts` -- `bash plugins/subminer-workflow/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane runtime-compat --lane docs src/main/runtime/tray-runtime.ts src/main/runtime/tray-main-actions.ts src/main/runtime/tray-main-deps.ts src/main.ts changes/303-tray-help-menu.md` -- `bun run changelog:lint` - -Verifier artifacts: `.tmp/skill-verification/subminer-verify-20260425-211156-9fkdDf/`. - diff --git a/backlog/tasks/task-304 - Fix-N1-sentence-boundary-counting-across-Yomitan-punctuation-gaps.md b/backlog/tasks/task-304 - Fix-N1-sentence-boundary-counting-across-Yomitan-punctuation-gaps.md deleted file mode 100644 index 9e7e3803..00000000 --- a/backlog/tasks/task-304 - Fix-N1-sentence-boundary-counting-across-Yomitan-punctuation-gaps.md +++ /dev/null @@ -1,27 +0,0 @@ ---- -id: TASK-304 -title: Fix N+1 sentence boundary counting across Yomitan punctuation gaps -status: In Progress -assignee: [] -created_date: '2026-04-26 05:33' -labels: - - bug - - tokenizer - - annotations -dependencies: [] -priority: medium ---- - -## Description - - -N+1 target selection should respect sentence-ending punctuation from the original subtitle text even when Yomitan token output omits punctuation tokens. Current behavior can treat multiple subtitle sentences as one token span and incorrectly satisfy the minimum content-token threshold. - - -## Acceptance Criteria - -- [ ] #1 A subtitle like `てんめ！ふざけんなよ！` does not mark `ふざけん`/similar single-content-token second sentence as N+1 when the minimum sentence word count is 3. -- [ ] #2 N+1 sentence segmentation uses original subtitle text offsets or equivalent source-boundary data, not only punctuation tokens returned by Yomitan. -- [ ] #3 Existing annotation exclusion behavior for particles/grammar tokens remains unchanged. -- [ ] #4 Regression tests cover Yomitan-style token streams where punctuation is absent from the token list. - diff --git a/backlog/tasks/task-305 - Use-Yomitan-word-classes-for-subtitle-token-POS-filtering.md b/backlog/tasks/task-305 - Use-Yomitan-word-classes-for-subtitle-token-POS-filtering.md deleted file mode 100644 index aa19d61f..00000000 --- a/backlog/tasks/task-305 - Use-Yomitan-word-classes-for-subtitle-token-POS-filtering.md +++ /dev/null @@ -1,64 +0,0 @@ ---- -id: TASK-305 -title: Use Yomitan word classes for subtitle token POS filtering -status: Done -assignee: - - Codex -created_date: '2026-04-26 05:56' -updated_date: '2026-05-02 22:47' -labels: - - tokenizer - - yomitan -dependencies: [] -priority: medium ---- - -## Description - - -Subtitle annotation filtering currently uses Yomitan token spans, then enriches those spans by running MeCab over the full normalized subtitle line. Add support for carrying Yomitan headword wordClasses from termsFind into SubMiner tokens so dictionary-backed tokens can provide coarse POS/tag metadata without vendored Yomitan changes. MeCab whole-line enrichment should remain a fallback/source of detailed POS data when Yomitan classes are absent. - - -## Acceptance Criteria - -- [x] #1 Yomitan scanner tokens preserve matched headword wordClasses when termsFind returns them. -- [x] #2 Subtitle tokenization maps recognized Yomitan wordClasses to coarse PartOfSpeech/POS metadata before annotation filtering. -- [x] #3 Whole-line MeCab enrichment remains available for missing or more detailed POS metadata and does not break existing subtitle annotation behavior. -- [x] #4 Focused tokenizer tests cover wordClasses extraction and POS mapping. - - -## Implementation Plan - - -1. Add focused regression coverage for Yomitan scanner wordClasses payload and subtitle POS mapping. -2. Extend the app-owned Yomitan scanner payload to carry matched headword wordClasses when present. -3. Map recognized Yomitan wordClasses to SubMiner coarse PartOfSpeech/POS metadata before annotation filtering. -4. Keep MeCab whole-line enrichment as fallback/detail-fill for missing POS fields. -5. Run focused tokenizer tests and typecheck. - -2026-05-02 review follow-up: inspect latest CodeRabbit review on PR #57, classify each finding as actionable/not actionable, patch scoped issues, run focused verification, then update final notes. User request to address/assess the review is the approval for this follow-up. - - -## Implementation Notes - - -Implemented app-only wordClasses extraction from termsFind results; no vendored Yomitan changes required. Recognized classes currently map prt, aux, v*, adj-i/adj-ix, adj-na, and noun-like classes to SubMiner POS metadata. MeCab enrichment now skips only tokens with complete pos1/pos2/pos3 and otherwise fills missing fields while preserving existing coarse pos1. Verification: bun test src/core/services/tokenizer/yomitan-parser-runtime.test.ts src/core/services/tokenizer.test.ts; bun run typecheck. - -2026-05-02 CodeRabbit latest review assessment: only current actionable finding was in src/core/services/tokenizer/annotation-stage.test.ts, where a kana-only regression fixture used mixed-script/punctuation surface text. Earlier CodeRabbit findings in this PR were already marked addressed by prior commits. Patched the fixture to use pure-kana surface/headword and renamed the test to match the exercised behavior. Verification: bun test src/core/services/tokenizer/annotation-stage.test.ts; bun run typecheck. - - -## Final Summary - - -Implemented app-only Yomitan wordClasses support for subtitle token annotation filtering. The scanner carries matched headword wordClasses from termsFind results, tokenizer maps recognized classes into SubMiner coarse POS metadata before annotation, and MeCab whole-line enrichment continues to fill missing detailed POS fields without requiring vendored Yomitan changes. - -2026-05-02 CodeRabbit follow-up: -- Assessed the latest CodeRabbit review on PR #57. Only one new actionable finding remained: the kana-only N+1 regression test used a mixed/punctuated surface. -- Updated the fixture in src/core/services/tokenizer/annotation-stage.test.ts to use a pure-kana unknown target and renamed the test accordingly. - -Tests run: -- bun test src/core/services/tokenizer/annotation-stage.test.ts -- bun run typecheck - -Note: earlier CodeRabbit findings on this PR were already marked addressed in prior commits; no further latest-review issues were left unresolved in this pass. - diff --git a/backlog/tasks/task-306 - Fix-Hyprland-fullscreen-overlay-geometry-and-hover-pause.md b/backlog/tasks/task-306 - Fix-Hyprland-fullscreen-overlay-geometry-and-hover-pause.md deleted file mode 100644 index f2e6a76e..00000000 --- a/backlog/tasks/task-306 - Fix-Hyprland-fullscreen-overlay-geometry-and-hover-pause.md +++ /dev/null @@ -1,33 +0,0 @@ ---- -id: TASK-306 -title: Fix Hyprland fullscreen overlay geometry and hover pause -status: Done -assignee: [] -created_date: '2026-04-27 01:44' -labels: - - linux - - hyprland - - overlay - - bug -dependencies: [] -priority: high ---- - -## Description - - - -Overlay should track mpv geometry through Hyprland fullscreen transitions, stay above fullscreen video, and keep primary subtitle hover pause working after fullscreen/toggle cycles. - -Implemented by observing mpv fullscreen property changes in addition to Hyprland geometry events, then refreshing visible overlay bounds/layering on Linux. - - - -## Acceptance Criteria - - - -- [x] #1 Hyprland tracker reacts to fullscreen/window state changes with updated geometry. -- [x] #2 Visible overlay is re-layered above mpv after Hyprland fullscreen geometry updates. -- [x] #3 Primary subtitle hover pause remains active after overlay geometry changes or visible overlay toggle cycles. - diff --git a/backlog/tasks/task-306 - Separate-background-stats-daemon-from-regular-SubMiner-app.md b/backlog/tasks/task-306 - Separate-background-stats-daemon-from-regular-SubMiner-app.md deleted file mode 100644 index d1166d27..00000000 --- a/backlog/tasks/task-306 - Separate-background-stats-daemon-from-regular-SubMiner-app.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -id: TASK-306 -title: Separate background stats daemon from regular SubMiner app -status: Done -assignee: [] -created_date: '2026-04-27 00:56' -updated_date: '2026-04-27 01:00' -labels: - - stats - - runtime -dependencies: [] -priority: high ---- - -## Description - - -Background stats mode should run only the stats data/server pieces. It must not bring up tray UI or expose the regular mpv connection surface, and stopping should remain CLI-only. - - -## Acceptance Criteria - -- [x] #1 Launching stats background mode starts a separate stats daemon process rather than booting the regular SubMiner runtime. -- [x] #2 Background stats mode does not create or keep a tray icon. -- [x] #3 Background stats mode does not start mpv IPC/client surfaces that let mpv connect to the app. -- [x] #4 Background stats mode remains stoppable through the stats stop command line path. - - -## Implementation Plan - - -1. Add entry-runtime tests for public stats background/stop daemon detection. -2. Implement early public stats daemon command detection and route it before regular app boot. -3. Run targeted tests and update task status/criteria. - - -## Implementation Notes - - -Implemented early public stats daemon routing in main-entry runtime. Direct `--stats-background` and `--stats-stop` now resolve to daemon control before single-instance lock and before loading `main.js`, matching the existing internal launcher daemon flags. Installed missing Bun dependencies to run targeted tests. - - -## Final Summary - - -Summary: -- Added `resolveStatsDaemonCommandAction` and updated entry detection so public `--stats-background` / `--stats-stop` invocations route through the isolated stats daemon control path. -- Reused that action resolution in `stats-daemon-entry` so public stop commands map to stop instead of the default start path. -- Added regression coverage for public daemon detection/action resolution. - -Verification: -- `bun test src/main-entry-runtime.test.ts launcher/commands/command-modules.test.ts src/main/runtime/stats-cli-command.test.ts src/stats-daemon-control.test.ts` -- `bun run typecheck` - diff --git a/backlog/tasks/task-307 - Defer-in-app-stats-server-to-running-background-stats-daemon.md b/backlog/tasks/task-307 - Defer-in-app-stats-server-to-running-background-stats-daemon.md deleted file mode 100644 index d7479395..00000000 --- a/backlog/tasks/task-307 - Defer-in-app-stats-server-to-running-background-stats-daemon.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-307 -title: Defer in-app stats server to running background stats daemon -status: Done -assignee: [] -created_date: '2026-04-27 01:57' -updated_date: '2026-04-27 02:02' -labels: - - stats - - runtime -dependencies: [] -priority: high ---- - -## Description - - -When normal SubMiner app startup has stats auto-start enabled, it should detect an already-running background stats daemon and avoid starting a second in-app stats server. Stats overlay/dashboard URL resolution should point at the background daemon. - - -## Acceptance Criteria - -- [x] #1 If a live background stats daemon state exists for another process, in-app stats auto-start does not start a local stats server. -- [x] #2 Stats URL resolution returns the background daemon URL when the background daemon is live. -- [x] #3 Stale or dead background daemon state is cleared and normal in-app stats startup still works. -- [x] #4 Regression tests cover the deferral behavior. - - -## Implementation Plan - - -1. Add unit tests for stats server routing decisions around live/stale background daemon state. -2. Implement a small routing helper used by main stats startup. -3. Wire `ensureStatsServerStarted()` through the helper. -4. Run targeted tests/typecheck/changelog lint and finalize the task. - - -## Implementation Notes - - -Extracted stats server URL routing into `src/main/runtime/stats-server-routing.ts` and wired `main.ts` through it. The helper returns the background daemon URL without calling local server startup when a live external daemon exists; dead/self-owned stale state is removed before falling back to local startup. Added the new test to `test:core:src`. - - -## Final Summary - - -Summary: -- Added a pure stats server routing helper that chooses between a live background daemon and local in-app stats server startup. -- Updated main stats URL resolution to defer to another process's background daemon and only start the in-app server when no live daemon is available. -- Added regression tests for live daemon deferral, dead daemon cleanup, self-owned stale state cleanup, and local server reuse. -- Added the routing test to the core source test lane and added a changelog fragment. - -Verification: -- `bun test src/main/runtime/stats-server-routing.test.ts src/main-entry-runtime.test.ts src/main/runtime/stats-cli-command.test.ts src/stats-daemon-control.test.ts` -- `bun run test:core:src` -- `bun run typecheck` -- `bun run changelog:lint` - diff --git a/backlog/tasks/task-307 - Exclude-kana-only-words-from-N1-subtitle-targets.md b/backlog/tasks/task-307 - Exclude-kana-only-words-from-N1-subtitle-targets.md deleted file mode 100644 index 78e4de50..00000000 --- a/backlog/tasks/task-307 - Exclude-kana-only-words-from-N1-subtitle-targets.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-307 -title: Exclude kana-only words from N+1 subtitle targets -status: Done -assignee: - - codex -created_date: '2026-04-27 01:52' -updated_date: '2026-04-27 01:57' -labels: - - tokenizer - - annotations -dependencies: [] -priority: medium ---- - -## Description - - -Subtitle N+1 annotation is over-targeting kana-only or hiragana/katakana tokens that collapse to dictionary words. Adjust targeting so kana-only tokens are not selected as N+1 candidates, while preserving tokenization/hover behavior and other annotation metadata where existing filters allow it. - - -## Acceptance Criteria - -- [x] #1 Kana-only subtitle tokens are not marked as N+1 targets. -- [x] #2 Kanji or mixed lexical tokens can still be marked as N+1 targets when they are the single unknown candidate in a sentence. -- [x] #3 Regression coverage demonstrates the kana-only N+1 exclusion. - - -## Implementation Plan - - -1. Add a failing regression in `src/core/services/tokenizer.test.ts` showing a kana-only Yomitan token is not selected as the single N+1 target, while a mixed lexical token in the same style still can be targeted. -2. Implement the smallest filter in `src/token-merger.ts`: N+1 candidate selection rejects tokens whose surface is entirely kana; word-count behavior remains governed by existing annotation/POS filters. -3. Run the focused tokenizer tests, then update task acceptance criteria/final summary. - - -## Implementation Notes - - -Implemented a surface-level kana-only guard in N+1 candidate selection. Kept existing word-count/POS filtering behavior intact; updated tokenizer and annotation-stage expectations where old tests intentionally allowed kana-only N+1 targets. - - -## Final Summary - - -Summary: -- Added kana-only surface detection to `isNPlusOneCandidateToken` so hiragana/katakana-only subtitle tokens are not selected as N+1 targets. -- Added/updated tokenizer and annotation-stage regressions for kana-only targets while preserving non-kana N+1 behavior. -- Added changelog fragment `changes/307-kana-nplusone-targets.md`. - -Verification: -- `bun test src/core/services/tokenizer.test.ts --test-name-pattern "kana-only N\+1"` failed before the fix with `true !== false`. -- `bun test src/core/services/tokenizer/annotation-stage.test.ts src/core/services/tokenizer.test.ts` passed. -- `bun run typecheck` passed. -- `bun run test:fast` passed. -- `bun run changelog:lint` passed. -- `bunx prettier --check src/core/services/tokenizer.test.ts src/core/services/tokenizer/annotation-stage.test.ts src/token-merger.ts changes/307-kana-nplusone-targets.md` passed. - diff --git a/backlog/tasks/task-308 - Restore-persistent-JLPT-subtitle-underlines.md b/backlog/tasks/task-308 - Restore-persistent-JLPT-subtitle-underlines.md deleted file mode 100644 index 3ca96fd8..00000000 --- a/backlog/tasks/task-308 - Restore-persistent-JLPT-subtitle-underlines.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -id: TASK-308 -title: Restore persistent JLPT subtitle underlines -status: Done -assignee: - - Codex -created_date: '2026-04-27 02:03' -updated_date: '2026-04-27 02:07' -labels: - - overlay - - jlpt - - renderer -dependencies: [] -priority: medium ---- - -## Description - - -JLPT tagging currently exposes the JLPT level on hover, but the persistent subtitle underline is missing. When JLPT annotation is enabled and a rendered subtitle token has a JLPT level, users should see the configured JLPT color underline without needing to hover. - - -## Acceptance Criteria - -- [x] #1 JLPT-tagged subtitle tokens render a persistent underline for N1-N5 levels when JLPT tagging is enabled. -- [x] #2 Hover and keyboard-selected JLPT labels continue to appear for tagged tokens. -- [x] #3 Higher-priority annotation colors such as known words, N+1, names, and frequency styling are not overridden by JLPT text color. -- [x] #4 Regression coverage verifies the CSS contract for persistent JLPT underlines. - - -## Implementation Plan - - -1. Add a focused renderer CSS regression asserting each `word-jlpt-n*` class provides persistent underline decoration while preserving existing typography constraints. -2. Run the focused renderer test to confirm the regression fails before production changes. -3. Restore underline CSS for JLPT classes without broadening JLPT text-color precedence over known/N+1/name/frequency tokens. -4. Re-run the focused renderer test and update acceptance criteria/task notes. - - -## Implementation Notes - - -Verified red/green regression: tightened `src/renderer/subtitle-render.test.ts` first failed because base `word-jlpt-n*` selectors had no underline decoration, then passed after moving JLPT underline decoration to unconditional base selectors while leaving JLPT text color priority-scoped. - -Checks: `bun test src/renderer/subtitle-render.test.ts`; `bun run changelog:lint`; `bun run typecheck`. - - -## Final Summary - - -Restored persistent JLPT subtitle underlines by adding underline decoration to each base `word-jlpt-n*` renderer CSS class. JLPT text color remains in the existing priority-scoped selectors, so known/N+1/name/frequency coloring is not overridden while the underline still appears on any JLPT-tagged token. - -Updated renderer CSS regression coverage to assert underline decoration for N1-N5 and added a fixed changelog fragment. Verified with `bun test src/renderer/subtitle-render.test.ts`, `bun run changelog:lint`, and `bun run typecheck`. - diff --git a/backlog/tasks/task-309 - Accept-modified-follow-up-digits-for-multi-line-sentence-mining.md b/backlog/tasks/task-309 - Accept-modified-follow-up-digits-for-multi-line-sentence-mining.md deleted file mode 100644 index 078d151d..00000000 --- a/backlog/tasks/task-309 - Accept-modified-follow-up-digits-for-multi-line-sentence-mining.md +++ /dev/null @@ -1,57 +0,0 @@ ---- -id: TASK-309 -title: Accept modified follow-up digits for multi-line sentence mining -status: Done -assignee: - - '@codex' -created_date: '2026-04-27 20:06' -updated_date: '2026-04-27 20:15' -labels: - - bug - - linux - - shortcuts -dependencies: [] -priority: high ---- - -## Description - - - -On Linux, `Ctrl+Shift+S` starts multi-line sentence-card mining, but the follow-up digit is not accepted and the prompt times out. Restore reliable digit capture for the multi-mine flow, including the common case where the original shortcut modifiers are still held briefly while pressing the digit. - - - -## Acceptance Criteria - - - -- [x] #1 `Ctrl+Shift+S` followed by a number-row digit creates a counted `mineSentenceMultiple` request instead of timing out. -- [x] #2 Follow-up digit capture works when the user has not fully released `Ctrl`/`Shift` after the starter shortcut. -- [x] #3 Regression coverage includes renderer session bindings and mpv plugin numeric selection. - - -## Implementation Notes - - - -Backlog MCP unavailable in this session, so this task is tracked via repo-local backlog files. - -Implemented renderer digit extraction from `KeyboardEvent.code` for pending numeric selection, so shifted number-row events such as `Ctrl+Shift+Digit3` still dispatch count `3`. Updated the mpv plugin session-binding numeric selector to register bare digits plus the starter shortcut modifier combinations, so plugin-owned `Ctrl+Shift+S` can accept a follow-up digit before the modifiers are fully released. - -Verification: - -- `bun test src/renderer/handlers/keyboard.test.ts src/core/services/overlay-shortcut-handler.test.ts src/core/services/overlay-window.test.ts` -- `bun run test:plugin:src` -- `bun run changelog:lint` -- `bun x prettier --check src/renderer/handlers/keyboard.ts src/renderer/handlers/keyboard.test.ts package.json 'changes/309-multi-mine-modified-digits.md' 'backlog/tasks/task-309 - Accept-modified-follow-up-digits-for-multi-line-sentence-mining.md'` - - - -## Final Summary - - - -Restored multi-line sentence-card digit capture for the case where `Ctrl`/`Shift` are still held after `Ctrl+Shift+S`. The renderer now accepts digits by physical `Digit1`-`Digit9`/`Numpad1`-`Numpad9` code during pending numeric selection, and the mpv plugin registers the matching modified digit bindings for session-binding numeric prompts. - - diff --git a/backlog/tasks/task-310 - Suppress-N1-highlight-for-kana-only-candidate-sentences.md b/backlog/tasks/task-310 - Suppress-N1-highlight-for-kana-only-candidate-sentences.md deleted file mode 100644 index 46093703..00000000 --- a/backlog/tasks/task-310 - Suppress-N1-highlight-for-kana-only-candidate-sentences.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-310 -title: Suppress N+1 highlight for kana-only candidate sentences -status: Done -assignee: - - Codex -created_date: '2026-04-28 06:55' -updated_date: '2026-04-28 07:04' -labels: - - tokenizer - - n+1 -dependencies: [] -priority: medium ---- - -## Description - - -Reduce noisy N+1 subtitle annotations when the only unknown candidates in a sentence are kana-only hiragana or katakana words, such as mostly-kana subtitle lines where highlighting a particle/helper-like token is low value. - - -## Acceptance Criteria - -- [x] #1 N+1 annotation does not mark a kana-only unknown target when all N+1 candidates in the sentence are kana-only. -- [x] #2 N+1 annotation continues to mark kanji or mixed-script unknown targets in otherwise eligible sentences. -- [x] #3 A focused regression test covers the kana-only candidate case. -- [x] #4 N+1 minimum sentence word count excludes tokens stripped by the subtitle annotation filter, so filtered grammar/noise tokens cannot satisfy minSentenceWords. - - -## Implementation Plan - - -1. Keep the existing N+1 target eligibility guard: kana-only subtitle surfaces do not become N+1 targets. -2. Add a focused regression in src/core/services/tokenizer/annotation-stage.test.ts proving annotation-filtered tokens do not count toward ankiConnect.nPlusOne.minSentenceWords. -3. Verify the new regression fails before code changes. -4. Patch src/token-merger.ts so the N+1 minimum sentence word count uses the same subtitle-annotation eligibility filter as annotation rendering, excluding filtered particles/auxiliaries/noise from the count. -5. Re-run focused tokenizer tests, then update TASK-310 acceptance criteria and final notes. - - -## Implementation Notes - - -Initial context: current token-merger has an existing surface-level kana-only guard in isNPlusOneCandidateToken, added in commit 9e4ad907. Need decide whether to broaden behavior to lookup/headword forms or verify current behavior only. - -Implemented by treating kana-only N+1 candidates as kana-only even when their token surface includes surrounding subtitle punctuation such as ellipsis or dashes. Focused regression was red before the token-merger change: スイッチ… was marked true, then passed after the guard update. test:env initially hit an unrelated immersion-tracker active_days timing/order failure and Bun follow-on loader error; the failing test passed in isolation and the full test:env rerun passed. - -Reopened for follow-up scope: minSentenceWords must count annotation-eligible tokens only, not tokens stripped from annotation metadata. - -Implemented follow-up minSentenceWords behavior: unknown tokens filtered from N+1 targeting no longer contribute to sentence length; known eligible tokens and true N+1 candidates still count. - - -## Final Summary - - -Changed N+1 sentence-length counting so minSentenceWords only counts known eligible words and actual N+1 target candidates. Unknown tokens filtered from N+1 targeting, including kana-only unknowns, no longer pad a sentence into eligibility. Existing annotation-filtered particles/auxiliaries remain excluded. Added regression coverage for the filtered unknown padding case while preserving kanji/mixed-script target behavior. - -Verification: new regression failed before implementation; `bun test src/core/services/tokenizer/annotation-stage.test.ts -t "N\\+1"` pass; full `bun test src/core/services/tokenizer/annotation-stage.test.ts` pass; `bun test src/core/services/tokenizer.test.ts -t "N\\+1"` pass; `bun run typecheck` pass. - diff --git a/backlog/tasks/task-311 - Suppress-auxiliary-inflection-fragments-from-subtitle-annotations.md b/backlog/tasks/task-311 - Suppress-auxiliary-inflection-fragments-from-subtitle-annotations.md deleted file mode 100644 index e34a8302..00000000 --- a/backlog/tasks/task-311 - Suppress-auxiliary-inflection-fragments-from-subtitle-annotations.md +++ /dev/null @@ -1,43 +0,0 @@ ---- -id: TASK-311 -title: Suppress auxiliary inflection fragments from subtitle annotations -status: Done -assignee: [] -created_date: '2026-05-02 09:07' -updated_date: '2026-05-02 09:10' -labels: - - tokenizer - - annotations - - bug -dependencies: [] -priority: medium ---- - -## Description - - -Suppress standalone Japanese auxiliary/inflection subtitle fragments such as `れる` and `れた` from frequency/JLPT/N+1/known annotation styling while keeping lexical verbs such as `くれ` / `くれる` annotatable. Tokens must remain hoverable; only annotation metadata should be stripped. - - -## Acceptance Criteria - -- [x] #1 `れる` and `れた`-style standalone helper fragments render as plain hoverable subtitle tokens. -- [x] #2 Lexical verbs like `くれ` / `くれる` remain eligible for annotation. -- [x] #3 Regression tests cover unit filter behavior and tokenizer integration. - - -## Implementation Notes - - -Implemented with TDD. Added failing coverage first for standalone `れる`/`れた` auxiliary fragments and a lexical `くれ`/`くれる` guard. Updated the shared subtitle annotation filter to strip annotation metadata for kana-only auxiliary inflection fragments identified by MeCab POS (`助動詞` only, or `動詞/接尾` with optional trailing `助動詞`) while preserving lexical `くれ` as `くれる` when tagged `動詞/自立`. Added tokenizer integration coverage for `れた` and neighboring lexical N+1 behavior. - - -## Final Summary - - -Suppressed annotation metadata for standalone auxiliary inflection fragments such as `れる` and `れた` in subtitle tokens, leaving them hoverable but plain. Preserved lexical `くれ` -> `くれる` verb metadata when MeCab tags it as `動詞/自立`. - -Added unit and tokenizer regression coverage, plus a release fragment in `changes/311-auxiliary-inflection-annotation-filter.md`. - -Validation: targeted annotation/tokenizer tests passed; `bun run typecheck` passed; `bun run changelog:lint` passed. `bun run test:fast` was attempted twice and failed in unrelated `src/core/services/subsync.test.ts` cross-file state (`window.electronAPI` undefined), while `bun test src/core/services/subsync.test.ts` passes by itself. - diff --git a/backlog/tasks/task-312 - Suppress-ja-nai-explanatory-ending-subtitle-annotations.md b/backlog/tasks/task-312 - Suppress-ja-nai-explanatory-ending-subtitle-annotations.md deleted file mode 100644 index 987a822d..00000000 --- a/backlog/tasks/task-312 - Suppress-ja-nai-explanatory-ending-subtitle-annotations.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -id: TASK-312 -title: Suppress ja-nai explanatory ending subtitle annotations -status: Done -assignee: [] -created_date: '2026-05-02 09:55' -updated_date: '2026-05-02 10:03' -labels: - - tokenizer - - annotations - - bug -dependencies: [] -priority: medium ---- - -## Description - - -Suppress subtitle annotation styling for grammar-only explanatory endings like `じゃない` and `じゃないですか` while preserving nearby lexical content annotations. - - -## Acceptance Criteria - -- [x] #1 `じゃない` and `じゃないですか`-style endings render as plain hoverable subtitle tokens. -- [x] #2 The reported phrase `みたいなのあるじゃないですか` does not annotate `じゃない`/`じゃないですか` as lexical/frequency content. -- [x] #3 Regression tests cover unit filter behavior and tokenizer integration without suppressing lexical content tokens. -- [x] #4 Standalone polite copula endings such as `です` / `ですよ` render as plain hoverable subtitle tokens even if POS metadata is missing or too lexical. - - -## Implementation Notes - - -Added failing coverage first for `じゃない` / `じゃないですか` and `ですよ` leaking annotation metadata when POS metadata is missing or too lexical. Implemented term-family exclusions in the shared subtitle annotation filter for the `じゃない` explanatory family and polite copula suffix endings (`ですか`, `ですね`, `ですよ`, `ですな`). Kept bare `です` term-only behavior unchanged to preserve existing no-POS frequency tests; POS-tagged `です` is already stripped by the grammar POS exclusion path. - - -## Final Summary - - -Suppressed subtitle annotation metadata for grammar-only endings like `じゃないですか` and `ですよ`, while preserving nearby lexical content annotations. Added unit and tokenizer regression coverage for the reported `みたいなのあるじゃないですか` and `感じですよ` shapes, plus changelog fragment `changes/312-grammar-ending-annotation-filter.md`. - -Validation: `bun test src/core/services/tokenizer/annotation-stage.test.ts`; `bun test src/core/services/tokenizer.test.ts`; `bun run typecheck`; `bun run changelog:lint`; `git diff --check`. - diff --git a/backlog/tasks/task-313 - Fix-mpv-buffering-reload-overlay-lifecycle.md b/backlog/tasks/task-313 - Fix-mpv-buffering-reload-overlay-lifecycle.md deleted file mode 100644 index 696922a8..00000000 --- a/backlog/tasks/task-313 - Fix-mpv-buffering-reload-overlay-lifecycle.md +++ /dev/null @@ -1,28 +0,0 @@ ---- -id: TASK-313 -title: Fix mpv buffering reload overlay lifecycle -status: To Do -assignee: [] -created_date: '2026-05-02 22:12' -labels: - - bug - - mpv - - overlay -dependencies: [] -priority: high ---- - -## Description - - -macOS local playback can emit an mpv reload/end-file/file-loaded sequence during buffering. SubMiner should treat same-media reload churn as a continuation, not a fresh playback session, so the visible overlay remains available and startup-only tokenization/AniSkip work is not repeated unnecessarily. - - -## Acceptance Criteria - -- [ ] #1 Same-media mpv reload buffering does not hide the visible overlay. -- [ ] #2 Same-media mpv reload buffering does not re-arm the pause-until-ready startup gate or wait for a second tokenization-ready signal. -- [ ] #3 Same-media mpv reload buffering does not repeat AniSkip lookup work for the already-loaded media. -- [ ] #4 Normal new-file playback still clears per-media state, applies managed subtitle defaults, auto-starts/updates the overlay, and runs needed startup checks. -- [ ] #5 Regression coverage exercises the buffering reload/end-file/file-loaded sequence in the mpv plugin lifecycle. - diff --git a/backlog/tasks/task-315 - Suppress-annotations-for-standalone-じゃない-and-です-ending-tokens.md b/backlog/tasks/task-315 - Suppress-annotations-for-standalone-じゃない-and-です-ending-tokens.md deleted file mode 100644 index ed32daef..00000000 --- a/backlog/tasks/task-315 - Suppress-annotations-for-standalone-じゃない-and-です-ending-tokens.md +++ /dev/null @@ -1,67 +0,0 @@ ---- -id: TASK-315 -title: Suppress annotations for standalone じゃない and です ending tokens -status: Done -assignee: - - codex -created_date: '2026-05-03 00:02' -updated_date: '2026-05-03 06:05' -labels: - - bug - - tokenizer -dependencies: [] -priority: medium ---- - -## Description - - -Standalone `じゃない` grammar ending tokens should not display or persist subtitle annotations even if a dictionary assigns a rank or JLPT/known match. User observed `じゃない` still being marked frequent in overlay after tokenization produced it as a dictionary word. - - -## Acceptance Criteria - -- [x] #1 `じゃない` and `です` ending tokens have known-word, N+1, frequency, and JLPT annotation metadata cleared in subtitle annotation output. -- [x] #2 Common polite/question variants such as `じゃないですか` and `ですよ` remain excluded when tokenized as a single ending token. -- [x] #3 Regression coverage proves same-line Yomitan segments split content from trailing grammar endings so the content word can be annotated without coloring the ending. -- [x] #4 Auxiliary-only helper spans such as `てく` + `れた` in `ベアトリスがいてくれたから` have known-word, N+1, frequency, and JLPT annotation metadata cleared. -- [x] #5 Hard-coded grammar-ending phrase permutations are replaced by shared pattern matching, with parser selection and subtitle annotation filtering using the same grammar-ending classifier. - - -## Implementation Plan - - -1. Add a focused regression for `ベアトリスがいてくれたから` where Yomitan tokens include auxiliary-only `てく` and `れた` with pre-ranked/known/JLPT metadata candidates. -2. Run the targeted test to verify the regression fails before production changes. -3. Patch the shared subtitle annotation filter so kana-only auxiliary helper spans made only of grammar POS components are excluded while preserving lexical content tokens. -4. Re-run targeted tokenizer/annotation tests, then run SubMiner change verification classifier/verifier for the touched files. -5. Update TASK-315 acceptance criteria, notes, and final summary with commands and outcomes. - -Replace explicit standalone grammar-ending permutations with a compact shared matcher used by parser selection and annotation filtering. - -Add regression tests first for non-enumerated polite copula / ja-nai variants so the matcher behavior is proven, then refactor implementation and verify targeted lanes. - - -## Implementation Notes - - -Implemented as one focused tokenizer fix. Parser selection now splits dictionary-backed same-line grammar ending segments (`です`, `じゃない*`) from preceding content so annotation styling can apply only to the content token. Shared subtitle annotation filtering now treats bare `です` like the existing `ですか/ですよ/...` copula endings. - -2026-05-03: Reopened for approved add-on covering auxiliary-only `てく` + `れた` helper highlighting report. - -2026-05-03: Added regression coverage for `ベアトリスがいてくれたから` where Yomitan emits `てく` + `れた` and MeCab enrichment tags `てく` as `助詞|動詞` / `接続助詞|非自立`. The regression initially failed because `てく` kept `isKnown: true` and `jlptLevel: N4`. Added a shared-filter helper for kana-only particle+non-independent-verb helper spans, preserving lexical `自立` verbs. Verification: `bun test src/core/services/tokenizer/annotation-stage.test.ts`, `bun test src/core/services/tokenizer.test.ts`, `bun test src/core/services/tokenizer/parser-selection-stage.test.ts`, `bun x prettier --check ...`, and `bun run typecheck` passed. SubMiner verifier core lane passed typecheck but `bun run test:fast` failed on unrelated existing cross-suite issues: `window.electronAPI` undefined in `src/renderer/handlers/keyboard.ts` during `src/core/services/subsync.test.ts`, followed by Bun `node:test` nested-test cascade. - -2026-05-03: Reopened for follow-up requested by user: remove hard-coded standalone grammar-ending permutation list and lean on pattern/POS filtering where possible. - -2026-05-03: Added shared `grammar-ending.ts` matcher for polite copula, negative copula, and explanatory endings. Parser selection now uses the standalone-ending matcher instead of `STANDALONE_GRAMMAR_ENDINGS`. Shared subtitle filter now uses the same grammar classifier instead of generated phrase sets. Removed stale duplicate subtitle-exclusion helpers from `annotation-stage.ts`; annotation-stage continues to delegate subtitle exclusion to the shared filter. Verification passed: targeted tokenizer/parser/annotation tests, Prettier check, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, and `bun run test:smoke:dist`. `bun run changelog:lint` remains blocked by pre-existing malformed fragment `changes/319-interjection-annotation-filter.md`. - - -## Final Summary - - -Replaced grammar-ending phrase permutations with shared pattern matching. `parser-selection-stage.ts` now splits standalone grammar endings through `grammar-ending.ts` instead of `STANDALONE_GRAMMAR_ENDINGS`; `subtitle-annotation-filter.ts` uses the same classifier for polite copula, negative copula, and explanatory endings instead of generated exact phrase sets. - -Kept exclusion ownership cleaner: subtitle annotation exclusion remains in the shared filter, while `annotation-stage.ts` no longer carries stale duplicate subtitle-exclusion constants/helpers. Added regressions for pattern coverage including `ではないですか` splitting and no-POS grammar-ending annotation clearing. - -Verification passed: targeted tokenizer/parser/annotation tests, Prettier check, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, and `bun run test:smoke:dist`. `bun run changelog:lint` is blocked by pre-existing malformed `changes/319-interjection-annotation-filter.md`; new fragment `changes/321-grammar-ending-pattern-filter.md` uses the current metadata format. - diff --git a/backlog/tasks/task-316 - Fix-macOS-launcher-playback-exit-with-background-stats-daemon.md b/backlog/tasks/task-316 - Fix-macOS-launcher-playback-exit-with-background-stats-daemon.md deleted file mode 100644 index 48139e41..00000000 --- a/backlog/tasks/task-316 - Fix-macOS-launcher-playback-exit-with-background-stats-daemon.md +++ /dev/null @@ -1,68 +0,0 @@ ---- -id: TASK-316 -title: Fix macOS launcher playback exit with background stats daemon -status: Done -assignee: - - '@Codex' -created_date: '2026-05-03 00:32' -updated_date: '2026-05-03 00:36' -labels: - - bug - - macos - - mpv - - stats - - runtime -dependencies: [] -priority: high ---- - -## Description - - -Launching a video on macOS when SubMiner is not already running should not leave the regular SubMiner app/tray alive after mpv closes. A separately running background stats daemon must remain non-blocking and must not be used as a foreground app dependency during playback startup/shutdown. - - -## Acceptance Criteria - -- [x] #1 Closing a launcher/plugin-managed mpv session exits the launcher-started regular SubMiner app/tray after mpv closes. -- [x] #2 Explicit background/no-argument app launches still remain alive as before. -- [x] #3 A live background stats daemon is ignored by normal in-app stats server routing during regular app startup/playback, so the regular app never depends on or connects to that background daemon. -- [x] #4 Regression coverage demonstrates the managed playback shutdown and stats-daemon isolation behavior. - - -## Implementation Plan - - -1. Add failing regressions first: stats routing should ignore a live foreign background daemon for normal app URL/server startup, and managed playback disconnect should request app quit directly without reconnecting or depending on overlay/youtube disconnect guards. -2. Implement the narrow runtime changes in `src/main/runtime/stats-server-routing.ts` and, if needed, mpv disconnect plumbing in `src/core/services/mpv.ts` / event deps. -3. Preserve explicit persistent background/no-arg behavior by keeping `--managed-playback` as the only playback-exit marker. -4. Run focused tests (`stats-server-routing`, mpv client/protocol/event tests), then typecheck if focused checks pass. -5. Update changelog and task acceptance/final notes. - - -## Implementation Notes - - -Implemented regular app stats routing isolation from live background daemon state and explicit managed-playback quit-on-disconnect wiring in main mpv event deps. Existing `MpvIpcClient` socket-close managed playback quit path remains covered. - -`bun run test:fast` was attempted after focused verification. It failed in the broad `test:core:src` lane with Bun/node:test nested-test runner errors across many unrelated files and one transient subsync renderer API failure; rerunning the concrete subsync failure alone passed. Focused runtime tests, typecheck, and changelog lint remain green. - - -## Final Summary - - -Summary: -- Regular app stats server routing no longer returns or depends on a live background daemon URL; it validates/cleans state, then uses the local app stats server path. -- Managed playback is now explicitly treated as a quit-on-disconnect launch mode in main mpv event deps, in addition to the existing mpv socket-close quit request. -- Added regressions for background daemon isolation and managed playback quit-on-disconnect classification. -- Added changelog fragment `changes/316-macos-playback-stats-daemon.md`. - -Verification: -- `bun test src/main/runtime/stats-server-routing.test.ts src/core/services/mpv.test.ts src/core/services/mpv-protocol.test.ts src/main/runtime/mpv-client-event-bindings.test.ts src/main/runtime/mpv-main-event-bindings.test.ts src/main/runtime/mpv-main-event-main-deps.test.ts` -- `bun run typecheck` -- `bun run changelog:lint` -- `bun test src/core/services/subsync.test.ts --test-name-pattern "deterministic _retimed"` - -Blocked broader gate: -- `bun run test:fast` failed in `test:core:src` with Bun/node:test nested-test runner errors across unrelated files; the concrete subsync failure from that run passed when isolated. - diff --git a/backlog/tasks/task-317 - Add-browser-open-affordance-for-texthooker.md b/backlog/tasks/task-317 - Add-browser-open-affordance-for-texthooker.md deleted file mode 100644 index 0d7c6c50..00000000 --- a/backlog/tasks/task-317 - Add-browser-open-affordance-for-texthooker.md +++ /dev/null @@ -1,35 +0,0 @@ ---- -id: TASK-317 -title: Add browser open affordance for texthooker -status: Done -assignee: [] -created_date: '2026-05-03 02:02' -updated_date: '2026-05-03 02:21' -labels: - - feature - - texthooker -dependencies: [] -priority: medium ---- - -## Description - - -Add a `-o` flag to the texthooker subcommand to open the texthooker page in the user's default browser, and add a tray app option that triggers the same behavior. Implement with tests and existing launcher/tray patterns. - - -## Acceptance Criteria - -- [x] #1 `texthooker -o` starts/targets the texthooker page and opens it in the default browser. -- [x] #2 Tray app exposes a menu option to open the texthooker page in the default browser. -- [x] #3 Existing texthooker behavior without `-o` remains unchanged. -- [x] #4 Relevant CLI/tray behavior covered by tests. - - -## Final Summary - - -Implemented `subminer texthooker -o` by parsing the launcher subcommand flag, forwarding `--open-browser` to the app texthooker command, and allowing that app arg to force browser opening even when `texthooker.openBrowser` is false. Added an `Open Texthooker` tray menu item wired through the same CLI command path. Updated docs-site usage/launcher/API docs and added a changelog fragment. Verification: targeted CLI/tray tests passed; `bun run typecheck` passed; `bun run docs:test` passed; `bun run changelog:lint` passed; `bun run test:env` passed; `bun run build` passed; `bun run test:smoke:dist` passed; `bun run docs:build` passed after installing docs-site deps. `bun run test:fast` is blocked by an existing broader-suite failure in `runSubsyncManual writes deterministic _retimed filename when replace is false` (`window.electronAPI` undefined), followed by Bun nested-test cascade errors. - -Follow-up fix: `subminer texthooker -o` now opens `http://127.0.0.1:5174` from the launcher after a successful texthooker app handoff, so it works even when the installed SubMiner app binary does not yet understand the app-side `--open-browser` flag. Reproduced the reported behavior; confirmed the texthooker server was running at `127.0.0.1:5174`; added a launcher regression asserting the browser URL is opened. Verification: `bun test launcher/mpv.test.ts launcher/config/cli-parser-builder.test.ts launcher/config/args-normalizer.test.ts src/core/services/cli-command.test.ts src/main/runtime/tray-runtime.test.ts src/main/runtime/tray-main-actions.test.ts` passed; `bun run typecheck` passed; `bun run build:launcher` passed. - diff --git a/backlog/tasks/task-318 - Keep-JLPT-underline-color-fixed-after-lookup-selection.md b/backlog/tasks/task-318 - Keep-JLPT-underline-color-fixed-after-lookup-selection.md deleted file mode 100644 index 15a8d5e3..00000000 --- a/backlog/tasks/task-318 - Keep-JLPT-underline-color-fixed-after-lookup-selection.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-318 -title: Keep JLPT underline color fixed after lookup selection -status: Done -assignee: - - '@Codex' -created_date: '2026-05-03 03:17' -updated_date: '2026-05-03 03:19' -labels: - - overlay - - jlpt - - renderer -dependencies: [] -priority: medium ---- - -## Description - - -Looking up a subtitle token can leave browser/Yomitan selection styling active. If that token has a JLPT class and another annotation class, the underline must remain the JLPT level color because underline color represents static JLPT classification, not the currently active annotation or lookup state. - - -## Acceptance Criteria - -- [x] #1 JLPT subtitle underlines retain their configured N1-N5 color after lookup/selection styling is applied. -- [x] #2 JLPT tokens that also have known, N+1, name, or frequency annotation classes keep their annotation text color behavior without changing the JLPT underline color. -- [x] #3 Renderer regression coverage verifies the CSS contract for the combined JLPT plus annotation case. - - -## Implementation Plan - - -1. Add a focused CSS regression in `src/renderer/subtitle-render.test.ts` for JLPT tokens combined with higher-priority annotation classes and lookup/selection styling. -2. Run the focused renderer test and confirm it fails because selection rules do not lock `text-decoration-color`. -3. Update `src/renderer/style.css` to explicitly preserve JLPT underline decoration color in lookup/selection state selectors without changing text color priority. -4. Re-run the focused renderer test, then run the smallest relevant verification gate. - - -## Implementation Notes - - -Verified TDD red/green for renderer CSS contract: `bun test src/renderer/subtitle-render.test.ts` first failed because `word-jlpt-n1::selection` lock was missing, then passed after adding explicit JLPT `text-decoration-color` selection rules. Also ran `bun run changelog:lint` and `bun run typecheck` successfully. - - -## Final Summary - - -Fixed JLPT subtitle underline color drift after dictionary lookup/selection by adding explicit `::selection` decoration-color locks for N1-N5 token classes in `src/renderer/style.css`. This preserves the JLPT underline as static classification while leaving known/N+1/name/frequency text color priority intact. - -Added renderer CSS regression coverage for the JLPT selection lock and a user-visible changelog fragment. - -Checks: `bun test src/renderer/subtitle-render.test.ts`; `bun run changelog:lint`; `bun run typecheck`. - diff --git a/backlog/tasks/task-319 - Suppress-annotations-for-expressive-interjection-subtitles.md b/backlog/tasks/task-319 - Suppress-annotations-for-expressive-interjection-subtitles.md deleted file mode 100644 index 420bf4d7..00000000 --- a/backlog/tasks/task-319 - Suppress-annotations-for-expressive-interjection-subtitles.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-319 -title: Suppress annotations for expressive interjection subtitles -status: Done -assignee: - - Codex -created_date: '2026-05-03 03:18' -updated_date: '2026-05-03 03:20' -labels: - - bug - - subtitle-annotations -dependencies: [] -references: - - src/core/services/tokenizer/subtitle-annotation-filter.ts - - src/core/services/tokenizer/annotation-stage.test.ts -priority: medium ---- - -## Description - - -Interjection-only subtitle tokens such as ハァ and はっ should remain hoverable as tokens but must not receive known, N+1, frequency, or JLPT annotation styling. Current behavior can still annotate these forms when dictionary/POS metadata does not trip the existing exclusion gate. - - -## Acceptance Criteria - -- [x] #1 Standalone ハァ/はっ-style interjection tokens have annotation metadata cleared even when dictionary metadata exists. -- [x] #2 Filtering remains scoped so content-bearing non-interjection tokens still receive annotations. -- [x] #3 Regression coverage exercises the reported subtitle pattern: ハァ… / （ガーフィール）はっ！ - - -## Implementation Plan - - -1. Add failing regression coverage around annotation filtering for the reported interjection forms, including katakana ハァ and small-tsu はっ with surrounding subtitle punctuation/name text. -2. Tighten the shared subtitle annotation exclusion gate so expressive kana interjections clear annotation metadata without relying only on MeCab pos1=感動詞. -3. Run the focused tokenizer/annotation tests, then update acceptance criteria and notes. - - -## Implementation Notes - - -Implemented via shared subtitle annotation exclusion term normalization: added はぁ so katakana ハァ normalizes into the existing term gate. Existing small-tsu kana SFX logic already covers はっ. Regression confirms both reported forms clear known/N+1/frequency/JLPT metadata while a normal noun keeps frequency annotation. - - -## Final Summary - - -Summary: -- Added a regression for the reported subtitle pattern ハァ… / （ガーフィール）はっ！, with annotation metadata present on both interjection tokens. -- Extended the shared subtitle annotation exclusion term set so ハァ normalizes to はぁ and is stripped of annotation styling. Existing はっ handling remains covered by small-tsu kana SFX filtering. -- Added a change fragment for the user-visible bug fix. - -Verification: -- bun test src/core/services/tokenizer/annotation-stage.test.ts -- bun test src/core/services/tokenizer/annotation-stage.test.ts src/core/services/tokenizer.test.ts src/renderer/subtitle-render.test.ts -- bun run typecheck - diff --git a/backlog/tasks/task-320 - Refresh-current-subtitle-known-word-highlight-after-successful-mining.md b/backlog/tasks/task-320 - Refresh-current-subtitle-known-word-highlight-after-successful-mining.md deleted file mode 100644 index be8f57e2..00000000 --- a/backlog/tasks/task-320 - Refresh-current-subtitle-known-word-highlight-after-successful-mining.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-320 -title: Refresh current subtitle known-word highlight after successful mining -status: Done -assignee: - - Codex -created_date: '2026-05-03 03:22' -updated_date: '2026-05-03 03:29' -labels: - - bug - - anki - - subtitle-annotations -dependencies: [] -priority: medium ---- - -## Description - - -After a sentence card is mined successfully, the mined word is added to the known-word cache and future subtitle appearances render as known. The currently displayed subtitle must also be refreshed immediately so the mined word turns known-color without waiting for a later cue. - - -## Acceptance Criteria - -- [x] #1 Successful sentence-card mining refreshes the current displayed subtitle so newly mined known words render immediately. -- [x] #2 Unsuccessful/no-op mining does not refresh the current subtitle. -- [x] #3 Regression coverage verifies the successful and unsuccessful mining paths. - - -## Implementation Plan - - -1. Add a regression test around AnkiIntegration known-word cache appends: when mined note info changes known words, a callback fires. -2. Make KnownWordCacheManager.appendFromNoteInfo report whether it changed the immediate known-word cache. -3. Add an AnkiIntegration known-word-cache-updated callback and invoke it after successful immediate append. -4. Wire main process callback to subtitleProcessingController.refreshCurrentSubtitle(appState.currentSubText), forcing active-line retokenization after popup/proxy or local mining updates the known-word cache. -5. Add a changelog fragment and run targeted tests plus typecheck. - - -## Implementation Notes - - -Implemented generic known-word-cache update notification instead of shortcut-only refresh. KnownWordCacheManager.appendFromNoteInfo now returns whether in-memory known words changed; AnkiIntegration notifies a callback after successful append. Main process wires that callback to subtitleProcessingController.refreshCurrentSubtitle(appState.currentSubText), forcing retokenization without using stale prefetch/cache data. Added regression coverage in anki-integration.test.ts. - - -## Final Summary - - -Summary: -- Added a known-word-cache update callback on AnkiIntegration and wired it in the main process to refresh the current subtitle after mined note info changes known words. -- Made KnownWordCacheManager.appendFromNoteInfo report whether it changed the known-word cache, so refresh only happens after an actual immediate known-word append. -- Added regression coverage proving mined note info updates known words and emits the update notification. - -Verification: -- bun test src/anki-integration.test.ts src/anki-integration/known-word-cache.test.ts src/main/runtime/anki-actions.test.ts src/main/runtime/anki-actions-main-deps.test.ts -- bun run typecheck -- bun run changelog:lint currently blocked by pre-existing invalid metadata in changes/319-interjection-annotation-filter.md. - diff --git a/backlog/tasks/task-321 - Preserve-word-audio-during-manual-clipboard-card-updates.md b/backlog/tasks/task-321 - Preserve-word-audio-during-manual-clipboard-card-updates.md deleted file mode 100644 index 431bbeb0..00000000 --- a/backlog/tasks/task-321 - Preserve-word-audio-during-manual-clipboard-card-updates.md +++ /dev/null @@ -1,63 +0,0 @@ ---- -id: TASK-321 -title: Preserve word audio during manual clipboard card updates -status: Done -assignee: - - '@Codex' -created_date: '2026-05-03 06:22' -updated_date: '2026-05-03 06:23' -labels: - - anki - - mining -dependencies: [] -priority: medium ---- - -## Description - - -Manual Ctrl+Shift+C/Ctrl+V card updates on already-mined cards should refresh the sentence content and generated sentence media without removing or replacing the existing word/expression audio. The word is unchanged in this flow, so the configured word audio field must be left untouched while sentence audio remains forced-overwrite behavior from TASK-299. - - -## Acceptance Criteria - -- [x] #1 Manual clipboard subtitle update replaces the resolved sentence audio field with newly generated sentence audio. -- [x] #2 Manual clipboard subtitle update does not include the configured word/expression audio field in Anki field updates. -- [x] #3 Animated image generation still uses the existing word audio duration for lead-in sync when configured. -- [x] #4 A regression test covers preserving word/expression audio during manual clipboard update. - - -## Implementation Plan - - -1. Update the focused manual clipboard card update regression so generated audio is written only to the resolved sentence audio field and the configured word/expression audio field is absent from updateNoteFields payloads. -2. Run the focused test and confirm it fails for the existing TASK-299 behavior. -3. Change CardCreationService.updateLastAddedFromClipboard to stop merging/updating expression audio while preserving forced overwrite for sentence audio. -4. Run the focused test; then run adjacent Anki card-creation tests if the focused gate passes. -5. Update task acceptance criteria/final notes with verification results. - - -## Implementation Notes - - -Implemented narrow manual clipboard update change in CardCreationService.updateLastAddedFromClipboard: generated audio now force-overwrites only the resolved sentence audio field and no longer writes the configured word/expression audio field. Animated AVIF lead-in still runs from the original note info before image generation, preserving existing word-audio sync behavior. - - -## Final Summary - - -Summary: -- Manual Ctrl+Shift+C/Ctrl+V card updates now leave the configured word/expression audio field untouched while force-replacing the resolved sentence audio field. -- Updated the regression test to assert the Anki update payload omits ExpressionAudio and only merges SentenceAudio with forced overwrite. -- Updated docs-site behavior notes and added a changelog fragment for the sentence-only manual audio replacement behavior. - -Verification: -- bun test src/anki-integration/card-creation-manual-update.test.ts src/anki-integration/card-creation.test.ts src/anki-integration/animated-image-sync.test.ts -- bun run typecheck -- bun run docs:test -- bun run docs:build -- git diff --check -- src/anki-integration/card-creation.ts src/anki-integration/card-creation-manual-update.test.ts docs-site/mining-workflow.md docs-site/anki-integration.md docs-site/configuration.md changes/322-preserve-word-audio-manual-update.md - -Blocked gate: -- bun run changelog:lint is blocked by pre-existing malformed changes/319-interjection-annotation-filter.md, which is outside this task's files. - diff --git a/backlog/tasks/task-322 - Fix-failing-CI-checks-on-PR-57.md b/backlog/tasks/task-322 - Fix-failing-CI-checks-on-PR-57.md deleted file mode 100644 index 6fd6ea1d..00000000 --- a/backlog/tasks/task-322 - Fix-failing-CI-checks-on-PR-57.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-322 -title: Fix failing CI checks on PR 57 -status: Done -assignee: - - codex -created_date: '2026-05-03 06:27' -updated_date: '2026-05-03 06:31' -labels: - - ci - - bug -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/57' -priority: high ---- - -## Description - - -Investigate and fix failing GitHub Actions checks on PR #57 (`tokenizer-updates`). Scope: use CI logs to identify root cause, apply focused local fix, and verify with relevant local checks. - - -## Acceptance Criteria - -- [x] #1 Failing GitHub Actions check root cause is identified from logs. -- [x] #2 A focused code/test/docs fix is applied locally. -- [x] #3 Relevant local verification passes or blocked reason is documented. -- [x] #4 PR checks are rechecked or next CI action is documented. -- [x] #5 Actionable CodeRabbit PR comments are inspected and addressed or documented as non-actionable. - - -## Implementation Plan - - -1. Fix CI changelog lint by adding a valid `type` frontmatter value to `changes/319-interjection-annotation-filter.md`. -2. Address unresolved CodeRabbit threads: - - `scripts/test-plugin-session-bindings.lua`: make `.tmp` creation portable across Unix/Windows shells. - - `src/core/services/tokenizer.ts`: pass `TokenizerAnnotationOptions` through `stripSubtitleAnnotationMetadata` paths so `sourceText` is honored. - - `src/main/runtime/mpv-main-event-main-deps.ts`: align overlay-runtime quit-on-disconnect predicate with `hasInitialPlaybackQuitOnDisconnectArg`. - - `src/renderer/handlers/mouse.test.ts`: make `elementFromPoint` stubs coordinate-sensitive. -3. Run focused checks: `bun run changelog:lint`, relevant tokenizer/main/mouse tests, and plugin Lua test path if available. -4. Recheck PR checks/comments after local verification. - - -## Implementation Notes - - -CI root cause: GitHub Actions `build-test-audit` failed during `bun run changelog:lint`; `changes/319-interjection-annotation-filter.md` must declare `type` as one of `added`, `changed`, `fixed`, `docs`, `internal`. Scope expanded by user to also address CodeRabbit comments on PR #57. - -Implemented CI changelog metadata fix and unresolved CodeRabbit feedback locally. Full verification run: `bun run changelog:lint`, focused tests, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, `bun run test:smoke:dist`, `bun run format:check:src`. Rechecked PR checks: remote `build-test-audit` still shows the old failing run until this branch is pushed; CodeRabbit remains pending remotely until review reruns. - - -## Final Summary - - -Fixed PR #57 CI failure by converting `changes/319-interjection-annotation-filter.md` to valid changelog fragment metadata. Addressed unresolved CodeRabbit feedback by making plugin test `.tmp` creation portable, threading tokenizer annotation options through metadata stripping, aligning quit-on-disconnect predicates for Jellyfin playback, and strengthening mouse hit-test assertions. Also formatted two existing PR files required by the source format gate. Verification passed locally: changelog lint, focused tests, typecheck, test:fast, test:env, build, smoke dist, and format check. Remote PR checks still show the previous failed `build-test-audit` run until these local changes are pushed. - diff --git a/backlog/tasks/task-323 - Fix-macOS-overlay-hiding-while-mpv-remains-active.md b/backlog/tasks/task-323 - Fix-macOS-overlay-hiding-while-mpv-remains-active.md deleted file mode 100644 index d2a480e6..00000000 --- a/backlog/tasks/task-323 - Fix-macOS-overlay-hiding-while-mpv-remains-active.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-323 -title: Fix macOS overlay hiding while mpv remains active -status: Done -assignee: - - '@codex' -created_date: '2026-05-03 07:41' -updated_date: '2026-05-03 07:48' -labels: - - bug - - macos - - overlay -dependencies: [] -references: - - src/core/services/overlay-visibility.ts - - src/window-trackers/macos-tracker.ts -priority: high ---- - -## Description - - -macOS visible overlay can hide/reload during normal playback even while mpv, or the overlay over mpv, remains the active viewing surface. The fix should preserve overlay visibility and subtitle continuity during transient macOS focus/tracker flaps, while still hiding the overlay when the tracked mpv window is genuinely unavailable or another app is brought forward. - - -## Acceptance Criteria - -- [x] #1 When the macOS tracker has recent valid mpv geometry, transient focus/helper misses do not hide the visible overlay or force a reload. -- [x] #2 The overlay still hides when the tracked mpv window is genuinely lost beyond the existing tracking grace behavior. -- [x] #3 A regression test covers the macOS active-playback case where mpv/overlay focus is preserved despite a transient non-tracking state. -- [x] #4 Relevant docs or task notes are updated if behavior or verification guidance changes. - - -## Implementation Plan - - -1. Add a failing regression in `src/core/services/overlay-visibility.test.ts`: on macOS, after the overlay is visible/tracked, a transient tracker state with `isTracking() === false` but non-null `getGeometry()` keeps the overlay visible, updates bounds, and does not call `hide()` or loading OSD. -2. Implement the minimal macOS preserve path in `src/core/services/overlay-visibility.ts`, mirroring the existing Windows transient non-minimized branch but without Windows z-order binding. -3. Preserve existing startup/lost-window behavior: `windowTracker: null` and `isTracking() === false` with `getGeometry() === null` still hide and show the first loading OSD. -4. Run focused tests for `src/core/services/overlay-visibility.test.ts`; then typecheck or the repo runtime verification lane if the focused patch passes. -5. Update TASK-323 notes/acceptance criteria with verification results. - - -## Implementation Notes - - -Added a macOS overlay visibility regression for transient tracker loss with retained geometry. The test failed first because the old path marked tracker-not-ready and hid the overlay. Implemented a scoped preserve path in `src/core/services/overlay-visibility.ts`: macOS now keeps the visible overlay alive only when the tracker still has retained geometry; true loss with null geometry still hides and emits the existing loading OSD behavior. Added changelog fragment `changes/323-macos-overlay-tracker-flaps.md`. - -Verification: `bun test src/core/services/overlay-visibility.test.ts` passed after the fix; `bun test src/window-trackers/macos-tracker.test.ts src/core/services/overlay-visibility.test.ts` passed; `bun run typecheck` passed; `bun run test:env` passed; isolated `bun test src/core/services/subsync.test.ts` passed; `bun run build` passed; `bun run test:smoke:dist` passed; `bun run changelog:lint` passed. `bun run test:fast` failed twice in an unrelated broad-suite interaction where `src/renderer/handlers/keyboard.ts` tried to use missing `window.electronAPI` while `src/core/services/subsync.test.ts` was running, followed by Bun node:test nested-test cascade errors. - - -## Final Summary - - -Fixed the macOS visible-overlay hide/reload path during normal playback by preserving the overlay when the tracker briefly reports non-tracking but still has retained mpv geometry. The overlay visibility service now treats that macOS state like a transient tracker flap: it keeps bounds/layer/order refreshed and leaves the overlay click-through instead of hiding or showing the loading OSD. True macOS loss remains unchanged: no tracker or null geometry still hides the overlay and uses the existing loading behavior. - -Added regression coverage in `src/core/services/overlay-visibility.test.ts` for the active-playback case and added changelog fragment `changes/323-macos-overlay-tracker-flaps.md`. - -Verification passed: focused overlay tests, macOS tracker + overlay tests, typecheck, `test:env`, isolated `subsync.test.ts`, build, dist smoke, and changelog lint. Full `test:fast` remains blocked by an unrelated broad-suite interaction where renderer keyboard state fires without `window.electronAPI` during `subsync.test.ts`, then Bun reports node:test cascade errors. - diff --git a/backlog/tasks/task-324 - Fix-mpv-playlist-changes-re-running-app-warmups.md b/backlog/tasks/task-324 - Fix-mpv-playlist-changes-re-running-app-warmups.md deleted file mode 100644 index f7a9f62d..00000000 --- a/backlog/tasks/task-324 - Fix-mpv-playlist-changes-re-running-app-warmups.md +++ /dev/null @@ -1,63 +0,0 @@ ---- -id: TASK-324 -title: Fix mpv playlist changes re-running app warmups -status: Done -assignee: [] -created_date: '2026-05-03 07:48' -updated_date: '2026-05-03 07:52' -labels: - - bug - - mpv - - overlay -dependencies: [] -references: - - launcher/ - - src/core/services/mpv.ts - - src/main/runtime/ -priority: medium ---- - -## Description - - -When moving to the next or previous mpv playlist entry, SubMiner should reconnect the existing app/runtime to mpv instead of treating the new video like a fresh app startup. Re-running startup warmups or creating another app session after the first video can interfere with overlay behavior. - - -## Acceptance Criteria - -- [x] #1 Changing to next or previous mpv playlist item reuses the existing app/runtime instead of launching a new app session. -- [x] #2 Startup warmups are not repeated for playlist item changes after the first app startup. -- [x] #3 Overlay behavior remains available after playlist navigation. -- [x] #4 Regression test covers the playlist-change/reconnect path. - - -## Implementation Plan - - -1. Reproduce the plugin auto-start regression with a failing Lua start-gate test. -2. Update mpv plugin auto-start handling so playlist/file changes with an already-running overlay reuse the existing app path and do not re-arm pause-until-ready warmup. -3. Add changelog fragment and run plugin/launcher verification. - - -## Implementation Notes - - -RED: `lua scripts/test-plugin-start-gate.lua` failed after changing the duplicate pause-until-ready auto-start expectations; it showed the loading gate was armed twice while overlay was already running. - -GREEN: `plugin/subminer/process.lua` now disarms any old ready gate and only reasserts visible overlay state when auto-start fires while `state.overlay_running` is already true. - - -## Final Summary - - -Summary: -- Updated the mpv Lua plugin auto-start reuse path so a file/playlist load with an already-running overlay no longer re-arms the pause-until-ready tokenization gate. -- Kept the existing app/control command reuse behavior: subsequent auto-starts reassert visible/hidden overlay state without issuing another `--start` subprocess. -- Added a changelog fragment for the mpv playlist overlay reuse fix. - -Tests: -- `lua scripts/test-plugin-start-gate.lua` (red before fix, green after) -- `bun run test:plugin:src` -- `bun run changelog:lint` -- `bun run test:launcher:env:src` - diff --git a/backlog/tasks/task-325 - Fix-keyboard-only-Yomitan-popup-shortcut-precedence.md b/backlog/tasks/task-325 - Fix-keyboard-only-Yomitan-popup-shortcut-precedence.md deleted file mode 100644 index 0e66bcb4..00000000 --- a/backlog/tasks/task-325 - Fix-keyboard-only-Yomitan-popup-shortcut-precedence.md +++ /dev/null @@ -1,55 +0,0 @@ ---- -id: TASK-325 -title: Fix keyboard-only Yomitan popup shortcut precedence -status: Done -assignee: - - codex -created_date: '2026-05-04 01:19' -updated_date: '2026-05-04 01:22' -labels: - - bug - - keyboard - - yomitan -dependencies: [] -priority: high ---- - -## Description - - -When keyboard-only mode is active and a Yomitan popup is visible, popup keyboard controls must win over overlay/mpv/session keybindings. Currently default overlay bindings such as bare `j` can fire instead of scrolling/navigating the Yomitan popup. - - -## Acceptance Criteria - -- [x] #1 With keyboard-only mode active and a Yomitan popup visible, pressing `j`/`k` forwards to the Yomitan popup instead of dispatching default session bindings such as primary subtitle track cycling. -- [x] #2 With keyboard-only mode inactive, existing popup-visible session binding behavior remains unchanged for bound keys. -- [x] #3 Regression coverage captures the keyboard-only popup precedence behavior. - - -## Implementation Plan - - -1. Add a focused regression in `src/renderer/handlers/keyboard.test.ts`: keyboard-only mode + visible Yomitan popup + bare `KeyJ` session binding should forward `KeyJ` to the popup and not dispatch the mpv/session binding. -2. Verify the new test fails before production changes. -3. Patch `src/renderer/handlers/keyboard.ts` so popup key handling ignores session-binding precedence only while keyboard-driven mode is enabled. -4. Run targeted renderer keyboard tests, then update acceptance criteria and final notes. - - -## Implementation Notes - - -Implementation: `handleYomitanPopupKeybind` now only lets configured session bindings take precedence when keyboard-driven mode is not enabled. In keyboard-only mode with a visible Yomitan popup, bare popup keys such as `KeyJ` forward to the popup instead of dispatching overlay/mpv keybindings. Added a regression covering `KeyJ` bound to `cycle sid`. - -Verification: targeted test failed before the production change, then passed after the fix. Full local gates run: `bun test src/renderer/handlers/keyboard.test.ts --test-name-pattern "keyboard mode: popup keybinds take precedence"`, `bun test src/renderer/handlers/keyboard.test.ts`, `bun run changelog:lint`, `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, `bun run test:smoke:dist`. Build initially required `bun install --frozen-lockfile`, submodule init, and `stats/` locked deps install because this worktree had no dependencies/submodules checked out. - - -## Final Summary - - -Fixed keyboard-only Yomitan popup shortcut precedence by allowing popup key forwarding to bypass configured session bindings only while keyboard-driven mode is active. This makes popup controls such as `j`/`k` win over default overlay/mpv bindings like primary subtitle track cycling, while preserving existing non-keyboard-only popup behavior where configured bindings still fire. - -Added renderer keyboard regression coverage for the reported `KeyJ`/`cycle sid` conflict and added a changelog fragment for the user-visible overlay fix. - -Verification passed: targeted red/green regression, full renderer keyboard test file, changelog lint, typecheck, `test:fast`, `test:env`, build, and dist smoke tests. - diff --git a/backlog/tasks/task-325 - Fix-session-chart-known-word-percentage-denominator.md b/backlog/tasks/task-325 - Fix-session-chart-known-word-percentage-denominator.md deleted file mode 100644 index 48d39318..00000000 --- a/backlog/tasks/task-325 - Fix-session-chart-known-word-percentage-denominator.md +++ /dev/null @@ -1,38 +0,0 @@ ---- -id: TASK-325 -title: Fix session chart known-word percentage denominator -status: Done -assignee: [] -created_date: '2026-05-04 01:19' -updated_date: '2026-05-04 01:23' -labels: - - stats -dependencies: [] -priority: medium ---- - -## Description - - -Session detail known-word percentages should use the same filtered vocabulary occurrence rows for both known and total word counts. Current chart can divide known persisted word occurrences by raw token totals, causing excluded tokens to depress the known percentage. - - -## Acceptance Criteria - -- [x] #1 Session known-word timeline API exposes cumulative filtered total word counts alongside known counts. -- [x] #2 Session detail chart computes known/unknown areas from filtered totals, not raw timeline token counts, when known-word data is available. -- [x] #3 Session summary known-word rate uses filtered persisted word totals where available and preserves safe fallback behavior when known-word data is unavailable. -- [x] #4 Regression tests cover filtered denominator behavior for the API and chart data path. - - -## Implementation Notes - - -Implemented in-place fix using existing persisted word occurrence rows. `/api/stats/sessions/:id/known-words-timeline` now returns cumulative `totalWordsSeen` from filtered persisted occurrences, and session known-word rates divide by the same filtered total. Session detail chart builds known/unknown areas from `totalWordsSeen` instead of raw timeline `tokensSeen`. - - -## Final Summary - - -Known-word percentages on session charts now use filtered persisted word totals for both numerator and denominator. No migration/backfill required; data comes from existing `imm_word_line_occurrences`. Added regression coverage for the API response/rate and chart data builder. - diff --git a/backlog/tasks/task-325 - Keep-JLPT-underline-color-fixed-with-combined-lookup-annotations.md b/backlog/tasks/task-325 - Keep-JLPT-underline-color-fixed-with-combined-lookup-annotations.md deleted file mode 100644 index 51ed982e..00000000 --- a/backlog/tasks/task-325 - Keep-JLPT-underline-color-fixed-with-combined-lookup-annotations.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-325 -title: Keep JLPT underline color fixed with combined lookup annotations -status: Done -assignee: - - '@Codex' -created_date: '2026-05-04 00:25' -updated_date: '2026-05-04 00:28' -labels: - - overlay - - jlpt - - renderer -dependencies: [] -references: - - TASK-318 - - TASK-308 -priority: medium ---- - -## Description - - -Yomitan lookup on a subtitle token that has a JLPT level plus another annotation such as frequency or known-word highlighting can make the JLPT underline take the other annotation color. The underline must always remain the token's JLPT level color; other annotation classes may still control text color. - - -## Acceptance Criteria - -- [x] #1 A JLPT token combined with frequency styling keeps its underline set to the configured JLPT level color during lookup/selection styling. -- [x] #2 A JLPT token combined with known-word styling keeps its underline set to the configured JLPT level color during lookup/selection styling. -- [x] #3 Regression coverage exercises combined JLPT plus non-JLPT annotation selectors, including character span selection/hover styling used by lookup. - - -## Implementation Plan - - -1. Add focused renderer CSS regression coverage for combined `word-jlpt-n*` plus known/frequency classes, including `.c::selection`/`.c:hover` lookup paths. -2. Run `bun test src/renderer/subtitle-render.test.ts` and confirm the new assertion fails on the current CSS. -3. Update `src/renderer/style.css` so JLPT decoration color is locked on the token and child character spans without changing text color priority for known/frequency/name/N+1 annotations. -4. Re-run the focused renderer test, then run typecheck/changelog checks as scope requires. - - -## Implementation Notes - - -Added red/green renderer CSS regression for combined JLPT plus known/N+1/frequency annotation classes and character hover lookup paths. Current CSS failed before the lock selectors were added; focused test passes after the CSS change. - - -## Final Summary - - -Fixed JLPT underline color drift for tokens that also carry known-word, N+1, or frequency annotation classes. The renderer CSS now explicitly locks the underline decoration color for combined JLPT annotation selectors, hover, character hover, and selection states while preserving the existing text color priority for other annotations. - -Added renderer regression coverage for combined JLPT plus non-JLPT annotation selectors and lookup character hover paths. Added a user-visible changelog fragment. - -Checks: `bun test src/renderer/subtitle-render.test.ts`; `bun run changelog:lint`; `bun run typecheck`; `bun run format:check:src`. - diff --git a/backlog/tasks/task-326 - Fix-AniList-post-watch-update-after-skipped-completion-threshold.md b/backlog/tasks/task-326 - Fix-AniList-post-watch-update-after-skipped-completion-threshold.md deleted file mode 100644 index 33487b28..00000000 --- a/backlog/tasks/task-326 - Fix-AniList-post-watch-update-after-skipped-completion-threshold.md +++ /dev/null @@ -1,32 +0,0 @@ ---- -id: TASK-326 -title: Fix AniList post-watch update after skipped completion threshold -status: In Progress -assignee: [] -created_date: '2026-05-04 00:33' -labels: - - anilist - - bug -dependencies: [] -priority: high ---- - -## Description - - -AniList episode progress should sync reliably when playback reaches or passes the watched trigger point, even if mpv progress events jump over the exact threshold. Investigate why a completed watched episode did not update AniList and fix the root cause for post-watch tracking. - - -## Acceptance Criteria - -- [x] #1 When playback moves from before the completion threshold to any later position at or beyond the threshold, AniList queues or sends the episode progress update once. -- [x] #2 If playback is already past the completion threshold and the update has not yet been recorded for the current media/episode, AniList still queues or sends the update. -- [x] #3 AniList progress updates remain deduplicated for the same media/episode watch completion. -- [x] #4 A regression test covers the skipped-threshold or already-past-threshold case. - - -## Notes - -- Fixed mpv `time-pos` ordering so post-watch checks read the fresh playback position after seeks. -- Wired manual mark-watched to run a forced AniList post-watch sync after the local watched mark succeeds. -- Added regressions for time-position ordering, manual watched sync, forced post-watch updates, and the Little Witch Academia filename parse. diff --git a/backlog/tasks/task-326 - Make-stats-word-metrics-honor-filtering-rules.md b/backlog/tasks/task-326 - Make-stats-word-metrics-honor-filtering-rules.md deleted file mode 100644 index 66d33e7c..00000000 --- a/backlog/tasks/task-326 - Make-stats-word-metrics-honor-filtering-rules.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -id: TASK-326 -title: Make stats word metrics honor filtering rules -status: Done -assignee: [] -created_date: '2026-05-04 01:35' -updated_date: '2026-05-04 02:08' -labels: - - stats -dependencies: [] -priority: high ---- - -## Description - - -Audit stats app metrics that show or derive from word totals and make them use filtered persisted vocabulary occurrences where the UI concept is learned/seen words. Preserve raw telemetry only where it is intentionally playback/token telemetry. - - -## Acceptance Criteria - -- [x] #1 Stats UI word totals, word rates, lookup-per-word rates, and chart word series use filtered persisted word occurrences where available. -- [x] #2 Known-word metrics continue to use the same filtered denominator as known counts. -- [x] #3 Trend, overview, library, session, and episode surfaces are audited with regression coverage for changed data paths. -- [x] #4 Fallback behavior remains safe for sessions without persisted vocabulary occurrences. - - -## Implementation Notes - - -Audit finding: raw `tokensSeen` / `totalTokensSeen` still feeds overview hints, dashboard aggregation, trends activity/progress/anime cumulative/library summary, lookup-per-100-word rates, session rows/recent sessions/episode sessions, and library/anime/media headers. Vocabulary and known unique word summaries already use persisted filtered vocabulary rows. Recommended design: query-time filtered word totals from existing `imm_word_line_occurrences`, with raw-token fallback only when a session has no persisted occurrence rows. - -Implemented shared query-time filtered word counts. Session summaries, overview hints, daily/monthly rollups, anime/media library/detail rows, anime episode rows, episode/media sessions, trends activity/progress/anime cumulative, library summary, and lookup-per-100-word ratios now use filtered persisted word occurrences. Fallback remains raw token totals only for sessions with no persisted subtitle-line rows. - -Follow-up implemented: Vocab frequency tables now apply the same tokenizer vocabulary predicate at read time, because old `imm_words` rows can predate current tokenizer exclusion rules. Vocabulary persistence and cleanup also mirror the broader subtitle-annotation grammar filters. Added common frequency stop terms observed in the stats vocabulary list to the shared tokenizer exclusion set so those rows are filtered consistently across subtitle annotations, persistence, cleanup, stats reads, and SQL word-count aggregates. - - -## Final Summary - - -Stats word metrics now honor filtering rules through the read-model query layer. Existing persisted `imm_word_line_occurrences` provide the filtered denominator; no migration/backfill needed. Vocab tables filter stored rows on read using tokenizer vocabulary rules, so legacy noisy rows stop appearing without a migration. Added regressions for session/overview/rollup fallback behavior, trends/library lookup-rate behavior, vocabulary read filtering, cleanup filtering, and shared stop-term filtering. - diff --git a/backlog/tasks/task-327 - Persist-stats-page-exclusion-list-in-database.md b/backlog/tasks/task-327 - Persist-stats-page-exclusion-list-in-database.md deleted file mode 100644 index 67ac01b0..00000000 --- a/backlog/tasks/task-327 - Persist-stats-page-exclusion-list-in-database.md +++ /dev/null @@ -1,42 +0,0 @@ ---- -id: TASK-327 -title: Persist stats page exclusion list in database -status: Done -assignee: [] -created_date: '2026-05-04 01:39' -updated_date: '2026-05-04 01:49' -labels: - - feature - - stats - - database -dependencies: [] -priority: medium ---- - -## Description - - -Add database-backed persistence for the stats page exclusion list. On first load with the new schema, seed the new table from the existing exclusion list source so existing user choices are preserved. After migration, update database rows whenever the exclusion list is changed or saved so it persists across browser sessions indefinitely. - - -## Acceptance Criteria - -- [x] #1 A new small database table stores stats page exclusion entries. -- [x] #2 First load with the new schema seeds the table from the existing exclusion list source. -- [x] #3 Subsequent exclusion list save/change operations update the database-backed list. -- [x] #4 Regression coverage verifies migration/seed behavior and persistence updates. - - -## Implementation Notes - - -Implemented DB-backed stats exclusion list using schema version 18 and new `imm_stats_excluded_words` table. Added read/replace query helpers, service methods, and `/api/stats/excluded-words` GET/PUT routes. Stats frontend now loads exclusions from DB, seeds the empty DB table from legacy `localStorage` on first load, and writes each toggle/restore/clear through the API while keeping localStorage in sync for compatibility. Added focused regression coverage for schema/read-replace, API routes, API client, and frontend bootstrap/update behavior. Verification: `bun run typecheck` passed; `bun test src/core/services/__tests__/stats-server.test.ts stats/src/lib/api-client.test.ts stats/src/hooks/useExcludedWords.test.ts` passed; `bun test src/core/services/immersion-tracker/storage-session.test.ts` passed; `bun run docs:test` passed; `bun run format:check:stats` passed; `bun run changelog:lint` passed. Blocked/unrelated: `bun run typecheck:stats` fails in existing stats files (`AnilistSelector.tsx`, `reading-utils*`, `session-grouping.test.ts`, `yomitan-lookup.test.tsx`); `bun run test:immersion:sqlite:src` fails existing `recordSubtitleLine counts exact Yomitan tokens for session metrics` expected 4 got 3; `bun run docs:build` fails missing `@catppuccin/vitepress/theme/macchiato/mauve.css` import. - -Added `src/core/services/__tests__/stats-server.test.ts` and `stats/src/hooks/useExcludedWords.test.ts` to the `test:core:src` allowlist so the new DB exclusion route/client/store regressions run in the maintained fast source lane. - - -## Final Summary - - -Persisted the stats vocabulary exclusion list in SQLite with new schema version 18 table `imm_stats_excluded_words`. Added backend read/replace helpers and `/api/stats/excluded-words` GET/PUT routes, then wired the stats frontend exclusion store to load DB rows, seed an empty DB from legacy browser localStorage on first load, and update the DB on toggle/restore/clear. Updated docs and added changelog fragment. Focused tests and root typecheck pass; broader stats/docs/sqlite gates are blocked by unrelated existing failures recorded in notes. - diff --git a/backlog/tasks/task-327 - Restore-stats-daemon-deferral-when-launching-playback.md b/backlog/tasks/task-327 - Restore-stats-daemon-deferral-when-launching-playback.md deleted file mode 100644 index 9753af94..00000000 --- a/backlog/tasks/task-327 - Restore-stats-daemon-deferral-when-launching-playback.md +++ /dev/null @@ -1,67 +0,0 @@ ---- -id: TASK-327 -title: Restore stats daemon deferral when launching playback -status: Done -assignee: - - '@Codex' -created_date: '2026-05-04 01:15' -updated_date: '2026-05-04 01:17' -labels: - - bug - - stats - - runtime -dependencies: [] -priority: high ---- - -## Description - - -Launching a video while a background stats daemon is already running must not fail with stats.serverPort already in use. Normal in-app stats startup should reuse the live daemon URL instead of binding a second stats server, while preserving managed playback shutdown behavior from TASK-316. - - -## Acceptance Criteria - -- [x] #1 A live background stats daemon from another process causes in-app stats URL resolution to return the daemon URL without starting a local stats server. -- [x] #2 Dead or stale daemon state is removed and local stats startup still works. -- [x] #3 Managed playback shutdown behavior remains covered by existing tests. -- [x] #4 Focused regression tests pass. - - -## Implementation Plan - - -1. Update `src/main/runtime/stats-server-routing.test.ts` first so a live foreign daemon must return its daemon URL and skip local server startup. -2. Run the focused routing test to confirm the regression fails red. -3. Update `src/main/runtime/stats-server-routing.ts` to return `{ source: 'background' }` for live foreign daemon state, clear stale/self-owned state, and keep local startup fallback unchanged. -4. Run focused stats routing tests plus managed playback tests touched by TASK-316. -5. Update changelog and task acceptance/final notes. - - -## Implementation Notes - - -Implemented via TDD: first changed `stats-server-routing.test.ts` to require live foreign daemon deferral and observed the expected red failure. Then restored `stats-server-routing.ts` to return the daemon URL with `source: 'background'` when daemon state belongs to a live other process. Stale/dead and self-owned stale cleanup paths remain local fallback. - -Verification passed: `bun test src/main/runtime/stats-server-routing.test.ts`; focused runtime suite for stats daemon + TASK-316 managed playback files; `bun run typecheck`; `bun run test:fast`. - -`bun run changelog:lint` is blocked by pre-existing unrelated `changes/326-anilist-time-position-post-watch.md` missing valid `type` metadata; `changes/327-stats-daemon-deferral.md` follows the expected fragment format. - - -## Final Summary - - -Summary: -- Restored in-app stats startup deferral to a live background stats daemon from another process, returning the daemon URL and skipping local stats server binding. -- Kept stale/dead daemon cleanup and local stats startup fallback behavior intact. -- Added a changelog fragment for the restored port-conflict fix. - -Verification: -- `bun test src/main/runtime/stats-server-routing.test.ts` -- `bun test src/main/runtime/stats-server-routing.test.ts src/core/services/mpv.test.ts src/core/services/mpv-protocol.test.ts src/main/runtime/mpv-client-event-bindings.test.ts src/main/runtime/mpv-main-event-bindings.test.ts src/main/runtime/mpv-main-event-main-deps.test.ts src/main/runtime/stats-cli-command.test.ts src/stats-daemon-control.test.ts` -- `bun run typecheck` -- `bun run test:fast` - -Blocked check: -- `bun run changelog:lint` fails on unrelated pre-existing `changes/326-anilist-time-position-post-watch.md` metadata, not this change. - diff --git a/backlog/tasks/task-328 - Keep-subtitle-prefetch-running-after-immediate-cached-annotation-render.md b/backlog/tasks/task-328 - Keep-subtitle-prefetch-running-after-immediate-cached-annotation-render.md deleted file mode 100644 index cf09a4d0..00000000 --- a/backlog/tasks/task-328 - Keep-subtitle-prefetch-running-after-immediate-cached-annotation-render.md +++ /dev/null @@ -1,64 +0,0 @@ ---- -id: TASK-328 -title: Keep subtitle prefetch running after immediate cached annotation render -status: Done -assignee: - - codex -created_date: '2026-05-04 01:26' -updated_date: '2026-05-04 01:30' -labels: [] -dependencies: [] -references: - - >- - /home/sudacode/projects/japanese/SubMiner/src/main/runtime/mpv-main-event-actions.ts - - /home/sudacode/projects/japanese/SubMiner/src/main.ts - - >- - /home/sudacode/projects/japanese/SubMiner/src/core/services/subtitle-processing-controller.ts - - >- - /home/sudacode/projects/japanese/SubMiner/backlog/completed/task-197 - - Eliminate-per-line-plain-subtitle-flash-on-prefetch-cache-hit.md - - >- - /home/sudacode/projects/japanese/SubMiner/backlog/completed/task-196 - - Fix-subtitle-prefetch-cache-key-mismatch-and-active-cue-window.md -priority: high ---- - -## Description - - -Cached subtitle annotation hits should render annotated subtitles immediately without starving the subtitle prefetcher. Current evidence: the mpv subtitle-change path emits the cached payload before forwarding the subtitle change; in the runtime, the cached emit resumes prefetch, then the forwarded change pauses it, and no async controller emit follows on a cache hit to resume it again. - - -## Acceptance Criteria - -- [x] #1 Cached subtitle annotation payloads still render immediately without a plain subtitle flash. -- [x] #2 A cache-hit subtitle-change event leaves subtitle prefetch eligible to continue after the immediate annotated emit. -- [x] #3 Cache-miss subtitle-change behavior still shows plain text immediately while async annotation processing runs. -- [x] #4 Regression coverage proves the cache-hit ordering that prevents prefetch from staying paused. - - -## Implementation Plan - - -1. Add a focused regression test in `src/main/runtime/mpv-main-event-actions.test.ts` proving cache-hit subtitle changes pause live prefetch work before emitting the immediate annotated payload, so the emit resumes prefetch last. -2. Change `createHandleMpvSubtitleChangeHandler` ordering in `src/main/runtime/mpv-main-event-actions.ts`: set current text, consume cache, forward `onSubtitleChange(text)`, then emit cached payload or plain fallback, then refresh Discord presence. -3. Preserve existing behavior: cache hits emit annotated payload synchronously; cache misses emit `{ text, tokens: null }` synchronously. -4. Run focused tests for `mpv-main-event-actions`; run adjacent controller/prefetch tests if ordering touches cache assumptions. -5. Update TASK-328 acceptance criteria and add a changelog fragment if the repo requires one for this user-visible fix. - - -## Implementation Notes - - -Red/green: added cache-hit ordering regression in `src/main/runtime/mpv-main-event-actions.test.ts`; first run failed with actual order `emit:annotated` before `process:line`. Fix narrows ordering change to cache hits only: cache hit calls `onSubtitleChange` before immediate annotated emit; cache miss keeps plain broadcast before processing. - -Verification: `bun test src/main/runtime/mpv-main-event-actions.test.ts` passed; `bun test src/core/services/subtitle-processing-controller.test.ts` passed; `bun test src/core/services/subtitle-prefetch.test.ts` passed; combined targeted test command passed 35 tests; `bun run typecheck` passed. `bun run changelog:lint` blocked by unrelated pre-existing `changes/326-anilist-time-position-post-watch.md` missing a valid `type` metadata line. - - -## Final Summary - - -Fixed the subtitle cache-hit ordering that could leave subtitle prefetch paused after an immediate annotated render. Cache hits now forward the subtitle change first, then emit the cached annotated payload, so the runtime pause happens before the emit path resumes prefetch. Cache misses keep the previous plain-subtitle-first path so fallback text still appears immediately while tokenization runs. - -Added a regression test for the cache-hit ordering and a changelog fragment for the overlay fix. Verified with targeted subtitle runtime/controller/prefetch tests and `bun run typecheck`; changelog lint is blocked by an unrelated existing malformed fragment for TASK-326. - diff --git a/backlog/tasks/task-329 - Keep-JLPT-subtitle-styling-underline-only.md b/backlog/tasks/task-329 - Keep-JLPT-subtitle-styling-underline-only.md deleted file mode 100644 index 7d1d9163..00000000 --- a/backlog/tasks/task-329 - Keep-JLPT-subtitle-styling-underline-only.md +++ /dev/null @@ -1,43 +0,0 @@ ---- -id: TASK-329 -title: Keep JLPT subtitle styling underline-only -status: Done -assignee: [] -created_date: '2026-05-04 02:13' -labels: - - bug - - renderer - - jlpt -dependencies: [] -references: - - src/renderer/style.css - - src/renderer/subtitle-render.test.ts -priority: medium ---- - -## Description - - -Fix subtitle token styling so JLPT metadata never changes token text color. JLPT should only render the level marker/underline affordance while known, n+1, name-match, and frequency colors retain priority. - - -## Acceptance Criteria - -- [x] #1 JLPT-only subtitle tokens do not set token text color. -- [x] #2 JLPT level marker/underline still uses configured JLPT color. -- [x] #3 Existing known, n+1, name-match, and frequency text colors remain unchanged. - - -## Final Summary - - -Changed subtitle JLPT styling from text color to underline decoration and updated renderer CSS regression coverage. - -Verification: -- `bun test src/renderer/subtitle-render.test.ts` -- `bunx prettier --check src/renderer/subtitle-render.test.ts src/renderer/style.css` -- `bun run typecheck` - -Blocked: -- `bun run test:fast` fails in existing dirty stats/session work: `recordSubtitleLine counts exact Yomitan tokens for session metrics` expects `tokensSeen` 4 but gets 3. - diff --git a/backlog/tasks/task-330 - Fix-PR-60-CI-failures-and-CodeRabbit-feedback.md b/backlog/tasks/task-330 - Fix-PR-60-CI-failures-and-CodeRabbit-feedback.md deleted file mode 100644 index 505ab427..00000000 --- a/backlog/tasks/task-330 - Fix-PR-60-CI-failures-and-CodeRabbit-feedback.md +++ /dev/null @@ -1,70 +0,0 @@ ---- -id: TASK-330 -title: Fix PR 60 CI failures and CodeRabbit feedback -status: Done -assignee: - - codex -created_date: '2026-05-04 02:50' -updated_date: '2026-05-04 02:59' -labels: - - ci - - pr-review -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/60' -priority: high ---- - -## Description - - -Resolve failing GitHub Actions checks and actionable unresolved CodeRabbit review feedback on PR #60 (Persist stats exclusions in DB and fix word metrics filtering). Keep fixes scoped to the PR behavior and preserve existing project patterns. - - -## Acceptance Criteria - -- [x] #1 Failing GitHub Actions checks for PR #60 have an identified root cause and local fix. -- [x] #2 All actionable unresolved CodeRabbit review comments on PR #60 are addressed locally or explicitly documented as non-actionable. -- [x] #3 Relevant local verification passes for the changed code paths. -- [x] #4 Task notes summarize CI failure context, review-comment handling, and any residual verification gaps. - - -## Implementation Plan - - -1. Resolve PR #60 context and inspect GitHub Actions failures with the gh-fix-ci workflow. -2. Fetch unresolved review threads with the gh-address-comments workflow, focusing on CodeRabbit actionable comments. -3. Read the touched files/tests around the failing paths and comments; identify root cause before edits. -4. Apply minimal fixes with regression coverage where appropriate. -5. Run targeted verification first, then broader repo gates as time permits. -6. Update Backlog notes/acceptance criteria with CI/comment outcomes and residual risks. - - -## Implementation Notes - - -Resolved PR #60 CI failure by restoring raw `tokensSeen` for session summaries while keeping filtered persisted word counts in aggregate/known-word paths. Addressed CodeRabbit feedback: fixed missing `headword` test fixture binding; paged vocabulary stats past filtered rows; preserved lifetime/rollup totals when retained-session recomputation is partial; emitted flat known-word timeline points for zero-visible-word line gaps; restored localStorage mocks; added rollback/retry behavior for excluded-word store persistence/initialization. - - -## Final Summary - - -Fixed the PR #60 CI failure and addressed actionable CodeRabbit feedback. - -Key changes: -- Restored exact Yomitan token counts for session summary metrics while leaving filtered word counts for aggregate and known-word calculations. -- Fixed malformed query test fixtures by binding `headword` into `imm_words` inserts. -- Updated vocabulary stats to page until enough visible rows are collected after post-query filtering. -- Made library/detail/rollup read models preserve lifetime or stored rollup totals when retained-session recomputation is partial, including dashboard rollup-derived word metrics. -- Kept known-word timeline line positions stable by emitting flat points for missing line indexes. -- Made excluded-word persistence rollback on failed writes, allow initialization retries after transient load failures, and restored mocked `localStorage` in tests. - -Verification passed: -- `bun run typecheck` -- `bun run test:fast` -- `bun run test:env` -- `bun run build` -- `bun run test:smoke:dist` -- `bun run format:check:src` -- `git diff --check` - diff --git a/backlog/tasks/task-331 - Address-unresolved-CodeRabbit-comments-on-PR-57.md b/backlog/tasks/task-331 - Address-unresolved-CodeRabbit-comments-on-PR-57.md deleted file mode 100644 index 1aacb8e7..00000000 --- a/backlog/tasks/task-331 - Address-unresolved-CodeRabbit-comments-on-PR-57.md +++ /dev/null @@ -1,37 +0,0 @@ ---- -id: TASK-331 -title: Address unresolved CodeRabbit comments on PR 57 -status: Done -assignee: - - codex -created_date: '2026-05-04 03:21' -updated_date: '2026-05-04 03:27' -labels: - - pr-feedback - - coderabbit -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/57' -priority: medium ---- - -## Description - - -Assess and fix unresolved CodeRabbit review comments on PR #57 after rebasing tokenizer-updates. Scope includes manual clipboard SentenceAudio guard, tokenizer standalone particle blacklist, AniList guessit fallback confidence, startup gate duplicate auto-start, and small regression-test hardening where applicable. - - -## Acceptance Criteria - -- [x] #1 Each unresolved CodeRabbit comment is either fixed or explicitly assessed as not applicable against current code. -- [x] #2 Regression tests cover behavior changes where practical. -- [x] #3 Relevant focused tests and typecheck pass. - - -## Implementation Notes - - -Fixed all verified actionable CodeRabbit comments from PR #57: manual clipboard updates no longer fall back to ExpressionAudio when SentenceAudio is absent, connective particle phrases no longer suppress lexical verb readings like 立って, guessit output only borrows parser season/episode from non-low-confidence parses, duplicate auto-start no longer releases an active pause-until-ready gate, JLPT CSS tests block text-decoration shorthand underlines, post-watch update rejection logging is covered, and duplicate quit-on-disconnect predicate code is shared. - -Verification: bun test src/anki-integration/card-creation-manual-update.test.ts src/core/services/tokenizer/annotation-stage.test.ts src/core/services/anilist/anilist-updater.test.ts src/main/runtime/mpv-main-event-actions.test.ts src/renderer/subtitle-render.test.ts; lua scripts/test-plugin-start-gate.lua; bun run typecheck; bun run test:fast. - diff --git a/backlog/tasks/task-332 - Fix-subtitle-frequency-annotation-missing-ranks-shown-in-Yomitan-popup.md b/backlog/tasks/task-332 - Fix-subtitle-frequency-annotation-missing-ranks-shown-in-Yomitan-popup.md deleted file mode 100644 index 53fc6882..00000000 --- a/backlog/tasks/task-332 - Fix-subtitle-frequency-annotation-missing-ranks-shown-in-Yomitan-popup.md +++ /dev/null @@ -1,60 +0,0 @@ ---- -id: TASK-332 -title: Fix subtitle frequency annotation missing ranks shown in Yomitan popup -status: Done -assignee: - - Codex -created_date: '2026-05-04 03:29' -updated_date: '2026-05-04 03:41' -labels: - - bug - - tokenizer -dependencies: [] -priority: medium ---- - -## Description - - -Subtitle frequency highlighting can miss a token even when the Yomitan popup shows a rank within the configured threshold. Reproduced with `第二走者とアンカーは\n中継地点に速やかに移動！`: Yomitan popup shows `第二` JPDB rank 1820, but SubMiner tokenizer output has no `frequencyRank` for `第二`, so renderer cannot annotate it. - - -## Acceptance Criteria - -- [x] #1 `第二` in `第二走者とアンカーは\n中継地点に速やかに移動！` receives the Yomitan rank shown by the popup when frequency highlighting is enabled. -- [x] #2 Regression test covers the Yomitan scan/frequency ingestion path for exact popup-derived ranks. -- [x] #3 Existing tokenizer frequency tests continue to pass. - - -## Implementation Plan - - -1. Reproduce and inspect the missing `第二` rank path with tokenizer probes and focused tests. -2. Preserve exact Yomitan scan frequency ranks when the matching frequency entry omits reading metadata but has the same exact term. -3. Allow ranked ordinal prefix-noun tokens (`第` + numeric noun, e.g. `第二`) through annotation POS filtering while keeping standalone prefixes excluded. -4. Verify with focused tokenizer/runtime/annotation tests, typecheck, changelog lint, and a live-style Yomitan profile probe. - - -## Implementation Notes - - -Root-cause probe against temp copy of Yomitan profile: tokenizer returns no frequencyRank for `第二`; renderer config `topX` is 10000, so render threshold is not the blocker. - -User approved implementation plan on 2026-05-04. - -Verification: `bun test src/core/services/tokenizer.test.ts src/core/services/tokenizer/yomitan-parser-runtime.test.ts src/core/services/tokenizer/annotation-stage.test.ts` passed (192 tests). - -Verification: `bun run typecheck` passed. - -Verification: `bun run changelog:lint` passed. - -Verification: `bun run get-frequency:electron -- --yomitan-user-data /tmp/subminer-yomitan-probe-909423 "第二走者とアンカーは\\n中継地点に速やかに移動！"` produced `第二` with `frequencyRank: 1820`. - -Finalization check: implementation plan updated to reflect the discovered POS-filter root cause and completed solution. - - -## Final Summary - - -Fixed subtitle frequency annotation for `第二` by allowing ranked ordinal prefix-noun compounds through annotation POS filtering. Also made scan rank matching tolerate exact frequency entries where one side omits reading metadata. Verified with tokenizer/runtime/annotation tests, typecheck, changelog lint, and a live-style Yomitan profile probe showing `第二` now receives frequencyRank 1820. - diff --git a/backlog/tasks/task-333 - Suppress-aru-subtitle-annotations.md b/backlog/tasks/task-333 - Suppress-aru-subtitle-annotations.md deleted file mode 100644 index 293fc8f1..00000000 --- a/backlog/tasks/task-333 - Suppress-aru-subtitle-annotations.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-333 -title: Suppress aru subtitle annotations -status: Done -assignee: [] -created_date: '2026-05-04 04:39' -updated_date: '2026-05-04 05:02' -labels: - - tokenizer - - annotations - - bug -dependencies: [] -priority: medium ---- - -## Description - - -Add `ある` / `有る` to the subtitle annotation suppression path so `aru` tokens remain hoverable and never receive N+1, JLPT, frequency, or name-match annotation metadata. Known-word highlighting is special: if a filtered `aru` token is known and known highlighting is enabled, it should still render as known. - - -## Acceptance Criteria - -- [x] #1 `ある` and kanji headword/surface variants such as `有る` are excluded by the subtitle annotation filter. -- [x] #2 Annotation stripping clears N+1, JLPT, frequency, and name metadata for `aru` tokens while preserving token hover data. -- [x] #3 Known-word highlighting still applies to filtered tokens, including `aru`, when known-word lookup marks them known. -- [x] #4 Regression coverage fails before the fix and passes after. - - -## Implementation Plan - - -1. Add `ある`/`有る`/`在る` to the shared subtitle annotation hard-exclusion terms. -2. Preserve/recompute known-word status for filtered tokens while stripping N+1, JLPT, frequency, and name metadata. -3. Add RED/GREEN unit and tokenizer regression coverage, plus a changelog fragment. -4. Run targeted tests and full handoff gate. - - -## Implementation Notes - - -TDD path: added failing annotation-stage coverage first. Initial implementation made targeted tests pass, then broader tokenizer coverage revealed an older fixture expecting `ある` to remain lexical; updated that integration expectation to the new requested behavior. Follow-up correction: known-word highlighting is the lone annotation exception for filtered tokens, so the strip path now preserves known state and `annotateTokens` recomputes known status for filtered tokens while still clearing N+1/JLPT/frequency/name metadata. - - -## Final Summary - - -Suppressed non-known subtitle annotations for `aru` existence verbs by adding `ある`, `有る`, and `在る` to the shared hard-exclusion list. Corrected the filtered-token path so known-word highlighting still applies whenever known highlighting is enabled; filtered tokens now keep/gain `isKnown` but still lose N+1, JLPT, frequency, and name metadata. - -Added and updated annotation-stage and tokenizer regression coverage for `aru`, particles, helper fragments, interjections, and other filtered known tokens. Added `changes/333-aru-annotation-filter.md`. - -Validation passed: RED failures observed before implementation/correction; `bun test src/core/services/tokenizer/annotation-stage.test.ts`; `bun test src/core/services/tokenizer.test.ts`; `bun run typecheck`; `bun run format:check:src`; `bun run changelog:lint`; `bun run test:fast`; `bun run test:env`; `bun run build`; `bun run test:smoke:dist`. - diff --git a/backlog/tasks/task-334 - Assess-and-address-PR-57-latest-CodeRabbit-comments.md b/backlog/tasks/task-334 - Assess-and-address-PR-57-latest-CodeRabbit-comments.md deleted file mode 100644 index e1ef92a3..00000000 --- a/backlog/tasks/task-334 - Assess-and-address-PR-57-latest-CodeRabbit-comments.md +++ /dev/null @@ -1,53 +0,0 @@ ---- -id: TASK-334 -title: Assess and address PR 57 latest CodeRabbit comments -status: Done -assignee: - - '@codex' -created_date: '2026-05-04 05:03' -updated_date: '2026-05-04 05:07' -labels: - - pr-feedback - - coderabbit -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/57' -priority: medium ---- - -## Description - - -Assess the latest CodeRabbit review on PR #57 submitted 2026-05-04 and fix verified issues. Current scope: AniList post-watch duplicate-write race, known-word cache mutation return value, and manual-mark AniList rejection isolation with regression coverage. - - -## Acceptance Criteria - -- [x] #1 Each latest CodeRabbit comment is either fixed or explicitly assessed as not applicable against current code. -- [x] #2 Regression tests cover behavior changes where practical. -- [x] #3 Relevant focused tests and typecheck pass, or any blocked verification is documented. - - -## Implementation Plan - - -1. Verify each latest CodeRabbit finding against current code. -2. Update known-word cache append return semantics so cache clears are reported as mutations when state existed. -3. Acquire AniList post-watch in-flight before async gating and release in finally. -4. Isolate manual-mark AniList callback failures in IPC and add a rejection-path regression test. -5. Run focused tests for touched areas plus typecheck; document any blocked verification. - - -## Implementation Notes - - -Verified latest CodeRabbit review submitted 2026-05-04 on PR #57. Fixed all three current items: known-word cache mutation return after cache reset, AniList post-watch concurrent in-flight race, and manual watched mark isolation from AniList callback failures. Added regression tests for each path and a changelog fragment. - - -## Final Summary - - -Fixed latest PR #57 CodeRabbit feedback by reporting known-word cache clears as mutations during immediate append, acquiring AniList post-watch in-flight before awaited gates to prevent duplicate writes, and isolating manual watched mark success from AniList post-watch callback failures. Added focused regression coverage in known-word cache, AniList post-watch, and IPC tests, plus a changelog fragment. - -Verification: bun test src/anki-integration/known-word-cache.test.ts; bun test src/main/runtime/anilist-post-watch.test.ts; bun test src/core/services/ipc.test.ts; bun run typecheck; bun run format:check:src; bun run changelog:lint; bun run test:fast; bun run test:env; bun run build; bun run test:smoke:dist. - diff --git a/backlog/tasks/task-335 - Fix-Linux-AniList-setup-gate-using-stored-keyring-token.md b/backlog/tasks/task-335 - Fix-Linux-AniList-setup-gate-using-stored-keyring-token.md deleted file mode 100644 index d1ebca86..00000000 --- a/backlog/tasks/task-335 - Fix-Linux-AniList-setup-gate-using-stored-keyring-token.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-335 -title: Fix Linux AniList setup gate using stored keyring token -status: Done -assignee: [] -created_date: '2026-05-04 05:26' -updated_date: '2026-05-04 05:30' -labels: - - anilist - - bug - - linux -dependencies: [] -priority: high ---- - -## Description - - -AniList setup page reopens on Linux video launch even when the token exists in secret storage and post-watch updates can use it. Investigate setup gating versus update token refresh paths and make them agree on stored-token availability. - - -## Acceptance Criteria - -- [x] #1 Launching a video on Linux with an AniList token available in secret storage does not show the AniList setup page just because config accessToken is empty. -- [x] #2 If secret storage load fails, setup/errors surface the underlying storage problem instead of behaving like an empty token. -- [x] #3 Regression coverage exercises the setup-gate token availability path and preserves post-watch update token behavior. - - -## Implementation Notes - - -Patched AniList setup callback to require successful token persistence before caching/closing the setup flow. Patched config reload auth refresh to pass allowSetupPrompt:false so normal startup/playback reloads do not open AniList setup UI. Added regression coverage around persistence failure and non-prompting config refresh. - - -## Final Summary - - -Fixed AniList setup/login flow so failed encrypted token persistence no longer reports success or seeds only an in-memory token. Config reload now refreshes AniList auth state without opening the setup window during playback, reducing repeated Linux setup prompts when safeStorage/keyring resolution fails. - diff --git a/backlog/tasks/task-337 - Fix-transient-Linux-safeStorage-failure-poisoning-AniList-token-store.md b/backlog/tasks/task-337 - Fix-transient-Linux-safeStorage-failure-poisoning-AniList-token-store.md deleted file mode 100644 index 6e534600..00000000 --- a/backlog/tasks/task-337 - Fix-transient-Linux-safeStorage-failure-poisoning-AniList-token-store.md +++ /dev/null @@ -1,39 +0,0 @@ ---- -id: TASK-337 -title: Fix transient Linux safeStorage failure poisoning AniList token store -status: Done -assignee: [] -created_date: '2026-05-04 05:51' -updated_date: '2026-05-04 05:52' -labels: - - anilist - - bug - - linux -dependencies: [] -priority: high ---- - -## Description - - -AniList token store memoizes a false safeStorage availability result. On Linux this can happen before Electron/keyring readiness, causing later post-watch updates and setup saves to report missing login/encryption unavailable even after the keyring is available. - - -## Acceptance Criteria - -- [x] #1 A transient safeStorage unavailable result does not prevent a later stored AniList token load once encryption is available. -- [x] #2 A transient safeStorage unavailable result does not prevent a later AniList token save once encryption is available. -- [x] #3 Regression coverage protects the retry behavior. - - -## Implementation Notes - - -Changed AniList token store safeStorage probe to memoize successful probes only. Failed probes now return false without poisoning later load/save attempts, covering Linux startup windows where Electron safeStorage/keyring can be unavailable before app readiness but usable later. Added regression test for transient unavailable -> available load/save retry. - - -## Final Summary - - -Fixed a Linux AniList auth failure where an early safeStorage/keyring miss was cached for the whole process. Stored tokens now load and setup tokens can save after GNOME libsecret becomes available later in startup. - diff --git a/backlog/tasks/task-338 - Fix-known-word-highlight-on-standalone-subtitle-particles.md b/backlog/tasks/task-338 - Fix-known-word-highlight-on-standalone-subtitle-particles.md deleted file mode 100644 index e8432e9c..00000000 --- a/backlog/tasks/task-338 - Fix-known-word-highlight-on-standalone-subtitle-particles.md +++ /dev/null @@ -1,72 +0,0 @@ ---- -id: TASK-338 -title: Fix known-word highlight on standalone subtitle particles -status: Done -assignee: - - codex -created_date: '2026-05-04 05:52' -updated_date: '2026-05-04 05:57' -labels: - - bug - - subtitle - - tokenizer -dependencies: [] -references: - - src/core/services/tokenizer/annotation-stage.ts - - src/core/services/tokenizer/subtitle-annotation-filter.ts - - src/renderer/subtitle-render.ts -priority: medium ---- - -## Description - - -Standalone grammar particles such as に should not render as known-word green when they appear in the known-word cache as readings for other words. Keep known-word coloring for lexical tokens, but prevent grammar-excluded subtitle tokens from getting known-green. - - -## Acceptance Criteria - -- [x] #1 Standalone grammar particles like に do not retain isKnown after subtitle annotation filtering. -- [x] #2 Lexical known-word tokens still render as known when not grammar-excluded. -- [x] #3 Focused regression test covers the particle false-positive path. - - -## Implementation Plan - - -1. Add a focused regression in `src/core/services/tokenizer/annotation-stage.test.ts` showing standalone particle `に` is grammar-excluded and does not retain `isKnown` even when `isKnownWord('に')` is true. -2. Run the focused tokenizer annotation test and confirm the new test fails for the current behavior. -3. Patch `src/core/services/tokenizer/annotation-stage.ts` so grammar-excluded tokens clear known status while still stripping N+1/frequency/JLPT/name metadata. -4. Run the focused test file, then inspect diff and update task acceptance criteria. - - -## Implementation Notes - - -Implemented tokenizer annotation filtering so grammar-excluded subtitle tokens clear known-word status instead of retaining green known coloring. Added focused regression for known-word-cache particle false positive and updated existing expectations for unified annotation clearing. Verification: `bun test src/core/services/tokenizer/annotation-stage.test.ts --test-name-pattern "clears known status from standalone particles"` failed before the production patch; after patch, `bun test src/core/services/tokenizer/annotation-stage.test.ts`, `bun test src/core/services/tokenizer.test.ts`, combined tokenizer tests, `bun run typecheck`, `bun run changelog:lint`, and `bun run test:fast` passed. - -Full handoff gate follow-up: `bun run test:env` and `bun run build` passed. `bun run test:smoke:dist` failed outside this tokenizer change in `dist/core/services/overlay-manager.test.js` because current dirty overlay-window code calls `window.getTitle()` on a test mock that does not provide it. - - -## Final Summary - - -Summary: -- Cleared `isKnown` for grammar-excluded subtitle tokens in the tokenizer annotation stage, preventing standalone particles such as `に` from rendering as known just because a known-word deck contains a matching reading. -- Added a focused regression test for the known-word-cache false positive and updated tokenizer expectations so helper/grammar spans consistently clear all subtitle annotations. -- Added changelog fragment `changes/338-known-word-particle-highlights.md`. - -Verification: -- `bun test src/core/services/tokenizer/annotation-stage.test.ts --test-name-pattern "clears known status from standalone particles"` failed before the production patch. -- `bun test src/core/services/tokenizer/annotation-stage.test.ts` -- `bun test src/core/services/tokenizer.test.ts` -- `bun test src/core/services/tokenizer/annotation-stage.test.ts src/core/services/tokenizer.test.ts` -- `bun run typecheck` -- `bun run changelog:lint` -- `bun run test:fast` -- `bun run test:env` -- `bun run build` - -Blocked/External: -- `bun run test:smoke:dist` currently fails outside this tokenizer change in `dist/core/services/overlay-manager.test.js`: dirty overlay-window code calls `window.getTitle()` on a test mock without that method. - diff --git a/backlog/tasks/task-340 - Restore-default-replay-and-next-subtitle-overlay-keybindings.md b/backlog/tasks/task-340 - Restore-default-replay-and-next-subtitle-overlay-keybindings.md deleted file mode 100644 index de6ab702..00000000 --- a/backlog/tasks/task-340 - Restore-default-replay-and-next-subtitle-overlay-keybindings.md +++ /dev/null @@ -1,65 +0,0 @@ ---- -id: TASK-340 -title: Restore default replay and next subtitle overlay keybindings -status: Done -assignee: - - Codex -created_date: '2026-05-04 06:25' -updated_date: '2026-05-04 06:49' -labels: - - bug - - keybindings - - overlay - - mpv -dependencies: [] -priority: high ---- - -## Description - - -Default overlay/mpv keybindings for replaying the current subtitle line and playing the next subtitle line are not firing. Shift+H and Shift+L subtitle jumps still work, but Ctrl+Shift+H should replay the current subtitle and pause at subtitle end, and Ctrl+Shift+L should play the next subtitle and pause at subtitle end. Keep the other built-in defaults working. - - -## Acceptance Criteria - -- [x] #1 Default keybindings include working replay-current-subtitle and play-next-subtitle bindings on Ctrl+Shift+H and Ctrl+Shift+L. -- [x] #2 Replay-current-subtitle dispatch reaches the existing runtime path that pauses at the subtitle end. -- [x] #3 Play-next-subtitle dispatch reaches the existing runtime path that pauses at the subtitle end. -- [x] #4 Existing default keybindings continue to compile/register without regressions. -- [x] #5 Focused regression tests cover the broken default bindings. - - -## Implementation Plan - - -1. Add focused regression coverage that the resolved defaults compile on Linux without dropping Ctrl+Shift+H/L, and that those keys map to replayCurrentSubtitle/playNextSubtitle session actions. -2. Move the default session-help shortcut off Ctrl/Cmd+Shift+H to a non-conflicting shortcut, then update generated/default config docs so shipped defaults match documentation. -3. Add/adjust coverage for default replay/next bindings and run targeted Bun tests plus plugin session-binding smoke. - -4. Follow-up after live test: fix the mpv plugin shifted-letter key-name conversion so `Ctrl+Shift+KeyL` registers using mpv's uppercase letter form and add Lua regression coverage for both `Ctrl+Shift+L` and `Shift+L`. - - -## Implementation Notes - - -Root cause: default `shortcuts.openSessionHelp = CommandOrControl+Shift+H` canonicalized to `ctrl+shift+KeyH` on Linux/Windows, conflicting with the built-in replay-current-subtitle keybinding. The session-binding compiler drops conflicted bindings, so replay did not register. Moved default session help to `CommandOrControl+Slash` and added regression coverage that defaults compile without a conflict and keep replay/next actions on `Ctrl+Shift+H/L`. - -Follow-up from live test: `Ctrl+Shift+H` works after resolving the help shortcut conflict, but `Ctrl+Shift+L` still behaves like native/other `Ctrl+L`. Investigating mpv/plugin key-name generation for shifted letter chords. - -Follow-up fix: mpv normalizes shifted letter chords to uppercase letter key names (for example `Ctrl+Shift+l` becomes `Ctrl+L`). The plugin previously emitted `Ctrl+Shift+l`, which let live `Ctrl+Shift+L` fall through as the `Ctrl+L` key path. `plugin/subminer/session_bindings.lua` now emits uppercase letters and omits the Shift modifier for shifted `Key[A-Z]` bindings. Lua regression coverage now checks `Ctrl+Shift+KeyL -> Ctrl+L`, `Shift+KeyL -> L`, and the play-next CLI dispatch. - -Second live follow-up: `Ctrl+Shift+L` routed to play-next but still behaved like `Shift+L` when playback was already paused because `MpvIpcClient.playNextSubtitle()` explicitly cleared `pendingPauseAtSubEnd` and only sent `sub-seek 1` in paused state. Changed play-next to always arm pause-at-sub-end, clear stale pause target, seek to next subtitle, and unpause when currently paused. Existing sub-end/time-pos handling then pauses at the next subtitle end. - - -## Final Summary - - -Changed the default session-help shortcut from `CommandOrControl+Shift+H` to `CommandOrControl+Slash` so `Ctrl+Shift+H` remains available for replay-current-subtitle and `Ctrl+Shift+L` remains available for play-next-subtitle. Updated config examples, docs-site shortcut/config/usage docs, and added changelog fragment `changes/340-default-subtitle-keybindings.md`. - -Fixed both follow-up issues from live testing. First, the mpv plugin key-name converter now uses mpv's uppercase key form for shifted letter bindings (`Ctrl+Shift+KeyL` registers as `Ctrl+L`, `Shift+KeyL` as `L`). Second, `MpvIpcClient.playNextSubtitle()` now starts playback even when mpv is paused, keeps the pause-at-sub-end path armed, and lets existing subtitle-end timing pause again at the next subtitle end. - -Regression coverage now includes compiled default bindings, Lua plugin shifted-letter registration/CLI dispatch, and paused-state play-next behavior. - -Verification passed: targeted Bun session/mpv/protocol tests, `bun run test:plugin:src`, `bun run changelog:lint`, `bun run build`, and `bun run test:smoke:dist`. Earlier full gate also passed before the follow-ups: `bun run typecheck`, `bun run test:fast`, `bun run test:env`, docs/config checks, and dist smoke. - diff --git a/backlog/tasks/task-341 - Fix-frequency-highlight-for-honorific-prefix-noun-tokens.md b/backlog/tasks/task-341 - Fix-frequency-highlight-for-honorific-prefix-noun-tokens.md deleted file mode 100644 index e6362ade..00000000 --- a/backlog/tasks/task-341 - Fix-frequency-highlight-for-honorific-prefix-noun-tokens.md +++ /dev/null @@ -1,66 +0,0 @@ ---- -id: TASK-341 -title: Fix frequency highlight for honorific prefix noun tokens -status: Done -assignee: - - codex -created_date: '2026-05-05 02:08' -updated_date: '2026-05-05 02:10' -labels: - - bug - - tokenizer - - frequency -dependencies: [] -documentation: - - docs/architecture/2026-03-15-renderer-performance-design.md -priority: high ---- - -## Description - - -User reported subtitle token `ご機嫌` in `（フランク）ご機嫌が良くないようだな アンドリュー` shows Yomitan/JPDB rank 5484 in popup but is not highlighted as frequent. Frequency annotation currently excludes merged tokens containing default-excluded POS parts such as `接頭詞`; ordinal prefix-noun tokens already have an exception. Desired outcome: honorific prefix + noun lexical tokens like `ご機嫌` keep their valid frequency rank so renderer can apply frequent-token styling, while standalone prefixes and noisy merged grammar fragments remain excluded. - - -## Acceptance Criteria - -- [x] #1 `ご機嫌`-style honorific prefix + noun tokens retain a finite frequency rank after annotation/tokenization when frequency highlighting is enabled. -- [x] #2 Standalone prefix/noise tokens remain excluded from frequency annotation. -- [x] #3 Regression test covers the reported `ご機嫌` rank 5484 behavior. -- [x] #4 Relevant tokenizer/annotation tests pass. - - -## Implementation Plan - - -1. Add a failing regression around honorific prefix + noun token frequency retention, using `ご機嫌` with rank 5484 and POS `接頭詞|名詞` / `名詞接続|一般`. -2. Implement a narrow annotation-stage exception for lexical honorific prefix-noun tokens, adjacent to the existing ordinal prefix-noun allowance. -3. Verify standalone prefix/noise exclusion behavior remains covered. -4. Run targeted tokenizer/annotation tests and update acceptance criteria/final notes. - - -## Implementation Notes - - -TDD red verified: `bun test src/core/services/tokenizer.test.ts -t "honorific prefix-noun"` failed with `actual: undefined`, `expected: 5484` before implementation. - -Implemented a narrow honorific prefix-noun frequency allowance for merged `お`/`ご`/`御` + noun tokens with POS `接頭詞|名詞` and prefix POS2 `名詞接続`. Existing standalone prefix/noise exclusion tests still pass. - -Verification: `bun test src/core/services/tokenizer.test.ts src/core/services/tokenizer/annotation-stage.test.ts` passed (164 tests); `bun run typecheck` passed; `bunx prettier --check src/core/services/tokenizer/annotation-stage.ts src/core/services/tokenizer.test.ts` passed. Repo-wide `bun run format:check:src` still fails on pre-existing `src/core/services/stats-window.ts` formatting. - - -## Final Summary - - -Fixed frequency annotation for lexical honorific prefix-noun tokens such as `ご機嫌`. The annotation filter now allows merged `お`/`ご`/`御` prefix + noun tokens with MeCab POS `接頭詞|名詞` / `名詞接続|...` to retain a valid frequency rank, while standalone prefixes and existing noise filters remain excluded. - -Added a tokenizer regression for the reported `ご機嫌` case asserting rank `5484` is preserved after MeCab enrichment and annotation. - -Verification: -- `bun test src/core/services/tokenizer.test.ts -t "honorific prefix-noun"` failed before the fix with `undefined` vs `5484`, then passed after the fix. -- `bun test src/core/services/tokenizer.test.ts src/core/services/tokenizer/annotation-stage.test.ts` passed (164 tests). -- `bun run typecheck` passed. -- `bunx prettier --check src/core/services/tokenizer/annotation-stage.ts src/core/services/tokenizer.test.ts` passed. - -Note: repo-wide `bun run format:check:src` currently fails on unrelated existing formatting in `src/core/services/stats-window.ts`. - diff --git a/backlog/tasks/task-342 - Improve-docs-homepage-indexability.md b/backlog/tasks/task-342 - Improve-docs-homepage-indexability.md deleted file mode 100644 index 94ce1d0f..00000000 --- a/backlog/tasks/task-342 - Improve-docs-homepage-indexability.md +++ /dev/null @@ -1,54 +0,0 @@ ---- -id: TASK-342 -title: Improve docs homepage indexability -status: Done -assignee: - - codex -created_date: '2026-05-11 04:53' -updated_date: '2026-05-11 05:06' -labels: - - docs - - seo -dependencies: [] -references: - - 'https://docs.subminer.moe/' - - >- - https://developers.google.com/search/docs/crawling-indexing/consolidate-duplicate-urls -priority: medium ---- - -## Description - - -Google Search Console reports https://docs.subminer.moe/ as Crawled - currently not indexed. Investigate and improve the docs-site homepage and crawl signals so the root docs page has clear unique content, self-consistent canonical metadata, and no avoidable duplicate sitemap entry from VitePress README output. Keep the change scoped to docs-site SEO/content and verify with docs tests/build plus live-style generated HTML inspection. - - -## Acceptance Criteria - -- [x] #1 Generated docs HTML for https://docs.subminer.moe/ declares a self-referential canonical URL and does not declare noindex. -- [x] #2 Generated sitemap does not advertise a duplicate /README docs page when the docs homepage is the intended canonical root. -- [x] #3 Docs tests cover the SEO/indexing signals so canonical and duplicate sitemap regressions are caught. -- [x] #4 Docs build/test commands pass or any blocker is documented with exact failure output. - - -## Implementation Plan - - -1. Add failing docs-site tests for canonical head generation and sitemap duplicate filtering. 2. Update VitePress config to emit canonical URLs and exclude /README from the sitemap. 3. Strengthen docs homepage content with unique overview/decision-path copy. 4. Run docs tests/build and inspect generated HTML/sitemap. - - -## Implementation Notes - - -2026-05-11: Added docs SEO tests, root canonical generation, sitemap README filtering, and stronger docs homepage orientation copy. Verified generated index.html contains self canonical/no noindex and generated sitemap omits /README. - -2026-05-11: Added changes/342-docs-indexability.md and verified changelog lint. Final verification: bun run --cwd docs-site test, bun run docs:build, bun x prettier --check touched docs/changelog files, bun run changelog:lint. - -2026-05-11: User requested removal of the added homepage orientation block. Removed it, removed the matching content test, and updated the changelog fragment. Generated index.html no longer contains the removed headings while preserving canonical metadata. - - -## Final Summary - - -Improved docs homepage indexability signals for https://docs.subminer.moe/. Added self-referential canonical generation for VitePress pages and filtered the duplicate /README page out of the generated sitemap. Added docs SEO regression coverage, kept the existing Plausible hostname test aligned with the shared hostname constant, and added a docs changelog fragment. Per follow-up request, the extra homepage orientation copy was removed before handoff. Verification passed: docs tests, docs build, targeted generated HTML/sitemap inspection, Prettier check for touched files, and changelog lint. - diff --git a/backlog/tasks/task-343 - Fix-macOS-character-dictionary-selector-session-shortcut.md b/backlog/tasks/task-343 - Fix-macOS-character-dictionary-selector-session-shortcut.md deleted file mode 100644 index 31e32d86..00000000 --- a/backlog/tasks/task-343 - Fix-macOS-character-dictionary-selector-session-shortcut.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -id: TASK-343 -title: Fix macOS character dictionary selector session shortcut -status: Done -assignee: [] -created_date: '2026-05-11 08:05' -updated_date: '2026-05-11 08:06' -labels: - - bug - - macos - - character-dictionary - - plugin -dependencies: [] -modified_files: - - plugin/subminer/session_bindings.lua - - scripts/test-plugin-session-bindings.lua -priority: medium -ordinal: 181500 ---- - -## Description - - -Opening the character dictionary AniList selector from mpv/session shortcuts should work on macOS. Current generated session bindings include the openCharacterDictionary session action, but the Lua plugin CLI dispatch table does not map that action to the app flag, so the shortcut cannot reach the runtime selector. - - -## Acceptance Criteria - -- [x] #1 The openCharacterDictionary session action invokes the app with --open-character-dictionary from the mpv plugin. -- [x] #2 Regression coverage proves the Lua session-binding CLI map forwards openCharacterDictionary correctly. -- [x] #3 Existing session-binding regression coverage still passes. - - -## Implementation Notes - - -TDD red: `lua scripts/test-plugin-session-bindings.lua` failed because openCharacterDictionary did not emit --open-character-dictionary. Green after adding the missing Lua CLI mapping. - - -## Final Summary - - -Fixed the mpv plugin session action mapping so the character dictionary selector shortcut dispatches `--open-character-dictionary` to the app. Added Lua regression coverage for the macOS-style Alt+Meta+A binding and verified adjacent TypeScript session binding tests. - diff --git a/backlog/tasks/task-344 - Fix-macOS-overlay-tracker-hiding-while-mpv-remains-active.md b/backlog/tasks/task-344 - Fix-macOS-overlay-tracker-hiding-while-mpv-remains-active.md deleted file mode 100644 index 38cbc2e2..00000000 --- a/backlog/tasks/task-344 - Fix-macOS-overlay-tracker-hiding-while-mpv-remains-active.md +++ /dev/null @@ -1,74 +0,0 @@ ---- -id: TASK-344 -title: Fix macOS overlay tracker hiding while mpv remains active -status: Done -assignee: - - codex -created_date: '2026-05-11 08:27' -updated_date: '2026-05-11 08:41' -labels: - - bug - - macos - - overlay -dependencies: [] -references: - - src/main/runtime/overlay-visibility-runtime.ts - - src/window-trackers -modified_files: - - src/core/services/overlay-visibility.ts - - src/core/services/overlay-visibility.test.ts - - changes/344-macos-overlay-active-mpv.md -priority: high -ordinal: 182500 ---- - -## Description - - -macOS playback overlay should match Windows behavior: the tracker may only hide or alter overlay layering when mpv is no longer the active playback window. When mpv remains topmost or fullscreen, the visible overlay must stay present and interactive unless the user manually hides it or minimizes mpv. - - -## Acceptance Criteria - -- [x] #1 With mpv active on macOS, window-tracker updates do not hide the visible overlay or make it click-through. -- [x] #2 With mpv fullscreen on macOS, tracker geometry/layering refreshes preserve overlay interactivity. -- [x] #3 Overlay visibility still changes when mpv is no longer active, and manual hide/minimize behavior remains intact. -- [x] #4 A regression test covers the macOS active-mpv path that previously produced an overlay loading OSD and non-interactive overlay. - - -## Implementation Plan - - -1. Add a focused regression in `src/core/services/overlay-visibility.test.ts` for macOS with mpv tracked/focused and retained geometry: visibility refresh must not hide the overlay, must not emit loading OSD, and must leave the overlay interactive (`setIgnoreMouseEvents(false)`) unless forced passthrough is active. -2. Update `src/core/services/overlay-visibility.ts` so macOS tracker refreshes preserve the visible overlay while mpv is active/fullscreen, and only hide/re-layer for explicit manual hide, minimized/untracked target, or non-active mpv cases. -3. Run the focused overlay visibility tests, then a broader fast gate if the focused fix is green. - - -## Implementation Notes - - -Implemented in the shared overlay visibility service. macOS now keeps tracked/focused mpv overlays interactive instead of defaulting to mouse passthrough, and preserves an already visible active-mpv overlay during temporary tracker-not-ready refreshes without showing the loading OSD. Forced passthrough, modal hide, manual hide, Windows minimized handling, and initial macOS tracker-not-ready startup behavior remain covered by tests. - -Verification: `bun test src/core/services/overlay-visibility.test.ts` passed; affected overlay/mouse/runtime group passed; `bun run typecheck`, `bun run changelog:lint`, `bun run build`, `bun run test:env`, and `bun run test:smoke:dist` passed. `bun run test:fast` is blocked by existing cross-file test pollution: `src/core/services/subsync.test.ts` passes alone, but fails when run after `src/renderer/handlers/keyboard.test.ts` because `window.electronAPI` is undefined in a lingering keyboard handler; Bun then reports nested node:test errors for later files. `bun run format:check:src` is blocked by pre-existing formatting drift in `src/core/services/stats-window.ts`; touched files pass direct Prettier check. - - -## Final Summary - - -Summary: -- Updated macOS overlay visibility logic so a tracked/focused mpv window keeps the visible overlay interactive instead of click-through. -- Preserved an already visible active-mpv overlay during temporary macOS tracker-not-ready refreshes, avoiding the loading OSD/hide path for that active playback case. -- Added regression coverage for active mpv tracker refreshes and transient tracker-not-ready refreshes, plus updated old macOS expectations to the new active-mpv contract. -- Added a changelog fragment for the user-visible overlay fix. - -Verification: -- Passed: `bun test src/core/services/overlay-visibility.test.ts` -- Passed: `bun test src/core/services/overlay-visibility.test.ts src/core/services/overlay-runtime-init.test.ts src/core/services/overlay-shortcut-handler.test.ts src/renderer/handlers/mouse.test.ts` -- Passed: `bun run typecheck` -- Passed: `bun run changelog:lint` -- Passed: `bun run build` -- Passed: `bun run test:env` -- Passed: `bun run test:smoke:dist` -- Blocked: `bun run test:fast` by existing keyboard/subsync cross-file global pollution; isolated `bun test src/core/services/subsync.test.ts` passes. -- Blocked: `bun run format:check:src` by pre-existing formatting drift in `src/core/services/stats-window.ts`; touched files pass direct Prettier check. - diff --git a/backlog/tasks/task-345 - Address-PR-57-latest-CodeRabbit-review-comments.md b/backlog/tasks/task-345 - Address-PR-57-latest-CodeRabbit-review-comments.md deleted file mode 100644 index 8a479553..00000000 --- a/backlog/tasks/task-345 - Address-PR-57-latest-CodeRabbit-review-comments.md +++ /dev/null @@ -1,70 +0,0 @@ ---- -id: TASK-345 -title: Address PR 57 latest CodeRabbit review comments -status: Done -assignee: - - codex -created_date: '2026-05-12 06:35' -updated_date: '2026-05-12 06:38' -labels: - - pr-review - - coderabbit -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/57' -priority: medium ---- - -## Description - - -Assess the 2026-05-11 CodeRabbit review on PR #57 and address still-valid actionable comments with minimal changes. Current comments cover mpv subtitle playback unpause behavior, parser-selection empty reading handling, and overlay focus selector accessibility. - - -## Acceptance Criteria - -- [x] #1 Still-valid CodeRabbit comments from the latest PR #57 review are fixed or explicitly documented as skipped with rationale. -- [x] #2 Regression coverage is added for behavior-affecting fixes where practical before production code changes. -- [x] #3 Relevant targeted checks pass locally. - - -## Implementation Plan - - -1. Inspect current code and nearby tests for the three latest CodeRabbit comments on PR #57. -2. Add regression tests first for behavior-impacting findings: mpv playNextSubtitle unpauses when pause state is unknown, and parser selection preserves combined reading for empty segment readings. -3. Apply minimal production fixes plus the CSS :focus-visible selector change. -4. Run targeted test commands for touched areas and update task notes/final status. - - -## Implementation Notes - - -Added red tests for the two behavior comments. `bun test src/core/services/mpv.test.ts` fails because playNextSubtitle skips unpause when pause state is null. `bun test src/core/services/tokenizer/parser-selection-stage.test.ts` fails because empty grammar-ending reading clears preceding combined reading. - -Implemented all three latest CodeRabbit findings. Added regressions for mpv unknown pause state and parser-selection empty reading handling; changed overlay focus selectors to :focus-visible. Also fixed existing Prettier failure in src/core/services/stats-window.ts. Verification passed: targeted tests, typecheck, test:fast, test:env, format:check:src, build, test:smoke:dist, changelog:lint, changelog:pr-check. - - -## Final Summary - - -Addressed the latest CodeRabbit comments on PR #57. - -Changes: -- `playNextSubtitle` now sends `pause=false` unless mpv is explicitly known to be playing, covering startup/reconnect unknown pause state. -- Parser selection no longer slices combined readings for empty grammar-ending readings, preserving preceding token readings. -- Overlay focus suppression now targets `:focus-visible` selectors. -- Applied Prettier to `src/core/services/stats-window.ts` to clear the existing formatting gate failure. - -Verification: -- `bun test src/core/services/mpv.test.ts` -- `bun test src/core/services/tokenizer/parser-selection-stage.test.ts` -- `bun run typecheck` -- `bun run test:fast` -- `bun run test:env` -- `bun run format:check:src` -- `bun run build` -- `bun run test:smoke:dist` -- `bun run changelog:lint` -- `bun run changelog:pr-check` - diff --git a/backlog/tasks/task-346 - Fix-stats-session-detail-when-recent-media-is-missing.md b/backlog/tasks/task-346 - Fix-stats-session-detail-when-recent-media-is-missing.md deleted file mode 100644 index ce403790..00000000 --- a/backlog/tasks/task-346 - Fix-stats-session-detail-when-recent-media-is-missing.md +++ /dev/null @@ -1,57 +0,0 @@ ---- -id: TASK-346 -title: Fix stats session detail when recent media is missing -status: Done -assignee: - - Codex -created_date: '2026-05-12 06:41' -updated_date: '2026-05-12 06:44' -labels: - - bug - - stats -dependencies: [] -priority: high ---- - -## Description - - -Stats overview can show a completed session, but clicking it opens a detail view that says "Media not found". The details view should resolve the session/media consistently for recently completed local playback so users can inspect session cards, words, timeline, and media stats after a video finishes. - - -## Acceptance Criteria - -- [x] #1 A completed session listed on the stats overview opens a usable details view instead of "Media not found" when its media is still present in stats data. -- [x] #2 Regression coverage reproduces the overview-to-detail lookup mismatch and verifies the corrected behavior. -- [x] #3 Relevant stats/detail documentation is updated if behavior or APIs change. - - -## Implementation Plan - - -1. Add a focused regression test in `src/core/services/immersion-tracker/__tests__/query.test.ts` covering a video/session visible from session summaries before `imm_lifetime_media` exists. -2. Update `getMediaDetail` in `src/core/services/immersion-tracker/query-library.ts` so detail rows can resolve from `imm_videos` plus session metrics when lifetime summary is absent. -3. Run the focused query test lane and update task notes/acceptance criteria. - - -## Implementation Notes - - -Implemented root-cause fix in `getMediaDetail`: media detail now resolves from `imm_videos` plus session metrics when `imm_lifetime_media` is not populated yet, while still preferring lifetime summary totals when available. Added regression test for session-visible/media-detail-missing mismatch. No docs update required because the API shape is unchanged; added changelog fragment `changes/346-stats-session-detail.md`. Verification: `bun test src/core/services/immersion-tracker/__tests__/query.test.ts`, `bun run typecheck`, `bun run format:check:src`, `bun run test:fast`, `bun run changelog:lint`. - - -## Final Summary - - -Summary: -- Fixed stats media detail lookup so sessions visible in overview can open detail even before lifetime media summaries exist. -- Preserved lifetime-summary totals when available and added a regression test for the missing-lifetime case. -- Added `changes/346-stats-session-detail.md` for the user-visible fix. - -Tests: -- `bun test src/core/services/immersion-tracker/__tests__/query.test.ts` -- `bun run typecheck` -- `bun run format:check:src` -- `bun run test:fast` -- `bun run changelog:lint` - diff --git a/backlog/tasks/task-347 - Address-PR-57-CodeRabbit-review-round-after-stats-session-fix.md b/backlog/tasks/task-347 - Address-PR-57-CodeRabbit-review-round-after-stats-session-fix.md deleted file mode 100644 index f3e7d685..00000000 --- a/backlog/tasks/task-347 - Address-PR-57-CodeRabbit-review-round-after-stats-session-fix.md +++ /dev/null @@ -1,61 +0,0 @@ ---- -id: TASK-347 -title: Address PR 57 CodeRabbit review round after stats session fix -status: Done -assignee: - - codex -created_date: '2026-05-12 07:02' -updated_date: '2026-05-12 09:48' -labels: - - pr-review - - coderabbit - - ci -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/57' -modified_files: - - src/core/services/overlay-window-input.ts - - src/core/services/overlay-window.test.ts -priority: high ---- - -## Description - - -Assess and address the 2026-05-12 CodeRabbit review on PR #57 plus the current red GitHub Actions check. Latest comments cover stats session detail token aggregation, Linux fullscreen overlay refresh scheduling, Hyprland title-event polling, malformed Hyprland monitor JSON handling, and JLPT-lock test coverage for name matches. - - -## Acceptance Criteria - -- [x] #1 Still-valid latest CodeRabbit findings on PR #57 are fixed or documented as skipped with rationale. -- [x] #2 CI failure context is inspected and any repo-relevant failing tests or formatting issues are fixed. -- [x] #3 Regression coverage is added for behavior changes where practical before production edits. -- [x] #4 Relevant local verification passes. - - -## Implementation Plan - - -1. Inspect failing GitHub Actions log and current code around each latest CodeRabbit finding. -2. Add or update focused regression tests first for behavior changes: stats token aggregation, fullscreen refresh exit cancellation, Hyprland monitor parse failure, and title-only event filtering. -3. Apply minimal production fixes for still-valid findings, plus the subtitle-render duplicate test coverage item. -4. Run targeted tests first, then format/typecheck and broader relevant gates; update the task with results. - -Address latest CodeRabbit callback-scope finding: add regression coverage that macOS visible-overlay blur does not invoke onWindowsVisibleOverlayBlur, then split win32/darwin blur handling in src/core/services/overlay-window-input.ts. - - -## Implementation Notes - - -2026-05-12 09:47: Assessed latest PR #57 CodeRabbit comments via gh. Prior review findings in comments are marked addressed by CodeRabbit; latest still-actionable item was macOS visible-overlay blur invoking the Windows-only blur callback in overlay-window-input.ts. - -Added regression coverage showing macOS visible-overlay blur leaves onWindowsVisibleOverlayBlur inactive; test failed before production change and passed after splitting win32/darwin handling. - -Verification: bun test src/core/services/overlay-window.test.ts; bun run typecheck; git diff --check. PR checks: build-test-audit pass, GitGuardian pass, CodeRabbit pass/skipped, Claude skipped. - - -## Final Summary - - -Addressed the latest CodeRabbit callback-scope review on PR #57. Windows visible-overlay blur still invokes onWindowsVisibleOverlayBlur and returns without restacking; macOS visible-overlay blur now returns without restacking and without invoking the Windows-only callback. Added focused regression coverage and verified targeted tests, typecheck, diff whitespace, and current PR checks. - diff --git a/backlog/tasks/task-348 - Fix-PR-57-coverage-CI-focus-chrome-failure.md b/backlog/tasks/task-348 - Fix-PR-57-coverage-CI-focus-chrome-failure.md deleted file mode 100644 index 3b2d770c..00000000 --- a/backlog/tasks/task-348 - Fix-PR-57-coverage-CI-focus-chrome-failure.md +++ /dev/null @@ -1,56 +0,0 @@ ---- -id: TASK-348 -title: Fix PR 57 coverage CI focus chrome failure -status: Done -assignee: - - '@codex' -created_date: '2026-05-12 07:02' -updated_date: '2026-05-12 07:11' -labels: - - ci - - bug -dependencies: [] -references: - - 'https://github.com/ksyasuda/SubMiner/pull/57' - - 'https://github.com/ksyasuda/SubMiner/actions/runs/25718536412' -priority: high ---- - -## Description - - -Investigate and fix current GitHub Actions `build-test-audit` failure on PR #57 (`tokenizer-updates`). CI fails during `bun run test:coverage:src` in the maintained source lane: `renderer stylesheet hides focus chrome on top-level overlay focus targets`. - - -## Acceptance Criteria - -- [x] #1 Root cause of the focus chrome coverage failure is identified from CI/local test output. -- [x] #2 A focused fix is applied without broad unrelated changes. -- [x] #3 Relevant local coverage/test command passes. -- [x] #4 Remote PR check status is rechecked or next CI action is documented. - - -## Implementation Plan - - -1. Reproduce the CI failure locally with `bun test src/renderer/overlay-legacy-cleanup.test.ts`. -2. Update the stale legacy cleanup assertion to expect top-level `:focus-visible` suppression and reject broad `:focus` suppression. -3. Run the targeted test and `bun run test:coverage:src` to match CI's failing lane. -4. Recheck PR checks or document that CI needs a push/rerun. - - -## Implementation Notes - - -CI/local root cause: `src/renderer/style.css` was intentionally changed to `html/body/#overlay:focus-visible`, but `src/renderer/overlay-legacy-cleanup.test.ts` still required broad `:focus` selectors. The stale assertion fails in `test:coverage:src`. - -Additional coverage-lane failure after first fix: `src/main/runtime/linux-mpv-fullscreen-overlay-refresh.test.ts` imported `updateLinuxMpvFullscreenOverlayRefreshBurst`, but `src/main/runtime/linux-mpv-fullscreen-overlay-refresh.ts` did not export/implement it. Added the helper to cancel existing bursts and schedule only while fullscreen is true. - -Verification passed: `bun test src/renderer/overlay-legacy-cleanup.test.ts`; `bun test src/main/runtime/linux-mpv-fullscreen-overlay-refresh.test.ts`; `bun run test:coverage:src`; `bun run format:check:src`. `gh pr checks 57` still reports the old failed `build-test-audit` run at run 25718536412; branch needs push/rerun for remote green. - - -## Final Summary - - -Fixed current PR #57 `build-test-audit` CI blockers. Updated the stale overlay legacy cleanup assertion to expect `:focus-visible` top-level focus suppression and guard against reintroducing broad `:focus` suppression. Added the missing `updateLinuxMpvFullscreenOverlayRefreshBurst` export used by the Linux fullscreen overlay refresh tests. Verification passed locally: focused overlay legacy cleanup test, focused Linux fullscreen refresh test, `bun run test:coverage:src`, and `bun run format:check:src`. Remote PR checks still show the old failed `build-test-audit` run until these local changes are pushed and CI reruns. - diff --git a/backlog/tasks/task-349 - Fix-macOS-overlay-window-ordering-behind-foreground-apps.md b/backlog/tasks/task-349 - Fix-macOS-overlay-window-ordering-behind-foreground-apps.md deleted file mode 100644 index b6ad6cb4..00000000 --- a/backlog/tasks/task-349 - Fix-macOS-overlay-window-ordering-behind-foreground-apps.md +++ /dev/null @@ -1,74 +0,0 @@ ---- -id: TASK-349 -title: Fix macOS overlay window ordering behind foreground apps -status: Done -assignee: [] -created_date: '2026-05-12 08:50' -updated_date: '2026-05-12 08:58' -labels: - - bug - - macos - - overlay -dependencies: [] -references: - - src/core/services/overlay-visibility.ts - - src/window-trackers - - TASK-344 -modified_files: - - src/core/services/overlay-visibility.ts - - src/core/services/overlay-visibility.test.ts - - src/core/services/overlay-window-input.ts - - src/core/services/overlay-window.test.ts - - changes/349-macos-overlay-z-order.md -priority: high -ordinal: 183500 ---- - -## Description - - -macOS overlay should stay visually above mpv, but remain grouped with mpv in normal desktop stacking. When another app/window is brought in front of mpv, that window must also appear in front of the overlay, matching Windows behavior. This follows the earlier active-mpv fix that stopped the overlay from hiding while mpv remained foremost. - - -## Acceptance Criteria - -- [x] #1 When mpv is the foreground playback window on macOS, the overlay remains visible above mpv. -- [x] #2 When another application or window is brought in front of mpv on macOS, that foreground window appears above both mpv and the overlay. -- [x] #3 Restoring mpv to the foreground restores the overlay above mpv without requiring a restart. -- [x] #4 Regression coverage documents the macOS stacking relationship and does not regress the prior active-mpv overlay preservation behavior. - - -## Implementation Plan - - -1. Add focused regression coverage for macOS mpv focus loss: the overlay must release its topmost level, remain visible/click-through, and stop enforcing layer order while mpv is behind another window. -2. Add focused blur-handler coverage so the macOS visible overlay does not restack itself when it loses focus. -3. Update overlay visibility and blur handling to use tracker focus as the macOS stacking boundary: focused mpv raises overlay; unfocused mpv releases topmost and skips restack. -4. Run focused overlay tests, formatting, typecheck, changelog lint, env/build/smoke checks; document any blocked broad gate separately. - - -## Implementation Notes - - -Implemented macOS stacking boundary using tracker focus. When tracked mpv is unfocused and the overlay itself is not focused, the visible overlay now releases Electron always-on-top, remains visible/click-through, and skips layer-order enforcement. Visible overlay blur restacking is also skipped on macOS, matching the Windows no-restack path for focus loss. `test:fast` remains blocked by existing cross-file pollution: `keyboard.test.ts` leaves `window.electronAPI` undefined for a later `subsync.test.ts`, causing Bun nested `node:test` errors in subsequent files. - - -## Final Summary - - -Summary: -- Updated macOS overlay visibility so tracked mpv focus controls stacking: focused mpv keeps the overlay raised; unfocused mpv releases topmost while keeping the overlay visible and click-through. -- Stopped macOS visible overlay blur handling from immediately restacking the overlay above unrelated foreground windows. -- Added regression tests for macOS mpv focus loss and macOS blur restacking behavior. -- Added a changelog fragment for the user-visible overlay z-order fix. - -Verification: -- Passed: `bun test src/core/services/overlay-visibility.test.ts src/core/services/overlay-window.test.ts` -- Passed: `bunx prettier --check src/core/services/overlay-visibility.ts src/core/services/overlay-visibility.test.ts src/core/services/overlay-window-input.ts src/core/services/overlay-window.test.ts changes/349-macos-overlay-z-order.md` -- Passed: `bun run typecheck` -- Passed: `bun run changelog:lint` -- Passed: `bun run test:env` -- Passed: `bun run build` -- Passed: `bun run test:smoke:dist` -- Blocked: `bun run test:fast` by existing keyboard/subsync cross-file global pollution; focused and environment tests pass. - diff --git a/backlog/tasks/task-350 - Fix-known-highlighting-for-Yomitan-compound-tokens.md b/backlog/tasks/task-350 - Fix-known-highlighting-for-Yomitan-compound-tokens.md deleted file mode 100644 index 77ddb1d6..00000000 --- a/backlog/tasks/task-350 - Fix-known-highlighting-for-Yomitan-compound-tokens.md +++ /dev/null @@ -1,62 +0,0 @@ ---- -id: TASK-350 -title: Fix known highlighting for Yomitan compound tokens -status: Done -assignee: - - codex -created_date: '2026-05-12 09:08' -updated_date: '2026-05-12 09:29' -labels: - - bug - - tokenizer -dependencies: [] -modified_files: - - src/core/services/tokenizer/yomitan-parser-runtime.ts - - src/core/services/tokenizer/yomitan-parser-runtime.test.ts - - src/core/services/tokenizer.test.ts - - changes/350-known-yomitan-token-highlighting.md -priority: high -ordinal: 184500 ---- - -## Description - - -Subtitle known-word coloring should respect the lexical token selected by Yomitan. If Yomitan emits a compound or inflected expression as one token, SubMiner must not mark that displayed token known solely because MeCab/POS enrichment can decompose it into known component words. - - -## Acceptance Criteria - -- [x] #1 A Yomitan token such as `取り組んで` with headword `取り組む` remains not-known when only component words like `取る` or `組む` are known. -- [x] #2 Frequency/JLPT/POS enrichment still works for the selected Yomitan token without leaking component known-word status into `isKnown`. -- [x] #3 Regression coverage demonstrates the compound-token case and fails on current behavior before the fix. - - -## Implementation Plan - - -1. Add a regression in `src/core/services/tokenizer.test.ts` for a Yomitan-selected compound token: Yomitan emits `取り組んで` with headword `取り組む`; MeCab splits the same span into component tokens whose headwords include known component words such as `組む`; expected result is one displayed token with `isKnown === false` when only the components are known. -2. Verify the regression fails on current code. -3. Patch MeCab enrichment so it only contributes POS metadata used by annotation filters/exclusions. It must preserve the Yomitan token's `surface`, `headword`, `reading`, offsets, and existing lexical annotation state, especially `isKnown`. -4. Re-run the targeted tokenizer test, then a relevant fast test lane if practical. - -After inspecting code, MeCab enrichment currently only writes POS metadata. The observed component coloring can also come from SubMiner's custom Yomitan scanning path fragmenting a phrase differently than Yomitan's internal parser. Regression should exercise `requestYomitanScanTokens` fallback/parser behavior as seen by `tokenizeSubtitle`, and the fix should prefer Yomitan internal parse token identity while keeping MeCab limited to filtering/POS metadata. - - -## Implementation Notes - - -User clarified MeCab is intended only to help filter unwanted characters/particles/sound effects/etc., not to alter lexical tokenization or known-word decisions. - -Implementation settled on parse-first token identity: `requestYomitanScanTokens` now reads Yomitan internal parse tokens first. It still runs the scanner to keep scanner metadata when spans agree, but returns parse tokens when the scanner fragments the parse token. MeCab remains POS/filter enrichment only. - - -## Final Summary - - -Fixed known-word highlighting for Yomitan compound tokens by preferring Yomitan internal parse token spans over fragmented scanner output. When scanner output agrees with parse spans, scanner metadata such as name-match and word classes is preserved; when it fragments a Yomitan token, the parse token identity wins so known component words do not color the larger unknown token green. - -Added regressions for `取り組んで` with known component words (`取る`, `組む`, `もらう`) and for parser-runtime token selection/metadata behavior. Added a changelog fragment. - -Validation run: `bun test src/core/services/tokenizer.test.ts src/core/services/tokenizer/yomitan-parser-runtime.test.ts src/core/services/tokenizer/parser-selection-stage.test.ts src/core/services/tokenizer/parser-enrichment-stage.test.ts`; `bun run typecheck`; `bun x prettier --check src/core/services/tokenizer.test.ts src/core/services/tokenizer/yomitan-parser-runtime.ts src/core/services/tokenizer/yomitan-parser-runtime.test.ts changes/350-known-yomitan-token-highlighting.md`; `bun run changelog:lint`; `git diff --check`. - diff --git a/backlog/tasks/task-355 - Unify-AniList-API-throttling-across-dictionary-stats-and-tracking.md b/backlog/tasks/task-355 - Unify-AniList-API-throttling-across-dictionary-stats-and-tracking.md deleted file mode 100644 index 6359160a..00000000 --- a/backlog/tasks/task-355 - Unify-AniList-API-throttling-across-dictionary-stats-and-tracking.md +++ /dev/null @@ -1,38 +0,0 @@ ---- -id: TASK-355 -title: Unify AniList API throttling across dictionary stats and tracking -status: In Progress -assignee: [] -created_date: '2026-05-12 21:49' -updated_date: '2026-05-13 01:21' -labels: - - anilist - - rate-limit - - bug -dependencies: [] -references: - - 'https://docs.anilist.co/guide/rate-limiting' -priority: high ---- - -## Description - - -Audit and fix AniList GraphQL usage so character dictionary generation, stats search/cover art, and post-watch tracking share conservative request pacing and honor AniList rate-limit response headers. Current logs do not show 429s, but source has separate/unthrottled call paths and repeated dictionary lookup failures for the same title. - - -## Acceptance Criteria - -- [ ] #1 All AniList GraphQL call paths use a shared/conservative limiter or equivalent pacing before requests. -- [ ] #2 429 responses honor Retry-After/X-RateLimit-Reset and do not continue hammering the API. -- [x] #3 Stats AniList search endpoint no longer bypasses the AniList rate limiter. -- [x] #4 Post-watch tracking no longer bypasses the AniList rate limiter. -- [x] #5 Focused regression tests cover limiter use for stats search and post-watch tracking, plus existing limiter behavior remains green. -- [x] #6 Stats cover-art lookup reuses already stored AniList cover data for the same anime before issuing another AniList API request. - - -## Implementation Notes - - -Implemented stats cover-art cache reuse across videos in the same anime before any AniList/image fetch. Added limiter plumbing for stats manual AniList search and post-watch tracking; both paths now call acquire before GraphQL and record response headers afterward. Character dictionary still uses its existing local pacing and remains follow-up work for fully shared limiter/header handling. - diff --git a/backlog/tasks/task-356 - Close-launcher-started-background-app-when-mpv-exits.md b/backlog/tasks/task-356 - Close-launcher-started-background-app-when-mpv-exits.md deleted file mode 100644 index 1236adfe..00000000 --- a/backlog/tasks/task-356 - Close-launcher-started-background-app-when-mpv-exits.md +++ /dev/null @@ -1,58 +0,0 @@ ---- -id: TASK-356 -title: Close launcher-started background app when mpv exits -status: Done -assignee: - - codex -created_date: '2026-05-13 01:37' -updated_date: '2026-05-13 01:40' -labels: - - bug - - launcher - - mpv -dependencies: [] -priority: medium ---- - -## Description - - -When SubMiner is started through the launcher-managed mpv flow, closing the mpv window should also close the background Electron app instead of leaving it running in the tray. Preserve intentional tray/background behavior for normal app startup. - - -## Acceptance Criteria - -- [x] #1 Launcher-managed mpv sessions signal or otherwise cause the spawned background app to quit when the mpv process exits. -- [x] #2 Normal background/tray startup remains available when SubMiner is launched without a launcher-managed playback session. -- [x] #3 A regression test covers the launcher mpv close/shutdown behavior. - - -## Implementation Plan - - -1. Add a launcher command regression test for mpv plugin auto-start playback: no direct startOverlay call, mpv exits, launcher marks the session as managed and runs cleanup. -2. Add a small launcher mpv lifecycle helper to mark a SubMiner app session as launcher-managed when the launcher relies on plugin auto-start. -3. Wire playback-command to call that helper only for launcher-managed playback paths where mpv plugin auto-start is expected. -4. Run the focused launcher tests, then update TASK-356 acceptance criteria/notes. - - -## Implementation Notes - - -Implemented launcher ownership marking for plugin-auto-start playback sessions. Direct startOverlay already marks launcher ownership; the plugin-auto-start branch now does the same before waiting for mpv exit, so existing cleanup sends the app --stop when mpv closes. Added regression coverage in launcher/commands/playback-command.test.ts. Verification: bun test launcher/commands/playback-command.test.ts; bun test launcher/mpv.test.ts launcher/commands/playback-command.test.ts; bun run test:launcher:src; bun run typecheck. Typecheck initially caught a nullable test fixture assignment and passed after fixing it. - - -## Final Summary - - -Summary: -- Added markOverlayManagedByLauncher() to centralize launcher ownership tracking for SubMiner app sessions. -- Mark plugin-auto-start playback sessions as launcher-managed, so closing mpv triggers existing cleanup and stops the background app instead of leaving it in the tray. -- Added a regression test covering mpv exit after launcher-managed plugin auto-start playback. - -Tests: -- bun test launcher/commands/playback-command.test.ts -- bun test launcher/mpv.test.ts launcher/commands/playback-command.test.ts -- bun run test:launcher:src -- bun run typecheck - diff --git a/backlog/tasks/task-357 - Add-primary-subtitle-bar-visibility-modes.md b/backlog/tasks/task-357 - Add-primary-subtitle-bar-visibility-modes.md deleted file mode 100644 index b001e1f8..00000000 --- a/backlog/tasks/task-357 - Add-primary-subtitle-bar-visibility-modes.md +++ /dev/null @@ -1,70 +0,0 @@ ---- -id: TASK-357 -title: Add primary subtitle bar visibility modes -status: Done -assignee: - - Codex -created_date: '2026-05-13 03:17' -updated_date: '2026-05-13 03:24' -labels: - - overlay - - subtitles - - config -dependencies: [] -priority: medium ---- - -## Description - - -Update the primary subtitle bar visibility control so the `v` key cycles through the same mode model used by secondary subtitles: hidden, visible, and hover/auto. The primary and secondary subtitle bars must keep separate visibility state and config defaults, and primary visibility changes must identify the primary bar in OSD feedback. - - -## Acceptance Criteria - -- [x] #1 Pressing `v` cycles primary subtitle bar visibility through hidden, visible, and hover/auto without changing secondary subtitle visibility. -- [x] #2 In hover/auto mode, the primary subtitle bar is normally hidden but becomes visible and interactable when hovering over its reserved location. -- [x] #3 Primary and secondary subtitle visibility modes have independent runtime state and config defaults. -- [x] #4 `subtitleStyle` exposes a primary subtitle visibility default that defaults to visible and validates invalid values with a warning/fallback. -- [x] #5 OSD feedback is shown when primary visibility mode changes and clearly identifies the primary subtitle bar. -- [x] #6 Relevant tests and config example/docs are updated. - - -## Implementation Plan - - -1. Add failing tests for primary subtitle mode config default/validation and renderer `v` cycling/OSD behavior. -2. Add primary subtitle mode type/config default under `subtitleStyle`, parse it with warning fallback, include it in generated example config. -3. Carry primary mode in renderer state/startup/hot-reload payloads independently from secondary mode. -4. Replace primary boolean toggle with `hidden -> visible -> hover` cycle and OSD text `Primary subtitle: `. -5. Add primary hover CSS mirroring secondary hover behavior so hover mode reserves a hit area and becomes interactable on hover. -6. Run focused tests, then broader relevant checks if time/environment allows. - - -## Implementation Notes - - -Implemented primary subtitle visibility as independent `PrimarySubMode` (`hidden | visible | hover`) with renderer state, startup default from `subtitleStyle.primaryDefaultMode`, hot-reload payload propagation, and primary-specific OSD. Focused tests were added before implementation and all focused tests passed. Full relevant gate passed: `bun run typecheck`, `bun run test:config`, `bun run test:fast`, `bun run test:env`, `bun run build`, `bun run test:smoke:dist`, `bun run docs:test`, `bun run docs:build`, `bun run format:check:src`, and `bun run changelog:lint`. - - -## Final Summary - - -Summary: -- Added `subtitleStyle.primaryDefaultMode` with default `visible`, enum validation, generated config examples, and renderer/hot-reload payload wiring. -- Changed the primary subtitle bar `v` action from a boolean hide/show toggle to independent `hidden | visible | hover` mode cycling with OSD text that identifies the primary subtitle. -- Added hover-mode CSS so the primary bar stays invisible until its location is hovered, then becomes visible and interactable. - -Tests: -- `bun test src/config/resolve/subtitle-style.test.ts src/config/config.test.ts src/renderer/handlers/keyboard.test.ts src/renderer/subtitle-render.test.ts src/main/runtime/config-hot-reload-handlers.test.ts` -- `bun run typecheck` -- `bun run test:config` -- `bun run test:fast` -- `bun run test:env` -- `bun run build` -- `bun run test:smoke:dist` -- `bun run docs:test` -- `bun run docs:build` -- `bun run format:check:src` -- `bun run changelog:lint` - diff --git a/backlog/tasks/task-358 - Show-and-verify-default-keybindings-in-example-config.md b/backlog/tasks/task-358 - Show-and-verify-default-keybindings-in-example-config.md deleted file mode 100644 index 8a885cf3..00000000 --- a/backlog/tasks/task-358 - Show-and-verify-default-keybindings-in-example-config.md +++ /dev/null @@ -1,55 +0,0 @@ ---- -id: TASK-358 -title: Show and verify default keybindings in example config -status: Done -assignee: - - '@Codex' -created_date: '2026-05-13 03:33' -updated_date: '2026-05-13 03:45' -labels: - - config - - keybindings - - overlay - - mpv -dependencies: [] -priority: medium ---- - -## Description - - -Keep the shipped example configuration, overlay runtime, and mpv plugin aligned with the built-in default keybindings. The example `keybindings` array should show the same defaults that are active by default, and focused tests should catch drift between documented defaults and actual overlay/mpv wiring. - - -## Acceptance Criteria - -- [x] #1 `config.example.jsonc` and the docs-site copy show all default keybindings in the `keybindings` array. -- [x] #2 Default keybindings are registered without conflicts in the overlay session-binding path. -- [x] #3 Default keybindings are registered and dispatched correctly inside the mpv plugin. -- [x] #4 Focused regression tests cover default keybinding/config-example parity and mpv/plugin dispatch. - - -## Implementation Plan - - -1. Inspect default keybinding definitions, config-example generation, overlay shortcut/session-binding tests, and mpv plugin binding tests. -2. Add failing tests for config-example keybinding parity and any missing default overlay/mpv wiring. -3. Update generated/example config and source wiring only where tests show drift. -4. Run focused Bun/Lua tests, regenerate examples if needed, update task AC/final notes. - - -## Implementation Notes - - -Implemented the config-template path by injecting `DEFAULT_KEYBINDINGS` into generated examples when the resolved config has an empty `keybindings` array, preserving runtime merge semantics. Added coverage for template parity, default binding compile/action mapping, overlay keyboard dispatch, and mpv plugin registration/dispatch. Regenerated both `config.example.jsonc` artifacts and added changelog fragment `changes/358-default-keybindings-config-example.md`. - - -## Final Summary - - -Updated generated example configuration so `config.example.jsonc` and `docs-site/public/config.example.jsonc` now show every built-in default keybinding in the `keybindings` array instead of `[]`. The template copy now describes the array as default plus custom keybindings, while runtime default merge behavior remains unchanged. - -Added regression coverage that the generated template parses back to `DEFAULT_KEYBINDINGS`, that every default binding compiles to the expected mpv command or session action, that the overlay keyboard handler dispatches all compiled defaults, and that the mpv plugin registers and invokes default mpv/session-action bindings. Also updated docs tables to include the default fullscreen binding and clarified that keybindings can target mpv commands or SubMiner session actions. - -Verification passed: `bun run format:check:src`, `bun run changelog:lint`, `bun run docs:test`, `bun run docs:build`, `bun run verify:config-example`, focused config/session/renderer/plugin tests, `bun run typecheck`, `bun run test:env`, `bun run test:fast`, `bun run build`, and `bun run test:smoke:dist`. - diff --git a/backlog/tasks/task-359 - Update-default-startup-and-subtitle-style-options.md b/backlog/tasks/task-359 - Update-default-startup-and-subtitle-style-options.md deleted file mode 100644 index b4c57fbc..00000000 --- a/backlog/tasks/task-359 - Update-default-startup-and-subtitle-style-options.md +++ /dev/null @@ -1,68 +0,0 @@ ---- -id: TASK-359 -title: Update default startup and subtitle style options -status: Done -assignee: - - Codex -created_date: '2026-05-13 06:16' -updated_date: '2026-05-13 06:28' -labels: - - config -dependencies: [] -priority: medium ---- - -## Description - - -Change fresh-install defaults so texthooker and associated subtitle websocket servers are disabled unless explicitly enabled, Yomitan popup auto-pause remains enabled by default, and primary/secondary subtitle style defaults match the requested font, transparent background, and stronger shadow. Keep generated example config and docs aligned with resolved defaults. - - -## Acceptance Criteria - -- [x] #1 Fresh default config has texthooker startup disabled by default. -- [x] #2 Fresh default config disables associated subtitle websocket servers by default, or exposes/uses an existing config option that does so. -- [x] #3 Fresh default config keeps subtitleStyle.autoPauseVideoOnYomitanPopup enabled by default. -- [x] #4 Fresh default config uses fontFamily `Hiragino Sans, M PLUS 1, Source Han Sans JP, Noto Sans CJK JP` for primary subtitles. -- [x] #5 Fresh default config keeps secondary subtitle fontFamily as `Inter, Noto Sans, Helvetica Neue, sans-serif`. -- [x] #6 Fresh default config uses textShadow `0 2px 6px rgba(0,0,0,0.9), 0 0 12px rgba(0,0,0,0.55)` for primary and secondary subtitles. -- [x] #7 Fresh default config uses transparent subtitle backgrounds for primary and secondary subtitles. -- [x] #8 Tests and generated/docs config examples are updated for the new defaults. -- [x] #9 Fresh default config uses `#8bd5ca` for the fourth frequency band and JLPT N4 subtitle color. - - -## Implementation Plan - - -1. Update focused config tests first for the requested fresh-install defaults. -2. Change default config values in `src/config/definitions/defaults-core.ts` and `src/config/definitions/defaults-subtitle.ts`. -3. Regenerate generated config examples with the repo generator. -4. Update docs-site configuration prose/snippets for the new defaults. -5. Run focused config/example tests and mark acceptance criteria when verified. - -6. Include the requested JLPT N4 default color adjustment and verify the existing fourth frequency band default remains `#8bd5ca`. - -7. Restore the secondary subtitle font default to its previous `Inter, Noto Sans, Helvetica Neue, sans-serif` stack while keeping the new primary subtitle font default. - - -## Implementation Notes - - -Context: existing config already has websocket.enabled (`true | false | "auto"`) and annotationWebsocket.enabled (`boolean`), so disabling associated websockets can be handled by default changes instead of adding a new config surface. - -Scope update from user: also set JLPT N4 default color to `#8bd5ca`; fourth frequency band is already `#8bd5ca` in current defaults and has existing regression coverage. - -Verification: `bun run test:config`, `bun run docs:test`, `bun run docs:build`, `bun run changelog:lint`, `bun run format:check:src`, `bun run typecheck`, `bun run build`, `bun run test:smoke:dist`, and `git diff --check` passed. Earlier full fast/env suites also passed during this task (`bun run test:fast`, `bun run test:env`) before the final N4-only default tweak; focused config/docs/build/smoke checks were rerun after that tweak. - -Scope correction from user: secondary subtitles should keep the previous font stack. Interpreting the typo `snas-serif` as the previous literal default `sans-serif`. - -Correction verification: restored secondary subtitle default font to `Inter, Noto Sans, Helvetica Neue, sans-serif`. Passed `bun run test:config`, `bun run docs:test`, `bun run changelog:lint`, `bun run format:check:src`, `bun run typecheck`, and `git diff --check`. Verified generated examples and docs contain the restored secondary font. - - -## Final Summary - - -Updated fresh-install defaults so texthooker startup, the regular subtitle websocket, and the annotation websocket are disabled by default while preserving Yomitan popup auto-pause. Updated primary subtitle defaults to the requested Japanese font stack, kept secondary subtitle font at the prior `Inter, Noto Sans, Helvetica Neue, sans-serif` stack, and applied shared stronger text shadow, transparent backgrounds, and teal N4/fourth-band color. Regenerated config examples, updated docs-site configuration docs, and added a changelog fragment. - -Verification passed: `bun run test:config`, `bun run docs:test`, `bun run docs:build`, `bun run changelog:lint`, `bun run format:check:src`, `bun run typecheck`, `bun run build`, `bun run test:smoke:dist`, and `git diff --check`. After the secondary-font correction, reran `bun run test:config`, `bun run docs:test`, `bun run changelog:lint`, `bun run format:check:src`, `bun run typecheck`, and `git diff --check`. `bun run test:fast` and `bun run test:env` also passed during the task before the final small default corrections; affected focused checks were rerun afterward. - diff --git a/backlog/tasks/task-87 - Codebase-health-harden-verification-and-retire-dead-architecture-identified-in-the-March-2026-review.md b/backlog/tasks/task-87 - Codebase-health-harden-verification-and-retire-dead-architecture-identified-in-the-March-2026-review.md deleted file mode 100644 index 00cdcddf..00000000 --- a/backlog/tasks/task-87 - Codebase-health-harden-verification-and-retire-dead-architecture-identified-in-the-March-2026-review.md +++ /dev/null @@ -1,79 +0,0 @@ ---- -id: TASK-87 -title: >- - Codebase health: harden verification and retire dead architecture identified - in the March 2026 review -status: In Progress -assignee: [] -created_date: '2026-03-06 03:19' -updated_date: '2026-03-06 11:11' -labels: - - tech-debt - - tests - - maintainability -milestone: m-0 -dependencies: [] -references: - - package.json - - README.md - - src/main.ts - - src/anki-integration.ts - - src/core/services/immersion-tracker-service.test.ts -- src/translators/index.ts -- src/subsync/engines.ts -- src/subtitle/pipeline.ts - - backlog/tasks/task-87.5 - Dead-architecture-cleanup-delete-unused-registry-and-pipeline-modules-that-are-off-the-live-path.md -documentation: - - docs/reports/2026-02-22-task-100-dead-code-report.md -priority: high ---- - -## Description - - - -Track the remediation work from the March 6, 2026 code review. The review found that the default test gate only exercises 53 of 241 test files, the dedicated subtitle test lane is a no-op, SQLite-backed immersion tracking tests are conditionally skipped in the standard Bun run, src/main.ts still contains a large dead-symbol backlog, several registry/pipeline modules appear unreferenced from live execution paths, and src/anki-integration.ts remains an oversized orchestration file. This parent task should coordinate a safe sequence: improve verification first, then remove dead code and continue decomposition with good test coverage in place. - - - -## Acceptance Criteria - - - -- [ ] #1 Child tasks are created for each remediation workstream with explicit dependencies and enough context for an isolated agent to execute them. -- [ ] #2 The parent task records the recommended sequencing and parallelization strategy so replacement agents can resume without conversation history. -- [ ] #3 Completion of the parent task leaves the repository with a materially more trustworthy test gate, less dead architecture, and clearer ownership boundaries for the main runtime and Anki integration surfaces. - - -## Implementation Plan - - - -Recommended sequencing: - -1. Run TASK-87.1, TASK-87.2, TASK-87.3, and TASK-87.7 first. These are the safety-net and tooling tasks and can largely proceed in parallel. -2. Start TASK-87.4 once TASK-87.1 lands so src/main.ts cleanup happens under a more trustworthy test matrix. -3. Start TASK-87.5 after TASK-87.1 and TASK-87.2 so dead subsync/pipeline cleanup happens with stronger subtitle and runtime verification. -4. Start TASK-87.6 after TASK-87.1 so Anki refactors happen with broader default coverage in place. -5. Keep PRs focused: do not combine verification work with architectural cleanup unless a narrow dependency requires it. - -Parallelization guidance: - -- Wave 1 parallel: TASK-87.1, TASK-87.2, TASK-87.3, TASK-87.7 -- Wave 2 parallel: TASK-87.4, TASK-87.5, TASK-87.6 - -Shared review context to restate in child tasks: - -- Standard test scripts currently reference only 53 unique test files out of 241 discovered test and type-test files under src/ and launcher/. -- test:subtitle is currently a placeholder echo even though subtitle sync is a user-facing feature. -- SQLite-backed immersion tracker tests are conditionally skipped in the standard Bun run. -- src/main.ts trips many noUnusedLocals/noUnusedParameters diagnostics. -- src/translators/index.ts, src/subsync/engines.ts, src/subtitle/pipeline.ts, src/tokenizers/index.ts, and src/token-mergers/index.ts appeared unreferenced during review and must be re-verified before deletion. - - -## Progress Notes - -- `TASK-87.5` is complete. The isolated dead registry/pipeline modules were re-verified as off the maintained runtime path and removed. -- Live subtitle tokenization now owns the zero-width separator normalization that previously only existed in the dead subtitle pipeline path, so the cleanup did not drop that behavior. -- Verification completed for the cleanup slice with `bun test src/core/services/tokenizer.test.ts`, `bun test src/dead-architecture-cleanup.test.ts`, `bun test src/core/services/subsync.test.ts src/subsync/utils.test.ts`, `bun run tsc`, and `bun run test:src`. -- Remaining parent-task scope still includes the broader verification hardening, `src/main.ts` dead-symbol cleanup, and `src/anki-integration.ts` decomposition work tracked by the other child tasks. diff --git a/docs/workflow/agent-plugins.md b/docs/workflow/agent-plugins.md index 44d62385..fce290e3 100644 --- a/docs/workflow/agent-plugins.md +++ b/docs/workflow/agent-plugins.md @@ -21,11 +21,6 @@ Read when: packaging or migrating repo-local agent workflow skills into plugins - `.agents/skills/subminer-*` remain only as compatibility shims. - Existing script entrypoints under `.agents/skills/subminer-change-verification/scripts/` stay as wrappers so historical commands do not break. -## Backlog - -- Prefer Backlog.md MCP when the host session exposes it. -- If MCP is unavailable, use repo-local `backlog/` files and record that fallback. - ## Verification - For plugin/docs-only changes, start with `bun run test:docs:kb`. diff --git a/package.json b/package.json index ed8decf8..8079a196 100644 --- a/package.json +++ b/package.json @@ -195,7 +195,6 @@ "!stats/vite.config.ts", "!docs-site{,/**/*}", "!changes{,/**/*}", - "!backlog{,/**/*}", "!.tmp{,/**/*}", "!release-*{,/**/*}", "!dist/**/*.map", diff --git a/plugins/subminer-workflow/.codex-plugin/plugin.json b/plugins/subminer-workflow/.codex-plugin/plugin.json index 9b5db655..735be53f 100644 --- a/plugins/subminer-workflow/.codex-plugin/plugin.json +++ b/plugins/subminer-workflow/.codex-plugin/plugin.json @@ -1,7 +1,7 @@ { "name": "subminer-workflow", "version": "0.1.0", - "description": "Repo-local SubMiner agent workflow plugin for backlog-first orchestration and change verification.", + "description": "Repo-local SubMiner agent workflow plugin for orchestration and change verification.", "author": { "name": "Kyle Yasuda", "email": "suda@sudacode.com", @@ -10,11 +10,11 @@ "homepage": "https://github.com/sudacode/SubMiner/tree/main/plugins/subminer-workflow", "repository": "https://github.com/sudacode/SubMiner", "license": "GPL-3.0-or-later", - "keywords": ["subminer", "workflow", "backlog", "verification", "skills"], + "keywords": ["subminer", "workflow", "verification", "skills"], "skills": "./skills/", "interface": { "displayName": "SubMiner Workflow", - "shortDescription": "Backlog-first SubMiner orchestration and verification.", + "shortDescription": "SubMiner orchestration and verification.", "longDescription": "Canonical repo-local plugin for SubMiner agent workflow packaging. Owns the scrum-master and change-verification skills plus helper scripts used to plan, verify, and validate changes reproducibly inside this repo.", "developerName": "Kyle Yasuda", "category": "Productivity", @@ -23,7 +23,7 @@ "defaultPrompt": [ "Use SubMiner workflow to plan and ship a feature.", "Verify a SubMiner change with the plugin-owned verifier.", - "Run backlog-first intake for this SubMiner task." + "Plan and ship this SubMiner task." ], "brandColor": "#2F6B4F" } diff --git a/plugins/subminer-workflow/README.md b/plugins/subminer-workflow/README.md index 5eea07f1..09c07273 100644 --- a/plugins/subminer-workflow/README.md +++ b/plugins/subminer-workflow/README.md @@ -12,23 +12,15 @@ This plugin is the canonical source of truth for the SubMiner agent workflow pac ## Contents - `skills/subminer-scrum-master/` - - backlog-first intake, planning, dispatch, and handoff workflow + - intake, planning, dispatch, and handoff workflow - `skills/subminer-change-verification/` - cheap-first verification workflow plus helper scripts -## Backlog MCP - -- This plugin assumes Backlog.md MCP is available in the host environment when the client exposes it. -- Canonical backlog behavior remains: - - read `backlog://workflow/overview` when resources are available - - otherwise use the matching backlog tool overview -- If backlog MCP is unavailable in the current session, fall back to direct repo-local `backlog/` edits and record that blocker in the task or handoff. - ## Compatibility - `.agents/skills/subminer-scrum-master/` is a compatibility shim that redirects to the plugin-owned skill. - `.agents/skills/subminer-change-verification/` is a compatibility shim. -- `.agents/skills/subminer-change-verification/scripts/*.sh` remain as wrapper entrypoints so existing docs, backlog tasks, and shell history keep working. +- `.agents/skills/subminer-change-verification/scripts/*.sh` remain as wrapper entrypoints so existing docs and shell history keep working. ## Verification @@ -44,6 +36,5 @@ bash plugins/subminer-workflow/skills/subminer-change-verification/scripts/verif .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh \ .agents/plugins/marketplace.json \ docs/workflow/README.md \ - docs/workflow/agent-plugins.md \ - backlog/tasks/task-240\ -\ Migrate-SubMiner-agent-skills-into-a-repo-local-plugin-workflow.md + docs/workflow/agent-plugins.md ``` diff --git a/plugins/subminer-workflow/skills/subminer-scrum-master/SKILL.md b/plugins/subminer-workflow/skills/subminer-scrum-master/SKILL.md index 7e76e421..0695c6a0 100644 --- a/plugins/subminer-workflow/skills/subminer-scrum-master/SKILL.md +++ b/plugins/subminer-workflow/skills/subminer-scrum-master/SKILL.md @@ -1,6 +1,6 @@ --- name: 'subminer-scrum-master' -description: 'Use in the SubMiner repo when a request should be turned into planned work and driven through execution. Assesses whether backlog tracking is warranted, creates or updates tasks when needed, records a plan, dispatches one or more subagents, and requires verification before handoff.' +description: 'Use in the SubMiner repo when a request should be turned into planned work and driven through execution. Records a plan, dispatches one or more subagents when useful, and requires verification before handoff.' --- # SubMiner Scrum Master @@ -9,67 +9,27 @@ Canonical source: this plugin path. Own workflow, not code by default. -Use this skill when the user gives a feature request, bug report, issue, refactor, or implementation ask and the agent should manage intake, planning, backlog hygiene, worker dispatch, and verification through completion. +Use this skill when the user gives a feature request, bug report, issue, refactor, or implementation ask and the agent should manage intake, planning, worker dispatch, and verification through completion. ## Core Rules -1. Decide first whether backlog tracking is warranted. -2. If backlog is needed, search first. Update existing work when it clearly matches. -3. If backlog is not needed, keep the process light. Do not invent ticket ceremony. -4. Record a plan before dispatching coding work. -5. Use parent + subtasks for multi-part work when backlog is used. -6. Dispatch conservatively. Parallelize only disjoint write scopes. -7. Require verification before handoff, typically via `subminer-change-verification`. -8. Report backlog actions, dispatched workers, verification, blockers, and remaining risks. - -## Backlog Workflow - -Preferred order: - -1. Read `backlog://workflow/overview` when MCP resources are available. -2. If resources are unavailable, use the corresponding backlog tool overview. -3. If backlog MCP is unavailable in the session, work directly in repo-local `backlog/` files and record that constraint explicitly. - -## Backlog Decision - -Skip backlog when the request is: - -- question only -- obvious mechanical edit -- tiny isolated change with no real planning - -Use backlog when the work: - -- needs planning or scope decisions -- spans multiple phases or subsystems -- is likely to need subagent dispatch -- should remain traceable for handoff/resume - -If backlog is used: - -- search existing tasks first -- create/update a standalone task for one focused deliverable -- create/update a parent task plus subtasks for multi-part work -- record the implementation plan in the task before implementation begins +1. Keep the process light for questions, obvious mechanical edits, and tiny isolated changes. +2. Record a plan before dispatching coding work. +3. Split multi-part work into clear phases and ownership areas. +4. Dispatch conservatively. Parallelize only disjoint write scopes. +5. Require verification before handoff, typically via `subminer-change-verification`. +6. Report dispatched workers, verification, blockers, and remaining risks. ## Intake Workflow 1. Parse the request. Classify it as question, mechanical edit, bugfix, feature, refactor, investigation, or follow-up. -2. Decide whether backlog is needed. -3. If backlog is needed: - - search first - - update existing task if clearly relevant - - otherwise create the right structure - - write the implementation plan before dispatch -4. If backlog is skipped: - - write a short working plan in-thread - - proceed without fake ticketing -5. Choose execution mode: +2. Write a short working plan in-thread when the work is nontrivial. +3. Choose execution mode: - no subagents for trivial work - one worker for focused work - parallel workers only for disjoint scopes -6. Run verification before handoff. +4. Run verification before handoff. ## Dispatch Rules @@ -118,42 +78,38 @@ Rules: - If verification fails, either: - send the worker back with exact failure context, or - fix it directly if it is tiny and clearly in scope -- If new scope appears, revisit backlog structure before silently expanding work. +- If new scope appears, pause and re-plan before silently expanding work. ## Representative Flows -### Trivial no-ticket work +### Trivial work -- decide backlog is unnecessary - keep a short plan - implement directly or with one worker if helpful - run targeted verification - report outcome concisely -### Single-task implementation +### Focused implementation -- search/create/update one task - record plan - dispatch one worker - integrate - verify -- update task and report outcome +- report outcome -### Parent + subtasks execution +### Multi-part execution -- search/create/update parent task -- create subtasks for distinct deliverables/phases +- define distinct deliverables/phases - record sequencing in the plan - dispatch workers only where scopes are disjoint - integrate - run consolidated verification -- update task state and report outcome +- report outcome ## Output Expectations At the end, report: -- whether backlog was used and what changed - which workers were dispatched and what they owned - what verification ran - explicit answers to: diff --git a/scripts/build-changelog.ts b/scripts/build-changelog.ts index bc329e97..352dce4d 100644 --- a/scripts/build-changelog.ts +++ b/scripts/build-changelog.ts @@ -613,8 +613,7 @@ function isIgnoredPullRequestPath(candidate: string): boolean { candidate === 'README.md' || candidate.startsWith('changes/') || candidate.startsWith('docs/') || - candidate.startsWith('.github/') || - candidate.startsWith('backlog/') + candidate.startsWith('.github/') ); }