feat(config): add configuration window (#70)

src/cli/args.test.ts

@@ -7,7 +7,7 @@ import {
   isHeadlessInitialCommand,
   isStandaloneTexthookerCommand,
   parseArgs,
-  shouldRunSettingsOnlyStartup,
+  shouldRunYomitanOnlyStartup,
   shouldStartApp,
 } from './args';
 
@@ -66,7 +66,7 @@ test('parseArgs captures update command and internal launcher paths', () => {
   assert.equal(hasExplicitCommand(args), true);
   assert.equal(shouldStartApp(args), true);
   assert.equal(commandNeedsOverlayRuntime(args), false);
-  assert.equal(shouldRunSettingsOnlyStartup(args), false);
+  assert.equal(shouldRunYomitanOnlyStartup(args), false);
 });
 
 test('parseArgs captures launch-mpv targets and keeps it out of app startup', () => {
@@ -94,6 +94,7 @@ test('parseArgs captures youtube startup forwarding flags', () => {
 test('parseArgs captures session action forwarding flags', () => {
   const args = parseArgs([
     '--toggle-stats-overlay',
+    '--mark-watched',
     '--open-jimaku',
     '--open-youtube-picker',
     '--open-playlist-browser',
@@ -110,6 +111,7 @@ test('parseArgs captures session action forwarding flags', () => {
   ]);
 
   assert.equal(args.toggleStatsOverlay, true);
+  assert.equal(args.markWatched, true);
   assert.equal(args.openJimaku, true);
   assert.equal(args.openYoutubePicker, true);
   assert.equal(args.openPlaylistBrowser, true);
@@ -206,35 +208,38 @@ test('hasExplicitCommand and shouldStartApp preserve command intent', () => {
   assert.equal(shouldStartApp(update), true);
   assert.equal(isHeadlessInitialCommand(update), true);
 
+  const yomitan = parseArgs(['--yomitan']);
+  assert.equal(yomitan.yomitan, true);
+  assert.equal(hasExplicitCommand(yomitan), true);
+  assert.equal(shouldStartApp(yomitan), true);
+  assert.equal(shouldRunYomitanOnlyStartup(yomitan), true);
+
   const settings = parseArgs(['--settings']);
   assert.equal(settings.settings, true);
   assert.equal(hasExplicitCommand(settings), true);
   assert.equal(shouldStartApp(settings), true);
-  assert.equal(shouldRunSettingsOnlyStartup(settings), true);
+  assert.equal(shouldRunYomitanOnlyStartup(settings), false);
+  assert.equal(commandNeedsOverlayRuntime(settings), false);
+  assert.equal(commandNeedsOverlayStartupPrereqs(settings), false);
 
-  const configSettings = parseArgs(['--config']);
-  assert.equal(configSettings.configSettings, true);
-  assert.equal(hasExplicitCommand(configSettings), true);
-  assert.equal(shouldStartApp(configSettings), true);
-  assert.equal(shouldRunSettingsOnlyStartup(configSettings), false);
-  assert.equal(commandNeedsOverlayRuntime(configSettings), false);
-  assert.equal(commandNeedsOverlayStartupPrereqs(configSettings), false);
+  const yomitanWithOverlay = parseArgs(['--yomitan', '--toggle-visible-overlay']);
+  assert.equal(yomitanWithOverlay.yomitan, true);
+  assert.equal(yomitanWithOverlay.toggleVisibleOverlay, true);
+  assert.equal(shouldRunYomitanOnlyStartup(yomitanWithOverlay), false);
 
-  const settingsWithOverlay = parseArgs(['--settings', '--toggle-visible-overlay']);
-  assert.equal(settingsWithOverlay.settings, true);
-  assert.equal(settingsWithOverlay.toggleVisibleOverlay, true);
-  assert.equal(shouldRunSettingsOnlyStartup(settingsWithOverlay), false);
-
-  const yomitanAlias = parseArgs(['--yomitan']);
-  assert.equal(yomitanAlias.settings, true);
-  assert.equal(hasExplicitCommand(yomitanAlias), true);
-  assert.equal(shouldStartApp(yomitanAlias), true);
+  const settingsDoesNotEnableYomitan = parseArgs(['--settings']);
+  assert.equal(settingsDoesNotEnableYomitan.yomitan, false);
 
   const help = parseArgs(['--help']);
   assert.equal(help.help, true);
   assert.equal(hasExplicitCommand(help), true);
   assert.equal(shouldStartApp(help), false);
-  assert.equal(shouldRunSettingsOnlyStartup(help), false);
+  assert.equal(shouldRunYomitanOnlyStartup(help), false);
+
+  const appPing = parseArgs(['--app-ping']);
+  assert.equal(appPing.appPing, true);
+  assert.equal(hasExplicitCommand(appPing), true);
+  assert.equal(shouldStartApp(appPing), false);
 
   const youtubePlay = parseArgs(['--youtube-play', 'https://youtube.com/watch?v=abc']);
   assert.equal(commandNeedsOverlayStartupPrereqs(youtubePlay), true);
@@ -280,6 +285,12 @@ test('hasExplicitCommand and shouldStartApp preserve command intent', () => {
   const toggleStatsOverlayRuntime = parseArgs(['--toggle-stats-overlay']);
   assert.equal(commandNeedsOverlayRuntime(toggleStatsOverlayRuntime), true);
 
+  const markWatched = parseArgs(['--mark-watched']);
+  assert.equal(markWatched.markWatched, true);
+  assert.equal(hasExplicitCommand(markWatched), true);
+  assert.equal(shouldStartApp(markWatched), true);
+  assert.equal(commandNeedsOverlayRuntime(markWatched), true);
+
   const dictionary = parseArgs(['--dictionary']);
   assert.equal(dictionary.dictionary, true);
   assert.equal(hasExplicitCommand(dictionary), true);

src/cli/args.ts

@@ -10,8 +10,8 @@ export interface CliArgs {
   toggle: boolean;
   toggleVisibleOverlay: boolean;
   togglePrimarySubtitleBar: boolean;
+  yomitan: boolean;
   settings: boolean;
-  configSettings: boolean;
   setup: boolean;
   show: boolean;
   hide: boolean;
@@ -28,6 +28,7 @@ export interface CliArgs {
   triggerSubsync: boolean;
   markAudioCard: boolean;
   toggleStatsOverlay: boolean;
+  markWatched: boolean;
   toggleSubtitleSidebar: boolean;
   openRuntimeOptions: boolean;
   openSessionHelp: boolean;
@@ -74,6 +75,7 @@ export interface CliArgs {
   texthooker: boolean;
   texthookerOpenBrowser: boolean;
   help: boolean;
+  appPing?: boolean;
   update?: boolean;
   updateLauncherPath?: string;
   updateResponsePath?: string;
@@ -115,8 +117,8 @@ export function parseArgs(argv: string[]): CliArgs {
     toggle: false,
     toggleVisibleOverlay: false,
     togglePrimarySubtitleBar: false,
+    yomitan: false,
     settings: false,
-    configSettings: false,
     setup: false,
     show: false,
     hide: false,
@@ -133,6 +135,7 @@ export function parseArgs(argv: string[]): CliArgs {
     triggerSubsync: false,
     markAudioCard: false,
     toggleStatsOverlay: false,
+    markWatched: false,
     toggleSubtitleSidebar: false,
     openRuntimeOptions: false,
     openSessionHelp: false,
@@ -172,6 +175,7 @@ export function parseArgs(argv: string[]): CliArgs {
     texthooker: false,
     texthookerOpenBrowser: false,
     help: false,
+    appPing: false,
     update: false,
     updateLauncherPath: undefined,
     updateResponsePath: undefined,
@@ -235,8 +239,8 @@ export function parseArgs(argv: string[]): CliArgs {
     else if (arg === '--toggle') args.toggle = true;
     else if (arg === '--toggle-visible-overlay') args.toggleVisibleOverlay = true;
     else if (arg === '--toggle-primary-subtitle-bar') args.togglePrimarySubtitleBar = true;
-    else if (arg === '--settings' || arg === '--yomitan') args.settings = true;
-    else if (arg === '--config') args.configSettings = true;
+    else if (arg === '--yomitan') args.yomitan = true;
+    else if (arg === '--settings') args.settings = true;
     else if (arg === '--setup') args.setup = true;
     else if (arg === '--show') args.show = true;
     else if (arg === '--hide') args.hide = true;
@@ -253,6 +257,7 @@ export function parseArgs(argv: string[]): CliArgs {
     else if (arg === '--trigger-subsync') args.triggerSubsync = true;
     else if (arg === '--mark-audio-card') args.markAudioCard = true;
     else if (arg === '--toggle-stats-overlay') args.toggleStatsOverlay = true;
+    else if (arg === '--mark-watched') args.markWatched = true;
     else if (arg === '--toggle-subtitle-sidebar') args.toggleSubtitleSidebar = true;
     else if (arg === '--open-runtime-options') args.openRuntimeOptions = true;
     else if (arg === '--open-session-help') args.openSessionHelp = true;
@@ -339,6 +344,7 @@ export function parseArgs(argv: string[]): CliArgs {
     else if (arg === '--jellyfin-preview-auth') args.jellyfinPreviewAuth = true;
     else if (arg === '--texthooker') args.texthooker = true;
     else if (arg === '--open-browser') args.texthookerOpenBrowser = true;
+    else if (arg === '--app-ping') args.appPing = true;
     else if (arg === '--update') args.update = true;
     else if (arg.startsWith('--update-launcher-path=')) {
       const value = arg.split('=', 2)[1];
@@ -488,8 +494,8 @@ export function hasExplicitCommand(args: CliArgs): boolean {
     args.toggle ||
     args.toggleVisibleOverlay ||
     args.togglePrimarySubtitleBar ||
+    args.yomitan ||
     args.settings ||
-    args.configSettings ||
     args.setup ||
     args.show ||
     args.hide ||
@@ -506,6 +512,7 @@ export function hasExplicitCommand(args: CliArgs): boolean {
     args.triggerSubsync ||
     args.markAudioCard ||
     args.toggleStatsOverlay ||
+    args.markWatched ||
     args.toggleSubtitleSidebar ||
     args.openRuntimeOptions ||
     args.openSessionHelp ||
@@ -540,6 +547,7 @@ export function hasExplicitCommand(args: CliArgs): boolean {
     args.jellyfinRemoteAnnounce ||
     args.jellyfinPreviewAuth ||
     args.texthooker ||
+    args.appPing ||
     args.update ||
     args.generateConfig ||
     args.help
@@ -561,8 +569,8 @@ export function isStandaloneTexthookerCommand(args: CliArgs): boolean {
     !args.toggle &&
     !args.toggleVisibleOverlay &&
     !args.togglePrimarySubtitleBar &&
+    !args.yomitan &&
     !args.settings &&
-    !args.configSettings &&
     !args.setup &&
     !args.show &&
     !args.hide &&
@@ -579,6 +587,7 @@ export function isStandaloneTexthookerCommand(args: CliArgs): boolean {
     !args.triggerSubsync &&
     !args.markAudioCard &&
     !args.toggleStatsOverlay &&
+    !args.markWatched &&
     !args.toggleSubtitleSidebar &&
     !args.openRuntimeOptions &&
     !args.openSessionHelp &&
@@ -612,6 +621,7 @@ export function isStandaloneTexthookerCommand(args: CliArgs): boolean {
     !args.jellyfinPlay &&
     !args.jellyfinRemoteAnnounce &&
     !args.jellyfinPreviewAuth &&
+    !args.appPing &&
     !args.update &&
     !args.help &&
     !args.autoStartOverlay &&
@@ -629,8 +639,8 @@ export function shouldStartApp(args: CliArgs): boolean {
     args.toggle ||
     args.toggleVisibleOverlay ||
     args.togglePrimarySubtitleBar ||
+    args.yomitan ||
     args.settings ||
-    args.configSettings ||
     args.setup ||
     args.copySubtitle ||
     args.copySubtitleMultiple ||
@@ -643,6 +653,7 @@ export function shouldStartApp(args: CliArgs): boolean {
     args.triggerSubsync ||
     args.markAudioCard ||
     args.toggleStatsOverlay ||
+    args.markWatched ||
     args.toggleSubtitleSidebar ||
     args.openRuntimeOptions ||
     args.openSessionHelp ||
@@ -676,16 +687,16 @@ export function shouldStartApp(args: CliArgs): boolean {
   return false;
 }
 
-export function shouldRunSettingsOnlyStartup(args: CliArgs): boolean {
+export function shouldRunYomitanOnlyStartup(args: CliArgs): boolean {
   return (
-    args.settings &&
+    args.yomitan &&
     !args.background &&
     !args.start &&
     !args.stop &&
     !args.toggle &&
     !args.toggleVisibleOverlay &&
     !args.togglePrimarySubtitleBar &&
-    !args.configSettings &&
+    !args.settings &&
     !args.show &&
     !args.hide &&
     !args.setup &&
@@ -702,6 +713,7 @@ export function shouldRunSettingsOnlyStartup(args: CliArgs): boolean {
     !args.triggerSubsync &&
     !args.markAudioCard &&
     !args.toggleStatsOverlay &&
+    !args.markWatched &&
     !args.toggleSubtitleSidebar &&
     !args.openRuntimeOptions &&
     !args.openSessionHelp &&
@@ -737,6 +749,7 @@ export function shouldRunSettingsOnlyStartup(args: CliArgs): boolean {
     !args.jellyfinRemoteAnnounce &&
     !args.jellyfinPreviewAuth &&
     !args.texthooker &&
+    !args.appPing &&
     !args.update &&
     !args.help &&
     !args.autoStartOverlay &&
@@ -762,6 +775,7 @@ export function commandNeedsOverlayRuntime(args: CliArgs): boolean {
     args.updateLastCardFromClipboard ||
     args.toggleSecondarySub ||
     args.toggleStatsOverlay ||
+    args.markWatched ||
     args.toggleSubtitleSidebar ||
     args.triggerFieldGrouping ||
     args.triggerSubsync ||

src/cli/help.test.ts

@@ -22,7 +22,9 @@ test('printHelp includes configured texthooker port', () => {
   assert.match(output, /--open-browser\s+Open texthooker in your default browser/);
   assert.doesNotMatch(output, /--refresh-known-words/);
   assert.match(output, /--setup\s+Open first-run setup window/);
-  assert.match(output, /--config\s+Open configuration window/);
+  assert.match(output, /--settings\s+Open SubMiner settings window/);
+  assert.match(output, /--yomitan\s+Open Yomitan settings window/);
+  assert.match(output, /--mark-watched\s+Mark current video watched and advance playlist/);
   assert.match(output, /--anilist-status/);
   assert.match(output, /--anilist-retry-queue/);
   assert.match(output, /--dictionary/);

src/cli/help.ts

@@ -24,8 +24,8 @@ ${B}Overlay${R}
   --toggle-primary-subtitle-bar  Toggle primary subtitle bar
   --show-visible-overlay         Show subtitle overlay
   --hide-visible-overlay         Hide subtitle overlay
-  --settings                     Open Yomitan settings window
-  --config                       Open configuration window
+  --yomitan                      Open Yomitan settings window
+  --settings                     Open SubMiner settings window
   --setup                        Open first-run setup window
   --auto-start-overlay           Auto-hide mpv subs, show overlay on connect
 
@@ -39,6 +39,7 @@ ${B}Mining${R}
   --trigger-field-grouping       Run Kiku field grouping
   --trigger-subsync              Run subtitle sync
   --toggle-secondary-sub         Cycle secondary subtitle mode
+  --mark-watched                 Mark current video watched and advance playlist
   --toggle-subtitle-sidebar      Toggle subtitle sidebar panel
   --open-runtime-options         Open runtime options palette
   --open-session-help            Open session help modal