fix: address CodeRabbit review feedback

This commit is contained in:
2026-03-22 19:37:49 -07:00
parent 8da3a26855
commit d65575c80d
33 changed files with 678 additions and 67 deletions

View File

@@ -17,6 +17,7 @@
*/
import type { SubtitleCue } from './core/services/subtitle-cue-parser';
import type { YoutubeTrackKind } from './core/services/youtube/kinds';
export enum PartOfSpeech {
noun = 'noun',
@@ -561,7 +562,7 @@ export interface ControllerRuntimeSnapshot {
export type JimakuLanguagePreference = 'ja' | 'en' | 'none';
export type YoutubeFlowMode = 'download' | 'generate';
export type YoutubeTrackKind = 'manual' | 'auto';
export type { YoutubeTrackKind };
export interface YoutubeTrackOption {
id: string;
@@ -584,12 +585,19 @@ export interface YoutubePickerOpenPayload {
hasTracks: boolean;
}
export interface YoutubePickerResolveRequest {
sessionId: string;
action: 'use-selected' | 'continue-without-subtitles';
primaryTrackId: string | null;
secondaryTrackId: string | null;
}
export type YoutubePickerResolveRequest =
| {
sessionId: string;
action: 'continue-without-subtitles';
primaryTrackId: null;
secondaryTrackId: null;
}
| {
sessionId: string;
action: 'use-selected';
primaryTrackId: string | null;
secondaryTrackId: string | null;
};
export interface YoutubePickerResolveResult {
ok: boolean;