sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-03-25 00:11:26 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: address CodeRabbit review feedback

Browse Source
This commit is contained in:
Kyle Yasuda
2026-03-22 19:37:49 -07:00
parent 8da3a26855
commit d65575c80d
33 changed files with 678 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/renderer/modals/youtube-track-picker.ts
View File

@@ -114,13 +114,26 @@ export function createYoutubeTrackPickerModal(
return;
}
const response = await window.electronAPI.youtubePickerResolve({
sessionId: payload.sessionId,
action,
primaryTrackId: action === 'use-selected' ? ctx.dom.youtubePickerPrimarySelect.value || null : null,
secondaryTrackId:
action === 'use-selected' ? ctx.dom.youtubePickerSecondarySelect.value || null : null,
});
let response;
try {
response =
action === 'use-selected'
? await window.electronAPI.youtubePickerResolve({
sessionId: payload.sessionId,
action: 'use-selected',
primaryTrackId: ctx.dom.youtubePickerPrimarySelect.value || null,
secondaryTrackId: ctx.dom.youtubePickerSecondarySelect.value || null,
})
: await window.electronAPI.youtubePickerResolve({
sessionId: payload.sessionId,
action: 'continue-without-subtitles',
primaryTrackId: null,
secondaryTrackId: null,
});
} catch (error) {
setStatus(error instanceof Error ? error.message : String(error), true);
return;
}
if (!response.ok) {
setStatus(response.message, true);
return;
@@ -129,7 +142,12 @@ export function createYoutubeTrackPickerModal(
}
function openYoutubePickerModal(payload: YoutubePickerOpenPayload): void {
if (ctx.state.youtubePickerModalOpen) return;
if (ctx.state.youtubePickerModalOpen) {
options.syncSettingsModalSubtitleSuppression();
applyPayload(payload);
window.electronAPI.notifyOverlayModalOpened('youtube-track-picker');
return;
}
ctx.state.youtubePickerModalOpen = true;
options.syncSettingsModalSubtitleSuppression();
applyPayload(payload);