fix(stats): repair legacy combined-season anime rows on startup (#116)

2026-07-29 19:21:33 -07:00 · 2026-06-09 12:41:07 -07:00
parent 311f1e8ee5
commit d5bfdcae7b
7 changed files with 952 additions and 2 deletions
@@ -680,6 +680,116 @@ test('split maintenance helpers update anime metadata and watched state', () =>
  }
 });

+test('updateAnimeAnilistInfo redistributes legacy combined row before assigning duplicate AniList id', () => {
+  const { db, dbPath } = createDb();
+
+  try {
+    const legacyAnimeId = getOrCreateAnimeRecord(db, {
+      parsedTitle: 'KonoSuba',
+      canonicalTitle: 'KonoSuba',
+      anilistId: 21202,
+      titleRomaji: 'Kono Subarashii Sekai ni Shukufuku wo!',
+      titleEnglish: null,
+      titleNative: null,
+      metadataJson: null,
+    });
+    const seasonAnimeId = getOrCreateAnimeRecord(db, {
+      parsedTitle: 'KonoSuba',
+      canonicalTitle: 'KonoSuba',
+      seasonScope: 1,
+      anilistId: null,
+      titleRomaji: null,
+      titleEnglish: null,
+      titleNative: null,
+      metadataJson: null,
+    });
+    const legacySeasonOneVideoId = getOrCreateVideoRecord(db, 'local:/tmp/konosuba-s01e01.mkv', {
+      canonicalTitle: 'KonoSuba S01E01',
+      sourcePath: '/tmp/konosuba-s01e01.mkv',
+      sourceUrl: null,
+      sourceType: SOURCE_TYPE_LOCAL,
+    });
+    const legacySeasonTwoVideoId = getOrCreateVideoRecord(db, 'local:/tmp/konosuba-s02e01.mkv', {
+      canonicalTitle: 'KonoSuba S02E01',
+      sourcePath: '/tmp/konosuba-s02e01.mkv',
+      sourceUrl: null,
+      sourceType: SOURCE_TYPE_LOCAL,
+    });
+    const targetVideoId = getOrCreateVideoRecord(db, 'local:/tmp/konosuba-s01e02.mkv', {
+      canonicalTitle: 'KonoSuba S01E02',
+      sourcePath: '/tmp/konosuba-s01e02.mkv',
+      sourceUrl: null,
+      sourceType: SOURCE_TYPE_LOCAL,
+    });
+
+    linkVideoToAnimeRecord(db, legacySeasonOneVideoId, {
+      animeId: legacyAnimeId,
+      parsedBasename: 'konosuba-s01e01.mkv',
+      parsedTitle: 'KonoSuba',
+      parsedSeason: 1,
+      parsedEpisode: 1,
+      parserSource: 'test',
+      parserConfidence: 1,
+      parseMetadataJson: null,
+    });
+    linkVideoToAnimeRecord(db, legacySeasonTwoVideoId, {
+      animeId: legacyAnimeId,
+      parsedBasename: 'konosuba-s02e01.mkv',
+      parsedTitle: 'KonoSuba',
+      parsedSeason: 2,
+      parsedEpisode: 1,
+      parserSource: 'test',
+      parserConfidence: 1,
+      parseMetadataJson: null,
+    });
+    linkVideoToAnimeRecord(db, targetVideoId, {
+      animeId: seasonAnimeId,
+      parsedBasename: 'konosuba-s01e02.mkv',
+      parsedTitle: 'KonoSuba',
+      parsedSeason: 1,
+      parsedEpisode: 2,
+      parserSource: 'test',
+      parserConfidence: 1,
+      parseMetadataJson: null,
+    });
+
+    updateAnimeAnilistInfo(db, targetVideoId, {
+      anilistId: 21202,
+      titleRomaji: 'Kono Subarashii Sekai ni Shukufuku wo!',
+      titleEnglish: null,
+      titleNative: null,
+      episodesTotal: 10,
+    });
+
+    const rows = db
+      .prepare(
+        `
+          SELECT
+            a.canonical_title AS canonicalTitle,
+            a.anilist_id AS anilistId,
+            COUNT(v.video_id) AS videoCount
+          FROM imm_anime a
+          LEFT JOIN imm_videos v ON v.anime_id = a.anime_id
+          GROUP BY a.anime_id
+          ORDER BY a.canonical_title ASC
+        `,
+      )
+      .all() as Array<{
+      canonicalTitle: string;
+      anilistId: number | null;
+      videoCount: number;
+    }>;
+
+    assert.deepEqual(rows, [
+      { canonicalTitle: 'KonoSuba Season 1', anilistId: 21202, videoCount: 2 },
+      { canonicalTitle: 'KonoSuba Season 2', anilistId: null, videoCount: 1 },
+    ]);
+  } finally {
+    db.close();
+    cleanupDbPath(dbPath);
+  }
+});
+
 test('deleteSessions refreshes only rollups affected by deleted sessions', () => {
  const { db, dbPath } = createDb();

@@ -0,0 +1,330 @@
+import type { DatabaseSync } from './sqlite';
+import { getOrCreateAnimeRecord } from './storage';
+import { toDbTimestamp } from './query-shared';
+import { nowMs } from './time';
+
+export interface AnimeSeasonRepairSummary {
+  scanned: number;
+  repaired: number;
+  movedVideos: number;
+  deletedAnimeRows: number;
+}
+
+interface AnimeRow {
+  anime_id: number;
+  anilist_id: number | null;
+  title_romaji: string | null;
+  title_english: string | null;
+  title_native: string | null;
+  episodes_total: number | null;
+  description: string | null;
+}
+
+interface ParsedVideoRow {
+  video_id: number;
+  parsed_title: string | null;
+  parsed_season: number | null;
+}
+
+interface RedistributeOptions {
+  transferAnilistToAnimeId?: number | null;
+  transferLegacyAnilist?: boolean;
+  overwriteTargetAnilist?: boolean;
+}
+
+function emptySummary(scanned = 0): AnimeSeasonRepairSummary {
+  return {
+    scanned,
+    repaired: 0,
+    movedVideos: 0,
+    deletedAnimeRows: 0,
+  };
+}
+
+function mergeSummary(
+  target: AnimeSeasonRepairSummary,
+  source: AnimeSeasonRepairSummary,
+): AnimeSeasonRepairSummary {
+  target.scanned += source.scanned;
+  target.repaired += source.repaired;
+  target.movedVideos += source.movedVideos;
+  target.deletedAnimeRows += source.deletedAnimeRows;
+  return target;
+}
+
+function runInTransaction<T>(db: DatabaseSync, work: () => T): T {
+  db.exec('BEGIN');
+  try {
+    const result = work();
+    db.exec('COMMIT');
+    return result;
+  } catch (error) {
+    db.exec('ROLLBACK');
+    throw error;
+  }
+}
+
+function normalizeSeason(value: number | null): number | null {
+  if (typeof value !== 'number' || !Number.isSafeInteger(value) || value <= 0) {
+    return null;
+  }
+  return value;
+}
+
+function getAnimeRow(db: DatabaseSync, animeId: number): AnimeRow | null {
+  return db
+    .prepare(
+      `
+        SELECT
+          anime_id,
+          anilist_id,
+          title_romaji,
+          title_english,
+          title_native,
+          episodes_total,
+          description
+        FROM imm_anime
+        WHERE anime_id = ?
+      `,
+    )
+    .get(animeId) as AnimeRow | null;
+}
+
+function getParsedVideos(db: DatabaseSync, animeId: number): ParsedVideoRow[] {
+  return db
+    .prepare(
+      `
+        SELECT video_id, parsed_title, parsed_season
+        FROM imm_videos
+        WHERE anime_id = ?
+        ORDER BY video_id ASC
+      `,
+    )
+    .all(animeId) as ParsedVideoRow[];
+}
+
+function hasAnimeReferences(db: DatabaseSync, animeId: number): boolean {
+  const row = db
+    .prepare(
+      `
+        SELECT 1 AS found
+        WHERE EXISTS (SELECT 1 FROM imm_videos WHERE anime_id = ?)
+           OR EXISTS (SELECT 1 FROM imm_subtitle_lines WHERE anime_id = ?)
+      `,
+    )
+    .get(animeId, animeId) as { found: number } | null;
+  return Boolean(row);
+}
+
+function assignAnilistToTarget(
+  db: DatabaseSync,
+  source: AnimeRow,
+  targetAnimeId: number,
+  overwriteTarget: boolean,
+  updatedAt: string,
+): boolean {
+  if (source.anilist_id === null || targetAnimeId === source.anime_id) {
+    return false;
+  }
+
+  const target = getAnimeRow(db, targetAnimeId);
+  if (!target) {
+    return false;
+  }
+  if (!overwriteTarget && target.anilist_id !== null && target.anilist_id !== source.anilist_id) {
+    return false;
+  }
+
+  db.prepare(
+    `
+      UPDATE imm_anime
+      SET anilist_id = NULL,
+          LAST_UPDATE_DATE = ?
+      WHERE anime_id = ?
+    `,
+  ).run(updatedAt, source.anime_id);
+
+  const updated = db
+    .prepare(
+      `
+        UPDATE imm_anime
+        SET
+          anilist_id = ?,
+          title_romaji = COALESCE(?, title_romaji),
+          title_english = COALESCE(?, title_english),
+          title_native = COALESCE(?, title_native),
+          episodes_total = COALESCE(?, episodes_total),
+          description = COALESCE(?, description),
+          LAST_UPDATE_DATE = ?
+        WHERE anime_id = ?
+      `,
+    )
+    .run(
+      source.anilist_id,
+      source.title_romaji,
+      source.title_english,
+      source.title_native,
+      source.episodes_total,
+      source.description,
+      updatedAt,
+      targetAnimeId,
+    ) as { changes: number };
+  return updated.changes > 0;
+}
+
+function redistributeAnimeRowByParsedSeasonsInTransaction(
+  db: DatabaseSync,
+  animeId: number,
+  options: RedistributeOptions = {},
+): AnimeSeasonRepairSummary {
+  const source = getAnimeRow(db, animeId);
+  if (!source) {
+    return emptySummary(1);
+  }
+
+  const videos = getParsedVideos(db, animeId);
+  const summary = emptySummary(1);
+  const updatedAt = toDbTimestamp(nowMs());
+  const targetBySeason = new Map<number, number>();
+
+  for (const video of videos) {
+    const parsedTitle = video.parsed_title?.trim();
+    const season = normalizeSeason(video.parsed_season);
+    if (!parsedTitle || season === null) {
+      continue;
+    }
+
+    const targetAnimeId = getOrCreateAnimeRecord(db, {
+      parsedTitle,
+      canonicalTitle: parsedTitle,
+      seasonScope: season,
+      anilistId: null,
+      titleRomaji: null,
+      titleEnglish: null,
+      titleNative: null,
+      metadataJson: null,
+    });
+    targetBySeason.set(season, targetAnimeId);
+
+    if (targetAnimeId === animeId) {
+      continue;
+    }
+
+    const videoUpdate = db
+      .prepare(
+        `
+          UPDATE imm_videos
+          SET anime_id = ?,
+              LAST_UPDATE_DATE = ?
+          WHERE video_id = ?
+        `,
+      )
+      .run(targetAnimeId, updatedAt, video.video_id) as { changes: number };
+    const lineUpdate = db
+      .prepare(
+        `
+          UPDATE imm_subtitle_lines
+          SET anime_id = ?,
+              LAST_UPDATE_DATE = ?
+          WHERE video_id = ?
+        `,
+      )
+      .run(targetAnimeId, updatedAt, video.video_id) as { changes: number };
+
+    if (videoUpdate.changes > 0 || lineUpdate.changes > 0) {
+      summary.movedVideos += 1;
+    }
+  }
+
+  const transferTarget =
+    options.transferAnilistToAnimeId ??
+    (options.transferLegacyAnilist
+      ? (targetBySeason.get(1) ??
+        (targetBySeason.size === 1 ? [...targetBySeason.values()][0] : null))
+      : null);
+  if (transferTarget) {
+    const transferred = assignAnilistToTarget(
+      db,
+      source,
+      transferTarget,
+      options.overwriteTargetAnilist ?? false,
+      updatedAt,
+    );
+    if (transferred) {
+      summary.repaired += 1;
+    }
+  }
+
+  if (!hasAnimeReferences(db, animeId)) {
+    const deleted = db.prepare('DELETE FROM imm_anime WHERE anime_id = ?').run(animeId) as {
+      changes: number;
+    };
+    if (deleted.changes > 0) {
+      summary.deletedAnimeRows += 1;
+    }
+  }
+
+  if (summary.movedVideos > 0 || summary.deletedAnimeRows > 0) {
+    summary.repaired += 1;
+  }
+  return summary;
+}
+
+export function repairLegacySeasonlessAnimeRows(db: DatabaseSync): AnimeSeasonRepairSummary {
+  return runInTransaction(db, () => {
+    const candidates = db
+      .prepare(
+        `
+          SELECT a.anime_id AS animeId
+          FROM imm_anime a
+          JOIN imm_videos v ON v.anime_id = a.anime_id
+          WHERE v.parsed_title IS NOT NULL
+            AND TRIM(v.parsed_title) != ''
+            AND v.parsed_season IS NOT NULL
+            AND v.parsed_season > 0
+          GROUP BY a.anime_id
+          HAVING COUNT(DISTINCT v.parsed_season) > 1
+          ORDER BY a.anime_id ASC
+        `,
+      )
+      .all() as Array<{ animeId: number }>;
+    const summary = emptySummary();
+    for (const candidate of candidates) {
+      mergeSummary(
+        summary,
+        redistributeAnimeRowByParsedSeasonsInTransaction(db, candidate.animeId, {
+          transferLegacyAnilist: true,
+        }),
+      );
+    }
+    return summary;
+  });
+}
+
+export function resolveAnimeAnilistConflict(
+  db: DatabaseSync,
+  targetAnimeId: number,
+  anilistId: number,
+): AnimeSeasonRepairSummary {
+  const conflict = db
+    .prepare(
+      `
+        SELECT anime_id AS animeId
+        FROM imm_anime
+        WHERE anilist_id = ?
+          AND anime_id != ?
+        LIMIT 1
+      `,
+    )
+    .get(anilistId, targetAnimeId) as { animeId: number } | null;
+  if (!conflict) {
+    return emptySummary();
+  }
+
+  return runInTransaction(db, () =>
+    redistributeAnimeRowByParsedSeasonsInTransaction(db, conflict.animeId, {
+      transferAnilistToAnimeId: targetAnimeId,
+      overwriteTargetAnilist: true,
+    }),
+  );
+}
@@ -1,9 +1,10 @@
 import { createHash } from 'node:crypto';
 import type { DatabaseSync } from './sqlite';
 import { buildCoverBlobReference, normalizeCoverBlobBytes } from './storage';
-import { rebuildLifetimeSummariesInTransaction } from './lifetime';
+import { rebuildLifetimeSummaries, rebuildLifetimeSummariesInTransaction } from './lifetime';
 import { getRollupGroupsForSessions, refreshRollupsForGroupsInTransaction } from './maintenance';
 import { nowMs } from './time';
+import { resolveAnimeAnilistConflict } from './anime-season-repair';
 import { PartOfSpeech, type MergedToken } from '../../../types';
 import { shouldExcludeTokenFromVocabularyPersistence } from '../tokenizer/annotation-stage';
 import { deriveStoredPartOfSpeech } from '../tokenizer/part-of-speech';
@@ -425,6 +426,14 @@ export function updateAnimeAnilistInfo(
  } | null;
  if (!row?.anime_id) return;

+  const repair = resolveAnimeAnilistConflict(db, row.anime_id, info.anilistId);
+  const targetRow = db
+    .prepare('SELECT anime_id FROM imm_videos WHERE video_id = ?')
+    .get(videoId) as {
+    anime_id: number | null;
+  } | null;
+  if (!targetRow?.anime_id) return;
+
  db.prepare(
    `
    UPDATE imm_anime
@@ -444,8 +453,11 @@ export function updateAnimeAnilistInfo(
    info.titleNative,
    info.episodesTotal,
    toDbTimestamp(nowMs()),
-    row.anime_id,
+    targetRow.anime_id,
  );
+  if (repair.movedVideos > 0 || repair.deletedAnimeRows > 0) {
+    rebuildLifetimeSummaries(db);
+  }
 }

 export function markVideoWatched(db: DatabaseSync, videoId: number, watched: boolean): void {