chore(task-85): finalize closure tracking and launcher path enforcement

2026-02-27 18:22:41 -08:00 · 2026-02-20 23:15:02 -08:00
parent f8db9e7119
commit c8c7f46a16
12 changed files with 211 additions and 31 deletions
--- a/docs/development.md
+++ b/docs/development.md
@@ -40,6 +40,7 @@ make build-macos-unsigned # macOS DMG + ZIP (unsigned)
 - Source of truth: `launcher/*.ts`
 - Generated output: `dist/launcher/subminer`
 - Do not hand-edit generated launcher output.
+- Repo-root `./subminer` is a stale artifact path and is rejected by verification checks.
 - Install targets (`make install-linux`, `make install-macos`) copy from `dist/launcher/subminer`.

 Verify the workflow:
--- a/docs/installation.md
+++ b/docs/installation.md
@@ -65,6 +65,7 @@ make install
 ```

 `make build-launcher` generates the wrapper at `dist/launcher/subminer`. The checked-in launcher source remains `launcher/*.ts`.
+Do not use a repo-root `./subminer` artifact when building from source; workflow checks enforce `dist/launcher/subminer` as the only generated path.

 ## macOS

--- a/docs/subagents/INDEX.md
+++ b/docs/subagents/INDEX.md
@@ -32,3 +32,6 @@ Read first. Keep concise.
 | `codex-task95-anki-20260221T031836Z-6f3e`                 | `codex-task95-anki`                 | `Implement TASK-95 anki-integration extraction for field-grouping merge collaborator`                                | `done`        | `docs/subagents/agents/codex-task95-anki-20260221T031836Z-6f3e.md`                 | `2026-02-21T03:26:55Z` |
 | `opencode-task-94-20260221T033647Z-7ou2`                  | `opencode-task-94`                  | `Finish TASK-94 thin composition root refactor and close acceptance criteria`                                        | `done`        | `docs/subagents/agents/opencode-task-94-20260221T033647Z-7ou2.md`                  | `2026-02-21T04:12:45Z` |
 | `codex-task71-round2-20260221T043541Z-k9t3`               | `codex-task71-round2`               | `Execute TASK-71 round 2 split of main.ts into domain runtime modules`                                               | `done`        | `docs/subagents/agents/codex-task71-round2-20260221T043541Z-k9t3.md`               | `2026-02-21T04:57:00Z` |
+| `codex-task85-20260221T051308Z-164g`                      | `codex-task85-exec`                 | `Execute TASK-85 remaining AC/DoD with writing-plans and executing-plans flow`                                       | `done`        | `docs/subagents/agents/codex-task85-20260221T051308Z-164g.md`                      | `2026-02-21T05:45:50Z` |
+| `codex-review-refactor-20260221T062353Z-p6k2`             | `codex-review-refactor`             | `Perform code review for current refactor changes and report actionable findings`                                    | `done`        | `docs/subagents/agents/codex-review-refactor-20260221T062353Z-p6k2.md`             | `2026-02-21T06:25:27Z` |
+| `opencode-task93-sync-20260221T070842Z-71c6`              | `opencode-task93-sync`              | `Synchronize TASK-85 closure tracking and child-task status in Backlog`                                              | `done`        | `docs/subagents/agents/opencode-task93-sync-20260221T070842Z-71c6.md`              | `2026-02-21T07:11:58Z` |
--- a/docs/subagents/agents/codex-review-refactor-20260221T062353Z-p6k2.md
+++ b/docs/subagents/agents/codex-review-refactor-20260221T062353Z-p6k2.md
@@ -0,0 +1,34 @@
+# Agent: `codex-review-refactor-20260221T062353Z-p6k2`
+
+- alias: `codex-review-refactor`
+- mission: `Review current refactor diff; report correctness/regression/test gaps`
+- status: `done`
+- branch: `main`
+- started_at: `2026-02-21T06:23:53Z`
+- heartbeat_minutes: `5`
+
+## Current Work (newest first)
+- [2026-02-21T06:25:27Z] handoff: review complete; no blocking/important defects found in refactor + launcher-workflow enforcement diff; targeted guardrails/tests passed.
+- [2026-02-21T06:25:27Z] test: `bun run check:main-fanin` and `bun run test:core:dist` passed on current tree.
+- [2026-02-21T06:24:30Z] progress: audited diffs in `.github/workflows/{ci,release}.yml`, `scripts/verify-generated-launcher.sh`, docs/task updates; validated launcher verifier behavior.
+- [2026-02-21T06:23:53Z] intent: open refactor diff; audit behavior changes; run targeted tests; return severity-ranked findings.
+
+## Files Touched
+- `docs/subagents/INDEX.md`
+- `docs/subagents/agents/codex-review-refactor-20260221T062353Z-p6k2.md`
+- `.github/workflows/ci.yml` (reviewed)
+- `.github/workflows/release.yml` (reviewed)
+- `scripts/verify-generated-launcher.sh` (reviewed)
+- `docs/development.md` (reviewed)
+- `docs/installation.md` (reviewed)
+- `backlog/tasks/task-85 - Refactor-large-files-for-maintainability-and-readability.md` (reviewed)
+
+## Assumptions
+- User asks for review only; no code changes requested.
+- Review target is current working tree refactor deltas on `main`.
+
+## Open Questions / Blockers
+- None.
+
+## Next Step
+- Await user direction (fixes optional; no required corrections identified).
--- a/docs/subagents/agents/codex-task85-20260221T051308Z-164g.md
+++ b/docs/subagents/agents/codex-task85-20260221T051308Z-164g.md
@@ -0,0 +1,36 @@
+# Agent: codex-task85-20260221T051308Z-164g
+
+- alias: codex-task85-exec
+- mission: Execute TASK-85 remaining AC/DoD with writing-plans then executing-plans flow (no commit)
+- status: done
+- branch: main
+- started_at: 2026-02-21T05:13:08Z
+- heartbeat_minutes: 5
+
+## Current Work (newest first)
+
+- [2026-02-21T05:45:50Z] completed: executed TASK-85 finalization plan end-to-end (no commit); enforced generated launcher policy in verifier + CI/release workflows, updated docs, ran full gates, and finalized TASK-85 to `Done` via Backlog MCP.
+- [2026-02-21T05:45:50Z] test: `make build-launcher && bash scripts/verify-generated-launcher.sh` pass after removing stale repo-root `./subminer`; full gate pass: `bun run build && bun run test:config:dist && bun run test:core:dist && bun run check:file-budgets && bun run check:main-fanin`.
+- [2026-02-21T05:13:08Z] intent: load backlog TASK-85 context, produce execution plan via writing-plans skill, then execute via executing-plans skill using parallel subagents where independent.
+- [2026-02-21T05:13:08Z] planned files: `src/main.ts`, `src/main/runtime/**`, `docs/development.md`, `docs/installation.md`, `scripts/verify-generated-launcher.sh`, `backlog/tasks/task-85 - Refactor-large-files-for-maintainability-and-readability.md`, `docs/plans/**`.
+- [2026-02-21T05:13:08Z] assumptions: Backlog initialized (`backlog/` exists) and TASK-85 remains active with AC #1/#4 + DoD #1/#3 open.
+
+## Files Touched
+
+- `docs/subagents/agents/codex-task85-20260221T051308Z-164g.md`
+- `docs/subagents/INDEX.md`
+- `docs/subagents/collaboration.md`
+- `docs/plans/2026-02-21-task85-finalization-plan.md`
+- `scripts/verify-generated-launcher.sh`
+- `.github/workflows/ci.yml`
+- `.github/workflows/release.yml`
+- `docs/development.md`
+- `docs/installation.md`
+
+## Open Questions / Blockers
+
+- none
+
+## Next Step
+
+- handoff complete; await user direction (optional commit/PR).
--- a/docs/subagents/agents/opencode-task93-sync-20260221T070842Z-71c6.md
+++ b/docs/subagents/agents/opencode-task93-sync-20260221T070842Z-71c6.md
@@ -0,0 +1,40 @@
+# Agent Session: opencode-task93-sync-20260221T070842Z-71c6
+
+- alias: `opencode-task93-sync`
+- mission: `Synchronize TASK-85 closure tracking and child-task status in Backlog`
+- status: `done`
+- started_utc: `2026-02-21T07:08:42Z`
+- completed_utc: `2026-02-21T07:11:58Z`
+- backlog_task: `TASK-93`
+
+## Intent
+
+- Load TASK-93 + TASK-85 + related child tasks from Backlog MCP.
+- Build execution plan via writing-plans skill.
+- Execute plan via executing-plans skill.
+- Update Backlog task metadata/notes/checklists to satisfy TASK-93 AC.
+
+## Planned Files/Surfaces
+
+- `backlog/tasks/task-93 - Synchronize-TASK-85-closure-tracking-and-child-task-status.md` (via MCP)
+- `backlog/tasks/task-85 - Refactor-large-files-for-maintainability-and-readability.md` (via MCP)
+- Child task tickets linked to TASK-85 (via MCP)
+- `docs/subagents/INDEX.md` (own row only)
+- `docs/subagents/collaboration.md` (append-only note)
+
+## Assumptions
+
+- Backlog already initialized (folder exists).
+- TASK-85 was recently marked Done and needs consistency cleanup.
+
+## Heartbeat Log
+
+- `2026-02-21T07:08:42Z` session started; reading backlog + planning context.
+- `2026-02-21T07:11:58Z` execution complete; TASK-85 synchronized and TASK-93 finalized Done.
+
+## Outcome
+
+- Created plan: `docs/plans/2026-02-21-task-93-sync-task85-closure-plan.md`.
+- Updated `TASK-85` description + implementation notes with child ownership map and ordered remaining scope.
+- Updated `TASK-93` implementation notes, checked all AC/DoD items, set final summary, marked status Done.
+- No product-code changes; backlog/process/documentation surfaces only.
--- a/docs/subagents/collaboration.md
+++ b/docs/subagents/collaboration.md
@@ -31,3 +31,7 @@ Shared notes. Append-only.
 - [2026-02-21T04:12:45Z] [opencode-task-94-20260221T033647Z-7ou2|opencode-task-94] TASK-94 finalized in Backlog MCP: AC checklist complete, notes+final summary recorded, status moved to Done.
 - [2026-02-21T04:35:41Z] [codex-task71-round2-20260221T043541Z-k9t3|codex-task71-round2] overlap note: starting TASK-71 round 2 follow-up on `src/main.ts` + `src/main/runtime/composers/*` + docs; preserving prior TASK-94/TASK-95 edits.
 - [2026-02-21T04:57:00Z] [codex-task71-round2-20260221T043541Z-k9t3|codex-task71-round2] completed TASK-71: extracted AniList tracking + MPV runtime composition into new composers, added seam tests, rewired `main.ts` + composer barrel, strict fan-in green, and finalized Backlog task as Done.
+- [2026-02-21T05:13:08Z] [codex-task85-20260221T051308Z-164g|codex-task85-exec] starting TASK-85 execution pass: load backlog task context, generate plan via writing-plans, execute via executing-plans, no commit.
+- [2026-02-21T05:45:50Z] [codex-task85-20260221T051308Z-164g|codex-task85-exec] completed TASK-85 pass: enforced launcher generated-artifact workflow across verifier + CI/release + docs, ran full build/test/guardrails, and finalized TASK-85 status to Done in Backlog MCP.
+- [2026-02-21T07:08:42Z] [opencode-task93-sync-20260221T070842Z-71c6|opencode-task93-sync] starting TASK-93 backlog synchronization pass: align TASK-85 closure tracking, AC/DoD mapping, and child-task ownership; backlog-only edits expected.
+- [2026-02-21T07:11:58Z] [opencode-task93-sync-20260221T070842Z-71c6|opencode-task93-sync] completed TASK-93: updated TASK-85 description/notes with explicit AC/DoD ownership + remaining-scope order; finalized TASK-93 AC/DoD and status Done.