fix(overlay): keep popup pause working with Hachidori 0.4.0

Browse Source

Hachidori 0.4.0 closed its popup shadow root, so isHachidoriPopupOpen always
returned false. The popup never took over the subtitle hover pause, and moving
off the subtitle resumed playback with the popup open. Popup key and controller
routing read the same check. The sidebar kept working because its hold follows
the attention event instead of the pane.

The fork now publishes the pane state on the host element, and the renderer
reads that attribute instead of upstream's shadow root and CSS class. The unit
stubs modelled an open root and hid this, so test:dictionary:electron now drives
the real reader and asserts the attribute follows the pane.

...

This commit is contained in:

sudacode committed 2026-11-04 22:46:25 -08:00

1 parent bc7e82fee6

commit c2dac537da

5 files changed

+95 -30

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

vendor/hachidori

Vendored

+1 -1

Submodule vendor/hachidori updated: 323d0143dd...0792c09e05.