From bc75a0cfbd7c79aa63101f3c10c60173a82f6df4 Mon Sep 17 00:00:00 2001 From: sudacode Date: Thu, 19 Feb 2026 21:46:25 -0800 Subject: [PATCH] fix: update default subtitle background color --- ...Update-default-subtitle-background-RGBA.md | 31 ++++++++++++++++ config.example.jsonc | 2 +- docs/configuration.md | 4 +- docs/public/config.example.jsonc | 2 +- docs/subagents/INDEX.md | 3 +- ...codex-subtitle-bg-20260220T054247Z-h9cu.md | 37 +++++++++++++++++++ docs/subagents/collaboration.md | 2 + src/config/config.test.ts | 1 + src/config/definitions.ts | 2 +- src/renderer/style.css | 2 +- 10 files changed, 79 insertions(+), 7 deletions(-) create mode 100644 backlog/tasks/task-89 - Update-default-subtitle-background-RGBA.md create mode 100644 docs/subagents/agents/codex-subtitle-bg-20260220T054247Z-h9cu.md diff --git a/backlog/tasks/task-89 - Update-default-subtitle-background-RGBA.md b/backlog/tasks/task-89 - Update-default-subtitle-background-RGBA.md new file mode 100644 index 0000000..fb5cbf1 --- /dev/null +++ b/backlog/tasks/task-89 - Update-default-subtitle-background-RGBA.md @@ -0,0 +1,31 @@ +--- +id: TASK-89 +title: Update default subtitle background RGBA +status: Done +assignee: [] +created_date: '2026-02-20 05:43' +updated_date: '2026-02-20 05:44' +labels: [] +dependencies: [] +priority: low +--- + +## Description + + +Set default subtitle background color to rgb(30, 32, 48, 0.88) as requested. + + +## Acceptance Criteria + +- [ ] #1 Default subtitle background color value matches requested string. +- [ ] #2 Config tests pass. +- [ ] #3 Default subtitle background color value matches requested string. +- [ ] #4 Config tests pass. + + +## Implementation Notes + + +Updated default subtitle background to rgb(30, 32, 48, 0.88) in config defaults, renderer fallback CSS, and docs/examples. Added regression assertion in src/config/config.test.ts. Verified with bun test src/config/config.test.ts (33/33 pass). + diff --git a/config.example.jsonc b/config.example.jsonc index 2c6034c..ffdcaa2 100644 --- a/config.example.jsonc +++ b/config.example.jsonc @@ -171,7 +171,7 @@ "fontColor": "#cad3f5", // Font color setting. "fontWeight": "normal", // Font weight setting. "fontStyle": "normal", // Font style setting. - "backgroundColor": "rgba(54, 58, 79, 0.5)", // Background color setting. + "backgroundColor": "rgb(30, 32, 48, 0.88)", // Background color setting. "nPlusOneColor": "#c6a0f6", // N plus one color setting. "knownWordColor": "#a6da95", // Known word color setting. "jlptColors": { diff --git a/docs/configuration.md b/docs/configuration.md index d3d4293..790ca3f 100644 --- a/docs/configuration.md +++ b/docs/configuration.md @@ -705,7 +705,7 @@ See `config.example.jsonc` for detailed configuration options. "fontColor": "#cad3f5", "fontWeight": "normal", "fontStyle": "normal", - "backgroundColor": "rgba(54, 58, 79, 0.5)", + "backgroundColor": "rgb(30, 32, 48, 0.88)", "secondary": { "fontSize": 24, "fontColor": "#ffffff", @@ -722,7 +722,7 @@ See `config.example.jsonc` for detailed configuration options. | `fontColor` | string | Any CSS color value (default: `"#cad3f5"`) | | `fontWeight` | string | CSS font-weight, e.g. `"bold"`, `"normal"`, `"600"` (default: `"normal"`) | | `fontStyle` | string | `"normal"` or `"italic"` (default: `"normal"`) | -| `backgroundColor` | string | Any CSS color, including `"transparent"` (default: `"rgba(54, 58, 79, 0.5)"`) | +| `backgroundColor` | string | Any CSS color, including `"transparent"` (default: `"rgb(30, 32, 48, 0.88)"`) | | `enableJlpt` | boolean | Enable JLPT level underline styling (`false` by default) | | `frequencyDictionary.enabled` | boolean | Enable frequency highlighting from dictionary lookups (`false` by default) | | `frequencyDictionary.sourcePath` | string | Path to a local frequency dictionary root. Leave empty or omit to use the built-in bundled dictionary search paths. | diff --git a/docs/public/config.example.jsonc b/docs/public/config.example.jsonc index 2c6034c..ffdcaa2 100644 --- a/docs/public/config.example.jsonc +++ b/docs/public/config.example.jsonc @@ -171,7 +171,7 @@ "fontColor": "#cad3f5", // Font color setting. "fontWeight": "normal", // Font weight setting. "fontStyle": "normal", // Font style setting. - "backgroundColor": "rgba(54, 58, 79, 0.5)", // Background color setting. + "backgroundColor": "rgb(30, 32, 48, 0.88)", // Background color setting. "nPlusOneColor": "#c6a0f6", // N plus one color setting. "knownWordColor": "#a6da95", // Known word color setting. "jlptColors": { diff --git a/docs/subagents/INDEX.md b/docs/subagents/INDEX.md index cf4a05a..27ee144 100644 --- a/docs/subagents/INDEX.md +++ b/docs/subagents/INDEX.md @@ -6,9 +6,10 @@ Read first. Keep concise. | ------------ | -------------- | ---------------------------------------------------- | --------- | ------------------------------------- | ---------------------- | | `codex-main` | `planner-exec` | `Fix frequency/N+1 regression in plugin --start flow` | `in_progress` | `docs/subagents/agents/codex-main.md` | `2026-02-19T19:36:46Z` | | `codex-config-validation-20260219T172015Z-iiyf` | `codex-config-validation` | `Find root cause of config validation error for ~/.config/SubMiner/config.jsonc` | `completed` | `docs/subagents/agents/codex-config-validation-20260219T172015Z-iiyf.md` | `2026-02-19T17:26:17Z` | -| `codex-task85-20260219T233711Z-46hc` | `codex-task85` | `Resume TASK-85 maintainability refactor from latest handoff point` | `in_progress` | `docs/subagents/agents/codex-task85-20260219T233711Z-46hc.md` | `2026-02-20T05:15:40Z` | +| `codex-task85-20260219T233711Z-46hc` | `codex-task85` | `Resume TASK-85 maintainability refactor from latest handoff point` | `in_progress` | `docs/subagents/agents/codex-task85-20260219T233711Z-46hc.md` | `2026-02-20T05:31:05Z` | | `codex-anilist-deeplink-20260219T233926Z` | `anilist-deeplink` | `Fix external subminer:// AniList callback handling from browser` | `done` | `docs/subagents/agents/codex-anilist-deeplink-20260219T233926Z.md` | `2026-02-19T23:59:21Z` | | `codex-texthooker-highlights-20260220T002354Z-927c` | `codex-texthooker-highlights` | `Add optional texthooker highlight toggles for known/n+1/frequency/JLPT` | `completed` | `docs/subagents/agents/codex-texthooker-highlights-20260220T002354Z-927c.md` | `2026-02-20T00:30:49Z` | | `codex-texthooker-ui-playwright-20260220T003827Z-k3p9` | `codex-texthooker-ui-playwright` | `Run Playwright MCP smoke/regression checks for texthooker-ui changes` | `completed` | `docs/subagents/agents/codex-texthooker-ui-playwright-20260220T003827Z-k3p9.md` | `2026-02-20T00:42:09Z` | | `codex-texthooker-color-ws-20260220T005844Z-r7m2` | `codex-texthooker-color-ws` | `Fix texthooker websocket payload so token highlight colors render` | `completed` | `docs/subagents/agents/codex-texthooker-color-ws-20260220T005844Z-r7m2.md` | `2026-02-20T01:01:00Z` | | `codex-nplusone-pos1-20260220T012300Z-c5he` | `codex-nplusone-pos1` | `Fix N+1 false-negative when Yomitan functional tokens inflate unknown candidate count` | `completed` | `docs/subagents/agents/codex-nplusone-pos1-20260220T012300Z-c5he.md` | `2026-02-20T01:28:20Z` | +| `codex-subtitle-bg-20260220T054247Z-h9cu` | `codex-subtitle-bg` | `Update default subtitle background color to requested RGBA value` | `completed` | `docs/subagents/agents/codex-subtitle-bg-20260220T054247Z-h9cu.md` | `2026-02-20T05:44:45Z` | diff --git a/docs/subagents/agents/codex-subtitle-bg-20260220T054247Z-h9cu.md b/docs/subagents/agents/codex-subtitle-bg-20260220T054247Z-h9cu.md new file mode 100644 index 0000000..4a1274f --- /dev/null +++ b/docs/subagents/agents/codex-subtitle-bg-20260220T054247Z-h9cu.md @@ -0,0 +1,37 @@ +# Agent: codex-subtitle-bg-20260220T054247Z-h9cu + +- alias: codex-subtitle-bg +- mission: Update default subtitle background color to requested RGBA value +- status: completed +- branch: main +- started_at: 2026-02-20T05:42:54Z +- heartbeat_minutes: 5 + +## Current Work (newest first) + +- [2026-02-20T05:44:45Z] handoff: completed TASK-89; default subtitle background updated to `rgb(30, 32, 48, 0.88)` across config defaults, docs examples, and renderer fallback CSS. +- [2026-02-20T05:44:45Z] test: `bun test src/config/config.test.ts` pass (33/33) after adding regression assertion for `config.subtitleStyle.backgroundColor`. +- [2026-02-20T05:42:54Z] intent: apply requested default subtitle background color change, keep scope minimal, run targeted tests. +- [2026-02-20T05:42:54Z] planned files: `src/config/definitions.ts`, related config tests if default snapshot/assertions exist, subagent bookkeeping files. +- [2026-02-20T05:42:54Z] assumptions: user requested exact value string `rgb(30, 32, 48, 0.88)`; apply to default subtitle background. + +## Files Touched + +- `docs/subagents/INDEX.md` +- `docs/subagents/collaboration.md` +- `docs/subagents/agents/codex-subtitle-bg-20260220T054247Z-h9cu.md` +- `backlog/tasks/task-89 - Update-default-subtitle-background-RGBA.md` +- `src/config/config.test.ts` +- `src/config/definitions.ts` +- `config.example.jsonc` +- `docs/public/config.example.jsonc` +- `docs/configuration.md` +- `src/renderer/style.css` + +## Open Questions / Blockers + +- none + +## Next Step + +- none diff --git a/docs/subagents/collaboration.md b/docs/subagents/collaboration.md index d6d299a..4a4bbb2 100644 --- a/docs/subagents/collaboration.md +++ b/docs/subagents/collaboration.md @@ -5,3 +5,5 @@ Shared notes. Append-only. - [YYYY-MM-DDTHH:MM:SSZ] [agent_id|alias] note, question, dependency, conflict, decision. - [2026-02-19T08:21:11Z] [codex-main|planner-exec] conflict note: `docs/subagents/INDEX.md` and `docs/subagents/agents/codex-main.md` were externally updated to TASK-69 while TASK-38 work was in-flight; reconciled own row/file back to TASK-38 handoff state. - [2026-02-20T00:01:40Z] [codex-anilist-deeplink|anilist-deeplink] preparing commit; scoping staged set to repo changes, excluding external reference dirs (vendor/yomitan-jlpt-vocab, mpv-anilist-updater). +- [2026-02-20T05:42:54Z] [codex-subtitle-bg-20260220T054247Z-h9cu|codex-subtitle-bg] short config tweak requested: update default subtitle background color; scoping to config defaults/tests only. +- [2026-02-20T05:44:45Z] [codex-subtitle-bg-20260220T054247Z-h9cu|codex-subtitle-bg] completed TASK-89; updated default subtitle background in config defaults/docs/examples/renderer CSS; config tests green. diff --git a/src/config/config.test.ts b/src/config/config.test.ts index 245ae37..877658c 100644 --- a/src/config/config.test.ts +++ b/src/config/config.test.ts @@ -23,6 +23,7 @@ test('loads defaults when config is missing', () => { assert.equal(config.jellyfin.remoteControlAutoConnect, true); assert.equal(config.jellyfin.autoAnnounce, false); assert.equal(config.jellyfin.remoteControlDeviceName, 'SubMiner'); + assert.equal(config.subtitleStyle.backgroundColor, 'rgb(30, 32, 48, 0.88)'); assert.equal(config.immersionTracking.enabled, true); assert.equal(config.immersionTracking.dbPath, ''); assert.equal(config.immersionTracking.batchSize, 25); diff --git a/src/config/definitions.ts b/src/config/definitions.ts index 961bb6f..7997ae1 100644 --- a/src/config/definitions.ts +++ b/src/config/definitions.ts @@ -177,7 +177,7 @@ export const DEFAULT_CONFIG: ResolvedConfig = { fontColor: '#cad3f5', fontWeight: 'normal', fontStyle: 'normal', - backgroundColor: 'rgba(54, 58, 79, 0.5)', + backgroundColor: 'rgb(30, 32, 48, 0.88)', nPlusOneColor: '#c6a0f6', knownWordColor: '#a6da95', jlptColors: { diff --git a/src/renderer/style.css b/src/renderer/style.css index ce9eddc..e631c0a 100644 --- a/src/renderer/style.css +++ b/src/renderer/style.css @@ -263,7 +263,7 @@ body { max-width: 80%; margin-bottom: 60px; padding: 12px 20px; - background: rgba(54, 58, 79, 0.5); + background: rgb(30, 32, 48, 0.88); border-radius: 8px; pointer-events: auto; }