mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-02-27 18:22:41 -08:00
fix: address claude review action items
This commit is contained in:
@@ -170,7 +170,7 @@ export function applySubtitleDomainConfig(context: ResolveContext): void {
|
||||
'subtitleStyle.hoverTokenBackgroundColor',
|
||||
(src.subtitleStyle as { hoverTokenBackgroundColor?: unknown }).hoverTokenBackgroundColor,
|
||||
resolved.subtitleStyle.hoverTokenBackgroundColor,
|
||||
'Expected string.',
|
||||
'Expected a CSS color value (hex, rgba/hsl/hsla, named color, or var()).',
|
||||
);
|
||||
}
|
||||
|
||||
|
||||
@@ -27,9 +27,7 @@ export function sendToVisibleOverlayRuntime<T extends string>(options: {
|
||||
}
|
||||
};
|
||||
|
||||
const getURL = options.mainWindow.webContents.getURL;
|
||||
const currentURL =
|
||||
typeof getURL === 'function' ? getURL.call(options.mainWindow.webContents) : 'ready';
|
||||
const currentURL = options.mainWindow.webContents.getURL();
|
||||
const isReady =
|
||||
!options.mainWindow.webContents.isLoading() &&
|
||||
currentURL !== '' &&
|
||||
|
||||
@@ -65,12 +65,13 @@ export function createOverlayModalRuntimeService(
|
||||
return null;
|
||||
};
|
||||
|
||||
const isWindowReadyForIpc = (window: BrowserWindow): boolean => {
|
||||
const isWindowReadyForIpc = (window: BrowserWindow): boolean => {
|
||||
if (window.webContents.isLoading()) {
|
||||
return false;
|
||||
}
|
||||
return window.webContents.getURL() !== '' && window.webContents.getURL() !== 'about:blank';
|
||||
};
|
||||
const currentURL = window.webContents.getURL();
|
||||
return currentURL !== '' && currentURL !== 'about:blank';
|
||||
};
|
||||
|
||||
const sendOrQueueForWindow = (
|
||||
window: BrowserWindow,
|
||||
|
||||
@@ -111,7 +111,7 @@ function applyInlineStyleDeclarations(
|
||||
}
|
||||
|
||||
const cssValue = String(value);
|
||||
if (key.startsWith('-') || key.includes('-')) {
|
||||
if (key.includes('-')) {
|
||||
target.style.setProperty(key, cssValue);
|
||||
if (key === '--webkit-text-stroke') {
|
||||
target.style.setProperty('-webkit-text-stroke', cssValue);
|
||||
|
||||
Reference in New Issue
Block a user