mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-10-21 05:01:26 -07:00
test: cut low-value tests, rewrite the rest around behavior, parallelize lanes (#285)
This commit is contained in:
sudacode authored and 
GitHub committed
1 parent
4b6842d034
commit
b48083ddd8
368 files changed
+18045
-60331
No files matched your search
@@ -1,241 +1,120 @@
|
||||
import test from 'node:test';
|
||||
import assert from 'node:assert/strict';
|
||||
import { parseArgs, type CliArgs } from '../../cli/args';
|
||||
import { createHandleInitialArgsHandler } from './initial-args-handler';
|
||||
|
||||
test('initial args handler no-ops without initial args', () => {
|
||||
let handled = false;
|
||||
const handleInitialArgs = createHandleInitialArgsHandler({
|
||||
getInitialArgs: () => null,
|
||||
type HandlerDeps = Parameters<typeof createHandleInitialArgsHandler>[0];
|
||||
|
||||
function cliArgs(overrides: Partial<CliArgs> = {}): CliArgs {
|
||||
return { ...parseArgs([]), start: true, ...overrides };
|
||||
}
|
||||
|
||||
// Records every startup side effect so tests can assert what the handler did.
|
||||
function runInitialArgs(
|
||||
overrides: Partial<HandlerDeps> & { mpvClientConnected?: boolean } = {},
|
||||
): string[] {
|
||||
const effects: string[] = [];
|
||||
const { mpvClientConnected, ...depOverrides } = overrides;
|
||||
const mpvClient =
|
||||
mpvClientConnected === undefined
|
||||
? null
|
||||
: { connected: mpvClientConnected, connect: () => effects.push('connect') };
|
||||
createHandleInitialArgsHandler({
|
||||
getInitialArgs: () => cliArgs(),
|
||||
isBackgroundMode: () => false,
|
||||
shouldEnsureTrayOnStartup: () => false,
|
||||
shouldRunHeadlessInitialCommand: () => false,
|
||||
ensureTray: () => {},
|
||||
ensureTray: () => effects.push('tray'),
|
||||
isTexthookerOnlyMode: () => false,
|
||||
hasImmersionTracker: () => false,
|
||||
getMpvClient: () => null,
|
||||
getMpvClient: () => mpvClient,
|
||||
commandNeedsOverlayStartupPrereqs: () => false,
|
||||
commandNeedsOverlayRuntime: () => false,
|
||||
ensureOverlayStartupPrereqs: () => {},
|
||||
ensureOverlayStartupPrereqs: () => effects.push('prereqs'),
|
||||
isOverlayRuntimeInitialized: () => false,
|
||||
initializeOverlayRuntime: () => {},
|
||||
logInfo: () => {},
|
||||
handleCliCommand: () => {
|
||||
handled = true;
|
||||
initializeOverlayRuntime: () => effects.push('init-overlay'),
|
||||
logInfo: (message) => effects.push(`log:${message}`),
|
||||
handleCliCommand: (_args, source) => effects.push(`cli:${source}`),
|
||||
...depOverrides,
|
||||
})();
|
||||
return effects;
|
||||
}
|
||||
|
||||
const AUTO_CONNECT_LOG = 'log:Auto-connecting MPV client for immersion tracking';
|
||||
|
||||
const cases: Array<{
|
||||
name: string;
|
||||
overrides: Parameters<typeof runInitialArgs>[0];
|
||||
expected: string[];
|
||||
}> = [
|
||||
{
|
||||
name: 'no-ops without initial args',
|
||||
overrides: { getInitialArgs: () => null },
|
||||
expected: [],
|
||||
},
|
||||
{
|
||||
name: 'forwards args to cli handler without bootstrapping the overlay',
|
||||
overrides: {},
|
||||
expected: ['cli:initial'],
|
||||
},
|
||||
{
|
||||
name: 'ensures tray in background mode',
|
||||
overrides: { isBackgroundMode: () => true },
|
||||
expected: ['tray', 'cli:initial'],
|
||||
},
|
||||
{
|
||||
name: 'can ensure tray outside background mode when requested',
|
||||
overrides: { shouldEnsureTrayOnStartup: () => true },
|
||||
expected: ['tray', 'cli:initial'],
|
||||
},
|
||||
{
|
||||
name: 'auto-connects mpv for immersion tracking',
|
||||
overrides: { hasImmersionTracker: () => true, mpvClientConnected: false },
|
||||
expected: [AUTO_CONNECT_LOG, 'connect', 'cli:initial'],
|
||||
},
|
||||
{
|
||||
name: 'skips mpv auto-connect for stats mode',
|
||||
overrides: {
|
||||
getInitialArgs: () => cliArgs({ start: false, stats: true }),
|
||||
hasImmersionTracker: () => true,
|
||||
mpvClientConnected: false,
|
||||
},
|
||||
expected: ['cli:initial'],
|
||||
},
|
||||
{
|
||||
name: 'bootstraps overlay before initial overlay-runtime commands',
|
||||
overrides: {
|
||||
commandNeedsOverlayStartupPrereqs: () => true,
|
||||
commandNeedsOverlayRuntime: () => true,
|
||||
},
|
||||
expected: ['prereqs', 'init-overlay', 'cli:initial'],
|
||||
},
|
||||
{
|
||||
name: 'prepares prereqs but skips eager overlay bootstrap for youtube playback',
|
||||
overrides: {
|
||||
getInitialArgs: () => cliArgs({ youtubePlay: 'https://youtube.com/watch?v=abc' }),
|
||||
commandNeedsOverlayStartupPrereqs: () => true,
|
||||
},
|
||||
expected: ['prereqs', 'cli:initial'],
|
||||
},
|
||||
{
|
||||
name: 'skips tray, mpv auto-connect, and overlay bootstrap for headless refresh',
|
||||
overrides: {
|
||||
getInitialArgs: () => cliArgs({ start: false, refreshKnownWords: true }),
|
||||
isBackgroundMode: () => true,
|
||||
shouldEnsureTrayOnStartup: () => true,
|
||||
shouldRunHeadlessInitialCommand: () => true,
|
||||
hasImmersionTracker: () => true,
|
||||
mpvClientConnected: false,
|
||||
commandNeedsOverlayStartupPrereqs: () => true,
|
||||
commandNeedsOverlayRuntime: () => true,
|
||||
},
|
||||
expected: ['cli:initial'],
|
||||
},
|
||||
];
|
||||
|
||||
for (const c of cases) {
|
||||
test(`initial args handler ${c.name}`, () => {
|
||||
assert.deepEqual(runInitialArgs(c.overrides), c.expected);
|
||||
});
|
||||
|
||||
handleInitialArgs();
|
||||
assert.equal(handled, false);
|
||||
});
|
||||
|
||||
test('initial args handler ensures tray in background mode', () => {
|
||||
let ensuredTray = false;
|
||||
const handleInitialArgs = createHandleInitialArgsHandler({
|
||||
getInitialArgs: () => ({ start: true }) as never,
|
||||
isBackgroundMode: () => true,
|
||||
shouldEnsureTrayOnStartup: () => false,
|
||||
shouldRunHeadlessInitialCommand: () => false,
|
||||
ensureTray: () => {
|
||||
ensuredTray = true;
|
||||
},
|
||||
isTexthookerOnlyMode: () => true,
|
||||
hasImmersionTracker: () => false,
|
||||
getMpvClient: () => null,
|
||||
commandNeedsOverlayStartupPrereqs: () => false,
|
||||
commandNeedsOverlayRuntime: () => false,
|
||||
ensureOverlayStartupPrereqs: () => {},
|
||||
isOverlayRuntimeInitialized: () => false,
|
||||
initializeOverlayRuntime: () => {},
|
||||
logInfo: () => {},
|
||||
handleCliCommand: () => {},
|
||||
});
|
||||
|
||||
handleInitialArgs();
|
||||
assert.equal(ensuredTray, true);
|
||||
});
|
||||
|
||||
test('initial args handler auto-connects mpv when needed', () => {
|
||||
let connectCalls = 0;
|
||||
let logged = false;
|
||||
const handleInitialArgs = createHandleInitialArgsHandler({
|
||||
getInitialArgs: () => ({ start: true }) as never,
|
||||
isBackgroundMode: () => false,
|
||||
shouldEnsureTrayOnStartup: () => false,
|
||||
shouldRunHeadlessInitialCommand: () => false,
|
||||
ensureTray: () => {},
|
||||
isTexthookerOnlyMode: () => false,
|
||||
hasImmersionTracker: () => true,
|
||||
getMpvClient: () => ({
|
||||
connected: false,
|
||||
connect: () => {
|
||||
connectCalls += 1;
|
||||
},
|
||||
}),
|
||||
commandNeedsOverlayStartupPrereqs: () => false,
|
||||
commandNeedsOverlayRuntime: () => false,
|
||||
ensureOverlayStartupPrereqs: () => {},
|
||||
isOverlayRuntimeInitialized: () => false,
|
||||
initializeOverlayRuntime: () => {},
|
||||
logInfo: () => {
|
||||
logged = true;
|
||||
},
|
||||
handleCliCommand: () => {},
|
||||
});
|
||||
|
||||
handleInitialArgs();
|
||||
assert.equal(connectCalls, 1);
|
||||
assert.equal(logged, true);
|
||||
});
|
||||
|
||||
test('initial args handler forwards args to cli handler', () => {
|
||||
const seenSources: string[] = [];
|
||||
const handleInitialArgs = createHandleInitialArgsHandler({
|
||||
getInitialArgs: () => ({ start: true }) as never,
|
||||
isBackgroundMode: () => false,
|
||||
shouldEnsureTrayOnStartup: () => false,
|
||||
shouldRunHeadlessInitialCommand: () => false,
|
||||
ensureTray: () => {},
|
||||
isTexthookerOnlyMode: () => false,
|
||||
hasImmersionTracker: () => false,
|
||||
getMpvClient: () => null,
|
||||
commandNeedsOverlayStartupPrereqs: () => false,
|
||||
commandNeedsOverlayRuntime: () => false,
|
||||
ensureOverlayStartupPrereqs: () => {
|
||||
seenSources.push('prereqs');
|
||||
},
|
||||
isOverlayRuntimeInitialized: () => false,
|
||||
initializeOverlayRuntime: () => {
|
||||
seenSources.push('init-overlay');
|
||||
},
|
||||
logInfo: () => {},
|
||||
handleCliCommand: (_args, source) => {
|
||||
seenSources.push(source);
|
||||
},
|
||||
});
|
||||
|
||||
handleInitialArgs();
|
||||
assert.deepEqual(seenSources, ['initial']);
|
||||
});
|
||||
|
||||
test('initial args handler bootstraps overlay before initial overlay-runtime commands', () => {
|
||||
const calls: string[] = [];
|
||||
const args = { settings: true } as never;
|
||||
const handleInitialArgs = createHandleInitialArgsHandler({
|
||||
getInitialArgs: () => args,
|
||||
isBackgroundMode: () => false,
|
||||
shouldEnsureTrayOnStartup: () => false,
|
||||
shouldRunHeadlessInitialCommand: () => false,
|
||||
ensureTray: () => {},
|
||||
isTexthookerOnlyMode: () => false,
|
||||
hasImmersionTracker: () => false,
|
||||
getMpvClient: () => null,
|
||||
commandNeedsOverlayStartupPrereqs: (inputArgs) => inputArgs === args,
|
||||
commandNeedsOverlayRuntime: (inputArgs) => inputArgs === args,
|
||||
ensureOverlayStartupPrereqs: () => {
|
||||
calls.push('prereqs');
|
||||
},
|
||||
isOverlayRuntimeInitialized: () => false,
|
||||
initializeOverlayRuntime: () => {
|
||||
calls.push('init-overlay');
|
||||
},
|
||||
logInfo: () => {},
|
||||
handleCliCommand: (_args, source) => {
|
||||
calls.push(`cli:${source}`);
|
||||
},
|
||||
});
|
||||
|
||||
handleInitialArgs();
|
||||
|
||||
assert.deepEqual(calls, ['prereqs', 'init-overlay', 'cli:initial']);
|
||||
});
|
||||
|
||||
test('initial args handler prepares prereqs but skips eager overlay bootstrap for youtube playback', () => {
|
||||
const calls: string[] = [];
|
||||
const args = { youtubePlay: 'https://youtube.com/watch?v=abc' } as never;
|
||||
const handleInitialArgs = createHandleInitialArgsHandler({
|
||||
getInitialArgs: () => args,
|
||||
isBackgroundMode: () => false,
|
||||
shouldEnsureTrayOnStartup: () => false,
|
||||
shouldRunHeadlessInitialCommand: () => false,
|
||||
ensureTray: () => {},
|
||||
isTexthookerOnlyMode: () => false,
|
||||
hasImmersionTracker: () => false,
|
||||
getMpvClient: () => null,
|
||||
commandNeedsOverlayStartupPrereqs: () => true,
|
||||
commandNeedsOverlayRuntime: () => false,
|
||||
ensureOverlayStartupPrereqs: () => {
|
||||
calls.push('prereqs');
|
||||
},
|
||||
isOverlayRuntimeInitialized: () => false,
|
||||
initializeOverlayRuntime: () => {
|
||||
calls.push('init-overlay');
|
||||
},
|
||||
logInfo: () => {},
|
||||
handleCliCommand: (_args, source) => {
|
||||
calls.push(`cli:${source}`);
|
||||
},
|
||||
});
|
||||
|
||||
handleInitialArgs();
|
||||
|
||||
assert.deepEqual(calls, ['prereqs', 'cli:initial']);
|
||||
});
|
||||
|
||||
test('initial args handler can ensure tray outside background mode when requested', () => {
|
||||
let ensuredTray = false;
|
||||
const handleInitialArgs = createHandleInitialArgsHandler({
|
||||
getInitialArgs: () => ({ start: true }) as never,
|
||||
isBackgroundMode: () => false,
|
||||
shouldEnsureTrayOnStartup: () => true,
|
||||
shouldRunHeadlessInitialCommand: () => false,
|
||||
ensureTray: () => {
|
||||
ensuredTray = true;
|
||||
},
|
||||
isTexthookerOnlyMode: () => true,
|
||||
hasImmersionTracker: () => false,
|
||||
getMpvClient: () => null,
|
||||
commandNeedsOverlayStartupPrereqs: () => false,
|
||||
commandNeedsOverlayRuntime: () => false,
|
||||
ensureOverlayStartupPrereqs: () => {},
|
||||
isOverlayRuntimeInitialized: () => false,
|
||||
initializeOverlayRuntime: () => {},
|
||||
logInfo: () => {},
|
||||
handleCliCommand: () => {},
|
||||
});
|
||||
|
||||
handleInitialArgs();
|
||||
assert.equal(ensuredTray, true);
|
||||
});
|
||||
|
||||
test('initial args handler skips tray and mpv auto-connect for headless refresh', () => {
|
||||
let ensuredTray = false;
|
||||
let connectCalls = 0;
|
||||
const handleInitialArgs = createHandleInitialArgsHandler({
|
||||
getInitialArgs: () => ({ refreshKnownWords: true }) as never,
|
||||
isBackgroundMode: () => true,
|
||||
shouldEnsureTrayOnStartup: () => true,
|
||||
shouldRunHeadlessInitialCommand: () => true,
|
||||
ensureTray: () => {
|
||||
ensuredTray = true;
|
||||
},
|
||||
isTexthookerOnlyMode: () => false,
|
||||
hasImmersionTracker: () => true,
|
||||
getMpvClient: () => ({
|
||||
connected: false,
|
||||
connect: () => {
|
||||
connectCalls += 1;
|
||||
},
|
||||
}),
|
||||
commandNeedsOverlayStartupPrereqs: () => true,
|
||||
commandNeedsOverlayRuntime: () => true,
|
||||
ensureOverlayStartupPrereqs: () => {},
|
||||
isOverlayRuntimeInitialized: () => false,
|
||||
initializeOverlayRuntime: () => {},
|
||||
logInfo: () => {},
|
||||
handleCliCommand: () => {},
|
||||
});
|
||||
|
||||
handleInitialArgs();
|
||||
assert.equal(ensuredTray, false);
|
||||
assert.equal(connectCalls, 0);
|
||||
});
|
||||
}
|
||||
Reference in new issue
Block a user