sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-04-26 16:19:26 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: address PR review follow-ups

Browse Source
This commit is contained in:
Kyle Yasuda
2026-04-25 20:34:18 -07:00
parent ba48db6255
commit ac93a5bd2e
32 changed files with 345 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/character-dictionary-runtime/fetch.test.ts
View File

@@ -4,9 +4,10 @@ import test from 'node:test';
import { searchAniListMediaCandidates } from './fetch';
test('searchAniListMediaCandidates trims fallback candidate titles', async () => {
const previousFetch = globalThis.fetch;
const previousFetchDescriptor = Object.getOwnPropertyDescriptor(globalThis, 'fetch');
Object.defineProperty(globalThis, 'fetch', {
configurable: true,
writable: true,
value: async () =>
new Response(
JSON.stringify({
@@ -24,6 +25,10 @@ test('searchAniListMediaCandidates trims fallback candidate titles', async () =>
assert.equal(candidates[0]?.title, 'Re:ZERO');
} finally {
Object.defineProperty(globalThis, 'fetch', { configurable: true, value: previousFetch });
if (previousFetchDescriptor) {
Object.defineProperty(globalThis, 'fetch', previousFetchDescriptor);
} else {
Reflect.deleteProperty(globalThis, 'fetch');
}
}
});

6
src/main/character-dictionary-runtime/manual-selection.ts
View File

@@ -98,11 +98,7 @@ export function buildCharacterDictionarySeriesKey(input: {
}
export function createCharacterDictionaryManualSelectionStore(deps: { userDataPath: string }) {
const filePath = path.join(
deps.userDataPath,
'character-dictionaries',
'anilist-overrides.json',
);
const filePath = path.join(deps.userDataPath, 'character-dictionaries', 'anilist-overrides.json');
return {
getOverride: async (seriesKey: string): Promise<CharacterDictionaryManualSelection | null> => {