sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-02-27 18:22:41 -08:00
Code Issues Packages Projects Releases Wiki Activity

chore: commit unstaged workspace changes

Browse Source
This commit is contained in:
Kyle Yasuda
2026-02-21 02:32:00 -08:00
parent 1c424b4a0b
commit ab1d5f19fd
16 changed files with 780 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/subagents/INDEX.md
View File

@@ -27,6 +27,6 @@ Read first. Keep concise.
| `codex-review-refactor-cleanup-20260220T113818Z-i2ov` | `codex-review-refactor-cleanup` | `Review recent TASK-85 refactor effort and identify remaining cleanup work` | `handoff` | `docs/subagents/agents/codex-review-refactor-cleanup-20260220T113818Z-i2ov.md` | `2026-02-20T11:48:28Z` |
| `codex-commit-unstaged-20260220T115057Z-k7q2` | `codex-commit-unstaged` | `Commit all current unstaged repository changes with content-derived conventional message` | `in_progress` | `docs/subagents/agents/codex-commit-unstaged-20260220T115057Z-k7q2.md` | `2026-02-20T11:51:18Z` |
| `codex-overlay-whitespace-newline-20260221T040705Z-aw2j` | `codex-overlay-whitespace-newline` | `Fix visible overlay whitespace/newline token rendering bug with TDD regression coverage` | `completed` | `docs/subagents/agents/codex-overlay-whitespace-newline-20260221T040705Z-aw2j.md` | `2026-02-21T04:18:16Z` |
| `codex-duplicate-kiku-20260221T043006Z-5vkz` | `codex-duplicate-kiku` | `Fix Kiku duplicate-card detection/grouping regression for Yomitan duplicate-marked + N+1-highlighted cards` | `completed` | `docs/subagents/agents/codex-duplicate-kiku-20260221T043006Z-5vkz.md` | `2026-02-21T04:38:25Z` |
| `codex-duplicate-kiku-20260221T043006Z-5vkz` | `codex-duplicate-kiku` | `Fix Kiku duplicate-card detection/grouping regression for Yomitan duplicate-marked + N+1-highlighted cards` | `completed` | `docs/subagents/agents/codex-duplicate-kiku-20260221T043006Z-5vkz.md` | `2026-02-21T10:07:58Z` |
| `codex-mpv-connect-log-20260221T043748Z-q7m1` | `codex-mpv-connect-log` | `Suppress repetitive MPV IPC connect-request INFO logs during startup` | `completed` | `docs/subagents/agents/codex-mpv-connect-log-20260221T043748Z-q7m1.md` | `2026-02-21T04:41:15Z` |
| `codex-add-backlog-tasks-20260221T044104Z-m3n8` | `codex-add-backlog-tasks` | `Add two unrelated backlog tasks: secondary subtitle decoupling and intro skip` | `done` | `docs/subagents/agents/codex-add-backlog-tasks-20260221T044104Z-m3n8.md` | `2026-02-21T04:44:12Z` |

29
docs/subagents/agents/codex-add-backlog-tasks-20260221T044104Z-m3n8.md Normal file
View File

@@ -0,0 +1,29 @@
# Agent: `codex-add-backlog-tasks-20260221T044104Z-m3n8`
- alias: `codex-add-backlog-tasks`
- mission: `Add two unrelated backlog tasks requested by user`
- status: `done`
- branch: `main`
- started_at: `2026-02-21T04:41:04Z`
- heartbeat_minutes: `5`
## Current Work (newest first)
- [2026-02-21T04:44:12Z] handoff: added `TASK-96` + `TASK-97` in `backlog/tasks`; updated index row to `done`.
- [2026-02-21T04:43:00Z] progress: drafting `TASK-96` (secondary subtitle decoupling) and `TASK-97` (intro skip) under `backlog/tasks`.
- [2026-02-21T04:42:10Z] intent: add two unrelated backlog tasks only; no code behavior changes.
## Files Touched
- `docs/subagents/INDEX.md`
- `docs/subagents/agents/codex-add-backlog-tasks-20260221T044104Z-m3n8.md`
- `backlog/tasks/task-96 - Decouple-secondary-subtitle-lifecycle-from-visible-invisible-overlays.md`
- `backlog/tasks/task-97 - Add-intro-skip-playback-control.md`
## Assumptions
- User request means creating backlog tickets, not implementing either feature now.
- Existing backlog format in `backlog/tasks` remains canonical.
## Open Questions / Blockers
- None.
## Next Step
- Wait for user follow-up (prioritize one of the two new tasks for implementation).

74
docs/subagents/agents/codex-duplicate-kiku-20260221T043006Z-5vkz.md Normal file
View File

@@ -0,0 +1,74 @@
# codex-duplicate-kiku-20260221T043006Z-5vkz
- alias: `codex-duplicate-kiku`
- mission: `Fix Kiku duplicate-card detection/grouping regression for Yomitan duplicate-marked + N+1-highlighted cards`
- status: `completed`
- start_utc: `2026-02-21T04:30:06Z`
- last_update_utc: `2026-02-21T10:07:58Z`
## Intent
- Reproduce bug where clear duplicate cards no longer trigger Kiku duplicate grouping.
- Add failing regression test first (TDD).
- Patch duplicate detection logic with minimal behavior change.
## Planned Files
- `src/anki-integration/duplicate.ts`
- `src/anki-integration/duplicate.test.ts` (or nearest duplicate-detection tests)
- `docs/subagents/INDEX.md`
- `docs/subagents/collaboration.md`
- `backlog/tasks/task-94 - Fix-Kiku-duplicate-detection-for-Yomitan-marked-duplicates.md`
## Assumptions
- Duplicate signal should still come from Anki duplicate search + Yomitan/N+1-derived fields used in note content.
- Regression likely from term/readings normalization/query escaping mismatch.
## Outcome
- Root cause: candidate-note exact-check only resolved the originating field name (`Expression` or `Word`), so duplicates failed when candidate note used the opposite alias.
- Added regression test first (RED): `Expression` current note vs `Word` candidate with same value returned `null`.
- Implemented minimal fix: candidate resolution now checks both aliases (`word` and `expression`) before exact-value compare.
- GREEN: targeted duplicate test passed; related `anki-integration` test passed.
- User follow-up repro showed remaining miss when duplicate appears only in alias field search results.
- Added second RED test for alias-query fallback.
- Implemented query-stage alias fallback: run `findNotes` for both alias fields, merge note ids, then exact-verify.
- GREEN after follow-up: duplicate tests + `anki-integration` test pass.
- User reported still failing after first follow-up.
- Added third RED regression: source note containing both `Expression` (sentence) and `Word` (term) only matched duplicates via `Word`; previous logic missed this by using only one source value.
- Implemented source-candidate expansion: gather both `Word` and `Expression` source values, query aliases for each, dedupe queries, then exact-match against normalized set.
- GREEN: duplicate tests (3/3) + `anki-integration` test pass.
- Image-backed repro indicated possible duplicate outside configured deck scope.
- Added fourth RED regression: deck-scoped query misses, collection-wide query should still detect duplicate.
- Implemented deck fallback query pass (same source/alias combinations without deck filter) when deck-scoped pass yields no candidates.
- GREEN: duplicate tests (4/4) + `anki-integration` test pass.
- User confirmed fresh build/install still failed with `貴様` repro.
- Added fifth RED regression: field-specific queries return no matches but plain text query returns candidate.
- Implemented plain-text query fallback pass (deck-scoped then global), still gated by exact `word`/`expression` value verify.
- GREEN: duplicate tests (5/5) + `anki-integration` test pass.
- Added runtime debug instrumentation for duplicate detection query/verification path:
- query string + hit count
- candidate count after exclude
- exact-match note id + field
- No behavior change from instrumentation; build + tests still green.
- User requested logging policy update: prefer console output unless explicitly captured, and persistent logs under `~/.config/SubMiner/logs/*.log`.
- Updated default launcher/app mpv log path to daily file naming: `~/.config/SubMiner/logs/SubMiner-YYYY-MM-DD.log`.
- Typecheck green.
- Found observability gap: app logger wrote only to stdout/stderr while launcher log file only captured wrapper messages.
- Added file sink to `src/logger.ts` so app logs also append to `~/.config/SubMiner/logs/SubMiner-YYYY-MM-DD.log` (or `SUBMINER_MPV_LOG` when set).
- Verified with typecheck + build.
## Files Touched
- `src/anki-integration/duplicate.ts`
- `src/anki-integration/duplicate.test.ts`
- `backlog/tasks/task-94 - Fix-Kiku-duplicate-detection-for-Yomitan-marked-duplicates.md`
- `docs/subagents/INDEX.md`
- `docs/subagents/collaboration.md`
- `docs/subagents/agents/codex-duplicate-kiku-20260221T043006Z-5vkz.md`
## Handoff
- No blockers.
- Next step: run broader gate (`bun run test:fast`) when ready, then commit.

28
docs/subagents/agents/codex-frequency-dup-log-20260221T042815Z-r4k1.md Normal file
View File

@@ -0,0 +1,28 @@
# Agent Log: codex-frequency-dup-log-20260221T042815Z-r4k1
- alias: codex-frequency-dup-log
- mission: reduce frequency dictionary duplicate-term startup log spam; keep useful signal
- status: completed
- started_utc: 2026-02-21T04:28:15Z
- last_update_utc: 2026-02-21T04:32:40Z
- planned_files:
- src/core/services/frequency-dictionary.ts
- src/core/services/frequency-dictionary.test.ts
- docs/subagents/INDEX.md
- touched_files:
- src/core/services/frequency-dictionary.ts
- src/core/services/frequency-dictionary.test.ts
- docs/subagents/agents/codex-frequency-dup-log-20260221T042815Z-r4k1.md
- docs/subagents/INDEX.md
- key_decisions:
- remove per-entry duplicate term logs
- keep one aggregate duplicate summary line per bank file at info level
- assumptions:
- duplicate entries are expected in source dictionary and should not produce per-entry info logs
- verification:
- `bun test src/core/services/frequency-dictionary.test.ts` (pass)
- full build currently blocked by unrelated Jellyfin WIP type errors on branch
- blockers:
- unrelated branch state prevents full `bun run build`
- next_step:
- optional follow-up: add true debug-level logging API if duplicate diagnostics are needed on demand

6
docs/subagents/collaboration.md
View File

@@ -25,5 +25,11 @@ Shared notes. Append-only.
- [2026-02-21T04:30:06Z] [codex-duplicate-kiku-20260221T043006Z-5vkz|codex-duplicate-kiku] investigating Kiku duplicate grouping regression; expecting touches in `src/anki-integration/duplicate.ts` and duplicate-detection tests only.
- [2026-02-21T04:33:17Z] [codex-duplicate-kiku-20260221T043006Z-5vkz|codex-duplicate-kiku] completed TASK-94: duplicate check now resolves `word`/`expression` alias fields when validating candidate notes; added regression test `src/anki-integration/duplicate.test.ts`; targeted build + duplicate/anki-integration tests passed.
- [2026-02-21T04:38:25Z] [codex-duplicate-kiku-20260221T043006Z-5vkz|codex-duplicate-kiku] follow-up repro fixed: duplicate search now queries both alias fields (`word` + `expression`) and unions note ids before exact compare; added second regression test for alias-query fallback.
- [2026-02-21T04:48:50Z] [codex-duplicate-kiku-20260221T043006Z-5vkz|codex-duplicate-kiku] second follow-up fix: when source note has both `Expression` and `Word`, duplicate detection now uses both source values (not just first field by order); added regression for mixed-field source candidate scenario.
- [2026-02-21T07:23:56Z] [codex-duplicate-kiku-20260221T043006Z-5vkz|codex-duplicate-kiku] third follow-up fix: add collection-wide fallback query pass when deck-scoped duplicate search returns no candidates; added regression for deck-scope miss case.
- [2026-02-21T09:25:53Z] [codex-duplicate-kiku-20260221T043006Z-5vkz|codex-duplicate-kiku] fourth follow-up fix: add plain-text query fallback when field-scoped queries miss; keep exact value verification on candidate notes to avoid false positives.
- [2026-02-21T09:40:33Z] [codex-duplicate-kiku-20260221T043006Z-5vkz|codex-duplicate-kiku] instrumentation pass: add duplicate-detection debug logs (`[duplicate] query/hits/candidates/exact-match`) to isolate remaining live repro mismatches.
- [2026-02-21T09:54:29Z] [codex-duplicate-kiku-20260221T043006Z-5vkz|codex-duplicate-kiku] logging-path update: default persistent logs now target `~/.config/SubMiner/logs/SubMiner-YYYY-MM-DD.log` (launcher + app mpv log default).
- [2026-02-21T10:07:58Z] [codex-duplicate-kiku-20260221T043006Z-5vkz|codex-duplicate-kiku] observability fix: app logger now also appends to daily log file, so runtime duplicate traces are available even when overlay stdout is not surfaced in launcher terminal.
- [2026-02-21T04:37:48Z] [codex-mpv-connect-log-20260221T043748Z-q7m1|codex-mpv-connect-log] overlap note: touching `src/core/services/mpv.ts` + mpv service tests for startup connection-request log level gating; coordinating with historical TASK-33 behavior (same symptom, new logger path).
- [2026-02-21T04:41:15Z] [codex-mpv-connect-log-20260221T043748Z-q7m1|codex-mpv-connect-log] completed TASK-95: changed `MpvIpcClient.connect()` connect-request line to `logger.debug`, added regression tests for info/debug level log behavior in `src/core/services/mpv.test.ts`; verified via `bun run build && node dist/core/services/mpv.test.js` (pass).