sudacode/SubMiner
1
0
Fork 0
mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-03-01 06:22:44 -08:00
Code Issues Packages Projects Releases Wiki Activity

fix: simplify mpv sub-visibility suppression and gate yomitan sync state

Browse Source
This commit is contained in:
Kyle Yasuda
2026-02-27 23:18:57 -08:00
parent 3f1702b0f6
commit 9e0c5e478e
3 changed files with 1 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/services/mpv-protocol.test.ts
View File

@@ -133,12 +133,6 @@ test('dispatchMpvProtocolMessage enforces sub-visibility hidden when overlay sup
{ {
command: ['set_property', 'sub-visibility', false], command: ['set_property', 'sub-visibility', false],
}, },
{
command: ['set_property', 'sub-visibility', 'no'],
},
{
command: ['set', 'sub-visibility', 'no'],
},
]); ]);
}); });

2
src/core/services/mpv-protocol.ts
View File

@@ -219,8 +219,6 @@ export async function dispatchMpvProtocolMessage(
} else if (msg.name === 'sub-visibility') { } else if (msg.name === 'sub-visibility') {
if (deps.isVisibleOverlayVisible() && asBoolean(msg.data, false)) { if (deps.isVisibleOverlayVisible() && asBoolean(msg.data, false)) {
deps.sendCommand({ command: ['set_property', 'sub-visibility', false] }); deps.sendCommand({ command: ['set_property', 'sub-visibility', false] });
deps.sendCommand({ command: ['set_property', 'sub-visibility', 'no'] });
deps.sendCommand({ command: ['set', 'sub-visibility', 'no'] });
} }
} else if (msg.name === 'sub-use-margins') { } else if (msg.name === 'sub-use-margins') {
deps.emitSubtitleMetricsChange({ deps.emitSubtitleMetricsChange({

2
src/main.ts
View File

@@ -2510,8 +2510,8 @@ async function syncYomitanDefaultProfileAnkiServer(): Promise<void> {
if (updated) { if (updated) {
logger.info(`Yomitan default profile Anki server set to ${targetUrl}`); logger.info(`Yomitan default profile Anki server set to ${targetUrl}`);
lastSyncedYomitanAnkiServer = targetUrl;
} }
lastSyncedYomitanAnkiServer = targetUrl;
} }
function createOverlayWindow(kind: 'visible' | 'modal'): BrowserWindow { function createOverlayWindow(kind: 'visible' | 'modal'): BrowserWindow {